Re: post-review new files with Perforce
Hi Ben,
I'm going through a backlog of e-mail I missed.
If you upgrade to the latest RBTools release, this should be fixed.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Sep 14, 2011 at 12:17 PM, Ben benbe...@gmail.com wrote:
I am having a problem using ReviewBoard 1.6 with Perforce. When I run
post-review for a changelist with new files, I get an error while
posting the diffs. (post-review debug trace below). I have tried
uploading the diffs manually after generating them with post-review,
but I just get malformed patch errors on the server. This looks like
Issue 2054 to me, and I posted my information there.
Does anyone have this working or know of a workaround?
-Ben
RBTools 0.3.3
Home = C:\Users\ben\AppData\Roaming
p4 info
repository info: Path: lenel-sourceold.windows.lenel.com:1666, Base
path: None, Supports changesets: True
p4 counters
HTTP GETting api/
HTTP GETting http://10.112.8.55/api/info/
Using the new web API
Generating diff for changenum 206994
p4 describe -s 206994
Processing edit of //Development/Path/To/My/src/Solution.sln
Writing //Development/Path/To/My/src/Solution.sln#10
to c:\users\ben\appdata\local\temp\tmp5eiypf
p4 print -o c:\users\ben\appdata\local\temp\tmp5eiypf -q
//Development/Path/To/My/src/Solution.sln#10
diff -urNp c:\users\ben\appdata\local\temp\tmp5eiypf
D:/Development\Path\To\My\src\Solution.sln
Processing add of
//Development/OnGuard/Branches/Titan/DotNet/src/TwoFlower/app.config
diff -urNp c:\users\ben\appdata\local\temp\tmporoe81
D:/Development\Path\To\My\src\TwoFlower\app.config
Processing add of
//Development/Path/To/My/src/TwoFlower/PrincipalExt.cs
diff -urNp c:\users\ben\appdata\local\temp\tmporoe81
D:/Development\Path\To\My\src\TwoFlower\Principal.cs
Processing add of //Development/Path/To/My/src/TwoFlower/Program.cs
diff -urNp c:\users\ben\appdata\local\temp\tmporoe81
D:/Development\Path\To\My\src\TwoFlower\Program.cs
Processing add of
//Development/Path/To/My/src/TwoFlower/Properties/AssemblyInfo.cs
diff -urNp c:\users\ben\appdata\local\temp\tmporoe81
D:/Development\Path\To\My\src\TwoFlower\Properties\AssemblyInfo.cs
Processing add of
//Development/Path/To/My/src/TwoFlower/TwoFlower.csproj
diff -urNp c:\users\ben\appdata\local\temp\tmporoe81
D:/Development\Path\To\My\src\TwoFlower\TwoFlower.csproj
Processing add of
//Development/Path/To/My/src/TwoFlower/WrappedServer.cs
diff -urNp c:\users\ben\appdata\local\temp\tmporoe81
D:/Development\Path\To\My\src\TwoFlower\WrappedServer.cs
Attempting to create review request on
lenel-sourceold.windows.lenel.com:1666 for 206994
HTTP POSTing to http://10.112.8.55/api/review-requests/:
{'changenum': '206994', 'repository': '
lenel-sourceold.windows.lenel.com:1666'}
Got API Error 204 (HTTP code 409): The change number specified has
already been used
Error data: {u'stat': u'fail', u'review_request': {u'status':
u'pending', u'last_updated': u'2011-09-13 17:28:43', u'description':
u'Test rig for using two embedded application servers\n', u'links':
{u'diffs': {u'href':
u'http://10.112.8.55/api/review-requests/5/diffs/', u'method':
u'GET'},
u'repository': {u'href': u'http://10.112.8.55/api/repositories/2/',
u'method': u'GET', u'title': u'Old OnGuard Repository'}, u'changes':
{u'href': u'http://10.112.8.55/api/review-requests/5/changes/',
u'method': u'GET'}, u'self': {u'href':
u'http://10.112.8.55/api/review-requests/5/', u'method': u'GET'},
u'update': {u'href': u'http://10.112.8.55/api/review-requests/5/',
u'method': u'PUT'}, u'last_update': {u'href':
u'http://10.112.8.55/api/review-requests/5/last-update/', u'method':
u'GET'}, u'reviews': {u'href':
u'http://10.112.8.55/api/review-requests/5/reviews/', u'method':
u'GET'}, u'draft': {u'href':
u'http://10.112.8.55/api/review-requests/5/draft/',u'method': u'GET'},
u'file_attachments': {u'href':
u'http://10.112.8.55/api/review-requests/5/file-attachments/',
u'method': u'GET'}, u'submitter': {u'href':
u'http://10.112.8.55/api/users/ben/', u'method': u'GET', u'title':
u'ben'},u'screenshots': {u'href':
u'http://10.112.8.55/api/review-requests/5/screenshots/', u'method':
u'GET'}, u'delete': {u'href':
u'http://10.112.8.55/api/review-requests/5/', u'method': u'DELETE'}},
u'target_groups': [], u'bugs_closed': [], u'changenum': 206994,
u'target_people': [], u'testing_done': u'', u'branch': u'', u'id': 5,
u'time_added': u'2011-09-13 17:28:43', u'summary': u'Test rig for using
two embedded application servers', u'public': False}, u'err': {u'msg':
u'The change number specified has already been used', u'code': 204}}
Review request already exists. Updating it...
HTTP PUTting to http://10.112.8.55/api/review-requests/5/:
{'changenum': 206994}
Uploading diff, size: 16111
HTTP POSTing to
Re: Error of post-review: The current directory does not contain a checkout from a supported source code repository.
Haa, I found the problem caused by svn client. I use TortoiseSVN as my svn client in Windows, but it seems post-review could not communicate with svn server through TortoiseSVN. I installed command line svn, the problem solved. Thanks for you help! On Sep 28, 1:46 pm, Christian Hammond chip...@chipx86.com wrote: To determine if you're in a valid checkout, we run svn info and look for the text Repository Root. What do you see when you type that? If the output is localized, that's the problem, though we already try to force it to be English. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com 2011/9/27 James Tang tzl...@gmail.com But the problem is I already tried post-review in checkout svn directory(which contains a .svn folder), it still give me same words. How to solve this? Isn't post-review support windows7? On 9月27日, 下午4时24分, Christian Hammond chip...@chipx86.com wrote: Home has nothing to do with the checks. That's just for our own usage. You need to run post-review from within an SVN, CVS, Git, etc. checkout directory. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Sep 26, 2011 at 10:52 PM, James Tang tzl...@gmail.com wrote: I run post-review in command line in Windows, below is the result: C:\Users\XXXpost-review -d RBTools 0.3.3 Home = C:\Users\Tang\AppData\Roaming The current directory does not contain a checkout from a supported source code repository. It seems post-review will search the user data folder for the checkout source code directory. How to change the Home setting? Or how to solve the problem if I put the checkout source code under C:\Users \XXX? Thanks. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Can I do post-commite review on the website (without post-review tool)?
I think the post-review tool is a very nice tool for pre-commite reivew with reviewboard. But if I just want to do a post-commite review on my PC, where doesn't install svn client, what should I do? I ask so because I ever seen such a system, so I think I should not be a technical problem, right? Best regards. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Can I do post-commite review on the website (without post-review tool)?
Hi James, The options we provide today are to use either post-review with --revision-range, or just generate a diff with svn diff. Ideally there'd be a web UI for this built into Review Board. We had someone working on one at one point, but the project sort of didn't pan out. We'll likely work toward it again sometime in the future, but not right away. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Sep 28, 2011 at 2:17 AM, James Tang tzl...@gmail.com wrote: I think the post-review tool is a very nice tool for pre-commite reivew with reviewboard. But if I just want to do a post-commite review on my PC, where doesn't install svn client, what should I do? I ask so because I ever seen such a system, so I think I should not be a technical problem, right? Best regards. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
metric collection - number of comments
Hi, Is there any way one can collect some basic kind of metrics, e.g number of comments for a review in reviewboard? Regards, Gyanesh -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: API LDAP Authentiaction
This is on Apache on FastCGI. There's a weird issue with us hosting
WSGI because the server is running an older version of Ubuntu
(something we should correct, but can't at the moment).
On Sep 27, 5:48 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Jeff,
Thanks for sending me that info.
So this actually has nothing to do with LDAP. I've seen this before once, on
Python 2.7 only. My guess is there's something that prevented the right
headers from reaching the server. Some sort of regression on their end (we
already know they broke uploading of binary content).
First off, can you let me know whether you're using the dev server, or
Apache? If Apache, is it mod_wsgi? And if so, is there a
WSGIPassAuthorization On line in the config?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, Sep 27, 2011 at 11:02 AM, Jeff Ward j...@fuzzybinary.com wrote:
Yes this is using post-review as the client. Here's the output when I
disable anonymous reads:
C:\Python27\Scripts\post-review --server=http://server:--debug --
repository=repo_name
RBTools 0.3.3
Home = redacted
hg showconfig
hg root
p4 info
repository info: Path: redacted, Base path: None, Supports
changesets: True
HTTP GETting api/
HTTP GETtinghttp://server:/api/info/
== HTTP Authentication Required
Enter authorization information for Web API at server:
Username: jeffw
Password:
Got API Error 103 (HTTP code 401): You are not logged in
Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not logged
in', u'code': 103}}
Using the deprecated Review Board 1.0 web API
Generating diff for changenum default
p4 opened -c default
Processing edit of redacted
Writing redacted to redacted
p4 print -o redacted -q redacted
diff -urNp redacted redacted
Traceback (most recent call last):
File C:\Python27\Scripts\post-review-script.py, line 8, in
module
load_entry_point('rbtools==0.3.3', 'console_scripts', 'post-
review')()
File C:\Python27\lib\site-packages\rbtools-0.3.3-py2.7.egg\rbtools
\postreview.py, line 3988, in main
AttributeError: 'ReviewBoardServer' object has no attribute
'rb_version'
/api doesn't require auth in this scenereo, but /api/info does. I can
not log in to /api/info from a web browser in this situation either.
If I turn on anonymous read I get this:
RBTools 0.3.3
Home = redacted
hg showconfig
hg root
p4 info
repository info: Path: redacted, Base path: None, Supports
changesets: True
HTTP GETting api/
HTTP GETtinghttp://server:/api/info/
Using the new web API
Generating diff for changenum default
p4 opened -c default
Processing edit of redacted
Writing redacted to redacted
p4 print -o redacted -q redacted
diff -urNp redacted redacted
Attempting to create review request on repo_name for None
HTTP POSTing tohttp://server:/api/review-requests/:
{'repository': 'repo_name'}
== HTTP Authentication Required
Enter authorization information for Web API at server:
Username: jeffw
Password:
Got API Error 103 (HTTP code 401): You are not logged in
Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not logged
in', u'code': 103}}
Attempting to create review request on repo_name for None
HTTP POSTing tohttp://server:/api/review-requests/:
{'repository': 'repo_name'}
Got API Error 103 (HTTP code 401): You are not logged in
Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not logged
in', u'code': 103}}
Attempting to create review request on repo_name for None
HTTP POSTing tohttp://server:/api/review-requests/:
{'repository': 'repo_name'}
Got API Error 103 (HTTP code 401): You are not logged in
Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not logged
in', u'code': 103}}
Attempting to create review request on repo_name for None
HTTP POSTing tohttp://server:/api/review-requests/:
{'repository': 'repo_name'}
Got API Error 103 (HTTP code 401): You are not logged in
Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not logged
in', u'code': 103}}
Error creating review request: You are not logged in (HTTP 401, API
Error 103)
My LDAP does not allow anonymous binds, which I think may be the
issue. Authentication from the main page works though, and since both
are supposed to go through the same code path, I have no idea what's
killing the API auth.
--
Jeff
On Sep 26, 4:12 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Jeff,
Sorry for the late reply.
Our authentication for both the web UI and API go through the same place.
However, you may be hitting other bugs.
Is this using post-review as the client? Can you run with --debug and
show
me the output?
I'm curious what's prompting for a password on /api/, because we don't
Re: Make svn commit via reviewboard UI
Review Board never writes to your repository. Developers still have to commit code using 'svn commit' -David On Wed, Sep 28, 2011 at 10:24 AM, Bing Hua jasoninelmstr...@gmail.com wrote: Hi, I've set up reviewboard and trying to use it on a small project. The question is, is there a way to commit changes to svn repository via reviewboard UI? Thanks, Bing -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: metric collection - number of comments
There's nothing built-in. If you only care about simple counts, you could probably write something using the REST API pretty easily. -David On Wed, Sep 28, 2011 at 7:29 AM, Gyanesh Singh gyanesh.si...@gmail.com wrote: Hi, Is there any way one can collect some basic kind of metrics, e.g number of comments for a review in reviewboard? Regards, Gyanesh -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: metric collection - number of comments
Hi David, Thank you for the quick response. Just wanted to check in this group, if someone has something similar. Regards, Gyanesh On Wed, Sep 28, 2011 at 11:01 PM, David Trowbridge trowb...@gmail.comwrote: There's nothing built-in. If you only care about simple counts, you could probably write something using the REST API pretty easily. -David On Wed, Sep 28, 2011 at 7:29 AM, Gyanesh Singh gyanesh.si...@gmail.com wrote: Hi, Is there any way one can collect some basic kind of metrics, e.g number of comments for a review in reviewboard? Regards, Gyanesh -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: API LDAP Authentiaction
Can you tell me exactly which versions of ReviewBoard and Djblets are
installed, and what version of Python is being used on the server? I can
build you some packages with extended debug info to help figure out where
auth is getting stuck.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Sep 28, 2011 at 7:12 AM, Jeff Ward j...@fuzzybinary.com wrote:
This is on Apache on FastCGI. There's a weird issue with us hosting
WSGI because the server is running an older version of Ubuntu
(something we should correct, but can't at the moment).
On Sep 27, 5:48 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Jeff,
Thanks for sending me that info.
So this actually has nothing to do with LDAP. I've seen this before once,
on
Python 2.7 only. My guess is there's something that prevented the right
headers from reaching the server. Some sort of regression on their end
(we
already know they broke uploading of binary content).
First off, can you let me know whether you're using the dev server, or
Apache? If Apache, is it mod_wsgi? And if so, is there a
WSGIPassAuthorization On line in the config?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, Sep 27, 2011 at 11:02 AM, Jeff Ward j...@fuzzybinary.com
wrote:
Yes this is using post-review as the client. Here's the output when I
disable anonymous reads:
C:\Python27\Scripts\post-review --server=http://server:--debug --
repository=repo_name
RBTools 0.3.3
Home = redacted
hg showconfig
hg root
p4 info
repository info: Path: redacted, Base path: None, Supports
changesets: True
HTTP GETting api/
HTTP GETtinghttp://server:/api/info/
== HTTP Authentication Required
Enter authorization information for Web API at server:
Username: jeffw
Password:
Got API Error 103 (HTTP code 401): You are not logged in
Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not
logged
in', u'code': 103}}
Using the deprecated Review Board 1.0 web API
Generating diff for changenum default
p4 opened -c default
Processing edit of redacted
Writing redacted to redacted
p4 print -o redacted -q redacted
diff -urNp redacted redacted
Traceback (most recent call last):
File C:\Python27\Scripts\post-review-script.py, line 8, in
module
load_entry_point('rbtools==0.3.3', 'console_scripts', 'post-
review')()
File C:\Python27\lib\site-packages\rbtools-0.3.3-py2.7.egg\rbtools
\postreview.py, line 3988, in main
AttributeError: 'ReviewBoardServer' object has no attribute
'rb_version'
/api doesn't require auth in this scenereo, but /api/info does. I can
not log in to /api/info from a web browser in this situation either.
If I turn on anonymous read I get this:
RBTools 0.3.3
Home = redacted
hg showconfig
hg root
p4 info
repository info: Path: redacted, Base path: None, Supports
changesets: True
HTTP GETting api/
HTTP GETtinghttp://server:/api/info/
Using the new web API
Generating diff for changenum default
p4 opened -c default
Processing edit of redacted
Writing redacted to redacted
p4 print -o redacted -q redacted
diff -urNp redacted redacted
Attempting to create review request on repo_name for None
HTTP POSTing tohttp://server:/api/review-requests/:
{'repository': 'repo_name'}
== HTTP Authentication Required
Enter authorization information for Web API at server:
Username: jeffw
Password:
Got API Error 103 (HTTP code 401): You are not logged in
Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not
logged
in', u'code': 103}}
Attempting to create review request on repo_name for None
HTTP POSTing tohttp://server:/api/review-requests/:
{'repository': 'repo_name'}
Got API Error 103 (HTTP code 401): You are not logged in
Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not
logged
in', u'code': 103}}
Attempting to create review request on repo_name for None
HTTP POSTing tohttp://server:/api/review-requests/:
{'repository': 'repo_name'}
Got API Error 103 (HTTP code 401): You are not logged in
Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not
logged
in', u'code': 103}}
Attempting to create review request on repo_name for None
HTTP POSTing tohttp://server:/api/review-requests/:
{'repository': 'repo_name'}
Got API Error 103 (HTTP code 401): You are not logged in
Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not
logged
in', u'code': 103}}
Error creating review request: You are not logged in (HTTP 401, API
Error 103)
My LDAP does not allow anonymous binds, which I think may be the
issue.
Re: API LDAP Authentiaction
Hey Christian,
Server is using Python 2.5.2, client is using 2.7.1
RB is 1.6.1-py2.5
Djblets is 0.6.11-py2.5
Having some extra debug info might be helpful. You can send any built
packages to this email if you'd like.
Thanks for all your help!
--
Jeff
On Sep 28, 4:17 pm, Christian Hammond chip...@chipx86.com wrote:
Can you tell me exactly which versions of ReviewBoard and Djblets are
installed, and what version of Python is being used on the server? I can
build you some packages with extended debug info to help figure out where
auth is getting stuck.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Wed, Sep 28, 2011 at 7:12 AM, Jeff Ward j...@fuzzybinary.com wrote:
This is on Apache on FastCGI. There's a weird issue with us hosting
WSGI because the server is running an older version of Ubuntu
(something we should correct, but can't at the moment).
On Sep 27, 5:48 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Jeff,
Thanks for sending me that info.
So this actually has nothing to do with LDAP. I've seen this before once,
on
Python 2.7 only. My guess is there's something that prevented the right
headers from reaching the server. Some sort of regression on their end
(we
already know they broke uploading of binary content).
First off, can you let me know whether you're using the dev server, or
Apache? If Apache, is it mod_wsgi? And if so, is there a
WSGIPassAuthorization On line in the config?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, Sep 27, 2011 at 11:02 AM, Jeff Ward j...@fuzzybinary.com
wrote:
Yes this is using post-review as the client. Here's the output when I
disable anonymous reads:
C:\Python27\Scripts\post-review --server=http://server:--debug--
repository=repo_name
RBTools 0.3.3
Home = redacted
hg showconfig
hg root
p4 info
repository info: Path: redacted, Base path: None, Supports
changesets: True
HTTP GETting api/
HTTP GETtinghttp://server:/api/info/
== HTTP Authentication Required
Enter authorization information for Web API at server:
Username: jeffw
Password:
Got API Error 103 (HTTP code 401): You are not logged in
Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not
logged
in', u'code': 103}}
Using the deprecated Review Board 1.0 web API
Generating diff for changenum default
p4 opened -c default
Processing edit of redacted
Writing redacted to redacted
p4 print -o redacted -q redacted
diff -urNp redacted redacted
Traceback (most recent call last):
File C:\Python27\Scripts\post-review-script.py, line 8, in
module
load_entry_point('rbtools==0.3.3', 'console_scripts', 'post-
review')()
File C:\Python27\lib\site-packages\rbtools-0.3.3-py2.7.egg\rbtools
\postreview.py, line 3988, in main
AttributeError: 'ReviewBoardServer' object has no attribute
'rb_version'
/api doesn't require auth in this scenereo, but /api/info does. I can
not log in to /api/info from a web browser in this situation either.
If I turn on anonymous read I get this:
RBTools 0.3.3
Home = redacted
hg showconfig
hg root
p4 info
repository info: Path: redacted, Base path: None, Supports
changesets: True
HTTP GETting api/
HTTP GETtinghttp://server:/api/info/
Using the new web API
Generating diff for changenum default
p4 opened -c default
Processing edit of redacted
Writing redacted to redacted
p4 print -o redacted -q redacted
diff -urNp redacted redacted
Attempting to create review request on repo_name for None
HTTP POSTing tohttp://server:/api/review-requests/:
{'repository': 'repo_name'}
== HTTP Authentication Required
Enter authorization information for Web API at server:
Username: jeffw
Password:
Got API Error 103 (HTTP code 401): You are not logged in
Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not
logged
in', u'code': 103}}
Attempting to create review request on repo_name for None
HTTP POSTing tohttp://server:/api/review-requests/:
{'repository': 'repo_name'}
Got API Error 103 (HTTP code 401): You are not logged in
Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not
logged
in', u'code': 103}}
Attempting to create review request on repo_name for None
HTTP POSTing tohttp://server:/api/review-requests/:
{'repository': 'repo_name'}
Got API Error 103 (HTTP code 401): You are not logged in
Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not
logged
in', u'code': 103}}
Attempting to create review request on repo_name for None
Re: RBTools 0.3.4 released
On Mon, 2011-09-26 at 21:27 -0700, Christian Hammond wrote: Hey everyone, RBTools 0.3.4 is released. It's a small bug fix release, which may be useful to those using Git, RBCommons, or Python 2.7. See http://www.reviewboard.org/news/2011/09/26/rbtools-034-released/ for more information. RBTools 0.3.4 is now available in the Fedora and EPEL testing repositories. If you are using RBTools on one of these platforms, please install them using yum update --enablerepo=updates-testing RBTools (substituting epel-testing if appropriate). If it works for you, please leave feedback at https://admin.fedoraproject.org/updates/search/RBTools (The yum mirrors may take a day or two to pick up the new packages) -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Issue 2310 in reviewboard: git diff is invalid when using --parent option
Comment #2 on issue 2310 by bfo...@gmail.com: git diff is invalid when using --parent option http://code.google.com/p/reviewboard/issues/detail?id=2310 Maybe it's a feature actually. I didn't really check the git tree before fixing it. It was part of a fix to support bare repositories and more revision range in post-review (d7ec4f48 in master). So, should the bug Fanny is encountering be called a feature? Anyway, it seems that what she used to do seems to work fine using --revision-range=HEAD^:HEAD. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2259 in reviewboard: Replying to a comment on a review breaks the js popup on IE8
Comment #1 on issue 2259 by atiannic...@gmail.com: Replying to a comment on a review breaks the js popup on IE8 http://code.google.com/p/reviewboard/issues/detail?id=2259 Is there any work around for this? Many of the people on our team use IE and it appears to be an issue for them. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2310 in reviewboard: git diff is invalid when using --parent option
Updates: Status: NotABug Labels: Component-RBTools Comment #3 on issue 2310 by chip...@gmail.com: git diff is invalid when using --parent option http://code.google.com/p/reviewboard/issues/detail?id=2310 Yeah, a single revision actually wasn't supported before. It was working but that wasn't the intended behavior. What we have now is correct. Might take some getting used to though. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
