View Diff has issue in 1.7.2, and fine in 1.7.1
Hi,
I am using Review Board 1.7.2 on Windows 7 with repository on Clearcase,
and found the view diff page doesn't render correctly.
if I upload several changed files in one diff by post-review, say more than
2 files, only 2 files' diff could display, and only can add comment for the
first one diff.
after some diagnose, I found the cause is in Line 15 of reviews.js, 'new RB.
CommentIssueManager({' will cause Uncaught TypeError
var gCommentIssueManager = new RB.CommentIssueManager({
Seems like the refactor of reviews.js in 1.7.2 by moving related code to
commentIssueManagerModel.js caused this problem, while 1.7.1 works just
fine.
As not so familiar with javascript, I can only find out the cause, don't
know how to fix.
Hope this also could be fixed in next Review Board release.
Thanks!
Tao Zhou
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Accessing reviewboard using https
Hi All, We have reviewboard setup and working smoothly with http, but now due to some security reason we need to configure https to access reviewboard. I checked google knowledge base but could not find any useful. Can you please help me with the steps i need to perform to make reviewbaord work with https. Thanks in advance. Regards, Nilesh -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Accessing reviewboard using https
On 2013-01-25 08:25, Nilesh Jaiswal wrote: We have reviewboard setup and working smoothly with http, but now due to some security reason we need to configure https to access reviewboard. I checked google knowledge base but could not find any useful. Can you please help me with the steps i need to perform to make reviewbaord work with https. You probably won't find any documentation about RB + https because there is no need. RB doesn't care; just set up your web server to use https. You shouldn't need to do anything special with RB. I'm using https with apache... it's pretty easy; just get basic ssl working and - if needed - disable regular http. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Issue 2877 in reviewboard: post-review no longer supports git 1.6
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2877 by jczork...@gmail.com: post-review no longer supports git
1.6
http://code.google.com/p/reviewboard/issues/detail?id=2877
* NOTE: For customer support, please post to *
* reviewbo...@googlegroups.com *
**
* Do not post confidential information in this bug report. *
* If you need immediate support, please contact*
* reviewbo...@googlegroups.com *
What version are you running?
RBTools 0.4.2
What's the URL of the page containing the problem?
n/a
What steps will reproduce the problem?
1. run post-review in a git repository on a system with git 1.6
2. see stacktrace
What is the expected output? What do you see instead?
A review should be posted, but instead you see:
$ post-review -n -d
RBTools 0.4.2
Python 2.6.8 (unknown, May 29 2012, 22:30:44)
[GCC 4.3.4 [gcc-4_3-branch revision 152973]]
Running on Linux-2.6.32.59-0.7-default-x86_64-with-SuSE-11-x86_64
Home =
Current Directory =
Checking the repository type. Errors shown below are mostly harmless.
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a ClearCase repository...
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Running: git config core.bare
DEBUG:root:Running: git rev-parse --show-toplevel
Traceback (most recent call last):
File /usr/local/bin/post-review, line 9, in module
load_entry_point('RBTools==0.4.2', 'console_scripts', 'post-review')()
File /usr/local/lib64/python2.6/site-packages/rbtools/postreview.py,
line 1221, in main
repository_info, tool = scan_usable_client(options)
File /usr/local/lib64/python2.6/site-packages/rbtools/clients/__init__.py,
line 157, in scan_usable_client
repository_info = tool.get_repository_info()
File /usr/local/lib64/python2.6/site-packages/rbtools/clients/git.py,
line 59, in get_repository_info
os.chdir(os.path.abspath(git_top))
OSError: [Errno 2] No such file or directory: '//--show-toplevel'
What operating system are you using? What browser?
SLES 11SP1
Please provide any additional information below.
The patch to fix submodules with git 1.7 uses:
git rev-parse --show-toplevel
On git 1.7+ this returns the absolute path of the top level of the repo,
but on git 1.6 it returns '--show-toplevel', which post-review tries to use
as a directory.
The same effect should be achievable in 1.6 using:
git_top = execute([self.git, rev-parse, --show-cdup],
ignore_errors=True).rstrip(\n)
git_top = os.path.abspath(git_top)
That should also work fine on 1.7, but perhaps I'm missing something else
that '--show-toplevel' does, in which case maybe this could be used if
git-top == '--show-toplevel'?
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
