Re: Review Board 1.7.9 is released

2013-06-04 Thread pfee 
Hi Christian, Stephen,

While testing Stephen's Fedora packages, on a F18 machine I upgraded from 
1.7.7.1 to 1.7.9.  Following the upgrade, I expected visiting the site's 
/dashboard URL would have told me to run "rb-site upgrade".  Instead I got 
a 500 "Something broke..." message.

Despite not being prompted, I ran "rb-site upgrade /var/www/reviewboard" 
anyway.  The site came back to life and started working again as expected, 
however someone upgrading for the first time would not know to do this.

The output of "rb-site upgrade" is below, are the "unapplied evolutions" 
message a cause for concern?
=
# rb-site upgrade /var/www/reviewboard
Rebuilding directory structure
Updating database. This may take a while.

The log output below, including warnings and errors,
can be ignored unless upgrade fails.

--  --
Creating tables ...
Upgrading Review Board from 1.7.7.1 to 1.7.9
There are unapplied evolutions for accounts.
There are unapplied evolutions for hostingsvcs.
There are unapplied evolutions for reviews.
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
Evolution successful.
---  ---

Resetting in-database caches.

Upgrade complete!


Thanks,
Paul

On Tuesday, 4 June 2013 05:50:46 UTC+1, Christian Hammond wrote:
>
> Hi Angus,
>
> Looks like there's a small issue in the dependency rule that breaks 
> easy_install's resolution for the version.
>
> Packagers, I'm going to be deploying a quick hotfix update to this, but 
> without a version number bump. It's nothing but a package metadata change. 
> Since you control your own metadata, this shouldn't affect you.
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>  
> On Jun 3, 2013, at 9:48 PM, Angus Ku > 
> wrote:
>
> Hi Christian,
>
> There is no Djblets-0.7.15-py2.7.egg folder in my 
> "/usr/local/lib/python2.7/dist-packages" directory.
> So, I tried to run "easy_install -U Djblets" manually and Djblets 0.7.15 
> can be downloaded.
> After that, I use "easy_install -U ReviewBoard" to upgrade to 1.7.9 and 
> then the issue is gone.
>
> So, I wonder that does "easy_install -U ReviewBoard" lack for checking the 
> dependency of Djblets?
>
> BTW, thanks a lot for you help!  ^.^
>
>
>
> Christian Hammond於 2013年6月4日星期二UTC+8下午12時16分28秒寫道：
>>
>> Hi Angus,
>>
>> You're definitely running an old version of Djblets. That would explain 
>> it, though I can't explain why you would be on that version.
>>
>> Is there a Djblets-0.7.15-py2.7.egg directory alongside the 0.7.12 
>> directory by any chance?
>>
>> Christian
>>
>> -- 
>> Christian Hammond - chi...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> Beanbag, Inc. - http://www.beanbaginc.com
>>  
>> On Jun 3, 2013, at 9:14 PM, Angus Ku  wrote:
>>
>> Hi Christian,
>>
>> Here is the result,
>>
>> import djbPython 2.7.3 (default, Aug  1 2012, 05:14:39)
>> [GCC 4.6.3] on linux2
>> Type "help", "copyright", "credits" or "license" for more information.
>> (InteractiveConsole)
>> le>>> import djblets
>> >>> djblets.__file__
>>
>> '/usr/local/lib/python2.7/dist-packages/Djblets-0.7.12-py2.7.egg/djblets/__init__.pyc'
>>
>> Our repository is using Subversion.
>>
>> Thanks!
>>
>> Christian Hammond於 2013年6月4日星期二UTC+8上午11時55分13秒寫道：
>>>
>>> Hi Angus,
>>>
>>> The "evolution is required" message is normal, and just part of our 
>>> standard database migration work that rb-site does on your behalf.
>>>
>>> Can you verify for me what version of Djblets is installed? You can do:
>>>
>>> rb-site manage /path/to/site shell
>>> >>> import djblets
>>> >>> djblets.__file__
>>>
>>> I want to rule out an older version of Djblets being used. The log you 
>>> pasted shows that our logger is never even being used, which should not be 
>>> possible unless something else being executed went out of its way to 
>>> override it.
>>>
>>> Can you also tell me what type of repository you're working with?
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond - chi...@chipx86.com
>>> Review Board - http://www.reviewboard.org
>>> Beanbag, Inc. - http://www.beanbaginc.com
>>>  
>>> On Jun 3, 2013, at 8:44 PM, Angus Ku  wrote:
>>>
>>> Hi Christian,
>>>
>>> Thanks for your reply.
>>> I just follow the standard installation guide from the website to setup 
>>> my server using Apache and mod_wsgi.
>>> I don't do any custom modifications for all ReviewBoard files and 
>>> settings.
>>> But, I think i got a message " an evolution is required" when I run 
>>> "rb-site upgrade" from 1.7.7.1 to 1.7.9. Any actions should I take?
>>>
>>> BTW, currently, I downgrade my ReviewBoard from 1.7.9 to 1.7.7.1, and 
>>> the view diff page works again. 
>>>
>>>
>>>
>>> Christian Hammond於 2013年6月4日星期二UTC+8上午11時15分09秒寫道：

Re: Review Board 1.7.9 is released

2013-06-04 Thread pfee 
Hi Christian,

Using Firefox/Firebug, I see that the icon above the "My Account, Admin, 
Log Off" menu is server from an external site:

http://www.gravatar.com/avatar/0657fda85d3463a3e0784bc6f2e14b69?s=32

Is there a reason why this isn't bundled with ReviewBoard?  Someone using 
ReviewBoard from a network isolated from the public Internet would not be 
able to access this image.

Thanks,
Paul

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Review Board 1.7.9 is released

2013-06-04 Thread Stephen Gallagher 
On Tuesday, June 4, 2013, pfee wrote:

> Hi Christian, Stephen,
>
> While testing Stephen's Fedora packages, on a F18 machine I upgraded from
> 1.7.7.1 to 1.7.9.  Following the upgrade, I expected visiting the site's
> /dashboard URL would have told me to run "rb-site upgrade".  Instead I got
> a 500 "Something broke..." message.
>
> Despite not being prompted, I ran "rb-site upgrade /var/www/reviewboard"
> anyway.  The site came back to life and started working again as expected,
> however someone upgrading for the first time would not know to do this.
>
>
Ah, thanks for reminding me. Not that anyone actually reads the updates
notes, but I usually put a reminder in that you always need to run rb-site
upgrade after installing the packages. I'll tweak the update notes when I
get to work.

I've been meaning to patch the Fedora packages to do this automatically, by
having rb-site install save a config file with a list of installed sites so
I can have the %post script run the upgrade on package install.





> The output of "rb-site upgrade" is below, are the "unapplied evolutions"
> message a cause for concern?
> =
> # rb-site upgrade /var/www/reviewboard
> Rebuilding directory structure
> Updating database. This may take a while.
>
> The log output below, including warnings and errors,
> can be ignored unless upgrade fails.
>
> --  --
> Creating tables ...
> Upgrading Review Board from 1.7.7.1 to 1.7.9
> There are unapplied evolutions for accounts.
> There are unapplied evolutions for hostingsvcs.
> There are unapplied evolutions for reviews.
> Project signature has changed - an evolution is required
> Installing custom SQL ...
> Installing indexes ...
> Installed 0 object(s) from 0 fixture(s)
> Evolution successful.
> ---  ---
>
> Resetting in-database caches.
>
> Upgrade complete!
> 
>
> Thanks,
> Paul
>
> On Tuesday, 4 June 2013 05:50:46 UTC+1, Christian Hammond wrote:
>>
>> Hi Angus,
>>
>> Looks like there's a small issue in the dependency rule that breaks
>> easy_install's resolution for the version.
>>
>> Packagers, I'm going to be deploying a quick hotfix update to this, but
>> without a version number bump. It's nothing but a package metadata change.
>> Since you control your own metadata, this shouldn't affect you.
>>
>> Christian
>>
>> --
>> Christian Hammond - chi...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> Beanbag, Inc. - http://www.beanbaginc.com
>>
>> On Jun 3, 2013, at 9:48 PM, Angus Ku  wrote:
>>
>> Hi Christian,
>>
>> There is no Djblets-0.7.15-py2.7.egg folder in my
>> "/usr/local/lib/python2.7/**dist-packages" directory.
>> So, I tried to run "easy_install -U Djblets" manually and Djblets 0.7.15
>> can be downloaded.
>> After that, I use "easy_install -U ReviewBoard" to upgrade to 1.7.9 and
>> then the issue is gone.
>>
>> So, I wonder that does "easy_install -U ReviewBoard" lack for checking
>> the dependency of Djblets?
>>
>> BTW, thanks a lot for you help!  ^.^
>>
>>
>>
>> Christian Hammond於 2013年6月4日星期二UTC+**8下午12時16分28秒寫道：
>>
>> Hi Angus,
>>
>> You're definitely running an old version of Djblets. That would explain
>> it, though I can't explain why you would be on that version.
>>
>> Is there a Djblets-0.7.15-py2.7.egg directory alongside the 0.7.12
>> directory by any chance?
>>
>> Christian
>>
>> --
>> Christian Hammond - chi...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> Beanbag, Inc. - http://www.beanbaginc.com
>>
>> On Jun 3, 2013, at 9:14 PM, Angus Ku  wrote:
>>
>> Hi Christian,
>>
>> Here is the result,
>>
>> import djbPython 2.7.3 (default, Aug  1 2012, 05:14:39)
>> [GCC 4.6.3] on linux2
>> Type "help", "copyright", "credits" or "license" for more information.
>> (InteractiveConsole)
>> le>>> import djblets
>> >>> djblets.__file__
>> '/usr/local/lib/python2.7/**dist-packages/Djblets-0.7.12-**
>> py2.7.egg/djblets/__init__.**pyc'
>>
>> Our repository is using Subversion.
>>
>> Thanks!
>>
>> Christian Hammond於 2013年6月4日星期二UTC+**8上午11時55分13秒寫道：
>>
>> Hi Angus,
>>
>> The "evolution is required" message is normal, and just part of our
>> standard database migration work that rb-site does on your behalf.
>>
>> Can you verify for me what version of Djblets is installed? You can do:
>>
>> rb-site manage /path/to/site shell
>> >>> import djblets
>> >>> djblets.__file__
>>
>> I want to rule out an older version of Djblets being used. The log you
>> pasted shows that our logger is never even being used, which should not be
>> possible unless something else being executed went out of its way to
>> override it.
>>
>> Can you also tell me what type of repository you're working with?
>>
>> Christian
>>
>> --
>> Christian Hammond - chi...@chipx86.com
>> Review Board - http://www.reviewboard.org
>>
>>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user

Re: Review Board 1.7.9 is released

2013-06-04 Thread Christian Hammond 
On Jun 4, 2013, at 2:44 AM, Stephen Gallagher  wrote:

> 
> 
> On Tuesday, June 4, 2013, pfee wrote:
> Hi Christian, Stephen,
> 
> While testing Stephen's Fedora packages, on a F18 machine I upgraded from 
> 1.7.7.1 to 1.7.9.  Following the upgrade, I expected visiting the site's 
> /dashboard URL would have told me to run "rb-site upgrade".  Instead I got a 
> 500 "Something broke..." message.
> 
> Despite not being prompted, I ran "rb-site upgrade /var/www/reviewboard" 
> anyway.  The site came back to life and started working again as expected, 
> however someone upgrading for the first time would not know to do this.
> 
> 
> Ah, thanks for reminding me. Not that anyone actually reads the updates 
> notes, but I usually put a reminder in that you always need to run rb-site 
> upgrade after installing the packages. I'll tweak the update notes when I get 
> to work.
> 
> I've been meaning to patch the Fedora packages to do this automatically, by 
> having rb-site install save a config file with a list of installed sites so I 
> can have the %post script run the upgrade on package install. 

I've actually been wanting such a file for Review Board upstream that rb-site 
can write to, so that we can be more intelligent about upgrades. If you come up 
with a good way to do it, let me know :)

Christian


-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Review Board 1.7.9 is released

2013-06-04 Thread Christian Hammond 
Hi Paul,

We've had gravatar support ever since 1.7 came out.

Gravatar.com is pretty much the de-facto standard avatar provider out there, 
which lots of services and even developer tools integrate with. We're 
optimizing for the 99% case where you at least have a proxy server set up to 
reach the outside world.

Worst thing that happens otherwise is that you get a blank image. Oh well.

We may provide a way of customizing this in Review Board Enterprise, since 
larger companies often have their own in-house employee photos/avatars stored 
somewhere.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On Jun 4, 2013, at 2:10 AM, pfee  wrote:

> Hi Christian,
> 
> Using Firefox/Firebug, I see that the icon above the "My Account, Admin, Log 
> Off" menu is server from an external site:
> 
> http://www.gravatar.com/avatar/0657fda85d3463a3e0784bc6f2e14b69?s=32
> 
> Is there a reason why this isn't bundled with ReviewBoard?  Someone using 
> ReviewBoard from a network isolated from the public Internet would not be 
> able to access this image.
> 
> Thanks,
> Paul

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Review Board 1.7.9 is released

2013-06-04 Thread Stephen Gallagher 
On 06/04/2013 05:47 AM, Christian Hammond wrote:
> On Jun 4, 2013, at 2:44 AM, Stephen Gallagher  > wrote:
> 
>>
>>
>> On Tuesday, June 4, 2013, pfee wrote:
>>
>> Hi Christian, Stephen,
>>
>> While testing Stephen's Fedora packages, on a F18 machine I
>> upgraded from 1.7.7.1 to 1.7.9.  Following the upgrade, I expected
>> visiting the site's /dashboard URL would have told me to run
>> "rb-site upgrade".  Instead I got a 500 "Something broke..." message.
>>
>> Despite not being prompted, I ran "rb-site upgrade
>> /var/www/reviewboard" anyway.  The site came back to life and
>> started working again as expected, however someone upgrading for
>> the first time would not know to do this.
>>
>>
>> Ah, thanks for reminding me. Not that anyone actually reads the
>> updates notes, but I usually put a reminder in that you always need to
>> run rb-site upgrade after installing the packages. I'll tweak the
>> update notes when I get to work.
>>
>> I've been meaning to patch the Fedora packages to do this
>> automatically, by having rb-site install save a config file with a
>> list of installed sites so I can have the %post script run the upgrade
>> on package install. 
> 
> I've actually been wanting such a file for Review Board upstream that
> rb-site can write to, so that we can be more intelligent about upgrades.
> If you come up with a good way to do it, let me know :)
> 


Has Review Board formally and without question dropped Windows support?
If so, it becomes reasonably easy to hardcode a requirement on a file
such as /etc/ReviewBoard/sites which could be as simple as
one-path-per-line, and then patch rb-site to amend it when doing an
install and to iterate through it when calling 'rb-site upgrade' with no
arguments.

Then all I would have to do in the Fedora packages is call 'rb-site
upgrade' in the %post section on upgrades.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Review Board 1.7.9 is released

2013-06-04 Thread pfee 
Thanks for the explanation.  I wasn't aware of gravatar, hence I can view 
this as a feature not a bug :)

On Tuesday, 4 June 2013 10:51:00 UTC+1, Christian Hammond wrote:
>
> Hi Paul,
>
> We've had gravatar support ever since 1.7 came out.
>
> Gravatar.com is pretty much the de-facto standard avatar provider out 
> there, which lots of services and even developer tools integrate with. 
> We're optimizing for the 99% case where you at least have a proxy server 
> set up to reach the outside world.
>
> Worst thing that happens otherwise is that you get a blank image. Oh well.
>
> We may provide a way of customizing this in Review Board Enterprise, since 
> larger companies often have their own in-house employee photos/avatars 
> stored somewhere.
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>  
> On Jun 4, 2013, at 2:10 AM, pfee > wrote:
>
> Hi Christian,
>
> Using Firefox/Firebug, I see that the icon above the "My Account, Admin, 
> Log Off" menu is server from an external site:
>
> http://www.gravatar.com/avatar/0657fda85d3463a3e0784bc6f2e14b69?s=32
>
> Is there a reason why this isn't bundled with ReviewBoard?  Someone using 
> ReviewBoard from a network isolated from the public Internet would not be 
> able to access this image.
>
> Thanks,
> Paul
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Review Board 1.7.9 is released

2013-06-04 Thread victoria 
On Tue, Jun 4, 2013 at 1:47 PM, Stephen Gallagher  wrote:

> On 06/04/2013 05:47 AM, Christian Hammond wrote:
> > On Jun 4, 2013, at 2:44 AM, Stephen Gallagher  > > wrote:
> >
> >>
> >>
> >> On Tuesday, June 4, 2013, pfee wrote:
> >>
> >> Hi Christian, Stephen,
> >>
> >> While testing Stephen's Fedora packages, on a F18 machine I
> >> upgraded from 1.7.7.1 to 1.7.9.  Following the upgrade, I expected
> >> visiting the site's /dashboard URL would have told me to run
> >> "rb-site upgrade".  Instead I got a 500 "Something broke..."
> message.
> >>
> >> Despite not being prompted, I ran "rb-site upgrade
> >> /var/www/reviewboard" anyway.  The site came back to life and
> >> started working again as expected, however someone upgrading for
> >> the first time would not know to do this.
> >>
> >>
> >> Ah, thanks for reminding me. Not that anyone actually reads the
> >> updates notes, but I usually put a reminder in that you always need to
> >> run rb-site upgrade after installing the packages. I'll tweak the
> >> update notes when I get to work.
> >>
> >> I've been meaning to patch the Fedora packages to do this
> >> automatically, by having rb-site install save a config file with a
> >> list of installed sites so I can have the %post script run the upgrade
> >> on package install.
> >
> > I've actually been wanting such a file for Review Board upstream that
> > rb-site can write to, so that we can be more intelligent about upgrades.
> > If you come up with a good way to do it, let me know :)
> >
>
>
> Has Review Board formally and without question dropped Windows support?
> If so, it becomes reasonably easy to hardcode a requirement on a file
> such as /etc/ReviewBoard/sites which could be as simple as
> one-path-per-line, and then patch rb-site to amend it when doing an
> install and to iterate through it when calling 'rb-site upgrade' with no
> arguments.
>
> Then all I would have to do in the Fedora packages is call 'rb-site
> upgrade' in the %post section on upgrades.
>


Just a comment from BitNami. Even if Windows is not supported it would be
great you don't have any path hardcoded.  Currently we allow to have
different installations in the systems in different installation paths,
installing as root as an not root user. Of course this is also possible
without using the BitNami installers. Having that hardcoded will affect
this flexibility. If those are necessary I would suggest to have default
values..but not hardcoded and not customizables values.



> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Review Board 1.7.9 is released

2013-06-04 Thread Stephen Gallagher 
On 06/04/2013 09:15 AM, victoria wrote:
> 
> 
> On Tue, Jun 4, 2013 at 1:47 PM, Stephen Gallagher
> mailto:step...@gallagherhome.com>> wrote:
> 
> On 06/04/2013 05:47 AM, Christian Hammond wrote:
> > On Jun 4, 2013, at 2:44 AM, Stephen Gallagher
> mailto:step...@gallagherhome.com>
> >  >> wrote:
> >
> >>
> >>
> >> On Tuesday, June 4, 2013, pfee wrote:
> >>
> >> Hi Christian, Stephen,
> >>
> >> While testing Stephen's Fedora packages, on a F18 machine I
> >> upgraded from 1.7.7.1 to 1.7.9.  Following the upgrade, I
> expected
> >> visiting the site's /dashboard URL would have told me to run
> >> "rb-site upgrade".  Instead I got a 500 "Something broke..."
> message.
> >>
> >> Despite not being prompted, I ran "rb-site upgrade
> >> /var/www/reviewboard" anyway.  The site came back to life and
> >> started working again as expected, however someone upgrading for
> >> the first time would not know to do this.
> >>
> >>
> >> Ah, thanks for reminding me. Not that anyone actually reads the
> >> updates notes, but I usually put a reminder in that you always
> need to
> >> run rb-site upgrade after installing the packages. I'll tweak the
> >> update notes when I get to work.
> >>
> >> I've been meaning to patch the Fedora packages to do this
> >> automatically, by having rb-site install save a config file with a
> >> list of installed sites so I can have the %post script run the
> upgrade
> >> on package install.
> >
> > I've actually been wanting such a file for Review Board upstream that
> > rb-site can write to, so that we can be more intelligent about
> upgrades.
> > If you come up with a good way to do it, let me know :)
> >
> 
> 
> Has Review Board formally and without question dropped Windows support?
> If so, it becomes reasonably easy to hardcode a requirement on a file
> such as /etc/ReviewBoard/sites which could be as simple as
> one-path-per-line, and then patch rb-site to amend it when doing an
> install and to iterate through it when calling 'rb-site upgrade' with no
> arguments.
> 
> Then all I would have to do in the Fedora packages is call 'rb-site
> upgrade' in the %post section on upgrades.
> 
> 
> 
> Just a comment from BitNami. Even if Windows is not supported it would
> be great you don't have any path hardcoded.  Currently we allow to have
> different installations in the systems in different installation paths,
> installing as root as an not root user. Of course this is also possible
> without using the BitNami installers. Having that hardcoded will affect
> this flexibility. If those are necessary I would suggest to have default
> values..but not hardcoded and not customizables values.
> 

Yeah, the same thought occurred to me a few minutes ago. I may just try
to make it a variable in settings.py or something, defaulting to
/etc/ReviewBoard, unless Christian or David has a better idea.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Review Board 1.7.9 is released

2013-06-04 Thread Christian Hammond 
Hi Bruce,

Make sure of the following:

1) The configured account for your MySQL that Review Board is using has full 
permissions on the database.

2) You're not mixing MyISAM and InnoDB tables in the database.

Christian


On Jun 4, 2013, at 6:35, Bruce Cran  wrote:

> > 1.7.9 is out, with fixes to installation issues people have hit and 
> > reported (thanks!).
> 
> My installation failed to upgrade from 1.7.6, with what looks to be a foreign 
> key issue:
> 
> --  --
> Creating tables ...
> Upgrading Review Board from 1.7.6 to 1.7.9
> There are unapplied evolutions for accounts.
> There are unapplied evolutions for hostingsvcs.
> There are unapplied evolutions for reviews.
> Project signature has changed - an evolution is required
> Installing custom SQL ...
> Installing indexes ...
> Installed 0 object(s) from 0 fixture(s)
> Error: Error applying evolution: (1005, "Can't create table 
> 'db_name.#sql-5b3a_6d' (errno: 150)")
> 
> -- 
> Bruce Cran

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Review Board 1.7.9 is released

2013-06-04 Thread Bruce Cran 
> 1.7.9 is out, with fixes to installation issues people have hit and 
reported (thanks!).

My installation failed to upgrade from 1.7.6, with what looks to be a 
foreign key issue:

--  --
Creating tables ...
Upgrading Review Board from 1.7.6 to 1.7.9
There are unapplied evolutions for accounts.
There are unapplied evolutions for hostingsvcs.
There are unapplied evolutions for reviews.
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
Error: Error applying evolution: (1005, "Can't create table 
'db_name.#sql-5b3a_6d' (errno: 150)")

-- 
Bruce Cran

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Review Board 1.7.9 is released

2013-06-04 Thread Stephen Gallagher 
On 06/04/2013 09:19 AM, Stephen Gallagher wrote:
> On 06/04/2013 09:15 AM, victoria wrote:
>>
>>
>> On Tue, Jun 4, 2013 at 1:47 PM, Stephen Gallagher
>> mailto:step...@gallagherhome.com>> wrote:
>>
>> On 06/04/2013 05:47 AM, Christian Hammond wrote:
>> > On Jun 4, 2013, at 2:44 AM, Stephen Gallagher
>> mailto:step...@gallagherhome.com>
>> > > >> wrote:
>> >
>> >>
>> >>
>> >> On Tuesday, June 4, 2013, pfee wrote:
>> >>
>> >> Hi Christian, Stephen,
>> >>
>> >> While testing Stephen's Fedora packages, on a F18 machine I
>> >> upgraded from 1.7.7.1 to 1.7.9.  Following the upgrade, I
>> expected
>> >> visiting the site's /dashboard URL would have told me to run
>> >> "rb-site upgrade".  Instead I got a 500 "Something broke..."
>> message.
>> >>
>> >> Despite not being prompted, I ran "rb-site upgrade
>> >> /var/www/reviewboard" anyway.  The site came back to life and
>> >> started working again as expected, however someone upgrading for
>> >> the first time would not know to do this.
>> >>
>> >>
>> >> Ah, thanks for reminding me. Not that anyone actually reads the
>> >> updates notes, but I usually put a reminder in that you always
>> need to
>> >> run rb-site upgrade after installing the packages. I'll tweak the
>> >> update notes when I get to work.
>> >>
>> >> I've been meaning to patch the Fedora packages to do this
>> >> automatically, by having rb-site install save a config file with a
>> >> list of installed sites so I can have the %post script run the
>> upgrade
>> >> on package install.
>> >
>> > I've actually been wanting such a file for Review Board upstream that
>> > rb-site can write to, so that we can be more intelligent about
>> upgrades.
>> > If you come up with a good way to do it, let me know :)
>> >
>>
>>
>> Has Review Board formally and without question dropped Windows support?
>> If so, it becomes reasonably easy to hardcode a requirement on a file
>> such as /etc/ReviewBoard/sites which could be as simple as
>> one-path-per-line, and then patch rb-site to amend it when doing an
>> install and to iterate through it when calling 'rb-site upgrade' with no
>> arguments.
>>
>> Then all I would have to do in the Fedora packages is call 'rb-site
>> upgrade' in the %post section on upgrades.
>>
>>
>>
>> Just a comment from BitNami. Even if Windows is not supported it would
>> be great you don't have any path hardcoded.  Currently we allow to have
>> different installations in the systems in different installation paths,
>> installing as root as an not root user. Of course this is also possible
>> without using the BitNami installers. Having that hardcoded will affect
>> this flexibility. If those are necessary I would suggest to have default
>> values..but not hardcoded and not customizables values.
>>
> 
> Yeah, the same thought occurred to me a few minutes ago. I may just try
> to make it a variable in settings.py or something, defaulting to
> /etc/ReviewBoard, unless Christian or David has a better idea.
> 

Ok, I have a first pass at implementing this, by adding a new option to
rb-site (--sitelist) which will default to /etc/ReviewBoard/sites

I've modified the upgrade routine so that it can be called as 'rb-site
upgrade' with no site listed, at which point it will iterate through the
sites listed in /etc/ReviewBoard/sites and upgrade them all.

I'm sending these as attached git-format-patch patches because the
reviews.reviewboard.org website appears to be broken at the moment.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


>From fb9e7feb6e239c9a37b2fe5316fa9a328938c0c3 Mon Sep 17 00:00:00 2001
From: Stephen Gallagher 
Date: Tue, 4 Jun 2013 14:47:38 -0400
Subject: [PATCH 1/2] Store installation paths to sitelist file during 'rb-site
 install'

---
 reviewboard/cmdline/rbsite.py | 50 +++
 1 file changed, 50 insertions(+)

diff --git a/reviewboard/cmdline/rbsite.py b/reviewboard/cmdline/rbsite.py
index b3b4af61731abba99273b8eae566e1de7efd193f..7bd60c3e4ff926a5d4e786beaba97cb6478ebef4 100755
--- a/reviewboard/cmdline/rbsite.py
+++ b/r

Slight glitch in upgrade to 1.7.9

2013-06-04 Thread Christian Wuerdig 
Hi,

I just upgraded from 1.7.6 to 1.7.9 and got the following error when trying 
to view the diffs of any review request:

_log() got an unexpected keyword argument 'request'

Traceback (most recent call last):
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.9-py2.7.egg/reviewboard/diffviewer/views.py",
 
line 43, in view_diff
diffset.id, request=request)
  File "/usr/lib/python2.7/logging/__init__.py", line 1608, in debug
root.debug(msg, *args, **kwargs)
  File "/usr/lib/python2.7/logging/__init__.py", line 1128, in debug
self._log(DEBUG, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'request'

Running 'easy_install -U Djblets' fixed it. Is that not meant to be 
automatically upgraded?

Cheers
Christian

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Slight glitch in upgrade to 1.7.9

2013-06-04 Thread Christian Hammond 
Hi Christian,

Can you tell me when you downloaded 1.7.9? I put out a hotfix that should have 
taken care of this problem.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On Jun 4, 2013, at 3:53 PM, Christian Wuerdig  
wrote:

> Hi,
> 
> I just upgraded from 1.7.6 to 1.7.9 and got the following error when trying 
> to view the diffs of any review request:
> 
> _log() got an unexpected keyword argument 'request'
> 
> Traceback (most recent call last):
>   File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.9-py2.7.egg/reviewboard/diffviewer/views.py",
>  line 43, in view_diff
> diffset.id, request=request)
>   File "/usr/lib/python2.7/logging/__init__.py", line 1608, in debug
> root.debug(msg, *args, **kwargs)
>   File "/usr/lib/python2.7/logging/__init__.py", line 1128, in debug
> self._log(DEBUG, msg, args, **kwargs)
> TypeError: _log() got an unexpected keyword argument 'request'
> 
> Running 'easy_install -U Djblets' fixed it. Is that not meant to be 
> automatically upgraded?
> 
> Cheers
> Christian
> 
> -- 
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>  
>  

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Slight glitch in upgrade to 1.7.9

2013-06-04 Thread Christian Wuerdig 
Hi Christian,

about 18h ago.

Cheers
Christian

On Wednesday, June 5, 2013 10:54:11 AM UTC+12, Christian Hammond wrote:
>
> Hi Christian,
>
> Can you tell me when you downloaded 1.7.9? I put out a hotfix that should 
> have taken care of this problem.
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>  
> On Jun 4, 2013, at 3:53 PM, Christian Wuerdig 
> > 
> wrote:
>
> Hi,
>
> I just upgraded from 1.7.6 to 1.7.9 and got the following error when 
> trying to view the diffs of any review request:
>
> _log() got an unexpected keyword argument 'request'
>
> Traceback (most recent call last):
>   File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.9-py2.7.egg/reviewboard/diffviewer/views.py",
>  
> line 43, in view_diff
> diffset.id, request=request)
>   File "/usr/lib/python2.7/logging/__init__.py", line 1608, in debug
> root.debug(msg, *args, **kwargs)
>   File "/usr/lib/python2.7/logging/__init__.py", line 1128, in debug
> self._log(DEBUG, msg, args, **kwargs)
> TypeError: _log() got an unexpected keyword argument 'request'
>
> Running 'easy_install -U Djblets' fixed it. Is that not meant to be 
> automatically upgraded?
>
> Cheers
> Christian
>
> -- 
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard...@googlegroups.com 
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard...@googlegroups.com .
> For more options, visit https://groups.google.com/groups/opt_out.
>  
>  
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Slight glitch in upgrade to 1.7.9

2013-06-04 Thread Christian Hammond 
Hi,

Okay, that would be before I uploaded the hotfix then. Same package name and 
version, just with the dependency change.

Sorry you got bit by that. I was hoping not *too* many people had downloaded it 
before we fixed that :)

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On Jun 4, 2013, at 4:01 PM, Christian Wuerdig  
wrote:

> Hi Christian,
> 
> about 18h ago.
> 
> Cheers
> Christian
> 
> On Wednesday, June 5, 2013 10:54:11 AM UTC+12, Christian Hammond wrote:
> Hi Christian,
> 
> Can you tell me when you downloaded 1.7.9? I put out a hotfix that should 
> have taken care of this problem.
> 
> Christian
> 
> -- 
> Christian Hammond - chi...@chipx86.com
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
> 
> On Jun 4, 2013, at 3:53 PM, Christian Wuerdig  wrote:
> 
>> Hi,
>> 
>> I just upgraded from 1.7.6 to 1.7.9 and got the following error when trying 
>> to view the diffs of any review request:
>> 
>> _log() got an unexpected keyword argument 'request'
>> 
>> Traceback (most recent call last):
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.9-py2.7.egg/reviewboard/diffviewer/views.py",
>>  line 43, in view_diff
>> diffset.id, request=request)
>>   File "/usr/lib/python2.7/logging/__init__.py", line 1608, in debug
>> root.debug(msg, *args, **kwargs)
>>   File "/usr/lib/python2.7/logging/__init__.py", line 1128, in debug
>> self._log(DEBUG, msg, args, **kwargs)
>> TypeError: _log() got an unexpected keyword argument 'request'
>> 
>> Running 'easy_install -U Djblets' fixed it. Is that not meant to be 
>> automatically upgraded?
>> 
>> Cheers
>> Christian
>> 
>> -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to reviewboard...@googlegroups.com
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>  
>>  
> 
> 
> -- 
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>  
>  

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.