Re: Which version of Ubuntu is supported for latest 1.7.12 ReviewBoard release?
Hi Kunjal, Any modern version should be fine. We don't have a single recommended version. You will need to be sure you have a Python 2.x install, though. Christian On Monday, July 29, 2013, Kunjal wrote: > Chris, > > We are considering Ubuntu installation for latest upgrade to 1.7.12 > ReviewBoard release. > Which Ubuntu version installation is supported for ReviewBoard? > > Thanks a lot > Kunjal > > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com 'reviewboard%2bunsubscr...@googlegroups.com');> > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com 'cvml', 'reviewboard%2bunsubscr...@googlegroups.com');>. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: LDAP Authentication Issues
Hi Michael,
I don't have any useful answer for you just yet, but I wanted to point out
that the version of backends.py you're looking out is very ancient. You'll
want to check the one on http://github.com/reviewboard/reviewboard/ in
order to help debug this.
I'm not an LDAP expert so I'm not in a great position right now to tell you
what's wrong. It's possible our code is doing something wrong right now.
Particularly if you're getting that error, which at the very least we
should catch.
Christian
On Sunday, July 28, 2013, Michael Pigott wrote:
> Hello,
> I'm having trouble with configuring ReviewBoard for LDAP. I know I'm
> doing this correctly, because it works for my Subversion and Redmine
> instances. I'm not expecting much out of this, because I've seen others
> have had LDAP authentication issues like mine and haven't had much luck
> either.
>
> None of my LDAP users authenticate. I get varying issues with trying
> various configurations. The best I can get is a connection, with an error
> in my reviewboard.log stating:
>
> LDAP error: The specified object does not exist in the Directory or
> provided invalid credentials: uid=mpigott,dc=X,dc=org
>
> I have an OpenLDAP server running on the same machine as my Reviewboard
> instance. It has an admin account of "cn=admin,dc=X,dc=org" with a
> password. I don't have SASL set up, so it's just using the basic
> authentication.
>
> Server:
> I have tried all of the following:
>
> ldap://localhost/
> ldap://localhost:389/
> ldap://localhost/DC=X,DC=org?uid (to the unfamiliar, this is Apache's
> LDAP authentication URL)
>
> LDAP Base DN:
> dc=X,dc=org
> ou=people,dc=X,dc=org
>
> Given Name Attribute:
> givenName
>
> Surname Attribute:
> sn
>
> Full Name Attribute:
> cn
>
> E-mail Domain
>
> X.org
>
> E-mail LDAP Attribute
> mail
>
> User Mask:
> uid=%s => This gives me the error
> "LDAP error: The specified object does not exist in the Directory or
> provided invalid credentials: uid=mpigott,dc=X,dc=org"
> uid=%s,dc=X,dc=org=> Same error.
> (uid=%s) => This gives me the error
> "LDAP error: {'info': 'invalid DN', 'desc': 'Invalid DN syntax'}", with a
> corresponding error in syslog stating either "invalid dn
> ((uid=mpigott),ou=people,dc=X,dc=org)" or "invalid dn
> ((uid=mpigott),dc=X,dc=org)", depending on the above configurations.
>
> After looking at backends.py (
> http://reviewboard.googlecode.com/svn/trunk/reviewboard/accounts/backends.py),
> I was hoping the problem was that I did not set an anonymous username or
> password. From the logic, it looked like I could try to set the following:
>
> Anonymous User:
> cn=admin,dc=X,dc=org
>
> Anonymous Password
>
>
> Except, this time I get the error:
>
> "An error while LDAP-authenticating: ValueError('need more than 1 value to
> unpack',)"
>
> That appears to be a Python error that occurs when a list of items is too
> short. I noticed that the LDAP Anonymous Password never shows up on the
> admin screen; perhaps it is not saved?
>
> At any rate, any help is appreciated, though I'm about to give up and just
> use Registration authentication.
>
> Thanks,
> Mike
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com 'reviewboard%2bunsubscr...@googlegroups.com');>
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com 'cvml', 'reviewboard%2bunsubscr...@googlegroups.com');>.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>
--
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Review Board 1.6.18 and 1.7.12 released
On Mon, Jul 29, 2013 at 4:41 PM, Stephen Gallagher wrote: > On 07/28/2013 06:02 AM, Christian Hammond wrote: >> Hi everyone, >> >> We have a couple new releases tonight. Review Board 1.6.18 and 1.7.12 >> focus on tightening security, and giving extension writers a couple new >> abilities to make their lives easier. >> >> It's late here, so I'm going to direct you to the news post for further >> information: >> >> http://www.reviewboard.org/news/2013/07/28/review-board-1-6-18-and-1-7-12-released/ >> >> We also have a new guide on beefing up security for your file >> attachments. This is especially important for those of you with public >> installations, so please read it. >> >> http://support.beanbaginc.com/support/solutions/articles/110173-securing-file-attachments >> > > Packages for Fedora 18, Fedora 19 and Red Hat Enterprise Linux 6 (and > clones) are now available for testing at > https://admin.fedoraproject.org/updates/ReviewBoard > > They should appear in the 'updates-testing' or 'epel-testing' repository > mirrors within 48 hours, or they can be downloaded manually and tried > out from the link above. Please report any issues you discover with > these packages to https://bugzilla.redhat.com and the ReviewBoard component. The BitNami packages have been also udpated. BitNami ReviewBoard 1.7.12 installers, virtual machines and cloud images are already available at http://bitnami.com/stack/reviewboard > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. > > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: post-review, git-svn and --parent
Sorry the command I tested was...
git diff --no-color --no-prefix --no-ext-diff -r -u feature-x..develop
...which outputted a diff. (I'd put the wrong branch name in the command I
pasted here, I.e. testing..develop when it should have been
feature-x..develop).
Cheers,
Alex
On Tuesday, 30 July 2013 10:00:07 UTC+1, Alex Lewis wrote:
>
> Hi Christian,
> Thank you for your help! Sorry I completely missed the new rbt-post
> tool. I've re-run the command and the output is below. I've also provided
> the Commit hash ID's in case it helps...
>
> * 1c94727 - (HEAD, feature-x) temporary commit, testing
> * 5fe45c3 - (develop) snapshot versions.
> * b0e6883 - version bump.
> * 046b485 - (git-svn, master) Bug fix #1234
>
> > rbt post --parent=develop --debug -o
> DEBUG:root:Checking for a Subversion repository...
> DEBUG:root:Running: svn info --non-interactive
> DEBUG:root:Command exited with rc 1: ['svn', 'info', '--non-interactive']
> svn: E155007: '/path/to/dev/dir' is not a working copy
> ---
> DEBUG:root:Checking for a Git repository...
> DEBUG:root:Running: git rev-parse --git-dir
> DEBUG:root:Running: git config core.bare
> DEBUG:root:Running: git rev-parse --show-toplevel
> DEBUG:root:Running: git symbolic-ref -q HEAD
> DEBUG:root:Running: git svn info
> DEBUG:root:repository info: Path: http://someserver/svn/repo, Base path:
> /trunk, Supports changesets: False
> DEBUG:root:Making HTTP GET request to
> https://ourcodereviewserver.host.net/api/
> DEBUG:root:Making HTTP GET request to https://ourcodereviewserver.host.net
> /api/info/
> DEBUG:root:Running: git merge-base develop refs/heads/feature-x
> DEBUG:root:Running: git diff --no-color --no-prefix --no-ext-diff -r -u
> develop
> DEBUG:root:Running: git svn find-rev develop
> DEBUG:root:Running: git diff --no-color --no-prefix --no-ext-diff -r -u
> 5fe45c363bc8600ef727d0b4a441c8ed30e76c84..develop
> DEBUG:root:Running: git svn find-rev
> 5fe45c363bc8600ef727d0b4a441c8ed30e76c84
> Traceback (most recent call last):
> File "/usr/local/bin/rbt", line 9, in
> load_entry_point('RBTools==0.5.1', 'console_scripts', 'rbt')()
> File
> "/usr/local/lib/python2.7/dist-packages/RBTools-0.5.1-py2.7.egg/rbtools/commands/main.py",
>
> line 99, in main
> command.run_from_argv([RB_MAIN] + args)
> File
> "/usr/local/lib/python2.7/dist-packages/RBTools-0.5.1-py2.7.egg/rbtools/commands/__init__.py",
>
> line 158, in run_from_argv
> exit_code = self.main(*args) or 0
> File
> "/usr/local/lib/python2.7/dist-packages/RBTools-0.5.1-py2.7.egg/rbtools/commands/post.py",
>
> line 473, in main
> if len(diff) == 0:
> TypeError: object of type 'NoneType' has no len()
>
>
>1. git merge-base develop refs/heads/feature-x - Outputs hash id -
>5fe45c363bc8600ef727d0b4a441c8ed30e76c84
>2. git diff --no-color --no-prefix --no-ext-diff -r -u develop - Diff
>output.
>3. git svn find-rev develop - No output.
>4. git diff --no-color --no-prefix --no-ext-diff -r -u
>5fe45c363bc8600ef727d0b4a441c8ed30e76c84..develop - No output.
>5. git svn find-rev 5fe45c363bc8600ef727d0b4a441c8ed30e76c84 - Still
>no output.
>
>
> A couple of things that might help...
>
>- I'n using Git 1.8.3.4 on Ubuntu 13.04
>- I noticed is that *git diff* doesn't have a "-r" option as far as I
>could see from the man page, it does -R and --raw though. The -r is not
>having any affect on the output though (as far as I can tell).
>- I did git diff --no-color --no-prefix --no-ext-diff -r -u
>testing..develop and that worked fine, well it outputted the diff so
>it looked ok to me :)
>
> Just to confirm what I'd like to achieve. I'm using git-svn locally
> against an SVN server, using branches to do my work that I'd like to submit
> for review. I'll amend, squash, rebase, etc. to incorporate the changes
> into my local branch as per the review and to keep the commits tidy. Once I
> get enough *Ship It* responses on the final diff I'll commit the code to
> SVN in it's final state, with a commit message pointing to the review.
>
> Thanks again for your help.
>
> Cheers,
> Alex
>
> On Monday, 29 July 2013 19:14:47 UTC+1, Christian Hammond wrote:
>>
>> This looks like a bug, and not something you're doing wrong.
>>
>> Would you mind trying this with rbt-post instead of post-review (same
>> arguments) and seeing what the failure case is?
>>
>> rbt-post is the successor to post-review.
>>
>> Christian
>>
>>
>> On Jul 29, 2013, at 8:48, Alex Lewis wrote:
>>
>> Hi,
>> Please forgive me for raising this issue as I believe it has been
>> raised a couple of times over the years but I didn't see a resolution to
>> those issues and I'm seeing it with post-review 0.5.1. I hope you don't
>> mind.
>>
>> I have the following branch setup...
>>
>> |- xxx (feature-x)
>> |- xxx
>> |- xxx
>> |- yyy (develop)
>> |- yyy
>> |- zzz (master) (git-svn)
>>
>> ...where xxx, yyy and zzz are commits.
>>
>> As far as I un
Re: post-review, git-svn and --parent
Hi Christian,
Thank you for your help! Sorry I completely missed the new rbt-post tool.
I've re-run the command and the output is below. I've also provided the
Commit hash ID's in case it helps...
* 1c94727 - (HEAD, feature-x) temporary commit, testing
* 5fe45c3 - (develop) snapshot versions.
* b0e6883 - version bump.
* 046b485 - (git-svn, master) Bug fix #1234
> rbt post --parent=develop --debug -o
DEBUG:root:Checking for a Subversion repository...
DEBUG:root:Running: svn info --non-interactive
DEBUG:root:Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: E155007: '/path/to/dev/dir' is not a working copy
---
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Running: git config core.bare
DEBUG:root:Running: git rev-parse --show-toplevel
DEBUG:root:Running: git symbolic-ref -q HEAD
DEBUG:root:Running: git svn info
DEBUG:root:repository info: Path: http://someserver/svn/repo, Base path:
/trunk, Supports changesets: False
DEBUG:root:Making HTTP GET request to
https://ourcodereviewserver.host.net/api/
DEBUG:root:Making HTTP GET request to https://ourcodereviewserver.host.net
/api/info/
DEBUG:root:Running: git merge-base develop refs/heads/feature-x
DEBUG:root:Running: git diff --no-color --no-prefix --no-ext-diff -r -u
develop
DEBUG:root:Running: git svn find-rev develop
DEBUG:root:Running: git diff --no-color --no-prefix --no-ext-diff -r -u
5fe45c363bc8600ef727d0b4a441c8ed30e76c84..develop
DEBUG:root:Running: git svn find-rev
5fe45c363bc8600ef727d0b4a441c8ed30e76c84
Traceback (most recent call last):
File "/usr/local/bin/rbt", line 9, in
load_entry_point('RBTools==0.5.1', 'console_scripts', 'rbt')()
File
"/usr/local/lib/python2.7/dist-packages/RBTools-0.5.1-py2.7.egg/rbtools/commands/main.py",
line 99, in main
command.run_from_argv([RB_MAIN] + args)
File
"/usr/local/lib/python2.7/dist-packages/RBTools-0.5.1-py2.7.egg/rbtools/commands/__init__.py",
line 158, in run_from_argv
exit_code = self.main(*args) or 0
File
"/usr/local/lib/python2.7/dist-packages/RBTools-0.5.1-py2.7.egg/rbtools/commands/post.py",
line 473, in main
if len(diff) == 0:
TypeError: object of type 'NoneType' has no len()
1. git merge-base develop refs/heads/feature-x - Outputs hash id -
5fe45c363bc8600ef727d0b4a441c8ed30e76c84
2. git diff --no-color --no-prefix --no-ext-diff -r -u develop - Diff
output.
3. git svn find-rev develop - No output.
4. git diff --no-color --no-prefix --no-ext-diff -r -u
5fe45c363bc8600ef727d0b4a441c8ed30e76c84..develop - No output.
5. git svn find-rev 5fe45c363bc8600ef727d0b4a441c8ed30e76c84 - Still no
output.
A couple of things that might help...
- I'n using Git 1.8.3.4 on Ubuntu 13.04
- I noticed is that *git diff* doesn't have a "-r" option as far as I
could see from the man page, it does -R and --raw though. The -r is not
having any affect on the output though (as far as I can tell).
- I did git diff --no-color --no-prefix --no-ext-diff -r -u
testing..develop and that worked fine, well it outputted the diff so it
looked ok to me :)
Just to confirm what I'd like to achieve. I'm using git-svn locally against
an SVN server, using branches to do my work that I'd like to submit for
review. I'll amend, squash, rebase, etc. to incorporate the changes into my
local branch as per the review and to keep the commits tidy. Once I get
enough *Ship It* responses on the final diff I'll commit the code to SVN in
it's final state, with a commit message pointing to the review.
Thanks again for your help.
Cheers,
Alex
On Monday, 29 July 2013 19:14:47 UTC+1, Christian Hammond wrote:
>
> This looks like a bug, and not something you're doing wrong.
>
> Would you mind trying this with rbt-post instead of post-review (same
> arguments) and seeing what the failure case is?
>
> rbt-post is the successor to post-review.
>
> Christian
>
>
> On Jul 29, 2013, at 8:48, Alex Lewis >
> wrote:
>
> Hi,
> Please forgive me for raising this issue as I believe it has been raised
> a couple of times over the years but I didn't see a resolution to those
> issues and I'm seeing it with post-review 0.5.1. I hope you don't mind.
>
> I have the following branch setup...
>
> |- xxx (feature-x)
> |- xxx
> |- xxx
> |- yyy (develop)
> |- yyy
> |- zzz (master) (git-svn)
>
> ...where xxx, yyy and zzz are commits.
>
> As far as I understand it, to post a review of just the changes introduced
> by feature-x excluding the changes introduced by develop I use the --parent
> flag set to "develop". If I do this the command fails with an error about a
> NoneType (see debug output below). I believe the cause of the issue is that
> post-review tries to do a git svn find-rev on the yyy commits which aren't
> in SVN, so the find-rev returns nothing and post-review fails.
>
> Am I doing the right with the parent flag and if I am is there any chance
> that post-review co
