review with diff size greater than 1MB
Hi Team, I am trying to post the review for single .thpl file (34k lines) with diff size more than 1MB, I am getting the error saying Review Board's max diff size limit is 1 MB. Is there any way to get out of this problem? Thanks, Varun -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: review with diff size greater than 1MB
Do you expect your reviewers to read through 34k lines and actually make useful comments? Good reviews cover 100-200 lines per hour, so that's a 170-340 hour job for someone, or approximately 4-8 weeks of a full-time employee. Diffs 1MB pretty much always contain autogenerated code, which IME isn't useful to include in your code reviews. That said, if you insist, the max diff size is configurable in the settings (assuming a sufficiently recent version). -David -David On Mon, Nov 11, 2013 at 3:20 AM, Varun Jain varun.iam.j...@gmail.com wrote: Hi Team, I am trying to post the review for single .thpl file (34k lines) with diff size more than 1MB, I am getting the error saying Review Board's max diff size limit is 1 MB. Is there any way to get out of this problem? Thanks, Varun -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Browser opens incorrect URL from rbt post -o
Hello, I noticed a minor problem with rbt post -o. When I run post-review -o, my browser opens correctly at http://reviewboardhostname/reviews/r/reviewid/. When I run rbt post -o (from the the same changes), the review gets created correctly. However, the browser tries to open http://reviewboardhostname/r/reviewid/ and fails with HTTP 404. The reviews part of the path is missing (Review Board URL is http://reviewboardhostname/reviews). Review Board 1.7.18 on Ubuntu. RBTools 0.5.2 on Windows. Am I missing some configs? Regards, Igor. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Review groups and private repositories
Hey, I have noticed some problems with review groups and private repositories. It seems access control doesn't work properly or is it me? Scenario is this: - I have one SVN repository called repository1 and it's not publicly accessible - Review group named group1 has access to repository1 via admin panel (admin panel - repositories - repository1 - Review groups with access:) - Also group2 has same access to that repository as group1 - User1 belongs to group1 and User2 belongs to group2 So thats the setup, and the problem occuress when: - User1 creates a review request (repository1) and sets group1 as the group for the request - Now if User2 tries to read the review request he/she gets access denied So if you set repository to be private, only the selected group can view the review request, and not all the groups which have access to the repository via admin panel or am I missing something here? And if User2 is a superuser, then he/she can view the request. And this only works if group2 have access to the repository. If I remove group2 from the repository access list and user2 still have superuser rights, review request will not open (Access Denied). --Ges -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Review groups and private repositories
Hi, Are either group1 or group2 invite-only groups? Also, what version of Review Board? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Mon, Nov 11, 2013 at 5:26 AM, SenjorGes gessi...@gmail.com wrote: Hey, I have noticed some problems with review groups and private repositories. It seems access control doesn't work properly or is it me? Scenario is this: - I have one SVN repository called repository1 and it's not publicly accessible - Review group named group1 has access to repository1 via admin panel (admin panel - repositories - repository1 - Review groups with access:) - Also group2 has same access to that repository as group1 - User1 belongs to group1 and User2 belongs to group2 So thats the setup, and the problem occuress when: - User1 creates a review request (repository1) and sets group1 as the group for the request - Now if User2 tries to read the review request he/she gets access denied So if you set repository to be private, only the selected group can view the review request, and not all the groups which have access to the repository via admin panel or am I missing something here? And if User2 is a superuser, then he/she can view the request. And this only works if group2 have access to the repository. If I remove group2 from the repository access list and user2 still have superuser rights, review request will not open (Access Denied). --Ges -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Review Board 2.0 beta 1 released!
Hey everyone, I'm very excited to announce that we just released Review Board 2.0 beta 1. We have been working really hard on getting this ready, and are now hoping many of you will give it a try (on a test server, please). This release features numerous improvements to all parts of the product. Something in here for everyone. I wrote up the highlights on our news announcement on the site. Please have a look: http://www.reviewboard.org/news/2013/11/11/review-board-2-0-beta-1-released/ If you'd like to try it, we strongly recommend setting this up with a new database/site or a copy of your production database/site, and not your existing one. Please report any bugs you hit to us, so we can get the final 2.0 ready. Enjoy! Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3133 in reviewboard: Unable to change Submitter field via RBtools api
Comment #4 on issue 3133 by chip...@gmail.com: Unable to change Submitter field via RBtools api http://code.google.com/p/reviewboard/issues/detail?id=3133 You need to pass submit_as=username. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3133 in reviewboard: Unable to change Submitter field via RBtools api
Updates: Status: UserError Labels: Component-RBTools Comment #5 on issue 3133 by chip...@gmail.com: Unable to change Submitter field via RBtools api http://code.google.com/p/reviewboard/issues/detail?id=3133 Sorry, missed the update. Yep. Glad you figured it out :) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
