rbt post ignoring PUBLISH in .reviewboardrc?

2014-02-27 Thread Lee Laborczfalvi
I've just switched over to use rbt instead of post-review, but I'm finding 
that it's ignoring the PUBLISH=1 directive in the .reviewboardrc file.

I can see that my review is sitting on the server with the diff correctly 
there, the distribution group correctly there, but it is a draft only, not 
published.

I've checked my .reviewboardrc file and it has PUBLISH=1 in it.

When I make use of the command rbt post -p changenum then it correctly 
publishes the review request.

I'm not sure whether there's a bug here, or whether I've misconfigured 
something? I can see that all of the other fields in the .reviewboardrc 
file are being used.

Thanks
Lee

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: 2.0 Beta3 bugs

2014-02-27 Thread Allen
Yeah, I will. Thanks

On Wednesday, February 26, 2014 6:26:41 PM UTC-5, David Trowbridge wrote:

 Can you file these on the google code bug tracker?

 Thanks!
 -David


 On Wed, Feb 26, 2014 at 6:55 AM, Allen zhangs...@gmail.com 
 javascript:wrote:

 I am wondering is this a good place to report bugs? If you guys prefer 
 somewhere else, please let me know! I just figured out two bugs with the 
 2.0 Beta3.
 1. A user can not change his profiles. After I click on the save 
 Profile, all changes gone.
 2. When I play with the diff between different revisions, sometimes a 404 
 page not found error came out after I click on the download diff. And 
 when that happened, the download diff button disappeared after I went 
 back.
 (After a few tests, I believe the 404 page not found error only happens 
 when I move the left button.)

 That`s it so far! Thanks for you guys` contribution!

 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reviewboard ClearCase configuration

2014-02-27 Thread Khalil Shalish
Hi,
 
I am not clear on how to configure Reviewboard (1.7) with our clearcase 
setup.
 
Our clearcase setup:

We use clearcase dynamic views on linux.  The user can have a view or  set 
of views on his client machine.  The views are mounted and accessed in the 
following manner:
 
/view/view_name/vobs/project_name
 
In order to access a view, a user typlically will execute the starview 
command:  cleartool startview view_name which mounts the view under /view.
 
Our Reviewboard setup:
==
- Hosted on a linux server.
- Clearcase client is installed on review server.
 
The Reviewboard documentation on clearcase states:

Review Board works with local ClearCase dynamic views, by utilizing 
version-extended paths to access specific file revisions. The *Path 
field*http://www.reviewboard.org/docs/manual/1.7/admin/configuration/repositories/#path-fieldshould
 point to the particular VOB, which must be an absolute path starting 
with a drive letter on Windows or a mount point on Unix/Linux.

My Questions:  

Q1: What should I set in the path field ?   

Q2: Since each user can can have a set of views and Reviewboard requires an 
absolute path, it seems to me that the reviewboard server can only access 
one view for single clearcase repostiry.  Do I have to add each view as a 
separate clearcase repository in Reviewboard and manually start (mount) the 
view before adding it?  This is painfull, since we lots of views.

Q3: Is there a dynamic way to tell the server to startview view_name and 
access the file when the user posts a review of particualr file in 
view_name?

Any comments on this would be appreciated,

Khalil

 

 

 
 
 
 

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: upload diff file getting problem

2014-02-27 Thread Christian Hammond
You'll need to generate diffs by passing --full-index to git diff.

We recommend though that you use RBTools to post instead, as it'll ensure
the diff is in the right format, attach other useful data, and
create/update the review request for you.

Christian


On Thursday, February 27, 2014, umapathi magupalli 
umapathimagupa...@gmail.com wrote:

 Hi

 add Repository Hosting and repository information as shown below



 Repository Hosting:Host Service: service name
 service url: some url
 accout:some

 REpository Information:

 repository type:git
 repositoty paln :group
 repository group name: name
 repository name :name..

 while uploading .patch file it will unable to creating a request..

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to 
 reviewboard+unsubscr...@googlegroups.comjavascript:_e(%7B%7D,'cvml','reviewboard%2bunsubscr...@googlegroups.com');
 .
 For more options, visit https://groups.google.com/groups/opt_out.



-- 
-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Issue with spaces in diffs' paths

2014-02-27 Thread Marek Dorobisz


Hello,


I have a git repository and in paths there are spaces. Unfortunately 
Reviewboard ommits all before last space and tries to generate diffs with 
invalid paths. Is there any solution for that? 

Example path: $/ProjectName/release/some folder with spaces in 
name/anotherFolder/files.cs

And ReviewBoard generates diff with name/anotherFolder/files.cs 

My ReviewBoard version is 1.7.21

Do you have any idea how to workaround it?


Regards,

Marek

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: rbt post ignoring PUBLISH in .reviewboardrc?

2014-02-27 Thread David Trowbridge
Lee,

Looks like there's a bug. Can you file this on the google code issue
tracker?

Thanks!
-David


On Thu, Feb 27, 2014 at 3:48 AM, Lee Laborczfalvi labor...@gmail.comwrote:

 I've just switched over to use rbt instead of post-review, but I'm finding
 that it's ignoring the PUBLISH=1 directive in the .reviewboardrc file.

 I can see that my review is sitting on the server with the diff correctly
 there, the distribution group correctly there, but it is a draft only, not
 published.

 I've checked my .reviewboardrc file and it has PUBLISH=1 in it.

 When I make use of the command rbt post -p changenum then it correctly
 publishes the review request.

 I'm not sure whether there's a bug here, or whether I've misconfigured
 something? I can see that all of the other fields in the .reviewboardrc
 file are being used.

 Thanks
 Lee

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 1986 in reviewboard: CVS repository(pserver) addition fails

2014-02-27 Thread reviewboard


Comment #15 on issue 1986 by rich...@163.com: CVS repository(pserver)  
addition fails

http://code.google.com/p/reviewboard/issues/detail?id=1986

Do you have a data for the fix in 1.7.x branch? I want to use ReviewBoard  
to do code review in CVS environment, but it doesn't work in 1.7.21 branch  
yet.


Do you have a workaround instead? or could you please tell me hwo to fix  
the bug by myself?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 1986 in reviewboard: CVS repository(pserver) addition fails

2014-02-27 Thread reviewboard


Comment #16 on issue 1986 by trowb...@gmail.com: CVS repository(pserver)  
addition fails

http://code.google.com/p/reviewboard/issues/detail?id=1986

If you'd like, you could make the equivalent changes in the code on your  
system:  
https://github.com/reviewboard/reviewboard/commit/44e9c25db8ea7dd71ad3fd10927f17c3a86df4b6


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 1986 in reviewboard: CVS repository(pserver) addition fails

2014-02-27 Thread reviewboard


Comment #17 on issue 1986 by rich...@163.com: CVS repository(pserver)  
addition fails

http://code.google.com/p/reviewboard/issues/detail?id=1986

I modified and add function check_repository according to the above url.
but indicate that six variable is not found. and then I added from  
django.utils import six behind the sentense import urlparse after  
comparing with ReviewBoard-2.0beta3's cvs.py. the issue still exists. I  
have deleted cvs.pyc and cvs.pyo.


How can I modify the issue based on 1.7.21 branch?
Thanks

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.