Re: Unable to use New Review Request to create requests with parent diffs
Hi David, The biggest problem with RB Tools for our windows users is that it requires Python 2.7, and they are running Python 3 for other services. They've tried having both installed with no success. I think it would be a good decision to restore parent diff support to the New Review Request page. For our workflow, parent diffs are the norm, not a complex case. Thanks, Sara On Thursday, June 12, 2014 7:44:39 PM UTC-5, David Trowbridge wrote: Sara, Is the reluctance just that installing python stuff on Windows is hard, or are there other concerns? It might be nice to add parent diff support to the New Review Request page, but we'd need to do some redesign to fit it in with the new workflow, which is really designed to handle basic cases very quickly, and defer complex cases to rbtools. -David On Thu, Jun 12, 2014 at 8:40 AM, Sara Rayburn sarar...@gmail.com javascript: wrote: Most of our users use hg postreview to create review requests, but our windows users prefer to use the site's New Review Request upload tool. In RB 1.7.x, there was an option to upload both a diff and a parent diff. This is no longer an option. Is there still a way to use the web tool to create reviews with parent diffs? The windows developers in our group would prefer not to install RB Tools and all of its dependencies. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
It sounds like there might be a need for a standalone RBTools package for Windows, created using something like cx_freeze? -- Bruce On Fri, Jun 13, 2014 at 7:37 AM, Sara Rayburn sararayb...@gmail.com wrote: Hi David, The biggest problem with RB Tools for our windows users is that it requires Python 2.7, and they are running Python 3 for other services. They've tried having both installed with no success. I think it would be a good decision to restore parent diff support to the New Review Request page. For our workflow, parent diffs are the norm, not a complex case. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board 2.0.2 is released
Love the email enhancement but I don't see how to turn it on.. Is there a button on the review or is it a global setting or what ? Thanks! On Thursday, June 12, 2014 6:50:16 PM UTC-7, Christian Hammond wrote: Hey everyone, We just put out Review Board 2.0.2, which fixes a number of bugs reported on this list and in our tracker. See our announcement for info on the release: http://www.reviewboard.org/news/2014/06/12/review-board-2-0-2-released/ Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board 2.0.2 is released
If you open My Account and go to Settings, you'll see the check-box to enable or disable emails. -David On Fri, Jun 13, 2014 at 11:41 AM, markdbe...@gmail.com wrote: Love the email enhancement but I don't see how to turn it on.. Is there a button on the review or is it a global setting or what ? Thanks! On Thursday, June 12, 2014 6:50:16 PM UTC-7, Christian Hammond wrote: Hey everyone, We just put out Review Board 2.0.2, which fixes a number of bugs reported on this list and in our tracker. See our announcement for info on the release: http://www.reviewboard.org/news/2014/06/12/review-board-2-0-2-released/ Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
We've been wanting to do something like that for some time. -David On Jun 13, 2014, at 7:22 AM, Bruce Cran bruce.c...@gmail.com wrote: It sounds like there might be a need for a standalone RBTools package for Windows, created using something like cx_freeze? -- Bruce On Fri, Jun 13, 2014 at 7:37 AM, Sara Rayburn sararayb...@gmail.com wrote: Hi David, The biggest problem with RB Tools for our windows users is that it requires Python 2.7, and they are running Python 3 for other services. They've tried having both installed with no success. I think it would be a good decision to restore parent diff support to the New Review Request page. For our workflow, parent diffs are the norm, not a complex case. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3415 in reviewboard: Incoming counts on left nav panel is different from no. of review requests displayed
Comment #4 on issue 3415 by a...@brookmoor.com: Incoming counts on left nav panel is different from no. of review requests displayed http://code.google.com/p/reviewboard/issues/detail?id=3415 Yep - that worked. Okay, will keep an eye out for this and see if it happens again. Also, if you can just give me a pointer to where this code might be, I can put another set of eyes on it and see if something obvious pops up. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3312 in reviewboard: Diffs without embedded commit IDs can not be used
Comment #5 on issue 3312 by gmiroshn...@rebbix.com: Diffs without embedded commit IDs can not be used http://code.google.com/p/reviewboard/issues/detail?id=3312 That's right, dropping --git does generate a diff acceptable for Review Board. While diffs without commit IDs are still broken and base_commit_id param is a bit misleading, that workaround works for me. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3416 in reviewboard: 'Manual updates required' screen tells users to restart entire server
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3416 by bruce.c...@gmail.com: 'Manual updates required' screen tells users to restart entire server http://code.google.com/p/reviewboard/issues/detail?id=3416 What version are you running? 2.0.1 What's the URL of the page containing the problem? N/A What steps will reproduce the problem? 1. Install Review Board using 'rb-site install' 2. The 'Manual Server Updates Required' screen will be displayed telling admins to run 'chown -R www-data' etc. What is the expected output? What do you see instead? Beneath the title is the text: A recent upgrade requires manual updates to be made on this server. After these changes are made, you should restart your server. I think the only thing that should ever need restarted is the *web* server, not the entire server machine. What operating system are you using? What browser? Windows 8.1 and Firefox 30 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3312 in reviewboard: Diffs without embedded commit IDs can not be used
Comment #6 on issue 3312 by bruce.c...@gmail.com: Diffs without embedded
commit IDs can not be used
http://code.google.com/p/reviewboard/issues/detail?id=3312
Sorry - I just installed 2.0.1 and found that uploading the same diff
*does* work - it shows 'Revision UNKNOWN' but still works. So it's not
something that's changed between 2.0.1 and 2.0.2
The hg postreview code handles git diffs by adding a header:
if opts.get('git') or ui.configbool('diff', 'git'):
# Git diffs don't include the revision numbers with each file,
so
# we have to put them in the header instead.
output += # Node ID + node.hex(r.node()) + \n
output += # Parent + node.hex(parent.node()) + \n
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Issue 3417 in reviewboard: Windows RBT can't resolve Server
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3417 by mda...@efficiencytree.com: Windows RBT can't resolve Server http://code.google.com/p/reviewboard/issues/detail?id=3417 What version are you running? Reviewboard 2.0.0 RBT 0.6.1 What steps will reproduce the problem? 1. rbt post --server=https://myserver.com/reviewboard What is the expected output? What do you see instead? I expect to get a posted review Instead I get an error message of not being able to find the server What operating system are you using? What browser? Windows 7 x64 Python 2.7.7 Please provide any additional information below. If I replace the myserver.com with the actual IP address of the server everything works If I ping the myserver.com it resolves properly. If I post on the same server and repository on my Linux box it works properly. Attachments: LogWithDNS.txt 1.5 KB LogWithIP.txt 1.4 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3417 in reviewboard: Windows RBT can't resolve Server
Comment #1 on issue 3417 by mda...@efficiencytree.com: Windows RBT can't resolve Server http://code.google.com/p/reviewboard/issues/detail?id=3417 I did some more tests and look like it is a Python issue in general not specific to RBT. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3418 in reviewboard: rbt post for perforce changelist on windows fails when files are located on different drive than rbt.exe
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3418 by alexkb...@gmail.com: rbt post for perforce changelist on windows fails when files are located on different drive than rbt.exe http://code.google.com/p/reviewboard/issues/detail?id=3418 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be *** rejected. *** *** If you have a security issue to report, please send it confidentially to *** secur...@reviewboard.org. Posting security-related issues to this bug *** tracker causes us to have to do an emergency release. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** This bug tracker is public. Please check that any logs or other information *** that you include has been stripped of confidential information. What version are you running? Review Board Tools 0.6 What's the URL of the page containing the problem? NA What steps will reproduce the problem? 1. Install Python and rbt on C drive of windows machine 2. From P4V, create workspace mapped to E: drive 3. use rbt post to attempt to request a code review What is the expected output? What do you see instead? Expected: - to be able to create a review request as one would for perforce workspaces on the C drive Instead: - got System cannot find the path specified error; could not make review request What operating system are you using? What browser? Windows 8 (browser NA) Please provide any additional information below. When I created a workspace mapped to the C drive, it worked as it should. When I moved rbt.exe to the E drive and attempted to request a code review with rbt post for a workspace whos files are on the E drive, and that worked as it should. the problem arises when the drive of the location of the files being diff-ed is different than the drive of rbt.exe I think that the perforce component or rbt uses p4 describe to get the list of affected files. I checked the output of 'p4 describe changelist number and it does not include the drive. This would explain why the system gives the error that it cannot find the specified path - if it assumes the same drive as rbt.exe, and that's the wrong drive, the files won't exist. My workaround is to use a wrapper script for rbt. We configure the drive letter of the workspace mapping once, and the wrapper script copies rbt.exe and the other dependancies from \Python27\Scripts onto the workspace drive. Then it executes rbt.exe from that drive. This isn't idea because it means there is a copy of rbt.exe on potentially many drives, and of course that the wrapper script has to be used instead of rbt.exe itself. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3417 in reviewboard: Windows RBT can't resolve Server
Updates: Status: SetupIssue Comment #2 on issue 3417 by trowb...@gmail.com: Windows RBT can't resolve Server http://code.google.com/p/reviewboard/issues/detail?id=3417 If you're having DNS issues, it's probably even lower than python. Maybe try putting the server name in a hosts file. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2184 in reviewboard: Mercurial rename support: Pure file renames with *no actual changes* to the file fails with Diff did not apply cleanly
Comment #11 on issue 2184 by trowb...@gmail.com: Mercurial rename support: Pure file renames with *no actual changes* to the file fails with Diff did not apply cleanly http://code.google.com/p/reviewboard/issues/detail?id=2184 Sure, we can do that. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3417 in reviewboard: Windows RBT can't resolve Server
Comment #3 on issue 3417 by mda...@efficiencytree.com: Windows RBT can't
resolve Server
http://code.google.com/p/reviewboard/issues/detail?id=3417
That's the odd thing though only Python is having a DNS issue.
I tried even this simple hostname script I found online.
import socket
socket.gethostbyname('google.com')
Which fails, but I can ping google.com and get an IP just fine.
I tried adding to the host still nothing so something in python or at least
my install of it must be messed up.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Re: Issue 3415 in reviewboard: Incoming counts on left nav panel is different from no. of review requests displayed
Comment #5 on issue 3415 by trowb...@gmail.com: Incoming counts on left nav panel is different from no. of review requests displayed http://code.google.com/p/reviewboard/issues/detail?id=3415 If you want to look through the code, search for *_request_count -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3416 in reviewboard: 'Manual updates required' screen tells users to restart entire server
Updates: Status: PendingReview Owner: trowb...@gmail.com Labels: Component-WebUI Comment #1 on issue 3416 by trowb...@gmail.com: 'Manual updates required' screen tells users to restart entire server http://code.google.com/p/reviewboard/issues/detail?id=3416 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
