Migrating From modpython To wsgi After Upgrade From Reviewboard 1.6.11 To 2.0.2

[celliott]

We just upgraded our install from 1.6.11 to 2.0.2 and had serious problems 
getting things running because we were using the modpython Django library 
with the mod_python Apache module and that hasn't been supported for 
awhile. Since Django no longer supports modpython I'm wondering how I 
migrate to wsgi? If I have the mod_ wsgi Apache module loaded I'm assuming 
the only other thing that I need to do is update my Apache configuration 
file, is that accurate? How do I get a sample apache-wsgi.conf generated so 
I can modify my config with the correct data? Also, in the mean time, I 
copied over the modpython libraries from the 1.3.3 Django site-packages 
directory to the Django 1.6.5 site directory and this hack seems to have 
gotten things working again in the short term, do you think this could have 
any adverse effects on my site? Please let me know. Thanks. 

Also, we're running on CentOS 6.5, Apache 2.2.15, and Python 2.6.6. 

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Unable to use "New Review Request" to create requests with parent diffs

[Bruce Cran]

I agree, http 500 isn't at all useful: I think on my setup I was always
seeing an error saying there were no matching repositories found.

Christian's mention of Mirror Path was the hint I needed to look up the
documentation - from there I realised that entering the ssh:// URL that
developers use (Review Board accesses repos using a local path) would let
setup-repo start working.

-- 
Bruce


On Tue, Jun 17, 2014 at 2:55 PM, Sara Rayburn  wrote:

>
> Nowhere does that documentation refer to the fact that setup-repo will
> often fail with less than useful errors. I think that the error should be
> more useful (error 500 is not super helpful for the person trying to run
> the setup command) and that the docs should mention that setup-repo is only
> for the basic case, and explicitly state that you should custom configure
> in more unusual cases. I mean, we figured it out, so the info is there, I
> just think it could be clearer.
>
> Anyway, it seems to be working for me on all of my projects, and it's
> working for all of the window's developers. A couple of our programmers are
> still having problems, but I'm not sure if that's bugs or user error. If
> they aren't able to resolve their issues I'll post again with details.
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Requested revision does not exist, using Bazaar

[Brian]

Hi Adam,

You know, I hadn't thought about trying this, but I may give it a shot. 
Thanks for the idea!

Brian

On Tuesday, June 17, 2014 1:02:58 PM UTC-7, Adam wrote:
>
> Hi Brian,
>
> Have you tried using the bzr-diff-revid  plugin for Bazaar?
>
> https://launchpad.net/bzr-diff-revid
>
> From the description on the LP page:
>
> "bzr-diff-revid is a plugin for the Bazaar VCS. It tweaks the output of 
> "bzr diff": When possible, it includes the revid of the file version in the 
> diff header, instead of the timestamp. This works with Review Board's bzr 
> support to make diff loading reliable"
>
>
> When using bzr with ReviewBoard I found this plugin avoids the very issues 
> you describe.
>
> Adam
> On 17 Jun 2014, at 22:41, Brian > wrote:
>
> My hope at this point is that there was something wrong with the 
> repository. We've used this combination of tools for a couple of years with 
> no issue, even after a couple of server upgrades/reinstalls. 
>
> On Tuesday, June 17, 2014 12:12:47 PM UTC-7, Christian Hammond wrote:
>>
>> Hi Brian,
>>
>> So, I guess Bazaar requires a local timestamp when doing a 'date:’ query. 
>> Review Board attempts to convert the date in the diff to a local date that 
>> would match it. It sounds like something’s going terribly wrong there. I 
>> toyed with it briefly, but couldn’t reproduce the problem you’re hitting.
>>
>> Christian
>>
>> -- 
>> Christian Hammond - chri...@beanbaginc.com
>> Review Board - http://www.reviewboard.org
>> Beanbag, Inc. - http://www.beanbaginc.com
>>
>> On June 17, 2014 at 12:07:13 PM, Brian (phxg...@gmail.com) wrote:
>>
>> Hi Christian,
>>
>> So far I haven't found a pattern in the timestamps that are causing 
>> issues. I have upgraded one of our servers to use RB 2.0.2 and I also 
>> recreated the Bazaar repository that we were using. There are only two of 
>> us working on this project and very little history, so we didn't really 
>> lose anything. I'm hoping that our problem either goes away, or I will be 
>> able to find something when I check a diff after each commit we do.
>>
>> I'll keep you up to date on what I can find out.
>>
>> Thanks for looking into this!
>> Brian
>>
>> On Tuesday, June 17, 2014 3:40:28 AM UTC-7, Christian Hammond wrote: 
>>>
>>>  Hi Brian,
>>>  
>>>  Spent a little bit of time this evening trying to debug this, but no 
>>> real luck.
>>>  
>>>  Can you see if there’s anything in common with the timestamps where 
>>> things fail? Do they wrap around to a new day, new month, anything?
>>>  
>>>  Christian
>>>  
>>>   -- 
>>>  Christian Hammond - chri...@beanbaginc.com
>>>  Review Board - http://www.reviewboard.org 
>>> Beanbag, Inc. - http://www.beanbaginc.com
>>>  
>>> On June 12, 2014 at 3:44:13 PM, Brian (phxg...@gmail.com) wrote:
>>>
>>>  I can tell you what we know so far. When we have this issue, I trace 
>>> the "bad revision" back to what I can find in the Bazaar log for the file. 
>>> We are UTC-7, and the timestamp is usually 7 hours off from a match. This 
>>> may be the case for all files/revisions, I'm not sure yet. Most (if not 
>>> all) of our development machines are set to UTC, but maybe there is one 
>>> somewhere that is not and is affecting this. Typically we can edit the diff 
>>> to match the time in the bzr log and Review Board handles the diff with no 
>>> problem.
>>>
>>> In the last week, we have see an instance or two where this workaround 
>>> has not been successful.
>>>
>>> Separate, but maybe related, we have also had a couple of instances 
>>> where 1 of 24, or 2 of 6, or 4 of 4 diffs in a file did not apply cleanly. 
>>> We're not sure what happened with that exactly, but the timestamps in the 
>>> diff and log were off by 7 hours in those files too.
>>>
>>> I'm actually waiting for my IT person to make a copy of our server 
>>> template right now so I can debug this. I'm planning on getting things set 
>>> up to (hopefully) recreate the issue, then will try new versions of Review 
>>> Board to see if that helps any. If not, I'll look into creating a clean 
>>> Bazaar repository to see if that helps any.
>>>
>>> I'm also open to any other ideas you may have!
>>>
>>> Thanks,
>>> Brian
>>>
>>> On Thursday, June 12, 2014 3:26:31 PM UTC-7, Christian Hammond wrote: 

  Hi Brian,
  
  Can you go into more details on how the timestamps affect things? I’d 
 love to find a way to fix/workaround this in RBTools and/or Review Board.
  
  Christian
  
   -- 
  Christian Hammond - chri...@beanbaginc.com
  Review Board - http://www.reviewboard.org 
 Beanbag, Inc. - http://www.beanbaginc.com
  
 On June 12, 2014 at 3:23:28 PM, Brian (phxg...@gmail.com) wrote:

  Hi Rahul,

 The way we have worked around it so far is to manually edit the diff. 
 We find the timestamp in the bzr log that it "should" be (UTC in our 
 case), 
 then edit the diff to match. This had been ok for a while but it is not 
 working more and m

Re: Unable to use "New Review Request" to create requests with parent diffs

[Sara Rayburn]

Hi Bruce,

Nowhere does that documentation refer to the fact that setup-repo will
often fail with less than useful errors. I think that the error should be
more useful (error 500 is not super helpful for the person trying to run
the setup command) and that the docs should mention that setup-repo is only
for the basic case, and explicitly state that you should custom configure
in more unusual cases. I mean, we figured it out, so the info is there, I
just think it could be clearer.

Anyway, it seems to be working for me on all of my projects, and it's
working for all of the window's developers. A couple of our programmers are
still having problems, but I'm not sure if that's bugs or user error. If
they aren't able to resolve their issues I'll post again with details.

Sara


On Tue, Jun 17, 2014 at 3:42 PM, Bruce Cran  wrote:

> Isn't this covered in
> http://www.reviewboard.org/docs/rbtools/0.6/rbt/configuration/ ?
>
> --
> Bruce
>
>
>
> On Tue, Jun 17, 2014 at 1:49 PM, Sara Rayburn 
> wrote:
>
>> That makes sense. It would be nice to see a section in the RB Tools setup
>> documentation about what to do if the setup-repo command fails. I'm not
>> worried about it on our end.
>>
>  --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Sara Rayburn
(337) 322-5573
sararayb...@gmail.com

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Unable to use "New Review Request" to create requests with parent diffs

[Bruce Cran]

Isn't this covered in
http://www.reviewboard.org/docs/rbtools/0.6/rbt/configuration/ ?

-- 
Bruce


On Tue, Jun 17, 2014 at 1:49 PM, Sara Rayburn  wrote:

> That makes sense. It would be nice to see a section in the RB Tools setup
> documentation about what to do if the setup-repo command fails. I'm not
> worried about it on our end.
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Stuck writing an extension

[Marc Bryan]

Filed! Thanks for your help.

https://code.google.com/p/reviewboard/issues/detail?id=3423

On Tuesday, June 17, 2014 1:43:26 PM UTC-6, Christian Hammond wrote:
>
> Certainly. Always good to track these :) Might be a good student project 
> in the future.
>
> Thanks,
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
> On June 17, 2014 at 12:25:10 PM, Marc Bryan (marc...@gmail.com 
> ) wrote:
>
> Cool! Do you think it is worth filing this as an enhancement ticket?
>
> On Tuesday, June 17, 2014 1:19:41 PM UTC-6, Christian Hammond wrote: 
>>
>>  Hey Marc,
>>  
>>  I can certainly relate. Time’s a problem for me as well. I’d love to add 
>> this ability, and think it makes sense, but I can’t give you an ETA right 
>> now. Swamped with a large To Do list.
>>  
>>  If it were being written, what I’d expect is a hook that 
>> DashboardDataGrid’s view directly uses. It would take the ?view= provided 
>> to the URL, find the appropriate hook, and either render the queryset it 
>> provides through DashboardDataGrid, or render a custom DataGrid. There’s 
>> probably a lot to think through, like how the sidebar works, where things 
>> integrate, etc.
>>  
>>  Christian
>>  
>>   -- 
>>  Christian Hammond - chri...@beanbaginc.com
>>  Review Board - http://www.reviewboard.org 
>> Beanbag, Inc. - http://www.beanbaginc.com
>>  
>> On June 17, 2014 at 12:15:56 PM, Marc Bryan (marc...@gmail.com) wrote:
>>
>>  Thanks Christian. Makes sense to post to reviewboard-dev. :) 
>>
>> Are there any plans to add another extension point / change the way this 
>> works in the future? If I get a chance I can look into making a patch, but 
>> time is always the problem :D
>>
>> Marc
>>
>> On Monday, June 16, 2014 10:35:46 PM UTC-6, Christian Hammond wrote: 
>>>
>>>  Hi Marc,
>>>  
>>>  The reviewboard-dev list is a better place for these questions, since 
>>> there’s less traffic there and more people interested in RB-related 
>>> development.
>>>  
>>>  That said, the problem is that you cannot replace the dashboard. The 
>>> parameter for the datagrid in DataGridSidebarItemsHook is the class that 
>>> the sidebar should apply to, but it must be an existing, established 
>>> datagrid. What you’d have to do there is provide your own URL and view for 
>>> your this datagrid, render that there, and then link to that URL. That also 
>>> means you’ll need these hooks in two places, which is going to be a bit 
>>> annoying.
>>>  
>>>  It’s not ideal, but that’s how it works currently.
>>>  
>>>  Christian
>>>  
>>>   -- 
>>>  Christian Hammond - chri...@beanbaginc.com
>>>  Review Board - http://www.reviewboard.org 
>>> Beanbag, Inc. - http://www.beanbaginc.com
>>>  
>>> On June 16, 2014 at 11:24:54 AM, Marc Bryan (marc...@gmail.com) wrote:
>>>
>>>  Hi guys, 
>>>
>>> I'm having trouble writing a dashboard sidebar extension that adds 
>>> custom filters to the datagrid.
>>>
>>> ie. I would like to make a few different links, but an example of one 
>>> would be 'Needs More Reviews', which would filter the reviews by:
>>>  
>>>- less than 2 Ship-its (2 is our internal rule)
>>>- has no open reviews
>>>- not yours 
>>>
>>>  
>>> Here is what I have currently:
>>>
>>> *extension.py:*
>>>
>>>  class MySidebarSection(BaseSidebarSection):
>>> label = 'My Dashboard'
>>>
>>> def get_items(self):
>>> yield SidebarNavItem(self, 'My Requests to Push', view_id='push')
>>> yield SidebarNavItem(self, 'My Requests to Fix', view_id='fix')
>>> yield SidebarNavItem(self, 'Involved Reviews', 
>>> view_id='involved')
>>> yield SidebarNavItem(self, 'Needs More Reviews', 
>>> view_id='outstanding')
>>> yield SidebarNavItem(self, 'All Requests to Push', 
>>> view_id='approved')
>>>  
>>>  class MyDashboard(Extension):
>>> metadata = {
>>> 'Name': 'My Dashboard',
>>> 'Summary': 'Summary here',
>>> }
>>> is_configurable = True
>>>
>>> def initialize(self):
>>> # Your extension initialization is done here.
>>> DataGridSidebarItemsHook(self, MyDashboardDataGrid, 
>>> [MySidebarSection])
>>>  
>>>
>>> *datagrids.py*
>>>
>>>  class MyDashboardDataGrid(DashboardDataGrid):
>>> def load_extra_state(self, profile):
>>> # pass custom queryset and change title
>>> user = self.request.user
>>> fullPath = self.request.get_full_path()
>>> view = self.request.GET.get('view', self.default_view)
>>>
>>> q = Q(repository__name='MyRepo', target_groups__name='internal', 
>>> status='P')
>>>
>>>  if view == 'outstanding':
>>> q = q & Q(shipit_count__lt=2, issue_open_count=0)  # 
>>> TODO: make sure the review isn't yours
>>> self.queryset = ReviewRequest.objects.filter(q)
>>> self.title = _('Requests That Need Reviews (Reviews with 
>>> # ship-its < 2, no open issues, not yours)')

Re: Requested revision does not exist, using Bazaar

[Adam Collard]

Hi Brian,

Have you tried using the bzr-diff-revid  plugin for Bazaar?

https://launchpad.net/bzr-diff-revid

>From the description on the LP page:

"bzr-diff-revid is a plugin for the Bazaar VCS. It tweaks the output of "bzr 
diff": When possible, it includes the revid of the file version in the diff 
header, instead of the timestamp. This works with Review Board's bzr support to 
make diff loading reliable"


When using bzr with ReviewBoard I found this plugin avoids the very issues you 
describe.

Adam

> On 17 Jun 2014, at 22:41, Brian  wrote:
> 
> My hope at this point is that there was something wrong with the repository. 
> We've used this combination of tools for a couple of years with no issue, 
> even after a couple of server upgrades/reinstalls. 
> 
>> On Tuesday, June 17, 2014 12:12:47 PM UTC-7, Christian Hammond wrote:
>> Hi Brian,
>> 
>> So, I guess Bazaar requires a local timestamp when doing a 'date:’ query. 
>> Review Board attempts to convert the date in the diff to a local date that 
>> would match it. It sounds like something’s going terribly wrong there. I 
>> toyed with it briefly, but couldn’t reproduce the problem you’re hitting.
>> 
>> Christian
>> 
>> -- 
>> Christian Hammond - chri...@beanbaginc.com
>> Review Board - http://www.reviewboard.org
>> Beanbag, Inc. - http://www.beanbaginc.com
>> 
>>> On June 17, 2014 at 12:07:13 PM, Brian (phxg...@gmail.com) wrote:
>>> 
>>> Hi Christian,
>>> 
>>> So far I haven't found a pattern in the timestamps that are causing issues. 
>>> I have upgraded one of our servers to use RB 2.0.2 and I also recreated the 
>>> Bazaar repository that we were using. There are only two of us working on 
>>> this project and very little history, so we didn't really lose anything. 
>>> I'm hoping that our problem either goes away, or I will be able to find 
>>> something when I check a diff after each commit we do.
>>> 
>>> I'll keep you up to date on what I can find out.
>>> 
>>> Thanks for looking into this!
>>> Brian
>>> 
 On Tuesday, June 17, 2014 3:40:28 AM UTC-7, Christian Hammond wrote: 
 Hi Brian,
 
 Spent a little bit of time this evening trying to debug this, but no real 
 luck.
 
 Can you see if there’s anything in common with the timestamps where things 
 fail? Do they wrap around to a new day, new month, anything?
 
 Christian
 
 -- 
 Christian Hammond - chri...@beanbaginc.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com
 
> On June 12, 2014 at 3:44:13 PM, Brian (phxg...@gmail.com) wrote:
> 
> I can tell you what we know so far. When we have this issue, I trace the 
> "bad revision" back to what I can find in the Bazaar log for the file. We 
> are UTC-7, and the timestamp is usually 7 hours off from a match. This 
> may be the case for all files/revisions, I'm not sure yet. Most (if not 
> all) of our development machines are set to UTC, but maybe there is one 
> somewhere that is not and is affecting this. Typically we can edit the 
> diff to match the time in the bzr log and Review Board handles the diff 
> with no problem.
> 
> In the last week, we have see an instance or two where this workaround 
> has not been successful.
> 
> Separate, but maybe related, we have also had a couple of instances where 
> 1 of 24, or 2 of 6, or 4 of 4 diffs in a file did not apply cleanly. 
> We're not sure what happened with that exactly, but the timestamps in the 
> diff and log were off by 7 hours in those files too.
> 
> I'm actually waiting for my IT person to make a copy of our server 
> template right now so I can debug this. I'm planning on getting things 
> set up to (hopefully) recreate the issue, then will try new versions of 
> Review Board to see if that helps any. If not, I'll look into creating a 
> clean Bazaar repository to see if that helps any.
> 
> I'm also open to any other ideas you may have!
> 
> Thanks,
> Brian
> 
>> On Thursday, June 12, 2014 3:26:31 PM UTC-7, Christian Hammond wrote:
>> Hi Brian,
>> 
>> Can you go into more details on how the timestamps affect things? I’d 
>> love to find a way to fix/workaround this in RBTools and/or Review Board.
>> 
>> Christian
>> 
>> -- 
>> Christian Hammond - chri...@beanbaginc.com
>> Review Board - http://www.reviewboard.org
>> Beanbag, Inc. - http://www.beanbaginc.com
>> 
>>> On June 12, 2014 at 3:23:28 PM, Brian (phxg...@gmail.com) wrote:
>>> 
>>> Hi Rahul,
>>> 
>>> The way we have worked around it so far is to manually edit the diff. 
>>> We find the timestamp in the bzr log that it "should" be (UTC in our 
>>> case), then edit the diff to match. This had been ok for a while but it 
>>> is not working more and more often now. I'm actually about to start 
>>> debugging it a little more, 

Re: Unable to use "New Review Request" to create requests with parent diffs

[Sara Rayburn]

That makes sense. It would be nice to see a section in the RB Tools setup
documentation about what to do if the setup-repo command fails. I'm not
worried about it on our end.


On Tue, Jun 17, 2014 at 2:42 PM, Christian Hammond  wrote:

> Hi Sara,
>
> Okay, that’s why. ‘rbt setup-repo’ is really intended for the typical case
> where the paths more or less match up. If your Path or Mirror Path looked
> like the ssh:// URL, they would have been found.
>
> Christian
>
> --
> Christian Hammond - christ...@beanbaginc.com
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
> On June 17, 2014 at 12:28:30 PM, Sara Rayburn (sararayb...@gmail.com)
> wrote:
>
>  Hi Christian,
>
> All of our repos are mercurial repos.
>
> An example Path would be "/data_local/hg-repository/foo". The mirror path
> is unused and unconfigured in all cases.
> We clone from "ssh://devel.ourserver.com//devel/src/hg-repository/foo"
>
>
> On Tue, Jun 17, 2014 at 2:22 PM, Christian Hammond <
> christ...@beanbaginc.com> wrote:
>
>>  What type of repository is it?
>>
>>  It’d be really helpful to have the Path and Mirror Path fields from the
>> desired Repository entry, and have the URL you use locally to check out the
>> repository, so that we can figure out what’s going wrong.
>>
>>  Christian
>>
>>   --
>>  Christian Hammond - christ...@beanbaginc.com
>>  Review Board - http://www.reviewboard.org
>> Beanbag, Inc. - http://www.beanbaginc.com
>>
>>  On June 17, 2014 at 9:41:10 AM, Bruce Cran (bruce.c...@gmail.com) wrote:
>>
>>   Yeah, I've found that setup-repo doesn't work for us either. For now I
>> always use both --server and --repository, though I should just do the
>> setup manually.
>> With RBTools 0.6.1,  setup-repo asks about 3 repos (whether they're the
>> one I want to use) but they're all wrong.
>>
>> --
>> Bruce
>>
>>
>> On Tue, Jun 17, 2014 at 9:36 AM, Sara Rayburn 
>> wrote:
>>
>>>  Well, we were able to get things working with RB Tools after a
>>> fashion. The rbt setup-repo command always failed to find the repository,
>>> returning an error 500. If we run rbt post --repository="foo", however,
>>> everything works fine. I think the setup-repo command either fails because
>>> we do not have the hg svn extension installed or because the default path
>>> for our repo (ssh://) does not match the path we use for reviewboard
>>> (we keep a local clone /data_local/hg-repo/foo). If you are interested in
>>> further details, I can post debug output.
>>>
>>> Sara
>>>
>>>
>>> On Mon, Jun 16, 2014 at 11:32 PM, Christian Hammond <
>>> christ...@beanbaginc.com> wrote:
>>>
  What’s going wrong with the configuration?

  Christian

   --
  Christian Hammond - christ...@beanbaginc.com
  Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

  On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com)
 wrote:

   Hi,

 Bruce, the installer works for our Windows guys just fine. Thanks for
 putting that together!

 Unfortunately, we can't seem to get RB Tools configured properly for
 anyone, but that's a question for another day.

 Sara


 On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond <
 christ...@beanbaginc.com> wrote:

>  Awesome :)
>
>  Under rbtools/contrib/installer/ would probably be best. We may end
> up moving it, but that’s ag ood starting point.
>
>  rb-win32-installer is an old repository that can be pretty much
> ignored at this point.
>
>  Christian
>
>   --
>  Christian Hammond - christ...@beanbaginc.com
>  Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
>  On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com)
> wrote:
>
>   Christian,
>
> Yes, I was hoping I'd be able to contribute the code to make future
> maintenance simpler.
>
> Which repo and in which directory would it be added? I see there's a
> old rb-win32-installer repository on github for Review Board - would it be
> there, or under contrib/ in the rbtools repo etc.?
>
> --
> Bruce
>
>
> On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond <
> christ...@beanbaginc.com> wrote:
>
>>  Hi Bruce,
>>
>>  That’s fantastic. I just installed in a fresh VM, and had RBTools
>> up-and-running in just a couple minutes.
>>
>>  Would you be willing to contribute the source to the installer? I’d
>> like to ship an official installer with our future releases.
>>
>   --
> Get the Review Board Power Pack at
> http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to

Re: Stuck writing an extension

[Christian Hammond]

Certainly. Always good to track these :) Might be a good student project in the 
future.

Thanks,

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 17, 2014 at 12:25:10 PM, Marc Bryan (marc2...@gmail.com) wrote:

Cool! Do you think it is worth filing this as an enhancement ticket?

On Tuesday, June 17, 2014 1:19:41 PM UTC-6, Christian Hammond wrote:
Hey Marc,

I can certainly relate. Time’s a problem for me as well. I’d love to add this 
ability, and think it makes sense, but I can’t give you an ETA right now. 
Swamped with a large To Do list.

If it were being written, what I’d expect is a hook that DashboardDataGrid’s 
view directly uses. It would take the ?view= provided to the URL, find the 
appropriate hook, and either render the queryset it provides through 
DashboardDataGrid, or render a custom DataGrid. There’s probably a lot to think 
through, like how the sidebar works, where things integrate, etc.

Christian

-- 
Christian Hammond - chri...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 17, 2014 at 12:15:56 PM, Marc Bryan (marc...@gmail.com) wrote:

Thanks Christian. Makes sense to post to reviewboard-dev. :)

Are there any plans to add another extension point / change the way this works 
in the future? If I get a chance I can look into making a patch, but time is 
always the problem :D

Marc

On Monday, June 16, 2014 10:35:46 PM UTC-6, Christian Hammond wrote:
Hi Marc,

The reviewboard-dev list is a better place for these questions, since there’s 
less traffic there and more people interested in RB-related development.

That said, the problem is that you cannot replace the dashboard. The parameter 
for the datagrid in DataGridSidebarItemsHook is the class that the sidebar 
should apply to, but it must be an existing, established datagrid. What you’d 
have to do there is provide your own URL and view for your this datagrid, 
render that there, and then link to that URL. That also means you’ll need these 
hooks in two places, which is going to be a bit annoying.

It’s not ideal, but that’s how it works currently.

Christian

-- 
Christian Hammond - chri...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 16, 2014 at 11:24:54 AM, Marc Bryan (marc...@gmail.com) wrote:

Hi guys,

I'm having trouble writing a dashboard sidebar extension that adds custom 
filters to the datagrid.

ie. I would like to make a few different links, but an example of one would be 
'Needs More Reviews', which would filter the reviews by:
less than 2 Ship-its (2 is our internal rule)
has no open reviews
not yours

Here is what I have currently:

extension.py:

class MySidebarSection(BaseSidebarSection):
    label = 'My Dashboard'

    def get_items(self):
        yield SidebarNavItem(self, 'My Requests to Push', view_id='push')
        yield SidebarNavItem(self, 'My Requests to Fix', view_id='fix')
        yield SidebarNavItem(self, 'Involved Reviews', view_id='involved')
        yield SidebarNavItem(self, 'Needs More Reviews', view_id='outstanding')
        yield SidebarNavItem(self, 'All Requests to Push', view_id='approved')

class MyDashboard(Extension):
    metadata = {
        'Name': 'My Dashboard',
        'Summary': 'Summary here',
    }
    is_configurable = True

    def initialize(self):
        # Your extension initialization is done here.
        DataGridSidebarItemsHook(self, MyDashboardDataGrid, [MySidebarSection])


datagrids.py

class MyDashboardDataGrid(DashboardDataGrid):
    def load_extra_state(self, profile):
        # pass custom queryset and change title
        user = self.request.user
        fullPath = self.request.get_full_path()
        view = self.request.GET.get('view', self.default_view)

        q = Q(repository__name='MyRepo', target_groups__name='internal', 
status='P')

        if view == 'outstanding':
                q = q & Q(shipit_count__lt=2, issue_open_count=0)  # TODO: make 
sure the review isn't yours
                self.queryset = ReviewRequest.objects.filter(q)
                self.title = _('Requests That Need Reviews (Reviews with # 
ship-its < 2, no open issues, not yours)')

        return super(MyDashboardDataGrid, self).load_extra_state(profile)



I assume this is all I need to do, but I keep getting this error when I click 
on the 'Needs More Reviews' link.

Page not found (404)
Request Method: GET
Request URL: http://0.0.0.0:8080/dashboard/?view=outstanding

This 404 is being raised by DashboardDataGrid.load_extra_state().

It seems as if DataGridSidebarItemsHook isn't using MyDashboardDataGrid but 
instead using DashboardDataGrid.

Is there anything I am missing?

Thanks for your help.

Marc
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happ

Re: Unable to use "New Review Request" to create requests with parent diffs

[Christian Hammond]

Hi Sara,

Okay, that’s why. ‘rbt setup-repo’ is really intended for the typical case 
where the paths more or less match up. If your Path or Mirror Path looked like 
the ssh:// URL, they would have been found.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 17, 2014 at 12:28:30 PM, Sara Rayburn (sararayb...@gmail.com) wrote:

Hi Christian,

All of our repos are mercurial repos.

An example Path would be "/data_local/hg-repository/foo". The mirror path is 
unused and unconfigured in all cases.
We clone from "ssh://devel.ourserver.com//devel/src/hg-repository/foo"


On Tue, Jun 17, 2014 at 2:22 PM, Christian Hammond  
wrote:
What type of repository is it?

It’d be really helpful to have the Path and Mirror Path fields from the desired 
Repository entry, and have the URL you use locally to check out the repository, 
so that we can figure out what’s going wrong.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 17, 2014 at 9:41:10 AM, Bruce Cran (bruce.c...@gmail.com) wrote:

Yeah, I've found that setup-repo doesn't work for us either. For now I always 
use both --server and --repository, though I should just do the setup manually.
With RBTools 0.6.1,  setup-repo asks about 3 repos (whether they're the one I 
want to use) but they're all wrong.

--
Bruce


On Tue, Jun 17, 2014 at 9:36 AM, Sara Rayburn  wrote:
Well, we were able to get things working with RB Tools after a fashion. The rbt 
setup-repo command always failed to find the repository, returning an error 
500. If we run rbt post --repository="foo", however, everything works fine. I 
think the setup-repo command either fails because we do not have the hg svn 
extension installed or because the default path for our repo (ssh://) does 
not match the path we use for reviewboard (we keep a local clone 
/data_local/hg-repo/foo). If you are interested in further details, I can post 
debug output.

Sara


On Mon, Jun 16, 2014 at 11:32 PM, Christian Hammond  
wrote:
What’s going wrong with the configuration?

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com) wrote:

Hi,

Bruce, the installer works for our Windows guys just fine. Thanks for putting 
that together!

Unfortunately, we can't seem to get RB Tools configured properly for anyone, 
but that's a question for another day.

Sara


On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond  
wrote:
Awesome :)

Under rbtools/contrib/installer/ would probably be best. We may end up moving 
it, but that’s ag ood starting point.

rb-win32-installer is an old repository that can be pretty much ignored at this 
point.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com) wrote:

Christian,

Yes, I was hoping I'd be able to contribute the code to make future maintenance 
simpler.

Which repo and in which directory would it be added? I see there's a old 
rb-win32-installer repository on github for Review Board - would it be there, 
or under contrib/ in the rbtools repo etc.?

--
Bruce


On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond  
wrote:
Hi Bruce,

That’s fantastic. I just installed in a fresh VM, and had RBTools 
up-and-running in just a couple minutes.

Would you be willing to contribute the source to the installer? I’d like to 
ship an official installer with our future releases.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.



--
Sara Rayburn
(337) 322-5573
sararayb...@gmail.com
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let

Re: Requested revision does not exist, using Bazaar

[Brian]

My hope at this point is that there was something wrong with the 
repository. We've used this combination of tools for a couple of years with 
no issue, even after a couple of server upgrades/reinstalls. 

On Tuesday, June 17, 2014 12:12:47 PM UTC-7, Christian Hammond wrote:
>
> Hi Brian,
>
> So, I guess Bazaar requires a local timestamp when doing a 'date:’ query. 
> Review Board attempts to convert the date in the diff to a local date that 
> would match it. It sounds like something’s going terribly wrong there. I 
> toyed with it briefly, but couldn’t reproduce the problem you’re hitting.
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
> On June 17, 2014 at 12:07:13 PM, Brian (phxg...@gmail.com ) 
> wrote:
>
> Hi Christian,
>
> So far I haven't found a pattern in the timestamps that are causing 
> issues. I have upgraded one of our servers to use RB 2.0.2 and I also 
> recreated the Bazaar repository that we were using. There are only two of 
> us working on this project and very little history, so we didn't really 
> lose anything. I'm hoping that our problem either goes away, or I will be 
> able to find something when I check a diff after each commit we do.
>
> I'll keep you up to date on what I can find out.
>
> Thanks for looking into this!
> Brian
>
> On Tuesday, June 17, 2014 3:40:28 AM UTC-7, Christian Hammond wrote: 
>>
>>  Hi Brian,
>>  
>>  Spent a little bit of time this evening trying to debug this, but no 
>> real luck.
>>  
>>  Can you see if there’s anything in common with the timestamps where 
>> things fail? Do they wrap around to a new day, new month, anything?
>>  
>>  Christian
>>  
>>   -- 
>>  Christian Hammond - chri...@beanbaginc.com
>>  Review Board - http://www.reviewboard.org 
>> Beanbag, Inc. - http://www.beanbaginc.com
>>  
>> On June 12, 2014 at 3:44:13 PM, Brian (phxg...@gmail.com) wrote:
>>
>>  I can tell you what we know so far. When we have this issue, I trace 
>> the "bad revision" back to what I can find in the Bazaar log for the file. 
>> We are UTC-7, and the timestamp is usually 7 hours off from a match. This 
>> may be the case for all files/revisions, I'm not sure yet. Most (if not 
>> all) of our development machines are set to UTC, but maybe there is one 
>> somewhere that is not and is affecting this. Typically we can edit the diff 
>> to match the time in the bzr log and Review Board handles the diff with no 
>> problem.
>>
>> In the last week, we have see an instance or two where this workaround 
>> has not been successful.
>>
>> Separate, but maybe related, we have also had a couple of instances where 
>> 1 of 24, or 2 of 6, or 4 of 4 diffs in a file did not apply cleanly. We're 
>> not sure what happened with that exactly, but the timestamps in the diff 
>> and log were off by 7 hours in those files too.
>>
>> I'm actually waiting for my IT person to make a copy of our server 
>> template right now so I can debug this. I'm planning on getting things set 
>> up to (hopefully) recreate the issue, then will try new versions of Review 
>> Board to see if that helps any. If not, I'll look into creating a clean 
>> Bazaar repository to see if that helps any.
>>
>> I'm also open to any other ideas you may have!
>>
>> Thanks,
>> Brian
>>
>> On Thursday, June 12, 2014 3:26:31 PM UTC-7, Christian Hammond wrote: 
>>>
>>>  Hi Brian,
>>>  
>>>  Can you go into more details on how the timestamps affect things? I’d 
>>> love to find a way to fix/workaround this in RBTools and/or Review Board.
>>>  
>>>  Christian
>>>  
>>>   -- 
>>>  Christian Hammond - chri...@beanbaginc.com
>>>  Review Board - http://www.reviewboard.org 
>>> Beanbag, Inc. - http://www.beanbaginc.com
>>>  
>>> On June 12, 2014 at 3:23:28 PM, Brian (phxg...@gmail.com) wrote:
>>>
>>>  Hi Rahul,
>>>
>>> The way we have worked around it so far is to manually edit the diff. We 
>>> find the timestamp in the bzr log that it "should" be (UTC in our case), 
>>> then edit the diff to match. This had been ok for a while but it is not 
>>> working more and more often now. I'm actually about to start debugging it a 
>>> little more, I'm not entirely convince it's a Bazaar issue.
>>>
>>> I'll post more if I can figure out what is going on.
>>>
>>> Brian
>>>
>>> On Thursday, June 12, 2014 4:47:01 AM UTC-7, Rahul Sisondia wrote: 

 Hi Brian,  

 I am also facing same issue. So what is the solution or workaround for 
 this problem ? 

 Thanks 
 Rahul 

 On Thursday, April 17, 2014 2:28:29 AM UTC+5:30, Brian wrote: 
>
> Following up on this... we found that the developer creating the diff 
> had a different time zone on his machine than the server. So it was 
> actually a Bazaar issue, not being able to match the times in the 
> checkouts.
>
> On Friday, February 28, 2014 12:46:16 PM UTC-7, Brian wrote: 
>>
>> Hello,
>>
>> We ar

Re: Unable to use "New Review Request" to create requests with parent diffs

[Sara Rayburn]

Hi Christian,

All of our repos are mercurial repos.

An example Path would be "/data_local/hg-repository/foo". The mirror path
is unused and unconfigured in all cases.
We clone from "ssh://devel.ourserver.com//devel/src/hg-repository/foo"


On Tue, Jun 17, 2014 at 2:22 PM, Christian Hammond  wrote:

> What type of repository is it?
>
> It’d be really helpful to have the Path and Mirror Path fields from the
> desired Repository entry, and have the URL you use locally to check out the
> repository, so that we can figure out what’s going wrong.
>
> Christian
>
> --
> Christian Hammond - christ...@beanbaginc.com
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
> On June 17, 2014 at 9:41:10 AM, Bruce Cran (bruce.c...@gmail.com) wrote:
>
>  Yeah, I've found that setup-repo doesn't work for us either. For now I
> always use both --server and --repository, though I should just do the
> setup manually.
> With RBTools 0.6.1,  setup-repo asks about 3 repos (whether they're the
> one I want to use) but they're all wrong.
>
> --
> Bruce
>
>
> On Tue, Jun 17, 2014 at 9:36 AM, Sara Rayburn 
> wrote:
>
>>  Well, we were able to get things working with RB Tools after a fashion.
>> The rbt setup-repo command always failed to find the repository, returning
>> an error 500. If we run rbt post --repository="foo", however, everything
>> works fine. I think the setup-repo command either fails because we do not
>> have the hg svn extension installed or because the default path for our
>> repo (ssh://) does not match the path we use for reviewboard (we keep a
>> local clone /data_local/hg-repo/foo). If you are interested in further
>> details, I can post debug output.
>>
>> Sara
>>
>>
>> On Mon, Jun 16, 2014 at 11:32 PM, Christian Hammond <
>> christ...@beanbaginc.com> wrote:
>>
>>>  What’s going wrong with the configuration?
>>>
>>>  Christian
>>>
>>>   --
>>>  Christian Hammond - christ...@beanbaginc.com
>>>  Review Board - http://www.reviewboard.org
>>> Beanbag, Inc. - http://www.beanbaginc.com
>>>
>>>  On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com)
>>> wrote:
>>>
>>>   Hi,
>>>
>>> Bruce, the installer works for our Windows guys just fine. Thanks for
>>> putting that together!
>>>
>>> Unfortunately, we can't seem to get RB Tools configured properly for
>>> anyone, but that's a question for another day.
>>>
>>> Sara
>>>
>>>
>>> On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond <
>>> christ...@beanbaginc.com> wrote:
>>>
  Awesome :)

  Under rbtools/contrib/installer/ would probably be best. We may end up
 moving it, but that’s ag ood starting point.

  rb-win32-installer is an old repository that can be pretty much
 ignored at this point.

  Christian

   --
  Christian Hammond - christ...@beanbaginc.com
  Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

  On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com)
 wrote:

   Christian,

 Yes, I was hoping I'd be able to contribute the code to make future
 maintenance simpler.

 Which repo and in which directory would it be added? I see there's a
 old rb-win32-installer repository on github for Review Board - would it be
 there, or under contrib/ in the rbtools repo etc.?

 --
 Bruce


 On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond <
 christ...@beanbaginc.com> wrote:

>  Hi Bruce,
>
>  That’s fantastic. I just installed in a fresh VM, and had RBTools
> up-and-running in just a couple minutes.
>
>  Would you be willing to contribute the source to the installer? I’d
> like to ship an official installer with our future releases.
>
   --
 Get the Review Board Power Pack at
 http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups "reviewboard" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

   --
 Get the Review Board Power Pack at
 http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups "reviewboard" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

>>>
>>>
>>>
>>> --
>>>  Sara Rayburn
>>> (337) 322

Re: Stuck writing an extension

[Marc Bryan]

Cool! Do you think it is worth filing this as an enhancement ticket?

On Tuesday, June 17, 2014 1:19:41 PM UTC-6, Christian Hammond wrote:
>
> Hey Marc,
>
> I can certainly relate. Time’s a problem for me as well. I’d love to add 
> this ability, and think it makes sense, but I can’t give you an ETA right 
> now. Swamped with a large To Do list.
>
> If it were being written, what I’d expect is a hook that 
> DashboardDataGrid’s view directly uses. It would take the ?view= provided 
> to the URL, find the appropriate hook, and either render the queryset it 
> provides through DashboardDataGrid, or render a custom DataGrid. There’s 
> probably a lot to think through, like how the sidebar works, where things 
> integrate, etc.
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
> On June 17, 2014 at 12:15:56 PM, Marc Bryan (marc...@gmail.com 
> ) wrote:
>
> Thanks Christian. Makes sense to post to reviewboard-dev. :) 
>
> Are there any plans to add another extension point / change the way this 
> works in the future? If I get a chance I can look into making a patch, but 
> time is always the problem :D
>
> Marc
>
> On Monday, June 16, 2014 10:35:46 PM UTC-6, Christian Hammond wrote: 
>>
>>  Hi Marc,
>>  
>>  The reviewboard-dev list is a better place for these questions, since 
>> there’s less traffic there and more people interested in RB-related 
>> development.
>>  
>>  That said, the problem is that you cannot replace the dashboard. The 
>> parameter for the datagrid in DataGridSidebarItemsHook is the class that 
>> the sidebar should apply to, but it must be an existing, established 
>> datagrid. What you’d have to do there is provide your own URL and view for 
>> your this datagrid, render that there, and then link to that URL. That also 
>> means you’ll need these hooks in two places, which is going to be a bit 
>> annoying.
>>  
>>  It’s not ideal, but that’s how it works currently.
>>  
>>  Christian
>>  
>>   -- 
>>  Christian Hammond - chri...@beanbaginc.com
>>  Review Board - http://www.reviewboard.org 
>> Beanbag, Inc. - http://www.beanbaginc.com
>>  
>> On June 16, 2014 at 11:24:54 AM, Marc Bryan (marc...@gmail.com) wrote:
>>
>>  Hi guys, 
>>
>> I'm having trouble writing a dashboard sidebar extension that adds custom 
>> filters to the datagrid.
>>
>> ie. I would like to make a few different links, but an example of one 
>> would be 'Needs More Reviews', which would filter the reviews by:
>>  
>>- less than 2 Ship-its (2 is our internal rule)
>>- has no open reviews
>>- not yours 
>>
>>  
>> Here is what I have currently:
>>
>> *extension.py:*
>>
>>  class MySidebarSection(BaseSidebarSection):
>> label = 'My Dashboard'
>>
>> def get_items(self):
>> yield SidebarNavItem(self, 'My Requests to Push', view_id='push')
>> yield SidebarNavItem(self, 'My Requests to Fix', view_id='fix')
>> yield SidebarNavItem(self, 'Involved Reviews', view_id='involved')
>> yield SidebarNavItem(self, 'Needs More Reviews', 
>> view_id='outstanding')
>> yield SidebarNavItem(self, 'All Requests to Push', 
>> view_id='approved')
>>  
>>  class MyDashboard(Extension):
>> metadata = {
>> 'Name': 'My Dashboard',
>> 'Summary': 'Summary here',
>> }
>> is_configurable = True
>>
>> def initialize(self):
>> # Your extension initialization is done here.
>> DataGridSidebarItemsHook(self, MyDashboardDataGrid, 
>> [MySidebarSection])
>>  
>>
>> *datagrids.py*
>>
>>  class MyDashboardDataGrid(DashboardDataGrid):
>> def load_extra_state(self, profile):
>> # pass custom queryset and change title
>> user = self.request.user
>> fullPath = self.request.get_full_path()
>> view = self.request.GET.get('view', self.default_view)
>>
>> q = Q(repository__name='MyRepo', target_groups__name='internal', 
>> status='P')
>>
>>  if view == 'outstanding':
>> q = q & Q(shipit_count__lt=2, issue_open_count=0)  # 
>> TODO: make sure the review isn't yours
>> self.queryset = ReviewRequest.objects.filter(q)
>> self.title = _('Requests That Need Reviews (Reviews with 
>> # ship-its < 2, no open issues, not yours)')
>>
>> return super(MyDashboardDataGrid, self).load_extra_state(profile)
>>  
>>
>>
>> I assume this is all I need to do, but I keep getting this error when I 
>> click on the 'Needs More Reviews' link.
>>
>>  Page not found (404)
>> Request Method: GET
>> Request URL: http://0.0.0.0:8080/dashboard/?view=outstanding
>>  
>> This 404 is being raised by DashboardDataGrid.load_extra_state().
>>
>> It seems as if DataGridSidebarItemsHook isn't using MyDashboardDataGrid 
>> but instead using DashboardDataGrid.
>>
>> Is there anything I am missing?
>>
>> Thanks for your help.
>>
>> Marc
>>  --
>> Get the Review Board Power Pack at http://

Re: Unable to use "New Review Request" to create requests with parent diffs

[Christian Hammond]

What type of repository is it?

It’d be really helpful to have the Path and Mirror Path fields from the desired 
Repository entry, and have the URL you use locally to check out the repository, 
so that we can figure out what’s going wrong.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 17, 2014 at 9:41:10 AM, Bruce Cran (bruce.c...@gmail.com) wrote:

Yeah, I've found that setup-repo doesn't work for us either. For now I always 
use both --server and --repository, though I should just do the setup manually.
With RBTools 0.6.1,  setup-repo asks about 3 repos (whether they're the one I 
want to use) but they're all wrong.

--
Bruce


On Tue, Jun 17, 2014 at 9:36 AM, Sara Rayburn  wrote:
Well, we were able to get things working with RB Tools after a fashion. The rbt 
setup-repo command always failed to find the repository, returning an error 
500. If we run rbt post --repository="foo", however, everything works fine. I 
think the setup-repo command either fails because we do not have the hg svn 
extension installed or because the default path for our repo (ssh://) does 
not match the path we use for reviewboard (we keep a local clone 
/data_local/hg-repo/foo). If you are interested in further details, I can post 
debug output.

Sara


On Mon, Jun 16, 2014 at 11:32 PM, Christian Hammond  
wrote:
What’s going wrong with the configuration?

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com) wrote:

Hi,

Bruce, the installer works for our Windows guys just fine. Thanks for putting 
that together!

Unfortunately, we can't seem to get RB Tools configured properly for anyone, 
but that's a question for another day.

Sara


On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond  
wrote:
Awesome :)

Under rbtools/contrib/installer/ would probably be best. We may end up moving 
it, but that’s ag ood starting point.

rb-win32-installer is an old repository that can be pretty much ignored at this 
point.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com) wrote:

Christian,

Yes, I was hoping I'd be able to contribute the code to make future maintenance 
simpler.

Which repo and in which directory would it be added? I see there's a old 
rb-win32-installer repository on github for Review Board - would it be there, 
or under contrib/ in the rbtools repo etc.?

--
Bruce


On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond  
wrote:
Hi Bruce,

That’s fantastic. I just installed in a fresh VM, and had RBTools 
up-and-running in just a couple minutes.

Would you be willing to contribute the source to the installer? I’d like to 
ship an official installer with our future releases.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.



--
Sara Rayburn
(337) 322-5573
sararayb...@gmail.com
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to review

Re: Stuck writing an extension

[Christian Hammond]

Hey Marc,

I can certainly relate. Time’s a problem for me as well. I’d love to add this 
ability, and think it makes sense, but I can’t give you an ETA right now. 
Swamped with a large To Do list.

If it were being written, what I’d expect is a hook that DashboardDataGrid’s 
view directly uses. It would take the ?view= provided to the URL, find the 
appropriate hook, and either render the queryset it provides through 
DashboardDataGrid, or render a custom DataGrid. There’s probably a lot to think 
through, like how the sidebar works, where things integrate, etc.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 17, 2014 at 12:15:56 PM, Marc Bryan (marc2...@gmail.com) wrote:

Thanks Christian. Makes sense to post to reviewboard-dev. :)

Are there any plans to add another extension point / change the way this works 
in the future? If I get a chance I can look into making a patch, but time is 
always the problem :D

Marc

On Monday, June 16, 2014 10:35:46 PM UTC-6, Christian Hammond wrote:
Hi Marc,

The reviewboard-dev list is a better place for these questions, since there’s 
less traffic there and more people interested in RB-related development.

That said, the problem is that you cannot replace the dashboard. The parameter 
for the datagrid in DataGridSidebarItemsHook is the class that the sidebar 
should apply to, but it must be an existing, established datagrid. What you’d 
have to do there is provide your own URL and view for your this datagrid, 
render that there, and then link to that URL. That also means you’ll need these 
hooks in two places, which is going to be a bit annoying.

It’s not ideal, but that’s how it works currently.

Christian

-- 
Christian Hammond - chri...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 16, 2014 at 11:24:54 AM, Marc Bryan (marc...@gmail.com) wrote:

Hi guys,

I'm having trouble writing a dashboard sidebar extension that adds custom 
filters to the datagrid.

ie. I would like to make a few different links, but an example of one would be 
'Needs More Reviews', which would filter the reviews by:
less than 2 Ship-its (2 is our internal rule)
has no open reviews
not yours

Here is what I have currently:

extension.py:

class MySidebarSection(BaseSidebarSection):
    label = 'My Dashboard'

    def get_items(self):
        yield SidebarNavItem(self, 'My Requests to Push', view_id='push')
        yield SidebarNavItem(self, 'My Requests to Fix', view_id='fix')
        yield SidebarNavItem(self, 'Involved Reviews', view_id='involved')
        yield SidebarNavItem(self, 'Needs More Reviews', view_id='outstanding')
        yield SidebarNavItem(self, 'All Requests to Push', view_id='approved')

class MyDashboard(Extension):
    metadata = {
        'Name': 'My Dashboard',
        'Summary': 'Summary here',
    }
    is_configurable = True

    def initialize(self):
        # Your extension initialization is done here.
        DataGridSidebarItemsHook(self, MyDashboardDataGrid, [MySidebarSection])


datagrids.py

class MyDashboardDataGrid(DashboardDataGrid):
    def load_extra_state(self, profile):
        # pass custom queryset and change title
        user = self.request.user
        fullPath = self.request.get_full_path()
        view = self.request.GET.get('view', self.default_view)

        q = Q(repository__name='MyRepo', target_groups__name='internal', 
status='P')

        if view == 'outstanding':
                q = q & Q(shipit_count__lt=2, issue_open_count=0)  # TODO: make 
sure the review isn't yours
                self.queryset = ReviewRequest.objects.filter(q)
                self.title = _('Requests That Need Reviews (Reviews with # 
ship-its < 2, no open issues, not yours)')

        return super(MyDashboardDataGrid, self).load_extra_state(profile)



I assume this is all I need to do, but I keep getting this error when I click 
on the 'Needs More Reviews' link.

Page not found (404)
Request Method: GET
Request URL: http://0.0.0.0:8080/dashboard/?view=outstanding

This 404 is being raised by DashboardDataGrid.load_extra_state().

It seems as if DataGridSidebarItemsHook isn't using MyDashboardDataGrid but 
instead using DashboardDataGrid.

Is there anything I am missing?

Thanks for your help.

Marc
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBC

Re: Stuck writing an extension

[Marc Bryan]

Oops sorry forgot to delete the thread text.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Stuck writing an extension

[Marc Bryan]

Thanks Christian. Makes sense to post to reviewboard-dev. :)

Are there any plans to add another extension point / change the way this 
works in the future? If I get a chance I can look into making a patch, but 
time is always the problem :D

Marc

On Monday, June 16, 2014 10:35:46 PM UTC-6, Christian Hammond wrote:
>
> Hi Marc,
>
> The reviewboard-dev list is a better place for these questions, since 
> there’s less traffic there and more people interested in RB-related 
> development.
>
> That said, the problem is that you cannot replace the dashboard. The 
> parameter for the datagrid in DataGridSidebarItemsHook is the class that 
> the sidebar should apply to, but it must be an existing, established 
> datagrid. What you’d have to do there is provide your own URL and view for 
> your this datagrid, render that there, and then link to that URL. That also 
> means you’ll need these hooks in two places, which is going to be a bit 
> annoying.
>
> It’s not ideal, but that’s how it works currently.
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
> On June 16, 2014 at 11:24:54 AM, Marc Bryan (marc...@gmail.com 
> ) wrote:
>
> Hi guys, 
>
> I'm having trouble writing a dashboard sidebar extension that adds custom 
> filters to the datagrid.
>
> ie. I would like to make a few different links, but an example of one 
> would be 'Needs More Reviews', which would filter the reviews by:
>  
>- less than 2 Ship-its (2 is our internal rule)
>- has no open reviews
>- not yours 
>
>  
> Here is what I have currently:
>
> *extension.py:*
>
>  class MySidebarSection(BaseSidebarSection):
> label = 'My Dashboard'
>
> def get_items(self):
> yield SidebarNavItem(self, 'My Requests to Push', view_id='push')
> yield SidebarNavItem(self, 'My Requests to Fix', view_id='fix')
> yield SidebarNavItem(self, 'Involved Reviews', view_id='involved')
> yield SidebarNavItem(self, 'Needs More Reviews', 
> view_id='outstanding')
> yield SidebarNavItem(self, 'All Requests to Push', 
> view_id='approved')
>  
>  class MyDashboard(Extension):
> metadata = {
> 'Name': 'My Dashboard',
> 'Summary': 'Summary here',
> }
> is_configurable = True
>
> def initialize(self):
> # Your extension initialization is done here.
> DataGridSidebarItemsHook(self, MyDashboardDataGrid, 
> [MySidebarSection])
>  
>
> *datagrids.py*
>
>  class MyDashboardDataGrid(DashboardDataGrid):
> def load_extra_state(self, profile):
> # pass custom queryset and change title
> user = self.request.user
> fullPath = self.request.get_full_path()
> view = self.request.GET.get('view', self.default_view)
>
> q = Q(repository__name='MyRepo', target_groups__name='internal', 
> status='P')
>
>  if view == 'outstanding':
> q = q & Q(shipit_count__lt=2, issue_open_count=0)  # TODO: 
> make sure the review isn't yours
> self.queryset = ReviewRequest.objects.filter(q)
> self.title = _('Requests That Need Reviews (Reviews with # 
> ship-its < 2, no open issues, not yours)')
>
> return super(MyDashboardDataGrid, self).load_extra_state(profile)
>  
>
>
> I assume this is all I need to do, but I keep getting this error when I 
> click on the 'Needs More Reviews' link.
>
>  Page not found (404)
> Request Method: GET
> Request URL: http://0.0.0.0:8080/dashboard/?view=outstanding
>  
> This 404 is being raised by DashboardDataGrid.load_extra_state().
>
> It seems as if DataGridSidebarItemsHook isn't using MyDashboardDataGrid 
> but instead using DashboardDataGrid.
>
> Is there anything I am missing?
>
> Thanks for your help.
>
> Marc
>  --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard...@googlegroups.com .
> For more options, visit https://groups.google.com/d/optout.
>
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Requested revision does not exist, using Bazaar

[Christian Hammond]

Hi Brian,

So, I guess Bazaar requires a local timestamp when doing a 'date:’ query. 
Review Board attempts to convert the date in the diff to a local date that 
would match it. It sounds like something’s going terribly wrong there. I toyed 
with it briefly, but couldn’t reproduce the problem you’re hitting.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 17, 2014 at 12:07:13 PM, Brian (phxgat...@gmail.com) wrote:

Hi Christian,

So far I haven't found a pattern in the timestamps that are causing issues. I 
have upgraded one of our servers to use RB 2.0.2 and I also recreated the 
Bazaar repository that we were using. There are only two of us working on this 
project and very little history, so we didn't really lose anything. I'm hoping 
that our problem either goes away, or I will be able to find something when I 
check a diff after each commit we do.

I'll keep you up to date on what I can find out.

Thanks for looking into this!
Brian

On Tuesday, June 17, 2014 3:40:28 AM UTC-7, Christian Hammond wrote:
Hi Brian,

Spent a little bit of time this evening trying to debug this, but no real luck.

Can you see if there’s anything in common with the timestamps where things 
fail? Do they wrap around to a new day, new month, anything?

Christian

-- 
Christian Hammond - chri...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 12, 2014 at 3:44:13 PM, Brian (phxg...@gmail.com) wrote:

I can tell you what we know so far. When we have this issue, I trace the "bad 
revision" back to what I can find in the Bazaar log for the file. We are UTC-7, 
and the timestamp is usually 7 hours off from a match. This may be the case for 
all files/revisions, I'm not sure yet. Most (if not all) of our development 
machines are set to UTC, but maybe there is one somewhere that is not and is 
affecting this. Typically we can edit the diff to match the time in the bzr log 
and Review Board handles the diff with no problem.

In the last week, we have see an instance or two where this workaround has not 
been successful.

Separate, but maybe related, we have also had a couple of instances where 1 of 
24, or 2 of 6, or 4 of 4 diffs in a file did not apply cleanly. We're not sure 
what happened with that exactly, but the timestamps in the diff and log were 
off by 7 hours in those files too.

I'm actually waiting for my IT person to make a copy of our server template 
right now so I can debug this. I'm planning on getting things set up to 
(hopefully) recreate the issue, then will try new versions of Review Board to 
see if that helps any. If not, I'll look into creating a clean Bazaar 
repository to see if that helps any.

I'm also open to any other ideas you may have!

Thanks,
Brian

On Thursday, June 12, 2014 3:26:31 PM UTC-7, Christian Hammond wrote:
Hi Brian,

Can you go into more details on how the timestamps affect things? I’d love to 
find a way to fix/workaround this in RBTools and/or Review Board.

Christian

-- 
Christian Hammond - chri...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 12, 2014 at 3:23:28 PM, Brian (phxg...@gmail.com) wrote:

Hi Rahul,

The way we have worked around it so far is to manually edit the diff. We find 
the timestamp in the bzr log that it "should" be (UTC in our case), then edit 
the diff to match. This had been ok for a while but it is not working more and 
more often now. I'm actually about to start debugging it a little more, I'm not 
entirely convince it's a Bazaar issue.

I'll post more if I can figure out what is going on.

Brian

On Thursday, June 12, 2014 4:47:01 AM UTC-7, Rahul Sisondia wrote:
Hi Brian, 

I am also facing same issue. So what is the solution or workaround for this 
problem ? 

Thanks 
Rahul 

On Thursday, April 17, 2014 2:28:29 AM UTC+5:30, Brian wrote:
Following up on this... we found that the developer creating the diff had a 
different time zone on his machine than the server. So it was actually a Bazaar 
issue, not being able to match the times in the checkouts.

On Friday, February 28, 2014 12:46:16 PM UTC-7, Brian wrote:
Hello,

We are using RB 1.7.12 and twice in the last two days we have gotten errors 
when uploading a diff of a Bazaar branch saying the requested revision does not 
exist:

Requested revision: 'date:2014-02-11 22:54:13' does not exist in branch: 
<>
Requested revision: 'date:2014-02-11 23:00:10' does not exist in branch: 
<>

Removing the diff section that this part of the diff refers to allows the diff 
to be uploaded, but this is obviously a non-optimal solution.

We have been using RB for a couple of years and have never seen this until the 
last couple of days.

Any idea what might be happening?

Thanks,
Brian
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at

Re: Requested revision does not exist, using Bazaar

[Brian]

Hi Christian,

So far I haven't found a pattern in the timestamps that are causing issues. 
I have upgraded one of our servers to use RB 2.0.2 and I also recreated the 
Bazaar repository that we were using. There are only two of us working on 
this project and very little history, so we didn't really lose anything. 
I'm hoping that our problem either goes away, or I will be able to find 
something when I check a diff after each commit we do.

I'll keep you up to date on what I can find out.

Thanks for looking into this!
Brian

On Tuesday, June 17, 2014 3:40:28 AM UTC-7, Christian Hammond wrote:
>
> Hi Brian,
>
> Spent a little bit of time this evening trying to debug this, but no real 
> luck.
>
> Can you see if there’s anything in common with the timestamps where things 
> fail? Do they wrap around to a new day, new month, anything?
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
> On June 12, 2014 at 3:44:13 PM, Brian (phxg...@gmail.com ) 
> wrote:
>
> I can tell you what we know so far. When we have this issue, I trace the 
> "bad revision" back to what I can find in the Bazaar log for the file. We 
> are UTC-7, and the timestamp is usually 7 hours off from a match. This may 
> be the case for all files/revisions, I'm not sure yet. Most (if not all) of 
> our development machines are set to UTC, but maybe there is one somewhere 
> that is not and is affecting this. Typically we can edit the diff to match 
> the time in the bzr log and Review Board handles the diff with no problem.
>
> In the last week, we have see an instance or two where this workaround has 
> not been successful.
>
> Separate, but maybe related, we have also had a couple of instances where 
> 1 of 24, or 2 of 6, or 4 of 4 diffs in a file did not apply cleanly. We're 
> not sure what happened with that exactly, but the timestamps in the diff 
> and log were off by 7 hours in those files too.
>
> I'm actually waiting for my IT person to make a copy of our server 
> template right now so I can debug this. I'm planning on getting things set 
> up to (hopefully) recreate the issue, then will try new versions of Review 
> Board to see if that helps any. If not, I'll look into creating a clean 
> Bazaar repository to see if that helps any.
>
> I'm also open to any other ideas you may have!
>
> Thanks,
> Brian
>
> On Thursday, June 12, 2014 3:26:31 PM UTC-7, Christian Hammond wrote: 
>>
>>  Hi Brian,
>>  
>>  Can you go into more details on how the timestamps affect things? I’d 
>> love to find a way to fix/workaround this in RBTools and/or Review Board.
>>  
>>  Christian
>>  
>>   -- 
>>  Christian Hammond - chri...@beanbaginc.com
>>  Review Board - http://www.reviewboard.org 
>> Beanbag, Inc. - http://www.beanbaginc.com
>>  
>> On June 12, 2014 at 3:23:28 PM, Brian (phxg...@gmail.com) wrote:
>>
>>  Hi Rahul,
>>
>> The way we have worked around it so far is to manually edit the diff. We 
>> find the timestamp in the bzr log that it "should" be (UTC in our case), 
>> then edit the diff to match. This had been ok for a while but it is not 
>> working more and more often now. I'm actually about to start debugging it a 
>> little more, I'm not entirely convince it's a Bazaar issue.
>>
>> I'll post more if I can figure out what is going on.
>>
>> Brian
>>
>> On Thursday, June 12, 2014 4:47:01 AM UTC-7, Rahul Sisondia wrote: 
>>>
>>> Hi Brian,  
>>>
>>> I am also facing same issue. So what is the solution or workaround for 
>>> this problem ? 
>>>
>>> Thanks 
>>> Rahul 
>>>
>>> On Thursday, April 17, 2014 2:28:29 AM UTC+5:30, Brian wrote: 

 Following up on this... we found that the developer creating the diff 
 had a different time zone on his machine than the server. So it was 
 actually a Bazaar issue, not being able to match the times in the 
 checkouts.

 On Friday, February 28, 2014 12:46:16 PM UTC-7, Brian wrote: 
>
> Hello,
>
> We are using RB 1.7.12 and twice in the last two days we have gotten 
> errors when uploading a diff of a Bazaar branch saying the requested 
> revision does not exist:
>
> Requested revision: 'date:2014-02-11 22:54:13' does not exist in 
> branch: <>
> Requested revision: 'date:2014-02-11 23:00:10' does not exist in 
> branch: <>
>
> Removing the diff section that this part of the diff refers to allows 
> the diff to be uploaded, but this is obviously a non-optimal solution.
>
> We have been using RB for a couple of years and have never seen this 
> until the last couple of days.
>
> Any idea what might be happening?
>
> Thanks,
> Brian
>
--
>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>> ---
>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>> ---
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> ---
>> You r

Re: rbt post using Mercurial

[Ali Ghorashi]

I get a "repo is not local error". It looks like the code is trying to get
the file contents as of a specific changeset from a remote server via ssh.
I'm not sure if there is a way to do that without cloning the repo. If
there repo is available via a webbrowser, then the file can be retrieved
via the /raw interface. That's because the server will ask the repo located
on the same server for the file.

To me, it looks like what it's trying to do cannot be don via ssh.

-Ali


On Mon, Jun 16, 2014 at 10:47 PM, Christian Hammond <
christ...@beanbaginc.com> wrote:

> What happens if you remove the —cwd line?
>
> We probably want to conditionalize setting that.
>
> Christian
>
> --
> Christian Hammond - christ...@beanbaginc.com
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
> On June 16, 2014 at 9:39:08 AM, Ali Ghorashi (agho...@gmail.com) wrote:
>
> I'm still getting the file not found error when I do a rbt post -u -d.
> Here is the error (I'm trying a different file than before.)
>
> >>> Error data: {u'stat': u'fail', u'file': u'src/SIPSA.cpp', u'err':
> {u'msg': u'The file was not found in the repository.', u'code': 207},
> u'revision': u'79c09fdfad23'}
>
> I've been tracing through the code to see where the problem is. I added
> the following debug message to the popen method of SCMTool:
>
>  logging.debug('SCMTool.popen command = %s',command)
>
> And this is what I'm getting:
>  SCMTool.popen command = [u'hg', u'--noninteractive', u'--repository',
> u'ssh://source.cei.com//home/hg/projects/sipsa/core/', u'--cwd', u'ssh://
> source.cei.com//home/hg/projects/sipsa/core/', u'--config',
> u'ui.ssh=rbssh', u'cat', u'--rev', u'79c09fdfad23', u'src/SIPSA.cpp']
>
> If I read this right, it looks like the current working directory is being
> set to "ssh://". Is that correct? I'm not sure Mercurial can use a
> remote ssh path as the current directory. When I paste the command into a
> shell, Mercurial (version 2.8.2) says:
>
>   abort: No such file or directory: 'ssh://
> source.cei.com//home/hg/projects/sipsa/core'
>
> Thanks
> -Ali
>
> On Thursday, June 12, 2014 1:51:14 PM UTC-6, Ali Ghorashi wrote:
>>
>> Changeset  79c09fdfad23 did not include src/Message.h. The last time
>> src/Message.h was in the changeset was on rev 68:2ed54119d47d (33 commits
>> ago). With that said, I verified that the latest version of src/Message.h
>> (prior to this last change) is in the repo.
>>
>>
>> On Thu, Jun 12, 2014 at 1:42 PM, Christian Hammond <
>> christ...@beanbaginc.com> wrote:
>>
>>>  The thing I’d want to check first is that src/Message.h, revision
>>> 79c09fdfad23 is actually in the repository that Review Board is pointed to.
>>> Can you verify that? If that’s not the case, then either that repository
>>> doesn’t have the latest-and-greatest (which is important), or there’s some
>>> issue with the range being posted from your local copy.
>>>
>>>  Christian
>>>
>>>   --
>>>  Christian Hammond - christ...@beanbaginc.com
>>>
>>>  Review Board - http://www.reviewboard.org
>>> Beanbag, Inc. - http://www.beanbaginc.com
>>>
>>> On June 12, 2014 at 12:36:45 PM, Ali Ghorashi (agho...@gmail.com) wrote:
>>>
>>>   Thanks for clearing that up.
>>> Is there any file/function I can put some debug statements in to see
>>> what the problem is? I have't had time to start tracing though the code yet.
>>>
>>> On Thursday, June 12, 2014 1:32:36 PM UTC-6, Christian Hammond wrote:

  The ‘hg svn’ errors are normal in debug output, if the appropriate
 extension is not installed or it’s not a hg svn repository.

  Review Board fetches the full contents of the files referenced in the
 diffs in order to generate a side-by-side diff viewer that can be analyzed
 and expanded. Because of this, we need some repository to talk to that has
 the most up-to-date commits.

  Christian

   --
  Christian Hammond - chri...@beanbaginc.com
  Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On June 12, 2014 at 8:17:49 AM, Ali Ghorashi (agh...@gmail.com) wrote:

  Are the "hg svn" errors normal?
 I'm also confused about another thing: Why does the reviewboard server
 needs to know where the main Mercurial repo is? What if one does not exist?
 In a distributed source control system, all the data is available to the
 "rbt" tool. It should be able to post a complete diff without the server
 having to know any specifics about the repo.

 Any help would be appreciated.

 Thanks
 -Ali

 On Wednesday, June 11, 2014 9:43:45 AM UTC-6, Ali Ghorashi wrote:
>
> Thanks Christian,
> See the attached file for the debug output. There is nothing special
> about the repo setup: I don't have any branches. Everything up to 
> changeset
> 100:79c09fdfad23 is pushed into the main repo. I changed a file with
> changeset: 101:1170d2410ead and then did a "r

Re: Review Board 2.x and "hg postreview"

[Jeremie Jost]

Hi,

We're using the postreview extension and have been hitting that issue 
pretty regularly. It's particularly annoying because I think that 
reviewboard caches the diff so if you messed up, even if you push 
afterwards and run hg postreview again it will still fail. I've finally 
stumbled on the -o option which seems to solve the issue, so that's pretty 
awesome. But that left me wondering, is there any reason why this isn't the 
default behaviour? From what I understand, it looks like rbt now does this 
by default. 

Or otherwise, at least have postreview abort if it cannot find the parent 
in the remote repository rather than create a corrupted review request?

(Sure, I could use defaults, but the Mercurial guys told me defaults are 
bad and I should feel bad even thinking about it 
.)

Cheers
Jeremie

On Thursday, 5 June 2014 02:14:06 UTC+1, ccaughie wrote:
>
>  Ah - yes, you have to use the -o option to tell ReviewBoard to figure 
> out the parent diff base by doing the equivalent of "hg outgoing". For this 
> to work you need to make sure that your default push repository is the same 
> as the one that ReviewBoard sees; if it isn't you can use -O instead. ("hg 
> help postreview" has all of this information.)
>
> --master also works but means you have to figure it out yourself.
>
> Apologies for not thinking of that earlier. I have it configured in my 
> default args for the postreview command so I never actually have to type it.
>
> Colin
>
> On 06/04/2014 4:36 PM, Bruce Cran wrote:
>  
>  I'm using Mercurial 3.0, ReviewBoard 2.0.1 and as of today, the latest 
> code from https://bitbucket.org/ccaughie/hgreviewboard . I did forget to 
> add "hg add file2.txt" to the list of steps, but I ran it during testing.   
> Should the code figure out which revision to use for the parent diff base? 
> It works if I specify "--master qparent".
>
> -- 
>  Bruce
>
>
> On Wed, Jun 4, 2014 at 4:36 PM, Colin Caughie  > wrote:
>
>>  Following those instructions exactly I get an error message of "The 
>> specified diff file is empty", which is not surprising since file2.txt was 
>> never added to the repository.
>>
>> If I do "hg add file2.txt" before the first qnew on the other hand, "hg 
>> postreview" works fine and correctly shows Line2 being added to file2.txt.
>>
>> If it is still breaking for you even with the hg add, can you let me know 
>> what versions of mercurial, ReviewBoard and the reviewboard extension 
>> you're using?
>>
>> If you're using the latest versions and it still doesn't work, please 
>> send me the output of
>>
>> hg postreview --debug --apitrace
>>  
>   -- 
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard...@googlegroups.com .
> For more options, visit https://groups.google.com/d/optout.
>
>
>  

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Unable to use "New Review Request" to create requests with parent diffs

[Bruce Cran]

Yeah, I've found that setup-repo doesn't work for us either. For now I
always use both --server and --repository, though I should just do the
setup manually.
With RBTools 0.6.1,  setup-repo asks about 3 repos (whether they're the one
I want to use) but they're all wrong.

-- 
Bruce


On Tue, Jun 17, 2014 at 9:36 AM, Sara Rayburn  wrote:

> Well, we were able to get things working with RB Tools after a fashion.
> The rbt setup-repo command always failed to find the repository, returning
> an error 500. If we run rbt post --repository="foo", however, everything
> works fine. I think the setup-repo command either fails because we do not
> have the hg svn extension installed or because the default path for our
> repo (ssh://) does not match the path we use for reviewboard (we keep a
> local clone /data_local/hg-repo/foo). If you are interested in further
> details, I can post debug output.
>
> Sara
>
>
> On Mon, Jun 16, 2014 at 11:32 PM, Christian Hammond <
> christ...@beanbaginc.com> wrote:
>
>> What’s going wrong with the configuration?
>>
>> Christian
>>
>> --
>> Christian Hammond - christ...@beanbaginc.com
>> Review Board - http://www.reviewboard.org
>> Beanbag, Inc. - http://www.beanbaginc.com
>>
>> On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com)
>> wrote:
>>
>>  Hi,
>>
>> Bruce, the installer works for our Windows guys just fine. Thanks for
>> putting that together!
>>
>> Unfortunately, we can't seem to get RB Tools configured properly for
>> anyone, but that's a question for another day.
>>
>> Sara
>>
>>
>> On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond <
>> christ...@beanbaginc.com> wrote:
>>
>>>  Awesome :)
>>>
>>>  Under rbtools/contrib/installer/ would probably be best. We may end up
>>> moving it, but that’s ag ood starting point.
>>>
>>>  rb-win32-installer is an old repository that can be pretty much ignored
>>> at this point.
>>>
>>>  Christian
>>>
>>>   --
>>>  Christian Hammond - christ...@beanbaginc.com
>>>  Review Board - http://www.reviewboard.org
>>> Beanbag, Inc. - http://www.beanbaginc.com
>>>
>>>  On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com)
>>> wrote:
>>>
>>>   Christian,
>>>
>>> Yes, I was hoping I'd be able to contribute the code to make future
>>> maintenance simpler.
>>>
>>> Which repo and in which directory would it be added? I see there's a old
>>> rb-win32-installer repository on github for Review Board - would it be
>>> there, or under contrib/ in the rbtools repo etc.?
>>>
>>> --
>>> Bruce
>>>
>>>
>>> On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond <
>>> christ...@beanbaginc.com> wrote:
>>>
  Hi Bruce,

  That’s fantastic. I just installed in a fresh VM, and had RBTools
 up-and-running in just a couple minutes.

  Would you be willing to contribute the source to the installer? I’d
 like to ship an official installer with our future releases.

>>>   --
>>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>>> ---
>>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>>> ---
>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>>   --
>>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>>> ---
>>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>>> ---
>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>
>>
>> --
>>  Sara Rayburn
>> (337) 322-5573
>> sararayb...@gmail.com
>>  --
>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>> ---
>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>> ---
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>>  --
>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>> ---
>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>> ---
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this 

Re: Unable to use "New Review Request" to create requests with parent diffs

[Sara Rayburn]

Well, we were able to get things working with RB Tools after a fashion. The
rbt setup-repo command always failed to find the repository, returning an
error 500. If we run rbt post --repository="foo", however, everything works
fine. I think the setup-repo command either fails because we do not have
the hg svn extension installed or because the default path for our repo
(ssh://) does not match the path we use for reviewboard (we keep a
local clone /data_local/hg-repo/foo). If you are interested in further
details, I can post debug output.

Sara


On Mon, Jun 16, 2014 at 11:32 PM, Christian Hammond <
christ...@beanbaginc.com> wrote:

> What’s going wrong with the configuration?
>
> Christian
>
> --
> Christian Hammond - christ...@beanbaginc.com
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
> On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com)
> wrote:
>
>  Hi,
>
> Bruce, the installer works for our Windows guys just fine. Thanks for
> putting that together!
>
> Unfortunately, we can't seem to get RB Tools configured properly for
> anyone, but that's a question for another day.
>
> Sara
>
>
> On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond <
> christ...@beanbaginc.com> wrote:
>
>>  Awesome :)
>>
>>  Under rbtools/contrib/installer/ would probably be best. We may end up
>> moving it, but that’s ag ood starting point.
>>
>>  rb-win32-installer is an old repository that can be pretty much ignored
>> at this point.
>>
>>  Christian
>>
>>   --
>>  Christian Hammond - christ...@beanbaginc.com
>>  Review Board - http://www.reviewboard.org
>> Beanbag, Inc. - http://www.beanbaginc.com
>>
>>  On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com) wrote:
>>
>>   Christian,
>>
>> Yes, I was hoping I'd be able to contribute the code to make future
>> maintenance simpler.
>>
>> Which repo and in which directory would it be added? I see there's a old
>> rb-win32-installer repository on github for Review Board - would it be
>> there, or under contrib/ in the rbtools repo etc.?
>>
>> --
>> Bruce
>>
>>
>> On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond <
>> christ...@beanbaginc.com> wrote:
>>
>>>  Hi Bruce,
>>>
>>>  That’s fantastic. I just installed in a fresh VM, and had RBTools
>>> up-and-running in just a couple minutes.
>>>
>>>  Would you be willing to contribute the source to the installer? I’d
>>> like to ship an official installer with our future releases.
>>>
>>   --
>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>> ---
>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>> ---
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>>   --
>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>> ---
>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>> ---
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> --
>  Sara Rayburn
> (337) 322-5573
> sararayb...@gmail.com
>  --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>  --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Sara Rayburn
(337) 322-5573
sararayb...@gmail.com

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscr

Re: Requested revision does not exist, using Bazaar

[Christian Hammond]

Hi Brian,

Spent a little bit of time this evening trying to debug this, but no real luck.

Can you see if there’s anything in common with the timestamps where things 
fail? Do they wrap around to a new day, new month, anything?

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 12, 2014 at 3:44:13 PM, Brian (phxgat...@gmail.com) wrote:

I can tell you what we know so far. When we have this issue, I trace the "bad 
revision" back to what I can find in the Bazaar log for the file. We are UTC-7, 
and the timestamp is usually 7 hours off from a match. This may be the case for 
all files/revisions, I'm not sure yet. Most (if not all) of our development 
machines are set to UTC, but maybe there is one somewhere that is not and is 
affecting this. Typically we can edit the diff to match the time in the bzr log 
and Review Board handles the diff with no problem.

In the last week, we have see an instance or two where this workaround has not 
been successful.

Separate, but maybe related, we have also had a couple of instances where 1 of 
24, or 2 of 6, or 4 of 4 diffs in a file did not apply cleanly. We're not sure 
what happened with that exactly, but the timestamps in the diff and log were 
off by 7 hours in those files too.

I'm actually waiting for my IT person to make a copy of our server template 
right now so I can debug this. I'm planning on getting things set up to 
(hopefully) recreate the issue, then will try new versions of Review Board to 
see if that helps any. If not, I'll look into creating a clean Bazaar 
repository to see if that helps any.

I'm also open to any other ideas you may have!

Thanks,
Brian

On Thursday, June 12, 2014 3:26:31 PM UTC-7, Christian Hammond wrote:
Hi Brian,

Can you go into more details on how the timestamps affect things? I’d love to 
find a way to fix/workaround this in RBTools and/or Review Board.

Christian

-- 
Christian Hammond - chri...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 12, 2014 at 3:23:28 PM, Brian (phxg...@gmail.com) wrote:

Hi Rahul,

The way we have worked around it so far is to manually edit the diff. We find 
the timestamp in the bzr log that it "should" be (UTC in our case), then edit 
the diff to match. This had been ok for a while but it is not working more and 
more often now. I'm actually about to start debugging it a little more, I'm not 
entirely convince it's a Bazaar issue.

I'll post more if I can figure out what is going on.

Brian

On Thursday, June 12, 2014 4:47:01 AM UTC-7, Rahul Sisondia wrote:
Hi Brian, 

I am also facing same issue. So what is the solution or workaround for this 
problem ? 

Thanks 
Rahul 

On Thursday, April 17, 2014 2:28:29 AM UTC+5:30, Brian wrote:
Following up on this... we found that the developer creating the diff had a 
different time zone on his machine than the server. So it was actually a Bazaar 
issue, not being able to match the times in the checkouts.

On Friday, February 28, 2014 12:46:16 PM UTC-7, Brian wrote:
Hello,

We are using RB 1.7.12 and twice in the last two days we have gotten errors 
when uploading a diff of a Bazaar branch saying the requested revision does not 
exist:

Requested revision: 'date:2014-02-11 22:54:13' does not exist in branch: 
<>
Requested revision: 'date:2014-02-11 23:00:10' does not exist in branch: 
<>

Removing the diff section that this part of the diff refers to allows the diff 
to be uploaded, but this is obviously a non-optimal solution.

We have been using RB for a couple of years and have never seen this until the 
last couple of days.

Any idea what might be happening?

Thanks,
Brian
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this messag