Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
Hi David,
Oddly enough, there is nothing at all in the logs when I try to create the
failed new review request. When I do the same operations in Chrome (where
the diff works just fine), I see
2014-09-11 12:57:32,499 - DEBUG - - DiffParser.parse: Beginning parse of
diff, size = 5408
2014-09-11 12:57:32,503 - DEBUG - - DiffParser.parse: Finished parsing
diff.
2014-09-11 12:57:32,653 - DEBUG - - DiffParser.parse: Beginning parse of
diff, size = 5408
2014-09-11 12:57:32,656 - DEBUG - - DiffParser.parse: Finished parsing
diff.
in the logs. Nothing at all hits the logs using firefox. There are no
errors in the apache logs either.
Sara
On Wednesday, September 10, 2014 4:03:39 PM UTC-5, David Trowbridge wrote:
Sara,
Can you look in the server log and see if there are any tracebacks in
there?
-David
On Wed, Sep 10, 2014 at 5:50 AM, Sara Rayburn sarar...@gmail.com
javascript: wrote:
Christian,
Yes, that was the output from the network tab for the failing new review
request, and the tab was open the whole time. When I create new review
request for that repository with one of the diffs that works, I get these
requests (I may not have caught them all... not familiar with web
debugging):
GET http://reviewboard.cctechnol.com/r/4078/ [HTTP/1.1 200 OK 197ms]
GET http://reviewboard.cctechnol.com/jsi18n/ [HTTP/1.1 200 OK 68ms]
GET http://reviewboard.cctechnol.com/api/review-requests/4078/ [HTTP/1.1
200 OK 109ms]
GET
http://reviewboard.cctechnol.com/static/rb/css/common.min.e6e71be831db.css
[HTTP/1.1 200 OK 12ms]
GET
http://reviewboard.cctechnol.com/static/rb/css/reviews.min.f35ccb97b383.css
We were finally able to narrow down which were the offending characters.
The developer had copied some documentation from a pdf document, and it had
some non-ascii quote marks in it. He corrected the files with the following
perl:
perl -pi -e 's/[[:^ascii:]]//g' filename
Hope that helps.
Sara
On Tuesday, September 9, 2014 4:33:06 PM UTC-5, Christian Hammond wrote:
Hi Sara,
Strange.. Is that output from the Network tab? Was that tab open when
initially making the request?
Christian
--
Christian Hammond - chri...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
On September 9, 2014 at 2:30:26 PM, Sara Rayburn (sarar...@gmail.com)
wrote:
Hi Christian,
Well, as it happens, the error only occurs while using Firefox (v.
30). The
user having troubles was relieved to find Chrome as a temporary
workaround.
I was able to unminify the code, but it didn't point me to a specific
line.
Maybe a firefox thing? I looked for a 500 error, but I don't really
even
see a relevant looking request. Here is the log in question, but
there's
not much to it. Clicking on the type error gets the big nasty block
from
before.
GET http://www.gravatar.com/avatar/e3a6e9470514467a04cbc94da028458e
[HTTP/1.1 304 Not Modified 796ms]
GET
http://reviewboard.cctechnol.com/static/rb/images/icons.
2eed2f830119.png
[HTTP/1.1 304 Not Modified 6ms]
GET
http://reviewboard.cctechnol.com/static/rb/images/logo@2x.
4e25cc3cacef.png
[HTTP/1.1 304 Not Modified 6ms]
Use of getPreventDefault() is deprecated. Use defaultPrevented
instead.
jquery-1.8.2.min.cfa9051cc0b0.js:2
GET
http://reviewboard.cctechnol.com/static/rb/images/spinner.
73e57937304d.gif
[HTTP/1.1 304 Not Modified 5ms]
The non-standard sendAsBinary method is deprecated and will soon be
removed. Use the standard send(Blob data) method instead.
jquery-1.8.2.min.cfa9051cc0b0.js:2
TypeError: rsp is null
On Tuesday, September 9, 2014 4:09:29 PM UTC-5, Christian Hammond
wrote:
Hi Sara,
We minify our files by default, making the context less than useful.
If
you’re using Chrome, you should be able to click the error, see that
big
minified file, and then click the little “{}” at the bottom of the
window.
That will un-minify it, updating the error in the console to point
to the
actual line where things failed. If you could then paste that line
(and the
lines surrounding it), that will help narrow things down.
We are getting ready for Review Board 2.0.7, which will display more
useful errors in the New Review Request page when things go wrong.
Hopefully it will help with this case as well.
It would also be helpful to see the request/response payloads
invoked by
that page, in order to see where things went wrong. I’d expect one
of the
responses will be a HTTP 500.
Christian
--
Christian Hammond - chri...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
--
Get the Review Board Power Pack at http://www.reviewboard.org/
powerpack/
---
Sign up for Review Board hosting at RBCommons:
Re: Issues publishing review with ReviewBoard
I also am having this problem.
ReviewBoard 2.0.6
I've made all the modifications suggested in this thread.
Apache acting as proxy terminating in ssl. I did some further digging and
see something strange:
The rbt debug output:
Using candidate path 'default':
'https://code.corp.vaeit.com/repos/vae.itpie'
repository info: Path: https://code.corp.vaeit.com/repos/vae.itpie,
Base path: , Supports changesets: False
Making HTTP GET request to https://code.corp.vaeit.com/reviews/api/
Running: hg parents --hidden -r 0
Running: hg identify -i --hidden -r 5481 --config
extensions.rbtoolsnormalize=/Library/Python/2.7/site-packages/RBTools-0.6.2-py2.7.egg/rbtools/helpers/hgext.py
Running: hg parents --hidden -r 56a82eed0038 --template {node|short}
--config
extensions.rbtoolsnormalize=/Library/Python/2.7/site-packages/RBTools-0.6.2-py2.7.egg/rbtools/helpers/hgext.py
Running: hg -q outgoing --template {rev}\t{node|short}\t{branch}\n
default -r cb8e1227ee09
Command exited with rc 1: ['hg', '-q', 'outgoing', '--template',
'{rev}\\t{node|short}\\t{branch}\\n', 'default', '-r', 'cb8e1227ee09']
---
0 outgoing changesets between remote and base.
Running: hg diff --hidden -r cb8e1227ee09 -r 56a82eed0038 --config
extensions.rbtoolsnormalize=/Library/Python/2.7/site-packages/RBTools-0.6.2-py2.7.egg/rbtools/helpers/hgext.py
Running: hg locate -r cb8e1227ee09
Running: hg locate -r 56a82eed0038
Running: hg log --hidden -r cb8e1227ee09::56a82eed0038 --template
{desc}ddb6b197-39e5-11e4-b993-3c15c2cf747a --config
extensions.rbtoolsnormalize=/Library/Python/2.7/site-packages/RBTools-0.6.2-py2.7.egg/rbtools/helpers/hgext.py
Making HTTP GET request to
https://code.corp.vaeit.com/reviews/api/review-requests/
Making HTTP POST request to
http://code.corp.vaeit.com/reviews/api/review-requests/
Traceback (most recent call last):
File /usr/local/bin/rbt, line 8, in module
load_entry_point('RBTools==0.6.2', 'console_scripts', 'rbt')()
File
/Library/Python/2.7/site-packages/RBTools-0.6.2-py2.7.egg/rbtools/commands/main.py,
line 134, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File
/Library/Python/2.7/site-packages/RBTools-0.6.2-py2.7.egg/rbtools/commands/__init__.py,
line 416, in run_from_argv
exit_code = self.main(*args) or 0
File
/Library/Python/2.7/site-packages/RBTools-0.6.2-py2.7.egg/rbtools/commands/post.py,
line 784, in main
submit_as=self.options.submit_as)
File
/Library/Python/2.7/site-packages/RBTools-0.6.2-py2.7.egg/rbtools/commands/post.py,
line 526, in post_request
review_request.get_diffs().upload_diff(diff_content,
AttributeError: 'ListResource' object has no attribute 'get_diffs'
Notice it makes the get request to https but the post request to http. I
used curl to get the contents of the get request:
curl https://user:p...@code.corp.vaeit.com/reviews/api/review-requests/
{total_results: 0, stat: ok, review_requests: [], links: {self:
{href: https://code.corp.vaeit.com/reviews/api/review-requests/;,
method: GET}, create: {href:
https://code.corp.vaeit.com/reviews/api/review-requests/;, method:
POST}}}
And all the urls look correct in there. It looks as if rbt is not using the
links disclosed in the api request.
On Thursday, December 6, 2012 3:40:08 AM UTC-6, Christian Hammond wrote:
Hi Brian,
One more thing to sanity check. If you go to your General Settings page,
do you have the server set as http://blah, or https://blah ?
Christian
--
Christian Hammond - chi...@chipx86.com javascript:
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Dec 5, 2012 at 4:59 PM, Brian Lewis *...@brianlewis.us
javascript: wrote:
Hi Christian,
Yes - I just stopped apache and manually restarted it as well just to
make sure. Here's a copy of the reviewboard.wsgi file ::
import os
import sys
os.environ['DJANGO_SETTINGS_MODULE'] = reviewboard.settings
os.environ['PYTHON_EGG_CACHE'] = /var/www/reviewboard/tmp/egg_cache
os.environ['HOME'] = /var/www/reviewboard/data
os.environ['HTTPS'] = 'on'
sys.path = ['/var/www/reviewboard/conf'] + sys.path
import django.core.handlers.wsgi
application = django.core.handlers.wsgi.WSGIHandler()
On Wednesday, December 5, 2012 4:52:12 PM UTC-8, Christian Hammond wrote:
Just to sanity check, did you reload Apache?
We put in absolute URLs, and we tell Django to build those for us.
Django will insert https if it sees the HTTPS environment variable set
to on, and http otherwise. Provided the process is ending up with this
environment variable set, and the server is reloaded, it should be working.
Would you mind pasting the reviewboard.wsgi file?
Christian
--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Dec 5, 2012 at 4:46 PM, Brian Lewis *...@brianlewis.us wrote:
Hi Christian,
Just tried that and there's no change. Additionally, I notice the
Re: Issues publishing review with ReviewBoard
Hrr.
And now it seems to have resolved itself. I honestly don't know what fixed
it.
On Wednesday, December 5, 2012 6:31:48 PM UTC-6, Brian Lewis wrote:
Hello All,
I've been racking my brain on this for a couple of days and figured I'd
post here before I refactor my entire setup. Basically what we are doing
is, we have two servers - one is a standard apache web node that acts as a
proxy server and terminates SSL, then we have reviewboard being proxied
behind that.
I've got everything setup and working with the exception of one piece. I
can upload a diff, I can add titles, descriptions, reviewers, etc. Tracing
the requests I can see that https is being returned as the request URL,
HOWEVER, when you go to publish a review, we get a 304 error and the
request URL is a non-https link.
I'm doing the rewriting from the web node directly, with a mod_rewrite
specifically calling out that its proxied (but changing or completely
removing the options doesn't make any difference) For reference, here's the
rewrite ::
RewriteCond %{HTTPS} off
RewriteRule .* https://%{HTTP_HOST}%{REQUEST_URI} [R=301,P,PT,L]
When I click on publish, essentially I see two requests (and nothing at
all in the debug logs, etc) The first ::
Request
URL:*https://reviewboard.boku.com/reviews/api/review-requests/189/?api_format=json
https://reviewboard.boku.com/reviews/api/review-requests/189/?api_format=json*
Request Method:GET
Status Code:304 NOT MODIFIED
Request Headersview source
Accept:application/json, text/javascript, */*
Accept-Charset:ISO-8859-1,utf-8;q=0.7,*;q=0.3
Accept-Encoding:gzip,deflate,sdch
Accept-Language:en-US,en;q=0.8
Cache-Control:max-age=0
Connection:keep-alive
Cookie:rbsessionid=bbf077166394571eaaf514053e6c4691;
__utma=109258518.568604164.1352840613.1352938162.1354736370.4;
__utmc=109258518; __utmz=109258518.1352929269.2.2.utmcsr=google|utmccn=(
organic)|utmcmd=organic|utmctr=(not%20provided); csrftoken=
b6dec71b9219e2090d9d98acf203e1f4
Host:reviewboard.boku.com
If-Modified-Since:Wed, 05 Dec 2012 22:02:11 GMT
Referer:https://reviewboard.boku.com/reviews/r/189/
User-Agent:Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5)
AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.95 Safari/537.11
X-Requested-With:XMLHttpRequest
Query String Parametersview URL encoded
api_format:json
Response Headersview source
Cache-Control:max-age=0
Connection:close
Date:Thu, 06 Dec 2012 00:12:46 GMT
Expires:Thu, 06 Dec 2012 00:12:48 GMT
Server:Apache/2.2.15 (CentOS)
Vary:Accept,Cookie,Accept-Language
The second ::
Request
URL:*http://reviewboard.boku.com/reviews/api/review-requests/189/draft/
http://reviewboard.boku.com/reviews/api/review-requests/189/draft/*
Request Method:OPTIONS
Status Code:200 OK
Request Headersview source
Accept:*/*
Accept-Charset:ISO-8859-1,utf-8;q=0.7,*;q=0.3
Accept-Encoding:gzip,deflate,sdch
Accept-Language:en-US,en;q=0.8
Access-Control-Request-Headers:origin, x-requested-with, content-type,
accept
Access-Control-Request-Method:PUT
Connection:keep-alive
Host:reviewboard.boku.com
Origin:https://reviewboard.boku.com
User-Agent:Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5)
AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.95 Safari/537.11
Response Headersview source
Allow:GET,HEAD,POST,OPTIONS
Connection:close
Content-Length:0
Content-Type:text/plain; charset=UTF-8
Date:Thu, 06 Dec 2012 00:12:48 GMT
Server:Apache
literally every other request comes in via HTTPS, clicking on links,
performing actions, etc. the ONLY thing that fails is publishing. I'm not
sure what to do next at this point so I wanted to see if anyone had ever
run into this. Below I will also paste the apache config for the proxy/ssl
term server and the web head for comparison.
SSL Proxy ::
VirtualHost 192.168.200.124:443
ServerName reviewboard.COMPANYNAME.com
http://reviewboard.companyname.com/
SSLEngine on
SSLProtocol all -SSLv2
SSLCipherSuite ALL:!ADH:!EXPORT:!SSLv2:RC4+RSA:+HIGH:+MEDIUM:+LOW
SSLCertificateFile /etc/pki/entrust-certs/
star.COMPANYNAME.com/star.COMPANYNAME.com.crt
http://star.companyname.com/star.COMPANYNAME.com.crt
SSLCertificateKeyFile /etc/pki/entrust-certs/
star.COMPANYNAME.com/star.COMPANYNAME.com.key
http://star.companyname.com/star.COMPANYNAME.com.key
SSLCACertificateFile /etc/pki/entrust-certs/
star.COMPANYNAME.com/star.COMPANYNAME.com_bundle.crt
http://star.companyname.com/star.COMPANYNAME.com_bundle.crt
# SSLCertificateFile /etc/pki/tls/certs/COMPANYNAME.com.crt
# SSLCertificateKeyFile /etc/pki/tls/certs/COMPANYNAME.com.key
# SSLCACertificateFile /etc/pki/tls/certs/gd_bundle.crt
# Default to not cache anything
ExpiresActive On
ExpiresDefault access plus 0 seconds
# Cache just images
ExpiresByType image/gif access plus 10 minutes
ExpiresByType image/jpg access plus 10 minutes
ExpiresByType image/png
Re: Issues publishing review with ReviewBoard
Hi Jeremy,
Strange.. I don't know what the cause would have been for that. Sounds like it
just wasn't properly loading the resource.
Hopefully that doesn't happen again.
Christian
--
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
On September 11, 2014 at 12:30:10 PM, Jeremy Wall (jeremy.w...@vaeit.com) wrote:
Hrr.
And now it seems to have resolved itself. I honestly don't know what fixed
it.
On Wednesday, December 5, 2012 6:31:48 PM UTC-6, Brian Lewis wrote:
Hello All,
I've been racking my brain on this for a couple of days and figured I'd
post here before I refactor my entire setup. Basically what we are doing
is, we have two servers - one is a standard apache web node that acts as a
proxy server and terminates SSL, then we have reviewboard being proxied
behind that.
I've got everything setup and working with the exception of one piece. I
can upload a diff, I can add titles, descriptions, reviewers, etc. Tracing
the requests I can see that https is being returned as the request URL,
HOWEVER, when you go to publish a review, we get a 304 error and the
request URL is a non-https link.
I'm doing the rewriting from the web node directly, with a mod_rewrite
specifically calling out that its proxied (but changing or completely
removing the options doesn't make any difference) For reference, here's the
rewrite ::
RewriteCond %{HTTPS} off
RewriteRule .* https://%{HTTP_HOST}%{REQUEST_URI} [R=301,P,PT,L]
When I click on publish, essentially I see two requests (and nothing at
all in the debug logs, etc) The first ::
Request
URL:*https://reviewboard.boku.com/reviews/api/review-requests/189/?api_format=json
*
Request Method:GET
Status Code:304 NOT MODIFIED
Request Headersview source
Accept:application/json, text/javascript, */*
Accept-Charset:ISO-8859-1,utf-8;q=0.7,*;q=0.3
Accept-Encoding:gzip,deflate,sdch
Accept-Language:en-US,en;q=0.8
Cache-Control:max-age=0
Connection:keep-alive
Cookie:rbsessionid=bbf077166394571eaaf514053e6c4691;
__utma=109258518.568604164.1352840613.1352938162.1354736370.4;
__utmc=109258518; __utmz=109258518.1352929269.2.2.utmcsr=google|utmccn=(
organic)|utmcmd=organic|utmctr=(not%20provided); csrftoken=
b6dec71b9219e2090d9d98acf203e1f4
Host:reviewboard.boku.com
If-Modified-Since:Wed, 05 Dec 2012 22:02:11 GMT
Referer:https://reviewboard.boku.com/reviews/r/189/
User-Agent:Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5)
AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.95 Safari/537.11
X-Requested-With:XMLHttpRequest
Query String Parametersview URL encoded
api_format:json
Response Headersview source
Cache-Control:max-age=0
Connection:close
Date:Thu, 06 Dec 2012 00:12:46 GMT
Expires:Thu, 06 Dec 2012 00:12:48 GMT
Server:Apache/2.2.15 (CentOS)
Vary:Accept,Cookie,Accept-Language
The second ::
Request
URL:*http://reviewboard.boku.com/reviews/api/review-requests/189/draft/
*
Request Method:OPTIONS
Status Code:200 OK
Request Headersview source
Accept:*/*
Accept-Charset:ISO-8859-1,utf-8;q=0.7,*;q=0.3
Accept-Encoding:gzip,deflate,sdch
Accept-Language:en-US,en;q=0.8
Access-Control-Request-Headers:origin, x-requested-with, content-type,
accept
Access-Control-Request-Method:PUT
Connection:keep-alive
Host:reviewboard.boku.com
Origin:https://reviewboard.boku.com
User-Agent:Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5)
AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.95 Safari/537.11
Response Headersview source
Allow:GET,HEAD,POST,OPTIONS
Connection:close
Content-Length:0
Content-Type:text/plain; charset=UTF-8
Date:Thu, 06 Dec 2012 00:12:48 GMT
Server:Apache
literally every other request comes in via HTTPS, clicking on links,
performing actions, etc. the ONLY thing that fails is publishing. I'm not
sure what to do next at this point so I wanted to see if anyone had ever
run into this. Below I will also paste the apache config for the proxy/ssl
term server and the web head for comparison.
SSL Proxy ::
ServerName reviewboard.COMPANYNAME.com
SSLEngine on
SSLProtocol all -SSLv2
SSLCipherSuite ALL:!ADH:!EXPORT:!SSLv2:RC4+RSA:+HIGH:+MEDIUM:+LOW
SSLCertificateFile /etc/pki/entrust-certs/
star.COMPANYNAME.com/star.COMPANYNAME.com.crt
SSLCertificateKeyFile /etc/pki/entrust-certs/
star.COMPANYNAME.com/star.COMPANYNAME.com.key
SSLCACertificateFile /etc/pki/entrust-certs/
star.COMPANYNAME.com/star.COMPANYNAME.com_bundle.crt
# SSLCertificateFile /etc/pki/tls/certs/COMPANYNAME.com.crt
# SSLCertificateKeyFile /etc/pki/tls/certs/COMPANYNAME.com.key
# SSLCACertificateFile /etc/pki/tls/certs/gd_bundle.crt
# Default to not cache anything
ExpiresActive On
ExpiresDefault access plus 0 seconds
# Cache just images
ExpiresByType
Re: Issue 3542 in reviewboard: Review requests allow drag-and-drop of attachments when not logged in
Updates: Status: Fixed Comment #2 on issue 3542 by trowb...@gmail.com: Review requests allow drag-and-drop of attachments when not logged in https://code.google.com/p/reviewboard/issues/detail?id=3542 Fixed in release-2.0.x (22b17b1). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3564 in reviewboard: rbt post for Perforce fails with modified binary files
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3564 by rick...@gmail.com: rbt post for Perforce fails with modified binary files https://code.google.com/p/reviewboard/issues/detail?id=3564 What version are you running? RBTools 0.6.2 What's the URL of the page containing the problem? n/a What steps will reproduce the problem? 1. p4 edit an existing binary file and modify it 2. p4 change to create a changelist with only the modified binary file 3. rbt post the p4 changelist What is the expected output? What do you see instead? expected: rbt successfully posts the change list to review board server what happend: rbt fails with rbtools.commands.CommandError: There don't seem to be any diffs! What operating system are you using? What browser? OS X 10.9.4, Chrome v37 Ubuntu x86 12.04, Chrome v37 Please provide any additional information below. This issue does NOT exist in RBTools 0.6.0. Although rbt 0.6.2 can post change list that has text files, any binary file in the change list will simply disappear in the posted review. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3437 in reviewboard: Double-clicking to Add a Comment in the Diff View Discards Any Comments Made
Comment #2 on issue 3437 by davidku...@gmail.com: Double-clicking to Add a Comment in the Diff View Discards Any Comments Made https://code.google.com/p/reviewboard/issues/detail?id=3437 Currently looking into this -- David Kus -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3566 in reviewboard: Need to adjust for change in 'svn propget' behavior for upcoming SVN 1.9.x
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3566 by alexey.n...@gmail.com: Need to adjust for change in 'svn propget' behavior for upcoming SVN 1.9.x https://code.google.com/p/reviewboard/issues/detail?id=3566 I noticed that RBTools breaks if a 1.9.0-dev version of SVN is in the $PATH when it tries to obtain the value of the reviewboard:url property. In 1.9.x, Subversion developers changed the return code of 'svn propget' when the property is not set: 1.8.x and previous versions returned code 0 (and empty string), while 1.9.x returns code 1 - apparently, to distinguish the property not set and property set to empty string scenarios. RBTools, failing to fetch reviewboard:url on the working copy, bails out and does not even attempt to fetch reviewboard:url from the root of the repository. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3567 in reviewboard: Allow users to annotate review request.
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3567 by tomas.br...@gmail.com: Allow users to annotate review request. https://code.google.com/p/reviewboard/issues/detail?id=3567 What version are you running? 2.0.6 There is a UX difference between review comments (done by a reviewer) and annotations (done by the reviewee). It'd be great if ReviewBoard allowed be to annotate my reviews and not confuse those annotations with review coments. Maybe just use a different color or display them differently somehow. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3452 in reviewboard: RR updated altough no changes made / warn when no changes are made
Comment #2 on issue 3452 by rd...@sfu.ca: RR updated altough no changes made / warn when no changes are made https://code.google.com/p/reviewboard/issues/detail?id=3452 I will look into this for my first easy-fix bug for fall semester. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
