Re: rbt hangs using git-bash

2015-11-11 Thread Der Mezger
Same here, the following command hangs forever:

$ rbt status -d
>>> RBTools 0.7.5
>>> Python 2.7.10 (default, May 23 2015, 09:40:32) [MSC v.1500 32 bit 
(Intel)]
>>> Running on Windows-8-6.2.9200
...
>>> Making HTTP GET request to http:///api/

Using MINGW64 GIT bash coming with GIT for Windows 2.6.1. Hopefully there 
will soon be a fix available.

Am Mittwoch, 16. September 2015 20:15:57 UTC+2 schrieb Justin Palmer:
>
> Another user at my office reported and I confirmed: rbt 0.7.4 in git-bash 
> 2.5.1 does not prompt for password, but instead hangs:
>
> $ rbt post -g --username=justinpa --parent=origin/master -d
>
> >>> RBTools 0.7.4
>
> …
> >>> Making HTTP GET request to http://localhost/reviews/api/
>
>
> git-cmd, cmd, and even my own MSYS2 will continue with:
>
>  
>
> Please log in to the Review Board server at localhost.
>
> Password:
>
>  
>
>
> ...

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Missing "View Diff" and another tab on the review request action bar

2015-11-11 Thread Californian
Hi,

I am setting up the Review Board for our team. I have installed and 
configured the Review Board v2.0.18 on a system with CentOS 7. We are using 
GitLab v7.1.1.

I am able to link the repo from GitLab with Review Board. Under my repo, I 
am also able to see committed changes in "New Review Request for Pending 
Change": "master" branch (from the drop down menu). After creating a Review 
Request, I can't find a way to view the diff. 

After reading the Review Board Manual/Doc closely, I realized in the Review 
Request, two tabs are missing on the review request action bar. According 
to the Doc, it has six tabs on the review request action bar. But I only 
see four tabs: Close, Update, Review, and Ship It! Please see the attached 
screenshot.

Apparently, we are missing the most important tab "View Diff". It seems 
something is wrong with the Diff Viewer in our Review Board system.

Any ideas what we are missing in our installation or configuration? Any 
info is appreciated.

Thanks!

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Missing "View Diff" and another tab on the review request action bar

2015-11-11 Thread David Trowbridge
Are you creating this review request from the list of committed changes? If
so, something is going wrong during that step and it's not downloading the
diff correctly. Can you check the logs for errors?

-David
On Wed, Nov 11, 2015 at 11:12 AM Californian  wrote:

> Hi,
>
> I am setting up the Review Board for our team. I have installed and
> configured the Review Board v2.0.18 on a system with CentOS 7. We are using
> GitLab v7.1.1.
>
> I am able to link the repo from GitLab with Review Board. Under my repo, I
> am also able to see committed changes in "New Review Request for Pending
> Change": "master" branch (from the drop down menu). After creating a Review
> Request, I can't find a way to view the diff.
>
> After reading the Review Board Manual/Doc closely, I realized in the
> Review Request, two tabs are missing on the review request action bar.
> According to the Doc, it has six tabs on the review request action bar. But
> I only see four tabs: Close, Update, Review, and Ship It! Please see the
> attached screenshot.
>
> Apparently, we are missing the most important tab "View Diff". It seems
> something is wrong with the Diff Viewer in our Review Board system.
>
> Any ideas what we are missing in our installation or configuration? Any
> info is appreciated.
>
> Thanks!
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-David

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: rbt hangs using git-bash

2015-11-11 Thread David Trowbridge
This looks more like a misconfigured proxy server.

-David
On Wed, Nov 11, 2015 at 8:59 AM Der Mezger  wrote:

> Same here, the following command hangs forever:
>
> $ rbt status -d
> >>> RBTools 0.7.5
> >>> Python 2.7.10 (default, May 23 2015, 09:40:32) [MSC v.1500 32 bit
> (Intel)]
> >>> Running on Windows-8-6.2.9200
> ...
> >>> Making HTTP GET request to http:///api/
>
> Using MINGW64 GIT bash coming with GIT for Windows 2.6.1. Hopefully there
> will soon be a fix available.
>
>
> Am Mittwoch, 16. September 2015 20:15:57 UTC+2 schrieb Justin Palmer:
>
>> Another user at my office reported and I confirmed: rbt 0.7.4 in git-bash
>> 2.5.1 does not prompt for password, but instead hangs:
>>
>> $ rbt post -g --username=justinpa --parent=origin/master -d
>>
>> >>> RBTools 0.7.4
>>
>> …
>> >>> Making HTTP GET request to http://localhost/reviews/api/
>>
>>
>> git-cmd, cmd, and even my own MSYS2 will continue with:
>>
>>
>>
>> Please log in to the Review Board server at localhost.
>>
>> Password:
>>
>>
>>
>>
>> ...
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-David

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: rbt hangs using git-bash

2015-11-11 Thread Justin Palmer
In my case, a proxy server was unnecessary to reach RB server. And rbt 
works from other consoles, not git-bash.


On Wednesday, November 11, 2015 at 1:16:04 PM UTC-6, David Trowbridge wrote:
>
> This looks more like a misconfigured proxy server.
>
> -David
> On Wed, Nov 11, 2015 at 8:59 AM Der Mezger  > wrote:
>
>> Same here, the following command hangs forever:
>>
>> $ rbt status -d
>> >>> RBTools 0.7.5
>> >>> Python 2.7.10 (default, May 23 2015, 09:40:32) [MSC v.1500 32 bit 
>> (Intel)]
>> >>> Running on Windows-8-6.2.9200
>> ...
>> >>> Making HTTP GET request to http:///api/
>>
>> Using MINGW64 GIT bash coming with GIT for Windows 2.6.1. Hopefully there 
>> will soon be a fix available.
>>
>>
>> Am Mittwoch, 16. September 2015 20:15:57 UTC+2 schrieb Justin Palmer:
>>
>>> Another user at my office reported and I confirmed: rbt 0.7.4 in 
>>> git-bash 2.5.1 does not prompt for password, but instead hangs:
>>>
>>> $ rbt post -g --username=justinpa --parent=origin/master -d
>>>
>>> >>> RBTools 0.7.4
>>>
>>> …
>>> >>> Making HTTP GET request to http://localhost/reviews/api/
>>>
>>>
>>> git-cmd, cmd, and even my own MSYS2 will continue with:
>>>
>>>  
>>>
>>> Please log in to the Review Board server at localhost.
>>>
>>> Password:
>>>
>>>  
>>>
>>>
>>> ...
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
> -- 
> -David 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Reviewboard 2.0.20: Clearcase Repository

2015-11-11 Thread Robert Bolen
Hello,

1) When using the repository clearcase with the path 
/view/testReviewBoardView in the Admin Dashboard for some reason Review 
Board is cutting off the forward slash for my filepath when uploading a 
diff file and trying to view the diff.

The error I received is below and the forward slash in front of vobs is 
missing
Error: The file 
'vobs/modules/stb_lightning/.@@/main/inv_stb_lightning_rel_100/2/source/main/inv_stb_lightning_rel_100/1'
 
could not be found in the repository

A solution I found that would fix this issue is adding a forward slash at 
the end of the repository path /view/testReviewBoardView/, and this 
resolved the error and allowed me to view the diff.

This caused another issue when try to view a diff where a findmerge, a 
specifc feature of clearcase, is needed.

2) When attempting to view a diff file I receive an error in the apache log 
file: 

Error: DeprecationWarning: SCMTool.file_exists() must take keyword 
arguments, signature for ClearCase is deprecated

Checking if file 
/view/testReviewBoardView//vobs/modules/stb_lightning/.@@/main/inv_stb_lightning_rel_100/2
 
exists 

This appears to be caused by there being a double slash in the file path 
(highlighted).

Attached is the diff file that I was using to test.

Thanks in advance,

Robert

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
findmerge indicator: /vobs/modules/stb_lightning/.@@/main/inv_stb_lightning_rel_100/2/source/main/inv_stb_lightning_rel_100/17/g_hopper/main/inv_stb_lightning_rel_100/1/source/main/inv_stb_lightning_rel_100/3/gcs_sling_api.c@@/main/inv_stb_lightning_rel_100/17
--- /vobs/modules/stb_lightning/.@@/main/inv_stb_lightning_rel_100/2/source/main/inv_stb_lightning_rel_100/17/g_hopper/main/inv_stb_lightning_rel_100/1/source/main/inv_stb_lightning_rel_100/3/gcs_sling_api.c@@/main/inv_stb_lightning_rel_100/16	2014-12-10 17:00:54.0 -0700
+++ /vobs/modules/stb_lightning/.@@/main/inv_stb_lightning_rel_100/2/source/main/inv_stb_lightning_rel_100/17/g_hopper/main/inv_stb_lightning_rel_100/1/source/main/inv_stb_lightning_rel_100/3/gcs_sling_api.c@@/main/inv_stb_lightning_rel_100/inv_stb_lightning_cr111504/1	2015-10-26 10:28:19.0 -0600
@@ -42,6 +42,7 @@
 //debug group
 #define MY_DEBUG_GROUP esosal_GCS_API_grp
 
+#define SECONDS_IN_ONE_HOUR  (3600)
 /** MACROS **/
 #define IPVOD_SERVER_NAME("Production")
 
@@ -68,6 +69,9 @@
RC_RESULT_E  rc_ret = RC_FAILURE;
GET_STB_PROFILE_IN_S   x_profile_in = {};
GET_STB_PROFILE_OUT_S x_profile_out = {0};
+   COMMON_HDR_XIP_S   x_common_xip_req = {};
+   RC_REQ_IP_S   x_host_ip = {0};
+   TIME_XIP_OUT_S  x_time_resp = {0};
intsnprintf_ret = -1;
char  rxid[GCS_STB_RECEIVER_ID_LEN] = {'\0'};
 



Re: Missing "View Diff" and another tab on the review request action bar

2015-11-11 Thread Californian
Thank you for the quick reply. Really appreciate!

Yes, I created a request from the list of committed changes. And I checked 
the log. I think I might know what's going on here.

We were unable to see the list of committed changes in the beginning. It's 
because we are running GitLab 7.1.1 (a little behind of the latest 
version). We had to modify gitlab.py file under /usr/lib/python2.7/site-
packages/reviewboard/hostingsvcs. In the original gitlab.py, in line 249, 
it had message=item['message'] which does not match our current 
gitlab (7.1.1) has. So, we replaced message=item['message'] with 
message=item['title']. 

After this modification, we are able to see the list of committed changes.

I think we might need to change other Review Board related .py script as 
well to match the change we made. Any suggestions? I understand changing 
the original .py files in Review Board is not a good idea. But before we 
upgrade to the new version of GitLab, this might be the only solution we 
have. Any suggestion is appreciated.

By the way, here are the errors I see in the log:

- Unable to update new review request from commit ID 
c4a817a2e2d48f6dea74903a1eb42efe8e6cd84b: u'message'
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/reviewboard/reviews/managers.py", line 
150, in create
review_request.update_from_commit_id(commit_id)
  File 
"/usr/lib/python2.7/site-packages/reviewboard/reviews/models/base_review_request_details.py",
 line 194, in update_from_commit_id
self.update_from_committed_change(commit_id)
  File 
"/usr/lib/python2.7/site-packages/reviewboard/reviews/models/base_review_request_details.py",
 line 238, in update_from_committed_change
commit = self.repository.get_change(commit_id)
  File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/models.py", line 
434, in get_change
return hosting_service.get_change(self, revision)
  File "/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/gitlab.py", 
line 298, in get_change
message = commit['message'] 

KeyError: u'message' 

Thank you again for the help!



On Wednesday, November 11, 2015 at 11:14:53 AM UTC-8, David Trowbridge 
wrote:
>
> Are you creating this review request from the list of committed changes? 
> If so, something is going wrong during that step and it's not downloading 
> the diff correctly. Can you check the logs for errors?
>
> -David
> On Wed, Nov 11, 2015 at 11:12 AM Californian  > wrote:
>
>> Hi,
>>
>> I am setting up the Review Board for our team. I have installed and 
>> configured the Review Board v2.0.18 on a system with CentOS 7. We are using 
>> GitLab v7.1.1.
>>
>> I am able to link the repo from GitLab with Review Board. Under my repo, 
>> I am also able to see committed changes in "New Review Request for Pending 
>> Change": "master" branch (from the drop down menu). After creating a Review 
>> Request, I can't find a way to view the diff. 
>>
>> After reading the Review Board Manual/Doc closely, I realized in the 
>> Review Request, two tabs are missing on the review request action bar. 
>> According to the Doc, it has six tabs on the review request action bar. But 
>> I only see four tabs: Close, Update, Review, and Ship It! Please see the 
>> attached screenshot.
>>
>> Apparently, we are missing the most important tab "View Diff". It seems 
>> something is wrong with the Diff Viewer in our Review Board system.
>>
>> Any ideas what we are missing in our installation or configuration? Any 
>> info is appreciated.
>>
>> Thanks!
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
> -- 
> -David 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Missing "View Diff" and another tab on the review request action bar

2015-11-11 Thread David Trowbridge
This is a known bug which is fixed in the 2.5 releases. We may do another
2.0.x release at some point, in which case it will be included there as
well.

-David

On Wed, Nov 11, 2015 at 12:05 PM, Californian  wrote:

> Thank you for the quick reply. Really appreciate!
>
> Yes, I created a request from the list of committed changes. And I checked
> the log. I think I might know what's going on here.
>
> We were unable to see the list of committed changes in the beginning. It's
> because we are running GitLab 7.1.1 (a little behind of the latest
> version). We had to modify gitlab.py file under /usr/lib/python2.7/site-
> packages/reviewboard/hostingsvcs. In the original gitlab.py, in line 249,
> it had message=item['message'] which does not match our current
> gitlab (7.1.1) has. So, we replaced message=item['message'] with
> message=item['title'].
>
> After this modification, we are able to see the list of committed changes.
>
> I think we might need to change other Review Board related .py script as
> well to match the change we made. Any suggestions? I understand changing
> the original .py files in Review Board is not a good idea. But before we
> upgrade to the new version of GitLab, this might be the only solution we
> have. Any suggestion is appreciated.
>
> By the way, here are the errors I see in the log:
>
> - Unable to update new review request from commit ID 
> c4a817a2e2d48f6dea74903a1eb42efe8e6cd84b: u'message'
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/site-packages/reviewboard/reviews/managers.py", 
> line 150, in create
> review_request.update_from_commit_id(commit_id)
>   File 
> "/usr/lib/python2.7/site-packages/reviewboard/reviews/models/base_review_request_details.py",
>  line 194, in update_from_commit_id
> self.update_from_committed_change(commit_id)
>   File 
> "/usr/lib/python2.7/site-packages/reviewboard/reviews/models/base_review_request_details.py",
>  line 238, in update_from_committed_change
> commit = self.repository.get_change(commit_id)
>   File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/models.py", 
> line 434, in get_change
> return hosting_service.get_change(self, revision)
>   File "/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/gitlab.py", 
> line 298, in get_change
> message = commit['message']
>
> KeyError: u'message'
>
> Thank you again for the help!
>
>
>
> On Wednesday, November 11, 2015 at 11:14:53 AM UTC-8, David Trowbridge
> wrote:
>>
>> Are you creating this review request from the list of committed changes?
>> If so, something is going wrong during that step and it's not downloading
>> the diff correctly. Can you check the logs for errors?
>>
>> -David
>> On Wed, Nov 11, 2015 at 11:12 AM Californian  wrote:
>>
>>> Hi,
>>>
>>> I am setting up the Review Board for our team. I have installed and
>>> configured the Review Board v2.0.18 on a system with CentOS 7. We are using
>>> GitLab v7.1.1.
>>>
>>> I am able to link the repo from GitLab with Review Board. Under my repo,
>>> I am also able to see committed changes in "New Review Request for Pending
>>> Change": "master" branch (from the drop down menu). After creating a Review
>>> Request, I can't find a way to view the diff.
>>>
>>> After reading the Review Board Manual/Doc closely, I realized in the
>>> Review Request, two tabs are missing on the review request action bar.
>>> According to the Doc, it has six tabs on the review request action bar. But
>>> I only see four tabs: Close, Update, Review, and Ship It! Please see the
>>> attached screenshot.
>>>
>>> Apparently, we are missing the most important tab "View Diff". It seems
>>> something is wrong with the Diff Viewer in our Review Board system.
>>>
>>> Any ideas what we are missing in our installation or configuration? Any
>>> info is appreciated.
>>>
>>> Thanks!
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
>> -David
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Bo

Re: Missing "View Diff" and another tab on the review request action bar

2015-11-11 Thread Californian
Just upgraded RB and Site to 2.5.1.1 by running "easy_install -U 
ReviewBoard" and "rb-site upgrade /path/to/site" w/o any errors. But I am 
still missing two tabs on the review request action bar. Please see the 
attached screenshot. 

I checked the log. No .py files related errors after upgrading to 2.5.1.1. 
Only see two warnings:

1.

 - /usr/lib/python2.7/site-packages/feedparser.py:364: DeprecationWarning: To 
avoid breaking existing software while fixing issue 310, a temporary mapping 
has been created from `updated_parsed` to `published_parsed` if 
`updated_parsed` doesn't exist. This fallback will be removed in a future 
version of feedparser.
  DeprecationWarning)


2.

- 
/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/reviews/markdown_utils.py:40:
 DeprecationWarning: reviewboard.reviews.markdown_utils.markdown_escape is 
deprecated. Please use djblets.markdown.markdown_escape.
  DeprecationWarning)


I also see some debug message like this. Not sure it is an issue.

- Cache miss for key jsi18n-djangojs-reviewboard_djblets-en-1447273457.


Any ideas why we are still missing "Download Diff" and "Diff" tabs after 
upgrading to 2.5.1.1.


Thanks!

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Missing "View Diff" and another tab on the review request action bar

2015-11-11 Thread David Trowbridge
Was this a review request you created from before the upgrade or after?

-David

On Wed, Nov 11, 2015 at 1:19 PM, Californian  wrote:

> Just upgraded RB and Site to 2.5.1.1 by running "easy_install -U
> ReviewBoard" and "rb-site upgrade /path/to/site" w/o any errors. But I am
> still missing two tabs on the review request action bar. Please see the
> attached screenshot.
>
> I checked the log. No .py files related errors after upgrading to 2.5.1.1.
> Only see two warnings:
>
> 1.
>
>  - /usr/lib/python2.7/site-packages/feedparser.py:364: DeprecationWarning: To 
> avoid breaking existing software while fixing issue 310, a temporary mapping 
> has been created from `updated_parsed` to `published_parsed` if 
> `updated_parsed` doesn't exist. This fallback will be removed in a future 
> version of feedparser.
>   DeprecationWarning)
>
>
> 2.
>
> - 
> /usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/reviews/markdown_utils.py:40:
>  DeprecationWarning: reviewboard.reviews.markdown_utils.markdown_escape is 
> deprecated. Please use djblets.markdown.markdown_escape.
>   DeprecationWarning)
>
>
> I also see some debug message like this. Not sure it is an issue.
>
> - Cache miss for key jsi18n-djangojs-reviewboard_djblets-en-1447273457.
>
>
> Any ideas why we are still missing "Download Diff" and "Diff" tabs after 
> upgrading to 2.5.1.1.
>
>
> Thanks!
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: rbt hangs using git-bash

2015-11-11 Thread Michael Anselmi
I'm having the same problem as well when using git-bash on Windows (see 
debug output below).  It works just fine using the Windows command prompt, 
ConEmu (Windows), and from Linux, and there's no proxy server between me 
and the RB server.  I'm using RBTools 0.7.5 and Git for Windows 2.6.3.  The 
repository in this case is a git-svn repo.  The server is running Review 
Board 2.0.18.

Please let me know if I can provide additional information that be helpful. 
 One thing I am not able to do is upgrade our Review Board server.

Best,

Michael

$ rbt post --server https://rb.server.url --repository repo_name --debug 
--tracking-branch git-svn
>>> RBTools 0.7.5 alpha 0 (dev)
>>> Python 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit 
(Intel)]
>>> Running on Windows-7-6.1.7601-SP1
>>> Home = Z:\
>>> Current directory = D:\Repos\Git\repo_name
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Command exited with rc 1: ['svn', '--non-interactive', u'info']
svn: E155007: 'D:\Repos\Git\repo_name' is not a working copy
---
>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
>>> Running: git config core.bare
>>> Running: git rev-parse --show-toplevel
>>> Running: git symbolic-ref -q HEAD
>>> Running: git svn info
>>> repository info: Path: https://svn.server.url/svn/repo_name, Base path: 
/, Supports changesets: False
>>> Making HTTP GET request to https://rb.server.url/api/
[gets stuck here]

On Wednesday, November 11, 2015 at 2:43:08 PM UTC-5, Justin Palmer wrote:
>
> In my case, a proxy server was unnecessary to reach RB server. And rbt 
> works from other consoles, not git-bash.
>
>
> On Wednesday, November 11, 2015 at 1:16:04 PM UTC-6, David Trowbridge 
> wrote:
>>
>> This looks more like a misconfigured proxy server.
>>
>> -David
>> On Wed, Nov 11, 2015 at 8:59 AM Der Mezger  wrote:
>>
>>> Same here, the following command hangs forever:
>>>
>>> $ rbt status -d
>>> >>> RBTools 0.7.5
>>> >>> Python 2.7.10 (default, May 23 2015, 09:40:32) [MSC v.1500 32 bit 
>>> (Intel)]
>>> >>> Running on Windows-8-6.2.9200
>>> ...
>>> >>> Making HTTP GET request to http:///api/
>>>
>>> Using MINGW64 GIT bash coming with GIT for Windows 2.6.1. Hopefully 
>>> there will soon be a fix available.
>>>
>>>
>>> Am Mittwoch, 16. September 2015 20:15:57 UTC+2 schrieb Justin Palmer:
>>>
 Another user at my office reported and I confirmed: rbt 0.7.4 in 
 git-bash 2.5.1 does not prompt for password, but instead hangs:

 $ rbt post -g --username=justinpa --parent=origin/master -d

 >>> RBTools 0.7.4

 …
 >>> Making HTTP GET request to http://localhost/reviews/api/


 git-cmd, cmd, and even my own MSYS2 will continue with:

  

 Please log in to the Review Board server at localhost.

 Password:

  


 ...
>>>
>>> -- 
>>> Supercharge your Review Board with Power Pack: 
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons: 
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> --- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> -- 
>> -David 
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Missing "View Diff" and another tab on the review request action bar

2015-11-11 Thread Californian
It is a new review request I created after the upgrade.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Missing "View Diff" and another tab on the review request action bar

2015-11-11 Thread Californian
I again looked at the upgrade log closely. See below.
This message "There are unapplied evolutions for diffviewer." does not look 
good. 
Do you thnk I might have something not install/configure properly? If yes, 
how to fix it?

Thanks!

***

Creating tables ...

Creating table accounts_trophy

Creating table attachments_fileattachmenthistory

Creating table diffviewer_rawfilediffdata

Creating table notifications_webhooktarget_repositories

Creating table notifications_webhooktarget

Creating table webapi_webapitoken

Upgrading Review Board from 2.0.18 to 2.5.1.1

There are unapplied evolutions for accounts.

There are unapplied evolutions for attachments.

There are unapplied evolutions for diffviewer.

There are unapplied evolutions for notifications.

There are unapplied evolutions for reviews.

There are unapplied evolutions for webapi.

Adding baseline version for new models

Evolutions in notifications baseline: webhooktarget_extra_state, 
webhooktarget_extra_data_null

Project signature has changed - an evolution is required

Installing custom SQL ...

Installing indexes ...

Installed 0 object(s) from 0 fixture(s)

Evolution successful.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Missing "View Diff" and another tab on the review request action bar

2015-11-11 Thread Christian Hammond
Before all that, you'll notice it says to ignore any messages unless it
fails. That mesage is simply part of the upgrade process. Further below,
you'll see that it says the evolution was successful, so you're fine there.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Wed, Nov 11, 2015 at 3:30 PM, Californian  wrote:

> I again looked at the upgrade log closely. See below.
> This message "There are unapplied evolutions for diffviewer." does not
> look good.
> Do you thnk I might have something not install/configure properly? If yes,
> how to fix it?
>
> Thanks!
>
> ***
>
> Creating tables ...
>
> Creating table accounts_trophy
>
> Creating table attachments_fileattachmenthistory
>
> Creating table diffviewer_rawfilediffdata
>
> Creating table notifications_webhooktarget_repositories
>
> Creating table notifications_webhooktarget
>
> Creating table webapi_webapitoken
>
> Upgrading Review Board from 2.0.18 to 2.5.1.1
>
> There are unapplied evolutions for accounts.
>
> There are unapplied evolutions for attachments.
>
> There are unapplied evolutions for diffviewer.
>
> There are unapplied evolutions for notifications.
>
> There are unapplied evolutions for reviews.
>
> There are unapplied evolutions for webapi.
>
> Adding baseline version for new models
>
> Evolutions in notifications baseline: webhooktarget_extra_state,
> webhooktarget_extra_data_null
>
> Project signature has changed - an evolution is required
>
> Installing custom SQL ...
>
> Installing indexes ...
>
> Installed 0 object(s) from 0 fixture(s)
>
> Evolution successful.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Missing "View Diff" and another tab on the review request action bar

2015-11-11 Thread Californian
Thank you for the message! I thought my original install might have some 
issue that is causing two tabs are missing from the review request action 
bar.  

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Missing "View Diff" and another tab on the review request action bar

2015-11-11 Thread Californian
I checked the log again. After upgrading from 2.0.18 to 2.5.1.1, I created 
a new request from a commit. There are errors. See error_1.txt.
Then I 
modified 
/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/hostingsvcs/gitlab.py",
 
line 299, replaced "message = commit['message']" with "message = 
commit['title']". 

And then, I created another new request from another new commit. 
Unfortunately, I am getting more errors. See error_2.txt.

>From what I got, I think  the original gitlab.py file is incompatible with 
the version of Gitlab we are using (7.1.1). 

Upgrading RB to 2.5.1.1 does not resolve the issue we have (missing view 
diff tab on the review request action bar ).

Any help will be appreciated.

Thanks!





-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
- Unable to update new review request from commit ID 
ede5d7e7298fcadc090469874911b6366e7b10df: HTTP Error 401: Unauthorized
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/reviews/managers.py",
 line 150, in create
review_request.update_from_commit_id(commit_id)
  File 
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/reviews/models/base_review_request_details.py",
 line 220, in update_from_commit_id
self.update_from_committed_change(commit_id)
  File 
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/reviews/models/base_review_request_details.py",
 line 264, in update_from_committed_change
commit = self.repository.get_change(commit_id)
  File 
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/scmtools/models.py",
 line 450, in get_change
return hosting_service.get_change(self, revision)
  File 
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/hostingsvcs/gitlab.py",
 line 317, in get_change
headers={'Accept': 'text/plain'})
  File 
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/hostingsvcs/service.py",
 line 55, in http_get
return self.http_request(url, method='GET', **kwargs)
  File 
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/hostingsvcs/service.py",
 line 79, in http_request
u = urlopen(r)
  File "/usr/lib64/python2.7/urllib2.py", line 127, in urlopen
return _opener.open(url, data, timeout)
  File "/usr/lib64/python2.7/urllib2.py", line 410, in open
response = meth(req, response)
  File "/usr/lib64/python2.7/urllib2.py", line 523, in http_response
'http', request, response, code, msg, hdrs)
  File "/usr/lib64/python2.7/urllib2.py", line 448, in error
return self._call_chain(*args)
  File "/usr/lib64/python2.7/urllib2.py", line 382, in _call_chain
result = func(*args)
  File "/usr/lib64/python2.7/urllib2.py", line 531, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
HTTPError: HTTP Error 401: Unauthorized- Unable to update new review request from commit ID 
57a759c8fd55b1ef44ca226e444c041321930431: u'message'
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/reviews/managers.py",
 line 150, in create
review_request.update_from_commit_id(commit_id)
  File 
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/reviews/models/base_review_request_details.py",
 line 220, in update_from_commit_id
self.update_from_committed_change(commit_id)
  File 
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/reviews/models/base_review_request_details.py",
 line 264, in update_from_committed_change
commit = self.repository.get_change(commit_id)
  File 
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/scmtools/models.py",
 line 450, in get_change
return hosting_service.get_change(self, revision)
  File 
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/hostingsvcs/gitlab.py",
 line 299, in get_change
message = commit['message']
KeyError: u'message'