Re: ReviewBoard git support
On Fri, Oct 29, 2010 at 1:27 AM, Stephen Gallagher karrde...@gmail.comwrote: On Oct 28, 5:59 pm, Aleix Pol aleix...@kde.org wrote: Hi ReviewBoardians! I'm a KDE developer and we're being moved from svn to git. In KDevelop we where using gitorious, there's a feature called merge request where a branch is given and it is compared to its parent which is pretty cool because you're not forced to create a plain patch (without all the history). I guess it should be quite easy to add that into ReviewBoard by processing the output of a git call instead of a patch file, do you think it would be feasable? Check out RBtools' post-review. http://www.reviewboard.org/docs/releasenotes/dev/rbtools/0.2/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en I was thinking more like RB could understand DVCS contribution paradigm. I don't really like to tell newcomers (the ones who use RB) to install a new application, also this would make it a little hard to tell what has to be merged. Aleix -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
ReviewBoard git support
Hi ReviewBoardians! I'm a KDE developer and we're being moved from svn to git. In KDevelop we where using gitorious, there's a feature called merge request where a branch is given and it is compared to its parent which is pretty cool because you're not forced to create a plain patch (without all the history). I guess it should be quite easy to add that into ReviewBoard by processing the output of a git call instead of a patch file, do you think it would be feasable? Thanks! Aleix -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Taking a nap when uploading a file
I just realized that this request it doesn't work if the last / (slash) is not present, with the url like http://reviewboard.kde.org/api/json/reviewrequests/4647/diff/new . I don't really know if that should have a meaning but it's quite confusing. Hope that helps. Aleix On Fri, Jul 16, 2010 at 5:25 AM, Aleix Pol aleix...@kde.org wrote: Well I could make it work. Just for the record, the correct line was this: curl http://reviewboard.kde.org/api/json/reviewrequests/4647/diff/new/ -u apol -F basedir=/trunk/KDE/kdeedu/kalgebra -F pa...@cosa | json_reformat On Thu, Jul 15, 2010 at 11:37 PM, Christian Hammond chip...@chipx86.comwrote: You can't yet. It's one of the things I'm working on before 1.5. What you can do though is browse /api/ (I recommend the JSONView FireFox extension for this), and look at reviewboard/webapi/resources.py. The new API is pretty browseable. Not everything, but it's getting there. You can also look at the unit tests in reviewboard/webapi/tests.py, which use each of the supplied APIs. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Jul 15, 2010 at 2:22 PM, Aleix Pol aleix...@kde.org wrote: We have 1.5 beta 2 installed there. I guess it should be fine to use 1.5 API. Where can I find the documentation for the new API? On Thu, Jul 15, 2010 at 11:13 PM, Christian Hammond chip...@chipx86.com wrote: Hi Aleix, Off-hand, I don't know why it'd be problematic, but I'd recommend setting up a little development server on your box, set DEBUG = True in your settings_local.py, and testing it there. We should be able to better see what the error is that way, along with lots of debug information. We try to return JSON payloads for everything, but a 500 error can happen when something internally breaks. That'd definitely be a bug, since we want to return gracefully with *something*. Just a heads up. Review Board 1.5 RC 1 is out, and we're looking to release hopefully soon (just working on docs and some last-minute bugs). There's a new API in 1.5 that sits alongside the old API. The new one is better, cleaner, more flexible, and will let you do more of what you need. I don't know how you want to handle development of this plugin, but if you want to support 1.5's API as well, you can query /api/info/, and if that's not a 404, it will be 1.5. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Jul 15, 2010 at 12:51 PM, Aleix Pol aleix...@gmail.com wrote: Hi, I am Aleix Pol, from the KDE project. I'm working on a little plugin for KDevelop that will enable the user to send patches directly a reviewboard service. I've been testing the API using curl and there I can create a new review but when I try to add a patch I get an HTML error saying that review board is taking a nap, which is weird not only because I didn't know that software took naps but because the rest of the API replies with JSON data but here it's that weird HTML error message. Could somebody tell my why is that happening? I am using that line: curl http://reviewboard.kde.org/api/json/reviewrequests/4647/diff/new- u apol -X POST --data -T test_reviewboard.patch Thanks, Aleix PS: The service should be working because it works with postreview. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group
Taking a nap when uploading a file
Hi, I am Aleix Pol, from the KDE project. I'm working on a little plugin for KDevelop that will enable the user to send patches directly a reviewboard service. I've been testing the API using curl and there I can create a new review but when I try to add a patch I get an HTML error saying that review board is taking a nap, which is weird not only because I didn't know that software took naps but because the rest of the API replies with JSON data but here it's that weird HTML error message. Could somebody tell my why is that happening? I am using that line: curl http://reviewboard.kde.org/api/json/reviewrequests/4647/diff/new - u apol -X POST --data -T test_reviewboard.patch Thanks, Aleix PS: The service should be working because it works with postreview. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Taking a nap when uploading a file
Well I could make it work. Just for the record, the correct line was this: curl http://reviewboard.kde.org/api/json/reviewrequests/4647/diff/new/ -u apol -F basedir=/trunk/KDE/kdeedu/kalgebra -F pa...@cosa | json_reformat On Thu, Jul 15, 2010 at 11:37 PM, Christian Hammond chip...@chipx86.comwrote: You can't yet. It's one of the things I'm working on before 1.5. What you can do though is browse /api/ (I recommend the JSONView FireFox extension for this), and look at reviewboard/webapi/resources.py. The new API is pretty browseable. Not everything, but it's getting there. You can also look at the unit tests in reviewboard/webapi/tests.py, which use each of the supplied APIs. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Jul 15, 2010 at 2:22 PM, Aleix Pol aleix...@kde.org wrote: We have 1.5 beta 2 installed there. I guess it should be fine to use 1.5 API. Where can I find the documentation for the new API? On Thu, Jul 15, 2010 at 11:13 PM, Christian Hammond chip...@chipx86.comwrote: Hi Aleix, Off-hand, I don't know why it'd be problematic, but I'd recommend setting up a little development server on your box, set DEBUG = True in your settings_local.py, and testing it there. We should be able to better see what the error is that way, along with lots of debug information. We try to return JSON payloads for everything, but a 500 error can happen when something internally breaks. That'd definitely be a bug, since we want to return gracefully with *something*. Just a heads up. Review Board 1.5 RC 1 is out, and we're looking to release hopefully soon (just working on docs and some last-minute bugs). There's a new API in 1.5 that sits alongside the old API. The new one is better, cleaner, more flexible, and will let you do more of what you need. I don't know how you want to handle development of this plugin, but if you want to support 1.5's API as well, you can query /api/info/, and if that's not a 404, it will be 1.5. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Jul 15, 2010 at 12:51 PM, Aleix Pol aleix...@gmail.com wrote: Hi, I am Aleix Pol, from the KDE project. I'm working on a little plugin for KDevelop that will enable the user to send patches directly a reviewboard service. I've been testing the API using curl and there I can create a new review but when I try to add a patch I get an HTML error saying that review board is taking a nap, which is weird not only because I didn't know that software took naps but because the rest of the API replies with JSON data but here it's that weird HTML error message. Could somebody tell my why is that happening? I am using that line: curl http://reviewboard.kde.org/api/json/reviewrequests/4647/diff/new - u apol -X POST --data -T test_reviewboard.patch Thanks, Aleix PS: The service should be working because it works with postreview. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users
