Re: Is Review Board mostly useful in offline code review?

[Jeff Andros]

This is how we started using reviewboard: we would use it more as meeting
notes during a conference room code review.

We progressed through that by everyone reviewing the code and leaving notes,
then meeting in the conference room to go over them, but dropped the face to
face part shortly afterwards.  Reviewboard just makes it unneccessary.

but to answer your question, it works pretty well for face to face reviews.

--Jeff

On Thu, Sep 29, 2011 at 10:49 AM, Nelson Jones  wrote:

> Is it overkill if used for  meeting type code review (face to face
> code review)? Any comments?
> Thanks
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Code block functionality in comment posts

[Jeff Andros]

+1
On May 4, 2011 10:40 AM, "Stephen Tyree"  wrote:
> Hello all,
>
> I've been using ReviewBoard for over a year now, and the only thing I
> find a lacking from a user perspective is the commenting
> functionality. When posting comments, I don't have the ability to
> format fixed-width blocks of code or have the code in those blocks be
> properly syntax highlighted. Given that ReviewBoard is (AFAIK)
> typically used for code reviews, this seems like an obvious win
> functionality wise. Are there any plans to add this in future
> versions?
>
> Thanks!
> Stephen Tyree
>
> --
> Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Installing ReviewBoard in Ubuntu 10.04

[Jeff Andros]

OK, is there a reason you're not using setuptools and apt rather than
downloading the tar.gz files?

--Jeff

On Tue, Sep 7, 2010 at 11:27 PM, Rajat Khandelwal wrote:

>  On 09/07/2010 12:39 PM, Jeff Andros wrote:
>
> You've tried following the steps here?
> http://www.reviewboard.org/docs/manual/dev/admin/installation/linux/
> I don't know that there's anything different enough in Ubuntu 10.4 that
> would make these instructions not work.
>
>  --Jeff
>
> On Tue, Sep 7, 2010 at 11:25 AM, Rajat Khandelwal 
> wrote:
>
>> Hi all
>>
>> I wanted to install review board in my ubuntu 10.04 and as there are no
>> good tutorials about that, I am unable to do that. Please help me in this.
>> Thanks.
>>
>> --
>> Rajat Khandelwal
>> SD 39 Satpura Hostel
>> B.Tech. Comp. Sc. & Engg. 2nd year
>> IIT Delhi
>>  --
>> Want to help the Review Board project? Donate today at
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to
>> reviewboard+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/reviewboard?hl=en
>
>
>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>
> Yes, I have followed the the instructions. I have downloaded
> PIL1.1.7.tar.gz, Djblets.tar.gz and ReviewBoard.tar.gz. Now I did python
> setup.py install in pil directory. After it I did python setup.py install in
> Djblets and it still says pill not installed.
> Again running selftest.py in pil directory, I get freetype not installed,
> tkinter support not installed, pil core not installed, littlecms not
> installed. Now what does that all imply?
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Installing ReviewBoard in Ubuntu 10.04

[Jeff Andros]

You've tried following the steps here?
http://www.reviewboard.org/docs/manual/dev/admin/installation/linux/
I
don't know that there's anything different enough in Ubuntu 10.4 that would
make these instructions not work.

--Jeff

On Tue, Sep 7, 2010 at 11:25 AM, Rajat Khandelwal wrote:

> Hi all
>
> I wanted to install review board in my ubuntu 10.04 and as there are no
> good tutorials about that, I am unable to do that. Please help me in this.
> Thanks.
>
> --
> Rajat Khandelwal
> SD 39 Satpura Hostel
> B.Tech. Comp. Sc. & Engg. 2nd year
> IIT Delhi
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Multiple diffs in the same review request

[Jeff Andros]

How is this different from the "update diff" option that's currently there?

On Fri, May 7, 2010 at 5:00 PM, Andrew  wrote:

> Hi guys.  I've been playing with the multiple revisions support in
> ReviewBoard.
>
> I was wondering what people think about these two suggestions:
>
> 1. It would be nice to be able to compose changesets.  For instance,
> if I have one changeset under review, it then gets reviewed, then I
> post a second changeset that is based on the first changeset, it would
> be neat to be able to see the diff from pre-first diff to post-second
> diff.  I understand that currently, it is possible to see the diff
> from post-first diff to post-second diff.
>
> 2. Given that #1 is not currently a feature, I am instructing all of
> my users to update review requests with changesets that are based on
> the same initial revision.  This way, the reviewer can see what's new
> in the second revision, as well as the full second revision.  I'm
> wondering whether it would be worth optionally enforcing this as a
> feature, or warning the user if the different revisions have different
> parents.
>
> My question #2 may be related to my other question at
>
> http://groups.google.com/group/reviewboard/browse_thread/thread/aefd7a770dca771a
>
> Thanks.
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: What does "ship it" and "starred" review request mean?

[Jeff Andros]

We use "Ship it" is a marker from the reviewers that they believe the code
is ready to be committed (shipping the changed code, as in to customers)
Some times the reviewer will want the original author to make the changes,
and re-post the code (if the changes are sufficiently minor, we normally
skip this step, and list changes but mark the review ship it)

The stars I don't use too much, but I believe they're like the stars in
Gmail, In this case they mark a review you may want to check back on for
some reason.

--Jeff

2010/1/21 qhlonline 

> Hi, all.
>   I am not quite catch what does the reviews label "ship it" and "star"
> mean. What does these used to do and how to use them in practice? can any
> one give me some suggestion?
>   And In my understanding, I think "ship it" can lable a review as
> critical or urgent to other reviewers. Is that true? if not, how to label
> ureng review request or reviews ?
>
>
> Best Regards!
>
>
>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: New member and new idea

[Jeff Andros]

there is a next/previous comment hotkey: the '[' and ']' keys move between
comments.

--Jeff

On Wed, Jan 20, 2010 at 8:29 AM, 张鸥  wrote:

> Hi,
>
>   Thanks for your great work! I am a Sr. Software Engineer from *Symantec*.
> I set up a review board system in our team. It works well. We all like it.
>
>Well, but there are no features we need.  I have an idea. It would be
> nice if the review system had a "next comment" or "Collapse/Expand" button
> that is always available to click. This would make it easier to see other
> people's comments in cases like this.
>
> --
> Thanks & Regards
> Vincent Zhang
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Love Dont Cost a Thing clip

[Jeff Andros]

I thought these were moderated now?

On Mon, Jan 18, 2010 at 6:12 AM, Press Centre  wrote:

> "Love Don't Cost a Thing" clip special edition with Naked Jennifer
> Lopez! Just look!
> http://duuit.com/-jenifer
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>
-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: user forgets password / password reset

[Jeff Andros]

we've just got a small deployment on a pretty trusted team, but we set the
"root" password to be a generic company password... users who forget their
password can use that in the administration panel and reset their password
that way.

On Tue, Nov 10, 2009 at 11:54 AM, Chris Clark wrote:

>
> Possibly dumb question; how can users self-service forgotten passwords?
>
> We're using Review Board 1.0.5.1
>
> The login screen only has options for logging in or creating a new
> account. I ended up going into the admin account and changing the
> password for the user but this isn't something I want to do for everyone
> ;-)
>
> Is there some Django setting I need to set to enable password resets?
>
> Thanks!
>
> Chris
>
>
> > To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
> -~--~~~~--~~--~--~---
>
>

--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Error 500 Logging on "New Review Request"

[Jeff Andros]

Hmmm, sounds like it's probably something in your web server install... We 
might be getting beyond me, but can you describe you environment? Send a copy 
of your (sanitized) config file?
--Jeff

-Original Message-
From: David Kent 

Date: Mon, 3 Aug 2009 13:28:26 
To: 
Subject: Re: Error 500 Logging on "New Review Request"


Thanks Jeff, but I believe I've already done that.  To provide a bit more
context, here is where I've looked and what I've tried:
1 - Looked in error.log and access.log of Apache.  I've seen nothing in
error.log and only the following in access.log:

10.52.53.39 - - [03/Aug/2009:12:56:13 -0500] "GET /r/new/ HTTP/1.1" 500 526

2 - Enabled application logging in ReviewBoard using the option in the admin
section under Settings -> Logging  and pointed it to log in
C:\ReviewBoard\logs.  After doing this I only see the following in the
logfile:

2009-08-03 12:01:32,937 - INFO - Logging
to C:\ReviewBoard\logs\reviewboard.log with a minimum level of DEBUG
2009-08-03 12:01:32,937 - INFO - Log file for Review Board v1.0

3.  I've tried logging with and without code profiling.  Neither seems to do
anything.

-David

On Mon, Aug 3, 2009 at 1:13 PM, Jeff Andros  wrote:

> I don't remember exactly how to set I up, but there's an additional logging
> switch in reviewboard, I don't know if it'll help, but I know christian has
> mentioned it a few times. You can check the list archive for how to set
> this, or christian normally responds about 1pm PDT.
>
> Hth,
> --Original Message--
> From: David Kent
> Sender: reviewboard@googlegroups.com
> To: reviewboard
> ReplyTo: reviewboard@googlegroups.com
> Subject: Error 500 Logging on "New Review Request"
> Sent: Aug 3, 2009 11:03 AM
>
>
> I've just installed ReviewBoard and after i set up a repository
> (subversion) and attempt to create a New Review Request it gives me
> the Error 500 page.  I can't find *any* logging of what happened.
> Does anyone have ideas for how I can at least get logging
> information?  I'm totally blind as to what the problem is without some
> sort of log.
>
> -David
>
>
>
>
> --Jeff
> >
>




--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Error 500 Logging on "New Review Request"

[Jeff Andros]

I don't remember exactly how to set I up, but there's an additional logging 
switch in reviewboard, I don't know if it'll help, but I know christian has 
mentioned it a few times. You can check the list archive for how to set this, 
or christian normally responds about 1pm PDT.

Hth,
--Original Message--
From: David Kent
Sender: reviewboard@googlegroups.com
To: reviewboard
ReplyTo: reviewboard@googlegroups.com
Subject: Error 500 Logging on "New Review Request"
Sent: Aug 3, 2009 11:03 AM


I've just installed ReviewBoard and after i set up a repository
(subversion) and attempt to create a New Review Request it gives me
the Error 500 page.  I can't find *any* logging of what happened.
Does anyone have ideas for how I can at least get logging
information?  I'm totally blind as to what the problem is without some
sort of log.

-David




--Jeff
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: backup and restore SQLite DB

[Jeff Andros]

It's not just the file, the folder it resides in as well. That should be a 7 
for the user that the web server runs under
--Jeff

-Original Message-
From: Pravin Nadarajoo 

Date: Thu, 16 Jul 2009 19:04:30 
To: reviewboard
Subject: Re: backup and restore SQLite DB



Thanks for your reply Jeff. I left the permissions of the DB file as
644. Will just try 777 for now and see what happens. Will write here
again.

Thanks
Pravin

On Jul 17, 2:21 am, Jeff Andros  wrote:
> not to be a pain, but does the web user also have write access to the
> directory that the SQLite file resides in? it needs to create a couple of
> temp files in that directory for indices and such.
>
> --Jeff
>
> 2009/7/16 Pravin Nadarajoo 
>
>
>
>
>
> > Hi there,
>
> > I've just installed the new stable release of ReviewBoard (ver 1.0) on
> > a new machine and i'm trying to move my Sqlite DB (.db) from an old
> > one with ReviewBoard (rc2) to the new machine. From your site, I
> > learnt that all I need to do is point ReviewBoard to the location of
> > the old DB file and it should work. But i'm getting thrown with an
> > "Internal Server Error", even after changing the ownership of it to
> > the web user.
>
> > Is there a proper way in which i can backup my SQLite DB from the old
> > ReviewBoard (old machine) and then properly restore it to my new
> > machine's ReviewBoard? Please point me in the right direction.
>
> > Thanks
>
> > Truly
> > Pravin
>
> --
> Jeff
> O|||O



--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: backup and restore SQLite DB

[Jeff Andros]

not to be a pain, but does the web user also have write access to the
directory that the SQLite file resides in? it needs to create a couple of
temp files in that directory for indices and such.

--Jeff

2009/7/16 Pravin Nadarajoo 

>
> Hi there,
>
> I've just installed the new stable release of ReviewBoard (ver 1.0) on
> a new machine and i'm trying to move my Sqlite DB (.db) from an old
> one with ReviewBoard (rc2) to the new machine. From your site, I
> learnt that all I need to do is point ReviewBoard to the location of
> the old DB file and it should work. But i'm getting thrown with an
> "Internal Server Error", even after changing the ownership of it to
> the web user.
>
> Is there a proper way in which i can backup my SQLite DB from the old
> ReviewBoard (old machine) and then properly restore it to my new
> machine's ReviewBoard? Please point me in the right direction.
>
> Thanks
>
> Truly
> Pravin
>
> >
>


-- 
Jeff
O|||O

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: HTTPS certificate not accepted

[Jeff Andros]

In linux, under apache, "ps -A|grep apache" should give you that info... It'll 
ba your apache user.

--Jeff
--Jeff

-Original Message-
From: Daniel 

Date: Mon, 13 Jul 2009 06:11:31 
To: reviewboard
Subject: Re: HTTPS certificate not accepted



Tim or Christian,

Do you know how where I can find the user name with which RB is
running as? What config file? I assume this is different than the user
name that is used to log into RB.

Currently, I have a different error:
HTTPS certificate not accepted. Please ensure that the proper
certificate exists in ~/.subversion/auth for the user that reviewboard
is running as.

So may be I can change this user name to my login user name, which can
access my SVN server.

Thanks
Daniel

On Jul 12, 9:21 pm, Tim Potter  wrote:
> 2009/7/10 Daniel 
>
>
>
> > Christian,
>
> > Thank you for your reply.
>
> > The 1st option is not possible for us, since the SVN repository is
> > controlled by Collabnet.
>
> Not sure what you exact collabnet setup is, but if you can create a new
> certificate that collabnet can access and grant it the Observer fold you can
> run reviewboard quite nicely.
>
> Add some extra lines to the .subversion/servers file in the home directory
> like this:
>
> [groups]
> csd200a = *.csd200a.com
>
> [csd200a]
> ssl-client-cert-file = /var/www/.subversion/cert.p12
> ssl-client-cert-password = password
>
> [global]
> http-proxy-host = proxy.whatever.com
> http-proxy-port = 8080
>
> This is on Linux - I have no idea about the details of Windows or the H:\
> drive problem sorry.
>
> For the 2nd option, can you please tell me how to use my user name to
>
> > access the SVN server (thru https)?
>
> If you export a copy of your certificate and point to it in your servers
> file it should work.  The only problem is you need to either leave it
> unencrypted or specify the password in the servers file.  Both are pretty
> bad ideas in general.  Having a special reviewboard specific certificate
> with read-only access is slightly better.
>
> Regards,
>
> Tim.
>
>
>
>
>
> > Thanks
> > Daniel
>
> > On Jun 29, 5:21 pm, Christian Hammond  wrote:
> > > Hi Daniel,
>
> > > From what I've seen, it seems tricky to get this to work right through
> > > Apache. What I'd strongly recommend, if possible, is to set a plain http
> > > repository for the path and use the https repository for the mirror path.
> > > The idea being that Review Board would just simply fetch the files from
> > the
> > > http repository and the mirror path would be what Review Board checks
> > when
> > > developers are posting changes for review.
>
> > > If you can't do this, then I think what you need to do is attempt to
> > access
> > > the server through https using your user and then move your .subversion
> > > directory into wherever Apache is trying to find it. You can probably set
> > an
> > > environment variable in the Apache configuration file (using SetEnv) to
> > > change this path.
>
> > > I'd like to make this easier in 1.1 or so. I know it's bitten a lot of
> > > people.
>
> > > Christian
>
> > > --
> > > Christian Hammond - chip...@chipx86.com
> > > Review Board -http://www.review-board.org
> > > VMware, Inc. -http://www.vmware.com
>
> > > On Mon, Jun 29, 2009 at 1:34 PM, Daniel  wrote:
>
> > > > Hi,
>
> > > > I am new to ReviewBoard 1.0 and trying to configure RB with SVN. I got
> > > > RB installed but when I try to create a new Review Request, it comes
> > > > back with an error:
>
> > > > "HTTPS certificate not accepted. Please ensure that the proper
> > > > certificate exists in H:\ /.subversion/auth for the user that
> > > > reviewboard is running as."
>
> > > > I don't have any idea why it is looking for a certificate on H:\. On
> > > > my system there is an environment variable HOMEDRIVE which is set to H:
> > > > \. I read somewhere that this might be caused by Apache home directory
> > > > points to a wrong place, but not sure where I can change this. I am
> > > > able to do all SVN operations outside ReviewBoard
>
> > > > Any clue?
>
> > > > Thanks
> > > > Daniel


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: IDE integration

[Jeff Andros]

I've heard some about this from my guys too. Eclipse integration was on the 
gsoc list, but I never heard which projects the students wound up doing. I'm 
not sure there's any work done on it yet.

--Jeff
--Original Message--
From: nap4110
Sender: reviewboard@googlegroups.com
To: reviewboard
ReplyTo: reviewboard@googlegroups.com
Subject: IDE integration
Sent: Jul 12, 2009 2:24 PM


Hi,
I am new to the reviewboard community.  I noticed that there has been
some talk about tighter integration between reviewboard and IDE such
as Eclipse, Intellij and Visual Studio.  My company has expressed
interest in assisting the open source community with development of
this feature.  Where do we get started?  Has anyone else in the
community started any work at the design or implementation level?


Thanks,
Neil




--Jeff
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: What functionality does the Subversion repo connection provide in RB?

[Jeff Andros]

Reviewboard displays the files in a two column view.  It pulls the base file
from the repo, displays that on the left column, applies the diff, then
displays the results on the right column.  This way you've got the entire
file to look over as you're reviewing it, not just the parts that have
changed.

2009/7/1 Eric P 

>
> Ok, this probably sounds like a stupid question, but I'm curious what
> functionality the connection to the repository brings to RB
> (Subversion in my example).
>
> When I create a diff for a review (on the command line via 'svn
> diff'), and then upload the diff, RB appears to make a check against
> the repo for some kind of validation.  But beyond that I don't see
> what the repo connection provides in terms of actual functionality;
> the diff already provides all the info necessary for the review (minus
> the base path which we manually enter anyway).
>
> I bet if I was a more seasoned user I wouldn't be asking this.
>
> Thanks for reading,
> Eric P.
>
> >
>


-- 
Jeff
O|||O

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: stuck with install/config

[Jeff Andros]

You sound pretty new to debian style apache management, so here goes.

Yeah, you'll either need to shut off the default site, or configure reviewboard 
as a vhost.  Shutting off default is probably the easiest.  You shouldn't have 
to remove it, there's a management script that will do that for you, a2dissite 
or something like that (sorry, not set up to check the actual name from my 
blackberry). There's that command's twin, a2ensite, that will turn on 
reviewboard if you drop the config file in the /etc/apache2/sites-available 
directory (again, double check that path as I'm working from memory).  

This is debian's apache management system, it's pretty sweet if you dig into 
it.  There should be documentation all over the web if you get really 
interested in learning more.
--Jeff

-Original Message-
From: grimbeaver 

Date: Wed, 1 Jul 2009 06:07:59 
To: reviewboard
Subject: Re: stuck with install/config



Not sure about the apache setup on Ubuntu 8.10.  But on Ubuntu 9.10 I
had to remove the default site file /etc/apache2/sites-enabled/000-
default before the site would load.  Not sure if that will help you
but thought I would throw it out there.

On Jul 1, 7:40 am, Jim Priest  wrote:
> I'm going back through everything this AM - the only thing I can't
> find is this reference in my reviewboard.conf
>
> 
> ...
> SetEvn DJANGO_SETTINGS_MODULE reviewboard.settings
> ...
> 
>
> I've seen that settings file mentioned on other posts - where does
> that file live??
>
> I guess at this point I'm going to just start over and try again from
> scratch and see what happens.
>
> Jim


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: rb-site install - "Review Board is taking a nap"

[Jeff Andros]

I've yet to do an install like that, and someone else may correct me, but
normally that message means that the apache user does not have write access
to bothr the sqlite file and the folder that contains it.

Try tracking that down and changing the permissions/owner.

--Jeff

2009/6/25 Eric P 

>
> Hi (me again),
>
> I have all my dependency issues sorted, and I've installed my first
> Review Board site per the documentation.
>
> When I go to visit the site, I see the 'Review Board is taking a nap'
> dialog box.
>
> In my Apache error_log, I see some errors:
>
> [error] [client 127.0.0.1] mod_python (pid=3617,
> interpreter='reviewboard_reviews_mysite_com', phase='PythonHandler',
> handler='django.core.handlers.modpython'): Application error
> ...
> [error] [client 127.0.0.1] Traceback (most recent call last):
> [Thu Jun 25 09:51:56 2009] [error] [client 127.0.0.1]   File
> "/usr/lib/python2.6/site-packages/mod_python/importer.py", line 1537,
> in HandlerDispatch\ndefault=default_handler, arg=req,
> silent=hlist.silent)
> ...
> [error] [client 127.0.0.1] OperationalError: attempt to write a
> readonly database
>
>
> FYI. Here are the params I used to set up the site.
>
> rb-site install reviews.mysite.com \
> --domain-name=reviews.mysite.com \
> --site-root=/ \
> --media-url=/media \
> --db-type=sqlite3 \
> --cache-type=memcached \
> --cache-info=memcached://localhost:11211/ \
> --web-server-type=apache \
> --python-loader=modpython
>
>
> I'm not sure what to make of those errors.   It looks like there are a
> couple issues.
>
> Anyway, thanks for reading.
> Eric P
>
> >
>


-- 
Jeff
O|||O

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Report application name to Perforce using -zprog?

[Jeff Andros]

I'll check with our CM people on monday, we'll see if they have any problem
with this.

2009/6/13 David Trowbridge 

>
> I don't see any reason why we shouldn't do this. Accountability is a good
> thing.
>
> -David
>
> On Sat, Jun 13, 2009 at 8:41 PM, Paul Scott wrote:
> >
> > Hmm... I don't know about that. I mean, if you really wanted to try and
> stick unique identifiers in your p4 commands so you could track which ones
> were currently pending, I guess you could, but I assume your Perforce
> administrators would get cranky at you. ;) Also, I don't really know how
> feasible that would be for showing progress... I mean, all you get from
> monitor is what processes are still alive, and how long they've been
> running. Maybe I misunderstood where you were going with that.
> >
> > The main purpose of throwing in a -zprog is just to make things a little
> prettier on the Perforce side. It lets you identify your application to the
> server, so logs and monitor output will display that instead of a generic
> "p4" (for post-review) or whatever the p4 python api reports (for Review
> Board). Mostly this is just a way of playing nice in the general Perforce
> environment. Though this might also allow RB admins who also have access to
> Perforce server logs to get a better sense of how they are affecting or
> being affected by Perforce performance. (There may be other ways of
> identifying Review Board in logs depending on your configuration--user, RB
> server IP--though probably not for post-review).
> >
> > This wouldn't be a huge change (just tack that on to p4 commands, and set
> something in the p4python connection object) and I would think the only
> major reason not to do it is if people didn't really want Review Board
> reported as reviewboard or similar in their Perforce logs.
> >
> > -- Paul
> >
> > 
> > From: reviewboard@googlegroups.com [reviewbo...@googlegroups.com] On
> Behalf Of Christian Hammond [chip...@chipx86.com]
> > Sent: Saturday, June 13, 2009 4:32 PM
> > To: reviewboard@googlegroups.com
> > Subject: Re: Report application name to Perforce using -zprog?
> >
> > So this would allow for reporting progress on, say, file fetches from
> Perforce? Something like that would be interesting for displaying progresses
> on rendering diffs, but would be a lot of work. We'd need to find a good use
> case for it and implement things in a way where our code could take
> advantage of this information without requiring (for all the other SCMs).
> >
> > Christian
> >
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board - http://www.review-board.org
> > VMware, Inc. - http://www.vmware.com
> >
> >
> > On Thu, Apr 9, 2009 at 4:35 PM, Paul Scott  psc...@vmware.com>> wrote:
> >
> > Hey Review Boarders,
> >
> > My team uses the -zprog global option with a few major internal
> scripts/applications to help better track usage patterns. (If you're
> unfamiliar with -zprog, you can read about it here:
> http://kb.perforce.com/AdminTasks/SuperuserTasks/UsingTheZpro..erProcesses).
> I was thinking about adding this to our Review Board and post-review.
> How/where I implement this will be a little bit different based on whether
> this is a customization or something I intend to submit as a patch, so I
> wanted to see if this is something folks would like Review Board to do, or
> not like Review Board to do, or what.
> >
> > Thanks,
> > Paul Scott
> >
> >
> >
> >
> >
> >
> > >
> >
>
> >
>


-- 
Jeff
O|||O

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: ReviewBoard General Inquiries

[Jeff Andros]

I'm not really sure why this is an issue, but all uploads to reviewboard are
via diff.  If you use the post-review tool, you never have to
see/touch/smell the diff at all, you just deal with the review, and your
VCS's revision specs.

Even though you're uploading a diff, reviewboard goes out to your VCS, pulls
out the whole file, and hilights the areas which have changed.

I think that answers your question as I understand it; if you're asking
whether you can review existing files(like reviewing your whole codebase),
check the archives of this list... Christian has covered that a few times,
and it's very possible to do with post-review.


-- 
Jeff
O|||O

2009/5/25 Carlo Camerino 

>
> Hi,
>
> i am evaluating several code review software for our company.
> We have this question regarding review board,
>
> one of the barriers of entry for our programmers to use reviewboard is that
> we are not using diffs for code reviews but rather we are using files.
>
> We don't want to be able to upload diffs but rather upload files for
> consumption purposes.
>
> Does review-board support this kind of model?
>
> if not,
> will it support it in the future.
>
> Hopefully ReviewBoard will be able to support it in the future as it
> is such a nice tool.
>
> Also do you support writing a review by email , or adding comments via
> email?
>
> Thanks
>
> Carlo
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Using the demo

[Jeff Andros]

sorry, just hit me just how unhelpful that really was.

There's a command line tool called post-review you can download to
actually produce your uploads.

doc on the tool is here:
http://code.google.com/docreader/#p=reviewboard&s=reviewboard&t=Using_PostReview

the tool can be downloaded out of svn here:
http://reviewboard.googlecode.com/svn/trunk/reviewboard/contrib/tools/

2009/2/17 Jeff Andros :
> diff headers for reviewboard are a bit different... the server needs
> to know not only the path to the file, but also the revision it was
> generated from... that's how it looks up the base code.  as I
> understand it, svn diff might give you the right headers, but I'm not
> sure... we use p4.
>
> 2009/2/17 Anthony Foglia :
>>
>> This might be a stupid question.  I'd like to play around with the
>> demo, and follow a patch through the review process, but I'm having
>> trouble uploading a patch.  My plan was just to add a file, maybe add
>> additional patches to it, etc.
>>
>> My first question: Which repository do I use for demo purposes?  Navi
>> or Review Board SVN?
>>
>> Second: What should my patch contain?  I tried making a patch with a
>> new file, setting the base diff path to /, but I get an "Unable to
>> parse diff revision header" when uploading the diff.  I think this is
>> because my diff was made outside any version control, and the revision
>> header is a timestamp.
>>
>> Do I need to check out the demo's repository first?  If so, where is
>> it?
>>
>> --
>> Anthony Foglia
>> Princeton Consultants
>> >>
>>
>
>
>
> --
> Jeff
> O|||O
>



-- 
Jeff
O|||O

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Using the demo

[Jeff Andros]

diff headers for reviewboard are a bit different... the server needs
to know not only the path to the file, but also the revision it was
generated from... that's how it looks up the base code.  as I
understand it, svn diff might give you the right headers, but I'm not
sure... we use p4.

2009/2/17 Anthony Foglia :
>
> This might be a stupid question.  I'd like to play around with the
> demo, and follow a patch through the review process, but I'm having
> trouble uploading a patch.  My plan was just to add a file, maybe add
> additional patches to it, etc.
>
> My first question: Which repository do I use for demo purposes?  Navi
> or Review Board SVN?
>
> Second: What should my patch contain?  I tried making a patch with a
> new file, setting the base diff path to /, but I get an "Unable to
> parse diff revision header" when uploading the diff.  I think this is
> because my diff was made outside any version control, and the revision
> header is a timestamp.
>
> Do I need to check out the demo's repository first?  If so, where is
> it?
>
> --
> Anthony Foglia
> Princeton Consultants
> >
>



-- 
Jeff
O|||O

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: pre-commit workflow

[Jeff Andros]

it runs on your developer's boxes... here's documentation:
http://code.google.com/docreader/#p=reviewboard&s=reviewboard&t=Using_PostReview

I guess you could run it on a box with SSH, but that seems overkill



2009/2/13 Brot :
>
> Is there any documentation for this post-review script?
> Where should this script run? In my case we are using a linux server
> for review-board and have windows-client where we are working on our
> code (svn working base is on windows). Does this script fit into this
> environment?
> Do I have the possibility to connect via ssh and work with the post-
> review script?
>
> Another alternative could be a REST webservice for review-board to
> upload new reviews?!
>
> ~ Bernd
>
>
> On 12 Feb., 18:26, Jeff Andros  wrote:
>> 2009/2/12 Brot 
>>
>>
>>
>> > Hello,
>>
>> > today I installed Reviewboard and now I have a few questions.
>>
>> > 1)
>> > Is there a possibility to create reviews from the command-line or in
>> > scripts? It's not really handy to upload the diff-file for every
>> > review. The manual way wouldn't get acceptance and the developers will
>> > not use reviews.
>>
>> Yup! there's a script called post-review... I think for now you have to get
>> it from SVN, but Christian is working on packaging this for easy_install
>>
>>
>>
>> > 2)
>> > If a developer accepts an review, is there a way to commit the
>> > reviewed diff automatically?
>>
>> Not by default... that's a job for your SCM...although the forthcoming
>> extensions might make that possible... or you might be able to use the API
>> to have a daemon search for shipit tags and submit for you
>>
>>
>>
>> > ~ Bernd
>>
>> --
>> Jeff
>> O|||O
> >
>



-- 
Jeff
O|||O

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: pre-commit workflow

[Jeff Andros]

2009/2/12 Brot 

>
> Hello,
>
> today I installed Reviewboard and now I have a few questions.
>
> 1)
> Is there a possibility to create reviews from the command-line or in
> scripts? It's not really handy to upload the diff-file for every
> review. The manual way wouldn't get acceptance and the developers will
> not use reviews.


Yup! there's a script called post-review... I think for now you have to get
it from SVN, but Christian is working on packaging this for easy_install

>
>
> 2)
> If a developer accepts an review, is there a way to commit the
> reviewed diff automatically?
>
Not by default... that's a job for your SCM...although the forthcoming
extensions might make that possible... or you might be able to use the API
to have a daemon search for shipit tags and submit for you

>
>
> ~ Bernd
>
>
>
> >
>


-- 
Jeff
O|||O

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Newbie question: setup problems

[Jeff Andros]

I had this problem too... make sure your web user has permissions not only
on the sqlite file, but on the directory it resides in as well.
Jeff
O|||O


2009/1/8 Chris Clark 

>
> Phil wrote:
> > .Sqlite3 is complaining that it cannot open the database file.
> > (sqlite3.OperationalError: unable to open database file)
> >
> > Has anyone else had this problem? My understanding is that Python 2.5
> > includes sqlite & thus I wouldn't have to install it again -- is this
> > incorrect? Have I missed installing something?
> >
>
> If you are getting the sqlite error, this proves (py) sqlite is
> installed :-)
>
> You _probably_ have a file/path permission problem as sqlite databases
> are files. I suspect when you ran manage you did it as a different user
> than the one who runs the web server.
>
> Chris
>
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Using Server.sh

[Jeff Andros]

server.sh simply calls manage.py.  There's been some discussion of this, and
Christian may need to correct me, but this is a single-threaded webserver.
It's never undergone the optimization that a real web server like apache or
lighttpd has.  Being single threaded, it's going to be slow as all-get-out,
and you don't really want more than one person to run it at a time... kind
of killing the point of reviews.  If you're on ubuntu, it's really easy to
install apache, something like (I'm doing this from memory, and it's been a
while, so it may need some jiggling to get exactly right, but not much):

sudo apt-get install apache2 libapache2-mod-python

then copy apache-modpython.conf.in from the contrib/conf directory in
reviewboard into /etc/apache2/sites-available (I'm not sure, but the new
install process might do this for you)

the last step is to enable your new site:
sudo a2ensite apache-modpython.conf.in
sudo a2dissite default # this is the default site... we don't want it
sudo /etc/init.d/apache2 reload # reload the apache server configuration

HTH

Jeff
O|||O

2009/1/5 carloc 

>
> Hi,
>
> Can I use Server.sh for running reviewboard instead of installing it
> to a web server.
> If so, where do I put the configuration for connecting to a postgresql
> database.
>
> I would like to be able to run reviewboard on an ubuntu box.
>
> Carlo
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Submitted status is not intuitive

[Jeff Andros]

Christian Hammond wrote:

> I agree that Commit is more standard. We can make this change in the 
> public UI, but the API and database will have to remain Submitted. I'm 
> not loving the inconsistency there, but there's not a great solution 
> to that.

How much work would it be to make the UI dynamic... change the wording 
for submit/commit/whatever depending on which VCS you're working with?

It's pretty low priority, but here at Pillar we use Perforce, and my 
team is already a little antsy about the UI changing at all.

--Jeff

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Submitted status is not intuitive

[Jeff Andros]

Depends on which VCS you're using. CVS and SVN (and probably others) use the
term "commit", but P4 at least uses the term "submit". I'm sure there are
others as well.
Jeff
O|||O

Help me and the Leukemia and Lymphoma society fight blood cancers:
http://pages.teamintraining.org/dm/tucson08/jandros


2008/12/30 Arthur Kalmenson 

>
> > My two cents: "Submitted" should be "Committed". To reflect the repo-
> > lingo...
>
> I agree...
>
> --
> Arthur Kalmenson
>
>
>
> On Tue, Dec 30, 2008 at 5:53 AM, Ibmurai  wrote:
> >
> > My two cents: "Submitted" should be "Committed". To reflect the repo-
> > lingo...
> >
> > On 23 Dec., 10:20, "Christian Hammond"  wrote:
> >> We're making this slightly less confusing in the upcoming UI rewrite.
> The
> >> "Set Submitted" link is going away, and instead there will be a "Close"
> >> drop-down with "Discard" and "Submitted." It doesn't entirely eliminate
> the
> >> problem, but it's I think an improvement.
> >>
> >> I'm slowly working on a manual that should make this more clear if
> people
> >> get confused.
> >>
> >> Christian
> >>
> >> --
> >> Christian Hammond - chip...@chipx86.com
> >> VMware, Inc.
> >>
> >>
> >>
> >> On Fri, Dec 19, 2008 at 12:53 PM, morisgi  wrote:
> >>
> >> > On Dec 19, 3:56 pm, "Russell Bryant" 
> wrote:
> >>
> >> > > I believe that most people use the review with a tag of "Ship it" as
> the
> >> > > approval.  The "set submitted" functionality is intended to be used
> by
> >> > the
> >> > > committer of the change after it has been approved and committed, to
> mark
> >> > > the review as completed/closed.
> >>
> >> > > --
> >> > > Russell
> >>
> >> > OK, I understand.
> >> > So may be we should name it approved, committed or completed instead
> >> > of Submitted then.- Skjul tekst i anførselstegn -
> >>
> >> - Vis tekst i anførselstegn -
> > >
> >
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Diff with baseline

[Jeff Andros]

It sounds like he means the perforce baseline concept... meaning the
youngest common ancestor node in the revision tree
Jeff
O|||O

Help me and the Leukemia and Lymphoma society fight blood cancers:
http://pages.teamintraining.org/dm/tucson08/jandros


On Thu, Nov 6, 2008 at 1:17 PM, Christian Hammond <[EMAIL PROTECTED]>wrote:

> I'm confused as to what the problem is. When you say baseline, you mean
> what's in the repository? Just use the "Jump to revision" for that. Clicking
> "View Diff" will take you to the most recent diff, which compares against
> what's in the repository.
>
> If that's not what you mean, can you explain your definition of baseline?
>
> Christian
>
> --
> Christian Hammond - [EMAIL PROTECTED]
> VMware, Inc.
>
>
>
> On Thu, Nov 6, 2008 at 8:45 AM, Geoffrey <[EMAIL PROTECTED]> wrote:
>
>>
>> Hi all. I feel it's pretty essential to compare updated diffs with
>> baseline, but I can't find any mentioning of it in this group or the
>> bug tracker.
>>
>> What I mean is this: suppose you have two diffs in a review request.
>> Right now you'll see this in the diff view:
>>
>> Jump to revision: 1 2
>> Changes between r2 and: 1 2
>>
>> If you click 1 and 2 in the second row, you get the interdiff.
>>
>> But what I want to see is the diff between 2 and 1's baseline.
>>
>> Why? Think of the workflow:
>> 1) Developer posted diff 1 to be reviewed.
>> 2) Reviewer noticed a problem.
>> 3) Developer posted diff 2 to address it.
>> 4) Reviewer is ok with the second change, but now s/he wants to see
>> the combined effect: how will baseline change once all the changes are
>> committed?
>>
>> This is more obvious when you have many iterations. In the end you
>> don't care about the interdiffs any more because you have already
>> worked through them. You want to check the total diff between baseline
>> and last revision for a final review.
>>
>> I think it makes sense to change the diff view to only one line:
>>
>> Changes between: 0 1 2
>>
>> It's more intuitive than the current two-line view, and you can
>> compare arbitrary versions.
>>
>> If this makes sense, how difficult is it to implement?
>>
>> Thanks a lot!
>>
>>
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: diff view - looking to do full file reviews not a diff between two version

[Jeff Andros]

There are two ways to do this:

1. if you manually diff your current file against a file that doesn't exist
(there may be a flag you need to set on your diff program), it will generate
a diff against a new file, then you just need to adjust the diff header to
make it right... we've got a simple script that does this for our perforce
repo

2. I haven't tried it, but there's a revision range argument on
post-review.  Last I knew, this doesn't work for all SCM's, but it should
eventually.  just supply a revision number like 0.  (this has been suggested
before I think)

HTH
Jeff
O|||O

Help me and the Leukemia and Lymphoma society fight blood cancers:
http://pages.teamintraining.org/dm/tucson08/jandros


On Thu, Oct 16, 2008 at 7:59 AM, fts1050 <[EMAIL PROTECTED]> wrote:

>
> In the diff viewer, for new files, only one version of the file is
> show (because only 1 exists). I would like our code reviews to be more
> about reviewing a file in a given state, not simply a diff. Is there
> anyway to create your diff so that the diff viewer will only show a
> single version of the file, as specified by the diff file? This would
> avoid the side by side of the same file, which I am sure is extremely
> useful, but for how we work, is something we'd like to be able to
> bypass if we could.
>
> By the way, this is ideal for reviewers who are looking at the code
> for the first time, who need to review the entire file, not just the
> diff from version X to Y.
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: diff view - looking to do full file reviews not a diff between two version

[Jeff Andros]

It just hit me too, that you can just click the "expand changes" link in the
diff viewer header, there's nothing stopping you from reviewing parts that
didn't change, we do it all the time... just make sure to hit that link,
otherwise the comments that are in old sections won't be displayed

--Christian or Dave--
as an enhancement, how hard would it be to set "auto expand" as either a
user or global setting?

Jeff
O|||O

Help me and the Leukemia and Lymphoma society fight blood cancers:
http://pages.teamintraining.org/dm/tucson08/jandros


On Thu, Oct 16, 2008 at 10:17 AM, Jeff Andros <[EMAIL PROTECTED]> wrote:

> There are two ways to do this:
>
> 1. if you manually diff your current file against a file that doesn't exist
> (there may be a flag you need to set on your diff program), it will generate
> a diff against a new file, then you just need to adjust the diff header to
> make it right... we've got a simple script that does this for our perforce
> repo
>
> 2. I haven't tried it, but there's a revision range argument on
> post-review.  Last I knew, this doesn't work for all SCM's, but it should
> eventually.  just supply a revision number like 0.  (this has been suggested
> before I think)
>
> HTH
> Jeff
> O|||O
>
> Help me and the Leukemia and Lymphoma society fight blood cancers:
> http://pages.teamintraining.org/dm/tucson08/jandros
>
>
>
> On Thu, Oct 16, 2008 at 7:59 AM, fts1050 <[EMAIL PROTECTED]>wrote:
>
>>
>> In the diff viewer, for new files, only one version of the file is
>> show (because only 1 exists). I would like our code reviews to be more
>> about reviewing a file in a given state, not simply a diff. Is there
>> anyway to create your diff so that the diff viewer will only show a
>> single version of the file, as specified by the diff file? This would
>> avoid the side by side of the same file, which I am sure is extremely
>> useful, but for how we work, is something we'd like to be able to
>> bypass if we could.
>>
>> By the way, this is ideal for reviewers who are looking at the code
>> for the first time, who need to review the entire file, not just the
>> diff from version X to Y.
>> >>
>>
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Important: Who's running directly out of an SVN checkout?

[Jeff Andros]

yeah, I hadn't seen a reason to update, and had heard some issues with
updating django, so I'm still running svn #1390
Jeff
O|||O

Help me and the Leukemia and Lymphoma society fight blood cancers:
http://pages.teamintraining.org/dm/tucson08/jandros


On Wed, Oct 15, 2008 at 6:58 AM, Florian Föbel
<[EMAIL PROTECTED]>wrote:

> Hi,
>
> I'm still using reviewboard directly via SVN checkout as I did not see
> argument for changing that, yet. So if you make those changes it would be
> nice to have a short transition howto.
>
> Regards,
> Florian
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Facing error while revieboard installation

[Jeff Andros]

shouldn't the DATABASE_NAME be a path?  have you tried it with the absolute
path to your database file?
Jeff
O|||O

Help me and the Leukemia and Lymphoma society fight blood cancers:
http://pages.teamintraining.org/dm/tucson08/jandros


On Mon, Sep 22, 2008 at 8:52 PM, Atul Phalke <[EMAIL PROTECTED]>wrote:

> It's sqlite3.
>
> DATABASE_ENGINE = 'sqlite3'  # 'postgresql', 'mysql', 'sqlite3' or
> 'ado_mssql'.
> DATABASE_NAME = 'reviewboard.sqlite'  # Or path to database file if using
> sqlite3.
> DATABASE_USER = '' # Not used with sqlite3.
> DATABASE_PASSWORD = '' # Not used with sqlite3.
> DATABASE_HOST = '' # Set to empty string for localhost.
> DATABASE_PORT = '' # Set to empty string for default.
>
>
>
> On Tue, Sep 23, 2008 at 3:26 AM, Christian Hammond <[EMAIL PROTECTED]>wrote:
>
>> What's DATABASE_ENGINE set to in settings_local.py?
>>
>> Christian
>>
>> --
>> Christian Hammond - [EMAIL PROTECTED]
>> VMware, Inc.
>>
>>
>> On Mon, Sep 22, 2008 at 3:42 AM, Atul Phalke <[EMAIL PROTECTED]
>> > wrote:
>>
>>> Hi,
>>>Can anybody help me resolve following issue. I am using
>>> Revieboard - trunk
>>> Django - 1.0
>>> Sqlite 3.3
>>>
>>> If I run ./manage.py syncdb, I get following error
>>>
>>>
>>> [EMAIL PROTECTED] reviewboard]# ./manage.py syncdb
>>> Traceback (most recent call last):
>>>   File "./manage.py", line 144, in 
>>> fix_django_evolution_issues()
>>>   File "./manage.py", line 128, in fix_django_evolution_issues
>>> import django.db.models.fields as model_fields
>>>   File "/usr/lib/python2.5/site-packages/django/db/__init__.py", line 24,
>>> in 
>>> backend = __import__('%s.base' % settings.DATABASE_ENGINE, {}, {},
>>> [''])
>>> ImportError: No module named base
>>> [EMAIL PROTECTED] reviewboard]#
>>>
>>> It seems like some database related issue.
>>>
>>> Any response would be appreciated.
>>> Thanks in advance,
>>> Atul Balwant Phalke.
>>>
>>>
>>>
>>>
>>> On Mon, Sep 15, 2008 at 5:57 PM, Atul Phalke <
>>> [EMAIL PROTECTED]> wrote:
>>>
 Hey Christian,
 Sorry for delay in response. I am using reviewboard code from trunk
 and django version 1.0. Any response would be appreciated.
 Thanks,
 Atul.




 On Fri, Sep 5, 2008 at 4:20 PM, Christian Hammond <[EMAIL PROTECTED]>wrote:

> Review Board hasn't worked with 0.96 in over a year. Actually, I'm not
> sure it ever worked with 0.96. What version of Django are you using now? 
> And
> what revision of Review Board?
>
> Christian
>
> --
> Christian Hammond - [EMAIL PROTECTED]
> VMware, Inc.
>
>
>
> On Fri, Sep 5, 2008 at 2:56 AM, Atul Phalke <
> [EMAIL PROTECTED]> wrote:
>
>> Hi Team,
>>I am getting following error if I run command './manage.py syncdb'
>> Traceback (most recent call last):
>>   File "./manage.py", line 164, in 
>> fix_django_evolution_issues()
>>   File "./manage.py", line 132, in fix_django_evolution_issues
>> import django.db.models.fields.files as model_files
>>   File
>> "/usr/lib/python2.5/site-packages/django/db/models/fields/files.py", 
>> line 7,
>> in 
>> from django.core.files.storage import default_storage
>>   File
>> "/usr/lib/python2.5/site-packages/django/core/files/storage.py", line 
>> 223,
>> in 
>> DefaultStorage = get_storage_class(settings.DEFAULT_FILE_STORAGE)
>>   File "/usr/lib/python2.5/site-packages/django/conf/__init__.py",
>> line 32, in __getattr__
>> return getattr(self._target, name)
>> AttributeError: 'Settings' object has no attribute
>> 'DEFAULT_FILE_STORAGE'
>>
>> Earlier I was using django 0.96 version, that time I didn't face this
>> issue. Now I am facing this problem, sqlite and other required things are
>> installed. Any help would be appreciated.
>>
>> Thanks in advance.
>> Regards,
>> Atul Balwant Phalke.
>>
>>
>>
>
>
>

>>>
>>>
>>>
>>
>>
>>
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Perforce Security

[Jeff Andros]

it's not a pretty solution, but what about setting up multiple reviewboard
instances, with different user credentials in each (one for each project
you've got) then you only create accounts on the servers that theyr'e
supposed to have access to.
Jeff
O|||O

Help me and the Leukemia and Lymphoma society fight blood cancers:
http://pages.teamintraining.org/dm/tucson08/jandros


On Fri, Sep 19, 2008 at 4:30 PM, Daniel Wexler <[EMAIL PROTECTED]> wrote:

>
> I see an older discussion about the issue of Perforce security and the
> need to put the P4 user and client information into the server:
>
> http://groups.google.com/group/reviewboard/browse_thread/thread/d057cc0c05d51e1f
>
> Any update on this situation?
>
> My company is similarly concerned about this security issue and would
> like a way of passing through the user's perforce credentials.  Is
> anyone actively working on this issue?
>
> We have a large company and have many internal security groups.  There
> have been issues in the past with "server" accounts that make the IT
> department hesitant to set up a special Perforce account for the
> server.
>
> Can someone explain why the server needs Perforce access in the first
> place?  Why not just upload the required information as part of the
> user-side post-review script?
>
> BTW, I did install Windows NTLM authentication on my server using
> mod_auth_sspi with no issues so far, which provides a modicum of
> security.
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---