Which version of Ubuntu is supported for latest 1.7.12 ReviewBoard release?
Chris, We are considering Ubuntu installation for latest upgrade to 1.7.12 ReviewBoard release. Which Ubuntu version installation is supported for ReviewBoard? Thanks a lot Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Several ReviewBoard Issues which needs resolution
Thanks for your reply. Very helpful !!! On Friday, January 4, 2013 11:57:16 AM UTC-8, Kunjal wrote: > > Hello, > > We have setup ReviewBoard integration with Perforce and most parts it is > working ok. (using version 1.6.3) > > We have few issues/enhancement requests: > > a. If the file size in pending CL exceed 500K around, then > ReviewBoard can’t handle it; > > b. Current general template is used for all projects, could we > specify something special for the specified projects? Such as, > >i. We > don’t want the submitters can “ship it” themselves. > > ii. Add > “MUST” reviewers for special rules check… (Eg. The review people list order > is not as that who has submitted. We’d better keep the same order) > > > Let me know if above is possible? Also, Is it possible that we can write > the code our self or is it the case that code must be written with in RB > open source team? > > Thanks > > Kunjal > > > > > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Several ReviewBoard Issues which needs resolution
Hello, We have setup ReviewBoard integration with Perforce and most parts it is working ok. (using version 1.6.3) We have few issues/enhancement requests: a. If the file size in pending CL exceed 500K around, then ReviewBoard can’t handle it; b. Current general template is used for all projects, could we specify something special for the specified projects? Such as, i. We don’t want the submitters can “ship it” themselves. ii. Add “MUST” reviewers for special rules check… (Eg. The review people list order is not as that who has submitted. We’d better keep the same order) Let me know if above is possible? Also, Is it possible that we can write the code our self or is it the case that code must be written with in RB open source team? Thanks Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to add comments at each diff section
Thanks... You solved my problem On Friday, June 15, 2012 5:25:52 PM UTC-7, Christian Hammond wrote: > > Hi, > > Hmm, either I'm misunderstanding, or you guys aren't using commenting > properly. > > You should be able to click and drag line numbers in the diff viewer to > select a comment range. You'll get a comment box where you can type your > comment. When you've added every comment you need, publish the review. You > shouldn't have to write your comments on the review page. > > Christian > > > > On Jun 15, 2012, at 14:50, Kunjal wrote: > > Chris, > > Hello, and how are you? > > We are using RB for large scale development and mostly for each review we > have number of diffs to review. > The way the comments addition works, there is no way to add comment right > at the diff so we the reviewer know which lines of code needs attention. > The comment section is entirely different from view diff section so one > has to remember all the diff comments and come back to comments page and > input all the comments. > Do you plan solution to this issue in one of the next releases? > > Thanks > Kunjal > Broadcom Inc. > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
How to add comments at each diff section
Chris, Hello, and how are you? We are using RB for large scale development and mostly for each review we have number of diffs to review. The way the comments addition works, there is no way to add comment right at the diff so we the reviewer know which lines of code needs attention. The comment section is entirely different from view diff section so one has to remember all the diff comments and come back to comments page and input all the comments. Do you plan solution to this issue in one of the next releases? Thanks Kunjal Broadcom Inc. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to handle binary files in a review?
It looks like that we have RBTools-0.2rc1 version installed. Is there a better way to check RB Tool version? On May 23, 10:46 pm, "Ashithraj Shetty" wrote: > Hi, > > I would like to ask for two feature requests, > > 1. Currently a developer can close his review request even though all the > reviewers have not given a SHIP IT! Approval to his review request. Can you > add a feature to block the developer from closing a review request till all > the reviewers have marked the request as SHIP IT!. Would be cool if the > reviewers also cannot close the review request till all the reviewers have > marked a request as SHIP IT! > > 2. The SHIP IT! Column just shows the number of ship it counts. Can you also > add a feature to show the count in the following way, 1 out of 4 where 1 is > the SHIP IT! Count and 4 is the number of reviewers for the review request. > This will help the auditors or the developers to know the status of review > requests in a glance and take necessary measures based on the data. > > -Ashith > > > > -Original Message- > From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On > > Behalf Of Christian Hammond > Sent: Tuesday, May 24, 2011 11:11 AM > To: reviewboard@googlegroups.com > Subject: Re: How to handle binary files in a review? > > I recognize that error, but thought we had fixed that before. What > version of RBTools are you running? > > Christian > > On Monday, May 23, 2011, mohak patel wrote: > > Hi Christian, > > > We have been using Perfoce as the source control tool; review board > > for the code review but review board throws error when developers post > > the binary files. > > > We got this kind of error: > > > This tool looks at the given Pending-CL# & posts it for review. > > [ Version: 20100217_1023/0.8] > > Arguments: --p4vgui,--p4-client,user_Citrix_CDBnew,--p4-cl,358296,-d > > > post-review config: C:\ \Local Settings\Application Data > > \.reviewboardrc > > post-review cookie: C:\ \Application Data\.post-review- > > cookies.txt > > >>>> "C:/Program Files/WinExePostReview/diff.exe" –urNp temp.spd > > > Traceback (most recent call last): > > File "post-review.py", line 2674, in > > File "post-review.py", line 2638, in main > > File "post-review.py", line 1403, in diff > > File "post-review.py", line 1654, in _changenum_diff > > File "post-review.py", line 1737, in _do_diff > > IndexError: list index out of range > > > Could you please help on this issue? > > > Thanks, > > Mohak Patel > > > On May 16, 2:10 pm, Christian Hammond wrote: > >> You shouldn't be getting an error. If the SCM is configured correctly, > with > >> the file type being set to binary, then the diff should just basically > say > >> "This is a binary file." The problem of course is that you can't actually > >> review that file, but we're adding support for actual reviewable file > >> attachments in 1.6, so that might help in some cases. > > >> What type of file is this? And what type of repository? > > >> Christian > > >> -- > >> Christian Hammond - chip...@chipx86.com > >> Review Board -http://www.reviewboard.org > >> VMware, Inc. -http://www.vmware.com > > >> On Mon, May 16, 2011 at 2:07 PM, Kunjal wrote: > >> > Hello, > > >> > We have RB-GIT integration and there are many times when the developer > >> > adds binary files with the review. > >> > When user tries to post review with binary file, we get error and > >> > review can not be posted. > >> > What is the best way to overcome this problem? > > >> > Thanks > >> > Kunjal > > >> > -- > >> > Want to help the Review Board project? Donate today at > >> >http://www.reviewboard.org/donate/ > >> > Happy user? Let us know athttp://www.reviewboard.org/users/ > >> > -~--~~~~--~~--~--~--- > >> > To unsubscribe from this group, send email to > >> > reviewboard+unsubscr...@googlegroups.com > >> > For more options, visit this group at > >> >http://groups.google.com/group/reviewboard?hl=en > > > -- > > Want to help the Review Board project? Donate today > > athttp://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from
How to handle binary files in a review?
Hello, We have RB-GIT integration and there are many times when the developer adds binary files with the review. When user tries to post review with binary file, we get error and review can not be posted. What is the best way to overcome this problem? Thanks Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard with GIT
So..should I create clone on the server OR should I use CGIT? Which one is MOST easy. I am hold up on this issue almost 8 months now..Any help is greatly appreciated. Also, can some one answer how to use CGIT here? For example: If I have repository in CGIT as http://mobcom-git.sj.broadcom.com/cgi-bin/cgit.cgi/git_repos/repo_kernel/prebuilt.git/ and I put this path in MIRROR PATH then will it work? Thanks Kunjal On Jun 18, 10:00 am, Dan Savilonis wrote: > On Jun 16, 6:58 pm, Kunjal wrote: > > > Now I get the point.. > > > But If keep clone on the server, I need to keep the clone in-sync with > > every commit happening in developers workspace. Is that correct? > > No. This is where the parent branch comes in. There are two > possiblities: the developer wants to review code based off a revision > that exists in the central repository, or the developer wants to > review code based off a local revision (which in turn is based off of > the central repository at some point). For the first case, post-review > simply submits the diff and the file blobs in the diff already exist > on the server. In the second case the review diff references files > that are *not* in the repository, so a corresponding "parent diff" is > required to specify the differences between the base revision in the > central repository and the base revision upon which the review is > based. > > > We already have CGIT configured. How I can re-sue CGIT here? > > > Should I say PATH > > ashttp://mobcom-git.sj.broadcom.com/cgi-bin/cgit.cgi/git_repos/repo_too... > > and will it work? > > > Thanks for your great help.. > > > Kunjal > > Dan > > > > > On Jun 16, 11:46 am, Christian Hammond wrote: > > > > It's a clone of the repository on the Review Board server itself. Path > > > points to that clone, and Mirror Path would be the remote origin that the > > > other developers are using for the central repository. Think of Path as > > > being what Review Board actually uses for fetching files, and Mirror Path > > > as > > > just being an alias that is matched against for the central server. > > > > Using a local clone is not great, though, unless Review Board is running > > > on > > > the same server as the central Git repository (or has that server > > > mounted). > > > You really should use something like cgit/gitweb and then the raw file URL > > > mask field. It's easier to maintain and more scalable. > > > > Christian > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > On Wed, Jun 16, 2010 at 9:57 AM, Kunjal wrote: > > > > Chris, > > > > > I do not understand how GIT can be supported for 300+ users if the > > > > Path field is the full path of the .git directory inside the > > > > checkout. > > > > How would we know the checkout directory for each and every developer? > > > > and how it is possible to use the same PATH variable for N number of > > > > users? > > > > It looks like I am missing somehting here. > > > > > Please elobarate... > > > > > Thanks for your time > > > > > Kunjal > > > > > The Path field should be the full path of the .git directory inside > > > > this checkout. > > > > > On Jun 15, 10:53 pm, Jan Koprowski wrote: > > > > > This looks like Christain said - git can't find repo. Read this: > > > >http://www.reviewboard.org/docs/manual/dev/admin/management/repositor... > > > > > to know how get patches for Git to enter. > > > > > > On Jun 16, 1:06 am, Christian Hammond wrote: > > > > > > > Git only works with local file paths on the Review Board server, > > > > > > unless > > > > you > > > > > > have the Raw URL field set. For that, you need a web-based Git > > > > > > viewer > > > > such > > > > > > as cgit or gitweb. See the Raw File URL Mask section athttp:// > > > >www.reviewboard.org/docs/manual/dev/admin/management/repositor... > > > > > > > Basically, Git has no way to fetch a remote file with a given > > > > > > revision > > > > from > > > > > > a server, requiring instead local clones. However, our Raw File URL > > > > mask, if > > > > > > set correctly, allows us to fetch the file from a web service that >
Re: ReviewBoard with GIT
The below two lines confuse me... For cgit, this path should be in the form of: http://servername/browse/gtk+/plain/?id2= For example: http://git.gnome.org/browse/gtk+/plain/?id2= wrote: > Here is some informations about cgit > configuration:http://www.reviewboard.org/docs/manual/dev/admin/management/repositor... > > On Jun 17, 12:58 am, Kunjal wrote: > > > > > Now I get the point.. > > > But If keep clone on the server, I need to keep the clone in-sync with > > every commit happening in developers workspace. Is that correct? > > > We already have CGIT configured. How I can re-sue CGIT here? > > > Should I say PATH > > ashttp://mobcom-git.sj.broadcom.com/cgi-bin/cgit.cgi/git_repos/repo_too... > > and will it work? > > > Thanks for your great help.. > > > Kunjal > > > On Jun 16, 11:46 am, Christian Hammond wrote: > > > > It's a clone of the repository on the Review Board server itself. Path > > > points to that clone, and Mirror Path would be the remote origin that the > > > other developers are using for the central repository. Think of Path as > > > being what Review Board actually uses for fetching files, and Mirror Path > > > as > > > just being an alias that is matched against for the central server. > > > > Using a local clone is not great, though, unless Review Board is running > > > on > > > the same server as the central Git repository (or has that server > > > mounted). > > > You really should use something like cgit/gitweb and then the raw file URL > > > mask field. It's easier to maintain and more scalable. > > > > Christian > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > On Wed, Jun 16, 2010 at 9:57 AM, Kunjal wrote: > > > > Chris, > > > > > I do not understand how GIT can be supported for 300+ users if the > > > > Path field is the full path of the .git directory inside the > > > > checkout. > > > > How would we know the checkout directory for each and every developer? > > > > and how it is possible to use the same PATH variable for N number of > > > > users? > > > > It looks like I am missing somehting here. > > > > > Please elobarate... > > > > > Thanks for your time > > > > > Kunjal > > > > > The Path field should be the full path of the .git directory inside > > > > this checkout. > > > > > On Jun 15, 10:53 pm, Jan Koprowski wrote: > > > > > This looks like Christain said - git can't find repo. Read this: > > > >http://www.reviewboard.org/docs/manual/dev/admin/management/repositor... > > > > > to know how get patches for Git to enter. > > > > > > On Jun 16, 1:06 am, Christian Hammond wrote: > > > > > > > Git only works with local file paths on the Review Board server, > > > > > > unless > > > > you > > > > > > have the Raw URL field set. For that, you need a web-based Git > > > > > > viewer > > > > such > > > > > > as cgit or gitweb. See the Raw File URL Mask section athttp:// > > > >www.reviewboard.org/docs/manual/dev/admin/management/repositor... > > > > > > > Basically, Git has no way to fetch a remote file with a given > > > > > > revision > > > > from > > > > > > a server, requiring instead local clones. However, our Raw File URL > > > > mask, if > > > > > > set correctly, allows us to fetch the file from a web service that > > > > > > is > > > > on the > > > > > > central Git server that has access to all files and revisions. > > > > > > > Christian > > > > > > > -- > > > > > > Christian Hammond - chip...@chipx86.com > > > > > > Review Board -http://www.reviewboard.org > > > > > > VMware, Inc. -http://www.vmware.com > > > > > > > On Tue, Jun 15, 2010 at 3:30 PM, Kunjal > > > > wrote: > > > > > > > Thanks ! > > > > > > > > My path variable is set to git:// > > > > > > > mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git > > > > > > > > My Mirror Path variable is empty. What should be the value in > > > > > > >
Re: ReviewBoard with GIT
Now I get the point.. But If keep clone on the server, I need to keep the clone in-sync with every commit happening in developers workspace. Is that correct? We already have CGIT configured. How I can re-sue CGIT here? Should I say PATH as http://mobcom-git.sj.broadcom.com/cgi-bin/cgit.cgi/git_repos/repo_tools/scripts.git/ and will it work? Thanks for your great help.. Kunjal On Jun 16, 11:46 am, Christian Hammond wrote: > It's a clone of the repository on the Review Board server itself. Path > points to that clone, and Mirror Path would be the remote origin that the > other developers are using for the central repository. Think of Path as > being what Review Board actually uses for fetching files, and Mirror Path as > just being an alias that is matched against for the central server. > > Using a local clone is not great, though, unless Review Board is running on > the same server as the central Git repository (or has that server mounted). > You really should use something like cgit/gitweb and then the raw file URL > mask field. It's easier to maintain and more scalable. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Wed, Jun 16, 2010 at 9:57 AM, Kunjal wrote: > > Chris, > > > I do not understand how GIT can be supported for 300+ users if the > > Path field is the full path of the .git directory inside the > > checkout. > > How would we know the checkout directory for each and every developer? > > and how it is possible to use the same PATH variable for N number of > > users? > > It looks like I am missing somehting here. > > > Please elobarate... > > > Thanks for your time > > > Kunjal > > > The Path field should be the full path of the .git directory inside > > this checkout. > > > On Jun 15, 10:53 pm, Jan Koprowski wrote: > > > This looks like Christain said - git can't find repo. Read this: > >http://www.reviewboard.org/docs/manual/dev/admin/management/repositor... > > > to know how get patches for Git to enter. > > > > On Jun 16, 1:06 am, Christian Hammond wrote: > > > > > Git only works with local file paths on the Review Board server, unless > > you > > > > have the Raw URL field set. For that, you need a web-based Git viewer > > such > > > > as cgit or gitweb. See the Raw File URL Mask section athttp:// > >www.reviewboard.org/docs/manual/dev/admin/management/repositor... > > > > > Basically, Git has no way to fetch a remote file with a given revision > > from > > > > a server, requiring instead local clones. However, our Raw File URL > > mask, if > > > > set correctly, allows us to fetch the file from a web service that is > > on the > > > > central Git server that has access to all files and revisions. > > > > > Christian > > > > > -- > > > > Christian Hammond - chip...@chipx86.com > > > > Review Board -http://www.reviewboard.org > > > > VMware, Inc. -http://www.vmware.com > > > > > On Tue, Jun 15, 2010 at 3:30 PM, Kunjal > > wrote: > > > > > Thanks ! > > > > > > My path variable is set to git:// > > > > > mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git > > > > > > My Mirror Path variable is empty. What should be the value in mirror > > > > > path? > > > > > > On Jun 15, 2:09 pm, Christian Hammond wrote: > > > > > > Hi, > > > > > > > First thing to check is that git is in your path, accessible by > > your web > > > > > > server. > > > > > > > What are you using for your Path and Mirror Path? > > > > > > > Christian > > > > > > > -- > > > > > > Christian Hammond - chip...@chipx86.com > > > > > > Review Board -http://www.reviewboard.org > > > > > > VMware, Inc. -http://www.vmware.com > > > > > > > On Tue, Jun 15, 2010 at 2:05 PM, Kunjal > > wrote: > > > > > > > Hi chris, > > > > > > > > I have reviewborad 1.5Beta 2 configured for GIT. > > > > > > > When I create review request, I get below error. any pointers? > > > > > > > > ImportError at /r/56/ > > > > > > > Request Method: GET > > > > > > > Request URL:http://mob-rb-test.sj.broadcom.com/r/56/ > > > > > > > Exception Type: ImportError &
Re: ReviewBoard with GIT
Chris, I do not understand how GIT can be supported for 300+ users if the Path field is the full path of the .git directory inside the checkout. How would we know the checkout directory for each and every developer? and how it is possible to use the same PATH variable for N number of users? It looks like I am missing somehting here. Please elobarate... Thanks for your time Kunjal The Path field should be the full path of the .git directory inside this checkout. On Jun 15, 10:53 pm, Jan Koprowski wrote: > This looks like Christain said - git can't find repo. Read > this:http://www.reviewboard.org/docs/manual/dev/admin/management/repositor... > to know how get patches for Git to enter. > > On Jun 16, 1:06 am, Christian Hammond wrote: > > > > > Git only works with local file paths on the Review Board server, unless you > > have the Raw URL field set. For that, you need a web-based Git viewer such > > as cgit or gitweb. See the Raw File URL Mask section > > athttp://www.reviewboard.org/docs/manual/dev/admin/management/repositor... > > > Basically, Git has no way to fetch a remote file with a given revision from > > a server, requiring instead local clones. However, our Raw File URL mask, if > > set correctly, allows us to fetch the file from a web service that is on the > > central Git server that has access to all files and revisions. > > > Christian > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.reviewboard.org > > VMware, Inc. -http://www.vmware.com > > > On Tue, Jun 15, 2010 at 3:30 PM, Kunjal wrote: > > > Thanks ! > > > > My path variable is set to git:// > > > mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git > > > > My Mirror Path variable is empty. What should be the value in mirror > > > path? > > > > On Jun 15, 2:09 pm, Christian Hammond wrote: > > > > Hi, > > > > > First thing to check is that git is in your path, accessible by your web > > > > server. > > > > > What are you using for your Path and Mirror Path? > > > > > Christian > > > > > -- > > > > Christian Hammond - chip...@chipx86.com > > > > Review Board -http://www.reviewboard.org > > > > VMware, Inc. -http://www.vmware.com > > > > > On Tue, Jun 15, 2010 at 2:05 PM, Kunjal wrote: > > > > > Hi chris, > > > > > > I have reviewborad 1.5Beta 2 configured for GIT. > > > > > When I create review request, I get below error. any pointers? > > > > > > ImportError at /r/56/ > > > > > Request Method: GET > > > > > Request URL:http://mob-rb-test.sj.broadcom.com/r/56/ > > > > > Exception Type: ImportError > > > > > Exception Value: > > > > > Exception Location: /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/ > > > > > python2.5/site-packages/ReviewBoard-1.5beta2-py2.5.egg/reviewboard/ > > > > > scmtools/git.py in __init__, line 202 > > > > > Python Executable: /opt/lampp/bin/python > > > > > Python Version: 2.5.2 > > > > > Python Path: ['/opt/lampp/htdocs/reviewboard/conf', '/opt/lampp/lib/ > > > > > python2.5/site-packages/django', '/opt/lampp/lib/python2.5/site- > > > > > packages/reviewboard', '/opt/lampp/lib/python2.5/site-packages/ > > > > > MySQL_python-1.2.2-py2.5-linux-i686.egg', '/opt/lampp/lib/python2.5/ > > > > > site-packages/setuptools-0.6c9-py2.5.egg', '/opt/lampp/lib/python2.5/ > > > > > site-packages/pytz-2009l-py2.5.egg', '/opt/lampp/lib/python2.5/site- > > > > > packages/flup-1.0.3.dev_20090716-py2.5.egg', > > > > > '/opt/lampp/lib/python2.5/ > > > > > site-packages/Pygments-1.1.1-py2.5.egg', '/opt/lampp/lib/python2.5/ > > > > > site-packages/django_evolution-0.0.0-py2.5.egg', '/opt/lampp/lib/ > > > > > python2.5/site-packages/PIL-1.1.6-py2.5-linux-i686.egg', '/opt/lampp/ > > > > > lib/python2.5/site-packages/simplejson-2.0.9-py2.5-linux-i686.egg', '/ > > > > > opt/lampp/lib/python2.5/site-packages/python_ldap-2.3.9-py2.5-linux- > > > > > i686.egg', '/opt/lampp/lib/python2.5/site-packages/Django-1.1.1- > > > > > py2.5.egg', '/opt/lampp/lib/python2.5/site-packages/JCC-2.5-py2.5- > > > > > linux-i686.egg', '/opt/lampp/lib/python2.5/site-packages/lucene-3.0.0- > >
Re: ReviewBoard with GIT
Thanks ! My path variable is set to git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git My Mirror Path variable is empty. What should be the value in mirror path? On Jun 15, 2:09 pm, Christian Hammond wrote: > Hi, > > First thing to check is that git is in your path, accessible by your web > server. > > What are you using for your Path and Mirror Path? > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Tue, Jun 15, 2010 at 2:05 PM, Kunjal wrote: > > Hi chris, > > > I have reviewborad 1.5Beta 2 configured for GIT. > > When I create review request, I get below error. any pointers? > > > ImportError at /r/56/ > > Request Method: GET > > Request URL:http://mob-rb-test.sj.broadcom.com/r/56/ > > Exception Type: ImportError > > Exception Value: > > Exception Location: /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/ > > python2.5/site-packages/ReviewBoard-1.5beta2-py2.5.egg/reviewboard/ > > scmtools/git.py in __init__, line 202 > > Python Executable: /opt/lampp/bin/python > > Python Version: 2.5.2 > > Python Path: ['/opt/lampp/htdocs/reviewboard/conf', '/opt/lampp/lib/ > > python2.5/site-packages/django', '/opt/lampp/lib/python2.5/site- > > packages/reviewboard', '/opt/lampp/lib/python2.5/site-packages/ > > MySQL_python-1.2.2-py2.5-linux-i686.egg', '/opt/lampp/lib/python2.5/ > > site-packages/setuptools-0.6c9-py2.5.egg', '/opt/lampp/lib/python2.5/ > > site-packages/pytz-2009l-py2.5.egg', '/opt/lampp/lib/python2.5/site- > > packages/flup-1.0.3.dev_20090716-py2.5.egg', '/opt/lampp/lib/python2.5/ > > site-packages/Pygments-1.1.1-py2.5.egg', '/opt/lampp/lib/python2.5/ > > site-packages/django_evolution-0.0.0-py2.5.egg', '/opt/lampp/lib/ > > python2.5/site-packages/PIL-1.1.6-py2.5-linux-i686.egg', '/opt/lampp/ > > lib/python2.5/site-packages/simplejson-2.0.9-py2.5-linux-i686.egg', '/ > > opt/lampp/lib/python2.5/site-packages/python_ldap-2.3.9-py2.5-linux- > > i686.egg', '/opt/lampp/lib/python2.5/site-packages/Django-1.1.1- > > py2.5.egg', '/opt/lampp/lib/python2.5/site-packages/JCC-2.5-py2.5- > > linux-i686.egg', '/opt/lampp/lib/python2.5/site-packages/lucene-3.0.0- > > py2.5-linux-i686.egg', '/opt/lampp/lib/python2.5/site-packages/ > > RBTools-0.2-py2.5.egg', '/opt/lampp/lib/python2.5/site-packages/ > > ReviewBoard-1.5beta2-py2.5.egg', '/opt/lampp/lib/python2.5/site- > > packages/recaptcha_client-1.0.5-py2.5.egg', '/opt/lampp/lib/python2.5/ > > site-packages/paramiko-1.7.6-py2.5.egg', '/opt/lampp/lib/python2.5/ > > site-packages/pycrypto-2.0.1-py2.5-linux-i686.egg', '/opt/lampp/lib/ > > python2.5/site-packages/Djblets-0.6.2-py2.5.egg', '/opt/lampp/lib/ > > python25.zip', '/opt/lampp/lib/python2.5', '/opt/lampp/lib/python2.5/ > > plat-linux2', '/opt/lampp/lib/python2.5/lib-tk', '/opt/lampp/lib/ > > python2.5/lib-dynload', '/opt/lampp/lib/python2.5/site-packages'] > > Server time: Tue, 15 Jun 2010 14:04:07 -0700 > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
ReviewBoard with GIT
Hi chris, I have reviewborad 1.5Beta 2 configured for GIT. When I create review request, I get below error. any pointers? ImportError at /r/56/ Request Method: GET Request URL: http://mob-rb-test.sj.broadcom.com/r/56/ Exception Type: ImportError Exception Value: Exception Location: /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/ python2.5/site-packages/ReviewBoard-1.5beta2-py2.5.egg/reviewboard/ scmtools/git.py in __init__, line 202 Python Executable: /opt/lampp/bin/python Python Version: 2.5.2 Python Path: ['/opt/lampp/htdocs/reviewboard/conf', '/opt/lampp/lib/ python2.5/site-packages/django', '/opt/lampp/lib/python2.5/site- packages/reviewboard', '/opt/lampp/lib/python2.5/site-packages/ MySQL_python-1.2.2-py2.5-linux-i686.egg', '/opt/lampp/lib/python2.5/ site-packages/setuptools-0.6c9-py2.5.egg', '/opt/lampp/lib/python2.5/ site-packages/pytz-2009l-py2.5.egg', '/opt/lampp/lib/python2.5/site- packages/flup-1.0.3.dev_20090716-py2.5.egg', '/opt/lampp/lib/python2.5/ site-packages/Pygments-1.1.1-py2.5.egg', '/opt/lampp/lib/python2.5/ site-packages/django_evolution-0.0.0-py2.5.egg', '/opt/lampp/lib/ python2.5/site-packages/PIL-1.1.6-py2.5-linux-i686.egg', '/opt/lampp/ lib/python2.5/site-packages/simplejson-2.0.9-py2.5-linux-i686.egg', '/ opt/lampp/lib/python2.5/site-packages/python_ldap-2.3.9-py2.5-linux- i686.egg', '/opt/lampp/lib/python2.5/site-packages/Django-1.1.1- py2.5.egg', '/opt/lampp/lib/python2.5/site-packages/JCC-2.5-py2.5- linux-i686.egg', '/opt/lampp/lib/python2.5/site-packages/lucene-3.0.0- py2.5-linux-i686.egg', '/opt/lampp/lib/python2.5/site-packages/ RBTools-0.2-py2.5.egg', '/opt/lampp/lib/python2.5/site-packages/ ReviewBoard-1.5beta2-py2.5.egg', '/opt/lampp/lib/python2.5/site- packages/recaptcha_client-1.0.5-py2.5.egg', '/opt/lampp/lib/python2.5/ site-packages/paramiko-1.7.6-py2.5.egg', '/opt/lampp/lib/python2.5/ site-packages/pycrypto-2.0.1-py2.5-linux-i686.egg', '/opt/lampp/lib/ python2.5/site-packages/Djblets-0.6.2-py2.5.egg', '/opt/lampp/lib/ python25.zip', '/opt/lampp/lib/python2.5', '/opt/lampp/lib/python2.5/ plat-linux2', '/opt/lampp/lib/python2.5/lib-tk', '/opt/lampp/lib/ python2.5/lib-dynload', '/opt/lampp/lib/python2.5/site-packages'] Server time: Tue, 15 Jun 2010 14:04:07 -0700 -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: AD Settings in RB
Thanks. Is this feature will get supported in near future? On Apr 29, 4:52 am, grimbeaver wrote: > You might be able to do it by setting the group name or a custom > search root in the settings but I'm not real familiar with the AD > scheme. Currently I'm just using the Find DC from DNS option. The > other thing to remember is that a user is not created in reviewboard > until after the user logs in once. This makes assigning privileges > kind of difficult. > > On Apr 29, 2:50 am, Christian Hammond wrote: > > > > > > > Hi, > > > I was hoping someone else would respond to this. AD is a > > contributor-supplied feature, which I have little personal knowledge of. > > > We make use of the Python ldap and DNS modules in order to handle > > authentication. I don't know what is needed to support multiple security > > groups, whether we need to modify code to allow for it or what. I'd love to > > give you a better answer, but this is just outside my area of expertise. I'd > > be fine with providing such support in our ActiveDirectory backend if > > someone with the ability to test this could provide a patch. > > > Christian > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.reviewboard.org > > VMware, Inc. -http://www.vmware.com > > > On Wed, Apr 28, 2010 at 9:43 PM, Kunjal wrote: > > > Can someone please replay as soon as possible? > > > > On Apr 27, 5:42 pm, Kunjal wrote: > > > > We have RB 1.0.5.1 installed. > > > > We have configured AD settings so all the users can login easily. > > > > Now, the issue is that we want to restrict users to only few > > > > departments in our company. > > > > So, we have created new windows security groups which has nested > > > > multiple department names in it. > > > > After doing this, the users of this departments can not access RB. > > > > If we put one department group then it works. But nesting of > > > > departments does not work. > > > > Does the RB 1.0.5.1 has ability to put multiple windows security > > > > groups for access/authentication? Is nesting possible? > > > > > -- > > > > Want to help the Review Board project? Donate today athttp:// > > >www.reviewboard.org/donate/ > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > > -~--~~~~--~~--~--~--- > > > > To unsubscribe from this group, send email to > > > reviewboard+unsubscr...@googlegroups.com > > oups.com> > > > > For more options, visit this group athttp:// > > > groups.google.com/group/reviewboard?hl=en > > > > -- > > > Want to help the Review Board project? Donate today at > > >http://www.reviewboard.org/donate/ > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > -~--~~~~--~~--~--~--- > > > To unsubscribe from this group, send email to > > > reviewboard+unsubscr...@googlegroups.com > > oups.com> > > > For more options, visit this group at > > >http://groups.google.com/group/reviewboard?hl=en > > > -- > > Want to help the Review Board project? Donate today > > athttp://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group > > athttp://groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today > athttp://www.reviewboard.org/donate/ > Happy user? Let us know athttp://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group > athttp://groups.google.com/group/reviewboard?hl=en- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: HTTPS support
What I found is that if I do not change post-review.py script at all,
I can post the review but I can not post the diff.
kapar...@ltsdo-kaparikh ~
$ post-review.cygwin 275221 -d
This tool looks at the given Pending-CL# & posts it for review.
[Version: 200911
13_1141]
>>> Repository info 'Path: pf-sj1-mob.sj.broadcom.com:1668, Base path: None, Sup
ports changesets: True'
>>> Generating diff for changenum 275221
>>> P4CLIENT is LTSDO-KAPARIKH
>>> status is pending
>>> Lines are: ['//depot/Sources/Integration/Automation_Scripts/CCB_CQ_Analysis/
ccb_cq_analysis.pl#5 - edit change 275221 (text) by kapar...@ltsdo-
KAPARIKH\r\n'
]
>>> Client LTSDO-KAPARIKH depot path //depot/Sources/Integration/Automation_Scri
pts/CCB_CQ_Analysis/ccb_cq_analysis.pl
>>> Writing "//depot/Sources/Integration/Automation_Scripts/CCB_CQ_Analysis/ccb_
cq_analysis.pl#5" to "/cygdrive/c/Temp/tmpE2AEBQ"
>>> Old file: /cygdrive/c/Temp/tmpE2AEBQ New file c:/Perforce/sysrel_scripts/CCB
_CQ_Analysis/ccb_cq_analysis.pl
>>> Attempting to create review request for 275221
repository path pf-sj1-mob.sj.broadcom.com:1668
>>> HTTP POSTing to http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/n
ew/: {'repository_path': 'pf-sj1-mob.sj.broadcom.com:1668',
'changenum': '275221
'}
>>> Review request created
>>> --- c:\Perforce\sysrel_scripts\CCB_CQ_Analysis\ccb_cq_analysis.pl //depot/
Sources/Integration/Automation_Scripts/CCB_CQ_Analysis/
ccb_cq_analysis.pl#5
+++ c:\Perforce\sysrel_scripts\CCB_CQ_Analysis
\ccb_cq_analysis.pl 2010-04-
29 09:57:09
@@ -13,7 +13,16 @@ use Win32::OLE::Const 'Microsoft Excel';
$Win32::OLE::Warn = 3; # die on errors...
use Tie::File;
###
-#All Variables declaration
>>> Uploading diff
>>> HTTP POSTing to http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/5
4/diff/new/: {}
Error uploading diff: One or more fields had errors (105)
Your review request still exists, but the diff is not attached.
On Apr 28, 5:11 pm, Christian Hammond wrote:
> It should work with https fine. I use it with https every day. Can you paste
> the output when using --debug with post-review?
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
>
>
> On Wed, Apr 28, 2010 at 4:23 PM, Kunjal wrote:
> > Here is the scenairo happening.
> > We are using post-review.py file to post review.
> > We close down HTTP port and open up HTTPS port.
> > Now, when I post the review, I can not post review at all !!
> > What I ovserve that in post-review.py, there are HTTP post methods are
> > used and
> > methonds like: self.http_post, http_get etc. are used.
>
> > Do we have post-review.py which supports HTTPS?
>
> > Thanks
> > Kunjal
>
> > On Apr 27, 10:59 pm, Christian Hammond wrote:
> > > Review Board doesn't know or care anything about http vs. https. If
> > you're
> > > having issues with post-review, I suspect it's due to your existing
> > > configuration referencing the http URL, which presumably doesn't work
> > now. I
> > > don't know how you have it configured, so it may be post-review.py, or a
> > > .reviewboardrc, or a property on the repository.
>
> > > Christian
>
> > > --
> > > Christian Hammond - chip...@chipx86.com
> > > Review Board -http://www.reviewboard.org
> > > VMware, Inc. -http://www.vmware.com
>
> > > On Tue, Apr 27, 2010 at 10:57 PM, Kunjal
> > wrote:
> > > > Chris,
>
> > > > Changes to Apache installation is done and we have moved our RB
> > > > website to HTTPS.
> > > > However, now when I post the review now, I can not post the diff.
> > > > Does the HTTPS interact the way diff is done ?
> > > > Do I need to update post-review.py script to update the url field to
> > > > point to https?
>
> > > > Thanks a lot.
> > > > Kunjal
>
> > > > On Apr 27, 10:45 pm, Christian Hammond wrote:
> > > > > Do you mean the Apache installation? That should work fine. Review
> > Board
> > > > > doesn't really care whether it's being used with https or http. It's
> > a
> > > > > matter of configuring your Apache installation and updating your
> > > > > .reviewboardrc files (or whatever mechanism you're using for
> > post-review
> > > >
Re: AD Settings in RB
Can someone please replay as soon as possible? On Apr 27, 5:42 pm, Kunjal wrote: > We have RB 1.0.5.1 installed. > We have configured AD settings so all the users can login easily. > Now, the issue is that we want to restrict users to only few > departments in our company. > So, we have created new windows security groups which has nested > multiple department names in it. > After doing this, the users of this departments can not access RB. > If we put one department group then it works. But nesting of > departments does not work. > Does the RB 1.0.5.1 has ability to put multiple windows security > groups for access/authentication? Is nesting possible? > > -- > Want to help the Review Board project? Donate today > athttp://www.reviewboard.org/donate/ > Happy user? Let us know athttp://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group > athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: HTTPS support
Here is the scenairo happening. We are using post-review.py file to post review. We close down HTTP port and open up HTTPS port. Now, when I post the review, I can not post review at all !! What I ovserve that in post-review.py, there are HTTP post methods are used and methonds like: self.http_post, http_get etc. are used. Do we have post-review.py which supports HTTPS? Thanks Kunjal On Apr 27, 10:59 pm, Christian Hammond wrote: > Review Board doesn't know or care anything about http vs. https. If you're > having issues with post-review, I suspect it's due to your existing > configuration referencing the http URL, which presumably doesn't work now. I > don't know how you have it configured, so it may be post-review.py, or a > .reviewboardrc, or a property on the repository. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > > > On Tue, Apr 27, 2010 at 10:57 PM, Kunjal wrote: > > Chris, > > > Changes to Apache installation is done and we have moved our RB > > website to HTTPS. > > However, now when I post the review now, I can not post the diff. > > Does the HTTPS interact the way diff is done ? > > Do I need to update post-review.py script to update the url field to > > point to https? > > > Thanks a lot. > > Kunjal > > > On Apr 27, 10:45 pm, Christian Hammond wrote: > > > Do you mean the Apache installation? That should work fine. Review Board > > > doesn't really care whether it's being used with https or http. It's a > > > matter of configuring your Apache installation and updating your > > > .reviewboardrc files (or whatever mechanism you're using for post-review > > > support) to point to the https URL instead of the http URL. > > > > Christian > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > On Tue, Apr 27, 2010 at 5:38 PM, Kunjal wrote: > > > > We have RB 1.0.5.1 in production and it is http now. > > > > We want to move it to https. > > > > So, we did apache server settings and move RB to https. > > > > But now I can post the review but I can not post the diff. > > > > It gives me error. > > > > Is HTTTPS supported in 1.0.5.1? > > > > > Because I see that in the roadmap of RB 1.5, it says ... > > > > > SSH and HTTPS support -- commited. > > > > > Thanks > > > > Kunjal > > > > > -- > > > > Want to help the Review Board project? Donate today at > > > >http://www.reviewboard.org/donate/ > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > > -~--~~~~--~~--~--~--- > > > > To unsubscribe from this group, send email to > > > > reviewboard+unsubscr...@googlegroups.com > > > > > > For more options, visit this group at > > > >http://groups.google.com/group/reviewboard?hl=en > > > > -- > > > Want to help the Review Board project? Donate today athttp:// > >www.reviewboard.org/donate/ > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > -~--~~~~--~~--~--~--- > > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > > For more options, visit this group athttp:// > > groups.google.com/group/reviewboard?hl=en > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today > athttp://www.reviewboard.org/donate/ > Happy user? Let us know athttp://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group > athttp://groups.google.com/group/reviewboard?hl=en- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: HTTPS support
Chris, Changes to Apache installation is done and we have moved our RB website to HTTPS. However, now when I post the review now, I can not post the diff. Does the HTTPS interact the way diff is done ? Do I need to update post-review.py script to update the url field to point to https? Thanks a lot. Kunjal On Apr 27, 10:45 pm, Christian Hammond wrote: > Do you mean the Apache installation? That should work fine. Review Board > doesn't really care whether it's being used with https or http. It's a > matter of configuring your Apache installation and updating your > .reviewboardrc files (or whatever mechanism you're using for post-review > support) to point to the https URL instead of the http URL. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > > > On Tue, Apr 27, 2010 at 5:38 PM, Kunjal wrote: > > We have RB 1.0.5.1 in production and it is http now. > > We want to move it to https. > > So, we did apache server settings and move RB to https. > > But now I can post the review but I can not post the diff. > > It gives me error. > > Is HTTTPS supported in 1.0.5.1? > > > Because I see that in the roadmap of RB 1.5, it says ... > > > SSH and HTTPS support -- commited. > > > Thanks > > Kunjal > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > oups.com> > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today > athttp://www.reviewboard.org/donate/ > Happy user? Let us know athttp://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group > athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
AD Settings in RB
We have RB 1.0.5.1 installed. We have configured AD settings so all the users can login easily. Now, the issue is that we want to restrict users to only few departments in our company. So, we have created new windows security groups which has nested multiple department names in it. After doing this, the users of this departments can not access RB. If we put one department group then it works. But nesting of departments does not work. Does the RB 1.0.5.1 has ability to put multiple windows security groups for access/authentication? Is nesting possible? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
HTTPS support
We have RB 1.0.5.1 in production and it is http now. We want to move it to https. So, we did apache server settings and move RB to https. But now I can post the review but I can not post the diff. It gives me error. Is HTTTPS supported in 1.0.5.1? Because I see that in the roadmap of RB 1.5, it says ... SSH and HTTPS support -- commited. Thanks Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Limit of Access to RB
Hello, We have development happening world wide and we have some concerns over showing code diffs in some asian countires. The issue is when some one log in, they can click on "All Review Request" and view everyone's request. IS there a way to restrict it based on group etc? I look at the User section in Admin and I can see that there are lot of access controls are available for users. But I could not find one which will block viewing other's code review. Thanks Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Error while posting review for GIT
Ok.. so my path variable in Admin GUI is: git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git Now, where do I enter raw URL path? and if the path is different for each file, how we are going to manage it? Really sorry for all this quesitons but I am not getting hold of this.. On Feb 23, 12:48 pm, Christian Hammond wrote: > The user never needs to deal with it. > > What will happen is that post-review will find the origin of whatever branch > they're on (provided they have RBTools 0.2 RC1). It will find the repository > path of that origin and look for that in Review Board. That's what must be > in Path. > > As an example, let's take Review Board's setup. From a developer checkout of > the Review Board tree, 'git remote show origin' shows a URL of > '@github.com:reviewboard/reviewboard.git'. This is the Path that is in > the Repository entry in the Admin UI. Review Board will match that URL, but > it won't use it for accessing files. To access files, it uses the Raw URL > path. > > The Path should not be the user's own repository. It only needs to be > origin. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Tue, Feb 23, 2010 at 11:15 AM, Kunjal wrote: > > Thanks ! > > > The Path field should be the full path of the .git directory inside > > the checkout and this Path field is set in Admin GUI. > > How the user will keep update this path field in Admin GUI? That is > > not feasible right? > > > Kunjal > > > On Feb 22, 11:36 am, Christian Hammond wrote: > > > Never saw this e-mail. Must have missed it while on vacation. > > > > With the raw URL stuff, actually you can set Path as the git repo, > > because > > > we'll never use it to access files. > > > > cgit has to run on the upstream git repository, so on > > > mobcom-git.sj.broadcom.com probably. *Something* needs local access to a > > Git > > > repository, so if not Review Board, then cgit. > > > > You shouldn't need Review Board or cgit to reference local repositories. > > > post-review will find the proper upstream (the > > mobcom-git.sj.broadcom.com) > > > and reference that. > > > > For information on what to put in the Raw URL mask field with cgit, look > > at: > > > >http://www.reviewboard.org/docs/manual/dev/admin/management/repositor... > > > > Christian > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > On Thu, Feb 11, 2010 at 2:01 PM, Kunjal wrote: > > > > So, you are saying that Path variable in Admin GUI should be empty and > > > > Mirror Path: should list the git repository? > > > > > Path: Empty string > > > > Mirror Path: git:// > > > > mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git > > > > > I also configure cgit as you told but I do not know how to make my > > > > local workspace available in cgit and also what path I put in Path > > > > variable in Admin GUI for cgit. > > > > > Right now, posting review only works if there is below config: > > > > > Path: /projects/mobcom_andrwks_ext2/users/kaparikh/scripts/.git [ This > > > > is my local workspace and every developer would have its own ] > > > > Mirror Path: git:// > > > > mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git > > > > > I think I am getting there... > > > > > On Feb 10, 5:18 pm, Christian Hammond wrote: > > > > > Awesome :) > > > > > > You can put the git:// URL in Mirror Path and Review Board will match > > > > > it properly. It just won't use it for accessing the repository. > > > > > > Christian > > > > > > On Wednesday, February 10, 2010, Kunjal > > wrote: > > > > > > THANKS MAN ! > > > > > > > Finally I got it working. > > > > > > > But my Path in RB server looks like: /projects/mobcom_andrwks_ext2/ > > > > > > users/kaparikh/scripts/.git which is my workspace. > > > > > > > Every developer has different workspace and multiple repo to work > > > > > > with. > > > > > > > I did not get the part where you mentioned about raw URL stuff. > > > > > > > Thanks > > > > >
Re: ReviewBoard Error while posting review for GIT
Thanks ! The Path field should be the full path of the .git directory inside the checkout and this Path field is set in Admin GUI. How the user will keep update this path field in Admin GUI? That is not feasible right? Kunjal On Feb 22, 11:36 am, Christian Hammond wrote: > Never saw this e-mail. Must have missed it while on vacation. > > With the raw URL stuff, actually you can set Path as the git repo, because > we'll never use it to access files. > > cgit has to run on the upstream git repository, so on > mobcom-git.sj.broadcom.com probably. *Something* needs local access to a Git > repository, so if not Review Board, then cgit. > > You shouldn't need Review Board or cgit to reference local repositories. > post-review will find the proper upstream (the mobcom-git.sj.broadcom.com) > and reference that. > > For information on what to put in the Raw URL mask field with cgit, look at: > > http://www.reviewboard.org/docs/manual/dev/admin/management/repositor... > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Thu, Feb 11, 2010 at 2:01 PM, Kunjal wrote: > > So, you are saying that Path variable in Admin GUI should be empty and > > Mirror Path: should list the git repository? > > > Path: Empty string > > Mirror Path: git:// > > mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git > > > I also configure cgit as you told but I do not know how to make my > > local workspace available in cgit and also what path I put in Path > > variable in Admin GUI for cgit. > > > Right now, posting review only works if there is below config: > > > Path: /projects/mobcom_andrwks_ext2/users/kaparikh/scripts/.git [ This > > is my local workspace and every developer would have its own ] > > Mirror Path: git:// > > mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git > > > I think I am getting there... > > > On Feb 10, 5:18 pm, Christian Hammond wrote: > > > Awesome :) > > > > You can put the git:// URL in Mirror Path and Review Board will match > > > it properly. It just won't use it for accessing the repository. > > > > Christian > > > > On Wednesday, February 10, 2010, Kunjal wrote: > > > > THANKS MAN ! > > > > > Finally I got it working. > > > > > But my Path in RB server looks like: /projects/mobcom_andrwks_ext2/ > > > > users/kaparikh/scripts/.git which is my workspace. > > > > > Every developer has different workspace and multiple repo to work > > > > with. > > > > > I did not get the part where you mentioned about raw URL stuff. > > > > > Thanks > > > > Kunjal > > > > > On Feb 10, 10:28 am, Christian Hammond wrote: > > > >> Hi, > > > > >> Sorry, I'm out of town on vacation and emailing from my phone, do my > > > >> answers will be brief. > > > > >> Subversion, Perforce, etc. give you the ability to talk to a remote > > > >> server and request a single file without having a checkout of the > > > >> whole repository. Git does not. With Git, you must have a full clone, > > > >> on the local computer (in this case, the Review Board server), in > > > >> order to access a particular file. This also means keeping it fully in > > > >> sync with origin always. > > > > >> Because of this limitation in Git, you either need to set up this > > > >> clone and point Path to that or you needto use the Raw URL. This is a > > > >> mask (similar to the bug URL) that points to a path for a raw file on > > > >> cgit/gitweb/etc. This is the easiest, most preferred way. See the help > > > >> text under that field in the Repository configuration. > > > > >> Christian > > > > >> On Wednesday, February 10, 2010, Kunjal > > wrote: > > > >> > Chris, > > > > >> > Are you saying repository path field in the RB Admin GUI? > > > >> > I set it as git:// > > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git > > > >> > which is the server path where our repository resides. > > > > >> > What do you mean when you say GIT works only on local paths? How do > > I > > > >> > know developer's local workspace path? > > > > >> > Pl. help. this issue is taking away my sleep !! > > > > >> >
Re: ReviewBoard Error while posting review for GIT
Any update on this one?
I am again stuck here...
Kunjal
On Feb 11, 2:01 pm, Kunjal wrote:
> So, you are saying that Path variable in Admin GUI should be empty and
> Mirror Path: should list the git repository?
>
> Path: Empty string
> Mirror Path: git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git
>
> I also configure cgit as you told but I do not know how to make my
> local workspace available in cgit and also what path I put in Path
> variable in Admin GUI for cgit.
>
> Right now, posting review only works if there is below config:
>
> Path: /projects/mobcom_andrwks_ext2/users/kaparikh/scripts/.git [ This
> is my local workspace and every developer would have its own ]
> Mirror Path: git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git
>
> I think I am getting there...
>
> On Feb 10, 5:18 pm, Christian Hammond wrote:
>
>
>
> > Awesome :)
>
> > You can put the git:// URL in Mirror Path and Review Board will match
> > it properly. It just won't use it for accessing the repository.
>
> > Christian
>
> > On Wednesday, February 10, 2010, Kunjal wrote:
> > > THANKS MAN !
>
> > > Finally I got it working.
>
> > > But my Path in RB server looks like: /projects/mobcom_andrwks_ext2/
> > > users/kaparikh/scripts/.git which is my workspace.
>
> > > Every developer has different workspace and multiple repo to work
> > > with.
>
> > > I did not get the part where you mentioned about raw URL stuff.
>
> > > Thanks
> > > Kunjal
>
> > > On Feb 10, 10:28 am, Christian Hammond wrote:
> > >> Hi,
>
> > >> Sorry, I'm out of town on vacation and emailing from my phone, do my
> > >> answers will be brief.
>
> > >> Subversion, Perforce, etc. give you the ability to talk to a remote
> > >> server and request a single file without having a checkout of the
> > >> whole repository. Git does not. With Git, you must have a full clone,
> > >> on the local computer (in this case, the Review Board server), in
> > >> order to access a particular file. This also means keeping it fully in
> > >> sync with origin always.
>
> > >> Because of this limitation in Git, you either need to set up this
> > >> clone and point Path to that or you needto use the Raw URL. This is a
> > >> mask (similar to the bug URL) that points to a path for a raw file on
> > >> cgit/gitweb/etc. This is the easiest, most preferred way. See the help
> > >> text under that field in the Repository configuration.
>
> > >> Christian
>
> > >> On Wednesday, February 10, 2010, Kunjal wrote:
> > >> > Chris,
>
> > >> > Are you saying repository path field in the RB Admin GUI?
> > >> > I set it as
> > >> > git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git
> > >> > which is the server path where our repository resides.
>
> > >> > What do you mean when you say GIT works only on local paths? How do I
> > >> > know developer's local workspace path?
>
> > >> > Pl. help. this issue is taking away my sleep !!
>
> > >> > Kunjal
>
> > >> > On Feb 5, 2:48 pm, Christian Hammond wrote:
> > >> >> I still need to see the repository Path field to be able to say
> > >> >> what's going
> > >> >> on. Is it a remote path, or a local path on the filesystem? Git can
> > >> >> only
> > >> >> operate on local paths.
>
> > >> >> Christian
>
> > >> >> --
> > >> >> Christian Hammond - chip...@chipx86.com
> > >> >> Review Board -http://www.reviewboard.org
> > >> >> VMware, Inc. -http://www.vmware.com
>
> > >> >> On Fri, Feb 5, 2010 at 11:05 AM, Kunjal
> > >> >> wrote:
> > >> >> > It's failing here in git.py in scmtools folder.
>
> > >> >> > class GitClient:
> > >> >> > def __init__(self, path):
> > >> >> > if not is_exe_in_path('git'):
> > >> >> > # This is technically not the right kind of error, but
> > >> >> > it's the
> > >> >> > # pattern we use with all the other tools.
> > >> >> > raise ImportError
>
> > >> >> > self.path = path
> >
Re: ReviewBoard Error while posting review for GIT
So, you are saying that Path variable in Admin GUI should be empty and
Mirror Path: should list the git repository?
Path: Empty string
Mirror Path: git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git
I also configure cgit as you told but I do not know how to make my
local workspace available in cgit and also what path I put in Path
variable in Admin GUI for cgit.
Right now, posting review only works if there is below config:
Path: /projects/mobcom_andrwks_ext2/users/kaparikh/scripts/.git [ This
is my local workspace and every developer would have its own ]
Mirror Path: git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git
I think I am getting there...
On Feb 10, 5:18 pm, Christian Hammond wrote:
> Awesome :)
>
> You can put the git:// URL in Mirror Path and Review Board will match
> it properly. It just won't use it for accessing the repository.
>
> Christian
>
>
>
>
>
> On Wednesday, February 10, 2010, Kunjal wrote:
> > THANKS MAN !
>
> > Finally I got it working.
>
> > But my Path in RB server looks like: /projects/mobcom_andrwks_ext2/
> > users/kaparikh/scripts/.git which is my workspace.
>
> > Every developer has different workspace and multiple repo to work
> > with.
>
> > I did not get the part where you mentioned about raw URL stuff.
>
> > Thanks
> > Kunjal
>
> > On Feb 10, 10:28 am, Christian Hammond wrote:
> >> Hi,
>
> >> Sorry, I'm out of town on vacation and emailing from my phone, do my
> >> answers will be brief.
>
> >> Subversion, Perforce, etc. give you the ability to talk to a remote
> >> server and request a single file without having a checkout of the
> >> whole repository. Git does not. With Git, you must have a full clone,
> >> on the local computer (in this case, the Review Board server), in
> >> order to access a particular file. This also means keeping it fully in
> >> sync with origin always.
>
> >> Because of this limitation in Git, you either need to set up this
> >> clone and point Path to that or you needto use the Raw URL. This is a
> >> mask (similar to the bug URL) that points to a path for a raw file on
> >> cgit/gitweb/etc. This is the easiest, most preferred way. See the help
> >> text under that field in the Repository configuration.
>
> >> Christian
>
> >> On Wednesday, February 10, 2010, Kunjal wrote:
> >> > Chris,
>
> >> > Are you saying repository path field in the RB Admin GUI?
> >> > I set it as
> >> > git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git
> >> > which is the server path where our repository resides.
>
> >> > What do you mean when you say GIT works only on local paths? How do I
> >> > know developer's local workspace path?
>
> >> > Pl. help. this issue is taking away my sleep !!
>
> >> > Kunjal
>
> >> > On Feb 5, 2:48 pm, Christian Hammond wrote:
> >> >> I still need to see the repository Path field to be able to say what's
> >> >> going
> >> >> on. Is it a remote path, or a local path on the filesystem? Git can only
> >> >> operate on local paths.
>
> >> >> Christian
>
> >> >> --
> >> >> Christian Hammond - chip...@chipx86.com
> >> >> Review Board -http://www.reviewboard.org
> >> >> VMware, Inc. -http://www.vmware.com
>
> >> >> On Fri, Feb 5, 2010 at 11:05 AM, Kunjal wrote:
> >> >> > It's failing here in git.py in scmtools folder.
>
> >> >> > class GitClient:
> >> >> > def __init__(self, path):
> >> >> > if not is_exe_in_path('git'):
> >> >> > # This is technically not the right kind of error, but
> >> >> > it's the
> >> >> > # pattern we use with all the other tools.
> >> >> > raise ImportError
>
> >> >> > self.path = path
> >> >> > p = subprocess.Popen(
> >> >> > ['git', '--git-dir=%s' % self.path, 'config',
> >> >> > 'core.repositoryformatversion'],
> >> >> > stderr=subprocess.PIPE,
> >> >> > stdout=subprocess.PIPE,
> >> >> > close_fds=(os.name != 'nt')
> >> >> > )
> >> >> > contents = p.stdout.read()
> >&g
Re: ReviewBoard Error while posting review for GIT
THANKS MAN !
Finally I got it working.
But my Path in RB server looks like: /projects/mobcom_andrwks_ext2/
users/kaparikh/scripts/.git which is my workspace.
Every developer has different workspace and multiple repo to work
with.
I did not get the part where you mentioned about raw URL stuff.
Thanks
Kunjal
On Feb 10, 10:28 am, Christian Hammond wrote:
> Hi,
>
> Sorry, I'm out of town on vacation and emailing from my phone, do my
> answers will be brief.
>
> Subversion, Perforce, etc. give you the ability to talk to a remote
> server and request a single file without having a checkout of the
> whole repository. Git does not. With Git, you must have a full clone,
> on the local computer (in this case, the Review Board server), in
> order to access a particular file. This also means keeping it fully in
> sync with origin always.
>
> Because of this limitation in Git, you either need to set up this
> clone and point Path to that or you needto use the Raw URL. This is a
> mask (similar to the bug URL) that points to a path for a raw file on
> cgit/gitweb/etc. This is the easiest, most preferred way. See the help
> text under that field in the Repository configuration.
>
> Christian
>
>
>
>
>
> On Wednesday, February 10, 2010, Kunjal wrote:
> > Chris,
>
> > Are you saying repository path field in the RB Admin GUI?
> > I set it as
> > git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git
> > which is the server path where our repository resides.
>
> > What do you mean when you say GIT works only on local paths? How do I
> > know developer's local workspace path?
>
> > Pl. help. this issue is taking away my sleep !!
>
> > Kunjal
>
> > On Feb 5, 2:48 pm, Christian Hammond wrote:
> >> I still need to see the repository Path field to be able to say what's
> >> going
> >> on. Is it a remote path, or a local path on the filesystem? Git can only
> >> operate on local paths.
>
> >> Christian
>
> >> --
> >> Christian Hammond - chip...@chipx86.com
> >> Review Board -http://www.reviewboard.org
> >> VMware, Inc. -http://www.vmware.com
>
> >> On Fri, Feb 5, 2010 at 11:05 AM, Kunjal wrote:
> >> > It's failing here in git.py in scmtools folder.
>
> >> > class GitClient:
> >> > def __init__(self, path):
> >> > if not is_exe_in_path('git'):
> >> > # This is technically not the right kind of error, but
> >> > it's the
> >> > # pattern we use with all the other tools.
> >> > raise ImportError
>
> >> > self.path = path
> >> > p = subprocess.Popen(
> >> > ['git', '--git-dir=%s' % self.path, 'config',
> >> > 'core.repositoryformatversion'],
> >> > stderr=subprocess.PIPE,
> >> > stdout=subprocess.PIPE,
> >> > close_fds=(os.name != 'nt')
> >> > )
> >> > contents = p.stdout.read()
> >> > errmsg = p.stderr.read()
> >> > failure = p.wait()
>
> >> > if failure:
> >> > raise ImportError
>
> >> > On Feb 4, 1:31 pm, Kunjal wrote:
> >> > > When I look at the error.log for Apache server, It give me this:
> >> > > Am I not Importing some modules?
>
> >> > > Traceback (most recent call last):
> >> > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> >> > > packages/Django-1.1.1-py2.5.egg/django/core/handlers/base.py", line
> >> > > 92, in get_response
> >> > > response = callback(request, *callback_args, **callback_kwargs)
> >> > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> >> > > packages/Django-1.1.1-py2.5.egg/django/views/decorators/cache.py",
> >> > > line 44, in _wrapped_view_func
> >> > > response = view_func(request, *args, **kwargs)
> >> > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> >> > > packages/Djblets-0.5.5-py2.5.egg/djblets/webapi/decorators.py", line
> >> > > 59, in _checklogin
> >> > > response = view_func(request, *args, **kwargs)
> >> > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> >> > > packages/Django-1.1.1-py2.5.egg/django/views/decorators/
Re: ReviewBoard Error while posting review for GIT
One more thing..
My .git/config looks like this:
[core]
repositoryformatversion = 0
filemode = true
bare = false
logallrefupdates = true
[remote "origin"]
url = git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git
fetch = +refs/heads/*:refs/remotes/origin/*
[branch "master"]
remote = origin
merge = refs/heads/master
[branch "eclair"]
remote = origin
merge = refs/heads/eclair
[reviewboard]
url = http://mob-rb-test.sj.broadcom.com
On Feb 10, 10:21 am, Kunjal wrote:
> Here is the latest try using yesterday night's nightly post-review
> script.
> This is the repository path I added in Admin GUI ->->->
> git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git
>
> From the below log, I found this lines confusing:
>
> Attempting to create review request on
> git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git for
> None
>
> ./RB_Nightly_0210/rbtools/postreview.py -d
>
>
>
> >>> svn info
> >>> git rev-parse --git-dir
> >>> git symbolic-ref -q HEAD
> >>> git svn info
> >>> git svn --version
> >>> git config --get svn-remote.svn.url
> >>> git config --get branch.eclair.merge
> >>> git config --get branch.eclair.remote
> >>> git config remote.origin.url
> >>> repository info: Path:
> >>> git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git, Base
> >>> path: , Supports changesets: False
> >>> git config --get reviewboard.url
> >>> git merge-base origin/eclair refs/heads/eclair
> >>> git diff --no-color --full-index
> >>> 425c25809588ebe4ef72d2561c632f5faa7b02c3..refs/heads/eclair
> >>> Looking for 'mob-rb-test.sj.broadcom.com /' cookie in
> >>> /home/kaparikh/.post-review-cookies.txt
> >>> Loaded valid cookie -- no login required
> >>> Attempting to create review request on
> >>> git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git for None
> >>> HTTP POSTing
> >>> tohttp://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/:{'repository_path':
> >>> 'git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git'}
> >>> Review request created
> >>> Uploading diff, size: 0
> >>> HTTP POSTing
> >>> tohttp://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/37/diff/new/:{}
> >>>
> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>
>
> http://www.w3.org/1999/xhtml"; xml:lang="en" lang="en">
>
> 500 - Internal Server Error | Review Board
>
>
> Something broke! (Error 500)
>
> It appears something broke when you tried to go to here. This is
> either
> a bug in Review Board or a server configuration error. Please
> report
> this to your administrator.
>
>
>
>
> Unable to
> accesshttp://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/37/diff/new/.
> The hostpath may be invalid
> HTTP Error 500: Internal Server Error
>
> On Feb 5, 2:48 pm, Christian Hammond wrote:
>
>
>
> > I still need to see the repository Path field to be able to say what's going
> > on. Is it a remote path, or a local path on the filesystem? Git can only
> > operate on local paths.
>
> > Christian
>
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.reviewboard.org
> > VMware, Inc. -http://www.vmware.com
>
> > On Fri, Feb 5, 2010 at 11:05 AM, Kunjal wrote:
> > > It's failing here in git.py in scmtools folder.
>
> > > class GitClient:
> > > def __init__(self, path):
> > > if not is_exe_in_path('git'):
> > > # This is technically not the right kind of error, but
> > > it's the
> > > # pattern we use with all the other tools.
> > > raise ImportError
>
> > > self.path = path
> > > p = subprocess.Popen(
> > > ['git', '--git-dir=%s' % self.path, 'config',
> > > 'core.repositoryformatversion'],
> > > stderr=subprocess.PIPE,
> > > stdout=subprocess.PIPE,
> > > close_fds=(os.name != 'nt')
> > > )
> > > contents = p.stdout.read()
> > > errmsg = p.stderr.read()
> > > failure = p.wa
Re: ReviewBoard Error while posting review for GIT
Here is the latest try using yesterday night's nightly post-review
script.
This is the repository path I added in Admin GUI ->->->
git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git
>From the below log, I found this lines confusing:
Attempting to create review request on
git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git for
None
./RB_Nightly_0210/rbtools/postreview.py -d
>>> svn info
>>> git rev-parse --git-dir
>>> git symbolic-ref -q HEAD
>>> git svn info
>>> git svn --version
>>> git config --get svn-remote.svn.url
>>> git config --get branch.eclair.merge
>>> git config --get branch.eclair.remote
>>> git config remote.origin.url
>>> repository info: Path:
>>> git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git, Base
>>> path: , Supports changesets: False
>>> git config --get reviewboard.url
>>> git merge-base origin/eclair refs/heads/eclair
>>> git diff --no-color --full-index
>>> 425c25809588ebe4ef72d2561c632f5faa7b02c3..refs/heads/eclair
>>> Looking for 'mob-rb-test.sj.broadcom.com /' cookie in
>>> /home/kaparikh/.post-review-cookies.txt
>>> Loaded valid cookie -- no login required
>>> Attempting to create review request on
>>> git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git for None
>>> HTTP POSTing to
>>> http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/:
>>> {'repository_path':
>>> 'git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git'}
>>> Review request created
>>> Uploading diff, size: 0
>>> HTTP POSTing to
>>> http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/37/diff/new/: {}
>>> http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>
http://www.w3.org/1999/xhtml"; xml:lang="en" lang="en">
500 - Internal Server Error | Review Board
Something broke! (Error 500)
It appears something broke when you tried to go to here. This is
either
a bug in Review Board or a server configuration error. Please
report
this to your administrator.
Unable to access
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/37/diff/new/.
The hostpath may be invalid
HTTP Error 500: Internal Server Error
On Feb 5, 2:48 pm, Christian Hammond wrote:
> I still need to see the repository Path field to be able to say what's going
> on. Is it a remote path, or a local path on the filesystem? Git can only
> operate on local paths.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Fri, Feb 5, 2010 at 11:05 AM, Kunjal wrote:
> > It's failing here in git.py in scmtools folder.
>
> > class GitClient:
> > def __init__(self, path):
> > if not is_exe_in_path('git'):
> > # This is technically not the right kind of error, but
> > it's the
> > # pattern we use with all the other tools.
> > raise ImportError
>
> > self.path = path
> > p = subprocess.Popen(
> > ['git', '--git-dir=%s' % self.path, 'config',
> > 'core.repositoryformatversion'],
> > stderr=subprocess.PIPE,
> > stdout=subprocess.PIPE,
> > close_fds=(os.name != 'nt')
> > )
> > contents = p.stdout.read()
> > errmsg = p.stderr.read()
> > failure = p.wait()
>
> > if failure:
> > raise ImportError
>
> > On Feb 4, 1:31 pm, Kunjal wrote:
> > > When I look at the error.log for Apache server, It give me this:
> > > Am I not Importing some modules?
>
> > > Traceback (most recent call last):
> > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> > > packages/Django-1.1.1-py2.5.egg/django/core/handlers/base.py", line
> > > 92, in get_response
> > > response = callback(request, *callback_args, **callback_kwargs)
> > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> > > packages/Django-1.1.1-py2.5.egg/django/views/decorators/cache.py",
> > > line 44, in _wrapped_view_func
> > > response = view_func(request, *args, **kwargs)
> > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> > > packages/Djblets-0.5.5-py2.5.egg/djblets/webapi/decorators.py", li
Re: ReviewBoard Error while posting review for GIT
Chris,
Are you saying repository path field in the RB Admin GUI?
I set it as git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git
which is the server path where our repository resides.
What do you mean when you say GIT works only on local paths? How do I
know developer's local workspace path?
Pl. help. this issue is taking away my sleep !!
Kunjal
On Feb 5, 2:48 pm, Christian Hammond wrote:
> I still need to see the repository Path field to be able to say what's going
> on. Is it a remote path, or a local path on the filesystem? Git can only
> operate on local paths.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Fri, Feb 5, 2010 at 11:05 AM, Kunjal wrote:
> > It's failing here in git.py in scmtools folder.
>
> > class GitClient:
> > def __init__(self, path):
> > if not is_exe_in_path('git'):
> > # This is technically not the right kind of error, but
> > it's the
> > # pattern we use with all the other tools.
> > raise ImportError
>
> > self.path = path
> > p = subprocess.Popen(
> > ['git', '--git-dir=%s' % self.path, 'config',
> > 'core.repositoryformatversion'],
> > stderr=subprocess.PIPE,
> > stdout=subprocess.PIPE,
> > close_fds=(os.name != 'nt')
> > )
> > contents = p.stdout.read()
> > errmsg = p.stderr.read()
> > failure = p.wait()
>
> > if failure:
> > raise ImportError
>
> > On Feb 4, 1:31 pm, Kunjal wrote:
> > > When I look at the error.log for Apache server, It give me this:
> > > Am I not Importing some modules?
>
> > > Traceback (most recent call last):
> > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> > > packages/Django-1.1.1-py2.5.egg/django/core/handlers/base.py", line
> > > 92, in get_response
> > > response = callback(request, *callback_args, **callback_kwargs)
> > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> > > packages/Django-1.1.1-py2.5.egg/django/views/decorators/cache.py",
> > > line 44, in _wrapped_view_func
> > > response = view_func(request, *args, **kwargs)
> > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> > > packages/Djblets-0.5.5-py2.5.egg/djblets/webapi/decorators.py", line
> > > 59, in _checklogin
> > > response = view_func(request, *args, **kwargs)
> > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> > > packages/Django-1.1.1-py2.5.egg/django/views/decorators/http.py", line
> > > 37, in inner
> > > return func(request, *args, **kwargs)
> > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/webapi/json.py",
> > > line 1178, in new_diff
> > > form = UploadDiffForm(review_request.repository, form_data,
> > > request.FILES)
> > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
> > > forms.py", line 44, in __init__
> > > if self.repository.get_scmtool().get_diffs_use_absolute_paths():
> > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/
> > > models.py", line 43, in get_scmtool
> > > return cls(self)
> > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/git.py",
> > > line 23, in __init__
> > > self.client = GitClient(repository.path)
> > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/git.py",
> > > line 180, in __init__
> > > raise ImportError
> > > ImportError
> > > ERROR:root:Exception thrown for user kaparikh athttp://
> > mob-rb-test.sj.broadcom.com/api/json/reviewrequests/34/diff/new/
>
> > > On Feb 3, 1:28 pm, Kunjal wrote:
>
> > > > One more thing..
> > > > How to fix the issue of post-review can not find the branches
> > > > correctly?
> &g
Re: ReviewBoard Error while posting review for GIT
It's failing here in git.py in scmtools folder.
class GitClient:
def __init__(self, path):
if not is_exe_in_path('git'):
# This is technically not the right kind of error, but
it's the
# pattern we use with all the other tools.
raise ImportError
self.path = path
p = subprocess.Popen(
['git', '--git-dir=%s' % self.path, 'config',
'core.repositoryformatversion'],
stderr=subprocess.PIPE,
stdout=subprocess.PIPE,
close_fds=(os.name != 'nt')
)
contents = p.stdout.read()
errmsg = p.stderr.read()
failure = p.wait()
if failure:
raise ImportError
On Feb 4, 1:31 pm, Kunjal wrote:
> When I look at the error.log for Apache server, It give me this:
> Am I not Importing some modules?
>
> Traceback (most recent call last):
> File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> packages/Django-1.1.1-py2.5.egg/django/core/handlers/base.py", line
> 92, in get_response
> response = callback(request, *callback_args, **callback_kwargs)
> File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> packages/Django-1.1.1-py2.5.egg/django/views/decorators/cache.py",
> line 44, in _wrapped_view_func
> response = view_func(request, *args, **kwargs)
> File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> packages/Djblets-0.5.5-py2.5.egg/djblets/webapi/decorators.py", line
> 59, in _checklogin
> response = view_func(request, *args, **kwargs)
> File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> packages/Django-1.1.1-py2.5.egg/django/views/decorators/http.py", line
> 37, in inner
> return func(request, *args, **kwargs)
> File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/webapi/json.py",
> line 1178, in new_diff
> form = UploadDiffForm(review_request.repository, form_data,
> request.FILES)
> File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
> forms.py", line 44, in __init__
> if self.repository.get_scmtool().get_diffs_use_absolute_paths():
> File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/
> models.py", line 43, in get_scmtool
> return cls(self)
> File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/git.py",
> line 23, in __init__
> self.client = GitClient(repository.path)
> File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
> packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/git.py",
> line 180, in __init__
> raise ImportError
> ImportError
> ERROR:root:Exception thrown for user kaparikh
> athttp://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/34/diff/new/
>
> On Feb 3, 1:28 pm, Kunjal wrote:
>
>
>
> > One more thing..
> > How to fix the issue of post-review can not find the branches
> > correctly?
> > As I mentioned you earlier, i have find/replace master branch to donut
> > in postreview.py to get to this point.
> > If I don't do that I get different set of errors.
>
> > Thanks for your help.
> > Kunjal
>
> > On Feb 2, 3:56 pm, Christian Hammond wrote:
>
> > > Hmm okay, well at least it's talking to the server now. If you check your
> > > server log file, you should be able to see some exception information that
> > > says what's generated that 500 error. If not, then temporarily setting
> > > DEBUG
> > > = True in your site's conf/settings_local.py will display that exception
> > > information in place of the 500 error. Either way, that should help to
> > > figure out where it's failing and hopefully what's going wrong.
>
> > > One thing that could be causing it, though, is your Review Board
> > > repository
> > > entry for your Git repository. Do you have it just referencing your remote
> > > git:// URL, or is Path actually pointing to a local Git checkout? There's
> > > no
> > > concept of grabbing individual files from a remote Git repository, so you
> > > need either a local clone accessible by Review Board, or if you're using
> > > the
> > > 1.1/1.5 alphas/nightlies you can specify a special URL for checking out a
> > > raw file from a Git web
Re: ReviewBoard Error while posting review for GIT
When I look at the error.log for Apache server, It give me this:
Am I not Importing some modules?
Traceback (most recent call last):
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/core/handlers/base.py", line
92, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/views/decorators/cache.py",
line 44, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Djblets-0.5.5-py2.5.egg/djblets/webapi/decorators.py", line
59, in _checklogin
response = view_func(request, *args, **kwargs)
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/views/decorators/http.py", line
37, in inner
return func(request, *args, **kwargs)
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/webapi/json.py",
line 1178, in new_diff
form = UploadDiffForm(review_request.repository, form_data,
request.FILES)
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
forms.py", line 44, in __init__
if self.repository.get_scmtool().get_diffs_use_absolute_paths():
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/
models.py", line 43, in get_scmtool
return cls(self)
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/git.py",
line 23, in __init__
self.client = GitClient(repository.path)
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/git.py",
line 180, in __init__
raise ImportError
ImportError
ERROR:root:Exception thrown for user kaparikh at
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/34/diff/new/
On Feb 3, 1:28 pm, Kunjal wrote:
> One more thing..
> How to fix the issue of post-review can not find the branches
> correctly?
> As I mentioned you earlier, i have find/replace master branch to donut
> in postreview.py to get to this point.
> If I don't do that I get different set of errors.
>
> Thanks for your help.
> Kunjal
>
> On Feb 2, 3:56 pm, Christian Hammond wrote:
>
>
>
> > Hmm okay, well at least it's talking to the server now. If you check your
> > server log file, you should be able to see some exception information that
> > says what's generated that 500 error. If not, then temporarily setting DEBUG
> > = True in your site's conf/settings_local.py will display that exception
> > information in place of the 500 error. Either way, that should help to
> > figure out where it's failing and hopefully what's going wrong.
>
> > One thing that could be causing it, though, is your Review Board repository
> > entry for your Git repository. Do you have it just referencing your remote
> > git:// URL, or is Path actually pointing to a local Git checkout? There's no
> > concept of grabbing individual files from a remote Git repository, so you
> > need either a local clone accessible by Review Board, or if you're using the
> > 1.1/1.5 alphas/nightlies you can specify a special URL for checking out a
> > raw file from a Git web front-end such as cgit or gitweb.
>
> > Unless the Git guys someday extend the protocol to fetch an individual file
> > by revision from an upstream repository without a local checkout, this is
> > the best we can do.
>
> > Christian
>
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.reviewboard.org
> > VMware, Inc. -http://www.vmware.com
>
> > On Tue, Feb 2, 2010 at 3:20 PM, Kunjal wrote:
> > > If i try with REVIEWBOARD_URL = 'None' (Below is the debug output)
> > > It looks like the URL is correct now. But I am still getting error.
> > > mob-rb-test{kaparikh}22: postreview.py -d
> > > >>> svn info
> > > >>> git rev-parse --git-dir
> > > >>> git svn info
> > > >>> git svn --version
> > > >>> git config --get svn-remote.svn.url
> > > >>> git remote show origin
> > > >>> repository info: Path: git://
> > > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git, Base path: ,
> > > Supports changesets: False
> > > >>> git con
Re: ReviewBoard Error while posting review for GIT
One more thing..
How to fix the issue of post-review can not find the branches
correctly?
As I mentioned you earlier, i have find/replace master branch to donut
in postreview.py to get to this point.
If I don't do that I get different set of errors.
Thanks for your help.
Kunjal
On Feb 2, 3:56 pm, Christian Hammond wrote:
> Hmm okay, well at least it's talking to the server now. If you check your
> server log file, you should be able to see some exception information that
> says what's generated that 500 error. If not, then temporarily setting DEBUG
> = True in your site's conf/settings_local.py will display that exception
> information in place of the 500 error. Either way, that should help to
> figure out where it's failing and hopefully what's going wrong.
>
> One thing that could be causing it, though, is your Review Board repository
> entry for your Git repository. Do you have it just referencing your remote
> git:// URL, or is Path actually pointing to a local Git checkout? There's no
> concept of grabbing individual files from a remote Git repository, so you
> need either a local clone accessible by Review Board, or if you're using the
> 1.1/1.5 alphas/nightlies you can specify a special URL for checking out a
> raw file from a Git web front-end such as cgit or gitweb.
>
> Unless the Git guys someday extend the protocol to fetch an individual file
> by revision from an upstream repository without a local checkout, this is
> the best we can do.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Tue, Feb 2, 2010 at 3:20 PM, Kunjal wrote:
> > If i try with REVIEWBOARD_URL = 'None' (Below is the debug output)
> > It looks like the URL is correct now. But I am still getting error.
> > mob-rb-test{kaparikh}22: postreview.py -d
> > >>> svn info
> > >>> git rev-parse --git-dir
> > >>> git svn info
> > >>> git svn --version
> > >>> git config --get svn-remote.svn.url
> > >>> git remote show origin
> > >>> repository info: Path: git://
> > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git, Base path: ,
> > Supports changesets: False
> > >>> git config --get reviewboard.url
> > >>> git diff --no-color --full-index donut
> > >>> Looking for 'mob-rb-test.sj.broadcom.com /' cookie in
> > /home/kaparikh/.post-review-cookies.txt
> > >>> Loaded valid cookie -- no login required
> > >>> Attempting to create review request for None
> > _make_url: path = api/json/reviewrequests/new/
> > _make_url:app = /
> > _make_url: joined URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/
> > _make_url: Resulting URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/
> > >>> HTTP POSTing to
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/:
> > {'repository_path': 'git://
> > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git'}
> > >>> Review request created
> > >>> Uploading diff, size: 867
> > _make_url: path = api/json/reviewrequests/30/diff/new/
> > _make_url:app = /
> > _make_url: joined URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/
> > _make_url: Resulting URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/
> > >>> HTTP POSTing to
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/:
> > {}
> > >>> > "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>
>
> > http://www.w3.org/1999/xhtml"; xml:lang="en" lang="en">
> >
> > 500 - Internal Server Error | Review Board
> >
> >
> > Something broke! (Error 500)
> >
> > It appears something broke when you tried to go to here. This is
> > either
> > a bug in Review Board or a server configuration error. Please
> > report
> > this to your administrator.
> >
> >
> >
>
> > Unable to access
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/.
> > The host path may be invalid
> > HTTP Error 500: Internal Server Error
>
> > ####
>
> > Also, I get up to above error by replacing master branch to donut in
> > the post-review.py script.
> > If I
Re: ReviewBoard Error while posting review for GIT
Thanks..
I read few post and many people are seeing similar error like mine but
they are talking about installting pysvn.
Does that apply to me as well for GIT?
-Kunjal
On Feb 2, 3:56 pm, Christian Hammond wrote:
> Hmm okay, well at least it's talking to the server now. If you check your
> server log file, you should be able to see some exception information that
> says what's generated that 500 error. If not, then temporarily setting DEBUG
> = True in your site's conf/settings_local.py will display that exception
> information in place of the 500 error. Either way, that should help to
> figure out where it's failing and hopefully what's going wrong.
>
> One thing that could be causing it, though, is your Review Board repository
> entry for your Git repository. Do you have it just referencing your remote
> git:// URL, or is Path actually pointing to a local Git checkout? There's no
> concept of grabbing individual files from a remote Git repository, so you
> need either a local clone accessible by Review Board, or if you're using the
> 1.1/1.5 alphas/nightlies you can specify a special URL for checking out a
> raw file from a Git web front-end such as cgit or gitweb.
>
> Unless the Git guys someday extend the protocol to fetch an individual file
> by revision from an upstream repository without a local checkout, this is
> the best we can do.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Tue, Feb 2, 2010 at 3:20 PM, Kunjal wrote:
> > If i try with REVIEWBOARD_URL = 'None' (Below is the debug output)
> > It looks like the URL is correct now. But I am still getting error.
> > mob-rb-test{kaparikh}22: postreview.py -d
> > >>> svn info
> > >>> git rev-parse --git-dir
> > >>> git svn info
> > >>> git svn --version
> > >>> git config --get svn-remote.svn.url
> > >>> git remote show origin
> > >>> repository info: Path: git://
> > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git, Base path: ,
> > Supports changesets: False
> > >>> git config --get reviewboard.url
> > >>> git diff --no-color --full-index donut
> > >>> Looking for 'mob-rb-test.sj.broadcom.com /' cookie in
> > /home/kaparikh/.post-review-cookies.txt
> > >>> Loaded valid cookie -- no login required
> > >>> Attempting to create review request for None
> > _make_url: path = api/json/reviewrequests/new/
> > _make_url:app = /
> > _make_url: joined URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/
> > _make_url: Resulting URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/
> > >>> HTTP POSTing to
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/:
> > {'repository_path': 'git://
> > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git'}
> > >>> Review request created
> > >>> Uploading diff, size: 867
> > _make_url: path = api/json/reviewrequests/30/diff/new/
> > _make_url:app = /
> > _make_url: joined URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/
> > _make_url: Resulting URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/
> > >>> HTTP POSTing to
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/:
> > {}
> > >>> > "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>
>
> > http://www.w3.org/1999/xhtml"; xml:lang="en" lang="en">
> >
> > 500 - Internal Server Error | Review Board
> >
> >
> > Something broke! (Error 500)
> >
> > It appears something broke when you tried to go to here. This is
> > either
> > a bug in Review Board or a server configuration error. Please
> > report
> > this to your administrator.
> >
> >
> >
>
> > Unable to access
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/.
> > The host path may be invalid
> > HTTP Error 500: Internal Server Error
>
> > ####
>
> > Also, I get up to above error by replacing master branch to donut in
> > the post-review.py script.
> > If I do not change this, I get different error which is like:
>
> > [[
>
> > mob-rb-test{kaparikh}30: po
RB review Process Automation
Chris, Once the Review is done, user has to make Review as Close->Submitted eles reviewers dashboard will still have the review. We enforce this process on developers and developers are saying that this is one extra step. I was thinking whether it is possible to close the review automatically? For example, for given Review, if the shipit_count is more then zero then review is approved and we can close it. Is there any way to do it programatically? Thanks Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Error while posting review for GIT
If i try with REVIEWBOARD_URL = 'None' (Below is the debug output)
It looks like the URL is correct now. But I am still getting error.
mob-rb-test{kaparikh}22: postreview.py -d
>>> svn info
>>> git rev-parse --git-dir
>>> git svn info
>>> git svn --version
>>> git config --get svn-remote.svn.url
>>> git remote show origin
>>> repository info: Path:
>>> git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git, Base
>>> path: , Supports changesets: False
>>> git config --get reviewboard.url
>>> git diff --no-color --full-index donut
>>> Looking for 'mob-rb-test.sj.broadcom.com /' cookie in
>>> /home/kaparikh/.post-review-cookies.txt
>>> Loaded valid cookie -- no login required
>>> Attempting to create review request for None
_make_url: path = api/json/reviewrequests/new/
_make_url:app = /
_make_url: joined URL =
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/
_make_url: Resulting URL =
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/
>>> HTTP POSTing to
>>> http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/:
>>> {'repository_path':
>>> 'git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git'}
>>> Review request created
>>> Uploading diff, size: 867
_make_url: path = api/json/reviewrequests/30/diff/new/
_make_url:app = /
_make_url: joined URL =
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/
_make_url: Resulting URL =
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/
>>> HTTP POSTing to
>>> http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/: {}
>>> http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>
http://www.w3.org/1999/xhtml"; xml:lang="en" lang="en">
500 - Internal Server Error | Review Board
Something broke! (Error 500)
It appears something broke when you tried to go to here. This is
either
a bug in Review Board or a server configuration error. Please
report
this to your administrator.
Unable to access
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/.
The host path may be invalid
HTTP Error 500: Internal Server Error
Also, I get up to above error by replacing master branch to donut in
the post-review.py script.
If I do not change this, I get different error which is like:
[[
mob-rb-test{kaparikh}30: postreview.py -d
>>> svn info
>>> git rev-parse --git-dir
>>> git svn info
>>> git svn --version
>>> git config --get svn-remote.svn.url
>>> git remote show origin
>>> repository info: Path:
>>> git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git, Base
>>> path: , Supports changesets: False
>>> git config --get reviewboard.url
>>> git diff --no-color --full-index master
Failed to execute command: ['git', 'diff', '--no-color', '--full-
index', 'master']
fatal: ambiguous argument 'master': unknown revision or path not in
the working tree.
Use '--' to separate paths from revisions
]]
On Jan 28, 3:05 pm, Christian Hammond wrote:
> You shouldn't need to set REVIEWBOARD_URL in postreview.py. It's pretty much
> intended for when there's no alternate way to configure the URL and a
> company wants to set a single URL company-wide. However, a much better
> option is either the per-repository configuration (such as using git config)
> or the .reviewboardrc file. If you set REVIEWBOARD_URL, it will override the
> other configuration types.
>
> I will point out that in the future, postreview.py will require other code
> in RBTools, so copying out postreview.py won't work. Probably after the 0.2
> release.
>
> At this point, I'd say we should add some debugging information to
> postreview.py. Search for the _make_url function, and change it to:
>
> print "_make_url: path = %s" % path
> app = urlparse(self.url)[2]
>
> print "_make_url: app = %s" % app
> if path[0] == '/':
> url = urljoin(self.url, app[:-1] + path)
> else:
> url = urljoin(self.url, app + path)
> print "_make_url: joined URL = %s" % url
>
> if not url.startswith('http'):
> url = 'http://%s' % url
>
> print "_make_url: Resulting URL = %s" % url
> return url
>
> That'll hopefully help us see where it's going wrong.
>
> Christia
Re: Post review with combination of binary + txt file does not work
Any info. on this one? Thanks ! On Jan 26, 6:50 pm, Kunjal wrote: > Hello Chris, > > With RB 1.0.5.1, when someone post the review with 1 binary file + 1 > txt file, RB should filter out the binary file but txt file should be > able to get reviewed in RB. > > We are getting below message when the user look at the RB web after > posting review. > > When I test RB, I could post review with few binary files + few text > file and it filter out binary files correctly. > Why this issue re-surfacing now? Does it depend on type of file? The > files we have are called .spr file and they are marked as BINARY in > perforce. > > The patch to 'C:/Builds/Mobcom/sysDev/21331/MMI_2/msp/stack/hedge/sdt/ > usimap.spr' didn't apply cleanly. The temporary files have been left > in '/tmp/reviewboard.GAdWou' for debugging purposes. `patch` returned: > patching file /tmp/reviewboard.GAdWou/tmp4nYJKO Hunk #1 succeeded at > 4297 (offset 187 lines). Hunk #2 succeeded at 4367 (offset 2 lines). > Hunk #3 succeeded at 9821 (offset 335 lines). Hunk #4 succeeded at > 9538 (offset 2 lines). Hunk #5 succeeded at 16413 (offset 608 lines). > Hunk #6 succeeded at 17689 (offset 147 lines). Hunk #7 succeeded at > 21659 (offset 760 lines). Hunk #8 succeeded at 24243 (offset 586 > lines). Hunk #9 succeeded at 25320 (offset 809 lines). Hunk #10 > succeeded at 25777 (offset 625 lines). patch: malformed patch at > line 171: ]]][ > > Traceback (most recent call last): > File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ > site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > views.py", line 153, in view_diff > interdiffset, highlighting, True) > File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ > site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > diffutils.py", line 623, in get_diff_files > large_data=True) > File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ > site-packages/Djblets-0.5.6-py2.5.egg/djblets/util/misc.py", line 162, > in cache_memoize > data = lookup_callable() > File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ > site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > diffutils.py", line 622, in > enable_syntax_highlighting), > File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ > site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > diffutils.py", line 345, in get_chunks > new = get_patched_file(old, filediff) > File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ > site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > diffutils.py", line 261, in get_patched_file > return patch(filediff.diff, buffer, filediff.dest_file) > File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ > site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > diffutils.py", line 129, in patch > (filename, tempdir, patch_output)) > Exception: The patch to 'C:/Builds/Mobcom/sysDev/21331/MMI_2/msp/stack/ > hedge/sdt/usimap.spr' didn't apply cleanly. The temporary files have > been left in '/tmp/reviewboard.GAdWou' for debugging purposes. > `patch` returned: patching file /tmp/reviewboard.GAdWou/tmp4nYJKO > Hunk #1 succeeded at 4297 (offset 187 lines). > Hunk #2 succeeded at 4367 (offset 2 lines). > Hunk #3 succeeded at 9821 (offset 335 lines). > Hunk #4 succeeded at 9538 (offset 2 lines). > Hunk #5 succeeded at 16413 (offset 608 lines). > Hunk #6 succeeded at 17689 (offset 147 lines). > Hunk #7 succeeded at 21659 (offset 760 lines). > Hunk #8 succeeded at 24243 (offset 586 lines). > Hunk #9 succeeded at 25320 (offset 809 lines). > Hunk #10 succeeded at 25777 (offset 625 lines). > patch: malformed patch at line 171: ]]][ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: SHIP IT countre is zero even if reviewer clicks ship it.
Thanks for everyone's help. The issue is fixed now. Great help indeed !! On Feb 1, 9:09 pm, Onkar wrote: > On Jan 28, 10:38 pm, Kunjal wrote: > > > Hello, > > > For one of our user, he does have active account and when he approves > > the review, the ship it counter is still zero. > > Why this is happening? > > > When I debug this, I found that the user did logged in RB today but in > > the Submitters list, it is showing his last login as 2009-12-17. > > > Is this causing issue? Where should I debug for this? > > Which version of reviewboard are you using? There was indeed an issue > in earlier versions which is fixed in latest 1.0.x version. > > Check following release > notes.http://www.reviewboard.org/docs/releasenotes/dev/reviewboard/1.0.2/ > > Onkar -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: SHIP IT countre is zero even if reviewer clicks ship it.
so, what is the diff between ship_it and shipit_count? If there is at-least one ship it marked, the value of ship_it should not be one? I understand that ship_it is providing 0 or 1 only. It is not the actual count. Just want to understand why if the review is approved, ship_it is still zero? Kunjal On Feb 1, 11:05 am, Kunjal wrote: > Ok. > > It looks like I found the issue. > I am doing query on incorrect table.. > > Let me try this out. > > On Jan 29, 2:22 pm, Christian Hammond wrote: > > > > > Hi, > > > I'd love to provide a patch, except I don't think Review Board is broken. > > This works fine from what I can tell, and the code has not changed since we > > introduced it. > > > I'm not convinced the query is correct, though. That ship_it column is not a > > counter. It's a boolean flag, meaning that you'll get back a 1 or a 0. It's > > not taking into account the sum of the values from those reviews. > > > What you probably want to be querying is the shipit_count column on the > > reviewrequest itself. This is the actual number of published reviews marked > > Ship It for that review request. > > > Christian > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.reviewboard.org > > VMware, Inc. -http://www.vmware.com > > > On Fri, Jan 29, 2010 at 2:13 PM, Kunjal wrote: > > > Chris. > > > > Here is what happening. > > > > Reviewer mark the review Ship It. > > > In the night, I generate the report saying how many reviews are > > > apprved or how many are pending etc. > > > > I create the query and get the data of SHIP IT counter: > > > > my $query = " > > > > SELECT r1.id, submitter_id, r2.username, r2.first_name, r2.last_name, > > > changenum ,time_added, description, ship_it FROM > > > reviewboard.reviews_reviewrequest r1 LEFT OUTER JOIN > > > diffviewer_diffset n1 on r1.diffset_history_id=n1.history_id LEFT > > > OUTER JOIN diffviewer_filediff n2 on n1.id=n2.diffset_id LEFT OUTER > > > JOIN reviewboard.reviews_review r ON r1.id=r.review_request_id LEFT > > > OUTER JOIN reviewboard.auth_user r2 ON submitter_id=r2.id where > > > description like '$uniqueKey'; > > > > "; > > > > From this query result, I found the value of SHIP IT counter and > > > report whether reveiew is approved or pending. > > > > So, for few users we are observing that even if they click on Ship It, > > > the value of ship_it counter is zero. > > > > We are having more of such issue now a days. > > > Someone report one more issue and issue escalated to director level !! > > > Can your team provide any patch release? > > > > We are using mySQL database. > > > > Kunjal > > > > On Jan 28, 2:46 pm, Christian Hammond wrote: > > > > So, they click Ship It, publish the review, and you see the review with > > > the > > > > Ship It but you don't see that on the dashboard? > > > > > This sounds like the code for bumping up the Ship It counter > > > > (ReviewRequest.increment_ship_it in reviewboard/reviews/models.py) is > > > > not > > > > working correctly. What database are you using? > > > > > The last login time should be fine. I believe that's just storing when > > > they > > > > actually performed the login, and the cookie has kept him logged in ever > > > > since. > > > > > Christian > > > > > -- > > > > Christian Hammond - chip...@chipx86.com > > > > Review Board -http://www.reviewboard.org > > > > VMware, Inc. -http://www.vmware.com > > > > > On Thu, Jan 28, 2010 at 9:38 AM, Kunjal wrote: > > > > > Hello, > > > > > > For one of our user, he does have active account and when he approves > > > > > the review, the ship it counter is still zero. > > > > > Why this is happening? > > > > > > When I debug this, I found that the user did logged in RB today but in > > > > > the Submitters list, it is showing his last login as 2009-12-17. > > > > > > Is this causing issue? Where should I debug for this? > > > > > > Kunjal > > > > > > -- > > > > > Want to help the Review Board project? Donate today at > > > > >http://www.reviewboard.org/donate/ > > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > &
Re: SHIP IT countre is zero even if reviewer clicks ship it.
Ok. It looks like I found the issue. I am doing query on incorrect table.. Let me try this out. On Jan 29, 2:22 pm, Christian Hammond wrote: > Hi, > > I'd love to provide a patch, except I don't think Review Board is broken. > This works fine from what I can tell, and the code has not changed since we > introduced it. > > I'm not convinced the query is correct, though. That ship_it column is not a > counter. It's a boolean flag, meaning that you'll get back a 1 or a 0. It's > not taking into account the sum of the values from those reviews. > > What you probably want to be querying is the shipit_count column on the > reviewrequest itself. This is the actual number of published reviews marked > Ship It for that review request. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Fri, Jan 29, 2010 at 2:13 PM, Kunjal wrote: > > Chris. > > > Here is what happening. > > > Reviewer mark the review Ship It. > > In the night, I generate the report saying how many reviews are > > apprved or how many are pending etc. > > > I create the query and get the data of SHIP IT counter: > > > my $query = " > > > SELECT r1.id, submitter_id, r2.username, r2.first_name, r2.last_name, > > changenum ,time_added, description, ship_it FROM > > reviewboard.reviews_reviewrequest r1 LEFT OUTER JOIN > > diffviewer_diffset n1 on r1.diffset_history_id=n1.history_id LEFT > > OUTER JOIN diffviewer_filediff n2 on n1.id=n2.diffset_id LEFT OUTER > > JOIN reviewboard.reviews_review r ON r1.id=r.review_request_id LEFT > > OUTER JOIN reviewboard.auth_user r2 ON submitter_id=r2.id where > > description like '$uniqueKey'; > > > "; > > > From this query result, I found the value of SHIP IT counter and > > report whether reveiew is approved or pending. > > > So, for few users we are observing that even if they click on Ship It, > > the value of ship_it counter is zero. > > > We are having more of such issue now a days. > > Someone report one more issue and issue escalated to director level !! > > Can your team provide any patch release? > > > We are using mySQL database. > > > Kunjal > > > On Jan 28, 2:46 pm, Christian Hammond wrote: > > > So, they click Ship It, publish the review, and you see the review with > > the > > > Ship It but you don't see that on the dashboard? > > > > This sounds like the code for bumping up the Ship It counter > > > (ReviewRequest.increment_ship_it in reviewboard/reviews/models.py) is not > > > working correctly. What database are you using? > > > > The last login time should be fine. I believe that's just storing when > > they > > > actually performed the login, and the cookie has kept him logged in ever > > > since. > > > > Christian > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > On Thu, Jan 28, 2010 at 9:38 AM, Kunjal wrote: > > > > Hello, > > > > > For one of our user, he does have active account and when he approves > > > > the review, the ship it counter is still zero. > > > > Why this is happening? > > > > > When I debug this, I found that the user did logged in RB today but in > > > > the Submitters list, it is showing his last login as 2009-12-17. > > > > > Is this causing issue? Where should I debug for this? > > > > > Kunjal > > > > > -- > > > > Want to help the Review Board project? Donate today at > > > >http://www.reviewboard.org/donate/ > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > > -~--~~~~--~~--~--~--- > > > > To unsubscribe from this group, send email to > > > > reviewboard+unsubscr...@googlegroups.com > > > > > > For more options, visit this group at > > > >http://groups.google.com/group/reviewboard?hl=en-Hide quoted text - > > > > - Show quoted text - > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: SHIP IT countre is zero even if reviewer clicks ship it.
Chris. Here is what happening. Reviewer mark the review Ship It. In the night, I generate the report saying how many reviews are apprved or how many are pending etc. I create the query and get the data of SHIP IT counter: my $query = " SELECT r1.id, submitter_id, r2.username, r2.first_name, r2.last_name, changenum ,time_added, description, ship_it FROM reviewboard.reviews_reviewrequest r1 LEFT OUTER JOIN diffviewer_diffset n1 on r1.diffset_history_id=n1.history_id LEFT OUTER JOIN diffviewer_filediff n2 on n1.id=n2.diffset_id LEFT OUTER JOIN reviewboard.reviews_review r ON r1.id=r.review_request_id LEFT OUTER JOIN reviewboard.auth_user r2 ON submitter_id=r2.id where description like '$uniqueKey'; "; >From this query result, I found the value of SHIP IT counter and report whether reveiew is approved or pending. So, for few users we are observing that even if they click on Ship It, the value of ship_it counter is zero. We are having more of such issue now a days. Someone report one more issue and issue escalated to director level !! Can your team provide any patch release? We are using mySQL database. Kunjal On Jan 28, 2:46 pm, Christian Hammond wrote: > So, they click Ship It, publish the review, and you see the review with the > Ship It but you don't see that on the dashboard? > > This sounds like the code for bumping up the Ship It counter > (ReviewRequest.increment_ship_it in reviewboard/reviews/models.py) is not > working correctly. What database are you using? > > The last login time should be fine. I believe that's just storing when they > actually performed the login, and the cookie has kept him logged in ever > since. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Thu, Jan 28, 2010 at 9:38 AM, Kunjal wrote: > > Hello, > > > For one of our user, he does have active account and when he approves > > the review, the ship it counter is still zero. > > Why this is happening? > > > When I debug this, I found that the user did logged in RB today but in > > the Submitters list, it is showing his last login as 2009-12-17. > > > Is this causing issue? Where should I debug for this? > > > Kunjal > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Integration with GIT
Any update on this issue? On Jan 26, 1:14 pm, Kunjal wrote: > git version 1.6.0.4 > > On Jan 26, 11:39 am, Christian Hammond wrote: > > > > > Git, not Review Board. > > > Christian > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.reviewboard.org > > VMware, Inc. -http://www.vmware.com > > > On Tue, Jan 26, 2010 at 9:55 AM, Kunjal wrote: > > > I am using 1.0.5.1 > > > > On Jan 25, 3:12 pm, Christian Hammond wrote: > > > > What version of Git are you using? > > > > > Christian > > > > > -- > > > > Christian Hammond - chip...@chipx86.com > > > > Review Board -http://www.reviewboard.org > > > > VMware, Inc. -http://www.vmware.com > > > > > On Mon, Jan 25, 2010 at 10:13 AM, Kunjal > > > wrote: > > > > > I just try to post the review. > > > > > > my git branch -a shows: > > > > > git branch -a > > > > > donut > > > > > * kunjal > > > > > > postreview.py --parent=origin/donut > > > > > Failed to execute command: ['git', 'diff', '--no-color', '--full- > > > > > index', 'master'] > > > > > fatal: ambiguous argument 'master': unknown revision or path not in > > > > > the working tree. > > > > > Use '--' to separate paths from revisions > > > > > > On Jan 25, 9:48 am, Kunjal wrote: > > > > > > Thanks a lot. > > > > > > > One question... > > > > > > > In the Add repository dialog, I have provided repository path as > > > > > > git://mobcom-git.sj.broadcom.com/git_repos. Is that correct? > > > > > > > We have our all repositories stored at /projects/xxx/xxx/git_repos. > > > > > > > Also, on the local workspace, user must do --> git config > > > > > > reviewboard.urlhttp://reviewboard.example.com > > > > > > This could be part of .cshrc file so every user does not have to do > > > it > > > > > > all the time. > > > > > > > After I do 2 above steps, am I ready to post-review or some more > > > > > > config is needed? I am using nigthlies as of Jan25. > > > > > > > Kunjal > > > > > > > On Jan 24, 5:20 pm, Christian Hammond wrote: > > > > > > > > Hi, > > > > > > > > Git support in Review Board 1.1 (soon to be renamed 1.5) is much > > > better > > > > > than > > > > > > > in 1.0.x. Git has no concept of checking out individual files from > > > a > > > > > remote > > > > > > > repository, so in 1.0.x, you need to make sure that you have a > > > > > repository on > > > > > > > a filesystem accessible from the Review Board server and it needs > > > to be > > > > > > > constantly up-to-date with a master repository. > > > > > > > > In 1.5, if you have a web-based repository viewer set up for your > > > Git > > > > > > > repository (such as cgit, gitweb, GitHub, etc.) then you can > > > specify a > > > > > path > > > > > > > to a "raw file" URL that provides a raw checkout of the file based > > > on > > > > > > > revision and filename. Review Board will use this to grab the > > > > > > > files > > > > > instead > > > > > > > of needing a local checkout. It's much easier to maintain, and > > > we're > > > > > going > > > > > > > to recommend this route going forward. > > > > > > > > As for post-review, it's had Git support for a long time. I > > > > > > > imagine > > > > > your > > > > > > > copy is just out of date. The class should be named "GitClient." > > > The > > > > > > > nightles are preferred for Git, though, as there's a number of > > > > > important > > > > > > > fixes for determining parent branches. I plan to cut a release > > > soon. > > > > > > > > To run post-review with Git, you can just type `post-review` and > > > > > > > it > > > > > will > > > > > > > generate
Re: ReviewBoard Error while posting review for GIT
Here is what I did. 1. I did download RB Tools nightly ( RBTools-0.2beta3.dev-20100125 ) in to my windows machine. 2. I modify REVIEWBOARD_URL in post-review.py. That is the all change I did. 3. I copy post.review.py to linux box. ( I am not sure whether complete RB Tools needs install or only copy of post-review.py from RB Tools is necessary) 4. I clone the git repository. 5. I configure new repo. in RB Web Admin. (Repository Path = git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git/) 6. I perform command git config reviewboard.url http://mob-rb-test.sj.broadcom.com in the git repository. 7. post-review.py --parent=donut (vendor.git does have donut branch) -- > This does not work. It gives host path may be invalid error. Also the post-review script is looking at by default to master branch only and complains that it can not perform git diff. 8 I also try post-review.py --server=http://mob-rb- test.sj.broadcom.com and the same thing. What wrong I am doing here? Kunjal On Jan 27, 2:19 pm, Christian Hammond wrote: > I've tried to reproduce this in my version of post-review and I can't. Are > you running a fully upstream version of RBTools now, or is it at all custom? > > Also, what version of Python are you running? > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Wed, Jan 27, 2010 at 2:12 PM, Kunjal wrote: > > Any pointers? > > > On Jan 26, 9:55 am, Kunjal wrote: > > > Here is my config looks like: > > > > [core] > > > repositoryformatversion = 0 > > > filemode = true > > > bare = false > > > logallrefupdates = true > > > [remote "origin"] > > > url = git:// > > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git > > > fetch = +refs/heads/*:refs/remotes/origin/* > > > [branch "donut"] > > > remote = origin > > > merge = refs/heads/donut > > > [reviewboard] > > > url =http://mob-rb-test.sj.broadcom.com > > > > I also try alternative config as: > > > > [core] > > > repositoryformatversion = 0 > > > filemode = true > > > bare = false > > > logallrefupdates = true > > > [remote "origin"] > > > url = git:// > > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git > > > fetch = +refs/heads/*:refs/remotes/origin/* > > > [branch "donut"] > > > remote = origin > > > merge = refs/heads/donut > > > > But same result. > > > > On Jan 25, 5:27 pm, Christian Hammond wrote: > > > > > Hmm, that doesn't look good. What does the Git config look like? > > > > > Christian > > > > > -- > > > > Christian Hammond - chip...@chipx86.com > > > > Review Board -http://www.reviewboard.org > > > > VMware, Inc. -http://www.vmware.com > > > > > On Mon, Jan 25, 2010 at 11:07 AM, Kunjal > > wrote: > > > > > Hello, > > > > > > When I post-review for GIT, I am getting below error. > > > > > > somehow the host path is listing ReviewBoard URL two times as you can > > > > > see below. > > > > > How to fix this? > > > > > > Unable to access > > >http://mob-rb-test.sj.broadcom.com/mob-rb-test.sj.broadcom.com/api/js... > > > > > . > > > > > The host path may be invalid > > > > > HTTP Error 404: Not Found > > > > > > -- > > > > > Want to help the Review Board project? Donate today at > > > > >http://www.reviewboard.org/donate/ > > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > > > -~--~~~~--~~--~--~--- > > > > > To unsubscribe from this group, send email to > > > > > reviewboard+unsubscr...@googlegroups.com > > > > > > > For more options, visit this group at > > > > >http://groups.google.com/group/reviewboard?hl=en-Hidequoted text - > > > > > - Show quoted text -- Hide quoted text - > > > > - Show quoted text - > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB Security Concern
I could configure it with HTTPS. I can click on all the links etc. but I got error when I click on View Diff. Some python access denined error. Here is the complete error message: [Errno 13] Permission denied Traceback (most recent call last): File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ views.py", line 153, in view_diff interdiffset, highlighting, True) File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 623, in get_diff_files large_data=True) File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/Djblets-0.5.5-py2.5.egg/djblets/util/misc.py", line 162, in cache_memoize data = lookup_callable() File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 622, in enable_syntax_highlighting), File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 344, in get_chunks old = get_original_file(filediff) File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 251, in get_original_file large_data=True)[0] File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/Djblets-0.5.5-py2.5.egg/djblets/util/misc.py", line 162, in cache_memoize data = lookup_callable() File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 250, in data = cache_memoize(key, lambda: [fetch_file(file, revision)], File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 229, in fetch_file data = tool.get_file(file, revision) File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/ perforce.py", line 88, in get_file p = subprocess.Popen(cmdline, stdout=subprocess.PIPE, stderr=subprocess.PIPE) File "/opt/lampp/lib/python2.5/subprocess.py", line 594, in __init__ errread, errwrite) File "/opt/lampp/lib/python2.5/subprocess.py", line 1091, in _execute_child raise child_exception OSError: [Errno 13] Permission deni On Jan 28, 8:54 am, HT wrote: > Does post-review support HTTPS? > > On Jan 27, 11:34 am, Kunjal wrote: > > > > > Thanks. I have configured RB with HTTPS now. > > > On Jan 26, 11:28 am, Christian Hammond wrote: > > > > You can put the entire site on HTTPS if you want. Review Board doesn't > > > limit > > > you to HTTP or HTTPS. Set the correct URL in your admin settings, and if > > > necessary set up Apache to redirect automatically to the HTTPS URL. > > > > Christian > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > On Tue, Jan 26, 2010 at 9:56 AM, Kunjal wrote: > > > > Hello, > > > > > We have enabled RB with Active Directory. > > > > > I can see that ReviewBoard uses http to login, and not https. I am no > > > > expert in these matters, but according to my old knowledge this means > > > > that the username and password is being sent in clear text on Broadcom > > > > intranet. > > > > > This seems a bit unsafe to me, especially considering that we now use > > > > windows passwords. > > > > > Is this how RB works? Is there a work around? > > > > > Kunjal > > > > > -- > > > > Want to help the Review Board project? Donate today at > > > >http://www.reviewboard.org/donate/ > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > > -~--~~~~--~~--~--~--- > > > > To unsubscribe from this group, send email to > > > > reviewboard+unsubscr...@googlegroups.com > > > > For more options, visit this group at > > > >http://groups.google.com/group/reviewboard?hl=en-Hidequoted text - > > > > - Show quoted text -- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
SHIP IT countre is zero even if reviewer clicks ship it.
Hello, For one of our user, he does have active account and when he approves the review, the ship it counter is still zero. Why this is happening? When I debug this, I found that the user did logged in RB today but in the Submitters list, it is showing his last login as 2009-12-17. Is this causing issue? Where should I debug for this? Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Error while posting review for GIT
Any pointers? On Jan 26, 9:55 am, Kunjal wrote: > Here is my config looks like: > > [core] > repositoryformatversion = 0 > filemode = true > bare = false > logallrefupdates = true > [remote "origin"] > url = > git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git > fetch = +refs/heads/*:refs/remotes/origin/* > [branch "donut"] > remote = origin > merge = refs/heads/donut > [reviewboard] > url =http://mob-rb-test.sj.broadcom.com > > I also try alternative config as: > > [core] > repositoryformatversion = 0 > filemode = true > bare = false > logallrefupdates = true > [remote "origin"] > url = > git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git > fetch = +refs/heads/*:refs/remotes/origin/* > [branch "donut"] > remote = origin > merge = refs/heads/donut > > But same result. > > On Jan 25, 5:27 pm, Christian Hammond wrote: > > > > > Hmm, that doesn't look good. What does the Git config look like? > > > Christian > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.reviewboard.org > > VMware, Inc. -http://www.vmware.com > > > On Mon, Jan 25, 2010 at 11:07 AM, Kunjal wrote: > > > Hello, > > > > When I post-review for GIT, I am getting below error. > > > > somehow the host path is listing ReviewBoard URL two times as you can > > > see below. > > > How to fix this? > > > > Unable to access > > >http://mob-rb-test.sj.broadcom.com/mob-rb-test.sj.broadcom.com/api/js... > > > . > > > The host path may be invalid > > > HTTP Error 404: Not Found > > > > -- > > > Want to help the Review Board project? Donate today at > > >http://www.reviewboard.org/donate/ > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > -~--~~~~--~~--~--~--- > > > To unsubscribe from this group, send email to > > > reviewboard+unsubscr...@googlegroups.com > > > For more options, visit this group at > > >http://groups.google.com/group/reviewboard?hl=en-Hide quoted text - > > > - Show quoted text -- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB Security Concern
Thanks. I have configured RB with HTTPS now. On Jan 26, 11:28 am, Christian Hammond wrote: > You can put the entire site on HTTPS if you want. Review Board doesn't limit > you to HTTP or HTTPS. Set the correct URL in your admin settings, and if > necessary set up Apache to redirect automatically to the HTTPS URL. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Tue, Jan 26, 2010 at 9:56 AM, Kunjal wrote: > > Hello, > > > We have enabled RB with Active Directory. > > > I can see that ReviewBoard uses http to login, and not https. I am no > > expert in these matters, but according to my old knowledge this means > > that the username and password is being sent in clear text on Broadcom > > intranet. > > > This seems a bit unsafe to me, especially considering that we now use > > windows passwords. > > > Is this how RB works? Is there a work around? > > > Kunjal > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Post review with combination of binary + txt file does not work
Hello Chris, With RB 1.0.5.1, when someone post the review with 1 binary file + 1 txt file, RB should filter out the binary file but txt file should be able to get reviewed in RB. We are getting below message when the user look at the RB web after posting review. When I test RB, I could post review with few binary files + few text file and it filter out binary files correctly. Why this issue re-surfacing now? Does it depend on type of file? The files we have are called .spr file and they are marked as BINARY in perforce. The patch to 'C:/Builds/Mobcom/sysDev/21331/MMI_2/msp/stack/hedge/sdt/ usimap.spr' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.GAdWou' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.GAdWou/tmp4nYJKO Hunk #1 succeeded at 4297 (offset 187 lines). Hunk #2 succeeded at 4367 (offset 2 lines). Hunk #3 succeeded at 9821 (offset 335 lines). Hunk #4 succeeded at 9538 (offset 2 lines). Hunk #5 succeeded at 16413 (offset 608 lines). Hunk #6 succeeded at 17689 (offset 147 lines). Hunk #7 succeeded at 21659 (offset 760 lines). Hunk #8 succeeded at 24243 (offset 586 lines). Hunk #9 succeeded at 25320 (offset 809 lines). Hunk #10 succeeded at 25777 (offset 625 lines). patch: malformed patch at line 171: ]]][ Traceback (most recent call last): File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ views.py", line 153, in view_diff interdiffset, highlighting, True) File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 623, in get_diff_files large_data=True) File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/Djblets-0.5.6-py2.5.egg/djblets/util/misc.py", line 162, in cache_memoize data = lookup_callable() File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 622, in enable_syntax_highlighting), File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 345, in get_chunks new = get_patched_file(old, filediff) File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 129, in patch (filename, tempdir, patch_output)) Exception: The patch to 'C:/Builds/Mobcom/sysDev/21331/MMI_2/msp/stack/ hedge/sdt/usimap.spr' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.GAdWou' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.GAdWou/tmp4nYJKO Hunk #1 succeeded at 4297 (offset 187 lines). Hunk #2 succeeded at 4367 (offset 2 lines). Hunk #3 succeeded at 9821 (offset 335 lines). Hunk #4 succeeded at 9538 (offset 2 lines). Hunk #5 succeeded at 16413 (offset 608 lines). Hunk #6 succeeded at 17689 (offset 147 lines). Hunk #7 succeeded at 21659 (offset 760 lines). Hunk #8 succeeded at 24243 (offset 586 lines). Hunk #9 succeeded at 25320 (offset 809 lines). Hunk #10 succeeded at 25777 (offset 625 lines). patch: malformed patch at line 171: ]]][ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Integration with GIT
git version 1.6.0.4 On Jan 26, 11:39 am, Christian Hammond wrote: > Git, not Review Board. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Tue, Jan 26, 2010 at 9:55 AM, Kunjal wrote: > > I am using 1.0.5.1 > > > On Jan 25, 3:12 pm, Christian Hammond wrote: > > > What version of Git are you using? > > > > Christian > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > On Mon, Jan 25, 2010 at 10:13 AM, Kunjal > > wrote: > > > > I just try to post the review. > > > > > my git branch -a shows: > > > > git branch -a > > > > donut > > > > * kunjal > > > > > postreview.py --parent=origin/donut > > > > Failed to execute command: ['git', 'diff', '--no-color', '--full- > > > > index', 'master'] > > > > fatal: ambiguous argument 'master': unknown revision or path not in > > > > the working tree. > > > > Use '--' to separate paths from revisions > > > > > On Jan 25, 9:48 am, Kunjal wrote: > > > > > Thanks a lot. > > > > > > One question... > > > > > > In the Add repository dialog, I have provided repository path as > > > > > git://mobcom-git.sj.broadcom.com/git_repos. Is that correct? > > > > > > We have our all repositories stored at /projects/xxx/xxx/git_repos. > > > > > > Also, on the local workspace, user must do --> git config > > > > > reviewboard.urlhttp://reviewboard.example.com > > > > > This could be part of .cshrc file so every user does not have to do > > it > > > > > all the time. > > > > > > After I do 2 above steps, am I ready to post-review or some more > > > > > config is needed? I am using nigthlies as of Jan25. > > > > > > Kunjal > > > > > > On Jan 24, 5:20 pm, Christian Hammond wrote: > > > > > > > Hi, > > > > > > > Git support in Review Board 1.1 (soon to be renamed 1.5) is much > > better > > > > than > > > > > > in 1.0.x. Git has no concept of checking out individual files from > > a > > > > remote > > > > > > repository, so in 1.0.x, you need to make sure that you have a > > > > repository on > > > > > > a filesystem accessible from the Review Board server and it needs > > to be > > > > > > constantly up-to-date with a master repository. > > > > > > > In 1.5, if you have a web-based repository viewer set up for your > > Git > > > > > > repository (such as cgit, gitweb, GitHub, etc.) then you can > > specify a > > > > path > > > > > > to a "raw file" URL that provides a raw checkout of the file based > > on > > > > > > revision and filename. Review Board will use this to grab the files > > > > instead > > > > > > of needing a local checkout. It's much easier to maintain, and > > we're > > > > going > > > > > > to recommend this route going forward. > > > > > > > As for post-review, it's had Git support for a long time. I imagine > > > > your > > > > > > copy is just out of date. The class should be named "GitClient." > > The > > > > > > nightles are preferred for Git, though, as there's a number of > > > > important > > > > > > fixes for determining parent branches. I plan to cut a release > > soon. > > > > > > > To run post-review with Git, you can just type `post-review` and it > > > > will > > > > > > generate a diff from the origin to HEAD. If you specify > > > > > > --parent= then it will generate from branchname to > > HEAD. > > > > > > > Christian > > > > > > > -- > > > > > > Christian Hammond - chip...@chipx86.com > > > > > > Review Board -http://www.reviewboard.org > > > > > > VMware, Inc. -http://www.vmware.com > > > > > > > On Sun, Jan 24, 2010 at 5:11 PM, Kunjal > > > > wrote: > > > > > > > Last ques
RB Security Concern
Hello, We have enabled RB with Active Directory. I can see that ReviewBoard uses http to login, and not https. I am no expert in these matters, but according to my old knowledge this means that the username and password is being sent in clear text on Broadcom intranet. This seems a bit unsafe to me, especially considering that we now use windows passwords. Is this how RB works? Is there a work around? Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Integration with GIT
I am using 1.0.5.1 On Jan 25, 3:12 pm, Christian Hammond wrote: > What version of Git are you using? > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Mon, Jan 25, 2010 at 10:13 AM, Kunjal wrote: > > I just try to post the review. > > > my git branch -a shows: > > git branch -a > > donut > > * kunjal > > > postreview.py --parent=origin/donut > > Failed to execute command: ['git', 'diff', '--no-color', '--full- > > index', 'master'] > > fatal: ambiguous argument 'master': unknown revision or path not in > > the working tree. > > Use '--' to separate paths from revisions > > > On Jan 25, 9:48 am, Kunjal wrote: > > > Thanks a lot. > > > > One question... > > > > In the Add repository dialog, I have provided repository path as > > > git://mobcom-git.sj.broadcom.com/git_repos. Is that correct? > > > > We have our all repositories stored at /projects/xxx/xxx/git_repos. > > > > Also, on the local workspace, user must do --> git config > > > reviewboard.urlhttp://reviewboard.example.com > > > This could be part of .cshrc file so every user does not have to do it > > > all the time. > > > > After I do 2 above steps, am I ready to post-review or some more > > > config is needed? I am using nigthlies as of Jan25. > > > > Kunjal > > > > On Jan 24, 5:20 pm, Christian Hammond wrote: > > > > > Hi, > > > > > Git support in Review Board 1.1 (soon to be renamed 1.5) is much better > > than > > > > in 1.0.x. Git has no concept of checking out individual files from a > > remote > > > > repository, so in 1.0.x, you need to make sure that you have a > > repository on > > > > a filesystem accessible from the Review Board server and it needs to be > > > > constantly up-to-date with a master repository. > > > > > In 1.5, if you have a web-based repository viewer set up for your Git > > > > repository (such as cgit, gitweb, GitHub, etc.) then you can specify a > > path > > > > to a "raw file" URL that provides a raw checkout of the file based on > > > > revision and filename. Review Board will use this to grab the files > > instead > > > > of needing a local checkout. It's much easier to maintain, and we're > > going > > > > to recommend this route going forward. > > > > > As for post-review, it's had Git support for a long time. I imagine > > your > > > > copy is just out of date. The class should be named "GitClient." The > > > > nightles are preferred for Git, though, as there's a number of > > important > > > > fixes for determining parent branches. I plan to cut a release soon. > > > > > To run post-review with Git, you can just type `post-review` and it > > will > > > > generate a diff from the origin to HEAD. If you specify > > > > --parent= then it will generate from branchname to HEAD. > > > > > Christian > > > > > -- > > > > Christian Hammond - chip...@chipx86.com > > > > Review Board -http://www.reviewboard.org > > > > VMware, Inc. -http://www.vmware.com > > > > > On Sun, Jan 24, 2010 at 5:11 PM, Kunjal > > wrote: > > > > > Last question... > > > > > > Does the GIT support available in RB 1.0.5 or I have to move to RB > > 1.1 > > > > > Alpha 2? > > > > > Sorry for all these questions. > > > > > > On Jan 24, 12:04 pm, Kunjal wrote: > > > > > > One more thing... > > > > > > The post-review script we have has the class called PerforceClient > > > > > > which gets the repository info. and creates diff. > > > > > > I do not see any class for GITClient. > > > > > > Do I need to create such class on my own? > > > > > > > Thanks > > > > > > Kunjal > > > > > > > On Jan 23, 11:10 am, Kunjal wrote: > > > > > > > > Hello Chris, > > > > > > > > We do have RB-Perforce integration working perfect! > > > > > > > We want RB-GIT integration as well. > > > > > > > > Here are the steps I can think of. Can you evaluate it? > > > > > > > > 1. A
Re: ReviewBoard Error while posting review for GIT
Here is my config looks like: [core] repositoryformatversion = 0 filemode = true bare = false logallrefupdates = true [remote "origin"] url = git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git fetch = +refs/heads/*:refs/remotes/origin/* [branch "donut"] remote = origin merge = refs/heads/donut [reviewboard] url = http://mob-rb-test.sj.broadcom.com I also try alternative config as: [core] repositoryformatversion = 0 filemode = true bare = false logallrefupdates = true [remote "origin"] url = git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git fetch = +refs/heads/*:refs/remotes/origin/* [branch "donut"] remote = origin merge = refs/heads/donut But same result. On Jan 25, 5:27 pm, Christian Hammond wrote: > Hmm, that doesn't look good. What does the Git config look like? > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Mon, Jan 25, 2010 at 11:07 AM, Kunjal wrote: > > Hello, > > > When I post-review for GIT, I am getting below error. > > > somehow the host path is listing ReviewBoard URL two times as you can > > see below. > > How to fix this? > > > Unable to access > >http://mob-rb-test.sj.broadcom.com/mob-rb-test.sj.broadcom.com/api/js... > > . > > The host path may be invalid > > HTTP Error 404: Not Found > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Integration with GIT
Last question... Does the GIT support available in RB 1.0.5 or I have to move to RB 1.1 Alpha 2? Sorry for all these questions. On Jan 24, 12:04 pm, Kunjal wrote: > One more thing... > The post-review script we have has the class called PerforceClient > which gets the repository info. and creates diff. > I do not see any class for GITClient. > Do I need to create such class on my own? > > Thanks > Kunjal > > On Jan 23, 11:10 am, Kunjal wrote: > > > > > Hello Chris, > > > We do have RB-Perforce integration working perfect! > > We want RB-GIT integration as well. > > > Here are the steps I can think of. Can you evaluate it? > > > 1. Add new repository for GIT in RB. > > 2. Install RB tools in Linux machines. We do have our own version of > > post-review. can we just replace it? > > 3. what are the commands to be used to post review? For perforce, we > > are using post-review.exe 234545 > > For GIT, I have to give latest commit number? post-review 0er545455 ? > > 4. Any other things I need to take care. > > > Thanks for your help. > > > Kunjal- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Integration with GIT
One more thing... The post-review script we have has the class called PerforceClient which gets the repository info. and creates diff. I do not see any class for GITClient. Do I need to create such class on my own? Thanks Kunjal On Jan 23, 11:10 am, Kunjal wrote: > Hello Chris, > > We do have RB-Perforce integration working perfect! > We want RB-GIT integration as well. > > Here are the steps I can think of. Can you evaluate it? > > 1. Add new repository for GIT in RB. > 2. Install RB tools in Linux machines. We do have our own version of > post-review. can we just replace it? > 3. what are the commands to be used to post review? For perforce, we > are using post-review.exe 234545 > For GIT, I have to give latest commit number? post-review 0er545455 ? > 4. Any other things I need to take care. > > Thanks for your help. > > Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Enable search in RB 1.0.5.
Hello,
We want to enable search in RB. We are having issues.
I've finally built java6,ANT,jcc,and pylucerne and I can see that I
can enable the search function with /opt/lampp/htdocs/reviewboard/
search-index where index files will reside:
I get the following errors when doing a full index:
#[r...@mob-rb-test reviewboard]# rb-site manage /opt/lampp/htdocs/
reviewboard index -- --full
Traceback (most recent call last):
File "/opt/lampp/bin/rb-site", line 8, in
load_entry_point('ReviewBoard==1.0.5.1', 'console_scripts', 'rb-
site')()
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/cmdline/rbsite.py",
line 1478, in main
command.run()
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/cmdline/rbsite.py",
line 1412, in run
site.run_manage_command(args[0], args[1:])
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/cmdline/rbsite.py",
line 352, in run_manage_command
execute_manager(reviewboard.settings, [__file__, cmd] + params)
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/core/management/__init__.py",
line 362, in execute_manager
utility.execute()
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/core/management/__init__.py",
line 303, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/core/management/base.py", line
195, in run_from_argv
self.execute(*args, **options.__dict__)
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/core/management/base.py", line
222, in execute
output = self.handle(*args, **options)
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/core/management/base.py", line
351, in handle
return self.handle_noargs(**options)
File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/reviews/management/
commands/index.py", line 68, in handle_noargs
store = lucene.FSDirectory.getDirectory(store_dir, False)
AttributeError: type object 'FSDirectory' has no attribute
'getDirectory'
Any idea?
Thanks
Kunjal
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
UnicodeDecodeError when posting review.
Hello Chris, With your great help we could release RB 1.0.5 to 300 + developers and it is working quite well. Suddenly from yesterday, some of the users (3 of them) are seeing below errors when they post the review. Do you know what can cause such errors? Traceback (most recent call last): File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/Django-1.1.1-py2.5.egg/django/core/handlers/base.py", line 92, in get_response response = callback(request, *callback_args, **callback_kwargs) File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/Django-1.1.1-py2.5.egg/django/views/decorators/ cache.py", line 45, in _wrapped_view_func add_never_cache_headers(response) File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/Django-1.1.1-py2.5.egg/django/utils/cache.py", line 119, in add_never_cache_headers patch_response_headers(response, cache_timeout=-1) File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/Django-1.1.1-py2.5.egg/django/utils/cache.py", line 108, in patch_response_headers response['ETag'] = '"%s"' % md5_constructor (response.content).hexdigest() File "/projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/Djblets-0.5.6-py2.5.egg/djblets/webapi/core.py", line 264, in _get_content content = adapter.encode(self.api_data) File "build/bdist.linux-i686/egg/simplejson/encoder.py", line 200, in encode chunks = self.iterencode(o, _one_shot=True) File "build/bdist.linux-i686/egg/simplejson/encoder.py", line 260, in iterencode return _iterencode(o, 0) UnicodeDecodeError: 'utf8' codec can't decode byte 0x93 in position 277: unexpected code byte -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Can not Upload Diff using RB 1.0.5.1
Chris,
I have not tried that. Will try that as well.
But the issue is it works ok on RB 1.0.5 on test server and does not
work on RB 1.0.5 on production server.
So, something is missing between settings of these two servers and not
sure what is missing...
Any clue?
On Dec 9, 4:32 pm, Christian Hammond wrote:
> What happens if you upload this same diff through the web UI? Do you see any
> additional error information?
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Tue, Dec 8, 2009 at 3:44 PM, Kunjal wrote:
> > sorry,
>
> > here is the missing error message...
>
> > >>> Uploading diff
> > >>> HTTP POSTing to
> >http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/di
> > ff/new/<http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/di%0Aff/new/>:
> > {}
> > Error uploading diff: One or more fields had errors (105)
> > Your review request still exists, but the diff is not attached.
>
> > On Dec 8, 12:19 pm, Christian Hammond wrote:
> > > I don't see any error in here. That line indicates that we're doing an
> > HTTP
> > > POST to that URL but aren't sending any fields, which is correct. The
> > files
> > > are likely sent, but we don't log that on the console.
>
> > > Does it just stop after that? Is there error information I'm just not
> > > seeing?
>
> > > Christian
>
> > > --
> > > Christian Hammond - chip...@chipx86.com
> > > Review Board -http://www.reviewboard.org
> > > VMware, Inc. -http://www.vmware.com
>
> > > On Tue, Dec 8, 2009 at 10:47 AM, Kunjal wrote:
>
> > > > Chris,
>
> > > > We have now set up production server which will released in few days.
> > > > During my final testing I found that when I post review, I can not
> > > > post the diff. Looks like RB-Perforce integration issue.
> > > > I read few blogs and you said that P4 should be in web server's path.
> > > > However, I check httpd.conf and I do not see any P4 specific
> > > > settings.
> > > > Where else I can debug?
>
> > > > Here is the error...
>
> > > > >>> Uploading diff
> > > > >>> HTTP POSTing to
> > > >http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/di
> > > > ff/new/<
> >http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/di%0Aff/new/>:
> > > > {}
>
> > > > -Kunjal
>
> > > > kapar...@ltsdo-kaparikh ~
> > > > $ post-review.cygwin 250188 -d
>
> > > > This tool looks at the given Pending-CL# & posts it for review.
> > > > [Version: 200911
> > > > 13_1141]
>
> > > > >>> Repository info 'Path: pf-sj1-mob.sj.broadcom.com:1668, Base path:
> > > > None, Sup
> > > > ports changesets: True'
> > > > >>> Generating diff for changenum 250188
> > > > >>> P4CLIENT is LTSDO-KAPARIKH
> > > > >>> status is pending
> > > > >>> Lines are:
> > > > ['//depot/Sources/Integration/Automation_Scripts/1DDR_Test_Reques
> > > > t_Script/1DDR_TestRequest.pl#1 - edit change 250188 (text) by
> > > > kapar...@ltsdo-kap
> > > > ARIKH\r\n']
> > > > >>> Client LTSDO-KAPARIKH depot path
> > > > //depot/Sources/Integration/Automation_Scri
> > > > pts/1DDR_Test_Request_Script/1DDR_TestRequest.pl
> > > > >>> Writing
> > > > "//depot/Sources/Integration/Automation_Scripts/1DDR_Test_Request_Sc
> > > > ript/1DDR_TestRequest.pl#1" to "/cygdrive/c/Temp/tmpBiyySU"
> > > > >>> Old file: /cygdrive/c/Temp/tmpBiyySU New file
> > > > c:/Perforce/Sources/Integratio
> > > > n/Automation_Scripts/1DDR_Test_Request_Script/1DDR_TestRequest.pl
> > > > >>> Attempting to create review request for 250188
> > > > repository path pf-sj1-mob.sj.broadcom.com:1668
> > > > >>> HTTP POSTing to
> > > >http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/new/
> > > > : {'repository_path': 'pf-sj1-mob.sj.broadcom.com:1668', 'changenum':
> > > > '250188'}
> > > > >>> Review request already exists. Updating it...
> > > > >>> HTTP POSTing to
> > > >http://rb-sj1
Re: Can not Upload Diff using RB 1.0.5.1
Chris,
Do you have any update?
I am really stuck now...
Kunjal
On Dec 8, 3:44 pm, Kunjal wrote:
> sorry,
>
> here is the missing error message...
>
> >>> Uploading diff
> >>> HTTP POSTing
> >>> tohttp://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/di
>
> ff/new/: {}
> Error uploading diff: One or more fields had errors (105)
> Your review request still exists, but the diff is not attached.
>
> On Dec 8, 12:19 pm, Christian Hammond wrote:
>
>
>
> > I don't see any error in here. That line indicates that we're doing an HTTP
> > POST to that URL but aren't sending any fields, which is correct. The files
> > are likely sent, but we don't log that on the console.
>
> > Does it just stop after that? Is there error information I'm just not
> > seeing?
>
> > Christian
>
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.reviewboard.org
> > VMware, Inc. -http://www.vmware.com
>
> > On Tue, Dec 8, 2009 at 10:47 AM, Kunjal wrote:
>
> > > Chris,
>
> > > We have now set up production server which will released in few days.
> > > During my final testing I found that when I post review, I can not
> > > post the diff. Looks like RB-Perforce integration issue.
> > > I read few blogs and you said that P4 should be in web server's path.
> > > However, I check httpd.conf and I do not see any P4 specific
> > > settings.
> > > Where else I can debug?
>
> > > Here is the error...
>
> > > >>> Uploading diff
> > > >>> HTTP POSTing to
> > >http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/di
> > > ff/new/<http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/di%0Aff/new/>:
> > > {}
>
> > > -Kunjal
>
> > > kapar...@ltsdo-kaparikh ~
> > > $ post-review.cygwin 250188 -d
>
> > > This tool looks at the given Pending-CL# & posts it for review.
> > > [Version: 200911
> > > 13_1141]
>
> > > >>> Repository info 'Path: pf-sj1-mob.sj.broadcom.com:1668, Base path:
> > > None, Sup
> > > ports changesets: True'
> > > >>> Generating diff for changenum 250188
> > > >>> P4CLIENT is LTSDO-KAPARIKH
> > > >>> status is pending
> > > >>> Lines are:
> > > ['//depot/Sources/Integration/Automation_Scripts/1DDR_Test_Reques
> > > t_Script/1DDR_TestRequest.pl#1 - edit change 250188 (text) by
> > > kapar...@ltsdo-kap
> > > ARIKH\r\n']
> > > >>> Client LTSDO-KAPARIKH depot path
> > > //depot/Sources/Integration/Automation_Scri
> > > pts/1DDR_Test_Request_Script/1DDR_TestRequest.pl
> > > >>> Writing
> > > "//depot/Sources/Integration/Automation_Scripts/1DDR_Test_Request_Sc
> > > ript/1DDR_TestRequest.pl#1" to "/cygdrive/c/Temp/tmpBiyySU"
> > > >>> Old file: /cygdrive/c/Temp/tmpBiyySU New file
> > > c:/Perforce/Sources/Integratio
> > > n/Automation_Scripts/1DDR_Test_Request_Script/1DDR_TestRequest.pl
> > > >>> Attempting to create review request for 250188
> > > repository path pf-sj1-mob.sj.broadcom.com:1668
> > > >>> HTTP POSTing to
> > >http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/new/
> > > : {'repository_path': 'pf-sj1-mob.sj.broadcom.com:1668', 'changenum':
> > > '250188'}
> > > >>> Review request already exists. Updating it...
> > > >>> HTTP POSTing to
> > >http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/up
> > > date_from_changenum/<http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/up%0Adate_f...>:
> > > {}
> > > >>> Review request created
> > > >>> ---
> > > c:\Perforce\Sources\Integration\Automation_Scripts\1DDR_Test_Request_Scr
> > > ipt\1DDR_TestRequest.pl //depot/Sources/Integration/Automation_Scripts/
> > > 1DDR_Test
> > > _Request_Script/1DDR_TestRequest.pl#1
> > > +++ c:\Perforce\Sources\Integration\Automation_Scripts
> > > \1DDR_Test_Request_Script\
> > > 1DDR_TestRequest.pl 2009-12-08 10:23:30
> > > @@ -12,6 +12,20 @@
> > > use MIME::Lite;
> > > use CGI qw/:standard/;
> > > use File::Basename;
> > > +#!/usr/bin/perl
>
> > > +#--
>
> >
Re: Can not Upload Diff using RB 1.0.5.1
sorry,
here is the missing error message...
>>> Uploading diff
>>> HTTP POSTing to http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/di
ff/new/: {}
Error uploading diff: One or more fields had errors (105)
Your review request still exists, but the diff is not attached.
On Dec 8, 12:19 pm, Christian Hammond wrote:
> I don't see any error in here. That line indicates that we're doing an HTTP
> POST to that URL but aren't sending any fields, which is correct. The files
> are likely sent, but we don't log that on the console.
>
> Does it just stop after that? Is there error information I'm just not
> seeing?
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Tue, Dec 8, 2009 at 10:47 AM, Kunjal wrote:
>
> > Chris,
>
> > We have now set up production server which will released in few days.
> > During my final testing I found that when I post review, I can not
> > post the diff. Looks like RB-Perforce integration issue.
> > I read few blogs and you said that P4 should be in web server's path.
> > However, I check httpd.conf and I do not see any P4 specific
> > settings.
> > Where else I can debug?
>
> > Here is the error...
>
> > >>> Uploading diff
> > >>> HTTP POSTing to
> >http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/di
> > ff/new/<http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/di%0Aff/new/>:
> > {}
>
> > -Kunjal
>
> > kapar...@ltsdo-kaparikh ~
> > $ post-review.cygwin 250188 -d
>
> > This tool looks at the given Pending-CL# & posts it for review.
> > [Version: 200911
> > 13_1141]
>
> > >>> Repository info 'Path: pf-sj1-mob.sj.broadcom.com:1668, Base path:
> > None, Sup
> > ports changesets: True'
> > >>> Generating diff for changenum 250188
> > >>> P4CLIENT is LTSDO-KAPARIKH
> > >>> status is pending
> > >>> Lines are:
> > ['//depot/Sources/Integration/Automation_Scripts/1DDR_Test_Reques
> > t_Script/1DDR_TestRequest.pl#1 - edit change 250188 (text) by
> > kapar...@ltsdo-kap
> > ARIKH\r\n']
> > >>> Client LTSDO-KAPARIKH depot path
> > //depot/Sources/Integration/Automation_Scri
> > pts/1DDR_Test_Request_Script/1DDR_TestRequest.pl
> > >>> Writing
> > "//depot/Sources/Integration/Automation_Scripts/1DDR_Test_Request_Sc
> > ript/1DDR_TestRequest.pl#1" to "/cygdrive/c/Temp/tmpBiyySU"
> > >>> Old file: /cygdrive/c/Temp/tmpBiyySU New file
> > c:/Perforce/Sources/Integratio
> > n/Automation_Scripts/1DDR_Test_Request_Script/1DDR_TestRequest.pl
> > >>> Attempting to create review request for 250188
> > repository path pf-sj1-mob.sj.broadcom.com:1668
> > >>> HTTP POSTing to
> >http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/new/
> > : {'repository_path': 'pf-sj1-mob.sj.broadcom.com:1668', 'changenum':
> > '250188'}
> > >>> Review request already exists. Updating it...
> > >>> HTTP POSTing to
> >http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/up
> > date_from_changenum/<http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/up%0Adate_f...>:
> > {}
> > >>> Review request created
> > >>> ---
> > c:\Perforce\Sources\Integration\Automation_Scripts\1DDR_Test_Request_Scr
> > ipt\1DDR_TestRequest.pl //depot/Sources/Integration/Automation_Scripts/
> > 1DDR_Test
> > _Request_Script/1DDR_TestRequest.pl#1
> > +++ c:\Perforce\Sources\Integration\Automation_Scripts
> > \1DDR_Test_Request_Script\
> > 1DDR_TestRequest.pl 2009-12-08 10:23:30
> > @@ -12,6 +12,20 @@
> > use MIME::Lite;
> > use CGI qw/:standard/;
> > use File::Basename;
> > +#!/usr/bin/perl
>
> > +#--
>
> > +#Script Name: 1DDR_TestRequest.pl
> > +#Usage:The script is used to get list of zip files from the latest CL
> > +#from the path "brcm-irv\\dfs\\projects\\mcsi_2ddr\\programname"
> > +#and send the mail notification for the 1DDR Test Request.
> > +#Arguments: The script takes one argument which is the
> > +#Branch/Program name/SDB name.
>
> > +#--
>
> > +#use warnings;
> > +#use strict;
> > +use MIME::Lite;
> >
Can not Upload Diff using RB 1.0.5.1
Chris,
We have now set up production server which will released in few days.
During my final testing I found that when I post review, I can not
post the diff. Looks like RB-Perforce integration issue.
I read few blogs and you said that P4 should be in web server's path.
However, I check httpd.conf and I do not see any P4 specific
settings.
Where else I can debug?
Here is the error...
>>> Uploading diff
>>> HTTP POSTing to http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/di
ff/new/: {}
-Kunjal
kapar...@ltsdo-kaparikh ~
$ post-review.cygwin 250188 -d
This tool looks at the given Pending-CL# & posts it for review.
[Version: 200911
13_1141]
>>> Repository info 'Path: pf-sj1-mob.sj.broadcom.com:1668, Base path: None, Sup
ports changesets: True'
>>> Generating diff for changenum 250188
>>> P4CLIENT is LTSDO-KAPARIKH
>>> status is pending
>>> Lines are: ['//depot/Sources/Integration/Automation_Scripts/1DDR_Test_Reques
t_Script/1DDR_TestRequest.pl#1 - edit change 250188 (text) by
kapar...@ltsdo-kap
ARIKH\r\n']
>>> Client LTSDO-KAPARIKH depot path //depot/Sources/Integration/Automation_Scri
pts/1DDR_Test_Request_Script/1DDR_TestRequest.pl
>>> Writing "//depot/Sources/Integration/Automation_Scripts/1DDR_Test_Request_Sc
ript/1DDR_TestRequest.pl#1" to "/cygdrive/c/Temp/tmpBiyySU"
>>> Old file: /cygdrive/c/Temp/tmpBiyySU New file c:/Perforce/Sources/Integratio
n/Automation_Scripts/1DDR_Test_Request_Script/1DDR_TestRequest.pl
>>> Attempting to create review request for 250188
repository path pf-sj1-mob.sj.broadcom.com:1668
>>> HTTP POSTing to http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/new/
: {'repository_path': 'pf-sj1-mob.sj.broadcom.com:1668', 'changenum':
'250188'}
>>> Review request already exists. Updating it...
>>> HTTP POSTing to http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/up
date_from_changenum/: {}
>>> Review request created
>>> --- c:\Perforce\Sources\Integration\Automation_Scripts\1DDR_Test_Request_Scr
ipt\1DDR_TestRequest.pl //depot/Sources/Integration/Automation_Scripts/
1DDR_Test
_Request_Script/1DDR_TestRequest.pl#1
+++ c:\Perforce\Sources\Integration\Automation_Scripts
\1DDR_Test_Request_Script\
1DDR_TestRequest.pl 2009-12-08 10:23:30
@@ -12,6 +12,20 @@
use MIME::Lite;
use CGI qw/:standard/;
use File::Basename;
+#!/usr/bin/perl
+#--
+#Script Name: 1DDR_TestRequest.pl
+#Usage:The script is used to get list of zip files from the latest CL
+#from the path "brcm-irv\\dfs\\projects\\mcsi_2ddr\\programname"
+#and send the mail notification for the 1DDR Test Request.
+#Arguments: The script takes one argument which is the
+#Branch/Program name/SDB name.
+#--
+#use warnings;
+#use strict;
+use MIME::Lite;
+use CGI qw/:standard/;
+use File::Basename;
use Data::Dumper;
#--
>>> Uploading diff
>>> HTTP POSTing to http://rb-sj1-1.sj.broadcom.com/api/json/reviewrequests/5/di
ff/new/: {}
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Binary Files handling in RB 1.0.5
Thanks..This is dummy question but I can not find post-review script any where on my linux distribution. I search all the files and folder and nothing is there. We definately installed RB tools. Kunjal On Dec 2, 12:41 pm, Christian Hammond wrote: > Hi Kunjal, > > See:http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ > > And the section on nightlies > at:http://www.reviewboard.org/docs/manual/dev/admin/installation/develop... > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Wed, Dec 2, 2009 at 10:42 AM, Kunjal wrote: > > Chris, > > > I think we have not updated post-review for a while. > > Where to find it in RB website? > > Can you point me location? > > > Kunjal > > > On Dec 1, 5:22 pm, Christian Hammond wrote: > > > Tom is right, they should be filtered so long as Perforce has them listed > > as > > > binary files. > > > > How recent is your post-review? I'd recommend trying a nightly and seeing > > if > > > the problem goes away. I seem to recall a corrupt patch issue that was > > fixed > > > when using binary files, which may trigger this. > > > > Christian > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > On Tue, Dec 1, 2009 at 5:16 PM, Kunjal wrote: > > > > The perforce has marked them as binary file. > > > > Why I get error message instead of some standard message saying this > > > > is binary file or similar? > > > > Do I need to install some patch ? > > > > > On Dec 1, 5:04 pm, Tom Sakkos wrote: > > > > > Assuming that the files are marked as Binary files in Perforce, > > > > Review-Board > > > > > should ignore them and properly say something along the lines of > > "Binary > > > > > files differ." > > > > > > -Tom > > > > > > On Tue, Dec 1, 2009 at 6:51 PM, Kunjal > > wrote: > > > > > > Hello, > > > > > > > In our development environment, we have lot of reviews only with > > > > > > Binary files. > > > > > > For example, If I post the review with 4 binary files, what should > > > > > > happen when I click on View Diff? > > > > > > > For now, I just try with one binary file, and I get below message > > when > > > > > > I click on View Diff. > > > > > > > Is there any work-around for binary files? > > > > > > > The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/usim.sbk' > > > > > > didn't apply cleanly. The temporary files have been left in '/tmp/ > > > > > > reviewboard.6SzZlW' for debugging purposes. `patch` returned: > > patching > > > > > > file /tmp/reviewboard.6SzZlW/tmpSst3n_ patch: malformed patch > > at > > > > > > line 21: > > > > > > > Traceback (most recent call last): > > > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > > > > > views.py", line 153, in view_diff > > > > > > interdiffset, highlighting, True) > > > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > > > > > diffutils.py", line 623, in get_diff_files > > > > > > large_data=True) > > > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > > > packages/Djblets-0.5.5-py2.5.egg/djblets/util/misc.py", line 162, > > in > > > > > > cache_memoize > > > > > > data = lookup_callable() > > > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > > > > > diffutils.py", line 622, in > > > > > > enable_syntax_highlighting), > > > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ >
Re: Binary Files handling in RB 1.0.5
Chris, I think we have not updated post-review for a while. Where to find it in RB website? Can you point me location? Kunjal On Dec 1, 5:22 pm, Christian Hammond wrote: > Tom is right, they should be filtered so long as Perforce has them listed as > binary files. > > How recent is your post-review? I'd recommend trying a nightly and seeing if > the problem goes away. I seem to recall a corrupt patch issue that was fixed > when using binary files, which may trigger this. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Tue, Dec 1, 2009 at 5:16 PM, Kunjal wrote: > > The perforce has marked them as binary file. > > Why I get error message instead of some standard message saying this > > is binary file or similar? > > Do I need to install some patch ? > > > On Dec 1, 5:04 pm, Tom Sakkos wrote: > > > Assuming that the files are marked as Binary files in Perforce, > > Review-Board > > > should ignore them and properly say something along the lines of "Binary > > > files differ." > > > > -Tom > > > > On Tue, Dec 1, 2009 at 6:51 PM, Kunjal wrote: > > > > Hello, > > > > > In our development environment, we have lot of reviews only with > > > > Binary files. > > > > For example, If I post the review with 4 binary files, what should > > > > happen when I click on View Diff? > > > > > For now, I just try with one binary file, and I get below message when > > > > I click on View Diff. > > > > > Is there any work-around for binary files? > > > > > The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/usim.sbk' > > > > didn't apply cleanly. The temporary files have been left in '/tmp/ > > > > reviewboard.6SzZlW' for debugging purposes. `patch` returned: patching > > > > file /tmp/reviewboard.6SzZlW/tmpSst3n_ patch: malformed patch at > > > > line 21: > > > > > Traceback (most recent call last): > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > > > views.py", line 153, in view_diff > > > > interdiffset, highlighting, True) > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > > > diffutils.py", line 623, in get_diff_files > > > > large_data=True) > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Djblets-0.5.5-py2.5.egg/djblets/util/misc.py", line 162, in > > > > cache_memoize > > > > data = lookup_callable() > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > > > diffutils.py", line 622, in > > > > enable_syntax_highlighting), > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > > > diffutils.py", line 345, in get_chunks > > > > new = get_patched_file(old, filediff) > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > > > diffutils.py", line 261, in get_patched_file > > > > return patch(filediff.diff, buffer, filediff.dest_file) > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > > > diffutils.py", line 129, in patch > > > > (filename, tempdir, patch_output)) > > > > Exception: The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/ > > > > usim.sbk' didn't apply cleanly. The temporary files have been left in > > > > '/tmp/reviewboard.6SzZlW' for debugging purposes. > > > > `patch` returned: patching file /tmp/reviewboard.6SzZlW/tmpSst3n_ > > > > patch: malformed patch at line 21: > > > > > -- > > > > Want to help the Review Board project? Donate today at > > > >http://www.reviewboard.org/donate/ > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ >
RB and Browser Compatibilty.
We are on verge of rolling out RB 1.0.5 to 300+ developers. Some of our developers use IE and some of them use FireFox. Does RB 1.0.5 work with both browser seamless? During my testing I did not find the difference but I might have missed something. Pl. let me know if there is any preference of browser we should enforce to our developers. Thanks -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Binary Files handling in RB 1.0.5
The perforce has marked them as binary file. Why I get error message instead of some standard message saying this is binary file or similar? Do I need to install some patch ? On Dec 1, 5:04 pm, Tom Sakkos wrote: > Assuming that the files are marked as Binary files in Perforce, Review-Board > should ignore them and properly say something along the lines of "Binary > files differ." > > -Tom > > > > On Tue, Dec 1, 2009 at 6:51 PM, Kunjal wrote: > > Hello, > > > In our development environment, we have lot of reviews only with > > Binary files. > > For example, If I post the review with 4 binary files, what should > > happen when I click on View Diff? > > > For now, I just try with one binary file, and I get below message when > > I click on View Diff. > > > Is there any work-around for binary files? > > > The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/usim.sbk' > > didn't apply cleanly. The temporary files have been left in '/tmp/ > > reviewboard.6SzZlW' for debugging purposes. `patch` returned: patching > > file /tmp/reviewboard.6SzZlW/tmpSst3n_ patch: malformed patch at > > line 21: > > > Traceback (most recent call last): > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > views.py", line 153, in view_diff > > interdiffset, highlighting, True) > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > diffutils.py", line 623, in get_diff_files > > large_data=True) > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/Djblets-0.5.5-py2.5.egg/djblets/util/misc.py", line 162, in > > cache_memoize > > data = lookup_callable() > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > diffutils.py", line 622, in > > enable_syntax_highlighting), > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > diffutils.py", line 345, in get_chunks > > new = get_patched_file(old, filediff) > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > diffutils.py", line 261, in get_patched_file > > return patch(filediff.diff, buffer, filediff.dest_file) > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ > > diffutils.py", line 129, in patch > > (filename, tempdir, patch_output)) > > Exception: The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/ > > usim.sbk' didn't apply cleanly. The temporary files have been left in > > '/tmp/reviewboard.6SzZlW' for debugging purposes. > > `patch` returned: patching file /tmp/reviewboard.6SzZlW/tmpSst3n_ > > patch: malformed patch at line 21: > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Binary Files handling in RB 1.0.5
Hello, In our development environment, we have lot of reviews only with Binary files. For example, If I post the review with 4 binary files, what should happen when I click on View Diff? For now, I just try with one binary file, and I get below message when I click on View Diff. Is there any work-around for binary files? The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/usim.sbk' didn't apply cleanly. The temporary files have been left in '/tmp/ reviewboard.6SzZlW' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.6SzZlW/tmpSst3n_ patch: malformed patch at line 21: Traceback (most recent call last): File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ views.py", line 153, in view_diff interdiffset, highlighting, True) File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 623, in get_diff_files large_data=True) File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/Djblets-0.5.5-py2.5.egg/djblets/util/misc.py", line 162, in cache_memoize data = lookup_callable() File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 622, in enable_syntax_highlighting), File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 345, in get_chunks new = get_patched_file(old, filediff) File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 129, in patch (filename, tempdir, patch_output)) Exception: The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/ usim.sbk' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.6SzZlW' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.6SzZlW/tmpSst3n_ patch: malformed patch at line 21: -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: P4Error when click on View Diff
Thanks, Chris. You solved my problem.
On Dec 1, 2:33 pm, Christian Hammond wrote:
> Which beta version?
>
> The failure is due to the p4 print command failing. It is trying to do:
>
> p4 -p print -q
>
> If you have a username and password set for the repository, it's tacking "-u
> -p " before the "print" part above.
>
> You may want to try running this manually from that server and see what
> happens. It may be that p4 isn't being invoked, or there's a communication
> or authentication issue with the server.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Tue, Dec 1, 2009 at 11:17 AM, Kunjal wrote:
> > Hello,
>
> > We are using RB-Beta version integrated with Perforce.
> > Suddendly, from yesterday evening, for all of the reviews in RB, when
> > someone clicks on View Diff, we get below error.
> > Any pointers to debug this issue?
>
> > Traceback (most recent call last):
> > File "/usr/local/lib64/python2.5/site-packages/reviewboard/
> > diffviewer/views.py", line 82, in view_diff
> > files = get_diff_files(diffset, None, interdiffset, highlighting)
> > File "/usr/local/lib64/python2.5/site-packages/reviewboard/
> > diffviewer/diffutils.py", line 561, in get_diff_files
> > enable_syntax_highlighting)
> > File "/usr/local/lib64/python2.5/site-packages/reviewboard/
> > diffviewer/diffutils.py", line 500, in generate_files
> > lambda: get_chunks(filediff.diffset,
> > File "/usr/local/lib64/python2.5/site-packages/djblets/util/
> > misc.py", line 47, in cache_memoize
> > data = lookup_callable()
> > File "/usr/local/lib64/python2.5/site-packages/reviewboard/
> > diffviewer/diffutils.py", line 503, in
> > enable_syntax_highlighting))
> > File "/usr/local/lib64/python2.5/site-packages/reviewboard/
> > diffviewer/diffutils.py", line 297, in get_chunks
> > old = get_original_file(filediff)
> > File "/usr/local/lib64/python2.5/site-packages/reviewboard/
> > diffviewer/diffutils.py", line 208, in get_original_file
> > return cache_memoize(key, lambda: [tool.get_file(file, revision)])
> > [0]
> > File "/usr/local/lib64/python2.5/site-packages/djblets/util/
> > misc.py", line 47, in cache_memoize
> > data = lookup_callable()
> > File "/usr/local/lib64/python2.5/site-packages/reviewboard/
> > diffviewer/diffutils.py", line 208, in
> > return cache_memoize(key, lambda: [tool.get_file(file, revision)])
> > [0]
> > File "/usr/local/lib64/python2.5/site-packages/reviewboard/scmtools/
> > perforce.py", line 89, in get_file
> > raise P4Error('\n'.join(line[1:] for line in error[1:]))
> > P4Error
>
> > --
> > Want to help the Review Board project? Donate today at
> >http://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~--~~~~--~~--~--~---
> > To unsubscribe from this group, send email to
> > reviewboard+unsubscr...@googlegroups.com
> > For more options, visit this group at
> >http://groups.google.com/group/reviewboard?hl=en- Hide quoted text -
>
> - Show quoted text -
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
P4Error when click on View Diff
Hello,
We are using RB-Beta version integrated with Perforce.
Suddendly, from yesterday evening, for all of the reviews in RB, when
someone clicks on View Diff, we get below error.
Any pointers to debug this issue?
Traceback (most recent call last):
File "/usr/local/lib64/python2.5/site-packages/reviewboard/
diffviewer/views.py", line 82, in view_diff
files = get_diff_files(diffset, None, interdiffset, highlighting)
File "/usr/local/lib64/python2.5/site-packages/reviewboard/
diffviewer/diffutils.py", line 561, in get_diff_files
enable_syntax_highlighting)
File "/usr/local/lib64/python2.5/site-packages/reviewboard/
diffviewer/diffutils.py", line 500, in generate_files
lambda: get_chunks(filediff.diffset,
File "/usr/local/lib64/python2.5/site-packages/djblets/util/
misc.py", line 47, in cache_memoize
data = lookup_callable()
File "/usr/local/lib64/python2.5/site-packages/reviewboard/
diffviewer/diffutils.py", line 503, in
enable_syntax_highlighting))
File "/usr/local/lib64/python2.5/site-packages/reviewboard/
diffviewer/diffutils.py", line 297, in get_chunks
old = get_original_file(filediff)
File "/usr/local/lib64/python2.5/site-packages/reviewboard/
diffviewer/diffutils.py", line 208, in get_original_file
return cache_memoize(key, lambda: [tool.get_file(file, revision)])
[0]
File "/usr/local/lib64/python2.5/site-packages/djblets/util/
misc.py", line 47, in cache_memoize
data = lookup_callable()
File "/usr/local/lib64/python2.5/site-packages/reviewboard/
diffviewer/diffutils.py", line 208, in
return cache_memoize(key, lambda: [tool.get_file(file, revision)])
[0]
File "/usr/local/lib64/python2.5/site-packages/reviewboard/scmtools/
perforce.py", line 89, in get_file
raise P4Error('\n'.join(line[1:] for line in error[1:]))
P4Error
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Active Directory Settings and ReviewBoard
Hello, We have setup AD with ReviewBoard. The issue is that users need to login once in order to get authenticated with RB. Is there a way we can pre-populate user list in RB? This way each user does not need to login at-least once to get there name added. Thanks Kunjal --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
ReviewBoard + GIT Integration
Chris, We have RB 1.0.5.1 working with Perforce. We also use GIT as version control system for some of our projects and we want to integrate RB with GIT. Few questions: 1. Can we use the same reviewboard database with GIT which we are using for Perforce? 2. How to post review from GIT? Do I need to install RB_Tools etc? Any steps? Thanks Kunjal --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Customize ReviewBoard for Email Subject
In the description of the Review, all the developer put the similar template as shown below: What I will do is get the string between [Defect / Enhancement / New Feature] and [Problem] and populate as Email Subject line. [Defect / Enhancement / New Feature] [Problem] Need to fix the callbacks of audio manager. [Solution] Consolidated Audio mangager callbacks. Also fixed the pcm playback. [Reviewers] Liping Wang, Uday Gupta, Kuoyu Lin, Frank Shou On Nov 5, 12:26 pm, Christian Hammond wrote: > There was a bug filed for this > (http://code.google.com/p/reviewboard/issues/detail?id=521) but we decided > not to implement it, since in most cases you either 1) Will be posting to > mailman lists, which have their own subject formatting, or 2) Are using it > for filtering purposes, at which point the new X-ReviewRequest-* e-mail > headers are far more appropriate. > > You can certainly modify email.py, but know that this will make upgrades > hard, and the location of that file has changed in the 1.1 series. If you're > going to do this, read the page on maintaining Review Board forks > (http://www.reviewboard.org/docs/codebase/dev/custom-forks/). > > Also, if we were to allow subject modification, it would just be a prefix. > Kunjal, I'm not sure I understand how the regex or resulting subject line > would look, so maybe you can give me some examples? > > As for the .pyc files, it doesn't hurt to do that certainly. It *shouldn't* > be needed, though. The big thing is to restart the web server. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Thu, Nov 5, 2009 at 11:44 AM, Chris Clark wrote: > > > Kunjal wrote: > > > we want to customize the subject line > > > of the email which RB sends on submit of review. > > > Check out reviewboard/reviews/email.py - mail_review_request() look for > > "subject". > > > I "nice to have" would be a way to customize this from the site admin > > page. I'm not likely to implement this myself though :-( > > > Chris > > > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en > > -~--~~~~--~~--~--~ Hide quoted text - > > - Show quoted text - --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: How to confiure EMAILS for Reviews
THANKS...It started working now.
One issue I see is this
For the existing review, If I add more people and click on Publish
changes, I get below error.
What is this regarding?
SMTPException at /api/json/reviewrequests/9/publish/
SMTP AUTH extension not supported by server.Request Method: POST
Request URL:
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/9/publish/
Exception Type: SMTPException
Exception Value: SMTP AUTH extension not supported by server.
Exception Location: /opt/lampp/lib/python2.5/smtplib.py in login, line
554
Python Executable: /tools/bin/python
Python Version: 2.5.2
Python Path: ['/opt/lampp/htdocs/reviewboard/conf', '/opt/lampp/lib/
python2.5/site-packages/django', '/opt/lampp/lib/python2.5/site-
packages/reviewboard', '/opt/lampp/lib/python2.5/site-packages/
MySQL_python-1.2.2-py2.5-linux-i686.egg', '/opt/lampp/lib/python2.5/
site-packages/setuptools-0.6c9-py2.5.egg', '/opt/lampp/lib/python2.5/
site-packages/ReviewBoard-1.0.3.1-py2.5.egg', '/opt/lampp/lib/
python2.5/site-packages/pytz-2009l-py2.5.egg', '/opt/lampp/lib/
python2.5/site-packages/flup-1.0.3.dev_20090716-py2.5.egg', '/opt/
lampp/lib/python2.5/site-packages/Pygments-1.1.1-py2.5.egg', '/opt/
lampp/lib/python2.5/site-packages/Djblets-0.5.3-py2.5.egg', '/opt/
lampp/lib/python2.5/site-packages/django_evolution-0.0.0-py2.5.egg', '/
opt/lampp/lib/python2.5/site-packages/Django-1.1-py2.5.egg', '/opt/
lampp/lib/python2.5/site-packages/PIL-1.1.6-py2.5-linux-i686.egg', '/
opt/lampp/lib/python2.5/site-packages/RBTools-0.2beta2-py2.5.egg', '/
opt/lampp/lib/python2.5/site-packages/simplejson-2.0.9-py2.5-linux-
i686.egg', '/opt/lampp/lib/python2.5/site-packages/python_ldap-2.3.9-
py2.5-linux-i686.egg', '/opt/lampp/lib/python25.zip', '/opt/lampp/lib/
python2.5', '/opt/lampp/lib/python2.5/plat-linux2', '/opt/lampp/lib/
python2.5/lib-tk', '/opt/lampp/lib/python2.5/lib-dynload', '/opt/lampp/
lib/python2.5/site-packages']
Server time: Wed, 4 Nov 2009 09:19:16 -0800
On Nov 3, 11:20 pm, Christian Hammond wrote:
> What mail server do you use?
>
> Also, give this a try:
>
> rb-site manage /path/to/site shell
>
> At the prompt:
>
> from django.core.mail import send_mail
> send_mail("Test Subject", "This is a test", "youraddr...@yourdomain.com",
> ["youraddr...@yourdomain.com"], fail_silently=False)
>
> That *should* send an e-mail to the address you specify, using the e-mail
> settings in Review Board. If that fails, hopefully you'll see why.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Tue, Nov 3, 2009 at 5:04 PM, Kunjal wrote:
>
> > Chris,
>
> > I have set the correct smtp host/port etc. but I still do not get
> > email.
> > Do I need to modify email.py file to get the email?
>
> > Thanks
> > Kunjal
>
> > On Nov 2, 3:47 pm, Christian Hammond wrote:
> > > You should be able to configure that in the E-mail Settings part of the
> > > Admin UI. If e-mail is not working correctly, then it's an issue talking
> > to
> > > the mail server.
>
> > > Unfortunately, going through Django's e-mail infrastructure means that we
> > > don't get any detailed error logging. Assuming the mail server is under
> > your
> > > control, you may want to check your mail server logs if your e-mail is
> > > enabled/configured properly and you're still not seeing anything.
>
> > > Christian
>
> > > --
> > > Christian Hammond - chip...@chipx86.com
> > > Review Board -http://www.reviewboard.org
> > > VMware, Inc. -http://www.vmware.com
>
> > > On Mon, Nov 2, 2009 at 4:05 PM, Kunjal wrote:
>
> > > > We have RB 1.0.3 with Perforce integration.
> > > > We have set up Apache server and everything works fine like posting
> > > > review, publshing review, updating diff etc.
> > > > We do not get any emails though once the review is posted etc.
> > > > how to configure email settings?
>
> > > > Thanks
> > > > Kunjal
>
> > > > > To unsubscribe from this group, send email to
> > > > reviewboard+unsubscr...@googlegroups.com
> >
> > > > For more options, visit this group at
> > > >http://groups.google.com/group/reviewboard?hl=en
> > > > -~--~~~~--~~--~--~ Hide quoted text
> > -
>
> > &g
Re: How to confiure EMAILS for Reviews
Chris, I have set the correct smtp host/port etc. but I still do not get email. Do I need to modify email.py file to get the email? Thanks Kunjal On Nov 2, 3:47 pm, Christian Hammond wrote: > You should be able to configure that in the E-mail Settings part of the > Admin UI. If e-mail is not working correctly, then it's an issue talking to > the mail server. > > Unfortunately, going through Django's e-mail infrastructure means that we > don't get any detailed error logging. Assuming the mail server is under your > control, you may want to check your mail server logs if your e-mail is > enabled/configured properly and you're still not seeing anything. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Mon, Nov 2, 2009 at 4:05 PM, Kunjal wrote: > > > We have RB 1.0.3 with Perforce integration. > > We have set up Apache server and everything works fine like posting > > review, publshing review, updating diff etc. > > We do not get any emails though once the review is posted etc. > > how to configure email settings? > > > Thanks > > Kunjal > > > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en > > -~--~~~~--~~--~--~ Hide quoted text - > > - Show quoted text - --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: How to make the description of the Review READ ONLY
Thanks. I got my answer. On Nov 2, 3:38 pm, Christian Hammond wrote: > This isn't possible today without modifying Review Board heavliy. It's a > pretty specific policy choice and and we probably wouldn't want to add a > setting for it (as it's more to test, maintain, and isn't something that 99% > of our userbase will need). > > Generally, I'd say you should just make sure people know not to change it. > After all, what's to prevent them from modifying the template on the first > post, and what if their code has changed enough to warrant a change in the > description? > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Mon, Nov 2, 2009 at 4:04 PM, Kunjal wrote: > > > Hello, > > > For the RB 1.0.3, we want to make such custom changes that the > > description is read only once someone post the review even if it is in > > draft mode. > > We DO NOT want users to allow editing the description in review board > > as it contains some pre-defined template and we do not want it to > > change. > > > How to do this? Is it possible? If yes, which file I have to change? > > > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en > > -~--~~~~--~~--~--~ Hide quoted text - > > - Show quoted text - --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
How to confiure EMAILS for Reviews
We have RB 1.0.3 with Perforce integration. We have set up Apache server and everything works fine like posting review, publshing review, updating diff etc. We do not get any emails though once the review is posted etc. how to configure email settings? Thanks Kunjal --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
How to make the description of the Review READ ONLY
Hello, For the RB 1.0.3, we want to make such custom changes that the description is read only once someone post the review even if it is in draft mode. We DO NOT want users to allow editing the description in review board as it contains some pre-defined template and we do not want it to change. How to do this? Is it possible? If yes, which file I have to change? --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Can not post word document in review
Hello, we have RB 1.0.3-Perforce setup. I created pending CL with word document. When I post the review, it did post the review successfully. But when I click on View Diff, on my first try I get below message: The patch to 'c:/Perforce/Sources/Integration/Automation_Scripts/ ClearQuest_Documents/4weewrewrewr.doc' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.0_p4v9' for debugging purposes. `patch` returned: patching file /tmp/reviewboard. 0_p4v9/tmpnshHiq patch: malformed patch at line 5: Traceback (most recent call last): File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ views.py", line 152, in view_diff interdiffset, highlighting, True) File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 623, in get_diff_files large_data=True) File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/Djblets-0.5.3-py2.5.egg/djblets/util/misc.py", line 162, in cache_memoize data = lookup_callable() File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 622, in enable_syntax_highlighting), File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 345, in get_chunks new = get_patched_file(old, filediff) File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 129, in patch (filename, tempdir, patch_output)) Exception: The patch to 'c:/Perforce/Sources/Integration/ Automation_Scripts/ClearQuest_Documents/4weewrewrewr.doc' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard. 0_p4v9' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.0_p4v9/tmpnshHiq patch: malformed patch at line 5: ON MY SECOND TRY WITH NEW PENDING CL, I GOT BELOW MESSAGE WHEN I CLICK ON VIEW DIFF: 'ascii' codec can't decode byte 0xa0 in position 87: ordinal not in range(128) Traceback (most recent call last): File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ views.py", line 152, in view_diff interdiffset, highlighting, True) File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 623, in get_diff_files large_data=True) File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/Djblets-0.5.3-py2.5.egg/djblets/util/misc.py", line 162, in cache_memoize data = lookup_callable() File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 622, in enable_syntax_highlighting), File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 345, in get_chunks new = get_patched_file(old, filediff) File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py", line 129, in patch (filename, tempdir, patch_output)) UnicodeDecodeError: 'ascii' codec can't decode byte 0xa0 in position 87: ordinal not in range(128) HOW TO FIX THIS ISSUE? --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Existing Reviews not visible after rb-site upgrade
Chirs, Sorry for all this email but I found this. In the older installation, there are few dir. which are not present in 1.0.3 installation. Did I miss installing something? The dir. I do not see in RB 1.0.3 installation are: djblets iphone m3 The files I do not see in RB 1.0.3 instllation are: Makefile Makefile.am Makefile.in py-compile Thanks Kunjal On Oct 28, 7:17 pm, Christian Hammond wrote: > Do you know exactly how old the old install was? Preferably which SVN > revision? > > Did you use rb-site for the old version as well? > > You shouldn't need to start with a new database, but it doesn't sound like > your site install upgraded correctly. We'll need to figure out what exactly > is causing this. > > Chris Clark posted some good notes on upgrading his old install today. That > might be useful as well. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Wed, Oct 28, 2009 at 2:38 PM, Kunjal wrote: > > > To add more info..we have never done any upgrade. > > We install Reviewboard Beta in 2008 and still using the old Beta > > version. > > Is there a way or we need to start with new database with our RB 1.0.3 > > release? > > > -Kunjal > > > On Oct 28, 2:30 pm, Kunjal wrote: > > > We are upgrading from Beta version. > > > > We did perform rb-site upgrade. > > > > Kunjal > > > > On Oct 28, 10:56 am, Christian Hammond wrote: > > > > > Did you then run rb-site upgrade on it? It should have taken care of > > that. > > > > > What version were you upgrading from? I thought 1.0 had this field. > > > > > Christian > > > > > -- > > > > Christian Hammond - chip...@chipx86.com > > > > Review Board -http://www.reviewboard.org > > > > VMware, Inc. -http://www.vmware.com > > > > > On Wed, Oct 28, 2009 at 9:26 AM, Kunjal > > wrote: > > > > > > Hello Chris, > > > > > > The new import shows more information imported. It looks like the > > > > > database is imported correctly. > > > > > Now, when I login to RB, I get below message... > > > > > Looks like some mismatch in the database fields. Is some database > > > > > fields obsolete? How to fix this? > > > > > > TemplateSyntaxError at /dashboard/ > > > > > Caught an exception while rendering: (1054, "Unknown column > > > > > 'reviews_reviewrequest.last_review_timestamp' in 'field list'") > > > > > > Original Traceback (most recent call last): > > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > > packages/Django-1.1-py2.5.egg/django/template/debug.py", line 71, in > > > > > render_node > > > > > result = node.render(context) > > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > > packages/Django-1.1-py2.5.egg/django/template/__init__.py", line 936, > > > > > in render > > > > > dict = func(*args) > > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/reviews/ > > > > > templatetags/reviewtags.py", line 348, in dashboard_entry > > > > > count = len(review_requests) > > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > > packages/Django-1.1-py2.5.egg/django/db/models/query.py", line 81, in > > > > > __len__ > > > > > self._result_cache = list(self.iterator()) > > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > > packages/Django-1.1-py2.5.egg/django/db/models/query.py", line 238, > > in > > > > > iterator > > > > > for row in self.query.results_iter(): > > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > > packages/Django-1.1-py2.5.egg/django/db/models/sql/query.py", line > > > > > 287, in results_iter > > > > > for rows in self.execute_sql(MULTI): > > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > > packages/Django-1.1-py2.5.egg/django/db/models/sql/query.py", line > > > > > 2369, in execute_sql > > >
Re: Existing Reviews not visible after rb-site upgrade
I found the Version of the Reviewboard we have. /* Define to the address where bug reports for this package should be sent. */ #define PACKAGE_BUGREPORT "http://code.google.com/p/reviewboard/issues/ entry" /* Define to the full name of this package. */ #define PACKAGE_NAME "Review Board" /* Define to the full name and version of this package. */ #define PACKAGE_STRING "Review Board 0.4" /* Define to the one symbol short name of this package. */ #define PACKAGE_TARNAME "reviewboard" /* Define to the version of this package. */ #define PACKAGE_VERSION "0.4" /* Version number of package */ #define VERSION "0.4" On Oct 28, 2:38 pm, Kunjal wrote: > To add more info..we have never done any upgrade. > We install Reviewboard Beta in 2008 and still using the old Beta > version. > Is there a way or we need to start with new database with our RB 1.0.3 > release? > > -Kunjal > > On Oct 28, 2:30 pm, Kunjal wrote: > > > > > We are upgrading from Beta version. > > > We did perform rb-site upgrade. > > > Kunjal > > > On Oct 28, 10:56 am, Christian Hammond wrote: > > > > Did you then run rb-site upgrade on it? It should have taken care of that. > > > > What version were you upgrading from? I thought 1.0 had this field. > > > > Christian > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > On Wed, Oct 28, 2009 at 9:26 AM, Kunjal wrote: > > > > > Hello Chris, > > > > > The new import shows more information imported. It looks like the > > > > database is imported correctly. > > > > Now, when I login to RB, I get below message... > > > > Looks like some mismatch in the database fields. Is some database > > > > fields obsolete? How to fix this? > > > > > TemplateSyntaxError at /dashboard/ > > > > Caught an exception while rendering: (1054, "Unknown column > > > > 'reviews_reviewrequest.last_review_timestamp' in 'field list'") > > > > > Original Traceback (most recent call last): > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Django-1.1-py2.5.egg/django/template/debug.py", line 71, in > > > > render_node > > > > result = node.render(context) > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Django-1.1-py2.5.egg/django/template/__init__.py", line 936, > > > > in render > > > > dict = func(*args) > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/reviews/ > > > > templatetags/reviewtags.py", line 348, in dashboard_entry > > > > count = len(review_requests) > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Django-1.1-py2.5.egg/django/db/models/query.py", line 81, in > > > > __len__ > > > > self._result_cache = list(self.iterator()) > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Django-1.1-py2.5.egg/django/db/models/query.py", line 238, in > > > > iterator > > > > for row in self.query.results_iter(): > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Django-1.1-py2.5.egg/django/db/models/sql/query.py", line > > > > 287, in results_iter > > > > for rows in self.execute_sql(MULTI): > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Django-1.1-py2.5.egg/django/db/models/sql/query.py", line > > > > 2369, in execute_sql > > > > cursor.execute(sql, params) > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Djblets-0.5.3-py2.5.egg/djblets/log/middleware.py", line 49, > > > > in execute > > > > return self.cursor.execute(sql, params) > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Django-1.1-py2.5.egg/django/db/backends/mysql/base.py", line > > > > 84, in execute > > > > return self.cursor.execute(query, args) > > > > File "build/bdist.linux-i686/egg/MySQLdb/cursors.py"
Re: Existing Reviews not visible after rb-site upgrade
Chirs, The old install was done by someone else. I see the folders created on 4th Aug, 2008. I am not sure whether rb-site was used or not. Do I need to perform commands like /.manage.py evolve after rb-site upgrade? At this point I am really stuck...!! On Oct 28, 2:38 pm, Kunjal wrote: > To add more info..we have never done any upgrade. > We install Reviewboard Beta in 2008 and still using the old Beta > version. > Is there a way or we need to start with new database with our RB 1.0.3 > release? > > -Kunjal > > On Oct 28, 2:30 pm, Kunjal wrote: > > > > > We are upgrading from Beta version. > > > We did perform rb-site upgrade. > > > Kunjal > > > On Oct 28, 10:56 am, Christian Hammond wrote: > > > > Did you then run rb-site upgrade on it? It should have taken care of that. > > > > What version were you upgrading from? I thought 1.0 had this field. > > > > Christian > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > On Wed, Oct 28, 2009 at 9:26 AM, Kunjal wrote: > > > > > Hello Chris, > > > > > The new import shows more information imported. It looks like the > > > > database is imported correctly. > > > > Now, when I login to RB, I get below message... > > > > Looks like some mismatch in the database fields. Is some database > > > > fields obsolete? How to fix this? > > > > > TemplateSyntaxError at /dashboard/ > > > > Caught an exception while rendering: (1054, "Unknown column > > > > 'reviews_reviewrequest.last_review_timestamp' in 'field list'") > > > > > Original Traceback (most recent call last): > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Django-1.1-py2.5.egg/django/template/debug.py", line 71, in > > > > render_node > > > > result = node.render(context) > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Django-1.1-py2.5.egg/django/template/__init__.py", line 936, > > > > in render > > > > dict = func(*args) > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/reviews/ > > > > templatetags/reviewtags.py", line 348, in dashboard_entry > > > > count = len(review_requests) > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Django-1.1-py2.5.egg/django/db/models/query.py", line 81, in > > > > __len__ > > > > self._result_cache = list(self.iterator()) > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Django-1.1-py2.5.egg/django/db/models/query.py", line 238, in > > > > iterator > > > > for row in self.query.results_iter(): > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Django-1.1-py2.5.egg/django/db/models/sql/query.py", line > > > > 287, in results_iter > > > > for rows in self.execute_sql(MULTI): > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Django-1.1-py2.5.egg/django/db/models/sql/query.py", line > > > > 2369, in execute_sql > > > > cursor.execute(sql, params) > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Djblets-0.5.3-py2.5.egg/djblets/log/middleware.py", line 49, > > > > in execute > > > > return self.cursor.execute(sql, params) > > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > > packages/Django-1.1-py2.5.egg/django/db/backends/mysql/base.py", line > > > > 84, in execute > > > > return self.cursor.execute(query, args) > > > > File "build/bdist.linux-i686/egg/MySQLdb/cursors.py", line 166, in > > > > execute > > > > self.errorhandler(self, exc, value) > > > > File "build/bdist.linux-i686/egg/MySQLdb/connections.py", line 35, > > > > in defaulterrorhandler > > > > raise errorclass, errorvalue > > > > OperationalError: (1054, "Unknown column > > > > 'reviews_reviewrequest.last_review_timestamp'
Re: Existing Reviews not visible after rb-site upgrade
To add more info..we have never done any upgrade. We install Reviewboard Beta in 2008 and still using the old Beta version. Is there a way or we need to start with new database with our RB 1.0.3 release? -Kunjal On Oct 28, 2:30 pm, Kunjal wrote: > We are upgrading from Beta version. > > We did perform rb-site upgrade. > > Kunjal > > On Oct 28, 10:56 am, Christian Hammond wrote: > > > > > Did you then run rb-site upgrade on it? It should have taken care of that. > > > What version were you upgrading from? I thought 1.0 had this field. > > > Christian > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.reviewboard.org > > VMware, Inc. -http://www.vmware.com > > > On Wed, Oct 28, 2009 at 9:26 AM, Kunjal wrote: > > > > Hello Chris, > > > > The new import shows more information imported. It looks like the > > > database is imported correctly. > > > Now, when I login to RB, I get below message... > > > Looks like some mismatch in the database fields. Is some database > > > fields obsolete? How to fix this? > > > > TemplateSyntaxError at /dashboard/ > > > Caught an exception while rendering: (1054, "Unknown column > > > 'reviews_reviewrequest.last_review_timestamp' in 'field list'") > > > > Original Traceback (most recent call last): > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/Django-1.1-py2.5.egg/django/template/debug.py", line 71, in > > > render_node > > > result = node.render(context) > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/Django-1.1-py2.5.egg/django/template/__init__.py", line 936, > > > in render > > > dict = func(*args) > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/reviews/ > > > templatetags/reviewtags.py", line 348, in dashboard_entry > > > count = len(review_requests) > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/Django-1.1-py2.5.egg/django/db/models/query.py", line 81, in > > > __len__ > > > self._result_cache = list(self.iterator()) > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/Django-1.1-py2.5.egg/django/db/models/query.py", line 238, in > > > iterator > > > for row in self.query.results_iter(): > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/Django-1.1-py2.5.egg/django/db/models/sql/query.py", line > > > 287, in results_iter > > > for rows in self.execute_sql(MULTI): > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/Django-1.1-py2.5.egg/django/db/models/sql/query.py", line > > > 2369, in execute_sql > > > cursor.execute(sql, params) > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/Djblets-0.5.3-py2.5.egg/djblets/log/middleware.py", line 49, > > > in execute > > > return self.cursor.execute(sql, params) > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/Django-1.1-py2.5.egg/django/db/backends/mysql/base.py", line > > > 84, in execute > > > return self.cursor.execute(query, args) > > > File "build/bdist.linux-i686/egg/MySQLdb/cursors.py", line 166, in > > > execute > > > self.errorhandler(self, exc, value) > > > File "build/bdist.linux-i686/egg/MySQLdb/connections.py", line 35, > > > in defaulterrorhandler > > > raise errorclass, errorvalue > > > OperationalError: (1054, "Unknown column > > > 'reviews_reviewrequest.last_review_timestamp' in 'field list'") > > > Request Method: GET > > > Request URL:http://mob-rb-test.sj.broadcom.com/dashboard/ > > > Exception Type: TemplateSyntaxError > > > Exception Value: Caught an exception while rendering: (1054, "Unknown > > > column 'reviews_reviewrequest.last_review_timestamp' in 'field list'") > > > > Original Traceback (most recent call last): > > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > > packages/Django-1.1-py2.5.egg/django/template/debug.py", line 71, in > > > re
Re: Existing Reviews not visible after rb-site upgrade
We are upgrading from Beta version. We did perform rb-site upgrade. Kunjal On Oct 28, 10:56 am, Christian Hammond wrote: > Did you then run rb-site upgrade on it? It should have taken care of that. > > What version were you upgrading from? I thought 1.0 had this field. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Wed, Oct 28, 2009 at 9:26 AM, Kunjal wrote: > > > Hello Chris, > > > The new import shows more information imported. It looks like the > > database is imported correctly. > > Now, when I login to RB, I get below message... > > Looks like some mismatch in the database fields. Is some database > > fields obsolete? How to fix this? > > > TemplateSyntaxError at /dashboard/ > > Caught an exception while rendering: (1054, "Unknown column > > 'reviews_reviewrequest.last_review_timestamp' in 'field list'") > > > Original Traceback (most recent call last): > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/Django-1.1-py2.5.egg/django/template/debug.py", line 71, in > > render_node > > result = node.render(context) > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/Django-1.1-py2.5.egg/django/template/__init__.py", line 936, > > in render > > dict = func(*args) > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/reviews/ > > templatetags/reviewtags.py", line 348, in dashboard_entry > > count = len(review_requests) > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/Django-1.1-py2.5.egg/django/db/models/query.py", line 81, in > > __len__ > > self._result_cache = list(self.iterator()) > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/Django-1.1-py2.5.egg/django/db/models/query.py", line 238, in > > iterator > > for row in self.query.results_iter(): > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/Django-1.1-py2.5.egg/django/db/models/sql/query.py", line > > 287, in results_iter > > for rows in self.execute_sql(MULTI): > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/Django-1.1-py2.5.egg/django/db/models/sql/query.py", line > > 2369, in execute_sql > > cursor.execute(sql, params) > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/Djblets-0.5.3-py2.5.egg/djblets/log/middleware.py", line 49, > > in execute > > return self.cursor.execute(sql, params) > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/Django-1.1-py2.5.egg/django/db/backends/mysql/base.py", line > > 84, in execute > > return self.cursor.execute(query, args) > > File "build/bdist.linux-i686/egg/MySQLdb/cursors.py", line 166, in > > execute > > self.errorhandler(self, exc, value) > > File "build/bdist.linux-i686/egg/MySQLdb/connections.py", line 35, > > in defaulterrorhandler > > raise errorclass, errorvalue > > OperationalError: (1054, "Unknown column > > 'reviews_reviewrequest.last_review_timestamp' in 'field list'") > > Request Method: GET > > Request URL:http://mob-rb-test.sj.broadcom.com/dashboard/ > > Exception Type: TemplateSyntaxError > > Exception Value: Caught an exception while rendering: (1054, "Unknown > > column 'reviews_reviewrequest.last_review_timestamp' in 'field list'") > > > Original Traceback (most recent call last): > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/Django-1.1-py2.5.egg/django/template/debug.py", line 71, in > > render_node > > result = node.render(context) > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/Django-1.1-py2.5.egg/django/template/__init__.py", line 936, > > in render > > dict = func(*args) > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/reviews/ > > templatetags/reviewtags.py", line 348, in dashboard_entry > > count = len(review_requests) > > File "/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- > > packages/Django-1.1-py
Re: Existing Reviews not visible after rb-site upgrade
alue) File "build/bdist.linux-i686/egg/MySQLdb/connections.py", line 35, in defaulterrorhandler raise errorclass, errorvalue OperationalError: (1054, "Unknown column 'reviews_reviewrequest.last_review_timestamp' in 'field list'") Exception Location: /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/ python2.5/site-packages/Django-1.1-py2.5.egg/django/template/debug.py in render_node, line 81 Python Executable: /opt/lampp/bin/python Python Version: 2.5.2 Python Path: ['/opt/lampp/htdocs/reviewboard/conf', '/opt/lampp/lib/ python2.5/site-packages/django', '/opt/lampp/lib/python2.5/site- packages/reviewboard', '/opt/lampp/lib/python2.5/site-packages/ MySQL_python-1.2.2-py2.5-linux-i686.egg', '/opt/lampp/lib/python2.5/ site-packages/setuptools-0.6c9-py2.5.egg', '/opt/lampp/lib/python2.5/ site-packages/ReviewBoard-1.0.3.1-py2.5.egg', '/opt/lampp/lib/ python2.5/site-packages/pytz-2009l-py2.5.egg', '/opt/lampp/lib/ python2.5/site-packages/flup-1.0.3.dev_20090716-py2.5.egg', '/opt/ lampp/lib/python2.5/site-packages/Pygments-1.1.1-py2.5.egg', '/opt/ lampp/lib/python2.5/site-packages/Djblets-0.5.3-py2.5.egg', '/opt/ lampp/lib/python2.5/site-packages/django_evolution-0.0.0-py2.5.egg', '/ opt/lampp/lib/python2.5/site-packages/Django-1.1-py2.5.egg', '/opt/ lampp/lib/python2.5/site-packages/PIL-1.1.6-py2.5-linux-i686.egg', '/ opt/lampp/lib/python2.5/site-packages/RBTools-0.2beta2-py2.5.egg', '/ opt/lampp/lib/python2.5/site-packages/simplejson-2.0.9-py2.5-linux- i686.egg', '/opt/lampp/lib/python2.5/site-packages/python_ldap-2.3.9- py2.5-linux-i686.egg', '/opt/lampp/lib/python25.zip', '/opt/lampp/lib/ python2.5', '/opt/lampp/lib/python2.5/plat-linux2', '/opt/lampp/lib/ python2.5/lib-tk', '/opt/lampp/lib/python2.5/lib-dynload', '/opt/lampp/ lib/python2.5/site-packages'] Server time: Wed, 28 Oct 2009 09:22:41 -0700 On Oct 27, 4:38 pm, Kunjal wrote: > Thanks. > I really like your quick support. > All the thanks to your team. I will try it out after porting > settings_local.py file. > > Regards, > Kunjal > > On Oct 27, 4:18 pm, Christian Hammond wrote: > > > > > You shouldn't care about settings.py, as that's part of the Review Board > > source. > > > However, settings_local.py is important, as it contains the uniquely > > generated secure key used for any encryption of passwords and such. You will > > want the original if you're using the same database. > > > That said, I don't imagine it's responsible for not seeing the review > > requests. That wouldn't be a Review Board problem, but I also don't know > > what it is. It does sound like the database didn't move over correctly. > > > You could attempt to copy over /var/lib/mysql directly. > > > Christian > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.reviewboard.org > > VMware, Inc. -http://www.vmware.com > > > On Tue, Oct 27, 2009 at 4:07 PM, Kunjal wrote: > > > > Very good point. > > > We have settings_local.py in our prod. server but I did not port it > > > over. > > > I already have settings.py in my new RB1.0.3 installation. > > > What is the difference between settings_local.py and settings.py and > > > do I need both? > > > > Should I port the settings_local.py and do the rb-site upgrade again? > > > > On Oct 27, 3:55 pm, Christian Hammond wrote: > > > > Should work in theory. > > > > > Are you re-using the same settings_local.py and other contents of the > > > site > > > > directory? > > > > > Christian > > > > > -- > > > > Christian Hammond - chip...@chipx86.com > > > > Review Board -http://www.reviewboard.org > > > > VMware, Inc. -http://www.vmware.com > > > > > On Tue, Oct 27, 2009 at 3:54 PM, Kunjal wrote: > > > > > > Is there a proper way to do it? > > > > > > I did like this. > > > > > > mysqldump --user=root -p --all-databases --socket=/var/lib/mysql/ > > > > > mysql.sock > backup-reviewboard.sql > > > > > > On Oct 27, 3:41 pm, Kunjal wrote: > > > > > > Hello Chris, > > > > > > > I have installed RB 1.0.3 on VM. > > > > > > > I wanted that RB 1.0.3 release should have existing RB database so I > > > > > > copied over the RB database and then perform rb-site upgrade. > > > > > > I di
Re: Existing Reviews not visible after rb-site upgrade
Thanks. I really like your quick support. All the thanks to your team. I will try it out after porting settings_local.py file. Regards, Kunjal On Oct 27, 4:18 pm, Christian Hammond wrote: > You shouldn't care about settings.py, as that's part of the Review Board > source. > > However, settings_local.py is important, as it contains the uniquely > generated secure key used for any encryption of passwords and such. You will > want the original if you're using the same database. > > That said, I don't imagine it's responsible for not seeing the review > requests. That wouldn't be a Review Board problem, but I also don't know > what it is. It does sound like the database didn't move over correctly. > > You could attempt to copy over /var/lib/mysql directly. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Tue, Oct 27, 2009 at 4:07 PM, Kunjal wrote: > > > Very good point. > > We have settings_local.py in our prod. server but I did not port it > > over. > > I already have settings.py in my new RB1.0.3 installation. > > What is the difference between settings_local.py and settings.py and > > do I need both? > > > Should I port the settings_local.py and do the rb-site upgrade again? > > > On Oct 27, 3:55 pm, Christian Hammond wrote: > > > Should work in theory. > > > > Are you re-using the same settings_local.py and other contents of the > > site > > > directory? > > > > Christian > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > On Tue, Oct 27, 2009 at 3:54 PM, Kunjal wrote: > > > > > Is there a proper way to do it? > > > > > I did like this. > > > > > mysqldump --user=root -p --all-databases --socket=/var/lib/mysql/ > > > > mysql.sock > backup-reviewboard.sql > > > > > On Oct 27, 3:41 pm, Kunjal wrote: > > > > > Hello Chris, > > > > > > I have installed RB 1.0.3 on VM. > > > > > > I wanted that RB 1.0.3 release should have existing RB database so I > > > > > copied over the RB database and then perform rb-site upgrade. > > > > > I did not get any error messages while doing rb-site upgrade. > > > > > After upgrade, What I see is that user table is ported correctly. But > > > > > all the reviews are not visible in dashboard. > > > > > Where they go? > > > > > > Kunjal > > > > > To unsubscribe from this group, send email to > > > > reviewboard+unsubscr...@googlegroups.com > > > > > > For more options, visit this group at > > > >http://groups.google.com/group/reviewboard?hl=en > > > > -~--~~~~--~~--~--~ Hide quoted text > > - > > > > - Show quoted text - > > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en > > -~--~~~~--~~--~--~ Hide quoted text - > > - Show quoted text - --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Existing Reviews not visible after rb-site upgrade
Very good point. We have settings_local.py in our prod. server but I did not port it over. I already have settings.py in my new RB1.0.3 installation. What is the difference between settings_local.py and settings.py and do I need both? Should I port the settings_local.py and do the rb-site upgrade again? On Oct 27, 3:55 pm, Christian Hammond wrote: > Should work in theory. > > Are you re-using the same settings_local.py and other contents of the site > directory? > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Tue, Oct 27, 2009 at 3:54 PM, Kunjal wrote: > > > Is there a proper way to do it? > > > I did like this. > > > mysqldump --user=root -p --all-databases --socket=/var/lib/mysql/ > > mysql.sock > backup-reviewboard.sql > > > On Oct 27, 3:41 pm, Kunjal wrote: > > > Hello Chris, > > > > I have installed RB 1.0.3 on VM. > > > > I wanted that RB 1.0.3 release should have existing RB database so I > > > copied over the RB database and then perform rb-site upgrade. > > > I did not get any error messages while doing rb-site upgrade. > > > After upgrade, What I see is that user table is ported correctly. But > > > all the reviews are not visible in dashboard. > > > Where they go? > > > > Kunjal > > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en > > -~--~~~~--~~--~--~ Hide quoted text - > > - Show quoted text - --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Existing Reviews not visible after rb-site upgrade
Is there a proper way to do it? I did like this. mysqldump --user=root -p --all-databases --socket=/var/lib/mysql/ mysql.sock > backup-reviewboard.sql On Oct 27, 3:41 pm, Kunjal wrote: > Hello Chris, > > I have installed RB 1.0.3 on VM. > > I wanted that RB 1.0.3 release should have existing RB database so I > copied over the RB database and then perform rb-site upgrade. > I did not get any error messages while doing rb-site upgrade. > After upgrade, What I see is that user table is ported correctly. But > all the reviews are not visible in dashboard. > Where they go? > > Kunjal --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Existing Reviews not visible after rb-site upgrade
It is mysql database and we tar it on one server and untar it on the server where RB1.0.3 installed. Is there any better way to copy over? On Oct 27, 3:41 pm, Kunjal wrote: > Hello Chris, > > I have installed RB 1.0.3 on VM. > > I wanted that RB 1.0.3 release should have existing RB database so I > copied over the RB database and then perform rb-site upgrade. > I did not get any error messages while doing rb-site upgrade. > After upgrade, What I see is that user table is ported correctly. But > all the reviews are not visible in dashboard. > Where they go? > > Kunjal --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Existing Reviews not visible after rb-site upgrade
Hello Chris, I have installed RB 1.0.3 on VM. I wanted that RB 1.0.3 release should have existing RB database so I copied over the RB database and then perform rb-site upgrade. I did not get any error messages while doing rb-site upgrade. After upgrade, What I see is that user table is ported correctly. But all the reviews are not visible in dashboard. Where they go? Kunjal --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Database Migration from RB-Beta to RB-1.0.3
Thanks Chris, The existing reviewboard database is on machine X. The new RB installation is on machine Y. When I run the rb-site upgrade on machine Y, how it will find the database stored in machine X? -Kunjal On Oct 20, 5:07 pm, Christian Hammond wrote: > Hi, > > We use a database schema migration tool called django-evolution, which > rb-site invokes on upgrades. You should be able to move your existing > database and site installation over to the new server, install the new > Review Board 1.0.4, and run rb-site upgrade on the site directory. > > Of course, make sure you have a backup in case anything goes wrong. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Tue, Oct 20, 2009 at 4:14 PM, Kunjal wrote: > > > Hello, > > > We have existing RB-Beta setup on linux machine. > > We have MySql database with lots of review data. (20,000 +) > > Now, as more and more team are comply with ReviewBoard usage, we want > > to move foraward with RB 1.0.3. > > > We have purchased new server to install latest version. My issue is > > how the existing database from RB-Beta verison will migrate to > > RB-1.0.3? > > > Do you provide any tool utility to export database tables in such a > > way that if you have introduce any new tables as part of latest 1.0.3 > > release, our data still remains ok? > > > Thanks > > Kunjal > > > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en > > -~--~~~~--~~--~--~ Hide quoted text - > > - Show quoted text - --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Database Migration from RB-Beta to RB-1.0.3
Hello, We have existing RB-Beta setup on linux machine. We have MySql database with lots of review data. (20,000 +) Now, as more and more team are comply with ReviewBoard usage, we want to move foraward with RB 1.0.3. We have purchased new server to install latest version. My issue is how the existing database from RB-Beta verison will migrate to RB-1.0.3? Do you provide any tool utility to export database tables in such a way that if you have introduce any new tables as part of latest 1.0.3 release, our data still remains ok? Thanks Kunjal --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: LDAP Authentication with 1.0.3
FYI... We got it working after we change the authenticatoin to Active Directory. Thanks for all your help. On Sep 29, 2:02 pm, Christian Hammond wrote: > Hi, > > Does Apache have write access to that directory? If logging is actually > enabled, it should be writing to a reviewboard.log file, as long as the > directory is either owned by the Apache process's user or is world-writable. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.review-board.org > VMware, Inc. -http://www.vmware.com > > > > On Tue, Sep 29, 2009 at 1:53 PM, Kunjal wrote: > > > Chris, > > > Finally, after few tries now the Enable logging does not go back to > > default. > > My log dir. is set at /projects/mob_tools/xampp/1.6.4-brcm-v2/htdocs/ > > reviewboard/logs > > > Now, I try to login to RB using my windows username/password which > > uses LDAP. > > I get message saying incorrect username/password. > > Now, when I look at the log dir. there is nothing there. > > > What should I do? > > > Kunjal > > > On Sep 29, 1:03 pm, Christian Hammond wrote: > > > Hi Kunjal, > > > > After setting the log directory and enabling logging, restart Apache. It > > > should then start logging on the next request. > > > > It seems some people have issues with the settings not sticking while > > others > > > don't. Can you tell me what you're using for server-side caching > > (memcached? > > > file-based?), whether you're using mod_python or fastcgi, and whether > > Apache > > > is configured for pre-fork or worker threads? > > > > Christian > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.review-board.org > > > VMware, Inc. -http://www.vmware.com > > > > On Tue, Sep 29, 2009 at 11:07 AM, Kunjal > > wrote: > > > > > One more question. > > > > > How to enable logging? > > > > > I went in to Settings->Logging and enable logging and set the log dir > > > > as well. > > > > however, the settings are re-set to default every time I log out and > > > > log in back. > > > > > Is there any way to see log while I try LDAP authentication? > > > > > Thanks > > > > Kunjal > > > > > On Sep 28, 2:25 pm, Kunjal wrote: > > > > > Thanks. > > > > > I do have one admin user in RB which has its own username/password. > > > > > Let me do some more debug. > > > > > > Thanks for your prompt help. > > > > > > Kunjal > > > > > > On Sep 28, 2:19 pm, Christian Hammond wrote: > > > > > > > Sorry, when I said to make the change, I meant to set up the LDAP > > > > > > authentication settings, and then restart Apache. > > > > > > > I don't know why you aren't able to log in after doing that. Did > > you > > > > check > > > > > > the Review Board log file? You may have to enable this first in Log > > > > > > Settings. > > > > > > > Did you initially create an administrator user that doesn't exist > > on > > > > your > > > > > > LDAP server? It's good to have at least one admin user that doesn't > > use > > > > LDAP > > > > > > for authentication but instead uses the built-in authentication, in > > > > case > > > > > > there are issues with logging in to the LDAP server. > > > > > > > You shouldn't need the memcached support for logging in, but you > > will > > > > want > > > > > > it before the server is production-ready. > > > > > > > Christian > > > > > > > -- > > > > > > Christian Hammond - chip...@chipx86.com > > > > > > Review Board -http://www.review-board.org > > > > > > VMware, Inc. -http://www.vmware.com > > > > > > > On Mon, Sep 28, 2009 at 2:15 PM, Kunjal > > > > wrote: > > > > > > > > Thanks for prompt answer. > > > > > > > > You said that " Try making the change ". > > > > > > > What change? Can you explain further? > > > > > > > > Here is I observed now. I keep updating LDAP settings even if > > restore > > > > > > > to default. > > > > > > > Now,
Re: LDAP Authentication with 1.0.3
Chris, Finally, after few tries now the Enable logging does not go back to default. My log dir. is set at /projects/mob_tools/xampp/1.6.4-brcm-v2/htdocs/ reviewboard/logs Now, I try to login to RB using my windows username/password which uses LDAP. I get message saying incorrect username/password. Now, when I look at the log dir. there is nothing there. What should I do? Kunjal On Sep 29, 1:03 pm, Christian Hammond wrote: > Hi Kunjal, > > After setting the log directory and enabling logging, restart Apache. It > should then start logging on the next request. > > It seems some people have issues with the settings not sticking while others > don't. Can you tell me what you're using for server-side caching (memcached? > file-based?), whether you're using mod_python or fastcgi, and whether Apache > is configured for pre-fork or worker threads? > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.review-board.org > VMware, Inc. -http://www.vmware.com > > > > On Tue, Sep 29, 2009 at 11:07 AM, Kunjal wrote: > > > One more question. > > > How to enable logging? > > > I went in to Settings->Logging and enable logging and set the log dir > > as well. > > however, the settings are re-set to default every time I log out and > > log in back. > > > Is there any way to see log while I try LDAP authentication? > > > Thanks > > Kunjal > > > On Sep 28, 2:25 pm, Kunjal wrote: > > > Thanks. > > > I do have one admin user in RB which has its own username/password. > > > Let me do some more debug. > > > > Thanks for your prompt help. > > > > Kunjal > > > > On Sep 28, 2:19 pm, Christian Hammond wrote: > > > > > Sorry, when I said to make the change, I meant to set up the LDAP > > > > authentication settings, and then restart Apache. > > > > > I don't know why you aren't able to log in after doing that. Did you > > check > > > > the Review Board log file? You may have to enable this first in Log > > > > Settings. > > > > > Did you initially create an administrator user that doesn't exist on > > your > > > > LDAP server? It's good to have at least one admin user that doesn't use > > LDAP > > > > for authentication but instead uses the built-in authentication, in > > case > > > > there are issues with logging in to the LDAP server. > > > > > You shouldn't need the memcached support for logging in, but you will > > want > > > > it before the server is production-ready. > > > > > Christian > > > > > -- > > > > Christian Hammond - chip...@chipx86.com > > > > Review Board -http://www.review-board.org > > > > VMware, Inc. -http://www.vmware.com > > > > > On Mon, Sep 28, 2009 at 2:15 PM, Kunjal > > wrote: > > > > > > Thanks for prompt answer. > > > > > > You said that " Try making the change ". > > > > > What change? Can you explain further? > > > > > > Here is I observed now. I keep updating LDAP settings even if restore > > > > > to default. > > > > > Now, What I see is that I login/logout as admin few times, and LDAP > > > > > settings are there. > > > > > They stop getting set to default. > > > > > > Then I restarted apached but still I could not login in RB using my > > > > > authentication. Do I need to have memchached installed first? > > > > > We are in middle of RB installation so I think we still need to > > > > > install patch, cmemcache and libmemcache > > > > > > Thanks > > > > > Kunjal > > > > > > On Sep 28, 1:45 pm, Christian Hammond wrote: > > > > > > Hi, > > > > > > > There's a bug with saving some authentication settings. The changes > > don't > > > > > > make it to all the Python threads. Try making the change and > > restarting > > > > > > Apache. > > > > > > > As for settings_local.py, the configuration options aren't actually > > saved > > > > > > there. We have in-database settings that get pulled out and put > > into an > > > > > > in-memory version of the settings file. This works well for the > > most > > > > > part, > > > > > > except the thread propagation, which I thought we had fixed, but > > > &
Re: LDAP Authentication with 1.0.3
One more question. How to enable logging? I went in to Settings->Logging and enable logging and set the log dir as well. however, the settings are re-set to default every time I log out and log in back. Is there any way to see log while I try LDAP authentication? Thanks Kunjal On Sep 28, 2:25 pm, Kunjal wrote: > Thanks. > I do have one admin user in RB which has its own username/password. > Let me do some more debug. > > Thanks for your prompt help. > > Kunjal > > On Sep 28, 2:19 pm, Christian Hammond wrote: > > > > > Sorry, when I said to make the change, I meant to set up the LDAP > > authentication settings, and then restart Apache. > > > I don't know why you aren't able to log in after doing that. Did you check > > the Review Board log file? You may have to enable this first in Log > > Settings. > > > Did you initially create an administrator user that doesn't exist on your > > LDAP server? It's good to have at least one admin user that doesn't use LDAP > > for authentication but instead uses the built-in authentication, in case > > there are issues with logging in to the LDAP server. > > > You shouldn't need the memcached support for logging in, but you will want > > it before the server is production-ready. > > > Christian > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.review-board.org > > VMware, Inc. -http://www.vmware.com > > > On Mon, Sep 28, 2009 at 2:15 PM, Kunjal wrote: > > > > Thanks for prompt answer. > > > > You said that " Try making the change ". > > > What change? Can you explain further? > > > > Here is I observed now. I keep updating LDAP settings even if restore > > > to default. > > > Now, What I see is that I login/logout as admin few times, and LDAP > > > settings are there. > > > They stop getting set to default. > > > > Then I restarted apached but still I could not login in RB using my > > > authentication. Do I need to have memchached installed first? > > > We are in middle of RB installation so I think we still need to > > > install patch, cmemcache and libmemcache > > > > Thanks > > > Kunjal > > > > On Sep 28, 1:45 pm, Christian Hammond wrote: > > > > Hi, > > > > > There's a bug with saving some authentication settings. The changes > > > > don't > > > > make it to all the Python threads. Try making the change and restarting > > > > Apache. > > > > > As for settings_local.py, the configuration options aren't actually > > > > saved > > > > there. We have in-database settings that get pulled out and put into an > > > > in-memory version of the settings file. This works well for the most > > > part, > > > > except the thread propagation, which I thought we had fixed, but > > > apparently > > > > not. > > > > > Christian > > > > > -- > > > > Christian Hammond - chip...@chipx86.com > > > > Review Board -http://www.review-board.org > > > > VMware, Inc. -http://www.vmware.com > > > > > On Mon, Sep 28, 2009 at 1:27 PM, Kunjal wrote: > > > > > > Hello, > > > > > > We are evaluating RB 1.0.3. > > > > > We want LDAP Authentication so we install python-ldap and make changes > > > > > to LDAP Settings in Admin->Settings and then restart apache. > > > > > The LDAP authentication is not working. Few things to note. > > > > > > 1. When I go back to Admin->Settings, It again default back to > > > > > Standard Registration > > > > > > 2. the settings_local.py file does not have any info on LDAP. Do I > > > > > need to add LDAP info. in settings_local.py file as well? > > > > > > Pls. help. > > > > > > Thanks > > > > > Kunjal > > > > > Broadcom Inc.- Hide quoted text - > > > > > - Show quoted text -- Hide quoted text - > > > - Show quoted text -- Hide quoted text - > > - Show quoted text - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: LDAP Authentication with 1.0.3
Thanks. I do have one admin user in RB which has its own username/password. Let me do some more debug. Thanks for your prompt help. Kunjal On Sep 28, 2:19 pm, Christian Hammond wrote: > Sorry, when I said to make the change, I meant to set up the LDAP > authentication settings, and then restart Apache. > > I don't know why you aren't able to log in after doing that. Did you check > the Review Board log file? You may have to enable this first in Log > Settings. > > Did you initially create an administrator user that doesn't exist on your > LDAP server? It's good to have at least one admin user that doesn't use LDAP > for authentication but instead uses the built-in authentication, in case > there are issues with logging in to the LDAP server. > > You shouldn't need the memcached support for logging in, but you will want > it before the server is production-ready. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.review-board.org > VMware, Inc. -http://www.vmware.com > > > > On Mon, Sep 28, 2009 at 2:15 PM, Kunjal wrote: > > > Thanks for prompt answer. > > > You said that " Try making the change ". > > What change? Can you explain further? > > > Here is I observed now. I keep updating LDAP settings even if restore > > to default. > > Now, What I see is that I login/logout as admin few times, and LDAP > > settings are there. > > They stop getting set to default. > > > Then I restarted apached but still I could not login in RB using my > > authentication. Do I need to have memchached installed first? > > We are in middle of RB installation so I think we still need to > > install patch, cmemcache and libmemcache > > > Thanks > > Kunjal > > > On Sep 28, 1:45 pm, Christian Hammond wrote: > > > Hi, > > > > There's a bug with saving some authentication settings. The changes don't > > > make it to all the Python threads. Try making the change and restarting > > > Apache. > > > > As for settings_local.py, the configuration options aren't actually saved > > > there. We have in-database settings that get pulled out and put into an > > > in-memory version of the settings file. This works well for the most > > part, > > > except the thread propagation, which I thought we had fixed, but > > apparently > > > not. > > > > Christian > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.review-board.org > > > VMware, Inc. -http://www.vmware.com > > > > On Mon, Sep 28, 2009 at 1:27 PM, Kunjal wrote: > > > > > Hello, > > > > > We are evaluating RB 1.0.3. > > > > We want LDAP Authentication so we install python-ldap and make changes > > > > to LDAP Settings in Admin->Settings and then restart apache. > > > > The LDAP authentication is not working. Few things to note. > > > > > 1. When I go back to Admin->Settings, It again default back to > > > > Standard Registration > > > > > 2. the settings_local.py file does not have any info on LDAP. Do I > > > > need to add LDAP info. in settings_local.py file as well? > > > > > Pls. help. > > > > > Thanks > > > > Kunjal > > > > Broadcom Inc.- Hide quoted text - > > > > - Show quoted text -- Hide quoted text - > > - Show quoted text - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: LDAP Authentication with 1.0.3
Thanks for prompt answer. You said that " Try making the change ". What change? Can you explain further? Here is I observed now. I keep updating LDAP settings even if restore to default. Now, What I see is that I login/logout as admin few times, and LDAP settings are there. They stop getting set to default. Then I restarted apached but still I could not login in RB using my authentication. Do I need to have memchached installed first? We are in middle of RB installation so I think we still need to install patch, cmemcache and libmemcache Thanks Kunjal On Sep 28, 1:45 pm, Christian Hammond wrote: > Hi, > > There's a bug with saving some authentication settings. The changes don't > make it to all the Python threads. Try making the change and restarting > Apache. > > As for settings_local.py, the configuration options aren't actually saved > there. We have in-database settings that get pulled out and put into an > in-memory version of the settings file. This works well for the most part, > except the thread propagation, which I thought we had fixed, but apparently > not. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.review-board.org > VMware, Inc. -http://www.vmware.com > > > > On Mon, Sep 28, 2009 at 1:27 PM, Kunjal wrote: > > > Hello, > > > We are evaluating RB 1.0.3. > > We want LDAP Authentication so we install python-ldap and make changes > > to LDAP Settings in Admin->Settings and then restart apache. > > The LDAP authentication is not working. Few things to note. > > > 1. When I go back to Admin->Settings, It again default back to > > Standard Registration > > > 2. the settings_local.py file does not have any info on LDAP. Do I > > need to add LDAP info. in settings_local.py file as well? > > > Pls. help. > > > Thanks > > Kunjal > > Broadcom Inc.- Hide quoted text - > > - Show quoted text - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
LDAP Authentication with 1.0.3
Hello, We are evaluating RB 1.0.3. We want LDAP Authentication so we install python-ldap and make changes to LDAP Settings in Admin->Settings and then restart apache. The LDAP authentication is not working. Few things to note. 1. When I go back to Admin->Settings, It again default back to Standard Registration 2. the settings_local.py file does not have any info on LDAP. Do I need to add LDAP info. in settings_local.py file as well? Pls. help. Thanks Kunjal Broadcom Inc. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: ReviewBoard + GIT Integration
Thanks a lot Matthew for your time. Kunjal On Sep 16, 9:13 am, Matthew Woehlke wrote: > (Inline quoting is preferred, thanks!) > > On 2009-09-16 10:57, Kunjal wrote: > > > so, the post-review script will work as is in Red-Hat linux > > environment? > > If the Python deps are met, it should. In my environment I have a > local-built copy of Python (with the needed modules, though I think it > is just simplejson, so not actually "modules" plural), ensuring that I > don't have problems with too-old Python or the like. It's built on RH3 > and as far as I know runs fine on RH3+ (though not sure if it would run > on non-RH/Fedora systems). > > If you are running RH5, you are probably fine. (Actually... if you are > running RH3/RH4, I am pretty sure that didn't have git and so you must > have built git locally anyway, so...) > > > Can some one post review from windows machine to GIT which is hosted > > on linux machine? > > Assuming you have git functional on the Windows machine, I think it > should work. Obviously, you'll also need Python :-). > > -- > Matthew --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Review Board 1.0.2 released
Chris, You can add Broadcom in the list. We use it for our MobCom group and users are happy !! Kunjal On Sep 16, 1:05 am, Christian Hammond wrote: > Hi everyone, > > We just put out the 1.0.2 release, which contains many bug fixes that users > have hit, and improved error logging to help diagnose problems. We strongly > encourage everyone to upgrade, and if you hit any new page crashes, we'll > probably ask you to upgrade and send us your log file. > > There's a brief news post > athttp://review-board.org/news/2009/09/16/review-board-102-released/ > > Full release notes are up > athttp://www.review-board.org/docs/releasenotes/dev/reviewboard/1.0.2/ > > As always, we're looking to fill out our page of Happy Users > (http://review-board.org/users/), so if you use Review Board and can give us > permission to list you, please let us know! > > Thanks, > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.review-board.org > VMware, Inc. -http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: ReviewBoard + GIT Integration
Thanks Matthew, so, the post-review script will work as is in Red-Hat linux environment? Can some one post review from windows machine to GIT which is hosted on linux machine? Thanks Kunjal On Sep 15, 4:25 pm, Matthew Woehlke wrote: > On 2009-09-15 18:07, Kunjal wrote: > > > We already have RB integrated with Perforce and it is working cool. > > Now, we have some developers working in GIT and we want to review that > > code as well. > > What are the steps developer should perform to get the diff and post > > the review? > > Save yourself a whole lot of trouble and use post-review :-). > > Or to answer your question more literally, here are the steps: > $ post-review -d # > > ...and you can omit -d if you don't want the noise of seeing what it is > doing. (You'll also need to install RBTools once per machine, or else > just snag postreview.py and make sure everyone has a copy.) > > -- > Matthew --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
ReviewBoard + GIT Integration
Hello, We already have RB integrated with Perforce and it is working cool. Now, we have some developers working in GIT and we want to review that code as well. Where should I start? What are the steps developer should perform to get the diff and post the review? Any info. in this regard will be helpful. Thanks --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: need help to integrate post-review with Perforce
Is RB installed on Linux or Windows? On Tue, Jun 9, 2009 at 1:34 AM, Amit wrote: > > Hi, > > I downloaded RBTools-0.2beta. afterwords i have no clue how to proceed > for integrating post-review into Perforce. > Any help will be highly appreciated. > > -Amit > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
