Re: Formatting errors in description field
Unfortunately that didn't help: using RBTools 0.6.2 it still is not correctly formatted Am Montag, 28. Juli 2014 22:29:16 UTC+2 schrieb David Trowbridge: I believe that things should be fixed just by upgrading your version of rbtools and swapping out 'post-review' for 'rbt post'. -David On Mon, Jul 28, 2014 at 1:22 PM, Philip Schiffer philip@sprylab.com javascript: wrote: We are all creating our review with this git alias: prd = !sh -c 'git fetch origin git push origin -u $(git name-rev --name-only HEAD) post-review -d --guess-summary --description=\$(git log origin/develop...HEAD)\ --branch=$(git name-rev --name-only HEAD) --tracking-branch=origin/develop --target-groups=$(git config reviewboard.group) --repository-url=$(git config reviewboard.repository) --server=$(git config reviewboard.url) --open' Am Montag, 28. Juli 2014 22:10:30 UTC+2 schrieb David Trowbridge: How are you putting the git log into the description? By hand? With the JSON API? Using arguments to post-review? -David On Mon, Jul 28, 2014 at 1:54 AM, Philip Schiffer philip@sprylab.com wrote: Okay, can that be fixed? I don't want to change our templates. Or can markdown be disabled? Am Freitag, 25. Juli 2014 23:51:20 UTC+2 schrieb David Trowbridge: OK, I believe that the problem is the indentation. Markdown treats indented text as a code block, and won't handle any markdown syntax in it. -David On Thu, Jul 24, 2014 at 11:15 PM, Philip Schiffer philip@sprylab.com wrote: Sorry for the late answer - I did not get any notification :/ Am Donnerstag, 17. Juli 2014 22:30:38 UTC+2 schrieb David Trowbridge: Can you show what the source markdown looks like? (Click the pencil and then copy/paste/redact) -David On Thu, Jul 17, 2014 at 2:34 AM, Philip Schiffer philip@sprylab.com wrote: Hello everyone, I have upgraded our reviewboard installation from 1.7.x to 2.0.3. Unfortunately we have some issues with the formatting of the description field. We are using the post-review tool in our scripts to post our reviews. Inside the description field we put the git commit log entries. As you can see in the attachment, there are problems displaying the links. I've searched the bug tracker but unfortunately I'm getting http 500 errors from google code for this issue: https://code.google.com/p/reviewboard/issues/detail?id=3377 -- Get the Review Board Power Pack at http://www.reviewboard.org/pow erpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/pow erpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/ powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Formatting errors in description field
It's not that important. It can stay that way. Am Dienstag, 29. Juli 2014 22:00:05 UTC+2 schrieb Christian Hammond: Hi Philip, We can’t, but we can delete the ticket. Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On July 29, 2014 at 3:29:22 AM, Philip Schiffer (philip@sprylab.com javascript:) wrote: I've created it: https://code.google.com/p/reviewboard/issues/detail?id=3503 (Can you redact the url? I forgot to do this :/) Am Dienstag, 29. Juli 2014 12:21:35 UTC+2 schrieb Christian Hammond: Hi Philip, Unless you specifically post with a flag enabling Markdown, we convert the text to valid Markdown. I believe when we do this, we don’t escape sequences of 4 spaces, which ends up triggering Markdown’s inline mode. So, this is a bug in Review Board. We would need to basically recognize 4+ leading spaces and insert some backslashes (which is ugly, but necessary for this). Can you file a new bug for this? (The HTTP 500 errors on the bug tracker are annoying… We’ve been unable to get Google to care about this problem.) Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On July 29, 2014 at 3:14:57 AM, Philip Schiffer (philip@sprylab.com) wrote: Unfortunately that didn't help: using RBTools 0.6.2 it still is not correctly formatted Am Montag, 28. Juli 2014 22:29:16 UTC+2 schrieb David Trowbridge: I believe that things should be fixed just by upgrading your version of rbtools and swapping out 'post-review' for 'rbt post'. -David On Mon, Jul 28, 2014 at 1:22 PM, Philip Schiffer philip@sprylab.com wrote: We are all creating our review with this git alias: prd = !sh -c 'git fetch origin git push origin -u $(git name-rev --name-only HEAD) post-review -d --guess-summary --description=\$(git log origin/develop...HEAD)\ --branch=$(git name-rev --name-only HEAD) --tracking-branch=origin/develop --target-groups=$(git config reviewboard.group) --repository-url=$(git config reviewboard.repository) --server=$(git config reviewboard.url) --open' Am Montag, 28. Juli 2014 22:10:30 UTC+2 schrieb David Trowbridge: How are you putting the git log into the description? By hand? With the JSON API? Using arguments to post-review? -David On Mon, Jul 28, 2014 at 1:54 AM, Philip Schiffer philip@sprylab.com wrote: Okay, can that be fixed? I don't want to change our templates. Or can markdown be disabled? Am Freitag, 25. Juli 2014 23:51:20 UTC+2 schrieb David Trowbridge: OK, I believe that the problem is the indentation. Markdown treats indented text as a code block, and won't handle any markdown syntax in it. -David On Thu, Jul 24, 2014 at 11:15 PM, Philip Schiffer philip@sprylab.com wrote: Sorry for the late answer - I did not get any notification :/ Am Donnerstag, 17. Juli 2014 22:30:38 UTC+2 schrieb David Trowbridge: Can you show what the source markdown looks like? (Click the pencil and then copy/paste/redact) -David On Thu, Jul 17, 2014 at 2:34 AM, Philip Schiffer philip@sprylab.com wrote: Hello everyone, I have upgraded our reviewboard installation from 1.7.x to 2.0.3. Unfortunately we have some issues with the formatting of the description field. We are using the post-review tool in our scripts to post our reviews. Inside the description field we put the git commit log entries. As you can see in the attachment, there are problems displaying the links. I've searched the bug tracker but unfortunately I'm getting http 500 errors from google code for this issue: https://code.google.com/p/reviewboard/issues/detail?id=3377 -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org
Re: Formatting errors in description field
Okay, can that be fixed? I don't want to change our templates. Or can markdown be disabled? Am Freitag, 25. Juli 2014 23:51:20 UTC+2 schrieb David Trowbridge: OK, I believe that the problem is the indentation. Markdown treats indented text as a code block, and won't handle any markdown syntax in it. -David On Thu, Jul 24, 2014 at 11:15 PM, Philip Schiffer philip@sprylab.com javascript: wrote: Sorry for the late answer - I did not get any notification :/ Am Donnerstag, 17. Juli 2014 22:30:38 UTC+2 schrieb David Trowbridge: Can you show what the source markdown looks like? (Click the pencil and then copy/paste/redact) -David On Thu, Jul 17, 2014 at 2:34 AM, Philip Schiffer philip@sprylab.com wrote: Hello everyone, I have upgraded our reviewboard installation from 1.7.x to 2.0.3. Unfortunately we have some issues with the formatting of the description field. We are using the post-review tool in our scripts to post our reviews. Inside the description field we put the git commit log entries. As you can see in the attachment, there are problems displaying the links. I've searched the bug tracker but unfortunately I'm getting http 500 errors from google code for this issue: https://code.google.com/p/ reviewboard/issues/detail?id=3377 -- Get the Review Board Power Pack at http://www.reviewboard.org/ powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Formatting errors in description field
We are all creating our review with this git alias: prd = !sh -c 'git fetch origin git push origin -u $(git name-rev --name-only HEAD) post-review -d --guess-summary --description=\$(git log origin/develop...HEAD)\ --branch=$(git name-rev --name-only HEAD) --tracking-branch=origin/develop --target-groups=$(git config reviewboard.group) --repository-url=$(git config reviewboard.repository) --server=$(git config reviewboard.url) --open' Am Montag, 28. Juli 2014 22:10:30 UTC+2 schrieb David Trowbridge: How are you putting the git log into the description? By hand? With the JSON API? Using arguments to post-review? -David On Mon, Jul 28, 2014 at 1:54 AM, Philip Schiffer philip@sprylab.com javascript: wrote: Okay, can that be fixed? I don't want to change our templates. Or can markdown be disabled? Am Freitag, 25. Juli 2014 23:51:20 UTC+2 schrieb David Trowbridge: OK, I believe that the problem is the indentation. Markdown treats indented text as a code block, and won't handle any markdown syntax in it. -David On Thu, Jul 24, 2014 at 11:15 PM, Philip Schiffer philip@sprylab.com wrote: Sorry for the late answer - I did not get any notification :/ Am Donnerstag, 17. Juli 2014 22:30:38 UTC+2 schrieb David Trowbridge: Can you show what the source markdown looks like? (Click the pencil and then copy/paste/redact) -David On Thu, Jul 17, 2014 at 2:34 AM, Philip Schiffer philip@sprylab.com wrote: Hello everyone, I have upgraded our reviewboard installation from 1.7.x to 2.0.3. Unfortunately we have some issues with the formatting of the description field. We are using the post-review tool in our scripts to post our reviews. Inside the description field we put the git commit log entries. As you can see in the attachment, there are problems displaying the links. I've searched the bug tracker but unfortunately I'm getting http 500 errors from google code for this issue: https://code.google.com/p/ reviewboard/issues/detail?id=3377 -- Get the Review Board Power Pack at http://www.reviewboard.org/pow erpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/ powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Formatting errors in description field
Sorry for the late answer - I did not get any notification :/ Am Donnerstag, 17. Juli 2014 22:30:38 UTC+2 schrieb David Trowbridge: Can you show what the source markdown looks like? (Click the pencil and then copy/paste/redact) -David On Thu, Jul 17, 2014 at 2:34 AM, Philip Schiffer philip@sprylab.com javascript: wrote: Hello everyone, I have upgraded our reviewboard installation from 1.7.x to 2.0.3. Unfortunately we have some issues with the formatting of the description field. We are using the post-review tool in our scripts to post our reviews. Inside the description field we put the git commit log entries. As you can see in the attachment, there are problems displaying the links. I've searched the bug tracker but unfortunately I'm getting http 500 errors from google code for this issue: https://code.google.com/p/reviewboard/issues/detail?id=3377 -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
