Re: Merging/combining two Reviewboard servers together

2021-01-20 Thread Rob Petti
Thanks, Christian! I suspected as much. Import/export may help with doing
this, but we'll discuss internally to see how we want to proceed. Worse
case, we'll just run and maintain multiple instances.

Thanks again!
~Rob

On Wed, Jan 20, 2021 at 2:07 PM Christian Hammond 
wrote:

> Hi Rob,
>
> Sorry for the late response here.
>
> There isn't really a way of doing this right now. We do have import/export
> capabilities being worked on for Power Pack, but as review requests rely on
> IDs, and two cannot share the same IDs, you'll be limited to one of two
> options:
>
> 1. Changing the IDs on all review requests being merged in.
> 2. Putting the review requests in their own Local Site (a sort of
> self-contained partition within a Review Board server). This would alter
> the URLs, but preserve the review request IDs. The IDs for reviews,
> comments, etc. would not be preserved.
>
> This feature is still in development. We've been working with support
> customers on testing it as we continue to develop it. If you were to use
> it, I'd advise testing it thoroughly on a test copy of the server and
> databases.
>
> Christian
>
> On Fri, Jan 15, 2021 at 12:12 PM rob@gmail.com 
> wrote:
>
>> Hi All,
>>
>> Has anyone tried to merge two reviewboard servers together? We've
>> recently acquired a new one, and are looking for ways to combine them into
>> a single server, if possible.
>>
>> I'm assuming it's not (or if it is, it's very extremely complex) but just
>> thought I'd ask first.
>>
>> ~Rob
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/reviewboard/d17cd058-c75e-4294-a310-12550bf0b46bn%40googlegroups.com
>> <https://groups.google.com/d/msgid/reviewboard/d17cd058-c75e-4294-a310-12550bf0b46bn%40googlegroups.com?utm_medium=email_source=footer>
>> .
>>
>
>
> --
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to a topic in the
> Google Groups "Review Board Community" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/reviewboard/A4aDFMNRfQE/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/CAE7Vnd%3D8027iQff1GFnQgxYNHN5Jog_AbeMVzhzwHcyZvJ7u7w%40mail.gmail.com
> <https://groups.google.com/d/msgid/reviewboard/CAE7Vnd%3D8027iQff1GFnQgxYNHN5Jog_AbeMVzhzwHcyZvJ7u7w%40mail.gmail.com?utm_medium=email_source=footer>
> .
>


-- 
<https://about.me/robpetti?promo=email_sig_source=product_medium=email_sig_campaign=gmail_api_content=thumb>
Rob Petti
about.me/robpetti
<https://about.me/robpetti?promo=email_sig_source=product_medium=email_sig_campaign=gmail_api_content=thumb>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CABH9TsJbNMNKA8VmZ9mXKO6h2h886G6Md0r189MfK8f-z7%3DiWQ%40mail.gmail.com.


Re: Cannot load commits from hgweb when using strange branch name

2020-02-12 Thread Rob Petti
Thanks, André

We had the user rename the branch instead and that seemed to work. Your fix
looks fine (though I'm also not able to test it) so hopefully the devs will
put it into a release in the future.

~Rob

On Wed, Feb 12, 2020 at 3:59 AM André Klitzing  wrote:

> Hi,
>
> seems your branch name needs url encoding. Maybe you could try this
> quickfix.
> I did not test it as I don't have a development environment at the moment.
> So sorry if it throws errors.
>
> diff --git a/reviewboard/scmtools/hg.py b/reviewboard/scmtools/hg.py
> index bbf70cd7c..1e3fca175 100644
> --- a/reviewboard/scmtools/hg.py
> +++ b/reviewboard/scmtools/hg.py
> @@ -378,7 +378,8 @@ class HgWebClient(SCMClient):
>  if start:
>  query_parts.append('ancestors(%s)' % start)
>
> -query_parts.append('branch(%s)' % (branch or '.'))
> +import urllib.parse
> +query_parts.append('branch(%s)' %
> (urllib.parse.quote_plus(branch) or '.'))
>
>  query = '+and+'.join(query_parts)
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to a topic in the
> Google Groups "Review Board Community" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/reviewboard/vdmj1o_moY8/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/81cc588e-c12d-4ff5-a76b-466603cbc942%40googlegroups.com
> <https://groups.google.com/d/msgid/reviewboard/81cc588e-c12d-4ff5-a76b-466603cbc942%40googlegroups.com?utm_medium=email_source=footer>
> .
>


-- 
<https://about.me/robpetti?promo=email_sig_source=product_medium=email_sig_campaign=gmail_api_content=thumb>
Rob Petti
about.me/robpetti
<https://about.me/robpetti?promo=email_sig_source=product_medium=email_sig_campaign=gmail_api_content=thumb>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CABH9TsJ8enkBp_%3DD2z70FxdEWbNF8OhvgqvGJW1NrDWjrpupfg%40mail.gmail.com.


Cannot load commits from hgweb when using strange branch name

2020-02-04 Thread Rob Petti
Hi Folks,

I'm currently running into the following issue when trying to view changes 
in a particular mercurial branch. No changes show up and no error message 
is visible in the UI. The server log dumps this out:

2020-02-04 15:47:22,688 - ERROR -  - root - Cannot load commits from hgweb: 
Unexpected error fetching file from 
http://mercurial.XX.net/xx/x/json-log/?rev=ancestors(08d863d1ad70a60fcae7afe9394206fb2d2c0fac)+and+branch(X-12371
 
& X-10577): URL can't contain control characters. 
u'/xx/xx/json-log/?rev=ancestors(08d863d1ad70a60fcae7afe9394206fb2d2c0fac)+and+branch(X-12371
 
& X-10577)' (found at least u' ')
Traceback (most recent call last):
  File 
"/opt/venv/local/lib/python2.7/site-packages/reviewboard/scmtools/hg.py", 
line 386, in get_commits
contents = self.get_file_http(url, '', '', 'application/json')
  File 
"/opt/venv/local/lib/python2.7/site-packages/reviewboard/scmtools/core.py", 
line 1163, in get_file_
http
raise SCMError(msg)

I'm guessing it's having difficulty handling the branch name "X-12371 & 
X-10577"? Other branches don't seem to have this issue.

~Rob

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/1669d03e-058b-4b9b-b27f-d12ff7c128f4%40googlegroups.com.


Re: "There was an error displaying this diff" when diffing a file that contains a "#" in the filename.

2019-08-27 Thread Rob Petti
Hey Folks,

I've managed to narrow it down some more. It appears to be a problem in 
scmtools/svn/pysvn.py.

def _do_on_path(self, cb, path, revision=HEAD):
if not path:
raise FileNotFoundError(path, revision)

try:
# path == 
"src/cws/QMS/Entities/NonconformanceBase#cws-nativeentity#.cws"
normpath = self.normalize_path(path)
# normpath == 
"https://subversion.ourdomain.net/repos/bpm-spa/trunk/applications/qualitycenter/src/cws/QMS/Entities/NonconformanceBase#cws-nativeentity#.cws;

# SVN expects to have URLs escaped. Take care to only
# escape the path part of the URL.
if self.client.is_url(normpath):
pathtuple = urlsplit(normpath)
path = pathtuple[2]
if isinstance(path, six.text_type):
path = path.encode('utf-8', 'ignore')
normpath = urlunsplit((pathtuple[0],
   pathtuple[1],
   quote(path),
   '', ''))

# normpath == 
"https://subversion.ourdomain.net/repos/bpm-spa/trunk/applications/qualitycenter/src/cws/QMS/Entities/NonconformanceBase;
normrev = self._normalize_revision(revision)
return cb(normpath, normrev)


As you can see, it combines the path naively into a URL without escaping 
any characters, then tries to parse it as a URL to URL-escape the path 
portion of it, which obviously won't work.

I was able to fix my problem by changing the code as below. It didn't make 
any sense to me that it would parse it as a URL before escaping it, so I 
removed that whole section of the code and just encoded the file path 
before normalizing it.
def _do_on_path(self, cb, path, revision=HEAD):
if not path:
raise FileNotFoundError(path, revision)

try:
normpath = self.normalize_path(quote(path.encode('utf-8', 
'ignore')))

normrev = self._normalize_revision(revision)
return cb(normpath, normrev)


If this makes sense, should I open a review with my proposed changes?

On Thursday, 22 August 2019 13:34:16 UTC-6, Rob Petti wrote:
>
> Hi Folks,
>
> We're having an issue with one of our SVN repositories right now. It 
> appears almost as if ReviewBoard can't handle files that contain "#" in 
> their names. I've attached a screenshot of the error. Of particular note is 
> that the error seems to suggest that it's truncating the filename from '#' 
> and erroneously trying to use that to locate the file in the repository.
>
> Would anyone know how to overcome this problem? Obviously we could work 
> around it by changing the file names, but this is a naming convention 
> that's required by our product and cannot be changed.
>
> Thanks!
> ~Rob
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/533d838b-61ab-4263-a1c6-2dbd3a0b61e7%40googlegroups.com.


"There was an error displaying this diff" when diffing a file that contains a "#" in the filename.

2019-08-22 Thread Rob Petti
Hi Folks,

We're having an issue with one of our SVN repositories right now. It 
appears almost as if ReviewBoard can't handle files that contain "#" in 
their names. I've attached a screenshot of the error. Of particular note is 
that the error seems to suggest that it's truncating the filename from '#' 
and erroneously trying to use that to locate the file in the repository.

Would anyone know how to overcome this problem? Obviously we could work 
around it by changing the file names, but this is a naming convention 
that's required by our product and cannot be changed.

Thanks!
~Rob

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/9c1c7ba7-0581-4bd2-98b0-d6d584241c7f%40googlegroups.com.


Re: "Unrecognized URL scheme" for http SVN urls

2018-02-01 Thread Rob Petti
It looks like my hunch was correct. The person who originally configured
this server used a yum repo from "Wandisco" in order to install subversion,
and apparently it libraries did not play nicely with the libraries used by
wsgi or reviewboard. I removed the repo, downgraded subversion to the
version provided by the distribution, recompiled pysvn, and everything
appears to be working fine now!

Thanks for the help! Telling me that it was an error directly from libsvn
was enough to set me on the right track. :)

~Rob

On Thu, Feb 1, 2018 at 10:45 AM, Rob Petti <rob.pe...@gmail.com> wrote:

> > rbt diff
> Index: /16.4.0/run-tests.js
> ===
> --- /16.4.0/run-tests.js(revision 1315)
> +++ /16.4.0/run-tests.js(working copy)
> @@ -1,3 +1,4 @@
> +//test
>  var appconfig = require(process.env.CCE2E_APPCONFIG_FILE ||
> "./config/config.json");
>  var variables = require("./config/variables.json");
>  var elelocator = require("./config/elements_locator.json");
> @@ -93,4 +94,4 @@
>  takeScreenShotsOnlyForFailedSpecs: true
>  }));
>  }
> -};
> \ No newline at end of file
> +};
>
> We also noticed that the error presents itself in the WebUI on the new
> review screen before even selecting any files or diffs, so it doesn't seem
> related to the diffing:
>
>
> <https://lh3.googleusercontent.com/-xv-5iuE6w74/WnM9tEqc3WI/Bn0/npbwAsbI83491plipXi6tVHBg7zmP64aQCLcBGAs/s1600/rb-error.PNG>
> I did some more digging of my own, and I suspect it's a shared library
> loading issue, since the same error is thrown when libsvn_ra_serf can't be
> located or loaded. When I run basically the same pysvn API code directly
> from python it works fine, but from Apache mod_wsgi or uwsgi it fails. I
> may end up having to recompile the whole stack.
>
>
> On Wednesday, 31 January 2018 20:08:03 UTC-7, Christian Hammond wrote:
>
>> Hi Rob,
>>
>> Let's make sure it doesn't have to do with file-based lookups. We may
>> need to run some tests. First, can you generate a diff with `rbt diff`, and
>> then check the resulting diff for the run-tests.js file. I need the "---",
>> "+++", and "Index:" lines for that entry.
>>
>> Christian
>>
>> On Tue, Jan 30, 2018 at 9:41 PM, Rob Petti <rob@gmail.com> wrote:
>>
>>> Hi Christian,
>>>
>>> I tested pysvn on our server by just using it to successfully checkout
>>> the repo in question:
>>>
>>> [root@wlrbprod01 ~]# /usr/local/bin/python
>>> Python 2.7.5 (default, Nov  5 2017, 11:12:51)
>>> [GCC 4.4.7 20120313 (Red Hat 4.4.7-18)] on linux2
>>> Type "help", "copyright", "credits" or "license" for more information.
>>> >>> import pysvn
>>> >>> client = pysvn.Client()
>>> >>> client.checkout("http://10.XX.XX.XX:89/svn/ourproject/16.4.0
>>> ","/tmp/test")
>>> 
>>>
>>> The ReviewBoard logs don't show this failure or a trace for it, and I'm
>>> not sure how to get more debugging information out of it. As near as I can
>>> tell, both my test and reviewboard are using the exact same set of shared
>>> libraries for both pysvn and libsvn, including libsvn_ra_serf, which I
>>> believe provides the support for http schemas. This should be working, but
>>> I can't figure out why it isn't.
>>>
>>>
>>> On Tuesday, 30 January 2018 19:10:12 UTC-7, Christian Hammond wrote:
>>>>
>>>> Hi Rob,
>>>>
>>>> This error is coming directly from libsvn (by way of PySVN).
>>>>
>>>> Can you show me the command line and PySVN testing you performed for
>>>> this on the server?
>>>>
>>>> Christian
>>>>
>>>> On Tue, Jan 30, 2018 at 1:40 PM, Rob Petti <rob@gmail.com> wrote:
>>>>
>>>>> Hi there,
>>>>>
>>>>> I'm currently using ReviewBoard 2.5.16, and we're running into issues
>>>>> using it with http svn urls. Any time we try to post reviews we get this
>>>>> error back:
>>>>> Unrecognized URL scheme for 'http://10.XX.XX.XX:89/svn/our
>>>>> project/16.4.0/run-tests.js' (HTTP 400, API Error 224)
>>>>>
>>>>> I already checked the svn CLI installed on the RB host server, and it
>>>>> has http/https support:
>>>>> [root@wlrbprod01 conf]# svn --version
&g

Re: "Unrecognized URL scheme" for http SVN urls

2018-02-01 Thread Rob Petti
> rbt diff
Index: /16.4.0/run-tests.js
===
--- /16.4.0/run-tests.js(revision 1315)
+++ /16.4.0/run-tests.js(working copy)
@@ -1,3 +1,4 @@
+//test
 var appconfig = require(process.env.CCE2E_APPCONFIG_FILE || 
"./config/config.json");
 var variables = require("./config/variables.json");
 var elelocator = require("./config/elements_locator.json");
@@ -93,4 +94,4 @@
 takeScreenShotsOnlyForFailedSpecs: true
 }));
 }
-};
\ No newline at end of file
+};

We also noticed that the error presents itself in the WebUI on the new 
review screen before even selecting any files or diffs, so it doesn't seem 
related to the diffing:

<https://lh3.googleusercontent.com/-xv-5iuE6w74/WnM9tEqc3WI/Bn0/npbwAsbI83491plipXi6tVHBg7zmP64aQCLcBGAs/s1600/rb-error.PNG>
I did some more digging of my own, and I suspect it's a shared library 
loading issue, since the same error is thrown when libsvn_ra_serf can't be 
located or loaded. When I run basically the same pysvn API code directly 
from python it works fine, but from Apache mod_wsgi or uwsgi it fails. I 
may end up having to recompile the whole stack.


On Wednesday, 31 January 2018 20:08:03 UTC-7, Christian Hammond wrote:

> Hi Rob,
>
> Let's make sure it doesn't have to do with file-based lookups. We may need 
> to run some tests. First, can you generate a diff with `rbt diff`, and then 
> check the resulting diff for the run-tests.js file. I need the "---", 
> "+++", and "Index:" lines for that entry.
>
> Christian
>
> On Tue, Jan 30, 2018 at 9:41 PM, Rob Petti <rob@gmail.com 
> > wrote:
>
>> Hi Christian,
>>
>> I tested pysvn on our server by just using it to successfully checkout 
>> the repo in question:
>>
>> [root@wlrbprod01 ~]# /usr/local/bin/python
>> Python 2.7.5 (default, Nov  5 2017, 11:12:51) 
>> [GCC 4.4.7 20120313 (Red Hat 4.4.7-18)] on linux2
>> Type "help", "copyright", "credits" or "license" for more information.
>> >>> import pysvn
>> >>> client = pysvn.Client()
>> >>> client.checkout("http://10.XX.XX.XX:89/svn/ourproject/16.4.0
>> ","/tmp/test")
>> 
>>
>> The ReviewBoard logs don't show this failure or a trace for it, and I'm 
>> not sure how to get more debugging information out of it. As near as I can 
>> tell, both my test and reviewboard are using the exact same set of shared 
>> libraries for both pysvn and libsvn, including libsvn_ra_serf, which I 
>> believe provides the support for http schemas. This should be working, but 
>> I can't figure out why it isn't.
>>
>>
>> On Tuesday, 30 January 2018 19:10:12 UTC-7, Christian Hammond wrote:
>>>
>>> Hi Rob,
>>>
>>> This error is coming directly from libsvn (by way of PySVN).
>>>
>>> Can you show me the command line and PySVN testing you performed for 
>>> this on the server?
>>>
>>> Christian
>>>
>>> On Tue, Jan 30, 2018 at 1:40 PM, Rob Petti <rob@gmail.com> wrote:
>>>
>>>> Hi there,
>>>>
>>>> I'm currently using ReviewBoard 2.5.16, and we're running into issues 
>>>> using it with http svn urls. Any time we try to post reviews we get this 
>>>> error back:
>>>> Unrecognized URL scheme for '
>>>> http://10.XX.XX.XX:89/svn/ourproject/16.4.0/run-tests.js' (HTTP 400, 
>>>> API Error 224)
>>>>
>>>> I already checked the svn CLI installed on the RB host server, and it 
>>>> has http/https support:
>>>> [root@wlrbprod01 conf]# svn --version
>>>> svn, version 1.8.19 (r1800620)
>>>>compiled Aug 10 2017, 22:07:28 on x86_64-unknown-linux-gnu
>>>>
>>>> Copyright (C) 2017 The Apache Software Foundation.
>>>> This software consists of contributions made by many people;
>>>> see the NOTICE file for more information.
>>>> Subversion is open source software, see http://subversion.apache.org/
>>>>
>>>> The following repository access (RA) modules are available:
>>>>
>>>> * ra_svn : Module for accessing a repository using the svn network 
>>>> protocol.
>>>>   - with Cyrus SASL authentication
>>>>   - handles 'svn' scheme
>>>> * ra_local : Module for accessing a repository on local disk.
>>>>   - handles 'file' scheme
>>>> * ra_serf : Module for accessing a repository via WebDAV protocol using 
>>>> 

"Unrecognized URL scheme" for http SVN urls

2018-01-30 Thread Rob Petti
Hi there,

I'm currently using ReviewBoard 2.5.16, and we're running into issues using 
it with http svn urls. Any time we try to post reviews we get this error 
back:
Unrecognized URL scheme for 
'http://10.XX.XX.XX:89/svn/ourproject/16.4.0/run-tests.js' (HTTP 400, API 
Error 224)

I already checked the svn CLI installed on the RB host server, and it has 
http/https support:
[root@wlrbprod01 conf]# svn --version
svn, version 1.8.19 (r1800620)
   compiled Aug 10 2017, 22:07:28 on x86_64-unknown-linux-gnu

Copyright (C) 2017 The Apache Software Foundation.
This software consists of contributions made by many people;
see the NOTICE file for more information.
Subversion is open source software, see http://subversion.apache.org/

The following repository access (RA) modules are available:

* ra_svn : Module for accessing a repository using the svn network protocol.
  - with Cyrus SASL authentication
  - handles 'svn' scheme
* ra_local : Module for accessing a repository on local disk.
  - handles 'file' scheme
* ra_serf : Module for accessing a repository via WebDAV protocol using 
serf.
  - using serf 1.3.4
  - handles 'http' scheme
  - handles 'https' scheme


Additionally, I manually tested pysvn, and it also works with http urls.

I'm frankly at a loss here, so any assistance would be appreciated! The 
host server is an RHEL6 machine with Python 2.7 installed. The full log 
from rbt follows:

> rbt post -d -o
>>> RBTools 0.7.10
>>> Python 2.7.13 (v2.7.13:a06454b1afa1, Dec 17 2016, 20:42:59) [MSC v.1500 
32 bit (Intel)]
>>> Running on Windows-10-10.0.14393
>>> Home = C:\Users\rpetti\AppData\Roaming
>>> Current directory = C:\Users\rpetti\Documents\rbtest
>>> Command line: rbt post -d -o
>>> Running: tf vc help
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> repository info: Path: http://10.XX.XX.XX:89/svn/ourproject, Base path: 
/16.4.0, Supports changesets: False
>>> Making HTTP GET request to https://codereview.ourcomanydomain.com/api/
>>> Making HTTP GET request to 
https://codereview.ourcomanydomain.com/api/repositories/?tool=Subversion
>>> Cached response for HTTP GET 
https://codereview.ourcomanydomain.com/api/repositories/?tool=Subversion 
expired and was modified
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> repository info: Path: http://10.XX.XX.XX:89/svn/ourproject, Base path: 
/16.4.0, Supports changesets: False
>>> Running: svn --non-interactive status -q --ignore-externals
>>> Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry 
-r BASE
>>> Running: svn --non-interactive info run-tests.js
>>> Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry 
-r BASE --no-diff-deleted
>>> Running: svn --non-interactive info run-tests.js
>>> Running: svn --non-interactive info run-tests.js
>>> Running: svn --non-interactive info run-tests.js
>>> Making HTTP GET request to 
https://codereview.ourcomanydomain.com/api/validation/diffs/
>>> Cached response for HTTP GET 
https://codereview.ourcomanydomain.com/api/validation/diffs/ expired and 
was modified
>>> Making HTTP POST request to 
https://codereview.ourcomanydomain.com/api/validation/diffs/
>>> Got API Error 224 (HTTP code 400): Unrecognized URL scheme for 
'http://10.XX.XX.XX:89/svn/ourproject/16.4.0/run-tests.js'
>>> Error data: {u'stat': u'fail', u'err': {u'msg': u"Unrecognized URL 
scheme for 'http://10.XX.XX.XX:89/svn/ourproject/16.4.0/run-tests.js'", 
u'code': 224}}
Traceback (most recent call last):
  File "C:\Program Files 
(x86)\RBTools\bin\..\Python27\Scripts\rbt-script.py", line 11, in 
load_entry_point('RBTools==0.7.10', 'console_scripts', 'rbt')()
  File "C:\Program Files 
(x86)\RBTools\Python27\lib\site-packages\rbtools-0.7.10-py2.7.egg\rbtools\commands\main.py",
 
line 133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File "C:\Program Files 
(x86)\RBTools\Python27\lib\site-packages\rbtools-0.7.10-py2.7.egg\rbtools\commands\__init__.py",
 
line 663, in run_from_argv
exit_code = self.main(*args) or 0
  File "C:\Program Files 
(x86)\RBTools\Python27\lib\site-packages\rbtools-0.7.10-py2.7.egg\rbtools\commands\post.py",
 
line 812, in main
(msg_prefix, e))
rbtools.commands.CommandError: Error validating diff

Unrecognized URL scheme for 
'http://10.XX.XX.XX:89/svn/ourproject/16.4.0/run-tests.js' (HTTP 400, API 
Error 224)

~Rob

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to 

Re: Long lines get cut off in diff view

2017-11-24 Thread Rob Petti
The user reports that they can work-around it by zooming out and in with
CTRL and -, then CTRL and 0, or by maximizing and restoring. So it would
seem that triggering a relayout fixes it for them.

Thanks for looking into it!

On Thu, Nov 23, 2017 at 10:20 PM, Christian Hammond <
christ...@beanbaginc.com> wrote:

> Looks like the lines are missing a character or two. I have seen this
> once, and when I looked, it was a quirk with how the browser chose to wrap
> vs. extend the container for the line. I’ll keep my eye open and see if I
> can reproduce and figure out the issue, but it was non-obvious last time.
>
> What I did find was resizing the window would trigger a relayout,
> resolving the problem. I’d be curious if this works around the issue for
> you.
>
> Christian
>
>
>
> On Thu, Nov 23, 2017 at 16:24 Rob Petti <rob.pe...@gmail.com> wrote:
>
>> That's odd... Here's the attachment again.
>>
>> On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond <
>> christ...@beanbaginc.com> wrote:
>>
>>> Hi Rob,
>>>
>>> Unfortunately that screenshot didn’t go through for me. Looks like it’s
>>> some inline thing instead of an attachment. Can you try re-attaching?
>>>
>>> Christian
>>>
>>>
>>> On Thu, Nov 23, 2017 at 10:09 Rob Petti <rob.pe...@gmail.com> wrote:
>>>
>>>> Hi all,
>>>>
>>>> One of my users is having a strange issue with the diff viewer in
>>>> ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of
>>>> the view gets cut off.
>>>>
>>>> They claim it happens in Chrome 62 and Firefox 57, but I was only able
>>>> to reproduce the problem in IE 11.
>>>>
>>>> Any ideas on what the issue might be, or how to resolve it?
>>>>
>>>> [image: image001.jpg]
>>>>
>>>> --
>>>> Supercharge your Review Board with Power Pack:
>>>> https://www.reviewboard.org/powerpack/
>>>> Want us to host Review Board for you? Check out RBCommons:
>>>> https://rbcommons.com/
>>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>>> ---
>>>> You received this message because you are subscribed to the Google
>>>> Groups "reviewboard" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send
>>>> an email to reviewboard+unsubscr...@googlegroups.com.
>>>> For more options, visit https://groups.google.com/d/optout.
>>>>
>>> --
>>> --
>>> Christian Hammond
>>> President/CEO of Beanbag
>>> Makers of Review Board
>>>
>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>>
>> You received this message because you are subscribed to a topic in the
>>> Google Groups "reviewboard" group.
>>> To unsubscribe from this topic, visit https://groups.google.com/d/
>>> topic/reviewboard/E_QhfFCtm0Q/unsubscribe.
>>> To unsubscribe from this group and all its topics, send an email to
>>> reviewboard+unsubscr...@googlegroups.com.
>>>
>>
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> --
> Christian Hammond
> President/CEO of Beanbag
> Makers of Review Board
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to a topic in the
> Google Groups "reviewboard" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/reviewboard/E_QhfFCtm0Q/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Long lines get cut off in diff view

2017-11-23 Thread Rob Petti
That's odd... Here's the attachment again.

On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond <christ...@beanbaginc.com
> wrote:

> Hi Rob,
>
> Unfortunately that screenshot didn’t go through for me. Looks like it’s
> some inline thing instead of an attachment. Can you try re-attaching?
>
> Christian
>
>
> On Thu, Nov 23, 2017 at 10:09 Rob Petti <rob.pe...@gmail.com> wrote:
>
>> Hi all,
>>
>> One of my users is having a strange issue with the diff viewer in
>> ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of
>> the view gets cut off.
>>
>> They claim it happens in Chrome 62 and Firefox 57, but I was only able to
>> reproduce the problem in IE 11.
>>
>> Any ideas on what the issue might be, or how to resolve it?
>>
>> [image: image001.jpg]
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> --
> Christian Hammond
> President/CEO of Beanbag
> Makers of Review Board
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to a topic in the
> Google Groups "reviewboard" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/reviewboard/E_QhfFCtm0Q/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Long lines get cut off in diff view

2017-11-23 Thread Rob Petti
Hi all,

One of my users is having a strange issue with the diff viewer in 
ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of 
the view gets cut off.

They claim it happens in Chrome 62 and Firefox 57, but I was only able to 
reproduce the problem in IE 11.

Any ideas on what the issue might be, or how to resolve it?

[image: image001.jpg]

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: error: Setup script exited with error in cryptography setup command: Invalid environment marker: python_version < '3'

2017-11-05 Thread Rob Petti
I just ran into this as well... Thankfully, I managed to fix it by updating 
to the latest setuptools using pip:
pip install -U setuptools

~Rob

On Sunday, 29 October 2017 01:18:46 UTC-6, Gabriel Ganam wrote:
>
> Help :)
>
> I'm trying to upgrade from 2.5.7 to 2.5.16, and when I ran the command:
> easy_install -U ReviewBoard
>
> I got the following error:
> error: Setup script exited with error in cryptography setup command: 
> Invalid environment marker: python_version < '3'
>
> Which is apparently from the "cryptography 2.1.2" installation.
>
> Thanks,
> Gabriel.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.