Post-review with "publish" flag hangs.
Hi all,
I'm currently using RB 1.5.5 and RBTools 0.3.2. Whenever I try
submitting a review via a Subversion post-commit hook with the
"publish" flag, the command hangs indefinitely. Here is my debug
output:
www-data@ainet:/home/git/svn-repositories/test$ post-review --
server=http://ainet --username=admin --password=admin --submit-
as=snovak --revision-range=11 --target-people=admin -p -d
>>> RBTools 0.3.2
>>> Home = /var/www
>>> svn info
>>> diff --version
>>> repository info: Path: file:///svn/test, Base path: /, Supports changesets:
>>> False
>>> HTTP GETting api/
>>> HTTP GETting http://ainet/api/info/
>>> Using the new web API
>>> svn diff --diff-cmd=diff -r 11
>>> svn info trunk/test.txt
>>> svn info trunk/test.txt
>>> svn info trunk/test.txt
>>> svn info trunk/test.txt
>>> HTTP GETting http://ainet/api/repositories/
>>> HTTP GETting http://ainet/api/repositories/3/
>>> HTTP GETting http://ainet/api/repositories/3/info/
>>> HTTP GETting http://ainet/api/repositories/4/
>>> HTTP GETting http://ainet/api/repositories/4/info/
>>> repository info: Path: file:///svn/test, Base path: /, Supports changesets:
>>> False
>>> Attempting to create review request on TEST for None
>>> Submitting the review request as snovak
>>> HTTP POSTing to http://ainet/api/review-requests/: {'submit_as': 'snovak',
>>> 'repository': 'TEST'}
>>> Review request created
>>> Attempting to set field 'target_people' to 'admin' for review request '34'
>>> HTTP PUTting to http://ainet/api/review-requests/34/draft/:
>>> {'target_people': 'admin'}
>>> Uploading diff, size: 307
>>> HTTP POSTing to http://ainet/api/review-requests/34/diffs/: {'basedir': '/'}
>>> Publishing
>>> HTTP PUTting to http://ainet/api/review-requests/34/draft/: {'public': 1}
[Hangs here.]
Note that accessing http://ainet/api/review-requests/34/draft/ has a
response error code of 100 with a message "Object does not exist". The
review does get posted, however, the operation hangs. This occurs
whether or not I specify a target person to review the changes. If I
do not include the publish flag, the operation completes as expected.
Does anyone have insight into addressing this issue?
Thanks!
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Post-review with "publish" flag hangs.
It looks like this behavior has been addressed in commit
885f880ea4a0042f8f54 ([RBTools] Brand new Clear Case implementation),
which was made just after the tagging for 0.3.2.
On Jul 15, 10:06 am, Stefan wrote:
> Hi all,
>
> I'm currently using RB 1.5.5 and RBTools 0.3.2. Whenever I try
> submitting a review via a Subversion post-commit hook with the
> "publish" flag, the command hangs indefinitely. Here is my debug
> output:
>
> www-data@ainet:/home/git/svn-repositories/test$ post-review --
> server=http://ainet--username=admin --password=admin --submit-
> as=snovak --revision-range=11 --target-people=admin -p -d
>
>
>
>
>
>
>
> >>> RBTools 0.3.2
> >>> Home = /var/www
> >>> svn info
> >>> diff --version
> >>> repository info: Path: file:///svn/test, Base path: /, Supports
> >>> changesets: False
> >>> HTTP GETting api/
> >>> HTTP GETtinghttp://ainet/api/info/
> >>> Using the new web API
> >>> svn diff --diff-cmd=diff -r 11
> >>> svn info trunk/test.txt
> >>> svn info trunk/test.txt
> >>> svn info trunk/test.txt
> >>> svn info trunk/test.txt
> >>> HTTP GETtinghttp://ainet/api/repositories/
> >>> HTTP GETtinghttp://ainet/api/repositories/3/
> >>> HTTP GETtinghttp://ainet/api/repositories/3/info/
> >>> HTTP GETtinghttp://ainet/api/repositories/4/
> >>> HTTP GETtinghttp://ainet/api/repositories/4/info/
> >>> repository info: Path: file:///svn/test, Base path: /, Supports
> >>> changesets: False
> >>> Attempting to create review request on TEST for None
> >>> Submitting the review request as snovak
> >>> HTTP POSTing tohttp://ainet/api/review-requests/:{'submit_as': 'snovak',
> >>> 'repository': 'TEST'}
> >>> Review request created
> >>> Attempting to set field 'target_people' to 'admin' for review request '34'
> >>> HTTP PUTting
> >>> tohttp://ainet/api/review-requests/34/draft/:{'target_people': 'admin'}
> >>> Uploading diff, size: 307
> >>> HTTP POSTing tohttp://ainet/api/review-requests/34/diffs/:{'basedir': '/'}
> >>> Publishing
> >>> HTTP PUTting tohttp://ainet/api/review-requests/34/draft/:{'public': 1}
>
> [Hangs here.]
>
> Note that accessinghttp://ainet/api/review-requests/34/draft/has a
> response error code of 100 with a message "Object does not exist". The
> review does get posted, however, the operation hangs. This occurs
> whether or not I specify a target person to review the changes. If I
> do not include the publish flag, the operation completes as expected.
>
> Does anyone have insight into addressing this issue?
>
> Thanks!
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Post-review with "publish" flag hangs.
Actually, I don't think it was. I submitted this problem as a bug with
a workaround at:
http://code.google.com/p/reviewboard/issues/detail?id=2179
On Jul 18, 2:44 pm, Stefan wrote:
> It looks like this behavior has been addressed in commit
> 885f880ea4a0042f8f54 ([RBTools] Brand new Clear Case implementation),
> which was made just after the tagging for 0.3.2.
>
> On Jul 15, 10:06 am, Stefan wrote:
>
>
>
>
>
>
>
> > Hi all,
>
> > I'm currently using RB 1.5.5 and RBTools 0.3.2. Whenever I try
> > submitting a review via a Subversion post-commit hook with the
> > "publish" flag, the command hangs indefinitely. Here is my debug
> > output:
>
> > www-data@ainet:/home/git/svn-repositories/test$ post-review --
> > server=http://ainet--username=admin--password=admin --submit-
> > as=snovak --revision-range=11 --target-people=admin -p -d
>
> > >>> RBTools 0.3.2
> > >>> Home = /var/www
> > >>> svn info
> > >>> diff --version
> > >>> repository info: Path: file:///svn/test, Base path: /, Supports
> > >>> changesets: False
> > >>> HTTP GETting api/
> > >>> HTTP GETtinghttp://ainet/api/info/
> > >>> Using the new web API
> > >>> svn diff --diff-cmd=diff -r 11
> > >>> svn info trunk/test.txt
> > >>> svn info trunk/test.txt
> > >>> svn info trunk/test.txt
> > >>> svn info trunk/test.txt
> > >>> HTTP GETtinghttp://ainet/api/repositories/
> > >>> HTTP GETtinghttp://ainet/api/repositories/3/
> > >>> HTTP GETtinghttp://ainet/api/repositories/3/info/
> > >>> HTTP GETtinghttp://ainet/api/repositories/4/
> > >>> HTTP GETtinghttp://ainet/api/repositories/4/info/
> > >>> repository info: Path: file:///svn/test, Base path: /, Supports
> > >>> changesets: False
> > >>> Attempting to create review request on TEST for None
> > >>> Submitting the review request as snovak
> > >>> HTTP POSTing tohttp://ainet/api/review-requests/:{'submit_as':
> > >>> 'snovak', 'repository': 'TEST'}
> > >>> Review request created
> > >>> Attempting to set field 'target_people' to 'admin' for review request
> > >>> '34'
> > >>> HTTP PUTting
> > >>> tohttp://ainet/api/review-requests/34/draft/:{'target_people': 'admin'}
> > >>> Uploading diff, size: 307
> > >>> HTTP POSTing tohttp://ainet/api/review-requests/34/diffs/:{'basedir':
> > >>> '/'}
> > >>> Publishing
> > >>> HTTP PUTting tohttp://ainet/api/review-requests/34/draft/:{'public': 1}
>
> > [Hangs here.]
>
> > Note that accessinghttp://ainet/api/review-requests/34/draft/hasa
> > response error code of 100 with a message "Object does not exist". The
> > review does get posted, however, the operation hangs. This occurs
> > whether or not I specify a target person to review the changes. If I
> > do not include the publish flag, the operation completes as expected.
>
> > Does anyone have insight into addressing this issue?
>
> > Thanks!
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
PUTing to review-requests/x/draft results in HTTP 301 error
Hi all, Very briefly, I'm attempting to change the "target_groups" property of a review request. However, when attempting to send a PUT request to change the property, I get a HTTP 301 error (urllib2.HTTPError: HTTP Error 301: Moved Permanently). Can someone provide insight into how to update a review request with this info? (Note: if I change the request type to GET, I do receive the JSON data for the specified review.) Code snippet: https://gist.github.com/1189749 Thanks! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: PUTing to review-requests/x/draft results in HTTP 301 error
Ah, thanks! On Sep 2, 4:17 pm, Christian Hammond wrote: > You're missing the trailing slash on the URL. That's what's causing the > redirect. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > > > > > On Fri, Sep 2, 2011 at 1:14 PM, Stefan wrote: > > Hi all, > > > Very briefly, I'm attempting to change the "target_groups" property of > > a review request. However, when attempting to send a PUT request to > > change the property, I get a HTTP 301 error (urllib2.HTTPError: HTTP > > Error 301: Moved Permanently). Can someone provide insight into how to > > update a review request with this info? (Note: if I change the request > > type to GET, I do receive the JSON data for the specified review.) > > > Code snippet:https://gist.github.com/1189749 > > > Thanks! > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
"Getting Started" page broken
Hi, the development link "Getting Started" on review-board.org yields "TemplateSyntaxError at /docs/codebase/dev/getting-started" with a massive Python stack. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
A few questions about ereviewboard.
Hi, i have a few questions regarding the ereviewboard plugin for Eclipse. Maybe someone who´s using it can help me out. 1.) Is there any kind of end user documentation available? I know how to install the plugin via the update site but what i´m missing is something like "How to configure the task repository" and "How to create a review request". 2.) What are the main features of the plugin. Is it possible to create pre- and post-commit reviews as well or are there any restrictions? 3.) Is there still active development? The last commit on http://github.com/mknittig/ereviewboard is more than five month ago. Thanks a lot. Regards Stefan PS: I would love to help out with some documentation, but right now http://github.com/mknittig/ereviewboard/issues#issue/3 prevents me from installing the plugin! ;-( -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.6 beta 2 - For real this time!
We also had broken counts in our 1.6 beta 1 instance. We are running it using a MySQL database, so to fix the counters we wrote the following SQL script which we run once a day: #All My Requests: update accounts_localsiteprofile as lp set lp.total_outgoing_request_count = (SELECT count(*) FROM reviews_reviewrequest as r WHERE r.submitter_id = lp.user_id); #Stared: update accounts_localsiteprofile as lp set lp.starred_public_request_count = (SELECT count(*) FROM accounts_profile_starred_review_requests as s WHERE s.profile_id = lp.profile_id); #Outgoing: update accounts_localsiteprofile as lp set lp.pending_outgoing_request_count = (SELECT count(*) FROM reviews_reviewrequest as r WHERE r.submitter_id = lp.user_id AND STATUS = 'P'); #Incomming: update accounts_localsiteprofile as lp set lp.total_incoming_request_count = (SELECT count(*) FROM reviews_reviewrequest as r left join reviews_reviewrequest_target_people as p on p.reviewrequest_id = r.id left join reviews_reviewrequest_target_groups as g on g.reviewrequest_id = r.id join reviews_group_users as gu on gu.group_id = g.group_id WHERE (lp.user_id = gu.user_id OR lp.user_id = p.user_id) and r.status = 'P' group by lp.user_id) update accounts_localsiteprofile as lp set lp.total_incoming_request_count = 0 where lp.total_incoming_request_count is null; #TOME: update accounts_localsiteprofile as lp set lp.direct_incoming_request_count = (SELECT count(*) FROM reviews_reviewrequest_target_people as p join reviews_reviewrequest as r on p.reviewrequest_id = r.id WHERE p.user_id= lp.user_id and r.status = 'P' group by p.user_id); update accounts_localsiteprofile as lp set lp.direct_incoming_request_count = 0 where lp.direct_incoming_request_count is null; We are looking into upgrading to 1.6 beta 2 as well, once we have upgraded we don't have to run these querys again :) Hope this might be helpful for someone. Stefan - Original Message - From: "Dan Savilonis" To: "reviewboard" Sent: Wednesday, May 11, 2011 10:57:53 PM Subject: Re: Review Board 1.6 beta 2 - For real this time! Ah, I suspected that it might be in the database. Thanks, Dan On May 11, 2:54 pm, Christian Hammond wrote: > It fixes all future ones going forward. We need to reset the broken 1.6 beta > 1 counts, which I'm still trying to figure out the best way to do. It'll > happen by the next beta, unless there's some emergency that forces us to put > the beta out sooner than planned. > > We have a Review Board instance with negative counts too. I'm keeping it > that way as a reminder :) > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > > > > > On Wed, May 11, 2011 at 10:59 AM, Dan Savilonis wrote: > > Upgrade to 1.6 beta 2 went fine for me. However, I noticed there are a > > couple lines in the release note indicating some fixes for incoming > > review and starred review request counts. This doesn't seem to have > > fixed the counts for me. I currently have -15 incoming reviews and -1 > > outgoing reviews. I've noticed it slowly decrementing since we > > installed 1.6 beta 1 :) > > > Dan > > > On May 10, 3:03 am, "Ashithraj Shetty" > > wrote: > > > Upgraded to the latest release. Big bad box is not seen anymore J > > > > -Ashith > > > > From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] > > On > > > Behalf Of Christian Hammond > > > Sent: Tuesday, May 10, 2011 11:37 AM > > > To: reviewboard@googlegroups.com > > > Subject: Review Board 1.6 beta 2 - For real this time! > > > > Let's try this again. > > > > 1.6 beta 2 is out! It should work with PostgreSQL and shouldn't have a > > giant > > > box at the bottom of every page. Give it a try! > > > > Christian > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > -- > > > Want to help the Review Board project? Donate today athttp:// > >www.reviewboard.org/donate/ > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > -~--~~~~--~~--~--~--- > > > To unsubscribe from this group, send email to > > > reviewboard+unsubscr...@googlegroups.com > > > For more options, visit this group athttp:// > > groups.google.com/group/reviewboard?hl=en > > > -- > > Want to help the Revi
Re: Mercurial support for post-review
On Fri, Jul 15, 2011 at 7:45 PM, Chris Toomey wrote: > Are there any plans / rough ETA to add mercurial support to post- > review? We've been using post-review with Mercurial for almost 2 years. What makes you think that it's not supported? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Review Request History
Hello, we have been using ReviewBoard for a few weeks so far and it has been quite useful to us. But an issue has just come up. Someone closed one of my review requests and dropped one issue. Is there a way to track what happened to a review request, ie. who changed what and when? Is the information of who closed a review request visible somewhere? Thanks, Stefan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Request History
Hi Christian, I found out what happened. Being an administrator I always thought, everyone could do everything. Thanks for your explanations. Stefan Am Montag, 10. September 2012 20:15:20 UTC+2 schrieb Christian Hammond: > > Hi Stefan, > > The only people who can in any way modify your review requests are other > administrators or users with very special permissions that had to be > granted by an administrator. We don't (yet) keep a history of who made the > changes, but we're adding that. > > As far as issues, without going into the database, nobody but you (or > someone logged in as you) can make changes to issues filed against your > review request. > > Christian > > -- > Christian Hammond - chi...@chipx86.com > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Mon, Sep 10, 2012 at 9:28 AM, Stefan Bohne < > stefan...@sentec-elektronik.de > wrote: > >> Hello, >> >> we have been using ReviewBoard for a few weeks so far and it has been >> quite useful to us. But an issue has just come up. >> >> Someone closed one of my review requests and dropped one issue. Is there >> a way to track what happened to a review request, ie. who changed what and >> when? Is the information of who closed a review request visible somewhere? >> >> Thanks, >> Stefan >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~--~~~~--~~--~--~--- >> To unsubscribe from this group, send email to >> reviewboard...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en > > > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Enabling Searching on RB 1.7.21
Hi I am seeing a pylucene warning on my RB setting page: == Enable search Provides a search field for quickly searching through review requests. PyLucene (with JCC) is required to enable search. See the documentation for instructions. == Is this to mean that RB thinks that I do not have pylucene installed? I checked and it sure seems to have landed where python ought to find it: /.local/lib/python2.6/site-packages/lucene-3.6.2-py2.6-linux-x86_64.egg (!). this module can import in python without any error. [root@vm-fes-rb reviews]# python Python 2.6.6 (r266:84292, Jan 22 2014, 09:42:36) [GCC 4.4.7 20120313 (Red Hat 4.4.7-4)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import lucene >>> "pip freeze" will give lucene==3.6.2 JCC==2.15 ReviewBoard==1.7.21 any help here ? thx Stefan -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Unicode and Subversion
Hello, I'm having problems posting a review request from a subversion repository with rbt post that contains non-ascii file names. It seems that rbt post executes svn diff with a non-unicode locale and that makes svn fail. The same svn command works when typed on the command line. But it could also be a configuration problem on my side. Any hints would be much appreciated. Below is the command line output with debug infos. $ rbt post --repository-url=http://svn/svn/main --username=stbohne --password=XXX -d --server=http://reviews/ 8792 >>> RBTools 0.6 >>> Python 2.7.5+ (default, Feb 27 2014, 19:39:55) [GCC 4.8.1] >>> Running on Linux-3.11.0-18-generic-i686-with-Ubuntu-13.10-saucy >>> Home = /home/stbohne >>> Current directory = /home/stbohne >>> Checking for a Subversion repository... >>> Running: svn info http://svn/svn/main --non-interactive >>> Running: diff --version >>> repository info: Path: http://svn/svn/main, Base path: /, Supports changesets: False >>> Making HTTP GET request to http://reviews/api/ >>> Making HTTP GET request to http://reviews/api/info/ >>> Running: svn log -r 8792 -l 1 --xml http://svn/svn/main >>> Running: svn info http://svn/svn/main --non-interactive >>> Running: diff --version >>> repository info: Path: http://svn/svn/main, Base path: /, Supports changesets: False >>> Running: svn status --ignore-externals >>> Running: svn diff --diff-cmd=diff --notice-ancestry http://svn/svn/main/@8791 http://svn/svn/main/@8792 Failed to execute command: ['svn', 'diff', '--diff-cmd=diff', '--notice-ancestry', 'http://svn/svn/main/@8791', 'http://svn/svn/main/@8792'] ["svn: E22: Can't convert string from 'UTF-8' to native encoding:\n", 'svn: E22: Index: Beaglebone Black/Z?\\195?\\188rn/branches/silo/var/www/silo/welcome.cgi\n', '===\n', '\n', 'svn: E175002: Error reading spooled REPORT request response\n'] stbohne@sentec116:~$ locale LANG=de_DE.UTF-8 LANGUAGE= LC_CTYPE="de_DE.UTF-8" LC_NUMERIC=de_DE.UTF-8 LC_TIME=de_DE.UTF-8 LC_COLLATE="de_DE.UTF-8" LC_MONETARY=de_DE.UTF-8 LC_MESSAGES="de_DE.UTF-8" LC_PAPER=de_DE.UTF-8 LC_NAME=de_DE.UTF-8 LC_ADDRESS=de_DE.UTF-8 LC_TELEPHONE=de_DE.UTF-8 LC_MEASUREMENT=de_DE.UTF-8 LC_IDENTIFICATION=de_DE.UTF-8 LC_ALL= $ svn diff --diff-cmd=diff --notice-ancestry http://svn/svn/main/@8791 http://svn/svn/main/@8792 Index: Beaglebone Black/Zürn/branches/silo/var/www/silo/welcome.cgi === --- Beaglebone Black/Zürn/branches/silo/var/www/silo/welcome.cgi (Revision 8791) +++ Beaglebone Black/Zürn/branches/silo/var/www/silo/welcome.cgi (Revision 8792) @@ -1,7 +1,6 @@ #!/usr/bin/python import cgi import cgitb; cgitb.enable() -import pexpect import os import hashlib Thanks, Stefan -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unicode and Subversion
Thanks, David. That fixed it. But now reviewboard itself seems to
stumble over unicode paths.
$ rbt post --repository-url=http://svn/svn/main/ --username=stbohne
--password=XXX -d --server=http://reviews/ 8792
>>> RBTools 0.6
>>> Python 2.7.5+ (default, Feb 27 2014, 19:39:55)
[GCC 4.8.1]
>>> Running on Linux-3.11.0-18-generic-i686-with-Ubuntu-13.10-saucy
>>> Home = /home/stbohne
>>> Current directory = /home/stbohne
>>> Checking for a Subversion repository...
>>> Running: svn info http://svn/svn/main/ --non-interactive
>>> Running: diff --version
>>> repository info: Path: http://svn/svn/main, Base path: /, Supports
changesets: False
>>> Making HTTP GET request to http://reviews/api/
>>> Making HTTP GET request to http://reviews/api/info/
>>> Running: svn log -r 8792 -l 1 --xml http://svn/svn/main/
>>> Running: svn info http://svn/svn/main/ --non-interactive
>>> Running: diff --version
>>> repository info: Path: http://svn/svn/main, Base path: /, Supports
changesets: False
>>> Running: svn status --ignore-externals
>>> Running: svn diff --diff-cmd=diff --notice-ancestry
http://svn/svn/main/@8791 http://svn/svn/main/@8792
>>> Making HTTP GET request to http://reviews/api/review-requests/
>>> Making HTTP POST request to http://reviews/api/review-requests/
>>> Making HTTP GET request to
http://reviews/api/review-requests/2194/diffs/
>>> Making HTTP POST request to
http://reviews/api/review-requests/2194/diffs/
>>> Got API Error 105 (HTTP code 400): One or more fields had errors
>>> Error data: {u'fields': {u'path': [u"'ascii' codec can't decode
byte 0xc3 in position 20: ordinal not in range(128)"]}, u'stat':
u'fail', u'err': {u'msg': u'One or more fields had errors', u'code': 105}}
Traceback (most recent call last):
File "/usr/local/bin/rbt", line 9, in
load_entry_point('RBTools==0.6', 'console_scripts', 'rbt')()
File
"/usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/main.py",
line 134, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File
"/usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/__init__.py",
line 422, in run_from_argv
exit_code = self.main(*args) or 0
File
"/usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/post.py",
line 769, in main
submit_as=self.options.submit_as)
File
"/usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/post.py",
line 545, in post_request
raise CommandError('\n'.join(error_msg))
rbtools.commands.CommandError: Error uploading diff
One or more fields had errors (HTTP 400, API Error 105)
path: 'ascii' codec can't decode byte 0xc3 in position 20: ordinal
not in range(128)
Your review request still exists, but the diff is not attached.
Am Dienstag, 29. April 2014 00:01:50 UTC+2 schrieb David Trowbridge:
I believe that this is because we remove locale configuration, since
svn likes to localize some of the control strings in the diffs.
Could you test a prospective code change for this?
In rbtools/util/process.py, there are two lines:
env['LC_ALL'] = 'C'
env['LANGUAGE'] = 'C'
Can you change 'C' to 'C.UTF-8' and see if it works?
-David
On Mon, Apr 28, 2014 at 6:06 AM, Stefan Bohne
> wrote:
Hello,
I'm having problems posting a review request from a subversion
repository with rbt post that contains non-ascii file names. It
seems that rbt post executes svn diff with a non-unicode locale
and that makes svn fail. The same svn command works when typed
on the command line. But it could also be a configuration
problem on my side. Any hints would be much appreciated. Below
is the command line output with debug infos.
$ rbt post --repository-url=http://svn/svn/main
<http://svn/svn/main> --username=stbohne --password=XXX -d
--server=http://reviews/ 8792
>>> RBTools 0.6
>>> Python 2.7.5+ (default, Feb 27 2014, 19:39:55)
[GCC 4.8.1]
>>> Running on Linux-3.11.0-18-generic-i686-with-Ubuntu-13.10-saucy
>>> Home = /home/stbohne
>>> Current directory = /home/stbohne
>>> Checking for a Subversion repository...
>>> Running: svn info http://svn/svn/main --non-interactive
>>> Running: diff --version
>>> repository info: Path: http://svn/svn/main, Base path:
Re: Unicode and Subversion
Review Board 1.7.21
Am Dienstag, 29. April 2014 22:02:37 UTC+2 schrieb David Trowbridge:
>
> What version of Review Board are you using?
>
> -David
>
>
> On Tue, Apr 29, 2014 at 3:22 AM, Stefan Bohne <
> stefan...@sentec-elektronik.de > wrote:
>
>> Thanks, David. That fixed it. But now reviewboard itself seems to
>> stumble over unicode paths.
>>
>> $ rbt post --repository-url=http://svn/svn/main/ --username=stbohne
>> --password=XXX -d --server=http://reviews/ 8792
>>
>> >>> RBTools 0.6
>> >>> Python 2.7.5+ (default, Feb 27 2014, 19:39:55)
>> [GCC 4.8.1]
>> >>> Running on Linux-3.11.0-18-generic-i686-with-Ubuntu-13.10-saucy
>> >>> Home = /home/stbohne
>> >>> Current directory = /home/stbohne
>> >>> Checking for a Subversion repository...
>> >>> Running: svn info http://svn/svn/main/ --non-interactive
>>
>> >>> Running: diff --version
>> >>> repository info: Path: http://svn/svn/main, Base path: /, Supports
>> changesets: False
>> >>> Making HTTP GET request to http://reviews/api/
>> >>> Making HTTP GET request to http://reviews/api/info/
>> >>> Running: svn log -r 8792 -l 1 --xml http://svn/svn/main/
>> >>> Running: svn info http://svn/svn/main/ --non-interactive
>>
>> >>> Running: diff --version
>> >>> repository info: Path: http://svn/svn/main, Base path: /, Supports
>> changesets: False
>> >>> Running: svn status --ignore-externals
>> >>> Running: svn diff --diff-cmd=diff --notice-ancestry
>> http://svn/svn/main/@8791 http://svn/svn/main/@8792
>> >>> Making HTTP GET request to http://reviews/api/review-requests/
>> >>> Making HTTP POST request to http://reviews/api/review-requests/
>> >>> Making HTTP GET request to
>> http://reviews/api/review-requests/2194/diffs/
>> >>> Making HTTP POST request to
>> http://reviews/api/review-requests/2194/diffs/
>> >>> Got API Error 105 (HTTP code 400): One or more fields had errors
>> >>> Error data: {u'fields': {u'path': [u"'ascii' codec can't decode byte
>> 0xc3 in position 20: ordinal not in range(128)"]}, u'stat': u'fail',
>> u'err': {u'msg': u'One or more fields had errors', u'code': 105}}
>> Traceback (most recent call last):
>> File "/usr/local/bin/rbt", line 9, in
>> load_entry_point('RBTools==0.6', 'console_scripts', 'rbt')()
>> File
>> "/usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/main.py",
>>
>> line 134, in main
>> command.run_from_argv([RB_MAIN, command_name] + args)
>> File
>> "/usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/__init__.py",
>>
>> line 422, in run_from_argv
>> exit_code = self.main(*args) or 0
>> File
>> "/usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/post.py",
>>
>> line 769, in main
>> submit_as=self.options.submit_as)
>> File
>> "/usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/post.py",
>>
>> line 545, in post_request
>> raise CommandError('\n'.join(error_msg))
>> rbtools.commands.CommandError: Error uploading diff
>>
>>
>> One or more fields had errors (HTTP 400, API Error 105)
>>
>> path: 'ascii' codec can't decode byte 0xc3 in position 20: ordinal
>> not in range(128)
>>
>> Your review request still exists, but the diff is not attached.
>>
>>
>> Am Dienstag, 29. April 2014 00:01:50 UTC+2 schrieb David Trowbridge:
>>>
>>> I believe that this is because we remove locale configuration, since svn
>>> likes to localize some of the control strings in the diffs. Could you test
>>> a prospective code change for this?
>>>
>>> In rbtools/util/process.py, there are two lines:
>>>
>>> env['LC_ALL'] = 'C'
>>> env['LANGUAGE'] = 'C'
>>>
>>> Can you change 'C' to 'C.UTF-8' and see if it works?
>>>
>>> -David
>>>
>>>
>>> On Mon, Apr 28, 2014 at 6:06 AM, Stefan Bohne >> elektronik.de> wrote:
>>>
>>>> Hello,
>>>>
>>>> I'm
Re: Unicode and Subversion
Here you go, David.
2014-04-29 10:12:58,425 - DEBUG - - DiffParser.parse: Beginning parse of
diff, size = 429
2014-04-29 10:12:58,442 - DEBUG - - DiffParser.parse: Finished parsing
diff.
2014-04-29 10:12:58,445 - ERROR - None - stbohne -
/api/review-requests/2194/diffs/ - Error uploading new diff: 'ascii' codec
can't decode byte 0xc3 in position 20: ordinal not in range(128)
Traceback (most recent call last):
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/webapi/resources.py",
line 2115, in create
request.FILES.get('parent_diff_path'))
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/reviews/forms.py",
line 309, in create
history)
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/diffviewer/forms.py",
line 67, in create
request=self.request)
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/diffviewer/managers.py",
line 82, in create_from_upload
save=save)
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/diffviewer/managers.py",
line 103, in create_from_data
check_existence=(not parent_diff_file_contents)))
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/diffviewer/managers.py",
line 213, in _process_files
request=request))):
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/scmtools/models.py",
line 211, in get_file_exists
base_commit_id, request)
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/scmtools/models.py",
line 333, in _get_file_exists_uncached
exists = self.get_scmtool().file_exists(path, revision)
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/scmtools/core.py",
line 80, in file_exists
self.get_file(path, revision)
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/scmtools/svn.py",
line 191, in get_file
return self._do_on_path(get_file_data, path, revision)
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/scmtools/svn.py",
line 145, in _do_on_path
normpath = self.__normalize_path(path)
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/scmtools/svn.py",
line 318, in __normalize_path
if path.startswith(self.repopath):
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 20:
ordinal not in range(128)
Am Sonntag, 4. Mai 2014 05:56:22 UTC+2 schrieb David Trowbridge:
>
> Stefan,
>
> This has improved significantly in the 2.0 RCs, but we should probably
> still try to fix it in the 1.7.x series. Can you see if you can get a
> traceback for the UnicodeDecodeError?
>
> -David
>
>
> On Wed, Apr 30, 2014 at 2:52 AM, Stefan Bohne <
> stefan...@sentec-elektronik.de > wrote:
>
>> Review Board 1.7.21
>>
>> Am Dienstag, 29. April 2014 22:02:37 UTC+2 schrieb David Trowbridge:
>>>
>>> What version of Review Board are you using?
>>>
>>> -David
>>>
>>>
>>> On Tue, Apr 29, 2014 at 3:22 AM, Stefan Bohne >> elektronik.de> wrote:
>>>
>>>> Thanks, David. That fixed it. But now reviewboard itself seems to
>>>> stumble over unicode paths.
>>>>
>>>> $ rbt post --repository-url=http://svn/svn/main/ --username=stbohne
>>>> --password=XXX -d --server=http://reviews/ 8792
>>>>
>>>> >>> RBTools 0.6
>>>> >>> Python 2.7.5+ (default, Feb 27 2014, 19:39:55)
>>>> [GCC 4.8.1]
>>>> >>> Running on Linux-3.11.0-18-generic-i686-with-Ubuntu-13.10-saucy
>>>> >>> Home = /home/stbohne
>>>> >>> Current directory = /home/stbohne
>>>> >>> Checking for a Subversion repository...
>>>> >>> Running: svn info http://svn/svn/main/ --non-interactive
>>>>
>>>> >>> Running: diff --version
>>>> >>> repository info: Path: http://svn/svn/main, Base path: /, Supports
>>>> changesets: False
>>>> >>> Making HTTP GET request to http://reviews/api/
>>>> >>> Making HTTP GET request to http://reviews/api/info/
>>>> >>> Running: svn log -r 8792 -l 1 --xml http://svn/svn/main/
>>>> >>> Running: svn info http://svn/svn/main/ --non-interactive
>>>>
>>>> >>> Running: diff --version
rebuild_index destroys reviewboard site
Hello all, since upgrading to RB2.0 and then RB2.0.1 my reviewboard stopped working periodically. Luckily, as far as I can tell, no information was lost. Today I found the culprit: a line in crobtab doing a full reindex. Here is some command line log to show the problem. stbohne@sentec116:~$ ls -l /var/www/reviews insgesamt 20 drwxr-xr-x 2 root root 4096 Jun 5 09:09 conf drwxr-xr-x 3 www-data www-data 4096 Jun 5 09:10 data drwxr-xr-x 4 root root 4096 Jun 5 09:09 htdocs drwxr-xr-x 2 root root 4096 Jun 5 09:09 logs drwxrwxrwx 2 root root 4096 Jun 5 09:09 tmp stbohne@sentec116:~$ sudo "/usr/bin/python" "/usr/local/bin/rb-site" manage "/var/www/reviews" index -- --full Removing all documents from your index because you said so. All documents removed. Indexing 1782 review requests stbohne@sentec116:~$ ls -l /var/www/reviews insgesamt 20176 -rw-r--r-- 1 root root 4128 Jun 5 09:16 _MAIN_2.toc -rw-r--r-- 1 root root 10934530 Jun 5 09:16 MAIN_mhao8rj5qykon23w.seg -rw-r--r-- 1 root root 9714845 Jun 5 09:16 MAIN_ouvhv91nwxh0w4io.seg -rwxr-xr-x 1 root root0 Jun 5 09:16 MAIN_WRITELOCK rebuild_index does the same thing. stbohne@sentec116:~$ sudo rb-site manage /var/www/reviews/ rebuild_index WARNING: This will irreparably remove EVERYTHING from your search index in connection 'default'. Your choices after this are to restore from backups or rebuild via the `rebuild_index` command. Are you sure you wish to continue? [y/N] y Removing all documents from your index because you said so. All documents removed. Indexing 1782 review requests stbohne@sentec116:~$ ls -l /var/www/reviews/ insgesamt 20176 -rw-r--r-- 1 root root 4128 Jun 5 09:30 _MAIN_2.toc -rw-r--r-- 1 root root 10934528 Jun 5 09:30 MAIN_5yig6ynh5eil7tmx.seg -rw-r--r-- 1 root root 9714847 Jun 5 09:30 MAIN_jnxk79y5l3dhomio.seg -rwxr-xr-x 1 root root0 Jun 5 09:29 MAIN_WRITELOCK Any ideas what could cause this? Stefan -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: rebuild_index destroys reviewboard site
That was it. No idea how that happened. Thanks a lot. Stefan Am Donnerstag, 5. Juni 2014 10:55:35 UTC+2 schrieb Bruce Cran: > > Your search index directory appears to be wrong: it should be something > like /var/www/reviews/search-index/ and not the root directory. > > -- > Bruce > > > On Thu, Jun 5, 2014 at 2:04 AM, Stefan Bohne < > stefan...@sentec-elektronik.de > wrote: > > Hello all, >> >> since upgrading to RB2.0 and then RB2.0.1 my reviewboard stopped working >> periodically. Luckily, as far as I can tell, no information was lost. Today >> I found the culprit: a line in crobtab doing a full reindex. >> >> Here is some command line log to show the problem. >> >> stbohne@sentec116:~$ ls -l /var/www/reviews >> insgesamt 20 >> drwxr-xr-x 2 root root 4096 Jun 5 09:09 conf >> drwxr-xr-x 3 www-data www-data 4096 Jun 5 09:10 data >> drwxr-xr-x 4 root root 4096 Jun 5 09:09 htdocs >> drwxr-xr-x 2 root root 4096 Jun 5 09:09 logs >> drwxrwxrwx 2 root root 4096 Jun 5 09:09 tmp >> stbohne@sentec116:~$ sudo "/usr/bin/python" "/usr/local/bin/rb-site" >> manage "/var/www/reviews" index -- --full >> Removing all documents from your index because you said so. >> All documents removed. >> Indexing 1782 review requests >> stbohne@sentec116:~$ ls -l /var/www/reviews >> insgesamt 20176 >> -rw-r--r-- 1 root root 4128 Jun 5 09:16 _MAIN_2.toc >> -rw-r--r-- 1 root root 10934530 Jun 5 09:16 MAIN_mhao8rj5qykon23w.seg >> -rw-r--r-- 1 root root 9714845 Jun 5 09:16 MAIN_ouvhv91nwxh0w4io.seg >> -rwxr-xr-x 1 root root0 Jun 5 09:16 MAIN_WRITELOCK >> >> rebuild_index does the same thing. >> >> stbohne@sentec116:~$ sudo rb-site manage /var/www/reviews/ rebuild_index >> >> WARNING: This will irreparably remove EVERYTHING from your search index >> in connection 'default'. >> Your choices after this are to restore from backups or rebuild via the >> `rebuild_index` command. >> Are you sure you wish to continue? [y/N] y >> Removing all documents from your index because you said so. >> All documents removed. >> Indexing 1782 review requests >> stbohne@sentec116:~$ ls -l /var/www/reviews/ >> insgesamt 20176 >> -rw-r--r-- 1 root root 4128 Jun 5 09:30 _MAIN_2.toc >> -rw-r--r-- 1 root root 10934528 Jun 5 09:30 MAIN_5yig6ynh5eil7tmx.seg >> -rw-r--r-- 1 root root 9714847 Jun 5 09:30 MAIN_jnxk79y5l3dhomio.seg >> -rwxr-xr-x 1 root root0 Jun 5 09:29 MAIN_WRITELOCK >> >> Any ideas what could cause this? >> >> Stefan >> > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
repo navigation with ReviewBoard
Hello, I'm reviewing ReviewBoard to decide whether or not to use it in my team for code & patch reviews. While what I'm seing all looks very promising, I'm looking for one feature I didn't find: The ability to navigate and browse the repository, similar to ViewVC or phabricator's Diffusion tool. Does such a tool already exist, perhaps as an extension ? If not, are there any plans to add it ? Thanks, Stefan -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: repo navigation with ReviewBoard
On 2014-10-01 15:38, Andrew Hills (anhills) wrote: > Hi Stefan, > > While that sounds like an interesting project for an extension, I'm > not sure exactly how it would work, since it would have a completely > different interface for each type of version control. It would be much > easier if you already had such a tool in place, and to write an > extension to add easy access points. But even then, all the web tools > look more than a little different, so it would take some effort to > make sure it's extensible enough to cover most cases... Andrew, I (think I) understand and agree with your concerns. But I also expected at least a minimal interface to already be in place, as the ReviewBoard tool already fetches data from various repos (so it can display commit lists, compare patches, etc.), so augmenting that to allow full repo navigation would be a natural extension. But I can definitely see this being a substantial effort, and I just wanted to know whether anyone had already done or thought about such a task. Thanks, Stefan -- ...ich hab' noch einen Koffer in Berlin... -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: repo navigation with ReviewBoard
On 2014-10-01 16:20, christ...@beanbaginc.com wrote: > Let me follow that up with saying that the beauty of Review Board is that not > only is it open source, but it has a very powerful extension framework. This > is a project that somebody could take on as an extension, test the waters, > and perhaps eventually contribute it to Review Board as a core feature. Right, I expected that answer. "Patches welcome" :-) Fair enough. Thanks, Stefan -- ...ich hab' noch einen Koffer in Berlin... -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
relaying email through ReviewBoard
Hello, I have successfully set up a RB instance prototype, and can receive mail notification on request creation as well as comments posted via the web interface. However, any replies sent to those messages go directly to the author(s), and are not routed through the RB instance. What settings am I missing that would allow me to do all RB communication via email, i.e. that would allow replies to be routed back through the RB instance (so they are properly recorded there) ? The online docs on https://www.reviewboard.org/docs/manual/2.0/admin/configuration/email-settings/#email-settings are talking**about a "sender e-mail address", but what exactly I need to put there isn't entirely clear to me.** Thanks, Stefan -- ...ich hab' noch einen Koffer in Berlin... -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
querying RB for statistics
Hello, is it possible to query a RB instance for summary information, such as * how many open review requests there are * how many review requests were closed in a given timeframe * a list of all open review requests associated with a particular group of users Etc. ? This information would be a great selling point for engineering management... :-) Thanks, Stefan -- ...ich hab' noch einen Koffer in Berlin... -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: querying RB for statistics
On Tuesday, October 7, 2014 1:48:04 PM UTC-4, Stefan Seefeld wrote: > > Hello, > > is it possible to query a RB instance for summary information, such as > > * how many open review requests there are > * how many review requests were closed in a given timeframe > * a list of all open review requests associated with a particular group > of users > > Etc. ? This information would be a great selling point for engineering > management... :-) > Ping ? Is any of this already possible ? If not, is it planned to add such capabilities in an upcoming release ? Thanks, Stefan -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: querying RB for statistics
On 2014-10-09 15:00, christ...@beanbaginc.com wrote: > Hi Stefan, > > We're adding reporting functionality to our Power Pack add-on product for > Review Board. It's still in beta, but a release is expected next week. For > now, please see > https://www.reviewboard.org/news/2014/06/03/powerpack-reports-beta/ Ah, perfect timing ! :-) I'll sign up for beta-testing right away. Thanks, Stefan -- ...ich hab' noch einen Koffer in Berlin... -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Search by filename
Hi guys, I'm wondering if it is possible to enable searching for the filename of the sources. Is there already something like this? Thanks & best regards, Stefan -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
UnicodeDecodeError in reviewboard\reviews\views.py
Hi,
I'm using Windows x64 with Python2.7.9 x64.
When calling http://localhost/reviewboard/r/new/ I'm receiving an *internal
server error 500.*
In the reviewboard.log I have the following trace.
'ascii' codec can't decode byte 0xfc in position 39: ordinal not in
> range(128)
> Traceback (most recent call last):
> File
> "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\core\handlers\base.py",
>
> line 112, in get_response
> response = wrapped_callback(request, *callback_args, **callback_kwargs)
> File
> "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\contrib\auth\decorators.py",
>
> line 22, in _wrapped_view
> return view_func(request, *args, **kwargs)
> File
> "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\site\decorators.py",
>
> line 35, in _check
> return view_func(request, local_site=local_site, *args, **kwargs)
> File
> "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\reviews\views.py",
>
> line 260, in new_review_request
> '%s (ID %d): %s' % (repo.name.encode('utf-8'), repo.id, e),
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xfc in position 39:
> ordinal not in range(128)
The effected code is the following:
for repo in repos.order_by('name'):
try:
scmtool = repo.get_scmtool()
valid_repos.append({
'id': repo.id,
'name': repo.name,
'scmtool_name': scmtool.name,
'supports_post_commit': repo.supports_post_commit,
'local_site_name': local_site_name,
'files_only': False,
'requires_change_number': scmtool.
supports_pending_changesets,
'requires_basedir': not scmtool.get_diffs_use_absolute_paths
(),
})
except Exception as e:
logging.error('Error loading SCMTool for repository '
'%s (ID %d): %s' % (repo.name, repo.id, e), #ERROR
HERE
exc_info=1)
When I simply replace the lines with the following it works without a
problem.
except Exception as e:
logging.error('Error loading SCMTool for repository ')
Since I'm not really into Python, I was not able to do a more sensefully
fix.
I bet you will find a better solution.
Best regards, Stefan
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: UnicodeDecodeError in reviewboard\reviews\views.py
I had another look into the issue,
the following fixes the wrong logging and creates a log with the real
problem in reviewboard.log
except Exception as e:
logging.exception('Error loading SCMTool for repository '
'%s (ID %d)',
repo.name,
repo.id)
2015-02-19 16:42:38,289 - ERROR - - Error loading SCMTool for repository
> ClearCase - at_v16.2seco_ui-mods_maint_bho (ID 13)
> Traceback (most recent call last):
> File
> "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\reviews\views.py",
>
> line 247, in new_review_request
> scmtool = repo.get_scmtool()
> File
> "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\scmtools\models.py",
>
> line 230, in get_scmtool
> return cls(self)
> File
> "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\scmtools\clearcase.py",
>
> line 67, in __init__
> self.viewtype = self._get_view_type(self.repopath)
> File
> "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\scmtools\clearcase.py",
>
> line 162, in _get_view_type
> shell=_popen_shell)
> File "C:\Python27\Lib\subprocess.py", line 710, in __init__
> errread, errwrite)
> File "C:\Python27\Lib\subprocess.py", line 958, in _execute_child
> startupinfo)
> WindowsError: [Error 267] Der Verzeichnisname ist ungültig
> 2015-02-19 16:42:38,730 - ERROR - - Error loading SCMTool for repository
> ClearCase - jcp-be_v17.1_int (ID 20)
> Traceback (most recent call last):
> File
> "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\reviews\views.py",
>
> line 247, in new_review_request
> scmtool = repo.get_scmtool()
> File
> "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\scmtools\models.py",
>
> line 230, in get_scmtool
> return cls(self)
> File
> "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\scmtools\clearcase.py",
>
> line 67, in __init__
> self.viewtype = self._get_view_type(self.repopath)
> File
> "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\scmtools\clearcase.py",
>
> line 162, in _get_view_type
> shell=_popen_shell)
> File "C:\Python27\Lib\subprocess.py", line 710, in __init__
> errread, errwrite)
> File "C:\Python27\Lib\subprocess.py", line 958, in _execute_child
> startupinfo)
> WindowsError: [Error 267] Der Verzeichnisname ist ungültig
On of my views was missing
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: UnicodeDecodeError in reviewboard\reviews\views.py
Hi, I just ran in the next related problem. Now the Admin/System Information/Server Log is crashing with 'ascii' codec can't decode byte 0xc3 in position 53: ordinal not in range(128) Traceback (most recent call last): File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\core\handlers\base.py", line 112, in get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\contrib\admin\views\decorators.py", line 17, in _checklogin return view_func(request, *args, **kwargs) File "C:\Python27\lib\site-packages\djblets-0.8.15-py2.7.egg\djblets\log\views.py", line 277, in server_log 'sort_type': sort_type, File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\shortcuts\__init__.py", line 29, in render_to_response return HttpResponse(loader.render_to_string(*args, **kwargs), **httpresponse_kwargs) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\loader.py", line 164, in render_to_string return t.render(Context(dictionary)) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\base.py", line 140, in render return self._render(context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\base.py", line 134, in _render return self.nodelist.render(context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\base.py", line 840, in render bit = self.render_node(node, context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\base.py", line 854, in render_node return node.render(context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\loader_tags.py", line 123, in render return compiled_parent._render(context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\base.py", line 134, in _render return self.nodelist.render(context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\base.py", line 840, in render bit = self.render_node(node, context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\base.py", line 854, in render_node return node.render(context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\loader_tags.py", line 123, in render return compiled_parent._render(context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\base.py", line 134, in _render return self.nodelist.render(context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\base.py", line 840, in render bit = self.render_node(node, context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\base.py", line 854, in render_node return node.render(context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\loader_tags.py", line 62, in render result = block.nodelist.render(context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\base.py", line 840, in render bit = self.render_node(node, context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\base.py", line 854, in render_node return node.render(context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\loader_tags.py", line 62, in render result = block.nodelist.render(context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\base.py", line 840, in render bit = self.render_node(node, context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\base.py", line 854, in render_node return node.render(context) File "C:\Python27\lib\site-packages\django-1.6.10-py2.7.egg\django\template\defaulttags.py", line 155, in render values = list(values) File "C:\Python27\lib\site-packages\djblets-0.8.15-py2.7.egg\djblets\log\views.py", line 148, in iter_log_lines line_info[2] + "\n" + line) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 53: ordinal not in range(128) In the meanwhile I figured out, that the root cause is my german windows which is logging an exception using the Umlaut Ü: WindowsError: [Error 267] Der Verzeichnisname ist ungültig There might be a lot more unfound problems. I know Windows is not supported anymore but maybe you can at least write a hint into the installation Wiki that an English windows installation is recommended. Best regards, Stefan On Thursday
