RE: TFS support
Our org got TFS to work with Reviewboard using the aforementioned SVNBridge. Not to self promote, but I wrote up the instructions we used on my blog: http://blogs.pinet.ca/tim/2010/08/24/code-review-goodness-with-reviewboard/ If any of the instructions do not work for you, let me know in the comments and I can update the procedure. Thanks, Tim -Original Message- From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Christian Hammond Sent: December-07-10 6:14 AM To: reviewboard@googlegroups.com Subject: Re: TFS support We've had a few companies who have written TFS support. I believe most made it work with an SVN bridge, but I think someone out there wrote some sort of true TFS support. If you're reading this, we'd love a contribution so we can include it :) Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Dec 7, 2010 at 2:51 AM, alibaba82 wrote: > Hello, > We are a mostly .NET and I have not really seen a good code review > tool out there. Any idea when and if you guys would offer support for > TFS. I'm not a great a developer but maybe you can use some of the > pieces from hudson code base. Hudson has very good integration with > TFS > > http://wiki.hudson-ci.org/display/HUDSON/Team+Foundation+Server+Plugin > > Thanks > > Ali > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RE: post-review - dis-contiguous revisions
Another option would be to create story branches in SVN then migrate back to trunk at story completion. This way you can review a story branch using a range and not be "polluted" with trunk checkins or other branches. This would of course be a philosophy shift in your org and we all know how programmers enjoy change J Tim From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Christian Hammond Sent: February-09-11 2:24 AM To: reviewboard@googlegroups.com Subject: Re: post-review - dis-contiguous revisions Hi Martin. You can't, really. You will have to have a review request per consecutive range. It doesn't really make sense otherwise, since we have to literally apply those changes and then show what happened between the two ends of the range. Having holes in that range doesn't mean anything useful. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Feb 8, 2011 at 11:17 PM, mmacrobert wrote: I'm trialling Reviewboard for my organisation and my workgroup. I've successfully used "post-review" to create review-requests on my reviewboard installation on Win32 and integrating with SVN. My team follows a pattern of numerous small checkins for completion of a story. Even for a small team this leads to dis-contiguous collection of revision numbers for a given story, so the "--revision-range=" parameter may be inappropriate for the task. How can I use post-review to generate a review-request based upon a discontiguous collection of review numbers? Thanks in advance. Martin -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com <mailto:reviewboard%2bunsubscr...@googlegroups.com> For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RE: Error for reviewboard on windows
I got it working on Windows using: http://blogs.pinet.ca/tim/2010/08/24/code-review-goodness-with-reviewboard/ I had to change the DocumentRoot from what reviewboard generated during install so this may be your problem. Tim -Original Message- From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of madmax Sent: February-24-11 7:04 AM To: reviewboard Subject: Error for reviewboard on windows Hi, I am using the following softwares, Reviewboard 1.5 Apache 2.2 Python 2.5 I am only able to see the directory listing in the reviewboard site. I have done changes in the http.conf and httpd_vhosts.conf. Still I am not able to figure out why am I not able to see the site. The contents of http.conf , http_vhosts.conf and apache-modpython.conf are attached below. httpd.conf # # This is the main Apache HTTP server configuration file. It contains the # configuration directives that give the server its instructions. # See http://httpd.apache.org/docs/2.2> for detailed information. # In particular, see # http://httpd.apache.org/docs/2.2/mod/directives.html> # for a discussion of each configuration directive. # # Do NOT simply read the instructions in here without understanding # what they do. They're here only as hints or reminders. If you are unsure # consult the online docs. You have been warned. # # Configuration and logfile names: If the filenames you specify for many # of the server's control files begin with "/" (or "drive:/" for Win32), the # server will use that explicit path. If the filenames do *not* begin # with "/", the value of ServerRoot is prepended -- so "logs/foo.log" # with ServerRoot set to "C:/Program Files/Apache Software Foundation/ Apache2.2" will be interpreted by the # server as "C:/Program Files/Apache Software Foundation/Apache2.2/ logs/foo.log". # # NOTE: Where filenames are specified, you must use forward slashes # instead of backslashes (e.g., "c:/apache" instead of "c:\apache"). # If a drive letter is omitted, the drive on which httpd.exe is located # will be used by default. It is recommended that you always supply # an explicit drive letter in absolute paths to avoid confusion. # # ServerRoot: The top of the directory tree under which the server's # configuration, error, and log files are kept. # # Do not add a slash at the end of the directory path. If you point # ServerRoot at a non-local disk, be sure to point the LockFile directive # at a local disk. If you wish to share the same ServerRoot for multiple # httpd daemons, you will need to change at least LockFile and PidFile. # ServerRoot "C:/Program Files/Apache Software Foundation/Apache2.2" # # Listen: Allows you to bind Apache to specific IP addresses and/or # ports, instead of the default. See also the # directive. # # Change this to Listen on specific IP addresses as shown below to # prevent Apache from glomming onto all bound IP addresses. # #Listen 12.34.56.78:80 Listen 8080 Listen 8082 # # Dynamic Shared Object (DSO) Support # # To be able to use the functionality of a module which was built as a DSO you # have to place corresponding `LoadModule' lines at this location so the # directives contained in it are actually available _before_ they are used. # Statically compiled modules (those listed by `httpd -l') do not need # to be loaded here. # # Example: # LoadModule foo_module modules/mod_foo.so # LoadModule actions_module modules/mod_actions.so LoadModule alias_module modules/mod_alias.so LoadModule asis_module modules/mod_asis.so LoadModule auth_basic_module modules/mod_auth_basic.so #LoadModule auth_digest_module modules/mod_auth_digest.so #LoadModule authn_alias_module modules/mod_authn_alias.so #LoadModule authn_anon_module modules/mod_authn_anon.so #LoadModule authn_dbd_module modules/mod_authn_dbd.so #LoadModule authn_dbm_module modules/mod_authn_dbm.so LoadModule authn_default_module modules/mod_authn_default.so LoadModule authn_file_module modules/mod_authn_file.so #LoadModule authnz_ldap_module modules/mod_authnz_ldap.so #LoadModule authz_dbm_module modules/mod_authz_dbm.so LoadModule authz_default_module modules/mod_authz_default.so LoadModule authz_groupfile_module modules/mod_authz_groupfile.so LoadModule authz_host_module modules/mod_authz_host.so #LoadModule authz_owner_module modules/mod_authz_owner.so LoadModule authz_user_module modules/mod_authz_user.so LoadModule autoindex_module modules/mod_autoindex.so #LoadModule cache_module modules/mod_cache.so #LoadModule cern_meta_module modules/mod_cern_meta.so LoadModule cgi_module modules/mod_cgi.so #LoadModule charset_lite_module modules/mod_charset_lite.so #LoadModule dav_module modules/mod_dav.so #LoadModule dav_fs_module modules/mod_dav_fs.so #LoadModule dav_lock_module modules/mod_dav_lock.so #LoadModule dbd_module modules/mod_dbd.so #LoadModule deflate_module modules/mod_deflate.so L
RE: All inclusive WAMP installation
My instructions for ReviewBoard on Windows: http://blogs.pinet.ca/tim/2010/08/24/code-review-goodness-with-reviewboard/ Tim From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Christian Hammond Sent: March-20-11 3:54 PM To: reviewboard@googlegroups.com Cc: Sam Batista Subject: Re: All inclusive WAMP installation Hi Sam, Unfortunately, as you know, installation on Windows is a real pain. We had some work done on creating an installer that helps with some of the dependencies, and will hopefully finish that up for 1.6. In your case, I'm not really sure what you mean about getting the conf file to work. MySQL not showing up means that the Python bindings weren't installed for it in a place where your Python install could find it. In general, we recommend installing on Linux, whether on a real box or in a VM, as it's *much* easier and will be better supported. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sun, Mar 20, 2011 at 12:11 PM, Sam Batista wrote: I have failed miserably at getting ReviewBoard installed on Windows with WAMP server, I installed all the dependencies and got to the "creating a site" part, but I couldn't figure out how to get the .conf file to work, also, MySQL wasn't shown as an option from the "rb-site install command. I've read about using mod_python online and everyone keeps saying to use mod_wsgi, so it would be cool is someone created a tutorial on how to get it up and running on Windows with WAMP, or I'd be willing to make a generous PayPal donation to someone with the time and patience to make an installer that would just work. This program is already pretty mature, it's about time someone makes it easy to get it up and running. Thanks. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com <mailto:reviewboard%2bunsubscr...@googlegroups.com> For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Trying to upload an id_rsa gives Uploading SSH key failed: This SSH key is not a valid RSA or DSS key error.
Review Board won't handle password protected private keys. If you entered a passphrase when generating the key then I found ReviewBoard can't handle it. BAD: -BEGIN RSA PRIVATE KEY- Proc-Type: 4,ENCRYPTED DEK-Info: AES-128-CBC,85167E3A8D2D8131CEEFC74E556378BC qg1I0mSPigMqCKLx4jDX/ueLhOmerA3qiqCMY+bqRjeC7nJFoMDrPFgwkQZrJc5W etc. GOOD: -BEGIN RSA PRIVATE KEY- MIIEowIBAAKCAQEAmAsqAA0z5dTFrP/fYAAG0yefvyJVOp7OfQC0XhxsFMs2gkGa etc. Tim On Tuesday, April 30, 2013 9:19:11 PM UTC+1, mamta.n...@gmail.com wrote: > > Hi, > I'm trying to upload an id_rsa private key to reviewboard to authenticate > with Git repo, but it fails with the error > Uploading SSH key failed: This SSH key is not a valid RSA or DSS key > > Permissions on id_rsa were set using chmod 600 > > Thanks, > M > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Trying to upload an id_rsa gives Uploading SSH key failed: This SSH key is not a valid RSA or DSS key error.
Same place it's stores all the other passwords? Admittedly, this is a feature that imho is missing. Tim On Wednesday, May 1, 2013 8:35:18 PM UTC+1, Matthew Woehlke wrote: > > On 2013-05-01 07:23, Tim wrote: > > Review Board won't handle password protected private keys. If you > entered a > > passphrase when generating the key then I found ReviewBoard can't handle > it. > > Well... yeah. Where would RB store the pass-phrase? :-) > > -- > Matthew > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Trying to upload an id_rsa gives Uploading SSH key failed: This SSH key is not a valid RSA or DSS key error.
Yes, I totally agree. There is no security advantage to be gained. For our case, any user (and reviewboard has its own user) on our network has a password protected rsa key pair so to set up reviewboard required some hoops to be jumped through. Allowing a password just makes setup simpler :) Back to the OT I definitely think a more informative key error message would be good, i.e. why is the rsa key i provided bad? Tim On Tuesday, April 30, 2013 9:19:11 PM UTC+1, mamta.n...@gmail.com wrote: > > Hi, > I'm trying to upload an id_rsa private key to reviewboard to authenticate > with Git repo, but it fails with the error > Uploading SSH key failed: This SSH key is not a valid RSA or DSS key > > Permissions on id_rsa were set using chmod 600 > > Thanks, > M > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
error at /r/30/publish/
Hi,
I am doing a proof of concept with reviewboard and everything is now
working properly except when I go to publish a review from a CVS patch
file. The review is created however I receive the following error
stack:
error at /r/30/publish/
(111, 'Connection refused')
Request Method: GET
Request URL:http://something.com/r/30/publish/
Exception Type: error
Exception Value:
(111, 'Connection refused')
Exception Location: /usr/lib/python2.4/smtplib.py in connect, line
306
Python Executable: /usr/bin/python
Python Version: 2.4.3
Python Path:['/opt', '/opt/reviewboard', '/usr/lib/python2.4/site-
packages/setuptools-0.6c5-py2.4.egg', '/usr/lib/python2.4/site-
packages/MySQL_python-1.2.2-py2.4-linux-i686.egg', '/usr/lib/python2.4/
site-packages/Pygments-0.11.1-py2.4.egg', '/usr/lib/python2.4/site-
packages/Trac-0.11-py2.4.egg', '/usr/lib/python2.4/site-packages/
Genshi-0.5.1-py2.4-linux-i686.egg', '/usr/lib/python2.4/site-packages/
FreemindMacro-0.1-py2.4.egg', '/usr/lib/python24.zip', '/usr/lib/
python2.4', '/usr/lib/python2.4/plat-linux2', '/usr/lib/python2.4/lib-
tk', '/usr/lib/python2.4/lib-dynload', '/usr/lib/python2.4/site-
packages', '/usr/lib/python2.4/site-packages/Numeric', '/usr/lib/
python2.4/site-packages/PIL', '/usr/lib/python2.4/site-packages/
gtk-2.0']
Server time:Mon, 20 Oct 2008 11:33:41 -0700
Here is the traceback:
Environment:
Request Method: GET
Request URL: http://something.com/r/30/publish/
Django Version: 1.0-final-SVN-unknown
Python Version: 2.4.3
Installed Applications:
['django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.markup',
'django.contrib.sites',
'django.contrib.sessions',
'djblets.datagrid',
'djblets.feedview',
'djblets.siteconfig',
'djblets.util',
'djblets.webapi',
'reviewboard.accounts',
'reviewboard.admin',
'reviewboard.changedescs',
'reviewboard.diffviewer',
'reviewboard.iphone',
'reviewboard.reports',
'reviewboard.reviews',
'reviewboard.scmtools',
'reviewboard.webapi',
'django_evolution']
Installed Middleware:
('django.middleware.common.CommonMiddleware',
'django.middleware.doc.XViewMiddleware',
'django.middleware.locale.LocaleMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'djblets.log.middleware.LoggingMiddleware',
'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')
Traceback:
File "/usr/lib/python2.4/site-packages/django/core/handlers/base.py"
in get_response
86. response = callback(request, *callback_args,
**callback_kwargs)
File "/opt/reviewboard/djblets/auth/util.py" in _checklogin
45. return view_func(request, *args, **kwargs)
File "/opt/reviewboard/reviews/views.py" in publish
457. review_request.publish(request.user)
File "/opt/reviewboard/reviews/models.py" in publish
369. mail_review_request(user, self)
File "/opt/reviewboard/reviews/email.py" in mail_review_request
184. extra_context)
File "/opt/reviewboard/reviews/email.py" in send_review_mail
114. message.send()
File "/usr/lib/python2.4/site-packages/django/core/mail.py" in send
265. return
self.get_connection(fail_silently).send_messages([self])
File "/usr/lib/python2.4/site-packages/django/core/mail.py" in
send_messages
166. new_conn_created = self.open()
File "/usr/lib/python2.4/site-packages/django/core/mail.py" in open
131.
local_hostname=DNS_NAME.get_fqdn())
File "/usr/lib/python2.4/smtplib.py" in __init__
244. (code, msg) = self.connect(host, port)
File "/usr/lib/python2.4/smtplib.py" in connect
306. raise socket.error, msg
Exception Type: error at /r/30/publish/
Exception Value: (111, 'Connection refused')
Any help is appreciated. Thanks!
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: error at /r/30/publish/
Christian,
Thanks for the prompt reply. I can send e-mail with the same host
from the command line as root and this works properly. What can I do
to produce good debug or to run a good test case? Could it be an
issue with the user apache?
import smtplib
s=smtplib.SMTP("localhost")
tolist=["[EMAIL PROTECTED]"]
msg = '''
From: [EMAIL PROTECTED]
Subject: testin'
This is a test '''
s.sendmail("[EMAIL PROTECTED]",tolist,msg)
{}
s.quit()
On Oct 20, 4:38 pm, "Christian Hammond" <[EMAIL PROTECTED]> wrote:
> This looks like your Review Board server is unable to talk to your mail
> server. Check to make sure all the settings are correct and that your mail
> server is reachable from there.
>
> Christian
>
> --
> Christian Hammond - [EMAIL PROTECTED]
> VMware, Inc.
>
> On Mon, Oct 20, 2008 at 11:45 AM, Tim <[EMAIL PROTECTED]> wrote:
>
> > Hi,
>
> > I am doing a proof of concept with reviewboard and everything is now
> > working properly except when I go to publish a review from a CVS patch
> > file. The review is created however I receive the following error
> > stack:
>
> > error at /r/30/publish/
>
> > (111, 'Connection refused')
>
> > Request Method: GET
> > Request URL: http://something.com/r/30/publish/
> > Exception Type: error
> > Exception Value:
>
> > (111, 'Connection refused')
>
> > Exception Location: /usr/lib/python2.4/smtplib.py in connect, line
> > 306
> > Python Executable: /usr/bin/python
> > Python Version: 2.4.3
> > Python Path: ['/opt', '/opt/reviewboard', '/usr/lib/python2.4/site-
> > packages/setuptools-0.6c5-py2.4.egg', '/usr/lib/python2.4/site-
> > packages/MySQL_python-1.2.2-py2.4-linux-i686.egg', '/usr/lib/python2.4/
> > site-packages/Pygments-0.11.1-py2.4.egg', '/usr/lib/python2.4/site-
> > packages/Trac-0.11-py2.4.egg', '/usr/lib/python2.4/site-packages/
> > Genshi-0.5.1-py2.4-linux-i686.egg', '/usr/lib/python2.4/site-packages/
> > FreemindMacro-0.1-py2.4.egg', '/usr/lib/python24.zip', '/usr/lib/
> > python2.4', '/usr/lib/python2.4/plat-linux2', '/usr/lib/python2.4/lib-
> > tk', '/usr/lib/python2.4/lib-dynload', '/usr/lib/python2.4/site-
> > packages', '/usr/lib/python2.4/site-packages/Numeric', '/usr/lib/
> > python2.4/site-packages/PIL', '/usr/lib/python2.4/site-packages/
> > gtk-2.0']
> > Server time: Mon, 20 Oct 2008 11:33:41 -0700
>
> > Here is the traceback:
>
> > Environment:
>
> > Request Method: GET
> > Request URL:http://something.com/r/30/publish/
> > Django Version: 1.0-final-SVN-unknown
> > Python Version: 2.4.3
> > Installed Applications:
> > ['django.contrib.admin',
> > 'django.contrib.auth',
> > 'django.contrib.contenttypes',
> > 'django.contrib.markup',
> > 'django.contrib.sites',
> > 'django.contrib.sessions',
> > 'djblets.datagrid',
> > 'djblets.feedview',
> > 'djblets.siteconfig',
> > 'djblets.util',
> > 'djblets.webapi',
> > 'reviewboard.accounts',
> > 'reviewboard.admin',
> > 'reviewboard.changedescs',
> > 'reviewboard.diffviewer',
> > 'reviewboard.iphone',
> > 'reviewboard.reports',
> > 'reviewboard.reviews',
> > 'reviewboard.scmtools',
> > 'reviewboard.webapi',
> > 'django_evolution']
> > Installed Middleware:
> > ('django.middleware.common.CommonMiddleware',
> > 'django.middleware.doc.XViewMiddleware',
> > 'django.middleware.locale.LocaleMiddleware',
> > 'django.contrib.sessions.middleware.SessionMiddleware',
> > 'django.contrib.auth.middleware.AuthenticationMiddleware',
> > 'djblets.log.middleware.LoggingMiddleware',
> > 'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')
>
> > Traceback:
> > File "/usr/lib/python2.4/site-packages/django/core/handlers/base.py"
> > in get_response
> > 86. response = callback(request, *callback_args,
> > **callback_kwargs)
> > File "/opt/reviewboard/djblets/auth/util.py" in _checklogin
> > 45. return view_func(request, *args, **kwargs)
> > File "/opt
Re: error at /r/30/publish/
Ok I think I figured this out. Looks like there was an issue where
the settings_local.py had the correct settings, but when I logged into
the admin screen the mail server was set to localhost instead of the
correct external SMTP server. I removed the entry in
settings_local.py and updated it via the admin screen.
It seems if you have a setting in settings_local.py and try to update
via the admin screen the updates don't take as it changes the values
back when you save. Is this correct? Either way my problem seems to
be solved as e-mails are now working.
Thanks!
On Oct 20, 4:38 pm, "Christian Hammond" <[EMAIL PROTECTED]> wrote:
> This looks like your Review Board server is unable to talk to your mail
> server. Check to make sure all the settings are correct and that your mail
> server is reachable from there.
>
> Christian
>
> --
> Christian Hammond - [EMAIL PROTECTED]
> VMware, Inc.
>
> On Mon, Oct 20, 2008 at 11:45 AM, Tim <[EMAIL PROTECTED]> wrote:
>
> > Hi,
>
> > I am doing a proof of concept with reviewboard and everything is now
> > working properly except when I go to publish a review from a CVS patch
> > file. The review is created however I receive the following error
> > stack:
>
> > error at /r/30/publish/
>
> > (111, 'Connection refused')
>
> > Request Method: GET
> > Request URL: http://something.com/r/30/publish/
> > Exception Type: error
> > Exception Value:
>
> > (111, 'Connection refused')
>
> > Exception Location: /usr/lib/python2.4/smtplib.py in connect, line
> > 306
> > Python Executable: /usr/bin/python
> > Python Version: 2.4.3
> > Python Path: ['/opt', '/opt/reviewboard', '/usr/lib/python2.4/site-
> > packages/setuptools-0.6c5-py2.4.egg', '/usr/lib/python2.4/site-
> > packages/MySQL_python-1.2.2-py2.4-linux-i686.egg', '/usr/lib/python2.4/
> > site-packages/Pygments-0.11.1-py2.4.egg', '/usr/lib/python2.4/site-
> > packages/Trac-0.11-py2.4.egg', '/usr/lib/python2.4/site-packages/
> > Genshi-0.5.1-py2.4-linux-i686.egg', '/usr/lib/python2.4/site-packages/
> > FreemindMacro-0.1-py2.4.egg', '/usr/lib/python24.zip', '/usr/lib/
> > python2.4', '/usr/lib/python2.4/plat-linux2', '/usr/lib/python2.4/lib-
> > tk', '/usr/lib/python2.4/lib-dynload', '/usr/lib/python2.4/site-
> > packages', '/usr/lib/python2.4/site-packages/Numeric', '/usr/lib/
> > python2.4/site-packages/PIL', '/usr/lib/python2.4/site-packages/
> > gtk-2.0']
> > Server time: Mon, 20 Oct 2008 11:33:41 -0700
>
> > Here is the traceback:
>
> > Environment:
>
> > Request Method: GET
> > Request URL:http://something.com/r/30/publish/
> > Django Version: 1.0-final-SVN-unknown
> > Python Version: 2.4.3
> > Installed Applications:
> > ['django.contrib.admin',
> > 'django.contrib.auth',
> > 'django.contrib.contenttypes',
> > 'django.contrib.markup',
> > 'django.contrib.sites',
> > 'django.contrib.sessions',
> > 'djblets.datagrid',
> > 'djblets.feedview',
> > 'djblets.siteconfig',
> > 'djblets.util',
> > 'djblets.webapi',
> > 'reviewboard.accounts',
> > 'reviewboard.admin',
> > 'reviewboard.changedescs',
> > 'reviewboard.diffviewer',
> > 'reviewboard.iphone',
> > 'reviewboard.reports',
> > 'reviewboard.reviews',
> > 'reviewboard.scmtools',
> > 'reviewboard.webapi',
> > 'django_evolution']
> > Installed Middleware:
> > ('django.middleware.common.CommonMiddleware',
> > 'django.middleware.doc.XViewMiddleware',
> > 'django.middleware.locale.LocaleMiddleware',
> > 'django.contrib.sessions.middleware.SessionMiddleware',
> > 'django.contrib.auth.middleware.AuthenticationMiddleware',
> > 'djblets.log.middleware.LoggingMiddleware',
> > 'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')
>
> > Traceback:
> > File "/usr/lib/python2.4/site-packages/django/core/handlers/base.py"
> > in get_response
> > 86. response = callback(request, *callback_args,
> > **callback_kwargs)
> > File "/opt/reviewboard/djblets/auth/util.py" in _checklogin
> > 45.
yum repos on EC2 instances don't have ReviewBoard
Hello, I'm trying to install ReviewBoard via yum, i.e. 'sudo yum install ReviewBoard' and getting this response: sudo yum install ReviewBoard Loaded plugins: priorities, update-motd, upgrade-helper No package ReviewBoard available. Error: Nothing to do I'm running on an EC2 Linux instance in AWS (using the AMZN instance type). Do I need to install a specific repo to get this package? Thanks, Tim -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: HTTPS certificate not accepted
2009/7/10 Daniel > > Christian, > > Thank you for your reply. > > The 1st option is not possible for us, since the SVN repository is > controlled by Collabnet. Not sure what you exact collabnet setup is, but if you can create a new certificate that collabnet can access and grant it the Observer fold you can run reviewboard quite nicely. Add some extra lines to the .subversion/servers file in the home directory like this: [groups] csd200a = *.csd200a.com [csd200a] ssl-client-cert-file = /var/www/.subversion/cert.p12 ssl-client-cert-password = password [global] http-proxy-host = proxy.whatever.com http-proxy-port = 8080 This is on Linux - I have no idea about the details of Windows or the H:\ drive problem sorry. For the 2nd option, can you please tell me how to use my user name to > access the SVN server (thru https)? If you export a copy of your certificate and point to it in your servers file it should work. The only problem is you need to either leave it unencrypted or specify the password in the servers file. Both are pretty bad ideas in general. Having a special reviewboard specific certificate with read-only access is slightly better. Regards, Tim. > > > Thanks > Daniel > > On Jun 29, 5:21 pm, Christian Hammond wrote: > > Hi Daniel, > > > > From what I've seen, it seems tricky to get this to work right through > > Apache. What I'd strongly recommend, if possible, is to set a plain http > > repository for the path and use the https repository for the mirror path. > > The idea being that Review Board would just simply fetch the files from > the > > http repository and the mirror path would be what Review Board checks > when > > developers are posting changes for review. > > > > If you can't do this, then I think what you need to do is attempt to > access > > the server through https using your user and then move your .subversion > > directory into wherever Apache is trying to find it. You can probably set > an > > environment variable in the Apache configuration file (using SetEnv) to > > change this path. > > > > I'd like to make this easier in 1.1 or so. I know it's bitten a lot of > > people. > > > > Christian > > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.review-board.org > > VMware, Inc. -http://www.vmware.com > > > > > > > > On Mon, Jun 29, 2009 at 1:34 PM, Daniel wrote: > > > > > Hi, > > > > > I am new to ReviewBoard 1.0 and trying to configure RB with SVN. I got > > > RB installed but when I try to create a new Review Request, it comes > > > back with an error: > > > > > "HTTPS certificate not accepted. Please ensure that the proper > > > certificate exists in H:\ /.subversion/auth for the user that > > > reviewboard is running as." > > > > > I don't have any idea why it is looking for a certificate on H:\. On > > > my system there is an environment variable HOMEDRIVE which is set to H: > > > \. I read somewhere that this might be caused by Apache home directory > > > points to a wrong place, but not sure where I can change this. I am > > > able to do all SVN operations outside ReviewBoard > > > > > Any clue? > > > > > Thanks > > > Daniel > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Syntax highlighting
Hello, Firstly I just started using Review Board and have had a very positive experience so far, thanks! Is there some place to find out what syntax highlighting is available? Is it pluggable or standardized? I'm using C++ and objective-c. The C++ has some highlighting, but not very meaningful - it colors comments and import statements differently but no real highlighting in the code. In objective-c there is not highlighting at all. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Syntax highlighting
Thanks for the response, I'll take a look at pygment and try out your fix Dan. On Wed, Apr 21, 2010 at 12:17 PM, Christian Hammond wrote: > We used to use get_lexer and saw some serious performance problems with it, > which is why we switched to get_lexer_for_filename. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Wed, Apr 21, 2010 at 8:45 AM, Dan Savilonis wrote: > >> I've added support for changing the syntax highlighting scheme, if >> that will help with your disappointment in the highlighting. It's >> working, but it needs some better integration for installation. Right >> now you have to hack up the pygments generated styles with a script. >> >> http://github.com/djs/reviewboard/tree/pygments >> >> For the Obj-C issue, RB is currently using get_lexer_for_filename, but >> there is also a guess_lexer API that presumably would yield better >> results... >> >> Dan >> >> >> >> On Apr 20, 3:41 pm, Christian Hammond wrote: >> > Hi Tim, >> > >> > We use a Python module called Pygments (http://www.pygments.org/) for >> the >> > syntax highlighting, so we basically support whatever they do. >> > >> > The lack of Obj-C highlighting is certainly an annoyance that I've dealt >> > with too. It's due to Pygments giving preference to I think Matlab files >> or >> > something, over Obj-C. This is something I'd love to see them fix. >> > >> > There's a chance we may get support down the road for adding >> customizable >> > highlighting (as in, being able to say that this file extension will use >> > that type of highlighter). You wouldn't be able to add new syntax >> > highlighting rules with this, but it's something at least, and would fix >> the >> > Obj-C situation. However, I think the person who was working on this >> support >> > has been too busy to finish it up, so I'm not sure which release will >> end up >> > with it. >> > >> > Christian >> > >> > -- >> > Christian Hammond - chip...@chipx86.com >> > Review Board -http://www.reviewboard.org >> > VMware, Inc. -http://www.vmware.com >> > >> > On Tue, Apr 20, 2010 at 12:33 PM, Tim Hollingsworth < >> > >> > >> > >> > >> > >> > timhollingswo...@gmail.com> wrote: >> > > Hello, >> > >> > > Firstly I just started using Review Board and have had a very positive >> > > experience so far, thanks! >> > >> > > Is there some place to find out what syntax highlighting is >> > > available? Is it pluggable or standardized? >> > >> > > I'm using C++ and objective-c. The C++ has some highlighting, but not >> > > very meaningful - it colors comments and import statements differently >> > > but no real highlighting in the code. In objective-c there is not >> > > highlighting at all. >> > >> > > -- >> > > Want to help the Review Board project? Donate today at >> > >http://www.reviewboard.org/donate/ >> > > Happy user? Let us know athttp://www.reviewboard.org/users/ >> > > -~--~~~~--~~--~--~--- >> > > To unsubscribe from this group, send email to >> > > reviewboard+unsubscr...@googlegroups.com >> >> > > For more options, visit this group at >> > >http://groups.google.com/group/reviewboard?hl=en >> > >> > -- >> > Want to help the Review Board project? Donate today athttp:// >> www.reviewboard.org/donate/ >> > Happy user? Let us know athttp://www.reviewboard.org/users/ >> > -~--~~~~--~~--~--~--- >> > To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> > For more options, visit this group athttp:// >> groups.google.com/group/reviewboard?hl=en >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~--~~~~--~~--~--~--- >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
getting diff contents with the API
Is there a way to get the contents of posted diffs through the JSON API? Specifically what I want to find out is which files are covered by a given review. Tim -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: getting diff contents with the API
That's great to hear. Is it already in the repository, or do I need to wait before I can play with it? Tim On May 29, 10:02 am, Christian Hammond wrote: > Hi Tim, > > This is coming in 1.5 beta 3's new API. It will cover file lists and > diff contents (raw patch file, rendered HTML, and diff opcodes). > > Christian > > On Friday, May 28, 2010, Tim Newsome wrote: > > Is there a way to get the contents of posted diffs through the JSON > > API? Specifically what I want to find out is which files are covered > > by a given review. > > > Tim > > > -- > > Want to help the Review Board project? Donate today > > athttp://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group > > athttp://groups.google.com/group/reviewboard?hl=en > > -- > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: getting diff contents with the API
OK. That doesn't sound too far off then. :-) Can you let me know when it gets into the codebase. I'd be happy to be this feature's first beta tester. Tim On May 30, 11:27 am, Christian Hammond wrote: > It's still being developed. Hopefully I can get it up for review this > week. I'm out of town without a laptop at the moment. > > Christian > > > > > > On Sunday, May 30, 2010, Tim Newsome wrote: > > That's great to hear. Is it already in the repository, or do I need to > > wait before I can play with it? > > > Tim > > > On May 29, 10:02 am, Christian Hammond wrote: > >> Hi Tim, > > >> This is coming in 1.5 beta 3's new API. It will cover file lists and > >> diff contents (raw patch file, rendered HTML, and diff opcodes). > > >> Christian > > >> On Friday, May 28, 2010, Tim Newsome wrote: > >> > Is there a way to get the contents of posted diffs through the JSON > >> > API? Specifically what I want to find out is which files are covered > >> > by a given review. > > >> > Tim > > >> > -- > >> > Want to help the Review Board project? Donate today > >> > athttp://www.reviewboard.org/donate/ > >> > Happy user? Let us know athttp://www.reviewboard.org/users/ > >> > -~--~~~~--~~--~--~--- > >> > To unsubscribe from this group, send email to > >> > reviewboard+unsubscr...@googlegroups.com > >> > For more options, visit this group > >> > athttp://groups.google.com/group/reviewboard?hl=en > > >> -- > >> -- > >> Christian Hammond - chip...@chipx86.com > >> Review Board -http://www.reviewboard.org > >> VMware, Inc. -http://www.vmware.com > > > -- > > Want to help the Review Board project? Donate today > > athttp://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group > > athttp://groups.google.com/group/reviewboard?hl=en > > -- > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RE: email notification
Trying using the "submit-as" parameter. http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#automati ng-post-review I have a common "post" user account and pass the username in the submit-as param. tim -Original Message- From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Madhavi Sent: September-16-10 5:32 AM To: reviewboard Subject: email notification Hi, We are on ReviewBoard 1.0.9 on CentOS We are creating RB issues in post commit hook. I am calling postreview.py from the post commit hook. one of parameters to the command is --username to which I am passing a standard username say 'userxyz' other that the submitter. So when email notification is sent, it is sent by this this 'userxyz' and not by submitter user. If I want to send emails from the submitter's email id, how to I do it ? Regards -Madhavi -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RE: Manual server updates required: Install GNU Patch problem after installation on Windows/Apache
I had a hell of a time to get patch.exe to work too. I had to put it in C:\GnuWin32\bin and C:\Windows\system32 and set my PATH environment variable to: C:\GnuWin32\bin;C:\PHP\;%SystemRoot%\system32;%SystemRoot%;%SystemRoot%\Syst em32\Wbem;C:\MySQL\MySQL Server 5.1\bin;C:\Python26;C:\Python26\Scripts I wrote my entire install experience in my blog (http://blogs.pinet.ca/tim/2010/08/24/code-review-goodness-with-reviewboard/ ). Tim -Original Message- From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Ian Sent: September-17-10 12:36 PM To: reviewboard Subject: Manual server updates required: Install GNU Patch problem after installation on Windows/Apache Hi guys, I see a number of people have had this issue but none of their resolutions have helped me so I post again. I have installed everything on Windows following the instructions and all I see when I browse the site is "Manual server updates required" and underneath that "Install GNU patch.exe". * Patch is installed and I can run it from the command line. * It is on my system path. * I have tried changing Apache to run as myself so it has full priveleges and this did not work * I have tried copying patch to Apache's bin folder, this did not work. * There are no logs in my RB installation dir. Apache has some logs about Python version "Python version mismatch, expected '2.5', found '2.5.4'. but I'm not sure this is a serious issue. Can someone help me? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RE: Active Directory
We use AD auth on our Windows server and it works great. If you would like help with the settings then please email me personally (I don't want to post our params). Tim From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Christian Hammond Sent: October-11-10 5:50 AM To: reviewboard@googlegroups.com Subject: Re: Active Directory Hi, People do use it, but I guess nobody who uses it has had anything useful to contribute to this. The error you're getting is what we get from the Python ldap library when it determines that the server name you provided is down. This would indicate that either the machine is unreachable or that the port on it can't be reached. Are you able to ping the AD server as specified in Review Board's AD configuration from the Review Board server? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Oct 11, 2010 at 2:30 AM, Al West wrote: Does no one use active directory integration then? Thanks, Al On 5 October 2010 18:05, albal wrote: > Hi, > > I'm trying to get Active Directory Authentication working with > ReviewBoard 1.5. I am running on Debian-Lenny and I have a successful > install of ReviewBoard but I would like to have our users authenticate > against our domain servers. If I put the domain controller IP or name > in the field and hit save, then logout and back in I get the following > log entries: > > 2010-10-05 16:58:18,943 - WARNING - Active Directory: Domain > controller is down > 2010-10-05 16:58:18,943 - ERROR - Active Directory error: Could not > contact any domain controller servers > > The linux machine is not part of the domain, DNS is setup correctly > and the hostnames resolve fine. Is there something else that needs to > be in place? > > Thanks, > Al > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com <mailto:reviewboard%2bunsubscr...@googlegroups.com> For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Review Board with Mercurial - The file "/filename.py" was not found in the repository.
I am evaluating ReviewBoard and considering it for purchase. To do so, I ran a brand-new instance of the Demo Virtual Machine (running ReviewBoard 2.5.10) posted at https://bitnami.com/stack/reviewboard-plus-powerpack/virtual-machine. The only thing I did after starting up this VM is to install Mercurial (apt-get install mercurial) and add a locally-stored clone of the repository there and add the repository via the Admin page. When I attempt to create a Review Request, and specify one of the changesets that appears on the web page (under "Create from an existing commit on: default"), the resulting Review Request does not have anything auto-filled into the description from the changeset. I found the following in the reviewboard.log file: 2017-07-13 12:29:32,300 - ERROR - - Unable to update new review request from commit ID 7e3d96823f78e36f65d49ff9243d91cedc4ec8f8: The file '/foo.py' (r7b4e8afe08b4) could not be found in the repository: 7b4e8afe08b4886a21cb637ff2be6629bc82a4c7 Traceback (most recent call last): File "/opt/bitnami/apps/reviewboardpowerpack/htdocs/reviewboard/reviews/managers.py", line 157, in create draft.update_from_commit_id(commit_id) File "/opt/bitnami/apps/reviewboardpowerpack/htdocs/reviewboard/reviews/models/review_request_draft.py", line 278, in update_from_commit_id self.update_from_committed_change(commit_id) File "/opt/bitnami/apps/reviewboardpowerpack/htdocs/reviewboard/reviews/models/review_request_draft.py", line 352, in update_from_committed_change base_commit_id=commit.parent) File "/opt/bitnami/apps/reviewboardpowerpack/htdocs/reviewboard/diffviewer/managers.py", line 457, in create_from_data check_existence=(not parent_diff_file_contents))) File "/opt/bitnami/apps/reviewboardpowerpack/htdocs/reviewboard/diffviewer/managers.py", line 604, in _process_files base_commit_id) FileNotFoundError: The file '/foo.py' (r7b4e8afe08b4) could not be found in the repository: 7b4e8afe08b4886a21cb637ff2be6629bc82a4c7 I debugged it, and found that repository.get_file_exists returns False, due to a failure in the construction of the mercurial command line. Specifically, diffviewer/managers.py at line 630 takes the file name listed in the changeset (e.g. 'foo.py'), and calls self._normalize_filename with a 'basedir' value of '/' (a hard-coded value set by an earlier routine on the call stack), resulting in the filename '/foo.py'. This results in the command being invoked as: hg cat --rev /foo.py If you type this command manually at a prompt, Mercurial (correctly) returns the message "abort: /foo.py not under root ". This error message is correct because there should NOT be a leading slash at the front of a file name (at least not when using Mercurial). This ReviewBoard bug renders support in a local Mercurial repository to be non-functional. Has this problem been fixed in a later version? If so, can the demonstration Virtual Machine be updated to the later version that contains this fix? If not yet fixed, can this problem be fixed, so that I might consider buying this product? -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
