Question about the API info
Hi I am not sure that if this is a doc bug or not: http://www.reviewboard.org/docs/manual/dev/webapi/reference/apicalls/login/#api-login As you said the type of password is Boolean, which is confusing me, could you please check it? BR/Vincent -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Aggregated diffs and added files
Hi.actually I have the same problem.but maybe it is because I have am still using the beta version Sent using a Sony Ericsson mobile phone Original message From: Christian Hammond Sent: To: reviewboard@googlegroups.com Subject: Re: Aggregated diffs and added files Without seeing the diff, it's a little hard to say. However, the end result must be a diff that can be applied to a working tree, and each file listed in the diff must contain either a revision that along with the filename can be fetched individually from an SVN server (therefore, it must exist) or be marked as a new file (which I suspect it's not, from the merge). Basically, if you have a diff that says this one file is based on revision XYZ at this location, and the SVN server can't look up that revision at that path, we can't display the diff. There's not much we can do about that there from Review Board's side. What I'd recommend is using our post-review command instead of svn diff. It handles some things like renames and fixing up file paths in the diffs before sending to Review Board. Hopefully it will fix your case. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Dec 9, 2010 at 8:25 AM, Sasha O wrote: > To clarify: my problem is that if a file was a new file created in one > of the revisions then > ReviewBoard barks at this file with the message "The file 'https:// > /myfile1' (r >> $first-rev-1) could not be found in the repository" and doesn't create >> review request. > > I am stuck and cannot use ReviewBoard. > > Thanks for any insight. > -- Sasha > > On Dec 6, 11:02 am, Sasha O wrote: >> Dear All -- >> >> I am trying to create review for a bunch of changes. These changes >> involved adding new files. The way I am doing this is: >> >> svn up -r $first-rev-1 >> svn merge -c $first-rev . >> svn merge -c $second-rev . >> A myfile1 >> ... >> svn diff > bunch.diff >> >> create review request in the Web UI by uploading bunch.diff >> >> I am getting error message like "The file 'https:///myfile1' (r >> $first-rev-1) could not be found in the repository >> >> I am doing something wrong? What is the way around this? >> >> Thanks in advance, >> -- Sasha > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RE: 500 - Internal Server Error | Review Board
Thanks... That fix the problem now I am able to see the login and registration GUI etc... Vincent From: chip...@gmail.com [mailto:chip...@gmail.com] On Behalf Of Christian Hammond Sent: Thursday, March 24, 2011 5:28 PM To: reviewboard@googlegroups.com Cc: Vincent Yee Subject: Re: 500 - Internal Server Error | Review Board Hi, Looks like a new python-dateutil was just released today that only works with Python 3, and it's being fetched. That's not good. We'll have to get out an update to be more specific about the version needed. Try getting rid of the old version (rm -rf /usr/lib/python2.4/site-packages/python_dateutil-2.0-py2.4.egg/) Then: easy_install -U python_dateutil==1.5 Christian -- Christian Hammond - chip...@chipx86.com<mailto:chip...@chipx86.com> Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Mar 24, 2011 at 5:24 PM, storms mailto:v...@sendmail.com>> wrote: Just installed 1.5.4 with Apache + mod_python started apache, and try to access web and got the following and got the following error via browser: 500 - Internal Server Error | Review Board - Mozilla Firefox Something broke! (Error 500) It appears something broke when you tried to go to here. This is either a bug in Review Board or a server configuration error. Please report this to your administrator. here's the log file: [Thu Mar 24 17:10:53 2011] [notice] suEXEC mechanism enabled (wrapper: /usr/sbin/suexec) [Thu Mar 24 17:10:53 2011] [notice] Digest: generating secret for digest authentication ... [Thu Mar 24 17:10:53 2011] [notice] Digest: done [Thu Mar 24 17:10:53 2011] [notice] mod_python: Creating 4 session mutexes based on 256 max processes and 0 max threads. [Thu Mar 24 17:10:53 2011] [notice] Apache/2.2.3 (Red Hat) configured -- resuming normal operations /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/db/ __init__.py:19: DeprecationWarning: settings.DATABASE_* is deprecated; use settings.DATABASES instead. DeprecationWarning /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/db/ __init__.py:60: DeprecationWarning: Short names for ENGINE in database configurations are deprecated. Prepend default.ENGINE with 'django.db.backends.' DeprecationWarning /usr/lib/python2.4/site-packages/pycrypto-2.3-py2.4-linux-i686.egg/ Crypto/Util/randpool.py:40: RandomPool_DeprecationWarning: This application uses RandomPool, which is BROKEN in older releases. See http://www.pycrypto.org/randpool-broken /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/core/ context_processors.py:27: DeprecationWarning: The context processor at `django.core.context_processors.auth` is deprecated; use the path `django.contrib.auth.context_processors.auth` instead. DeprecationWarning /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/ loaders/filesystem.py:58: DeprecationWarning: 'django.template.loaders.filesystem.load_template_source' is deprecated; use 'django.template.loaders.filesystem.Loader' instead. DeprecationWarning ERROR:root:Exception thrown for user AnonymousUser at http://vmreviews.qa-lab.sendmail.com/reviews/account/login/?next_page=/reviews/dashboard/ invalid syntax (parser.py, line 23) Traceback (most recent call last): File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ core/handlers/base.py", line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File "/usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/auth/views.py", line 80, in login return render_to_response(template_name, context) File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ shortcuts/__init__.py", line 20, in render_to_response return HttpResponse(loader.render_to_string(*args, **kwargs), **httpresponse_kwargs) File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ template/loader.py", line 183, in render_to_string return t.render(Context(dictionary)) File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ template/base.py", line 123, in render return self._render(context) File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ template/base.py", line 117, in _render return self.nodelist.render(context) File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ template/base.py", line 744, in render bits.append(self.render_node(node, context)) File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ template/base.py", line 757, in render_node return node.render(context) File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ template/loader_tags.py", line 127, in render return compiled_parent._render(context) File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ template/base.py",
RE: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or more fields had errors
On my client I have set
export P4PORT=perforce.example.com:1666
Ping perforce.example.com works
PING repoman.example.com (x.y.z.a) 56(84) bytes of data.
64 bytes from repoman.example.com (x.y.z.a): icmp_seq=1 ttl=63 time=0.504 ms
64 bytes from repoman.example.com (x.y.z.a): icmp_seq=2 ttl=63 time=0.335 ms
$ telnet perforce.example.com 1666
Trying x.y.z.a...
Connected to perforce.example.com (x.y.z.a).
Escape character is '^]'.
;;xfiles5server3server217funprotocol^]
telnet>
From: chip...@gmail.com [mailto:chip...@gmail.com] On Behalf Of Christian
Hammond
Sent: Wednesday, March 30, 2011 3:41 PM
To: reviewboard@googlegroups.com
Cc: Vincent Yee
Subject: Re: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or
more fields had errors
Sounds like the Review Board server isn't able to contact your Perforce server
for some reason. Might want to try SSHing into that server, temporarily setting
P4PORT in your session, and accessing the server. Or try pinging it for an
initial test.
Christian
--
Christian Hammond - chip...@chipx86.com<mailto:chip...@chipx86.com>
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Mar 30, 2011 at 3:36 PM, storms
mailto:v...@sendmail.com>> wrote:
trying to setup post-review with perforce got the following error.
I am able to ping and telnet to the perforce server from my
client my repository setting is:
Hosting service: Custom
Repository type: Perforce
Path: perforce.example.com<http://perforce.example.com>
Username:
Password:
$ post-review --debug --summary=p4-testing-change
>>> RBTools 0.3.2
>>> Home = /home/build
>>> svn info
>>> p4 info
>>> repository info: Path:
>>> repoman.example.com:1666<http://repoman.example.com:1666>, Base path: None,
>>> Supports changesets: True
>>> HTTP GETting api/
>>> HTTP GETting http://vmreviews.lab-example.com/reviews/api/info/
>>> Using the new web API
>>> Generating diff for changenum default
>>> p4 opened -c default
>>> Processing edit of //depot/Iocaine/main/Product/build.xml
>>> Writing "//depot/Iocaine/main/Product/build.xml#197" to "/tmp/tmpzT7Exi"
>>> p4 print -o /tmp/tmpzT7Exi -q //depot/Iocaine/main/Product/build.xml#197
>>> diff -urNp /tmp/tmpzT7Exi
>>> /home/build/build_client/Iocaine/main/Product/build.xml
>>> Using changenums on Review Board 1.5.2. Falling back to the deprecated 1.0
>>> API
==> Review Board Login Required
Enter username and password for Review Board at
http://vmreviews.lab-example.com/reviews/
>>> Looking for 'vmreviews.lab-example /reviews/' cookie in
>>> /home/build/.post-review-cookies.txt
>>> Loaded valid cookie -- no login required
>>> Attempting to create review request on
>>> perforce.example.com<http://perforce.example.com> for None
>>> HTTP POSTing to
>>> http://vmreviews.lab-example.com/reviews/api/json/reviewrequests/new/:
>>> {'repository_path': 'perforce.example.com<http://perforce.example.com>'}
>>> Review request created
>>> Attempting to set field 'summary' to 'p4-testing-change' for review request
>>> '12'
>>> HTTP POSTing to
>>> http://vmreviews.lab-example.com/reviews/api/json/reviewrequests/12/draft/set/:
>>> {'summary': 'p4-testing-change'}
>>> Uploading diff, size: 361
>>> HTTP POSTing to
>>> http://vmreviews.lab-example.com/reviews/api/json/reviewrequests/12/diff/new/:
>>> {}
>>> Got API Error 105 (HTTP code 200): One or more fields had errors
>>> Error data: {u'fields': {u'path': [u'[P4.connect()] Connect to server
>>> failed; check $P4PORT.\nTCP connect to
>>> perforce.example.com<http://perforce.example.com>
>>> failed.\nperforce.example.com<http://nperforce.example.com>: service
>>> unknown.\n']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had
>>> errors', u'code': 105}, u'deprecated': {u'in_version': u'1.5'}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
$ post-review --debug --summary=p4-testing-change --output-diff
>>> RBTools 0.3.2
>>> Home = /home/build
>>> svn info
>>> p4 info
>>> repository info: Path:
>>> repoman.exampl
RE: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or more fields had errors
I get a different error message if I have :1666 on my repository entry (Got API
Error 206 (HTTP code 200)
$ post-review --debug --summary=p4-testing-change
>>> RBTools 0.3.2
>>> Home = /home/build
>>> svn info
>>> p4 info
>>> repository info: Path: repoman.smi.sendmail.com:1666, Base path: None,
>>> Supports changesets: True
>>> HTTP GETting api/
>>> HTTP GETting http://vmreviews.lab-example.com/reviews/api/info/
>>> Using the new web API
>>> Generating diff for changenum default
>>> p4 opened -c default
>>> Processing edit of //depot/Iocaine/main/Product/build.xml
>>> Writing "//depot/Iocaine/main/Product/build.xml#197" to "/tmp/tmpIdYR5a"
>>> p4 print -o /tmp/tmpIdYR5a -q //depot/Iocaine/main/Product/build.xml#197
>>> diff -urNp /tmp/tmpIdYR5a
>>> /home/build/build_client/Iocaine/main/Product/build.xml
>>> Using changenums on Review Board 1.5.2. Falling back to the deprecated 1.0
>>> API
==> Review Board Login Required
Enter username and password for Review Board at
http://vmreviews.lab-example.com/reviews/
>>> Looking for 'vmreviews.qa-lab.sendmail.com /reviews/' cookie in
>>> /home/build/.post-review-cookies.txt
>>> Loaded valid cookie -- no login required
>>> Attempting to create review request on perforce.example.com for None
>>> HTTP POSTing to
>>> http://vmreviews.qa-lab.sendmail.com/reviews/api/json/reviewrequests/new/:
>>> {'repository_path': 'perforce.smi.sendmail.com'}
>>> Got API Error 206 (HTTP code 200): The repository path specified is not in
>>> the list of known repositories
>>> Error data: {u'repository_path': u'perforce.example.com', u'stat': u'fail',
>>> u'err': {u'msg': u'The repository path specified is not in the list of
>>> known repositories', u'code': 206}, u'deprecated': {u'in_version': u'1.5'}}
There was an error creating this review request.
The repository path "repoman.example.com:1666" is not in the
list of known repositories on the server.
Ask the administrator to add this repository to the Review Board server.
For information on adding repositories, please read
http://www.reviewboard.org/docs/manual/dev/admin/management/repositories/
From: chip...@gmail.com [mailto:chip...@gmail.com] On Behalf Of Christian
Hammond
Sent: Wednesday, March 30, 2011 4:08 PM
To: Vincent Yee
Cc: reviewboard@googlegroups.com
Subject: Re: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or
more fields had errors
The repository entry you showed doesn't seem to have :1666? Try adding the port.
Christian
--
Christian Hammond - chip...@chipx86.com<mailto:chip...@chipx86.com>
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Mar 30, 2011 at 4:00 PM, Vincent Yee
mailto:v...@sendmail.com>> wrote:
On my client I have set
export P4PORT=perforce.example.com:1666<http://perforce.example.com:1666>
Ping perforce.example.com<http://perforce.example.com> works
PING repoman.example.com<http://repoman.example.com> (x.y.z.a) 56(84) bytes of
data.
64 bytes from repoman.example.com<http://repoman.example.com> (x.y.z.a):
icmp_seq=1 ttl=63 time=0.504 ms
64 bytes from repoman.example.com<http://repoman.example.com> (x.y.z.a):
icmp_seq=2 ttl=63 time=0.335 ms
$ telnet perforce.example.com<http://perforce.example.com> 1666
Trying x.y.z.a...
Connected to perforce.example.com<http://perforce.example.com> (x.y.z.a).
Escape character is '^]'.
;;xfiles5server3server217funprotocol^]
telnet>
From: chip...@gmail.com<mailto:chip...@gmail.com>
[mailto:chip...@gmail.com<mailto:chip...@gmail.com>] On Behalf Of Christian
Hammond
Sent: Wednesday, March 30, 2011 3:41 PM
To: reviewboard@googlegroups.com<mailto:reviewboard@googlegroups.com>
Cc: Vincent Yee
Subject: Re: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or
more fields had errors
Sounds like the Review Board server isn't able to contact your Perforce server
for some reason. Might want to try SSHing into that server, temporarily setting
P4PORT in your session, and accessing the server. Or try pinging it for an
initial test.
Christian
--
Christian Hammond - chip...@chipx86.com<mailto:chip...@chipx86.com>
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Mar 30, 2011 at 3:36 PM, storms
mailto:v...@sendmail.com>> wrote:
trying to setup post-review with perforce got the following error.
I am able to ping and telnet to the perforc
RE: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or more fields had errors
Ok now it's a different error with
Mirror path: perforce.example.com:1666
>>> HTTP POSTing to
>>> http://vmreviews.lab-example.com/reviews/api/json/reviewrequests/20/draft/set/:
>>> {'summary': 'p4-testing-change'}
>>> Uploading diff, size: 361
>>> HTTP POSTing to
>>> http://vmreviews.qa-lab.sendmail.com/reviews/api/json/reviewrequests/20/diff/new/:
>>> {}
>>> Got API Error 105 (HTTP code 200): One or more fields had errors
>>> Error data: {u'fields': {u'path': [u'[Errno 2] No such file or
>>> directory']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had
>>> errors', u'code': 105}, u'deprecated': {u'in_version': u'1.5'}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
[build@vmtemp01 Product]$
If putting jsut :1666 in Mirror path,
It returns the original error:
>>> Error data: {u'fields': {u'path': [u'[P4.connect()] Connect to server
>>> failed; check $P4PORT.\nTCP connect to :1666 failed.\nconnect: :1666:
>>> Connection refused\n']}, u'stat': u'fail', u'err': {u'msg': u'One or more
>>> fields had errors', u'code': 105}, u'deprecated': {u'in_version': u'1.5'}}
From: chip...@gmail.com [mailto:chip...@gmail.com] On Behalf Of Christian
Hammond
Sent: Wednesday, March 30, 2011 4:23 PM
To: Vincent Yee
Cc: reviewboard@googlegroups.com
Subject: Re: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or
more fields had errors
Try putting the :1666 one in Mirror Path.
Christian
--
Christian Hammond - chip...@chipx86.com<mailto:chip...@chipx86.com>
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Mar 30, 2011 at 4:19 PM, Vincent Yee
mailto:v...@sendmail.com>> wrote:
I get a different error message if I have :1666 on my repository entry (Got API
Error 206 (HTTP code 200)
$ post-review --debug --summary=p4-testing-change
>>> RBTools 0.3.2
>>> Home = /home/build
>>> svn info
>>> p4 info
>>> repository info: Path:
>>> repoman.smi.sendmail.com:1666<http://repoman.smi.sendmail.com:1666>, Base
>>> path: None, Supports changesets: True
>>> HTTP GETting api/
>>> HTTP GETting http://vmreviews.lab-example.com/reviews/api/info/
>>> Using the new web API
>>> Generating diff for changenum default
>>> p4 opened -c default
>>> Processing edit of //depot/Iocaine/main/Product/build.xml
>>> Writing "//depot/Iocaine/main/Product/build.xml#197" to "/tmp/tmpIdYR5a"
>>> p4 print -o /tmp/tmpIdYR5a -q //depot/Iocaine/main/Product/build.xml#197
>>> diff -urNp /tmp/tmpIdYR5a
>>> /home/build/build_client/Iocaine/main/Product/build.xml
>>> Using changenums on Review Board 1.5.2. Falling back to the deprecated 1.0
>>> API
==> Review Board Login Required
Enter username and password for Review Board at
http://vmreviews.lab-example.com/reviews/
>>> Looking for
>>> 'vmreviews.qa-lab.sendmail.com<http://vmreviews.qa-lab.sendmail.com>
>>> /reviews/' cookie in /home/build/.post-review-cookies.txt
>>> Loaded valid cookie -- no login required
>>> Attempting to create review request on
>>> perforce.example.com<http://perforce.example.com> for None
>>> HTTP POSTing to
>>> http://vmreviews.qa-lab.sendmail.com/reviews/api/json/reviewrequests/new/:
>>> {'repository_path':
>>> 'perforce.smi.sendmail.com<http://perforce.smi.sendmail.com>'}
>>> Got API Error 206 (HTTP code 200): The repository path specified is not in
>>> the list of known repositories
>>> Error data: {u'repository_path':
>>> u'perforce.example.com<http://perforce.example.com>', u'stat': u'fail',
>>> u'err': {u'msg': u'The repository path specified is not in the list of
>>> known repositories', u'code': 206}, u'deprecated': {u'in_version': u'1.5'}}
There was an error creating this review request.
The repository path "repoman.example.com:1666<http://repoman.example.com:1666>"
is not in the
list of known repositories on the server.
Ask the adm
RE: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or more fields had errors
That's the trick... in /usr/bin/
Thx
Vincent
-Original Message-
From: chip...@gmail.com [mailto:chip...@gmail.com] On Behalf Of Christian
Hammond
Sent: Wednesday, March 30, 2011 9:51 PM
To: Vincent Yee
Cc: Christian Hammond; reviewboard@googlegroups.com
Subject: Re: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or
more fields had errors
Hi,
They're both in /usr/local/bin, which is certainly in your user's
path, but is it in Apache's?
You may want to see what happens if you move those to /usr/bin.
Alternatively, you can SetEnv PATH in your web server's config.
Christian
On Wednesday, March 30, 2011, Vincent Yee wrote:
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> We do have p4 and patch on the client system:
>
>
>
> $ which p4
>
> /usr/local/bin/p4
>
> $ /usr/local/bin/p4 -V
>
> Perforce - The Fast Software Configuration Management System.
>
> Copyright 1995-2011 Perforce Software. All rights reserved.
>
> Rev. P4/LINUX26X86/2010.2/279478 (2011/01/03).
>
> [build@vmtemp01 ~]$ ls -al /usr/local/bin/p4
>
> -rwxr-xr-x 1 root root 777172 Mar 22 14:02 /usr/local/bin/p4
>
>
>
> $ which patch
>
> /usr/bin/patch
>
> $ /usr/bin/patch -v
>
> patch 2.5.4
>
> Copyright 1984-1988 Larry Wall
>
> Copyright 1989-1999 Free Software Foundation, Inc.
>
> $ ls -al /usr/bin/patch
>
> -rwxr-xr-x 1 root wheel 91476 Aug 11 2008 /usr/bin/patch
>
>
>
>
>
>
>
>
>
> From: chip...@gmail.com
> [mailto:chip...@gmail.com] On Behalf Of Christian Hammond
> Sent: Wednesday, March 30, 2011 5:19 PM
> To: Vincent Yee
> Cc: reviewboard@googlegroups.com
> Subject: Re: post-review w/ p4 error: Got API Error 105 (HTTP code 200):
> One or more fields had errors
>
>
>
>
>
> Okay, the "No such file or
> directory" indicates a configuration problem, but is a step in the right
> direction. Some program you need is missing, and Review Board's initial checks
> didn't catch it. Can you make sure that both p4 and patch are both available
> on
> that system and accessible/executable?
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
>
>
>
> On Wed, Mar 30, 2011 at 4:59 PM, Vincent Yee wrote:
>
>
>
>
>
> I tried
> with both in Mirror path:
>
> perforce.example:1666
> è
>>>> Error data: {u'fields': {u'path': [u'[Errno 2] No such file or
> directory']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had
> errors', u'code': 105}, u'deprecated': {u'in_version': u'1.5'}}
>
>
>
> :1666 è
>>>> Error data: {u'fields': {u'path': [u'[P4.connect()] Connect to
> server failed; check $P4PORT.\nTCP connect to :1666 failed.\nconnect: :1666:
> Connection refused\n']}, u'stat': u'fail', u'err': {u'msg': u'One or more
> fields had errors', u'code': 105}, u'deprecated': {u'in_version': u'1.5'}}
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> From: chip...@gmail.com [mailto:chip...@gmail.com] On
> Behalf Of Christian Hammond
> Sent: Wednesday, March 30, 2011 4:42 PM
>
>
>
>
>
>
> To: Vincent Yee
> Cc: reviewboard@googlegroups.com
> Subject: Re: post-review w/ p4 error: Got API Error 105 (HTTP code 200):
> One or more fields had errors
>
>
>
>
>
>
>
>
>
>
>
>
>
> The
> error message says you're just using :1666.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
>
> On
> Wed, Mar 30, 2011 at 4:38 PM, Vincent Yee wrote:
>
>
>
>
>
> Ok now
> it’s a different error with
>
> Mirror
> path: perforce.example.com:1666
>
>
>
>>>>
> HTTP POSTing to
> http://vmreviews.lab-example.com/reviews/api/json/reviewrequests/20/draft/set/:
> {'summary': 'p4-testing-change'}
>
>>>>
> Uploading diff, size: 361
>
>
>
>
>
>
>
--
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
RE: Realized web-based post-commit reviews
Good work! How about CVS? From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Martin Sent: Thursday, April 07, 2011 11:53 AM To: reviewboard@googlegroups.com Subject: Re: Realized web-based post-commit reviews Congratulations, I saw you customization and is great. Do you know if there is something like that for git? Thanks in advance. Martin. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Error uploading diff
Hi,
I am getting the following errors when I try to upload a file using
post-review.
>>> Got API Error 210 (HTTP code 200): There was an error fetching extended
>>> information for this repository.
>>> Error data: {'deprecated': {'in_version': '1.5'}, 'stat': 'fail', 'err':
>>> {'msg': 'There was an error fetching extended information for this
>>> repository.', 'code': 210}}
>>> HTTP GETting api/json/repositories/3/info/
>>> Got API Error 210 (HTTP code 200): There was an error fetching extended
>>> information for this repository.
>>> Error data: {'deprecated': {'in_version': '1.5'}, 'stat': 'fail', 'err':
>>> {'msg': 'There was an error fetching extended information for this
>>> repository.', 'code': 210}}
>>> HTTP GETting api/json/repositories/4/info/
>>> Attempting to create review request on https://repository/option for None
>>> HTTP POSTing to http://truncated/option/api/json/reviewrequests/new/:
>>> {'repository_path': 'https://truncated.com/option'}
>>> Review request created
>>> Attempting to set field 'summary' to 'review board test' for review request
>>> '408'
>>> HTTP POSTing to http://truncated/api/json/reviewrequests/408/draft/set/:
>>> {'summary': 'review board test'}
>>> Attempting to set field 'description' to 'REVIEW BOARD TEST' for review
>>> request '408'
>>> HTTP POSTing to http://truncated/api/json/reviewrequests/408/draft/set/:
>>> {'description': 'REVIEW BOARD TEST'}
>>> Uploading diff, size: 421
>>> HTTP POSTing to http://truncating/api/json/reviewrequests/408/diff/new/:
>>> {'basedir': '/operations/puppet'}
>>> Got API Error 105 (HTTP code 200): One or more fields had errors
>>> Error data: {'fields': {'path': ["Server sent unexpected return value (500
>>> Internal Server Error) in response to OPTIONS request for
>>> 'https://truncated/opt/operations/puppet/USE_SVN_README'"]}, 'stat':
>>> 'fail', 'err': {'msg': 'One or more fields had errors', 'code': 105},
>>> 'deprecated': {'in_version': '1.5'}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
RB is 1.5, and rbtools are 0.3.2 .
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Error uploading diff
Hi,
Thanks for getting back to me Christian. I tried svn diff and svn diff works
fine. . The diff was also able to be generated locally. Any other ideas?
On Tue, May 10, 2011 at 6:22 PM, Christian Hammond wrote:
> What type of repository are you using? I assume Subversion?
>
> It looks like there are two things going wrong. The first is that Review
> Board's having some sort of trouble fetching server information from your
> repository. The second is that locally, it's been unable to generate a diff.
>
> So assuming Subversion, what happens if you run "svn diff" on your
> checkout?
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Tue, May 10, 2011 at 5:49 PM, Thomas Vincent wrote:
>
>> Hi,
>> I am getting the following errors when I try to upload a file using
>> post-review.
>> >>> Got API Error 210 (HTTP code 200): There was an error fetching
>> extended information for this repository.
>> >>> Error data: {'deprecated': {'in_version': '1.5'}, 'stat': 'fail',
>> 'err': {'msg': 'There was an error fetching extended information for this
>> repository.', 'code': 210}}
>> >>> HTTP GETting api/json/repositories/3/info/
>> >>> Got API Error 210 (HTTP code 200): There was an error fetching
>> extended information for this repository.
>> >>> Error data: {'deprecated': {'in_version': '1.5'}, 'stat': 'fail',
>> 'err': {'msg': 'There was an error fetching extended information for this
>> repository.', 'code': 210}}
>> >>> HTTP GETting api/json/repositories/4/info/
>> >>> Attempting to create review request on https://repository/option for
>> None
>> >>> HTTP POSTing to http://truncated/option/api/json/reviewrequests/new/:
>> {'repository_path': 'https://truncated.com/option'}
>> >>> Review request created
>> >>> Attempting to set field 'summary' to 'review board test' for review
>> request '408'
>> >>> HTTP POSTing to
>> http://truncated/api/json/reviewrequests/408/draft/set/: {'summary':
>> 'review board test'}
>> >>> Attempting to set field 'description' to 'REVIEW BOARD TEST' for
>> review request '408'
>> >>> HTTP POSTing to
>> http://truncated/api/json/reviewrequests/408/draft/set/: {'description':
>> 'REVIEW BOARD TEST'}
>> >>> Uploading diff, size: 421
>> >>> HTTP POSTing to
>> http://truncating/api/json/reviewrequests/408/diff/new/: {'basedir':
>> '/operations/puppet'}
>> >>> Got API Error 105 (HTTP code 200): One or more fields had errors
>> >>> Error data: {'fields': {'path': ["Server sent unexpected return value
>> (500 Internal Server Error) in response to OPTIONS request for '
>> https://truncated/opt/operations/puppet/USE_SVN_README'"]}, 'stat':
>> 'fail', 'err': {'msg': 'One or more fields had errors', 'code': 105},
>> 'deprecated': {'in_version': '1.5'}}
>>
>> Error uploading diff
>>
>> The generated diff file was empty. This usually means no files were
>> modified in this change.
>>
>> Try running with --output-diff and --debug for more information.
>>
>> Your review request still exists, but the diff is not attached.
>>
>> RB is 1.5, and rbtools are 0.3.2 .
>>
>> --
>> Want to help the Review Board project? Donate today at
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to
>> reviewboard+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/reviewboard?hl=en
>
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Error uploading diff
I changed the site setting from http to https. Now I get:
[13:07:36 tvincent@SERVER02:~/puppet]$ post-review -pd --
summary="review board test" --description="REVIEW BOARD TEST"
USE_SVN_README --username=tvincent
>>> RBTools 0.3.2
>>> Home = /home/tvincent
>>> svn info
>>> diff --version
>>> repository info: Path: https://SERVER01.truncated.com/opt, Base path:
>>> /operations/puppet, Supports changesets: False
>>> HTTP GETting api/
==> HTTP Authentication Required
Enter authorization information for "Web API" at
reviewboard.truncated.com
Password:
>>> HTTP GETting http://reviewboard.truncated.com/api/info/
>>> Using the deprecated Review Board 1.0 web API
>>> svn diff --diff-cmd=diff USE_SVN_README
>>> svn info USE_SVN_README
>>> svn info USE_SVN_README
>>> svn info USE_SVN_README
>>> svn info USE_SVN_README
==> Review Board Login Required
Enter username and password for Review Board at
http://reviewboard.truncated.com/
Password:
>>> Logging in with username "tvincent"
>>> HTTP POSTing to http://reviewboard.truncated.com/api/json/accounts/login/:
>>> {'username': 'tvincent', 'password': '**'}
Traceback (most recent call last):
File "/usr/bin/post-review", line 7, in ?
sys.exit(
File "/usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py", line 3790, in main
File "/usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py", line 488, in login
File "/usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py", line 982, in api_post
File "/usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py", line 903, in http_post
File "/usr/lib64/python2.4/urllib2.py", line 130, in urlopen
return _opener.open(url, data)
File "/usr/lib64/python2.4/urllib2.py", line 364, in open
response = meth(req, response)
File "/usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py", line 317, in http_response
File "/usr/lib64/python2.4/urllib2.py", line 396, in error
result = self._call_chain(*args)
File "/usr/lib64/python2.4/urllib2.py", line 337, in _call_chain
result = func(*args)
File "/usr/lib64/python2.4/urllib2.py", line 741, in http_error_401
host, req, headers)
File "/usr/lib64/python2.4/urllib2.py", line 720, in
http_error_auth_reqed
return self.retry_http_basic_auth(host, req, realm)
File "/usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py", line 339, in retry_http_basic_auth
File "/usr/lib64/python2.4/urllib2.py", line 730, in
retry_http_basic_auth
return self.parent.open(req)
File "/usr/lib64/python2.4/urllib2.py", line 364, in open
response = meth(req, response)
File "/usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py", line 317, in http_response
File "/usr/lib64/python2.4/urllib2.py", line 396, in error
result = self._call_chain(*args)
File "/usr/lib64/python2.4/urllib2.py", line 337, in _call_chain
result = func(*args)
File "/usr/lib64/python2.4/urllib2.py", line 916, in http_error_401
host, req, headers)
File "/usr/lib64/python2.4/urllib2.py", line 807, in
http_error_auth_reqed
raise ValueError("AbstractDigestAuthHandler doesn't know "
ValueError: AbstractDigestAuthHandler doesn't know about Basic
On May 10, 6:22 pm, Christian Hammond wrote:
> What type of repository are you using? I assume Subversion?
>
> It looks like there are two things going wrong. The first is that Review
> Board's having some sort of trouble fetching server information from your
> repository. The second is that locally, it's been unable to generate a diff.
>
> So assuming Subversion, what happens if you run "svn diff" on your checkout?
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
> On Tue, May 10, 2011 at 5:49 PM, Thomas Vincent wrote:
>
>
>
>
>
>
>
> > Hi,
> > I am getting the following errors when I try to upload a file using
> > post-review.
> > >>> Got API Error 210 (HTTP code 200): There was an error fetching extended
> > information for this repository.
> > >>> Error data: {'deprecated': {'in_version': '1.5'}, 'stat': 'fail',
> > 'err': {'msg': 'There was an error fetching extended info
Re: Error uploading diff
Hi,
I upgraded to version 1.5.5 and I am running mod_python with Python 2.6.
Only asks me for my password once now.
Less errors, but still a error:
post-review -pd --summary="review board test" --description="REVIEW BOARD
TEST" USE_SVN_README --username=tvincent
>>> RBTools 0.3.2
>>> Home = /home/tvincent
>>> svn info
>>> diff --version
>>> repository info: Path: https://SERVER01.truncated.com/opt, Base path:
/operations/puppet, Supports changesets: False
>>> HTTP GETting api/
==> HTTP Authentication Required
Enter authorization information for "Web API" at SERVER02.truncated.com
Password:
>>> HTTP GETting http://SERVER02.truncated.com/api/info/
>>> Using the new web API
>>> svn diff --diff-cmd=diff USE_SVN_README
>>> svn info USE_SVN_README
>>> svn info USE_SVN_README
>>> svn info USE_SVN_README
>>> svn info USE_SVN_README
>>> HTTP GETting http://SERVER02.truncated.com/api/repositories/
>>> HTTP GETting http://SERVER02.truncated.com/api/repositories/2/
>>> HTTP GETting http://SERVER02.truncated.com/api/repositories/2/info/
>>> Got API Error 210 (HTTP code 500): There was an error fetching extended
information for this repository
>>> Error data: {'stat': 'fail', 'err': {'msg': 'There was an error fetching
extended information for this repository', 'code': 210}}
>>> HTTP GETting http://SERVER02.truncated.com/api/repositories/3/
>>> HTTP GETting http://SERVER02.truncated.com/api/repositories/3/info/
>>> Got API Error 210 (HTTP code 500): There was an error fetching extended
information for this repository
>>> Error data: {'stat': 'fail', 'err': {'msg': 'There was an error fetching
extended information for this repository', 'code': 210}}
>>> HTTP GETting http://SERVER02.truncated.com/api/repositories/4/
>>> HTTP GETting http://SERVER02.truncated.com/api/repositories/4/info/
>>> Attempting to create review request on
https://SERVER01.truncated.com/opt for None
>>> HTTP POSTing to http://SERVER02.truncated.com/api/review-requests/:
{'repository': 'https://SERVER01.truncated.com/opt'}
>>> Review request created
>>> Attempting to set field 'summary' to 'review board test' for review
request '414'
>>> HTTP PUTting to
http://SERVER02.truncated.com/api/review-requests/414/draft/: {'summary':
'review board test'}
>>> Attempting to set field 'description' to 'REVIEW BOARD TEST' for review
request '414'
>>> HTTP PUTting to
http://SERVER02.truncated.com/api/review-requests/414/draft/:
{'description': 'REVIEW BOARD TEST'}
>>> Uploading diff, size: 421
>>> HTTP POSTing to
http://SERVER02.truncated.com/api/review-requests/414/diffs/: {'basedir':
'/operations/puppet'}
>>> Got API Error 105 (HTTP code 400): One or more fields had errors
>>> Error data: {'fields': {'path': ["Server sent unexpected return value
(500 Internal Server Error) in response to OPTIONS request for '
https://SERVER01.truncated.com/opt/operations/puppet/USE_SVN_README'"]},
'stat': 'fail', 'err': {'msg': 'One or more fields had errors', 'code':
105}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
On Wed, May 11, 2011 at 12:28 PM, Christian Hammond wrote:
> You're running exactly 1.5? Try upgrading. There are a lot of API issues in
> 1.5, which I want to rule out first.
>
> Also, are you using mod_python, or something else?
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Wed, May 11, 2011 at 11:10 AM, Thomas Vincent wrote:
>
>> I changed the site setting from http to https. Now I get:
>> [13:07:36 tvincent@SERVER02:~/puppet]$ post-review -pd --
>> summary="review board test" --description="REVIEW BOARD TEST"
>> USE_SVN_README --username=tvincent
>> >>> RBTools 0.3.2
>> >>> Home = /home/tvincent
>> >>> svn info
>> >>> diff --version
>> >>> repository info: Path: https://SERVER01.truncated.com/opt, Base path:
>> /operations/puppet, Supports changesets: False
>> >>> H
Re: Error uploading diff
Hi Chris,
I posted the logs at http://pastebin.com/aB4a8iMr . I see the errors that
indicate something wrong. But I can't reproduce the problem at the command
line. Thanks in advance.
On Wed, May 11, 2011 at 3:25 PM, Christian Hammond wrote:
> It still looks like Review Board is having a problem accessing your
> Subversion repository. It's failing in some way. Might want to check the
> Review Board log file to see if anything is coming up, and attempt a 'svn
> info' on the repository path from the Review Board server.
>
> It could be some issue with your PySVN install, too.
>
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Wed, May 11, 2011 at 3:23 PM, Thomas Vincent wrote:
>
>> Hi,
>> I upgraded to version 1.5.5 and I am running mod_python with Python 2.6.
>> Only asks me for my password once now.
>>
>> Less errors, but still a error:
>>
>> post-review -pd --summary="review board test" --description="REVIEW BOARD
>> TEST" USE_SVN_README --username=tvincent
>> >>> RBTools 0.3.2
>> >>> Home = /home/tvincent
>> >>> svn info
>> >>> diff --version
>> >>> repository info: Path: https://SERVER01.truncated.com/opt, Base path:
>> /operations/puppet, Supports changesets: False
>> >>> HTTP GETting api/
>> ==> HTTP Authentication Required
>> Enter authorization information for "Web API" at SERVER02.truncated.com
>> Password:
>> >>> HTTP GETting http://SERVER02.truncated.com/api/info/
>> >>> Using the new web API
>>
>> >>> svn diff --diff-cmd=diff USE_SVN_README
>> >>> svn info USE_SVN_README
>> >>> svn info USE_SVN_README
>> >>> svn info USE_SVN_README
>> >>> svn info USE_SVN_README
>> >>> HTTP GETting http://SERVER02.truncated.com/api/repositories/
>> >>> HTTP GETting http://SERVER02.truncated.com/api/repositories/2/
>> >>> HTTP GETting http://SERVER02.truncated.com/api/repositories/2/info/
>>
>> >>> Got API Error 210 (HTTP code 500): There was an error fetching
>> extended information for this repository
>> >>> Error data: {'stat': 'fail', 'err': {'msg': 'There was an error
>> fetching extended information for this repository', 'code': 210}}
>> >>> HTTP GETting http://SERVER02.truncated.com/api/repositories/3/
>> >>> HTTP GETting http://SERVER02.truncated.com/api/repositories/3/info/
>>
>> >>> Got API Error 210 (HTTP code 500): There was an error fetching
>> extended information for this repository
>> >>> Error data: {'stat': 'fail', 'err': {'msg': 'There was an error
>> fetching extended information for this repository', 'code': 210}}
>> >>> HTTP GETting http://SERVER02.truncated.com/api/repositories/4/
>> >>> HTTP GETting http://SERVER02.truncated.com/api/repositories/4/info/
>> >>> Attempting to create review request on
>> https://SERVER01.truncated.com/opt for None
>> >>> HTTP POSTing to http://SERVER02.truncated.com/api/review-requests/:
>> {'repository': 'https://SERVER01.truncated.com/opt'}
>> >>> Review request created
>> >>> Attempting to set field 'summary' to 'review board test' for review
>> request '414'
>> >>> HTTP PUTting to
>> http://SERVER02.truncated.com/api/review-requests/414/draft/: {'summary':
>> 'review board test'}
>> >>> Attempting to set field 'description' to 'REVIEW BOARD TEST' for
>> review request '414'
>> >>> HTTP PUTting to
>> http://SERVER02.truncated.com/api/review-requests/414/draft/:
>> {'description': 'REVIEW BOARD TEST'}
>> >>> Uploading diff, size: 421
>> >>> HTTP POSTing to
>> http://SERVER02.truncated.com/api/review-requests/414/diffs/: {'basedir':
>> '/operations/puppet'}
>>
>> >>> Got API Error 105 (HTTP code 400): One or more fields had errors
>> >>> Error data: {'fields': {'path': ["Server sent unexpected return value
>> (500 Internal Server Error) in response to OPTIONS request for '
>> https://SERVER01.truncated.com/opt/operations/puppet/USE_SVN_README'&quo
Re: Error uploading diff
Hi Chris,
It turns out the repository credentials that review board was using was a
former employees whose account was deleted. Thanks for your help.
Thomas
On Wed, May 11, 2011 at 3:39 PM, Thomas Vincent wrote:
> Hi Chris,
> I posted the logs at http://pastebin.com/aB4a8iMr . I see the errors that
> indicate something wrong. But I can't reproduce the problem at the command
> line. Thanks in advance.
>
> On Wed, May 11, 2011 at 3:25 PM, Christian Hammond wrote:
>
>> It still looks like Review Board is having a problem accessing your
>> Subversion repository. It's failing in some way. Might want to check the
>> Review Board log file to see if anything is coming up, and attempt a 'svn
>> info' on the repository path from the Review Board server.
>>
>> It could be some issue with your PySVN install, too.
>>
>>
>> Christian
>>
>> --
>> Christian Hammond - chip...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> VMware, Inc. - http://www.vmware.com
>>
>>
>> On Wed, May 11, 2011 at 3:23 PM, Thomas Vincent wrote:
>>
>>> Hi,
>>> I upgraded to version 1.5.5 and I am running mod_python with Python 2.6.
>>> Only asks me for my password once now.
>>>
>>> Less errors, but still a error:
>>>
>>> post-review -pd --summary="review board test" --description="REVIEW
>>> BOARD TEST" USE_SVN_README --username=tvincent
>>> >>> RBTools 0.3.2
>>> >>> Home = /home/tvincent
>>> >>> svn info
>>> >>> diff --version
>>> >>> repository info: Path: https://SERVER01.truncated.com/opt, Base
>>> path: /operations/puppet, Supports changesets: False
>>> >>> HTTP GETting api/
>>> ==> HTTP Authentication Required
>>> Enter authorization information for "Web API" at SERVER02.truncated.com
>>> Password:
>>> >>> HTTP GETting http://SERVER02.truncated.com/api/info/
>>> >>> Using the new web API
>>>
>>> >>> svn diff --diff-cmd=diff USE_SVN_README
>>> >>> svn info USE_SVN_README
>>> >>> svn info USE_SVN_README
>>> >>> svn info USE_SVN_README
>>> >>> svn info USE_SVN_README
>>> >>> HTTP GETting http://SERVER02.truncated.com/api/repositories/
>>> >>> HTTP GETting http://SERVER02.truncated.com/api/repositories/2/
>>> >>> HTTP GETting http://SERVER02.truncated.com/api/repositories/2/info/
>>>
>>> >>> Got API Error 210 (HTTP code 500): There was an error fetching
>>> extended information for this repository
>>> >>> Error data: {'stat': 'fail', 'err': {'msg': 'There was an error
>>> fetching extended information for this repository', 'code': 210}}
>>> >>> HTTP GETting http://SERVER02.truncated.com/api/repositories/3/
>>> >>> HTTP GETting http://SERVER02.truncated.com/api/repositories/3/info/
>>>
>>> >>> Got API Error 210 (HTTP code 500): There was an error fetching
>>> extended information for this repository
>>> >>> Error data: {'stat': 'fail', 'err': {'msg': 'There was an error
>>> fetching extended information for this repository', 'code': 210}}
>>> >>> HTTP GETting http://SERVER02.truncated.com/api/repositories/4/
>>> >>> HTTP GETting http://SERVER02.truncated.com/api/repositories/4/info/
>>> >>> Attempting to create review request on
>>> https://SERVER01.truncated.com/opt for None
>>> >>> HTTP POSTing to http://SERVER02.truncated.com/api/review-requests/:
>>> {'repository': 'https://SERVER01.truncated.com/opt'}
>>> >>> Review request created
>>> >>> Attempting to set field 'summary' to 'review board test' for review
>>> request '414'
>>> >>> HTTP PUTting to
>>> http://SERVER02.truncated.com/api/review-requests/414/draft/:
>>> {'summary': 'review board test'}
>>> >>> Attempting to set field 'description' to 'REVIEW BOARD TEST' for
>>> review request '414'
>>> >>> HTTP PUTting to
>>> http://SERVER02.truncated.com/api/review-requests/414/draft/:
>>> {'description': 'REVIEW BOARD TEST'}
>>> >>> Uploading dif
DJblets _check_expired() issues
ticed that only one key is generated and cached for all extensions
(which are in the same extension manager).
When the *_check_expired*() returns True, ALL extensions will be reloaded.
So, if an another user of ReviewBoard at the same time is trying to display
a web page where the extension is used, is it not a problem ?
Because perhaps the extension is not yet full reloaded, which can create
perhaps the above errors.
Or is it an issue how i wrote the extensions ?
Below one of the extension i created:
*class MetricsExtension(Extension):...is_configurable = True
has_admin_site = True...def __init__(self, *args, **kwargs):
super(MetricsExtension, self).__init__(*args, **kwargs)
URLHook(self, patterns('',(r'^rbmetrics/',
include('rbmetrics.urls'TemplateHook(self,
"base-scripts-post",
"rbmetrics/metrics_init.html",
apply_to=['view_diff', 'review-request-detail'])*
Hope you understand my problem, because not very easy to explain and my
english is so poor ... ;-)
Regards,
Vincent G.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
DJblets _check_expired() issues
noticed that only one key is generated and cached for all extensions
(which are in the same extension manager).
When the _check_expired() returns True, ALL extensions will be reloaded.
So, if an another user of ReviewBoard at the same time is trying to display
a web page where the extension is used, is it not a problem ?
Because perhaps the extension is not yet full reloaded, which can create
perhaps the above errors.
Or is it an issue how i wrote the extensions ?
Below one of the extension i created:
class MetricsExtension(Extension):
...
is_configurable = True
has_admin_site = True
...
def __init__(self, *args, **kwargs):
super(MetricsExtension, self).__init__(*args, **kwargs)
URLHook(self, patterns('',
(r'^rbmetrics/', include('rbmetrics.urls'
TemplateHook(self, "base-scripts-post",
"rbmetrics/metrics_init.html",
apply_to=['view_diff',
'review-request-detail'])
Hope you understand my problem, because not very easy to explain and my
english is so poor ... ;-)
Regards,
Vincent G.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Which recommended Apache MPM to use with Reviewboard + extensions
Hi, I would like to know which Apache MPM is recommended to use with Reviewboard ? MPM Fork or MPM Worker ? Because i have some issues when i use Apache MPM worker with Reviewboard Extensions (read my other topic Djblets _isexpired() issues) in case of *wsgi.multithread = True* wsgi.multiprocess = True If wsgi.multithread is set to False (by using Apache MPM Fork example), no problem. Best regards, Vincent G. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: DJblets _check_expired() issues
I opened another topic: https://groups.google.com/forum/#!topic/reviewboard/kS23n4m5aNw These above issues seem to be caused by the Apache configuration i used (MPM worker instead of MPM fork). Le mardi 10 décembre 2013 17:18:46 UTC+1, Vincent G. a écrit : > > Hi, > > Before to explain the problem, below the configuration: > > ReviewBoard version: 1.7.6 > Django version: 1.4.5 > Djblets version: 0.7.11 > Apache used > Memcache used (version 1.48, python lib) > > I developed some extensions for Reviewboard which are using TemplateHook > and UrlHook, to add some HTML code on existing Reviewboard web pages. > > When i installed and enabled these extensions through administration web > page, and users use the Reviewboard, some errors as below have been > notified: > (even after restarting apache, memcache, and users have refresh their web > browser). > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > *Traceback (most recent call last): File > "/usr/local/lib/python2.7/dist-packages/Django-1.4.5-py2.7.egg/django/core/handlers/base.py", > > line 89, in get_responseresponse = middleware_method(request) File > "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/middleware.py", > > line 32, in process_requestself._check_expired() File > "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/middleware.py", > > line 50, in _check_expiredextension_manager.load(full_reload=True) > File > "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/base.py", > > line 453, in loadself._clear_extensions() File > "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/base.py", > > line 542, in _clear_extensionsself._uninit_extension(extension) File > "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/base.py", > > line 595, in _uninit_extensionextension.shutdown() File > "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/base.py", > > line 170, in shutdownhook.shutdown() File > "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/hooks.py", > > line 46, in shutdownsuper(URLHook, self).shutdown() File > "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/base.py", > > line 246, in shutdownself.__class__.remove_hook(self) File > "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/base.py", > > line 274, in remove_hookcls.hooks.remove(hook)ValueError: > list.remove(x): x not in list* > > or > > > > > > > > > > > > > > > > > > > > *Traceback (most recent call last): File > "/usr/local/lib/python2.7/dist-packages/Django-1.4.5-py2.7.egg/django/core/handlers/base.py", > > line 89, in get_responseresponse = middleware_method(request) File > "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/middleware.py", > > line 32, in process_requestself._check_expired() File > "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/middleware.py", > > line 50, in _check_expiredextension_manager.load(full_reload=True) > File > "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/base.py", > > line 511, in loadself._init_extension(ext_class) File > "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/base.py", > > line 580, in _init_extensionextension.info.installed = > extension.registration.installedAttributeError: 'MetricsExtension' object > has no attribute 'registration'* > > I tried to find the problem and it seems to come from a cache issue. > As i understood (please tell me if i well understood or not), for each > HTTP request, the Djblet middleware (located in middleware.py file) checks > if the extension manager is expired (_check_expired() method). > > In *djblets/extensions/middleware.py* file: > > > > > > > > > > *class ExtensionsMiddleware(object):...def process_request(self, > request):self._check_expired()def > _check_expired(self):...for extension_manager in > get_extension_managers():if > extension_manager.is_expired():
Re: Which recommended Apache MPM to use with Reviewboard + extensions
Hi Christian,
Thank you to answer so fast.
I would like to notify that the behavior of the Reviewboard, specially when
extensions are used is very 'strange' when Apache server is in MPM worker
mode instead of MPM Prefork.
When in MPM Worker, i noticed that the HTTP request are setup as:
wsgi.multithread : True and wsgi.multiprocess : True.
Ok. It's normal according to the mod_wsgi document ( read
http://code.google.com/p/modwsgi/wiki/ProcessesAndThreading )
The issues i found (described in the topic
https://groups.google.com/forum/#!topic/reviewboard/XL0E9Sb22w0 ) is we
have sometimes a lot of errors ('[Review Board] ERROR (EXTERNAL IP)'
emails) because some object does not exist for example. I tried to analyze
the problem and perhaps i found the cause of these issues.
When the wsgi.multithread is set as True (so for example when Apache MPM
Worker is used), the HTTP requests received by the Reviewboard middleware
(as for example, the djblet middleware which checks the expiration of the
extension manager) can be processed in parallel in each thread BUT also in
the same process. So, when an expiration is detected (by comparing key with
cache) the extension manager is reloaded (so means that ALL extensions have
been reloaded). The problem is that if an other HTTP request is processed
at the same time in other thread BUT in the same process (so normally
memory is shared between threads), this HTTP request can have some issues
because the loading of the extension is not finished. That's why, i think,
i received a lot of '[Review Board] ERROR (EXTERNAL IP)' errors. The
process_request() method of the ExtensionsMiddleware class (in djblet
package) seems to not include synchronization mechanism.
I din't check yet, if you updated the Djblet library (we used the 0.7.11
version, and Reviewboard 1.7.6), but i think it's very important to check
the Apache configuration and use the Apache Prefork MPM to avoid the issues
we encountered. Because in this case, the multithread mechanism is not used
(wsgi.multithread= False) or synchronization mechanism shall be included in
the process_request() of each middleware.
That's why i asked you the recommended Apache MPM to use with Reviewboard.
Don't worry about the other topic i created.
I can understand you have no time. A new released of Reviewboard has been
out recently.
We planned to upgrade our Reviewboard application, but i saw you have
changed some things, especially the extension functionality.
So i need to check if our extensions are always compatible.
Regards,
Vincent
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
