Re: Newbie to ReviewBoard
Hi Karthik, Clearcase is a bit different from other scms in Reviewboard. You really need to use the post-review script to submit a diff for review. I don't think there is much usage of Clearcase support, so it doesn't get thoroughly tested. As I posted in another message recently, we were able to get it up and running on Windows with Clearcase, with only a few minor modifications. Dan On Jul 9, 3:02 pm, Karthik karthikeyan1...@gmail.com wrote: Hello All- I was trying to find out Open Source Code review tools and I came across Review Board. I am only familiar with Rational Clearcase for source code management. That is the I have for usage. I have gone through the Review board website. I am not getting how it takes the code differences for the review. When I was trying to use the demo website, there it asks base file path and diff to choose a file. I don't understand what it needs to be gone here. I have following queries regarding my usage of Review Board, - How do I give files to see the differences for the review. - Does it support Rational Clearcase repository? if not, is there any way to tweak it? - Can I refer the review files directly from the repository in my case it is Clearcase? - How do I give multiple files differences in a single review? since it is always possible to have multiple files changes in a single review. Thanks in advance! Awaiting for the reply! Regards, Karthik --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review and Git branches
I use the diff upload form when I want to make a more complex diff. I added the current simple support for git just so something was available but it needs a lot more flexibility to really follow the distributed spirit. I think it might be better to take whatever git diff will take, so I can specify something like HEAD^ or HEAD~3..HEAD~1, etc. This would be just one argument. The 'new' and 'origin' arguments would work as well. Dan On Jul 8, 8:37 am, Petter Måhlén pettermah...@gmail.com wrote: Despite not being a Python programmer, I found out through looking at the code that there does seem to be a requirement that you compare against the master branch. I've been able to change that, so we should be able to proceed. The solution we preferred involves two arguments that we called 'new' and 'origin', which allows you to specify two Git commit-ishes to create a review request for. It would be interesting to hear if that seems like a sensible solution to those of you who have used this tool for a while? On Jul 8, 11:57 am, Petter Måhlén pettermah...@gmail.com wrote: Hi, I'm trying to figure out how to set up Review Board for usage within our organisation. We're using Git for SCM, so the Git support in RB is one of the things that made me want to take a closer look. However, I'm having some problems in understanding how to get going. It seems from the documentation as if the solution would be to use the post- review tool to get review requests into RB. The documentation indicates that a command like post-review --parent=somebranch should generate a diff between 'master' and that branch. However, for various reasons, we're not using branches named 'master'. This means that the command fails with a message like: Failed to execute command: ['git', 'diff', '--no-color', 'master'] fatal: ambiguous argument 'master': unknown revision or path not in the working tree. Is there some other way of using post-review to indicate the two revisions I want to diff and post a review for? Thanks, Petter --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: ClearCase and Reviewboard setup.
Yes, split_lines=True is what I needed to add to get it to work. I'm less sure about the other changes. They seem like they might be a problem with your version of python on Windows. I'll add comments to the review. Dan On Jul 10, 11:22 am, Bartlomiej Celary bartlomiej.cel...@gmail.com wrote: Hi Dan, We did have to modify one line of code in post-review to get it to run Could you check if those changes are not similar to mine (http://reviews.review-board.org/r/906/)?I know I had difficulties submitting a diff for a clearcase repo and those changes fixed it. I think that we should also make a hard-coded part configurable. Thanks, Bartek --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
