回复： What's the mean of "ship it!"?

[深圳手机(王)]

OK.
 thank you very much !
   -- 原始邮件 --
  发件人: "Stein, Ruben";
 发送时间: 2012年2月14日(星期二) 下午5:42
 收件人: "reviewboard@googlegroups.com"; 
 
 主题: Re: What's the mean of "ship it!"?

  
 Hi,
 

 as far as I know it is the latter. Since the default workflow design for 
ReviewBoard is to review the code before it is committed, clicking on "ship 
it!" means to tell the author: "Yes, I agree to your changes: Ship it!" At 
this, "to ship" has the meaning of sending or committing the suggested changes 
to the VCS.
 

 Regards, Ruben
 

 From: "深圳手机 (王)" <825772...@qq.com>
Reply-To: 
Date: Tue, 14 Feb 2012 17:33:18 +0800
To: reviewboard 
Subject: What's the mean of "ship it!"?

 

  What's the mean of "ship it!"? I am puzzled for this question for some time.
 Remind the people don't forget to review the code? or the reviewer accept the 
result?
  
 

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en 

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en 


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: 回复： What's the mean of "ship it!"?

[John Yates]

Ruben's description correctly captures the significance of "Ship it!"
in RB's workflow.  What he left out is that "Ship it!" also is often a
standing joke among English-speaking developers.  When a piece of code
finally passes some early threshold an observer / reviewer may say
"Ship it!".  It is an affirmation which suggests omitting further
testing and delivering the code in its current state.

/john

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en