2.0.1 and script timeouts in Firefox 29 displaying large Testing Done field
I have a review in RB 2.0.1 where someone pasted over 700 lines of console output into the 'Testing Done' field of a review. Internet Explorer and Chrome don't have a problem with it, but with Firefox 29 you have to click through 3 'script timeout' warnings before it will display. It's getting stuck running https://reviews/static/lib/js/3rdparty.min.787bbc6b4fd2.js:6. Is this something that can be fixed, or should I suggest people attach output like that as files instead? -- Bruce -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: 2.0.1 and script timeouts in Firefox 29 displaying large Testing Done field
Hi Bruce, This is *probably* due to an issue in marked.js, which is what we use for syntax-highlighting Markdown. All text goes through this (by the time it’s run, older review request text is just escaped, so that it’s valid Markdown). I’m planning to do a bunch of work to remove the need for marked.js, and just process this stuff server-side as-needed, but we’re not there yet. This will probably happen in a 2.0.x, but not the upcoming one. I would recommend that any testing log output be attached as a file anyway, even without this problem. Attached text files in 2.0 are reviewable, and it helps keep review requests a bit more readable, e-mails a bit smaller, and keeps the database size down. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 9, 2014 at 9:13:34 AM, Bruce Cran (bruce.c...@gmail.com) wrote: I have a review in RB 2.0.1 where someone pasted over 700 lines of console output into the 'Testing Done' field of a review. Internet Explorer and Chrome don't have a problem with it, but with Firefox 29 you have to click through 3 'script timeout' warnings before it will display. It's getting stuck running https://reviews/static/lib/js/3rdparty.min.787bbc6b4fd2.js:6. Is this something that can be fixed, or should I suggest people attach output like that as files instead? -- Bruce -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: 2.0.1 and script timeouts in Firefox 29 displaying large Testing Done field
If there’s any way you can get me an exact copy of some text that’s breaking things (as a file attachment), I’ll be able to confirm this, and also test the newer releases of marked.js with it. That could help it get fixed sooner. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 9, 2014 at 12:43:10 PM, Christian Hammond (christ...@beanbaginc.com) wrote: Hi Bruce, This is *probably* due to an issue in marked.js, which is what we use for syntax-highlighting Markdown. All text goes through this (by the time it’s run, older review request text is just escaped, so that it’s valid Markdown). I’m planning to do a bunch of work to remove the need for marked.js, and just process this stuff server-side as-needed, but we’re not there yet. This will probably happen in a 2.0.x, but not the upcoming one. I would recommend that any testing log output be attached as a file anyway, even without this problem. Attached text files in 2.0 are reviewable, and it helps keep review requests a bit more readable, e-mails a bit smaller, and keeps the database size down. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 9, 2014 at 9:13:34 AM, Bruce Cran (bruce.c...@gmail.com) wrote: I have a review in RB 2.0.1 where someone pasted over 700 lines of console output into the 'Testing Done' field of a review. Internet Explorer and Chrome don't have a problem with it, but with Firefox 29 you have to click through 3 'script timeout' warnings before it will display. It's getting stuck running https://reviews/static/lib/js/3rdparty.min.787bbc6b4fd2.js:6. Is this something that can be fixed, or should I suggest people attach output like that as files instead? -- Bruce -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: 2.0.1 and script timeouts in Firefox 29 displaying large Testing Done field
Sorry, I won't be able to provide it since it contains internal data (usernames etc.). -- Bruce On Mon, Jun 9, 2014 at 1:47 PM, Christian Hammond christ...@beanbaginc.com wrote: If there’s any way you can get me an exact copy of some text that’s breaking things (as a file attachment), I’ll be able to confirm this, and also test the newer releases of marked.js with it. That could help it get fixed sooner. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.