Re: Automated merge after review && continuous integration

[Raja]

Hi All,
I managed to do something similar to #2 in the original request, which is
allow Reviewboard to be able to run certain commands on a build/test node
after a patch is uploaded. This is done as a reviewboard extension along
with a ReviewBot plugin that does the actual command execution after the
SCM operation and patches are applied.

I dont have this available publicly yet even though the basic setup works,
but I wanted to get some feedback on what will be helpful as a generic
extension. I also posted a video (Sorry about the poor video quality) at
http://www.youtube.com/watch?v=GYWeXUTeU3A that outlines the entire flow.

How this works:
Once this extension is installed, you can configure your repositories by
specifying the node on which your build/test commands should be run. On top
of that, you could upload some files that will be copied after the checkout
and patch are applied. These are typically property files that contain
per-developer information and not checked into any repository. You can copy
any number of files to the target node. After this, you specify the
commands that need to be run on the build/test node. There can be many
command sets (each command set runs on a particular directory and the
directory is configurable). You can add/delete command sets using the UI.
For e.g. you might want to update your codebase by running a composer
update (for php), bundle install etc. and then run other commands in a
different directory. Once all this configured, any patches that are posted
against that repository will be run on the configured node and the output
of those commands are posted back to Reviewboard as review comment.

Features:
* Support SVN And GitHub Public repositories
* No need for specialized software on the Client. This uses Ansible, so
just SSH needs to work between the reviewbot node and configured node.
* Ability to copy files after the checkout/patch is completed
* Ability to run any commands after checkout/patch is completed
* Output (Success/Failure) posted to Reviewboard as a comment.

Todo:
* PubKey authentication between the 2 nodes.
* PubKey auth support for SCMs to checkout in the build/test node
* Markdown support in the Review comment. I started this on Reviewboard 2.0
but since Reviewbot dint work on that, I downgraded to 1.7 and 1.7 doesnt
support Markdown.
* Store the output somewhere else (maybe as part of extension) and only
show them when requested rather than dump them as a review comment.
Sometimes the output is too big and may not be very useful

I used the ReviewBot plugin to get the notification from Reviewboard on
updating a patch and Ansible for calling into the remote node. Thanks a lot
to the reviewboard and reviewbot developers -- the extension mechanism just
rocks!

Any feedback is greatly appreciated. I will setup this entire thing on a
openshift node (one for the server and one for the target node) this
weekend so you can play with it.

Regards
Raja



On Thu, Nov 7, 2013 at 4:31 PM, Venkateswara Reddy
wrote:

> even i am looking for this, let me know if some one did it.
> Vreddy
>
> On Friday, September 20, 2013 9:30:05 PM UTC+5:30, David Trowbridge wrote:
>
>> There have been no changes to this as yet. We'd like to address this
>> eventually but it's a very difficult thing to address in a generic way, and
>> for the time being we have other priorities.
>>
>> -David
>>
>>
>> On Fri, Sep 20, 2013 at 4:32 AM, Luboš Račanský wrote:
>>
>>> I have the same question. Is there any way how to merge (from
>>> ReviewBoard) after acceptance of review?
>>>
>>>
>>> On Friday, May 3, 2013 11:05:07 PM UTC+2, mamta.n...@gmail.com wrote:

 Hey David,
 This is an older post but i"m actually looking for exactly these things
 currently and was wondering if these features have been built into
 reviewboard now  / via plugins or are they still in pipeline?

 Thanks,
 M

 On Wednesday, April 20, 2011 3:34:59 PM UTC-7, David Trowbridge wrote:
>
> #2 would be great; I know a lot of people have requested the ability
> to have some indication that the patch submitted will (a) apply cleanly 
> and
> (b) build (maybe even including automated testing).
>
> #1 is often requested, but it's something which we've been wary of
> because of the complexities of user authentication, audit chains, and the
> abilities it would introduce to break things. It would be a cool feature,
> but I think we'd need to approach it carefully.
>
> -David
>
>
> On Thu, Apr 14, 2011 at 10:19 AM, Jan Koprowski 
> wrote:
>
>> Hi,
>>
>> Recently i look at Gerrit - review tool dedicated for git guys. Two
>> things bring my attention:
>>
>> 1) Gerrit try to merge code automatically after review. This is great
>> ability. As far I'm aware when merge won't end with success developer get
>> message to rebase their code and send to review again. It will be cool to
>> get 

Re: Automated merge after review && continuous integration

[David Trowbridge]

As I said before, this is a very large project and we're currently quite
busy with other things. Until you read about it in the release notes, it
hasn't happened.

-David



On Mon, Nov 25, 2013 at 3:45 AM, Venkateswara Reddy
wrote:

> any updates on this
>
>
> On Thursday, November 7, 2013 4:31:19 PM UTC+5:30, Venkateswara Reddy
> wrote:
>>
>> even i am looking for this, let me know if some one did it.
>> Vreddy
>>
>> On Friday, September 20, 2013 9:30:05 PM UTC+5:30, David Trowbridge wrote:
>>
>>> There have been no changes to this as yet. We'd like to address this
>>> eventually but it's a very difficult thing to address in a generic way, and
>>> for the time being we have other priorities.
>>>
>>>  -David
>>>
>>>
>>> On Fri, Sep 20, 2013 at 4:32 AM, Luboš Račanský wrote:
>>>
 I have the same question. Is there any way how to merge (from
 ReviewBoard) after acceptance of review?


 On Friday, May 3, 2013 11:05:07 PM UTC+2, mamta.n...@gmail.com wrote:
>
> Hey David,
> This is an older post but i"m actually looking for exactly these
> things currently and was wondering if these features have been built into
> reviewboard now  / via plugins or are they still in pipeline?
>
> Thanks,
> M
>
> On Wednesday, April 20, 2011 3:34:59 PM UTC-7, David Trowbridge wrote:
>>
>> #2 would be great; I know a lot of people have requested the ability
>> to have some indication that the patch submitted will (a) apply cleanly 
>> and
>> (b) build (maybe even including automated testing).
>>
>> #1 is often requested, but it's something which we've been wary of
>> because of the complexities of user authentication, audit chains, and the
>> abilities it would introduce to break things. It would be a cool feature,
>> but I think we'd need to approach it carefully.
>>
>> -David
>>
>>
>> On Thu, Apr 14, 2011 at 10:19 AM, Jan Koprowski 
>> wrote:
>>
>>> Hi,
>>>
>>> Recently i look at Gerrit - review tool dedicated for git guys. Two
>>> things bring my attention:
>>>
>>> 1) Gerrit try to merge code automatically after review. This is
>>> great ability. As far I'm aware when merge won't end with success 
>>> developer
>>> get message to rebase their code and send to review again. It will be 
>>> cool
>>> to get something similar at reviewboard. I think this approach will for 
>>> for
>>> Git and probably for Mercurial too.
>>>
>>> 2) Build system integration. I saw Hudson & Gerrit integration which
>>> assume additional field for build system which check is project build 
>>> with
>>> new versions or not. It is well  exposed at
>>> http://source.android.com/source/life-of-a-patch.html. Will be
>>> something nice to make accessible some by API "checkbox field" for build
>>> system and approach such workflow in reviewboard - optional ofcourse.
>>>
>>> What do You think?
>>>
>>> Regards,
>>>
>>> Jan
>>>
>>> --
>>> Want to help the Review Board project? Donate today at
>>> http://www.reviewboard.org/donate/
>>> Happy user? Let us know at 
>>> http://www.reviewboard.org/users/
>>> -~--~~~~--~~--~--~---
>>> To unsubscribe from this group, send email to
>>> reviewboard...@googlegroups.com
>>> For more options, visit this group at http://groups.google.com/group
>>> /reviewboard?hl=en
>>
>>
>>  --
 Get the Review Board Power Pack at http://www.reviewboard.org/
 powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: 
 https://rbcommons.com/
 ---

 Happy user? Let us know at 
 http://www.reviewboard.org/users/
  ---
 You received this message because you are subscribed to the Google
 Groups "reviewboard" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.

>>>
>>>  --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this messa

Re: Automated merge after review && continuous integration

[Venkateswara Reddy]

any updates on this

On Thursday, November 7, 2013 4:31:19 PM UTC+5:30, Venkateswara Reddy wrote:
>
> even i am looking for this, let me know if some one did it.
> Vreddy
>
> On Friday, September 20, 2013 9:30:05 PM UTC+5:30, David Trowbridge wrote:
>
>> There have been no changes to this as yet. We'd like to address this 
>> eventually but it's a very difficult thing to address in a generic way, and 
>> for the time being we have other priorities.
>>
>> -David
>>
>>
>> On Fri, Sep 20, 2013 at 4:32 AM, Luboš Račanský wrote:
>>
>>> I have the same question. Is there any way how to merge (from 
>>> ReviewBoard) after acceptance of review?
>>>
>>>
>>> On Friday, May 3, 2013 11:05:07 PM UTC+2, mamta.n...@gmail.com wrote:

 Hey David,
 This is an older post but i"m actually looking for exactly these things 
 currently and was wondering if these features have been built into 
 reviewboard now  / via plugins or are they still in pipeline?

 Thanks,
 M

 On Wednesday, April 20, 2011 3:34:59 PM UTC-7, David Trowbridge wrote:
>
> #2 would be great; I know a lot of people have requested the ability 
> to have some indication that the patch submitted will (a) apply cleanly 
> and 
> (b) build (maybe even including automated testing).
>
> #1 is often requested, but it's something which we've been wary of 
> because of the complexities of user authentication, audit chains, and the 
> abilities it would introduce to break things. It would be a cool feature, 
> but I think we'd need to approach it carefully.
>
> -David
>
>
> On Thu, Apr 14, 2011 at 10:19 AM, Jan Koprowski 
> wrote:
>
>> Hi,
>>
>> Recently i look at Gerrit - review tool dedicated for git guys. Two 
>> things bring my attention:
>>
>> 1) Gerrit try to merge code automatically after review. This is great 
>> ability. As far I'm aware when merge won't end with success developer 
>> get 
>> message to rebase their code and send to review again. It will be cool 
>> to 
>> get something similar at reviewboard. I think this approach will for for 
>> Git and probably for Mercurial too.
>>
>> 2) Build system integration. I saw Hudson & Gerrit integration which 
>> assume additional field for build system which check is project build 
>> with 
>> new versions or not. It is well  exposed at 
>> http://source.android.com/source/life-of-a-patch.html. Will be 
>> something nice to make accessible some by API "checkbox field" for build 
>> system and approach such workflow in reviewboard - optional ofcourse.
>>
>> What do You think?
>>
>> Regards,
>>
>> Jan
>>
>> -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at 
>> http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com
>> For more options, visit this group at http://groups.google.com/
>> group/reviewboard?hl=en
>
>
>  -- 
>>> Get the Review Board Power Pack at 
>>> http://www.reviewboard.org/powerpack/
>>> ---
>>> Sign up for Review Board hosting at RBCommons: 
>>> https://rbcommons.com/
>>> ---
>>>
>>> Happy user? Let us know at 
>>> http://www.reviewboard.org/users/
>>> --- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/groups/opt_out.
>>>
>>
>>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Automated merge after review && continuous integration

[Venkateswara Reddy]

even i am looking for this, let me know if some one did it.
Vreddy

On Friday, September 20, 2013 9:30:05 PM UTC+5:30, David Trowbridge wrote:

> There have been no changes to this as yet. We'd like to address this 
> eventually but it's a very difficult thing to address in a generic way, and 
> for the time being we have other priorities.
>
> -David
>
>
> On Fri, Sep 20, 2013 at 4:32 AM, Luboš Račanský 
> 
> > wrote:
>
>> I have the same question. Is there any way how to merge (from 
>> ReviewBoard) after acceptance of review?
>>
>>
>> On Friday, May 3, 2013 11:05:07 PM UTC+2, mamta.n...@gmail.com wrote:
>>>
>>> Hey David,
>>> This is an older post but i"m actually looking for exactly these things 
>>> currently and was wondering if these features have been built into 
>>> reviewboard now  / via plugins or are they still in pipeline?
>>>
>>> Thanks,
>>> M
>>>
>>> On Wednesday, April 20, 2011 3:34:59 PM UTC-7, David Trowbridge wrote:

 #2 would be great; I know a lot of people have requested the ability to 
 have some indication that the patch submitted will (a) apply cleanly and 
 (b) build (maybe even including automated testing).

 #1 is often requested, but it's something which we've been wary of 
 because of the complexities of user authentication, audit chains, and the 
 abilities it would introduce to break things. It would be a cool feature, 
 but I think we'd need to approach it carefully.

 -David


 On Thu, Apr 14, 2011 at 10:19 AM, Jan Koprowski wrote:

> Hi,
>
> Recently i look at Gerrit - review tool dedicated for git guys. Two 
> things bring my attention:
>
> 1) Gerrit try to merge code automatically after review. This is great 
> ability. As far I'm aware when merge won't end with success developer get 
> message to rebase their code and send to review again. It will be cool to 
> get something similar at reviewboard. I think this approach will for for 
> Git and probably for Mercurial too.
>
> 2) Build system integration. I saw Hudson & Gerrit integration which 
> assume additional field for build system which check is project build 
> with 
> new versions or not. It is well  exposed at http://source.android.com/
> **source/life-of-a-patch.html.
>  
> Will be something nice to make accessible some by API "checkbox field" 
> for 
> build system and approach such workflow in reviewboard - optional 
> ofcourse.
>
> What do You think?
>
> Regards,
>
> Jan
>
> -- 
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/**donate/
> Happy user? Let us know at 
> http://www.reviewboard.org/**users/
> -~--~~~~--**~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard...@googlegroups.**com
> For more options, visit this group at http://groups.google.com/**
> group/reviewboard?hl=en


  -- 
>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>> ---
>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>> ---
>>
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Automated merge after review && continuous integration

[David Trowbridge]

There have been no changes to this as yet. We'd like to address this
eventually but it's a very difficult thing to address in a generic way, and
for the time being we have other priorities.

-David


On Fri, Sep 20, 2013 at 4:32 AM, Luboš Račanský wrote:

> I have the same question. Is there any way how to merge (from ReviewBoard)
> after acceptance of review?
>
>
> On Friday, May 3, 2013 11:05:07 PM UTC+2, mamta.n...@gmail.com wrote:
>>
>> Hey David,
>> This is an older post but i"m actually looking for exactly these things
>> currently and was wondering if these features have been built into
>> reviewboard now  / via plugins or are they still in pipeline?
>>
>> Thanks,
>> M
>>
>> On Wednesday, April 20, 2011 3:34:59 PM UTC-7, David Trowbridge wrote:
>>>
>>> #2 would be great; I know a lot of people have requested the ability to
>>> have some indication that the patch submitted will (a) apply cleanly and
>>> (b) build (maybe even including automated testing).
>>>
>>> #1 is often requested, but it's something which we've been wary of
>>> because of the complexities of user authentication, audit chains, and the
>>> abilities it would introduce to break things. It would be a cool feature,
>>> but I think we'd need to approach it carefully.
>>>
>>> -David
>>>
>>>
>>> On Thu, Apr 14, 2011 at 10:19 AM, Jan Koprowski wrote:
>>>
 Hi,

 Recently i look at Gerrit - review tool dedicated for git guys. Two
 things bring my attention:

 1) Gerrit try to merge code automatically after review. This is great
 ability. As far I'm aware when merge won't end with success developer get
 message to rebase their code and send to review again. It will be cool to
 get something similar at reviewboard. I think this approach will for for
 Git and probably for Mercurial too.

 2) Build system integration. I saw Hudson & Gerrit integration which
 assume additional field for build system which check is project build with
 new versions or not. It is well  exposed at http://source.android.com/*
 *source/life-of-a-patch.html.
 Will be something nice to make accessible some by API "checkbox field" for
 build system and approach such workflow in reviewboard - optional ofcourse.

 What do You think?

 Regards,

 Jan

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/**donate/
 Happy user? Let us know at 
 http://www.reviewboard.org/**users/
 -~--~~~~--**~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard...@googlegroups.**com
 For more options, visit this group at http://groups.google.com/**
 group/reviewboard?hl=en
>>>
>>>
>>>  --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
>
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Automated merge after review && continuous integration

[Luboš Račanský]

I have the same question. Is there any way how to merge (from ReviewBoard) 
after acceptance of review?

On Friday, May 3, 2013 11:05:07 PM UTC+2, mamta.n...@gmail.com wrote:
>
> Hey David,
> This is an older post but i"m actually looking for exactly these things 
> currently and was wondering if these features have been built into 
> reviewboard now  / via plugins or are they still in pipeline?
>
> Thanks,
> M
>
> On Wednesday, April 20, 2011 3:34:59 PM UTC-7, David Trowbridge wrote:
>>
>> #2 would be great; I know a lot of people have requested the ability to 
>> have some indication that the patch submitted will (a) apply cleanly and 
>> (b) build (maybe even including automated testing).
>>
>> #1 is often requested, but it's something which we've been wary of 
>> because of the complexities of user authentication, audit chains, and the 
>> abilities it would introduce to break things. It would be a cool feature, 
>> but I think we'd need to approach it carefully.
>>
>> -David
>>
>>
>> On Thu, Apr 14, 2011 at 10:19 AM, Jan Koprowski wrote:
>>
>>> Hi,
>>>
>>> Recently i look at Gerrit - review tool dedicated for git guys. Two 
>>> things bring my attention:
>>>
>>> 1) Gerrit try to merge code automatically after review. This is great 
>>> ability. As far I'm aware when merge won't end with success developer get 
>>> message to rebase their code and send to review again. It will be cool to 
>>> get something similar at reviewboard. I think this approach will for for 
>>> Git and probably for Mercurial too.
>>>
>>> 2) Build system integration. I saw Hudson & Gerrit integration which 
>>> assume additional field for build system which check is project build with 
>>> new versions or not. It is well  exposed at 
>>> http://source.android.com/source/life-of-a-patch.html. Will be 
>>> something nice to make accessible some by API "checkbox field" for build 
>>> system and approach such workflow in reviewboard - optional ofcourse.
>>>
>>> What do You think?
>>>
>>> Regards,
>>>
>>> Jan
>>>
>>> -- 
>>> Want to help the Review Board project? Donate today at 
>>> http://www.reviewboard.org/donate/
>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>> -~--~~~~--~~--~--~---
>>> To unsubscribe from this group, send email to 
>>> reviewboard...@googlegroups.com
>>> For more options, visit this group at 
>>> http://groups.google.com/group/reviewboard?hl=en
>>
>>
>>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Automated merge after review && continuous integration

[mamta . nanavati]

Hey David,
This is an older post but i"m actually looking for exactly these things 
currently and was wondering if these features have been built into 
reviewboard now  / via plugins or are they still in pipeline?

Thanks,
M

On Wednesday, April 20, 2011 3:34:59 PM UTC-7, David Trowbridge wrote:
>
> #2 would be great; I know a lot of people have requested the ability to 
> have some indication that the patch submitted will (a) apply cleanly and 
> (b) build (maybe even including automated testing).
>
> #1 is often requested, but it's something which we've been wary of because 
> of the complexities of user authentication, audit chains, and the abilities 
> it would introduce to break things. It would be a cool feature, but I think 
> we'd need to approach it carefully.
>
> -David
>
>
> On Thu, Apr 14, 2011 at 10:19 AM, Jan Koprowski 
> 
> > wrote:
>
>> Hi,
>>
>> Recently i look at Gerrit - review tool dedicated for git guys. Two 
>> things bring my attention:
>>
>> 1) Gerrit try to merge code automatically after review. This is great 
>> ability. As far I'm aware when merge won't end with success developer get 
>> message to rebase their code and send to review again. It will be cool to 
>> get something similar at reviewboard. I think this approach will for for 
>> Git and probably for Mercurial too.
>>
>> 2) Build system integration. I saw Hudson & Gerrit integration which 
>> assume additional field for build system which check is project build with 
>> new versions or not. It is well  exposed at 
>> http://source.android.com/source/life-of-a-patch.html. Will be something 
>> nice to make accessible some by API "checkbox field" for build system and 
>> approach such workflow in reviewboard - optional ofcourse.
>>
>> What do You think?
>>
>> Regards,
>>
>> Jan
>>
>> -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com 
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Automated merge after review && continuous integration

[David Trowbridge]

#2 would be great; I know a lot of people have requested the ability to have
some indication that the patch submitted will (a) apply cleanly and (b)
build (maybe even including automated testing).

#1 is often requested, but it's something which we've been wary of because
of the complexities of user authentication, audit chains, and the abilities
it would introduce to break things. It would be a cool feature, but I think
we'd need to approach it carefully.

-David


On Thu, Apr 14, 2011 at 10:19 AM, Jan Koprowski wrote:

> Hi,
>
> Recently i look at Gerrit - review tool dedicated for git guys. Two things
> bring my attention:
>
> 1) Gerrit try to merge code automatically after review. This is great
> ability. As far I'm aware when merge won't end with success developer get
> message to rebase their code and send to review again. It will be cool to
> get something similar at reviewboard. I think this approach will for for Git
> and probably for Mercurial too.
>
> 2) Build system integration. I saw Hudson & Gerrit integration which assume
> additional field for build system which check is project build with new
> versions or not. It is well  exposed at
> http://source.android.com/source/life-of-a-patch.html. Will be something
> nice to make accessible some by API "checkbox field" for build system and
> approach such workflow in reviewboard - optional ofcourse.
>
> What do You think?
>
> Regards,
>
> Jan
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Automated merge after review && continuous integration

[Jan Koprowski]

Hi,

Recently i look at Gerrit - review tool dedicated for git guys. Two things 
bring my attention:

1) Gerrit try to merge code automatically after review. This is great 
ability. As far I'm aware when merge won't end with success developer get 
message to rebase their code and send to review again. It will be cool to 
get something similar at reviewboard. I think this approach will for for Git 
and probably for Mercurial too.

2) Build system integration. I saw Hudson & Gerrit integration which assume 
additional field for build system which check is project build with new 
versions or not. It is well  exposed at 
http://source.android.com/source/life-of-a-patch.html. Will be something 
nice to make accessible some by API "checkbox field" for build system and 
approach such workflow in reviewboard - optional ofcourse.

What do You think?

Regards,

Jan

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en