Long lines get cut off in diff view
Hi all, One of my users is having a strange issue with the diff viewer in ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of the view gets cut off. They claim it happens in Chrome 62 and Firefox 57, but I was only able to reproduce the problem in IE 11. Any ideas on what the issue might be, or how to resolve it? [image: image001.jpg] -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Long lines get cut off in diff view
Hi Rob, Unfortunately that screenshot didn’t go through for me. Looks like it’s some inline thing instead of an attachment. Can you try re-attaching? Christian On Thu, Nov 23, 2017 at 10:09 Rob Petti wrote: > Hi all, > > One of my users is having a strange issue with the diff viewer in > ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of > the view gets cut off. > > They claim it happens in Chrome 62 and Firefox 57, but I was only able to > reproduce the problem in IE 11. > > Any ideas on what the issue might be, or how to resolve it? > > [image: image001.jpg] > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Long lines get cut off in diff view
That's odd... Here's the attachment again. On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond wrote: > Hi Rob, > > Unfortunately that screenshot didn’t go through for me. Looks like it’s > some inline thing instead of an attachment. Can you try re-attaching? > > Christian > > > On Thu, Nov 23, 2017 at 10:09 Rob Petti wrote: > >> Hi all, >> >> One of my users is having a strange issue with the diff viewer in >> ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of >> the view gets cut off. >> >> They claim it happens in Chrome 62 and Firefox 57, but I was only able to >> reproduce the problem in IE 11. >> >> Any ideas on what the issue might be, or how to resolve it? >> >> [image: image001.jpg] >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > -- > -- > Christian Hammond > President/CEO of Beanbag > Makers of Review Board > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to a topic in the > Google Groups "reviewboard" group. > To unsubscribe from this topic, visit https://groups.google.com/d/ > topic/reviewboard/E_QhfFCtm0Q/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Long lines get cut off in diff view
Looks like the lines are missing a character or two. I have seen this once, and when I looked, it was a quirk with how the browser chose to wrap vs. extend the container for the line. I’ll keep my eye open and see if I can reproduce and figure out the issue, but it was non-obvious last time. What I did find was resizing the window would trigger a relayout, resolving the problem. I’d be curious if this works around the issue for you. Christian On Thu, Nov 23, 2017 at 16:24 Rob Petti wrote: > That's odd... Here's the attachment again. > > On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond < > christ...@beanbaginc.com> wrote: > >> Hi Rob, >> >> Unfortunately that screenshot didn’t go through for me. Looks like it’s >> some inline thing instead of an attachment. Can you try re-attaching? >> >> Christian >> >> >> On Thu, Nov 23, 2017 at 10:09 Rob Petti wrote: >> >>> Hi all, >>> >>> One of my users is having a strange issue with the diff viewer in >>> ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of >>> the view gets cut off. >>> >>> They claim it happens in Chrome 62 and Firefox 57, but I was only able >>> to reproduce the problem in IE 11. >>> >>> Any ideas on what the issue might be, or how to resolve it? >>> >>> [image: image001.jpg] >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard+unsubscr...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> -- >> Christian Hammond >> President/CEO of Beanbag >> Makers of Review Board >> > -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> > You received this message because you are subscribed to a topic in the >> Google Groups "reviewboard" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe. >> To unsubscribe from this group and all its topics, send an email to >> reviewboard+unsubscr...@googlegroups.com. >> > >> For more options, visit https://groups.google.com/d/optout. >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Long lines get cut off in diff view
The user reports that they can work-around it by zooming out and in with CTRL and -, then CTRL and 0, or by maximizing and restoring. So it would seem that triggering a relayout fixes it for them. Thanks for looking into it! On Thu, Nov 23, 2017 at 10:20 PM, Christian Hammond < christ...@beanbaginc.com> wrote: > Looks like the lines are missing a character or two. I have seen this > once, and when I looked, it was a quirk with how the browser chose to wrap > vs. extend the container for the line. I’ll keep my eye open and see if I > can reproduce and figure out the issue, but it was non-obvious last time. > > What I did find was resizing the window would trigger a relayout, > resolving the problem. I’d be curious if this works around the issue for > you. > > Christian > > > > On Thu, Nov 23, 2017 at 16:24 Rob Petti wrote: > >> That's odd... Here's the attachment again. >> >> On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond < >> christ...@beanbaginc.com> wrote: >> >>> Hi Rob, >>> >>> Unfortunately that screenshot didn’t go through for me. Looks like it’s >>> some inline thing instead of an attachment. Can you try re-attaching? >>> >>> Christian >>> >>> >>> On Thu, Nov 23, 2017 at 10:09 Rob Petti wrote: >>> Hi all, One of my users is having a strange issue with the diff viewer in ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of the view gets cut off. They claim it happens in Chrome 62 and Firefox 57, but I was only able to reproduce the problem in IE 11. Any ideas on what the issue might be, or how to resolve it? [image: image001.jpg] -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. >>> -- >>> -- >>> Christian Hammond >>> President/CEO of Beanbag >>> Makers of Review Board >>> >> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> >> You received this message because you are subscribed to a topic in the >>> Google Groups "reviewboard" group. >>> To unsubscribe from this topic, visit https://groups.google.com/d/ >>> topic/reviewboard/E_QhfFCtm0Q/unsubscribe. >>> To unsubscribe from this group and all its topics, send an email to >>> reviewboard+unsubscr...@googlegroups.com. >>> >> >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > -- > -- > Christian Hammond > President/CEO of Beanbag > Makers of Review Board > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to a topic in the > Google Groups "reviewboard" group. > To unsubscribe from this topic, visit https://groups.google.com/d/ > topic/reviewboard/E_QhfFCtm0Q/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Long lines get cut off in diff view
I have users hitting this too, unfortunately. We're on the latest version of Review Board and are using the latest version of Firefox (stable). It's making people think about switching over to GitLab merge requests for reviews since we use GitLab for version control anyway. On Friday, November 24, 2017 at 10:40:15 AM UTC-5, Rob Petti wrote: > > The user reports that they can work-around it by zooming out and in with > CTRL and -, then CTRL and 0, or by maximizing and restoring. So it would > seem that triggering a relayout fixes it for them. > > Thanks for looking into it! > > On Thu, Nov 23, 2017 at 10:20 PM, Christian Hammond < > chri...@beanbaginc.com > wrote: > >> Looks like the lines are missing a character or two. I have seen this >> once, and when I looked, it was a quirk with how the browser chose to wrap >> vs. extend the container for the line. I’ll keep my eye open and see if I >> can reproduce and figure out the issue, but it was non-obvious last time. >> >> What I did find was resizing the window would trigger a relayout, >> resolving the problem. I’d be curious if this works around the issue for >> you. >> >> Christian >> >> >> >> On Thu, Nov 23, 2017 at 16:24 Rob Petti > >> wrote: >> >>> That's odd... Here's the attachment again. >>> >>> On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond < >>> chri...@beanbaginc.com > wrote: >>> Hi Rob, Unfortunately that screenshot didn’t go through for me. Looks like it’s some inline thing instead of an attachment. Can you try re-attaching? Christian On Thu, Nov 23, 2017 at 10:09 Rob Petti >>> > wrote: > Hi all, > > One of my users is having a strange issue with the diff viewer in > ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge > of > the view gets cut off. > > They claim it happens in Chrome 62 and Firefox 57, but I was only able > to reproduce the problem in IE 11. > > Any ideas on what the issue might be, or how to resolve it? > > [image: image001.jpg] > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google > Groups "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to revie...@googlegroups.com . > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board >>> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- >>> You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe. To unsubscribe from this group and all its topics, send an email to revie...@googlegroups.com . >>> For more options, visit https://groups.google.com/d/optout. >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to revie...@googlegroups.com . >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> -- >> Christian Hammond >> President/CEO of Beanbag >> Makers of Review Board >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to a topic in the >> Google Groups "reviewboard" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe. >> To unsubscribe from this group and all its topics, send an email to >> revie...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! http
Re: Long lines get cut off in diff view
I have good news on this subject. A customer we’re working with got us a really solid report case, and we’ve solved it. The fix is going to be going into 3.0.18. Aiming for next week for that release. Christian On Tue, May 26, 2020 at 20:50 Tyler Wright wrote: > I have users hitting this too, unfortunately. We're on the latest version > of Review Board and are using the latest version of Firefox (stable). It's > making people think about switching over to GitLab merge requests for > reviews since we use GitLab for version control anyway. > > On Friday, November 24, 2017 at 10:40:15 AM UTC-5, Rob Petti wrote: >> >> The user reports that they can work-around it by zooming out and in with >> CTRL and -, then CTRL and 0, or by maximizing and restoring. So it would >> seem that triggering a relayout fixes it for them. >> >> Thanks for looking into it! >> >> On Thu, Nov 23, 2017 at 10:20 PM, Christian Hammond < >> chri...@beanbaginc.com> wrote: >> >>> Looks like the lines are missing a character or two. I have seen this >>> once, and when I looked, it was a quirk with how the browser chose to wrap >>> vs. extend the container for the line. I’ll keep my eye open and see if I >>> can reproduce and figure out the issue, but it was non-obvious last time. >>> >>> What I did find was resizing the window would trigger a relayout, >>> resolving the problem. I’d be curious if this works around the issue for >>> you. >>> >>> Christian >>> >>> >>> >>> On Thu, Nov 23, 2017 at 16:24 Rob Petti wrote: >>> That's odd... Here's the attachment again. On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond < chri...@beanbaginc.com> wrote: > Hi Rob, > > Unfortunately that screenshot didn’t go through for me. Looks like > it’s some inline thing instead of an attachment. Can you try re-attaching? > > Christian > > > On Thu, Nov 23, 2017 at 10:09 Rob Petti wrote: > >> Hi all, >> >> One of my users is having a strange issue with the diff viewer in >> ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge >> of >> the view gets cut off. >> >> They claim it happens in Chrome 62 and Firefox 57, but I was only >> able to reproduce the problem in IE 11. >> >> Any ideas on what the issue might be, or how to resolve it? >> >> [image: image001.jpg] >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google >> Groups "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, >> send an email to revie...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > -- > -- > Christian Hammond > President/CEO of Beanbag > Makers of Review Board > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to a topic in the > Google Groups "reviewboard" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > revie...@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to revie...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. >>> -- >>> -- >>> Christian Hammond >>> President/CEO of Beanbag >>> Makers of Review Board >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to a topic in the >>> Google Groups "reviewboard" group. >>> To unsubscribe from this topic, visit >>> https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe. >>> To unsubscribe from this group a
Re: Long lines get cut off in diff view
That's fantastic news! Thanks, Christian! On Wednesday, May 27, 2020 at 12:31:06 AM UTC-4, Christian Hammond wrote: > > I have good news on this subject. > > A customer we’re working with got us a really solid report case, and we’ve > solved it. The fix is going to be going into 3.0.18. Aiming for next week > for that release. > > Christian > > > On Tue, May 26, 2020 at 20:50 Tyler Wright > wrote: > >> I have users hitting this too, unfortunately. We're on the latest >> version of Review Board and are using the latest version of Firefox >> (stable). It's making people think about switching over to GitLab merge >> requests for reviews since we use GitLab for version control anyway. >> >> On Friday, November 24, 2017 at 10:40:15 AM UTC-5, Rob Petti wrote: >>> >>> The user reports that they can work-around it by zooming out and in with >>> CTRL and -, then CTRL and 0, or by maximizing and restoring. So it would >>> seem that triggering a relayout fixes it for them. >>> >>> Thanks for looking into it! >>> >>> On Thu, Nov 23, 2017 at 10:20 PM, Christian Hammond < >>> chri...@beanbaginc.com> wrote: >>> Looks like the lines are missing a character or two. I have seen this once, and when I looked, it was a quirk with how the browser chose to wrap vs. extend the container for the line. I’ll keep my eye open and see if I can reproduce and figure out the issue, but it was non-obvious last time. What I did find was resizing the window would trigger a relayout, resolving the problem. I’d be curious if this works around the issue for you. Christian On Thu, Nov 23, 2017 at 16:24 Rob Petti wrote: > That's odd... Here's the attachment again. > > On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond < > chri...@beanbaginc.com> wrote: > >> Hi Rob, >> >> Unfortunately that screenshot didn’t go through for me. Looks like >> it’s some inline thing instead of an attachment. Can you try >> re-attaching? >> >> Christian >> >> >> On Thu, Nov 23, 2017 at 10:09 Rob Petti wrote: >> >>> Hi all, >>> >>> One of my users is having a strange issue with the diff viewer in >>> ReviewBoard 2.5.16. When long lines wrap, part of the text near the >>> edge of >>> the view gets cut off. >>> >>> They claim it happens in Chrome 62 and Firefox 57, but I was only >>> able to reproduce the problem in IE 11. >>> >>> Any ideas on what the issue might be, or how to resolve it? >>> >>> [image: image001.jpg] >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, >>> send an email to revie...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> -- >> Christian Hammond >> President/CEO of Beanbag >> Makers of Review Board >> > -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> > You received this message because you are subscribed to a topic in the >> Google Groups "reviewboard" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe >> . >> To unsubscribe from this group and all its topics, send an email to >> revie...@googlegroups.com. >> > >> For more options, visit https://groups.google.com/d/optout. >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google > Groups "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to revie...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let
Re: Long lines get cut off in diff view
Hey Christian, Any news as to when 3.0.18 is supposed to come out? Thanks! On Wednesday, May 27, 2020 at 11:26:15 AM UTC-4, Tyler Wright wrote: > > That's fantastic news! Thanks, Christian! > > On Wednesday, May 27, 2020 at 12:31:06 AM UTC-4, Christian Hammond wrote: >> >> I have good news on this subject. >> >> A customer we’re working with got us a really solid report case, and >> we’ve solved it. The fix is going to be going into 3.0.18. Aiming for next >> week for that release. >> >> Christian >> >> >> On Tue, May 26, 2020 at 20:50 Tyler Wright wrote: >> >>> I have users hitting this too, unfortunately. We're on the latest >>> version of Review Board and are using the latest version of Firefox >>> (stable). It's making people think about switching over to GitLab merge >>> requests for reviews since we use GitLab for version control anyway. >>> >>> On Friday, November 24, 2017 at 10:40:15 AM UTC-5, Rob Petti wrote: The user reports that they can work-around it by zooming out and in with CTRL and -, then CTRL and 0, or by maximizing and restoring. So it would seem that triggering a relayout fixes it for them. Thanks for looking into it! On Thu, Nov 23, 2017 at 10:20 PM, Christian Hammond < chri...@beanbaginc.com> wrote: > Looks like the lines are missing a character or two. I have seen this > once, and when I looked, it was a quirk with how the browser chose to > wrap > vs. extend the container for the line. I’ll keep my eye open and see if I > can reproduce and figure out the issue, but it was non-obvious last time. > > What I did find was resizing the window would trigger a relayout, > resolving the problem. I’d be curious if this works around the issue for > you. > > Christian > > > > On Thu, Nov 23, 2017 at 16:24 Rob Petti wrote: > >> That's odd... Here's the attachment again. >> >> On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond < >> chri...@beanbaginc.com> wrote: >> >>> Hi Rob, >>> >>> Unfortunately that screenshot didn’t go through for me. Looks like >>> it’s some inline thing instead of an attachment. Can you try >>> re-attaching? >>> >>> Christian >>> >>> >>> On Thu, Nov 23, 2017 at 10:09 Rob Petti wrote: >>> Hi all, One of my users is having a strange issue with the diff viewer in ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of the view gets cut off. They claim it happens in Chrome 62 and Firefox 57, but I was only able to reproduce the problem in IE 11. Any ideas on what the issue might be, or how to resolve it? [image: image001.jpg] -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to revie...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. >>> -- >>> -- >>> Christian Hammond >>> President/CEO of Beanbag >>> Makers of Review Board >>> >> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> >> You received this message because you are subscribed to a topic in >>> the Google Groups "reviewboard" group. >>> To unsubscribe from this topic, visit >>> https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe >>> . >>> To unsubscribe from this group and all its topics, send an email to >>> revie...@googlegroups.com. >>> >> >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google >> Groups "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, >> send an email to revie...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > -- > -- > Christian Hammo
Re: Long lines get cut off in diff view
Hi Tyler, We're aiming for next week (fingers crossed). It was planned to be out over a week ago, but we had a few things delay it (hardware failure on my end, some customer support issues that have kept us busy. I'm trying to wrap up what's left for the release, get that tested, and out the door. Christian On Mon, Jun 15, 2020 at 4:22 PM Tyler Wright wrote: > Hey Christian, > > Any news as to when 3.0.18 is supposed to come out? > > Thanks! > > On Wednesday, May 27, 2020 at 11:26:15 AM UTC-4, Tyler Wright wrote: >> >> That's fantastic news! Thanks, Christian! >> >> On Wednesday, May 27, 2020 at 12:31:06 AM UTC-4, Christian Hammond wrote: >>> >>> I have good news on this subject. >>> >>> A customer we’re working with got us a really solid report case, and >>> we’ve solved it. The fix is going to be going into 3.0.18. Aiming for next >>> week for that release. >>> >>> Christian >>> >>> >>> On Tue, May 26, 2020 at 20:50 Tyler Wright wrote: >>> I have users hitting this too, unfortunately. We're on the latest version of Review Board and are using the latest version of Firefox (stable). It's making people think about switching over to GitLab merge requests for reviews since we use GitLab for version control anyway. On Friday, November 24, 2017 at 10:40:15 AM UTC-5, Rob Petti wrote: > > The user reports that they can work-around it by zooming out and in > with CTRL and -, then CTRL and 0, or by maximizing and restoring. So it > would seem that triggering a relayout fixes it for them. > > Thanks for looking into it! > > On Thu, Nov 23, 2017 at 10:20 PM, Christian Hammond < > chri...@beanbaginc.com> wrote: > >> Looks like the lines are missing a character or two. I have seen this >> once, and when I looked, it was a quirk with how the browser chose to >> wrap >> vs. extend the container for the line. I’ll keep my eye open and see if I >> can reproduce and figure out the issue, but it was non-obvious last time. >> >> What I did find was resizing the window would trigger a relayout, >> resolving the problem. I’d be curious if this works around the issue for >> you. >> >> Christian >> >> >> >> On Thu, Nov 23, 2017 at 16:24 Rob Petti wrote: >> >>> That's odd... Here's the attachment again. >>> >>> On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond < >>> chri...@beanbaginc.com> wrote: >>> Hi Rob, Unfortunately that screenshot didn’t go through for me. Looks like it’s some inline thing instead of an attachment. Can you try re-attaching? Christian On Thu, Nov 23, 2017 at 10:09 Rob Petti wrote: > Hi all, > > One of my users is having a strange issue with the diff viewer in > ReviewBoard 2.5.16. When long lines wrap, part of the text near the > edge of > the view gets cut off. > > They claim it happens in Chrome 62 and Firefox 57, but I was only > able to reproduce the problem in IE 11. > > Any ideas on what the issue might be, or how to resolve it? > > [image: image001.jpg] > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google > Groups "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, > send an email to revie...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board >>> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- >>> You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe . To unsubscribe from this group and all its topics, send an email to revie...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommo
Re: Long lines get cut off in diff view
Hi Christian, Maybe my user's issue is a different issue because it still is broken in 3.0.18 :( On Monday, June 15, 2020 at 9:44:48 PM UTC-4, Christian Hammond wrote: > > Hi Tyler, > > We're aiming for next week (fingers crossed). It was planned to be out > over a week ago, but we had a few things delay it (hardware failure on my > end, some customer support issues that have kept us busy. I'm trying to > wrap up what's left for the release, get that tested, and out the door. > > Christian > > On Mon, Jun 15, 2020 at 4:22 PM Tyler Wright > wrote: > >> Hey Christian, >> >> Any news as to when 3.0.18 is supposed to come out? >> >> Thanks! >> >> On Wednesday, May 27, 2020 at 11:26:15 AM UTC-4, Tyler Wright wrote: >>> >>> That's fantastic news! Thanks, Christian! >>> >>> On Wednesday, May 27, 2020 at 12:31:06 AM UTC-4, Christian Hammond wrote: I have good news on this subject. A customer we’re working with got us a really solid report case, and we’ve solved it. The fix is going to be going into 3.0.18. Aiming for next week for that release. Christian On Tue, May 26, 2020 at 20:50 Tyler Wright wrote: > I have users hitting this too, unfortunately. We're on the latest > version of Review Board and are using the latest version of Firefox > (stable). It's making people think about switching over to GitLab merge > requests for reviews since we use GitLab for version control anyway. > > On Friday, November 24, 2017 at 10:40:15 AM UTC-5, Rob Petti wrote: >> >> The user reports that they can work-around it by zooming out and in >> with CTRL and -, then CTRL and 0, or by maximizing and restoring. So it >> would seem that triggering a relayout fixes it for them. >> >> Thanks for looking into it! >> >> On Thu, Nov 23, 2017 at 10:20 PM, Christian Hammond < >> chri...@beanbaginc.com> wrote: >> >>> Looks like the lines are missing a character or two. I have seen >>> this once, and when I looked, it was a quirk with how the browser chose >>> to >>> wrap vs. extend the container for the line. I’ll keep my eye open and >>> see >>> if I can reproduce and figure out the issue, but it was non-obvious >>> last >>> time. >>> >>> What I did find was resizing the window would trigger a relayout, >>> resolving the problem. I’d be curious if this works around the issue >>> for >>> you. >>> >>> Christian >>> >>> >>> >>> On Thu, Nov 23, 2017 at 16:24 Rob Petti wrote: >>> That's odd... Here's the attachment again. On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond < chri...@beanbaginc.com> wrote: > Hi Rob, > > Unfortunately that screenshot didn’t go through for me. Looks like > it’s some inline thing instead of an attachment. Can you try > re-attaching? > > Christian > > > On Thu, Nov 23, 2017 at 10:09 Rob Petti wrote: > >> Hi all, >> >> One of my users is having a strange issue with the diff viewer in >> ReviewBoard 2.5.16. When long lines wrap, part of the text near the >> edge of >> the view gets cut off. >> >> They claim it happens in Chrome 62 and Firefox 57, but I was only >> able to reproduce the problem in IE 11. >> >> Any ideas on what the issue might be, or how to resolve it? >> >> [image: image001.jpg] >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the >> Google Groups "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, >> send an email to revie...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > -- > -- > Christian Hammond > President/CEO of Beanbag > Makers of Review Board > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to a topic in > the Google Groups "reviewboard" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe > . >
Re: Long lines get cut off in diff view
Hi Tyler, That's a bit surprising to me. Can you tell me the exact browser/version being used? It would also help if I could see, in the browser's developer tools, what CSS rules are applied when selecting the element wrapping a line of code in the diff viewer. Christian On Tue, Jul 7, 2020 at 3:34 PM Tyler Wright wrote: > Hi Christian, > > Maybe my user's issue is a different issue because it still is broken in > 3.0.18 :( > > On Monday, June 15, 2020 at 9:44:48 PM UTC-4, Christian Hammond wrote: >> >> Hi Tyler, >> >> We're aiming for next week (fingers crossed). It was planned to be out >> over a week ago, but we had a few things delay it (hardware failure on my >> end, some customer support issues that have kept us busy. I'm trying to >> wrap up what's left for the release, get that tested, and out the door. >> >> Christian >> >> On Mon, Jun 15, 2020 at 4:22 PM Tyler Wright wrote: >> >>> Hey Christian, >>> >>> Any news as to when 3.0.18 is supposed to come out? >>> >>> Thanks! >>> >>> On Wednesday, May 27, 2020 at 11:26:15 AM UTC-4, Tyler Wright wrote: That's fantastic news! Thanks, Christian! On Wednesday, May 27, 2020 at 12:31:06 AM UTC-4, Christian Hammond wrote: > > I have good news on this subject. > > A customer we’re working with got us a really solid report case, and > we’ve solved it. The fix is going to be going into 3.0.18. Aiming for next > week for that release. > > Christian > > > On Tue, May 26, 2020 at 20:50 Tyler Wright wrote: > >> I have users hitting this too, unfortunately. We're on the latest >> version of Review Board and are using the latest version of Firefox >> (stable). It's making people think about switching over to GitLab merge >> requests for reviews since we use GitLab for version control anyway. >> >> On Friday, November 24, 2017 at 10:40:15 AM UTC-5, Rob Petti wrote: >>> >>> The user reports that they can work-around it by zooming out and in >>> with CTRL and -, then CTRL and 0, or by maximizing and restoring. So it >>> would seem that triggering a relayout fixes it for them. >>> >>> Thanks for looking into it! >>> >>> On Thu, Nov 23, 2017 at 10:20 PM, Christian Hammond < >>> chri...@beanbaginc.com> wrote: >>> Looks like the lines are missing a character or two. I have seen this once, and when I looked, it was a quirk with how the browser chose to wrap vs. extend the container for the line. I’ll keep my eye open and see if I can reproduce and figure out the issue, but it was non-obvious last time. What I did find was resizing the window would trigger a relayout, resolving the problem. I’d be curious if this works around the issue for you. Christian On Thu, Nov 23, 2017 at 16:24 Rob Petti wrote: > That's odd... Here's the attachment again. > > On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond < > chri...@beanbaginc.com> wrote: > >> Hi Rob, >> >> Unfortunately that screenshot didn’t go through for me. Looks >> like it’s some inline thing instead of an attachment. Can you try >> re-attaching? >> >> Christian >> >> >> On Thu, Nov 23, 2017 at 10:09 Rob Petti >> wrote: >> >>> Hi all, >>> >>> One of my users is having a strange issue with the diff viewer >>> in ReviewBoard 2.5.16. When long lines wrap, part of the text near >>> the edge >>> of the view gets cut off. >>> >>> They claim it happens in Chrome 62 and Firefox 57, but I was >>> only able to reproduce the problem in IE 11. >>> >>> Any ideas on what the issue might be, or how to resolve it? >>> >>> [image: image001.jpg] >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the >>> Google Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from >>> it, send an email to revie...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> -- >> Christian Hammond >> President/CEO of Beanbag >> Makers of Review Board >> > -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to hos
