Re: Reviewer to close review request
Yep, there's a Can Change Status permission you can set on a user that will allow them to do just that. Is it not the owner that's committing the code? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 25, 2012 at 12:53 PM, Peter Konneker pkonne...@wahoo.comwrote: Is there a permission that can be set on a user to allow them to close a review request that they are reviewing (instead of just the owner)? We are trying to implement reviews with as little impact on work flow as possible, so making the owner go back and close the request after the review is done seems superfluous. Thanks! -Peter -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Reviewer to close review request
Okay. I tried playing with that, but will have to try again. :) So we have a post-commit hook running that is posting the review request, then we want the reviewer to be able to come in, look at the code and close it out. So the owner pushes up the code, then the review request is pushed up automatically. So hopefully we can get it working. Not too much trouble even if we can't, though. Thanks! -Peter On Wed, Jul 25, 2012 at 2:06 PM, Christian Hammond chip...@chipx86.comwrote: Yep, there's a Can Change Status permission you can set on a user that will allow them to do just that. Is it not the owner that's committing the code? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 25, 2012 at 12:53 PM, Peter Konneker pkonne...@wahoo.comwrote: Is there a permission that can be set on a user to allow them to close a review request that they are reviewing (instead of just the owner)? We are trying to implement reviews with as little impact on work flow as possible, so making the owner go back and close the request after the review is done seems superfluous. Thanks! -Peter -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re : Reviewer to close review request
Edit review request is the permission you are looking for. Envoyé depuis mon Xperia™ S Message original Objet : Reviewer to close review request De : Peter Konneker pkonne...@wahoo.com À : reviewboard@googlegroups.com Cc : Is there a permission that can be set on a user to allow them to close a review request that they are reviewing (instead of just the owner)? We are trying to implement reviews with as little impact on work flow as possible, so making the owner go back and close the request after the review is done seems superfluous. Thanks! -Peter -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en