Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-23 Thread Raja
Doesnt the firstname, lastname and email set the values only on
auth_user table? If its only setting it locally in the reviewboard
database,  wouldnt it be possible to include those variables even if
the auth_backend is not builtin?

The current preferences screen shows those 3 variables only if
auth_backend is builtin.

-- Raja

On Feb 23, 6:29 am, Christian Hammond chip...@chipx86.com wrote:
 Or we should figure out a scheme to allow for setting that on other
 backends. Could check an attribute on the backend. Maybe assume that we can
 set that info and have a flag for turning it off, which LDAP, NIS, etc. can
 do.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com



 On Mon, Feb 22, 2010 at 4:39 PM, Stodge sto...@gmail.com wrote:
  Thanks. So I would need to write a custom backend/middleware instead?

  On Feb 22, 3:20 pm, Stephen Gallagher step...@gallagherhome.com
  wrote:
   On 02/22/2010 03:10 PM, Stodge wrote: I'm using the remote user
  middleware/backend to support basic http
authentication:

'django.contrib.auth.middleware.RemoteUserMiddleware',

and it seems to work nicely with Review Board. Apache forces a user to
login and then this middleware/backend automatically creates the user
in Django. The user is then interrupted and redirected to their
account page. Normally (as you know) the user is forced to enter their
first/last names and their email address. However, using the remote
middleware/backend the user is only asked to enable/disable syntax
highlighting. They're not forced to enter their names and email
address. Any ideas why this might be? Thanks

   Data received from the custom auth backend is authoritative. Anything
   you would enter as a first/last name or email would be overwritten by
   whatever the backend decided it should be.

  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr 
  oups.com
  For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-23 Thread Stodge
I have a custom middleware:

http://python.pastebin.com/wAcCNsTE

I blank out the names and email address but this doesn't help. Is
there something else I should be doing in my middleware?

Thanks

On Feb 22, 3:20 pm, Stephen Gallagher step...@gallagherhome.com
wrote:
 On 02/22/2010 03:10 PM, Stodge wrote: I'm using the remote user 
 middleware/backend to support basic http
  authentication:

  'django.contrib.auth.middleware.RemoteUserMiddleware',

  and it seems to work nicely with Review Board. Apache forces a user to
  login and then this middleware/backend automatically creates the user
  in Django. The user is then interrupted and redirected to their
  account page. Normally (as you know) the user is forced to enter their
  first/last names and their email address. However, using the remote
  middleware/backend the user is only asked to enable/disable syntax
  highlighting. They're not forced to enter their names and email
  address. Any ideas why this might be? Thanks

 Data received from the custom auth backend is authoritative. Anything
 you would enter as a first/last name or email would be overwritten by
 whatever the backend decided it should be.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-23 Thread Stodge
Ah - I think it's because I was still using the RemoteUserBackend. I
disabled that and it seems to work ok.

On Feb 23, 9:48 am, Stodge sto...@gmail.com wrote:
 I have a custom middleware:

 http://python.pastebin.com/wAcCNsTE

 I blank out the names and email address but this doesn't help. Is
 there something else I should be doing in my middleware?

 Thanks

 On Feb 22, 3:20 pm, Stephen Gallagher step...@gallagherhome.com
 wrote:

  On 02/22/2010 03:10 PM, Stodge wrote: I'm using the remote user 
  middleware/backend to support basic http
   authentication:

   'django.contrib.auth.middleware.RemoteUserMiddleware',

   and it seems to work nicely with Review Board. Apache forces a user to
   login and then this middleware/backend automatically creates the user
   in Django. The user is then interrupted and redirected to their
   account page. Normally (as you know) the user is forced to enter their
   first/last names and their email address. However, using the remote
   middleware/backend the user is only asked to enable/disable syntax
   highlighting. They're not forced to enter their names and email
   address. Any ideas why this might be? Thanks

  Data received from the custom auth backend is authoritative. Anything
  you would enter as a first/last name or email would be overwritten by
  whatever the backend decided it should be.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-23 Thread Christian Hammond
Actually, it's probably okay to have it there for all backends. Ideally, we
would stay in sync with the remote server (for LDAP, NIS and Active
Directory) but we don't do that today.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Tue, Feb 23, 2010 at 2:07 AM, Raja rajas...@gmail.com wrote:

 Doesnt the firstname, lastname and email set the values only on
 auth_user table? If its only setting it locally in the reviewboard
 database,  wouldnt it be possible to include those variables even if
 the auth_backend is not builtin?

 The current preferences screen shows those 3 variables only if
 auth_backend is builtin.

 -- Raja

 On Feb 23, 6:29 am, Christian Hammond chip...@chipx86.com wrote:
  Or we should figure out a scheme to allow for setting that on other
  backends. Could check an attribute on the backend. Maybe assume that we
 can
  set that info and have a flag for turning it off, which LDAP, NIS, etc.
 can
  do.
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.reviewboard.org
  VMware, Inc. -http://www.vmware.com
 
 
 
  On Mon, Feb 22, 2010 at 4:39 PM, Stodge sto...@gmail.com wrote:
   Thanks. So I would need to write a custom backend/middleware instead?
 
   On Feb 22, 3:20 pm, Stephen Gallagher step...@gallagherhome.com
   wrote:
On 02/22/2010 03:10 PM, Stodge wrote: I'm using the remote user
   middleware/backend to support basic http
 authentication:
 
 'django.contrib.auth.middleware.RemoteUserMiddleware',
 
 and it seems to work nicely with Review Board. Apache forces a user
 to
 login and then this middleware/backend automatically creates the
 user
 in Django. The user is then interrupted and redirected to their
 account page. Normally (as you know) the user is forced to enter
 their
 first/last names and their email address. However, using the remote
 middleware/backend the user is only asked to enable/disable syntax
 highlighting. They're not forced to enter their names and email
 address. Any ideas why this might be? Thanks
 
Data received from the custom auth backend is authoritative. Anything
you would enter as a first/last name or email would be overwritten by
whatever the backend decided it should be.
 
   --
   Want to help the Review Board project? Donate today at
  http://www.reviewboard.org/donate/
   Happy user? Let us know athttp://www.reviewboard.org/users/
   -~--~~~~--~~--~--~---
   To unsubscribe from this group, send email to
   reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 reviewboard%2bunsubscr...@googlegr oups.com
   For more options, visit this group at
  http://groups.google.com/group/reviewboard?hl=en

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-22 Thread Stodge
I'm using the remote user middleware/backend to support basic http
authentication:

'django.contrib.auth.middleware.RemoteUserMiddleware',

and it seems to work nicely with Review Board. Apache forces a user to
login and then this middleware/backend automatically creates the user
in Django. The user is then interrupted and redirected to their
account page. Normally (as you know) the user is forced to enter their
first/last names and their email address. However, using the remote
middleware/backend the user is only asked to enable/disable syntax
highlighting. They're not forced to enter their names and email
address. Any ideas why this might be? Thanks

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-22 Thread Stephen Gallagher
On 02/22/2010 03:10 PM, Stodge wrote:
 I'm using the remote user middleware/backend to support basic http
 authentication:

 'django.contrib.auth.middleware.RemoteUserMiddleware',

 and it seems to work nicely with Review Board. Apache forces a user to
 login and then this middleware/backend automatically creates the user
 in Django. The user is then interrupted and redirected to their
 account page. Normally (as you know) the user is forced to enter their
 first/last names and their email address. However, using the remote
 middleware/backend the user is only asked to enable/disable syntax
 highlighting. They're not forced to enter their names and email
 address. Any ideas why this might be? Thanks

   
Data received from the custom auth backend is authoritative. Anything
you would enter as a first/last name or email would be overwritten by
whatever the backend decided it should be.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-22 Thread Stodge
Thanks. So I would need to write a custom backend/middleware instead?

On Feb 22, 3:20 pm, Stephen Gallagher step...@gallagherhome.com
wrote:
 On 02/22/2010 03:10 PM, Stodge wrote: I'm using the remote user 
 middleware/backend to support basic http
  authentication:

  'django.contrib.auth.middleware.RemoteUserMiddleware',

  and it seems to work nicely with Review Board. Apache forces a user to
  login and then this middleware/backend automatically creates the user
  in Django. The user is then interrupted and redirected to their
  account page. Normally (as you know) the user is forced to enter their
  first/last names and their email address. However, using the remote
  middleware/backend the user is only asked to enable/disable syntax
  highlighting. They're not forced to enter their names and email
  address. Any ideas why this might be? Thanks

 Data received from the custom auth backend is authoritative. Anything
 you would enter as a first/last name or email would be overwritten by
 whatever the backend decided it should be.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-22 Thread Christian Hammond
Or we should figure out a scheme to allow for setting that on other
backends. Could check an attribute on the backend. Maybe assume that we can
set that info and have a flag for turning it off, which LDAP, NIS, etc. can
do.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, Feb 22, 2010 at 4:39 PM, Stodge sto...@gmail.com wrote:

 Thanks. So I would need to write a custom backend/middleware instead?

 On Feb 22, 3:20 pm, Stephen Gallagher step...@gallagherhome.com
 wrote:
  On 02/22/2010 03:10 PM, Stodge wrote: I'm using the remote user
 middleware/backend to support basic http
   authentication:
 
   'django.contrib.auth.middleware.RemoteUserMiddleware',
 
   and it seems to work nicely with Review Board. Apache forces a user to
   login and then this middleware/backend automatically creates the user
   in Django. The user is then interrupted and redirected to their
   account page. Normally (as you know) the user is forced to enter their
   first/last names and their email address. However, using the remote
   middleware/backend the user is only asked to enable/disable syntax
   highlighting. They're not forced to enter their names and email
   address. Any ideas why this might be? Thanks
 
  Data received from the custom auth backend is authoritative. Anything
  you would enter as a first/last name or email would be overwritten by
  whatever the backend decided it should be.

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en