Re: ReviewRequestApprovalHook not working (Reviewboard 3.0.x )

[Raja]

Thanks Christian. It looks like if I wanted to show some info on the
ReviewRequestView page based on those attributes
(approved/approvalFailure), I could setup some listeners that will get the
model and display them as an alert. They wont block the action but I can
show some info based on those attributes. Is that correct?

Best
Raja


On Sat, Oct 6, 2018 at 2:41 AM Christian Hammond 
wrote:

> Hi Raja,
>
> The hook doesn't influence anything in the UI. It's used for integrations
> that make use of the API to check if a review request has been approved
> (through the 'approved' and 'approval_failure' fields). This is intended
> for use in repository pre-commit hooks or in custom integrations. It's also
> not intended to block Ship Its or reviews, since in most cases it's still
> valuable to get further reviews even if others have signed off on it.
>
> We do have plans to represent this state as part of a larger change in an
> upcoming release. For now, though, you could always inject some indicator
> of whether a change is approved through the extension.
>
> Christian
>
> On Fri, Oct 5, 2018 at 11:37 AM Raja  wrote:
>
>> Hi,
>>
>> Im trying to build a custom extension following the example in
>> https://www.reviewboard.org/docs/manual/3.0/extending/extensions/hooks/review-request-approval-hook/#review-request-approval-hook
>> to check if a user needs to have X number of Ship-Its before its approved.
>> I have installed the extension and run breakpoints through it, which go
>> through the flow and return a tuple of False, .
>>
>> But the reviewboard UI doesnt reflect any of that and happily accepts the
>> Ship-It even if its just the first one. Is this a bug? Is an frontend
>> extension also needed to make this work? I was expecting the UI to throw an
>> alert indicating that there needs to be X Ship-Its (The error message
>> returned from the extension)
>>
>> Environment:
>> Virtual env running Reviewboard from source: Branch 3.0.x
>> Extension source is pretty much copied from the link above.
>>
>> Thanks
>> Raja
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
> --
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Raja
rajasaur at gmail.com

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: ReviewRequestApprovalHook not working (Reviewboard 3.0.x )

[Christian Hammond]

Hi Raja,

The hook doesn't influence anything in the UI. It's used for integrations
that make use of the API to check if a review request has been approved
(through the 'approved' and 'approval_failure' fields). This is intended
for use in repository pre-commit hooks or in custom integrations. It's also
not intended to block Ship Its or reviews, since in most cases it's still
valuable to get further reviews even if others have signed off on it.

We do have plans to represent this state as part of a larger change in an
upcoming release. For now, though, you could always inject some indicator
of whether a change is approved through the extension.

Christian

On Fri, Oct 5, 2018 at 11:37 AM Raja  wrote:

> Hi,
>
> Im trying to build a custom extension following the example in
> https://www.reviewboard.org/docs/manual/3.0/extending/extensions/hooks/review-request-approval-hook/#review-request-approval-hook
> to check if a user needs to have X number of Ship-Its before its approved.
> I have installed the extension and run breakpoints through it, which go
> through the flow and return a tuple of False, .
>
> But the reviewboard UI doesnt reflect any of that and happily accepts the
> Ship-It even if its just the first one. Is this a bug? Is an frontend
> extension also needed to make this work? I was expecting the UI to throw an
> alert indicating that there needs to be X Ship-Its (The error message
> returned from the extension)
>
> Environment:
> Virtual env running Reviewboard from source: Branch 3.0.x
> Extension source is pretty much copied from the link above.
>
> Thanks
> Raja
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

ReviewRequestApprovalHook not working (Reviewboard 3.0.x )

[Raja]

Hi,

Im trying to build a custom extension following the example 
in 
https://www.reviewboard.org/docs/manual/3.0/extending/extensions/hooks/review-request-approval-hook/#review-request-approval-hook
 
to check if a user needs to have X number of Ship-Its before its approved. 
I have installed the extension and run breakpoints through it, which go 
through the flow and return a tuple of False, . 

But the reviewboard UI doesnt reflect any of that and happily accepts the 
Ship-It even if its just the first one. Is this a bug? Is an frontend 
extension also needed to make this work? I was expecting the UI to throw an 
alert indicating that there needs to be X Ship-Its (The error message 
returned from the extension)

Environment:
Virtual env running Reviewboard from source: Branch 3.0.x
Extension source is pretty much copied from the link above.

Thanks
Raja

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.