Re: Reviewboard not reading file locations from patch index
Anyone? On Sunday, April 6, 2014 1:18:04 AM UTC+3, Robert Munteanu wrote: Hi, I'm using ReviewBoard 1.7.20 on Fedora 18 with a SVN repo. I'm trying to attach an SVN diff to a review using the RB API. I'm doing this from the eReviewboard Eclipse plugin, so I can't use post-review. The RB server runs at http://localhost:5040 . The SVN repository runs at http://localhost:5040/svn/repo . I am trying to post the diff with the basedir set to '/simple-project', and the diff is Index: src/com/example/Logic.java === --- w/runtime-ereviewboard/simple-project/src/com/example/Logic.java (revision 1) +++ w/runtime-ereviewboard/simple-project/src/com/example/Logic.java (working copy) @@ -7,6 +7,8 @@ public class Logic { public static void perform() { + + System.out.println(); System.out.println(Logic checks out); System.out.println(); When posting this diff, reviewboard complains that: {stat: fail, err: {msg: The file was not found in the repository, code: 207}, file: /simple-project/w/runtime-ereviewboard/simple-project/src/com/example/Logic.java, revision: 1} Looking at the diff, I see that the index is correct, the file does exist at /simple-project/src/com/example/Logic.java ( based on the Index line ). However, ReviewBoard seems to look for the file name contained in the ---/+++ lines. Is this correct/expected? Thanks, Robert -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Reviewboard not reading file locations from patch index
Hi, I'm using ReviewBoard 1.7.20 on Fedora 18 with a SVN repo. I'm trying to attach an SVN diff to a review using the RB API. I'm doing this from the eReviewboard Eclipse plugin, so I can't use post-review. The RB server runs at http://localhost:5040 . The SVN repository runs at http://localhost:5040/svn/repo . I am trying to post the diff with the basedir set to '/simple-project', and the diff is Index: src/com/example/Logic.java === --- w/runtime-ereviewboard/simple-project/src/com/example/Logic.java (revision 1) +++ w/runtime-ereviewboard/simple-project/src/com/example/Logic.java (working copy) @@ -7,6 +7,8 @@ public class Logic { public static void perform() { + + System.out.println(); System.out.println(Logic checks out); System.out.println(); When posting this diff, reviewboard complains that: {stat: fail, err: {msg: The file was not found in the repository, code: 207}, file: /simple-project/w/runtime-ereviewboard/simple-project/src/com/example/Logic.java, revision: 1} Looking at the diff, I see that the index is correct, the file does exist at /simple-project/src/com/example/Logic.java ( based on the Index line ). However, ReviewBoard seems to look for the file name contained in the ---/+++ lines. Is this correct/expected? Thanks, Robert -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.