Reviewbot: Should I see cppcheck and pep8 in my extension list?

2013-09-25 Thread Steve 
I installed reviewbot on our 1.7.14 server using these instructions:

https://github.com/reviewboard/ReviewBot

It looks like pep8 and cppcheck are automatically installed with reviewbot, 
but I don't see them listed in the extension list. I'm looking for them 
under

*Extensions -> Database -> Review bot tools*

That page says *'0 review bot tools'*.  Is some additional configuration 
needed?  The instructions say:

Workers are able to find installed tools using Entry 
Points. 
New tool classes should add a reviewbot.toolsentry point. The entry point 
for the pep8 tool is part of the review bot installation, here is an 
example showing its definition:

'reviewbot.tools': [
'cppcheck = reviewbot.tools.cppcheck:CPPCheckTool',
'cpplint = reviewbot.tools.cpplint:CPPLintTool',
'pep8 = reviewbot.tools.pep8:PEP8Tool',
],


But it's not clear to me where that setting should be.

--Steve

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Reviewbot: Should I see cppcheck and pep8 in my extension list?

2013-09-25 Thread Steven MacLeod 
Right after the section you've pasted, you'll see this:

After a tool has been installed on a worker, it must be registered with the
Review Bot extension, and configured in the admin panel. Registering tools
is accomplished in the following manner:

   1. Go to the extension list in the admin panel.
   2. Click the 'DATABASE' button for the 'Review-Bot-Extension'.
   3. Click the 'Review bot tools' link.
   4. Click 'REFRESH INSTALLED TOOLS' in the upper right of the page.

This will trigger tool registration for all of the currently running
workers, and refresh the page. You will now see the list of installed tools
and may configure them using this admin panel.



On Wed, Sep 25, 2013 at 2:21 PM, Steve  wrote:

> I installed reviewbot on our 1.7.14 server using these instructions:
>
> https://github.com/reviewboard/ReviewBot
>
> It looks like pep8 and cppcheck are automatically installed with
> reviewbot, but I don't see them listed in the extension list. I'm looking
> for them under
>
> *Extensions -> Database -> Review bot tools*
>
> That page says *'0 review bot tools'*.  Is some additional configuration
> needed?  The instructions say:
>
> Workers are able to find installed tools using Entry 
> Points.
> New tool classes should add a reviewbot.toolsentry point. The entry point
> for the pep8 tool is part of the review bot installation, here is an
> example showing its definition:
>
> 'reviewbot.tools': [
> 'cppcheck = reviewbot.tools.cppcheck:CPPCheckTool',
> 'cpplint = reviewbot.tools.cpplint:CPPLintTool',
> 'pep8 = reviewbot.tools.pep8:PEP8Tool',
> ],
>
>
> But it's not clear to me where that setting should be.
>
> --Steve
>
> --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Reviewbot: Should I see cppcheck and pep8 in my extension list?

2013-09-25 Thread Steve 
Sorry, I should have mentioned that I did that.  I even restarted apache 
and did the refresh again.  I'm still not seeing any extensions.

--Steve


On Wednesday, September 25, 2013 11:24:22 AM UTC-7, Steven MacLeod wrote:
>
> Right after the section you've pasted, you'll see this:
>
> After a tool has been installed on a worker, it must be registered with 
> the Review Bot extension, and configured in the admin panel. Registering 
> tools is accomplished in the following manner:
>
>1. Go to the extension list in the admin panel.
>2. Click the 'DATABASE' button for the 'Review-Bot-Extension'.
>3. Click the 'Review bot tools' link.
>4. Click 'REFRESH INSTALLED TOOLS' in the upper right of the page. 
>
> This will trigger tool registration for all of the currently running 
> workers, and refresh the page. You will now see the list of installed tools 
> and may configure them using this admin panel.
>
>
>
> On Wed, Sep 25, 2013 at 2:21 PM, Steve  >wrote:
>
>> I installed reviewbot on our 1.7.14 server using these instructions:
>>
>> https://github.com/reviewboard/ReviewBot
>>
>> It looks like pep8 and cppcheck are automatically installed with 
>> reviewbot, but I don't see them listed in the extension list. I'm looking 
>> for them under
>>
>> *Extensions -> Database -> Review bot tools*
>>
>> That page says *'0 review bot tools'*.  Is some additional configuration 
>> needed?  The instructions say:
>>
>> Workers are able to find installed tools using Entry 
>> Points.
>>  
>> New tool classes should add a reviewbot.toolsentry point. The entry 
>> point for the pep8 tool is part of the review bot installation, here is an 
>> example showing its definition:
>>
>> 'reviewbot.tools': [
>> 'cppcheck = reviewbot.tools.cppcheck:CPPCheckTool',
>> 'cpplint = reviewbot.tools.cpplint:CPPLintTool',
>> 'pep8 = reviewbot.tools.pep8:PEP8Tool',
>> ],
>>
>>
>> But it's not clear to me where that setting should be.
>>
>> --Steve
>>  
>> -- 
>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>> ---
>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>> ---
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Reviewbot: Should I see cppcheck and pep8 in my extension list?

2013-09-25 Thread Steve 
This may be the problem.  I'm running the reviewbot worker as apache and 
seeing this error:

[2013-09-25 10:57:33,786: WARNING/MainProcess] There was an error while 
creating a cookie file: [Errno 13] Permission denied: 
'reviewbot-cookies.txt'
[2013-09-25 10:57:33,786: ERROR/MainProcess] Could not reach RB server: 
[Errno 13] Permission denied: 'reviewbot-cookies.txt'

Where is it trying to write the cookie file? Maybe apache is not the right 
user to be running the reviewbot worker process?  What is the recommended 
user?  When I ran it as root there was a message recommending against that.

--Steve

On Wednesday, September 25, 2013 11:43:42 AM UTC-7, Steve wrote:
>
> Sorry, I should have mentioned that I did that.  I even restarted apache 
> and did the refresh again.  I'm still not seeing any extensions.
>
> --Steve
>
>
> On Wednesday, September 25, 2013 11:24:22 AM UTC-7, Steven MacLeod wrote:
>>
>> Right after the section you've pasted, you'll see this:
>>
>> After a tool has been installed on a worker, it must be registered with 
>> the Review Bot extension, and configured in the admin panel. Registering 
>> tools is accomplished in the following manner:
>>
>>1. Go to the extension list in the admin panel.
>>2. Click the 'DATABASE' button for the 'Review-Bot-Extension'.
>>3. Click the 'Review bot tools' link.
>>4. Click 'REFRESH INSTALLED TOOLS' in the upper right of the page. 
>>
>> This will trigger tool registration for all of the currently running 
>> workers, and refresh the page. You will now see the list of installed tools 
>> and may configure them using this admin panel.
>>
>>
>>
>> On Wed, Sep 25, 2013 at 2:21 PM, Steve  wrote:
>>
>>> I installed reviewbot on our 1.7.14 server using these instructions:
>>>
>>> https://github.com/reviewboard/ReviewBot
>>>
>>> It looks like pep8 and cppcheck are automatically installed with 
>>> reviewbot, but I don't see them listed in the extension list. I'm looking 
>>> for them under
>>>
>>> *Extensions -> Database -> Review bot tools*
>>>
>>> That page says *'0 review bot tools'*.  Is some additional 
>>> configuration needed?  The instructions say:
>>>
>>> Workers are able to find installed tools using Entry 
>>> Points.
>>>  
>>> New tool classes should add a reviewbot.toolsentry point. The entry 
>>> point for the pep8 tool is part of the review bot installation, here is an 
>>> example showing its definition:
>>>
>>> 'reviewbot.tools': [
>>> 'cppcheck = reviewbot.tools.cppcheck:CPPCheckTool',
>>> 'cpplint = reviewbot.tools.cpplint:CPPLintTool',
>>> 'pep8 = reviewbot.tools.pep8:PEP8Tool',
>>> ],
>>>
>>>
>>> But it's not clear to me where that setting should be.
>>>
>>> --Steve
>>>  
>>> -- 
>>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>>> ---
>>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>>> ---
>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>> --- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/groups/opt_out.
>>>
>>
>>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Reviewbot: Should I see cppcheck and pep8 in my extension list?

2013-09-25 Thread Steve 
Okay, I restarted the reviewbot work as root and now the extensions show 
up.  The reviewbot-cookies.txt file was written into the directory where I 
cloned the reviewbot source, which was owned by root.  I didn't expect that 
directory to be a working directory.  That seems odd to me.



On Wednesday, September 25, 2013 2:08:28 PM UTC-7, Steve wrote:
>
> This may be the problem.  I'm running the reviewbot worker as apache and 
> seeing this error:
>
> [2013-09-25 10:57:33,786: WARNING/MainProcess] There was an error while 
> creating a cookie file: [Errno 13] Permission denied: 
> 'reviewbot-cookies.txt'
> [2013-09-25 10:57:33,786: ERROR/MainProcess] Could not reach RB server: 
> [Errno 13] Permission denied: 'reviewbot-cookies.txt'
>
> Where is it trying to write the cookie file? Maybe apache is not the right 
> user to be running the reviewbot worker process?  What is the recommended 
> user?  When I ran it as root there was a message recommending against that.
>
> --Steve
>
> On Wednesday, September 25, 2013 11:43:42 AM UTC-7, Steve wrote:
>>
>> Sorry, I should have mentioned that I did that.  I even restarted apache 
>> and did the refresh again.  I'm still not seeing any extensions.
>>
>> --Steve
>>
>>
>> On Wednesday, September 25, 2013 11:24:22 AM UTC-7, Steven MacLeod wrote:
>>>
>>> Right after the section you've pasted, you'll see this:
>>>
>>> After a tool has been installed on a worker, it must be registered with 
>>> the Review Bot extension, and configured in the admin panel. Registering 
>>> tools is accomplished in the following manner:
>>>
>>>1. Go to the extension list in the admin panel.
>>>2. Click the 'DATABASE' button for the 'Review-Bot-Extension'.
>>>3. Click the 'Review bot tools' link.
>>>4. Click 'REFRESH INSTALLED TOOLS' in the upper right of the page. 
>>>
>>> This will trigger tool registration for all of the currently running 
>>> workers, and refresh the page. You will now see the list of installed tools 
>>> and may configure them using this admin panel.
>>>
>>>
>>>
>>> On Wed, Sep 25, 2013 at 2:21 PM, Steve  wrote:
>>>
 I installed reviewbot on our 1.7.14 server using these instructions:

 https://github.com/reviewboard/ReviewBot

 It looks like pep8 and cppcheck are automatically installed with 
 reviewbot, but I don't see them listed in the extension list. I'm looking 
 for them under

 *Extensions -> Database -> Review bot tools*

 That page says *'0 review bot tools'*.  Is some additional 
 configuration needed?  The instructions say:

 Workers are able to find installed tools using Entry 
 Points.
  
 New tool classes should add a reviewbot.toolsentry point. The entry 
 point for the pep8 tool is part of the review bot installation, here is an 
 example showing its definition:

 'reviewbot.tools': [
 'cppcheck = reviewbot.tools.cppcheck:CPPCheckTool',
 'cpplint = reviewbot.tools.cpplint:CPPLintTool',
 'pep8 = reviewbot.tools.pep8:PEP8Tool',
 ],


 But it's not clear to me where that setting should be.

 --Steve
  
 -- 
 Get the Review Board Power Pack at 
 http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups "reviewboard" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.

>>>
>>>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Reviewbot: Should I see cppcheck and pep8 in my extension list?

2013-09-26 Thread Steve 
I'm answering my own questions in case others run into similar problems.  I 
figured out that the reviewbot process looks for the reviewbot_cookies.txt 
file in the directory where you ran 'reviewbot worker'.  So the uid running 
the reviewbot process needs to be able to write to that directory.

So reviewbot is now working fine, and is actually pretty cool!

--Steve

On Wednesday, September 25, 2013 2:22:27 PM UTC-7, Steve wrote:
>
> Okay, I restarted the reviewbot work as root and now the extensions show 
> up.  The reviewbot-cookies.txt file was written into the directory where I 
> cloned the reviewbot source, which was owned by root.  I didn't expect that 
> directory to be a working directory.  That seems odd to me.
>
>
>
> On Wednesday, September 25, 2013 2:08:28 PM UTC-7, Steve wrote:
>>
>> This may be the problem.  I'm running the reviewbot worker as apache and 
>> seeing this error:
>>
>> [2013-09-25 10:57:33,786: WARNING/MainProcess] There was an error while 
>> creating a cookie file: [Errno 13] Permission denied: 
>> 'reviewbot-cookies.txt'
>> [2013-09-25 10:57:33,786: ERROR/MainProcess] Could not reach RB server: 
>> [Errno 13] Permission denied: 'reviewbot-cookies.txt'
>>
>> Where is it trying to write the cookie file? Maybe apache is not the 
>> right user to be running the reviewbot worker process?  What is the 
>> recommended user?  When I ran it as root there was a message recommending 
>> against that.
>>
>> --Steve
>>
>> On Wednesday, September 25, 2013 11:43:42 AM UTC-7, Steve wrote:
>>>
>>> Sorry, I should have mentioned that I did that.  I even restarted apache 
>>> and did the refresh again.  I'm still not seeing any extensions.
>>>
>>> --Steve
>>>
>>>
>>> On Wednesday, September 25, 2013 11:24:22 AM UTC-7, Steven MacLeod wrote:

 Right after the section you've pasted, you'll see this:

 After a tool has been installed on a worker, it must be registered with 
 the Review Bot extension, and configured in the admin panel. Registering 
 tools is accomplished in the following manner:

1. Go to the extension list in the admin panel.
2. Click the 'DATABASE' button for the 'Review-Bot-Extension'.
3. Click the 'Review bot tools' link.
4. Click 'REFRESH INSTALLED TOOLS' in the upper right of the page. 

 This will trigger tool registration for all of the currently running 
 workers, and refresh the page. You will now see the list of installed 
 tools 
 and may configure them using this admin panel.



 On Wed, Sep 25, 2013 at 2:21 PM, Steve  wrote:

> I installed reviewbot on our 1.7.14 server using these instructions:
>
> https://github.com/reviewboard/ReviewBot
>
> It looks like pep8 and cppcheck are automatically installed with 
> reviewbot, but I don't see them listed in the extension list. I'm looking 
> for them under
>
> *Extensions -> Database -> Review bot tools*
>
> That page says *'0 review bot tools'*.  Is some additional 
> configuration needed?  The instructions say:
>
> Workers are able to find installed tools using Entry 
> Points.
>  
> New tool classes should add a reviewbot.toolsentry point. The entry 
> point for the pep8 tool is part of the review bot installation, here is 
> an 
> example showing its definition:
>
> 'reviewbot.tools': [
> 'cppcheck = reviewbot.tools.cppcheck:CPPCheckTool',
> 'cpplint = reviewbot.tools.cpplint:CPPLintTool',
> 'pep8 = reviewbot.tools.pep8:PEP8Tool',
> ],
>
>
> But it's not clear to me where that setting should be.
>
> --Steve
>  
> -- 
> Get the Review Board Power Pack at 
> http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> --- 
> You received this message because you are subscribed to the Google 
> Groups "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send 
> an email to reviewboard...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.