Re: "hey, wait, I didn't close that!"
On 2013-11-19 17:14, David Trowbridge wrote: On Tue, Nov 19, 2013 at 12:58 PM, Matthew Woehlke wrote: The good news is that this means I can now verify that bug 3011¹ is fixed (can someone with ability to do so please close it? bonus points for amending the release notes to mention the bug number...). The "bad" news is that 'can close' permission sends mail as the request author and not the one that closed the request :-). I think that's probably covered by bug 2187. I'll add a comment about the email. Agreed (probably that is a prerequisite for the e-mail even being able to know who to send mail as). Thanks for pointing me there, and for the comment to the bug. -- Matthew -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: "hey, wait, I didn't close that!"
I think that's probably covered by bug 2187. I'll add a comment about the email. -David On Tue, Nov 19, 2013 at 12:58 PM, Matthew Woehlke wrote: > I just got a review closure e-mail from myself for a request I didn't > change. > > The good news is that this means I can now verify that bug 3011¹ is fixed > (can someone with ability to do so please close it? bonus points for > amending the release notes to mention the bug number...). The "bad" news is > that 'can close' permission sends mail as the request author and not the > one that closed the request :-). > > Any thoughts on whether or not that's the right thing to do? Should it be > changed? Should I file a bug report on it? > > (¹ http://code.google.com/p/reviewboard/issues/detail?id=3011) > > -- > Matthew > > -- > Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ > --- > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > --- > Happy user? Let us know at http://www.reviewboard.org/users/ > --- You received this message because you are subscribed to the Google > Groups "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
"hey, wait, I didn't close that!"
I just got a review closure e-mail from myself for a request I didn't change. The good news is that this means I can now verify that bug 3011¹ is fixed (can someone with ability to do so please close it? bonus points for amending the release notes to mention the bug number...). The "bad" news is that 'can close' permission sends mail as the request author and not the one that closed the request :-). Any thoughts on whether or not that's the right thing to do? Should it be changed? Should I file a bug report on it? (¹ http://code.google.com/p/reviewboard/issues/detail?id=3011) -- Matthew -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
