Re: post-review from windows fails
Hello Christian, Thank you very much for your answer. That was the right pointer. I investigated a few minutes and found the alternative configuration directive for mod_fcgi on http://www.fastcgi.com/mod_fastcgi/docs/mod_fastcgi.html. To resolve the problem I finally added the following line to my fastcgi.conf: FastCgiConfig -pass-header Authorization Maybe it is a good idea to add this line and the mod_fcgid config directive you mentioned next to the FAQ entry regarding mod_wsgi. Tanks again, Ruben On 24.03.2011, at 21:15, Christian Hammond wrote: > So, fastcgi, like mod_wsgi, strips the Authorization header by default. From > these docs ( > http://httpd.apache.org/mod_fcgid/mod/mod_fcgid.html#fcgidpassheader) it > looks like there's a "FcgidPassHeader Authorization" directive you can place > in your fastcgi configuration to possibly work around this. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review from windows fails
Hi, So the thing that may be the problem is fastcgi. There was a discussion about an option you have to enable in fastcgi (we'll be updating the auto-generated config for new sites, but existing ones need to be updated manually). It turns out this part of the discussion happened off the list, though, so I guess you wouldn't be able to easily find it... So, fastcgi, like mod_wsgi, strips the Authorization header by default. From these docs ( http://httpd.apache.org/mod_fcgid/mod/mod_fcgid.html#fcgidpassheader) it looks like there's a "FcgidPassHeader Authorization" directive you can place in your fastcgi configuration to possibly work around this. I'd give that a shot. Note this is for mod_fcgid. There's probably a related one for mod_fastcgi. Depends on which you're actually using under the hood. So you may have to google for variations on this if not using fcgid. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Mar 24, 2011 at 12:48 AM, Stein, Ruben < ruben.st...@mevis.fraunhofer.de> wrote: > On 15.03.2011, at 21:46, Christian Hammond wrote: > > > Are you behind a proxy server? > > No, I am not behind a proxy server. > > > With 0.3.2, can you run with --debug and provide the output? > > The output is attached as "debug_output_rbtools_0.3.2.txt" > > I can report some details concerning the problem: > 1. While playing around with the login problems I found out, that > allowing anonymous read access brings post-review some steps further, > but then again it stops asking for Web-API credentials although user > name and password were provided via command line. See > "debug_output_anonymous_read.txt" for the output. > > 2. The behavior of post-review 0.2 on osx does not differ from the one > on windows, that was wrong. The difference resulted from the fact, > that I had a valid cookie in my ".postreview-cookies.txt" on osx. As > soon as I copy that cookie to the windows machine, I can authenticate > there as well. > > 3. With the valid cookie in my .postreview-cookies.txt file it seems > to to ignore any credentials on the command line. I start pushing a > diff-file with a --username= argument, but without password. post- > review then prompts for a password, as expected. But no matter what I > type there, the operation will always succeed due to the cookie. Does > review-board use the cookie as fallback authentication method if the > password is false? I would expect the operation to fail if I provide a > specific user name and an invalid password is typed. Maybe this is > related to this older bug: > http://code.google.com/p/reviewboard/issues/detail?id=762 > See "debug_output_withoutcookie.txt" for an example. > > 4. My normal authentication mechanism is ActiveDirectory. Changing back to > standard authentication does not solve the problem. > > Sorry for re-posting the message, I think I tamed the mail-client now. > > Regards, Ruben > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review from windows fails
On 15.03.2011, at 21:46, Christian Hammond wrote:
> Are you behind a proxy server?
No, I am not behind a proxy server.
> With 0.3.2, can you run with --debug and provide the output?
The output is attached as "debug_output_rbtools_0.3.2.txt"
I can report some details concerning the problem:
1. While playing around with the login problems I found out, that
allowing anonymous read access brings post-review some steps further,
but then again it stops asking for Web-API credentials although user
name and password were provided via command line. See
"debug_output_anonymous_read.txt" for the output.
2. The behavior of post-review 0.2 on osx does not differ from the one
on windows, that was wrong. The difference resulted from the fact,
that I had a valid cookie in my ".postreview-cookies.txt" on osx. As
soon as I copy that cookie to the windows machine, I can authenticate
there as well.
3. With the valid cookie in my .postreview-cookies.txt file it seems
to to ignore any credentials on the command line. I start pushing a
diff-file with a --username= argument, but without password. post-
review then prompts for a password, as expected. But no matter what I
type there, the operation will always succeed due to the cookie. Does
review-board use the cookie as fallback authentication method if the
password is false? I would expect the operation to fail if I provide a
specific user name and an invalid password is typed. Maybe this is
related to this older bug:
http://code.google.com/p/reviewboard/issues/detail?id=762
See "debug_output_withoutcookie.txt" for an example.
4. My normal authentication mechanism is ActiveDirectory. Changing back to
standard authentication does not solve the problem.
Sorry for re-posting the message, I think I tamed the mail-client now.
Regards, Ruben
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=enC:\Prompt>post-review --submit-as=username --target-groups= --target-
people=targetuser --diff-filename=rbDiff_File --repository-url=https://
subversion.lan/dev --bugs-closed= --
summary=file.ending/.otherending@revision --description="asdf" --
server=http://reviewboard.lan --username=admin --publish --debug
>>> RBTools 0.3.2
>>> Home = C:\Users\rstein.MR\AppData\Roaming
>>> svn info https://subversion.lan/dev
>>> diff --version
>>> repository info: Path: https://subversion.lan/dev, Base path: /, Suppor
ts changesets: False
>>> HTTP GETting api/
==> HTTP Authentication Required
Enter authorization information for "Web API" at reviewboard.fme.lan
Password:
>>> HTTP GETting http://reviewboard.lan/api/info/
>>> Using the new web API
>>> HTTP GETting http://reviewboard.lan/api/repositories/
>>> HTTP GETting http://reviewboard.lan/api/repositories/1/
>>> HTTP GETting http://reviewboard.lan/api/repositories/1/info/
>>> HTTP GETting http://reviewboard.lan/api/repositories/2/
>>> HTTP GETting http://reviewboard.lan/api/repositories/2/info/
>>> repository info: Path: https://subversion.lan/dev, Base path: /, Suppor
ts changesets: False
>>> Attempting to create review request on https://subversion.lan/dev for N
one
>>> Submitting the review request as rstein
>>> HTTP POSTing to http://reviewboard.lan/api/review-requests/: {'submit_as
': 'rstein', 'repository': u'https://subversion.lan/dev'}
>>> Review request created
>>> Attempting to set field 'target_people' to 'targetuser' for review request
'127'
>>> HTTP PUTting to http://reviewboard.lan/api/review-requests/127/draft/: {
'target_people': 'admin,rstein'}
>>> Attempting to set field 'summary' to 'file.ending/.otherending@revision' f
or review request '127'
>>> HTTP PUTting to http://reviewboard.lan/api/review-requests/127/draft/: {
'summary': 'file.ending/.otherending@revision'}
>>> Attempting to set field 'description' to 'asdf' for review request '127'
>>> HTTP PUTting to http://reviewboard.fme.lan/api/review-requests/127/draft/: {
'description': 'asdf'}
>>> Uploading diff, size: 2838
>>> HTTP POSTing to http://reviewboard.lan/api/review-requests/127/diffs/: {
'basedir': '/'}
>>> Publishing
>>> HTTP PUTting to http://reviewboard.lan/api/review-requests/127/draft/: {
'public': 1}
Review request #127 posted.
http://reviewboard.lan/r/127/ C:\Prompt>post-review --submit-as=username --target-groups= --target-
people=targetuser --diff-filename=rbDiff_File --repository-url=https://
subversion.lan/dev --bugs-closed= --
summary=file.ending/.otherending@revision --description="asdf" --
server=http://reviewboard.lan --username=dummyUser --
password=DummyPasswd --publish --debug
>>> RBTools 0.3.2
>>> Home = C:\Prompt
>>> svn info https://suversion.landev
>>> diff --version
>>> repository info: Path: https://su
Re: post-review from windows fails
On 15.03.2011, at 21:46, Christian Hammond wrote:
> Are you behind a proxy server? If so, it's possible that post-review is
> picking up the proxy settings on Windows, and it's preventing it from
> accessing the site correctly.
No, I am not behind a proxy server.
> With 0.3.2, can you run with --debug and provide the output?
The output is attached as "debug_output_rbtools_0.3.2.txt"
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=enC:\Prompt>post-review --submit-as=username --target-groups= --target-
people=targetuser --diff-filename=rbDiff_File --repository-url=https://
subversion.lan/dev --bugs-closed= --
summary=file.ending/.otherending@revision --description="asdf" --
server=http://reviewboard.lan --username=dummyUser --
password=DummyPasswd --publish --debug
>>> RBTools 0.3.2
>>> Home = C:\Prompt
>>> svn info https://subversion/dev
>>> diff --version
>>> repository info: Path: https://subversion/dev, Base path: /, Suppor
ts changesets: False
>>> HTTP GETting api/
>>> HTTP GETting http://reviewboard.lan/api/info/
>>> Got API Error 103 (HTTP code 401): You are not logged in
>>> Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not logged in', u'
code': 103}}
Unable to access the root /api/ URL on the server.
I can report some details concerning the problem:
1. While playing around with the login problems I found out, that
allowing anonymous read access brings post-review some steps further,
but then again it stops asking for Web-API credentials although user
name and password were provided via command line. See
"debug_output_anonymous_read.txt" for the output.
C:\Prompt>post-review --submit-as=username --target-groups= --target-
people=targetuser --diff-filename=rbDiff_File --repository-url=https://
subversion.lan/dev --bugs-closed= --
summary=file.ending/.otherending@revision --description="asdf" --
server=http://reviewboard.lan --username=dummyUser --
password=DummyPasswd --publish --debug
>>> RBTools 0.3.2
>>> Home = C:\Prompt
>>> svn info https://suversion.landev
>>> diff --version
>>> repository info: Path: https://suversion.lan/dev, Base path: /, Suppor
ts changesets: False
>>> HTTP GETting api/
>>> HTTP GETting http://reviewboard.lan/api/info/
>>> Using the new web API
>>> HTTP GETting http://reviewboard.lan/api/repositories/
>>> HTTP GETting http://reviewboard.lan/api/repositories/1/
>>> HTTP GETting http://reviewboard.lan/api/repositories/1/info/
>>> HTTP GETting http://reviewboard.lan/api/repositories/2/
>>> HTTP GETting http://reviewboard.lan/api/repositories/2/info/
>>> repository info: Path: https://suversion.lan/dev, Base path: /, Suppor
ts changesets: False
>>> Attempting to create review request on https://subversion.lan/dev for N
one
>>> Submitting the review request as rstein
>>> HTTP POSTing to http://reviewboard.lan/api/review-requests/: {'submit_as
': 'rstein', 'repository': u'https://subversion.lan/dev'}
>>> Got API Error 103 (HTTP code 401): You are not logged in
>>> Error data: {u'stat': u'fail', u'err': {u'msg': u'You are not logged in', u'
code': 103}}
>>> Attempting to create review request on https://subversion.lan/dev for N
one
>>> Submitting the review request as rstein
>>> HTTP POSTing to http://reviewboard.lan/api/review-requests/: {'submit_as
': 'username', 'repository': u'https://subversion/dev'}
==> HTTP Authentication Required
Enter authorization information for "Web API" at reviewboard.lan
Username: username
Password:
2. The behavior of post-review 0.2 on osx does not differ from the one
on windows, that was wrong. The difference resulted from the fact,
that I had a valid cookie in my ".postreview-cookies.txt" on osx. As
soon as I copy that cookie to the windows machine, I can authenticate
there as well.
3. With the valid cookie in my .postreview-cookies.txt file it seems
to to ignore any credentials on the command line. I start pushing a
diff-file with a --username= argument, but without password. post-
review then prompts for a password, as expected. But no matter what I
type there, the operation will always succeed due to the cookie. Does
review-board use the cookie as fallback authentication method if the
password is false? I would expect the operation to fail if I provide a
specific user name and an invalid password is typed. Maybe this is
related to this older bug:
http://code.google.com/p/reviewboard/issues/detail?id=762
See "debug_output_withoutcookie.txt" for an example.
C:\Prompt>post-review --submit-as=username --target-groups= --target-
people=targetuser --diff-filename=rbDiff_File --repository-url=https://
subversion.lan/dev --bugs-closed= --
summary=file.ending/.otherending@revision --description=
Re: post-review from windows fails
Hi Ruben,
Are you behind a proxy server? If so, it's possible that post-review is
picking up the proxy settings on Windows, and it's preventing it from
accessing the site correctly.
With 0.3.2, can you run with --debug and provide the output?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, Mar 15, 2011 at 2:22 AM, rstm wrote:
> Hello,
>
> Until now I used post-review (RBTools 0.2) from my mac and I can push
> diffs without any trouble to a ReviewBoard 1.5.2. Now I started using
> a Windows client and get strange errors when trying to push a diff.
>
> RBTools 0.3.2:
> I cannot push a diff, I just get the following error message.
> "Unable to access the root /api/ URL on the server."
>
> Surfing to the /api/ folder of my server brings up the expected xml-
> tree. Everything seems fine.
>
> RBTools 0.2:
> Using RBTools 0.2 I get the behavior described in the following post.
>
> http://groups.google.com/group/reviewboard/browse_thread/thread/e9173d6c45648366/aeb8404f789b6de0#aeb8404f789b6de0
>
> Post-Review keeps asking a second time for credentials to the "Web
> API". See the typed command:
> C:\Users\rstein>post-review --submit-as=rstein --diff-
> filename=rbDiff_File --repository-url="https://subversion/dev
> " --server=http://reviewboard.lan --username=cmdlineusr --
> password=DummyPasswd
> ==> Review Board Login Required
> Enter username and password for Review Board at
> http://reviewboard.fme.lan/
> ==> HTTP Authentication Required
> Enter username and password for "Web API" at reviewboard.fme.lan
> Username:
>
> After supplying also the credentials for the Web-API, post-review
> generates a huge error message and dies in recursion like described
> here:
>
> http://groups.google.com/group/reviewboard/browse_thread/thread/c8c20bda63270613/8e8bd93e0ea9dbf9?#8e8bd93e0ea9dbf9
>
> The error message is the following. The part from "line 297 in open"
> repeats all the time:
> Username: Exception RuntimeError: 'maximum recursion depth exceeded in
> __subclasscheck__' in ignored
> Traceback (most recent call last):
> File "C:\Python26\Scripts\post-review-script.py", line 8, in
>
>load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')
> ()
> File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools
> \postreview.py", line 2857, in main
> File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools
> \postreview.py", line 346, in login
> File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools
> \postreview.py", line 648, in api_post
> File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools
> \postreview.py", line 628, in http_post
> File "C:\Python26\lib\urllib2.py", line 126, in urlopen
>return _opener.open(url, data, timeout)
> ...
>
> File "C:\Python26\lib\urllib2.py", line 397, in open
> response = meth(req, response)
> File "C:\Python26\lib\urllib2.py", line 510, in http_response
> 'http', request, response, code, msg, hdrs)
> File "C:\Python26\lib\urllib2.py", line 429, in error
> result = self._call_chain(*args)
> File "C:\Python26\lib\urllib2.py", line 369, in _call_chain
> result = func(*args)
> File "C:\Python26\lib\urllib2.py", line 855, in http_error_401
> url, req, headers)
> File "C:\Python26\lib\urllib2.py", line 833, in http_error_auth_reqed
> return self.retry_http_basic_auth(host, req, realm)
> File "C:\Python26\lib\urllib2.py", line 843, in retry_http_basic_auth
> return self.parent.open(req, timeout=req.timeout)
> ...
>
> File "C:\Python26\lib\urllib2.py", line 391, in open
>response = self._open(req, data)
> File "C:\Python26\lib\urllib2.py", line 409, in _open
>'_open', req)
> File "C:\Python26\lib\urllib2.py", line 369, in _call_chain
>result = func(*args)
> File "C:\Python26\lib\urllib2.py", line 1161, in http_open
>return self.do_open(httplib.HTTPConnection, req)
> File "C:\Python26\lib\urllib2.py", line 1133, in do_open
>h.request(req.get_method(), req.get_selector(), req.data, headers)
> File "C:\Python26\lib\httplib.py", line 910, in request
>self._send_request(method, url, body, headers)
> File "C:\Python26\lib\httplib.py", line 947, in _send_request
>self.endheaders()
> File "C:\Python26\lib\httplib.py", line 904, in endheaders
>self._send_output()
> File "C:\Python26\lib\httplib.py", line 776, in _send_output
>self.send(msg)
> File "C:\Python26\lib\httplib.py", line 735, in send
>self.connect()
> File "C:\Python26\lib\httplib.py", line 716, in connect
>self.timeout)
> File "C:\Python26\lib\socket.py", line 504, in create_connection
>sock = socket(af, socktype, proto)
> RuntimeError: maximum recursion depth exceeded
>
> The person in this thread speaks of a solution which is not described.
> Christian Hammond also speaks of a mod_wsgi module setting in the
> apache configuration. This is not applicable in my case, since I use
> fastcgi. The mod_wsg
post-review from windows fails
Hello,
Until now I used post-review (RBTools 0.2) from my mac and I can push
diffs without any trouble to a ReviewBoard 1.5.2. Now I started using
a Windows client and get strange errors when trying to push a diff.
RBTools 0.3.2:
I cannot push a diff, I just get the following error message.
"Unable to access the root /api/ URL on the server."
Surfing to the /api/ folder of my server brings up the expected xml-
tree. Everything seems fine.
RBTools 0.2:
Using RBTools 0.2 I get the behavior described in the following post.
http://groups.google.com/group/reviewboard/browse_thread/thread/e9173d6c45648366/aeb8404f789b6de0#aeb8404f789b6de0
Post-Review keeps asking a second time for credentials to the "Web
API". See the typed command:
C:\Users\rstein>post-review --submit-as=rstein --diff-
filename=rbDiff_File --repository-url="https://subversion/dev
" --server=http://reviewboard.lan --username=cmdlineusr --
password=DummyPasswd
==> Review Board Login Required
Enter username and password for Review Board at http://reviewboard.fme.lan/
==> HTTP Authentication Required
Enter username and password for "Web API" at reviewboard.fme.lan
Username:
After supplying also the credentials for the Web-API, post-review
generates a huge error message and dies in recursion like described
here:
http://groups.google.com/group/reviewboard/browse_thread/thread/c8c20bda63270613/8e8bd93e0ea9dbf9?#8e8bd93e0ea9dbf9
The error message is the following. The part from "line 297 in open"
repeats all the time:
Username: Exception RuntimeError: 'maximum recursion depth exceeded in
__subclasscheck__' in ignored
Traceback (most recent call last):
File "C:\Python26\Scripts\post-review-script.py", line 8, in
load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')
()
File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools
\postreview.py", line 2857, in main
File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools
\postreview.py", line 346, in login
File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools
\postreview.py", line 648, in api_post
File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools
\postreview.py", line 628, in http_post
File "C:\Python26\lib\urllib2.py", line 126, in urlopen
return _opener.open(url, data, timeout)
...
File "C:\Python26\lib\urllib2.py", line 397, in open
response = meth(req, response)
File "C:\Python26\lib\urllib2.py", line 510, in http_response
'http', request, response, code, msg, hdrs)
File "C:\Python26\lib\urllib2.py", line 429, in error
result = self._call_chain(*args)
File "C:\Python26\lib\urllib2.py", line 369, in _call_chain
result = func(*args)
File "C:\Python26\lib\urllib2.py", line 855, in http_error_401
url, req, headers)
File "C:\Python26\lib\urllib2.py", line 833, in http_error_auth_reqed
return self.retry_http_basic_auth(host, req, realm)
File "C:\Python26\lib\urllib2.py", line 843, in retry_http_basic_auth
return self.parent.open(req, timeout=req.timeout)
...
File "C:\Python26\lib\urllib2.py", line 391, in open
response = self._open(req, data)
File "C:\Python26\lib\urllib2.py", line 409, in _open
'_open', req)
File "C:\Python26\lib\urllib2.py", line 369, in _call_chain
result = func(*args)
File "C:\Python26\lib\urllib2.py", line 1161, in http_open
return self.do_open(httplib.HTTPConnection, req)
File "C:\Python26\lib\urllib2.py", line 1133, in do_open
h.request(req.get_method(), req.get_selector(), req.data, headers)
File "C:\Python26\lib\httplib.py", line 910, in request
self._send_request(method, url, body, headers)
File "C:\Python26\lib\httplib.py", line 947, in _send_request
self.endheaders()
File "C:\Python26\lib\httplib.py", line 904, in endheaders
self._send_output()
File "C:\Python26\lib\httplib.py", line 776, in _send_output
self.send(msg)
File "C:\Python26\lib\httplib.py", line 735, in send
self.connect()
File "C:\Python26\lib\httplib.py", line 716, in connect
self.timeout)
File "C:\Python26\lib\socket.py", line 504, in create_connection
sock = socket(af, socktype, proto)
RuntimeError: maximum recursion depth exceeded
The person in this thread speaks of a solution which is not described.
Christian Hammond also speaks of a mod_wsgi module setting in the
apache configuration. This is not applicable in my case, since I use
fastcgi. The mod_wsgi is not enabled on the server, as I understand
it.
After this I updated my Site to ReviewBoard 1.5.4, which does not
solve any of the described problems. I am confused, as the same
command on my osx machine passes without any problems.
Regards, Ruben
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
