Re: Issue 1166 in reviewboard: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client
Comment #10 on issue 1166 by trowb...@gmail.com: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client http://code.google.com/p/reviewboard/issues/detail?id=1166 Issue 1743 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1743 in reviewboard: Weired Error occurred when the file has windows endline charactor.
Updates: Status: Duplicate Mergedinto: 1166 Comment #1 on issue 1743 by trowb...@gmail.com: Weired Error occurred when the file has windows endline charactor. http://code.google.com/p/reviewboard/issues/detail?id=1743 Fundamentally the same as 1166. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1819 in reviewboard: Drop down list of groups to easily do
Updates: Status: WontFix Comment #2 on issue 1819 by trowb...@gmail.com: Drop down list of groups to easily do http://code.google.com/p/reviewboard/issues/detail?id=1819 I don't want to make any changes to this UI for now. If we hear more requests of this nature, we can look at this again. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1914 in reviewboard: review board didn't send mails by local mail server which is postfix
Updates: Status: NeedInfo Comment #2 on issue 1914 by trowb...@gmail.com: review board didn't send mails by local mail server which is postfix http://code.google.com/p/reviewboard/issues/detail?id=1914 Are you getting any errors in the reviewboard or web server logs? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1916 in reviewboard: Error trying to get diffs for reviews in a review request
Updates: Status: SetupIssue Comment #3 on issue 1916 by trowb...@gmail.com: Error trying to get diffs for reviews in a review request http://code.google.com/p/reviewboard/issues/detail?id=1916 This was due to needing to reset the cache. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1936 in reviewboard: Ability to submit changes to the repository
Updates: Status: WontFix Comment #1 on issue 1936 by trowb...@gmail.com: Ability to submit changes to the repository http://code.google.com/p/reviewboard/issues/detail?id=1936 This isn't something which we can reliably provide, given the vast choices of configuration, permissions, deployment, etc. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1949 in reviewboard: RBtools intermittently not submitting review requests.
Comment #3 on issue 1949 by trowb...@gmail.com: RBtools intermittently not submitting review requests. http://code.google.com/p/reviewboard/issues/detail?id=1949 Can you dig into the python code, or log the HTTP accesses? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1953 in reviewboard: Addressing comments on View Diff page is not usable
Updates: Status: Duplicate Mergedinto: 1070 Comment #5 on issue 1953 by trowb...@gmail.com: Addressing comments on View Diff page is not usable http://code.google.com/p/reviewboard/issues/detail?id=1953 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1070 in reviewboard: Multiple comments made on View diff page and same line of code are treated as seperate reviews on View Reviews page
Comment #2 on issue 1070 by trowb...@gmail.com: Multiple comments made on View diff page and same line of code are treated as seperate reviews on View Reviews page http://code.google.com/p/reviewboard/issues/detail?id=1070 Issue 1953 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1949 in reviewboard: RBtools intermittently not submitting review requests.
Comment #4 on issue 1949 by mail.ax...@gmail.com: RBtools intermittently not submitting review requests. http://code.google.com/p/reviewboard/issues/detail?id=1949 I've done so and am waiting for the error to be logged. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2015 in reviewboard: Setting blank=True in a JSONField results in an exception
Updates: Status: Fixed Comment #1 on issue 2015 by trowb...@gmail.com: Setting blank=True in a JSONField results in an exception http://code.google.com/p/reviewboard/issues/detail?id=2015 Fixed in djblets master rev b3f1e26. Thanks! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2022 in reviewboard: missing hint/check regarding django $db module
Updates: Status: WontFix Comment #1 on issue 2022 by trowb...@gmail.com: missing hint/check regarding django $db module http://code.google.com/p/reviewboard/issues/detail?id=2022 This is very specific to ALT Linux's packaging of django, and does not occur if you install it via easy_install. I don't think ALT Linux is common enough for us to feature specialized instructions in the manual. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2007 in reviewboard: error uploading diff with post-review 0.3.2 (path resolution fail)
Updates: Status: WontFix Comment #3 on issue 2007 by trowb...@gmail.com: error uploading diff with post-review 0.3.2 (path resolution fail) http://code.google.com/p/reviewboard/issues/detail?id=2007 I don't think we need to add yet another special argument to post-review for this. I'd suggest either use post-review to post your in-progress changes, or with a revision range, or use the web UI to submit the diffs, but wanting to use post review inside an svn repository with a diff file is a pretty unusual use case. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2028 in reviewboard: Allow other users to post new diff revisions
Updates: Status: WontFix Comment #1 on issue 2028 by trowb...@gmail.com: Allow other users to post new diff revisions http://code.google.com/p/reviewboard/issues/detail?id=2028 For now, I suggest running multiple review requests in parallel. If we decide to enable this, it will require some pretty major changes, and we need to have a lot of discussions about security and UI first. I'm going to close this for now and if we hear more requests for it we can revisit this decision. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1466 in reviewboard: Support for Mercurial --git diffs
Updates: Status: Fixed Comment #3 on issue 1466 by trowb...@gmail.com: Support for Mercurial --git diffs http://code.google.com/p/reviewboard/issues/detail?id=1466 Fixed in master as 044afe1. Note that the uploaded diff files must include the Node ID and Parent headers as generated by hg export. This is the only way ReviewBoard can know the original and new changeset IDs. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2022 in reviewboard: missing hint/check regarding django $db module
Comment #2 on issue 2022 by shigo...@gmail.com: missing hint/check regarding django $db module http://code.google.com/p/reviewboard/issues/detail?id=2022 OK -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2042 in reviewboard: Allow to postreview read a patch from stdin intead of file
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2042 by xaka2...@gmail.com: Allow to postreview read a patch from stdin intead of file http://code.google.com/p/reviewboard/issues/detail?id=2042 *NOTE: If you have a patch, please submit it to http://reviews.reviewboard.org/ What version are you running? RBTools 0.3.2 What's the URL of the page this enhancement relates to, if any? N/A Describe the enhancement and the motivation for it. At the moment postreview has --diff-filename option which allows you specify path to file with a patch. It would be good to use (as it's common way) - as path so postreview will read the data from stdin. In many cases it makes life easier because you can use pipes and so on. Also it would be good to have short alias for --diff-filename. What operating system are you using? What browser? N/A Please provide any additional information below. N/A -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2043 in reviewboard: Using reviewboard without a repository - only upload a diff file
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2043 by nicolas@gmail.com: Using reviewboard without a repository - only upload a diff file http://code.google.com/p/reviewboard/issues/detail?id=2043 What version are you running? 1.5.2 What's the URL of the page this enhancement relates to, if any? Describe the enhancement and the motivation for it. We currently use mercurial and SVN (legacy) as our reposirories. Most of the time, this works 100%. There are some cases with mercurial when we would like to review a patch (diff) but the parents are not on the server. In theory, using the parent diff could solve the problem, but it happened a few times when the changes and merges made it too complicated for some of the end users to generate the parent patch. Therefore, in those case, even if we lose a few features (like the code expansion over the 3 lines given in the diff), we would like to be able to create a review with only the patch file, and no link to the repository behind. What operating system are you using? What browser? Windows, Chrome (and others, depending on our users). Please provide any additional information below. We are open to alternative solutions, among others, if we could serve our local repo for a few moments, while the review is being created, this would help go around the problem. Thanks! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2044 in reviewboard: Add support in post-review for perforce shelved changelist
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2044 by cyril.bo...@koinzmedia.com: Add support in post-review for perforce shelved changelist http://code.google.com/p/reviewboard/issues/detail?id=2044 Perforce has a new feature to shelve open changelists on the server side for review. See http://www.perforce.com/perforce/doc.current/manuals/cmdref/shelve.html Unfortunately, RB v1.5.4 post-review does not seem able to pull diffs from such changelists until they're committed. It'd be really useful if RB added support to diff shelved files in pending changelists, so reviews could be performed before the code is checked-in the shared repository. Files that have been shelved can be accessed with the p4 diff, p4 diff2, p4 files, and p4 print commands, using the revision specifier @=change, where change is the pending changelist number, so this may be a fairly small enhancement? Thank you for the great work on this project! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2042 in reviewboard: Allow to postreview read a patch from stdin intead of file
Updates: Status: NotABug Comment #1 on issue 2042 by trowb...@gmail.com: Allow to postreview read a patch from stdin intead of file http://code.google.com/p/reviewboard/issues/detail?id=2042 post-review already supports --diff-filename=- -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2045 in reviewboard: Show changes to description or testing done fields as a real diff
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2045 by sbress...@gmail.com: Show changes to description or testing done fields as a real diff http://code.google.com/p/reviewboard/issues/detail?id=2045 *NOTE: If you have a patch, please submit it to http://reviews.reviewboard.org/ What version are you running? 1.5RC What's the URL of the page this enhancement relates to, if any? Describe the enhancement and the motivation for it. Review Board is already so great at showing diffs. However, they're not shown in one place where they ought to, thus enhancing the customer experience: Currently, when the Description or Testing Done sections are changed, the change notated in the review just shows the old text followed by the next text. The changes should actual be shown as a diff. What operating system are you using? What browser? Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2045 in reviewboard: Show changes to description or testing done fields as a real diff
Updates: Status: Confirmed Labels: Component-Reviews Comment #1 on issue 2045 by chip...@gmail.com: Show changes to description or testing done fields as a real diff http://code.google.com/p/reviewboard/issues/detail?id=2045 I've definitely thought about this and would be happy to have it. Maybe not show as a real diff but like So and so added to the description: [snip] blah Or whatever. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
