Issue 2046 in reviewboard: post-review always use a proxy even for local network
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2046 by sebastie...@googlemail.com: post-review always use a proxy even for local network http://code.google.com/p/reviewboard/issues/detail?id=2046 What version are you running? RBTools 0.3.2 What's the URL of the page containing the problem? NA What steps will reproduce the problem? 1. In Windows XP, configure proxy using environment variable http_proxy 2. Use post-review with subversion local repository to create a review in localhost reviewboard. 3. post-review uses proxy whereas reviewboard is on localhost. What is the expected output? What do you see instead? It should be possible to deactivate proxy using a command line switch --no-proxy for example. What operating system are you using? What browser? Windows XP, FF4. Please provide any additional information below. I hacked postreview.py by saying urllib2 top not use proxy and this fixed the problem. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1426 in reviewboard: The reply button is not working
Comment #6 on issue 1426 by jira.s...@gmail.com: The reply button is not working http://code.google.com/p/reviewboard/issues/detail?id=1426 I can reproduce this in RB 1.6 beta. OS: Mac OS Browser: Firefox 3.6.13 URL: http://sitedir/r/###/diff Steps: 1. Look at a review request 2. Select view diff 3. Click somewhere on the diff to comment save it 4. Click on the previous comment area 5. Select reply from the comment's pop-up -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2047 in reviewboard: UnicodeDecodeError: 'utf8' codec can't decode byte
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2047 by m.milbr...@gmail.com: UnicodeDecodeError: 'utf8' codec can't decode byte http://code.google.com/p/reviewboard/issues/detail?id=2047 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.5.4.1 What's the URL of the page containing the problem? https://server/api/json/reviewrequests/217417/update_from_changenum/: What steps will reproduce the problem? 1. On Windows or OSX add a typographical double quote to the Perforce description of the CLN you are attempting to post ( e.g. on windows Alt + 0147 ). 2. post the review using post-review CLN What is the expected output? What do you see instead? Expected to post a review, but get error message User Message html xmlns=http://www.w3.org/1999/xhtml; xml:lang=en lang=en head title500 - Internal Server Error | Review Board/title /head body h1Something broke! (Error 500)/h1 p It appears something broke when you tried to go to here. This is either a bug in Review Board or a server configuration error. Please report this to your administrator. /p /body /title Server Message: File /build/toolchain/lin32/python-2.6.1/lib/python2.6/json/encoder.py, line 294, in _iterencode yield encoder(o) UnicodeDecodeError: 'utf8' codec can't decode byte 0x93 in position 0: unexpected code byte What operating system are you using? What browser? Centos 5.5 x86_64 Please provide any additional information below. From what I can tell by default Windows and OSx will encode these type of characters as ASCII using one byte. The Django framework will attempt to decode these using utf-8 but fails because not encoded as expected. This primarily appears to have when users have these type of characters within the change description on Perforce. It appears potentially that scmtool/perforce.py could be patched to replace these characters within function parse_change_desc ( e.g. str.decode('utf-8', 'replace'). Haven't given it much thought yet in case there are any side-effects to this but at least the review appears to be successfully posted. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1949 in reviewboard: RBtools intermittently not submitting review requests.
Comment #5 on issue 1949 by mail.ax...@gmail.com: RBtools intermittently not submitting review requests. http://code.google.com/p/reviewboard/issues/detail?id=1949 My python's not up to scratch so I'm not able to see the exception message using the following code try: rsp = urllib2.urlopen(url).read() except: e = sys.exc_info()[1] debug('Error occured %s' % str(e)) raise e The url call does however not get to my apache server. I see the call to /api/json/repositories/ but nothing after that. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2048 in reviewboard: Disable automatic user creation if authenticated through ldap
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2048 by pablo...@gmail.com: Disable automatic user creation if authenticated through ldap http://code.google.com/p/reviewboard/issues/detail?id=2048 We would like to have different reviewboard sites for different projects, each one administered by a one member of the project. We need to authenticate all users through LDAP, but let the site administrator decide who will be able to access his reviewboard site. Current implementation (1.5.2) automatically creates the user from the ldap information after the user is successfully authenticated. It would be nice to make this user creation optional. Here is the thread in google groups with this subject: https://groups.google.com/d/topic/reviewboard/AgzdVmgMdFo/discussion -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.