Re: Issue 2134 in reviewboard: Diff breaks the review board.
Updates: Status: NeedInfo Comment #1 on issue 2134 by trowb...@gmail.com: Diff breaks the review board. http://code.google.com/p/reviewboard/issues/detail?id=2134 How did you create your diff? How did you create the review request? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2135 in reviewboard: clearcase.py failing on CentOS 5 (Python 2.4)
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2135 by yos...@hotmail.com: clearcase.py failing on CentOS 5 (Python 2.4) http://code.google.com/p/reviewboard/issues/detail?id=2135 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.6beta2 What's the URL of the page containing the problem? Anything that calls clearcase.py via /r/new with a clearcase diff What steps will reproduce the problem? 1. Create a clearcase review request with diff uploaded using RBtools 2. Must have Python 2.4 on the server (CentOS 5) What is the expected output? What do you see instead? Expect to see diff uploaded. Failed with the following error: Traceback (most recent call last): File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/core/handlers/base.py", line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File "/usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/djblets/auth/util.py", line 46, in _checklogin return view_func(request, *args, **kwargs) File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1-py2.4.egg/reviewboard/reviews/views.py", line 248, in new_review_request local_site=local_site) File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1-py2.4.egg/reviewboard/reviews/forms.py", line 234, in create attach_to_history=True) File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1-py2.4.egg/reviewboard/reviews/forms.py", line 286, in create history) File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1-py2.4.egg/reviewboard/diffviewer/forms.py", line 62, in create files = list(self._process_files( File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1-py2.4.egg/reviewboard/diffviewer/forms.py", line 136, in _process_files for f in tool.get_parser(file.read()).parse(): File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1-py2.4.egg/reviewboard/diffviewer/parser.py", line 49, in parse next_linenum, new_file = self.parse_change_header(i) File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1-py2.4.egg/reviewboard/diffviewer/parser.py", line 75, in parse_change_header linenum = self.parse_diff_header(linenum, info) File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1-py2.4.egg/reviewboard/scmtools/clearcase.py", line 206, in parse_diff_header info['origFile'] = self._oid2filename(m.group(1)) File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1-py2.4.egg/reviewboard/scmtools/clearcase.py", line 245, in _oid2filename return os.path.relpath(res, self.repopath) AttributeError: 'module' object has no attribute 'relpath' What operating system are you using? What browser? CentOS 5 Please provide any additional information below. This is due to Python 2.4 not supporting the relpath method However, the admin page for RB 1.6beta2 says 2.4 is supported: “It’s also assumed that you have Python v2.4 or v2.5 installed” http://www.reviewboard.org/docs/manual/dev/admin/installation/linux/ -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2134 in reviewboard: Diff breaks the review board.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2134 by codena...@gmail.com: Diff breaks the review board. http://code.google.com/p/reviewboard/issues/detail?id=2134 What version are you running? N/A What's the URL of the page containing the problem? https://svn.reviewboard.kde.org/r/6689/diff/3/ What steps will reproduce the problem? 1. Go to https://svn.reviewboard.kde.org/r/6689/diff/3/ What is the expected output? What do you see instead? I expect to see the diff. I get: Traceback (most recent call last): File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.5-py2.6.egg/reviewboard/diffviewer/views.py", line 153, in view_diff interdiffset, highlighting, True) File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.5-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 1066, in get_diff_files large_data=True) File "/usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/djblets/util/misc.py", line 166, in cache_memoize data = lookup_callable() File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.5-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 1065, in enable_syntax_highlighting)), File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.5-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 552, in get_chunks new = get_patched_file(old, filediff) File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.5-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 374, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.5-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 242, in patch (filename, tempdir, patch_output)) Exception: The patch to 'trunk/KDE/kdeutils/ark/app/ark_servicemenu.desktop' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.1xqXh3' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.1xqXh3/tmppbNYUg patch: unexpected end of file in patch What operating system are you using? What browser? Fedora 15, Firefox 4.0.1 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2101 in reviewboard: Files changed links don't work with Google Chrome 12.0.742.53
Comment #4 on issue 2101 by mattginz...@gmail.com: Files changed links don't work with Google Chrome 12.0.742.53 http://code.google.com/p/reviewboard/issues/detail?id=2101 Thanks. Do you have a bug link at chrome/chromium to reference? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2101 in reviewboard: Files changed links don't work with Google Chrome 12.0.742.53
Comment #3 on issue 2101 by lauren...@gmail.com: Files changed links don't work with Google Chrome 12.0.742.53 http://code.google.com/p/reviewboard/issues/detail?id=2101 Version 13.0.782.13 in the dev channel fixes this I usually don't install those dev builds. Do you think it'll be in the regular beta build soon? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2133 in reviewboard: chrome 12 scrolls backwards in diff viewer
Updates: Status: Duplicate Mergedinto: 2101 Comment #2 on issue 2133 by trowb...@gmail.com: chrome 12 scrolls backwards in diff viewer http://code.google.com/p/reviewboard/issues/detail?id=2133 This is a bug in Chrome. If you update to the dev channel it's fixed. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2101 in reviewboard: Files changed links don't work with Google Chrome 12.0.742.53
Comment #2 on issue 2101 by trowb...@gmail.com: Files changed links don't work with Google Chrome 12.0.742.53 http://code.google.com/p/reviewboard/issues/detail?id=2101 Issue 2133 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2133 in reviewboard: chrome 12 scrolls backwards in diff viewer
Comment #1 on issue 2133 by mattginz...@gmail.com: chrome 12 scrolls backwards in diff viewer http://code.google.com/p/reviewboard/issues/detail?id=2133 I upgraded from Chrome 11 to 12 on another host (also Mac OS X 10.6.7) and see exactly the same result. Reproducible for me at least. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2133 in reviewboard: chrome 12 scrolls backwards in diff viewer
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2133 by mattginz...@gmail.com: chrome 12 scrolls backwards in diff viewer http://code.google.com/p/reviewboard/issues/detail?id=2133 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.5.5 What's the URL of the page containing the problem? https://reviewboard.eng.vmware.com/r/anything What steps will reproduce the problem? 1. Use Chrome 12 on Mac OS as your browser 2. navigate to a reviewboard diff 3. click on one of the index links (filename, or change within a file) 4. use comma and period to select next/prev change What is the expected output? What do you see instead? I expect to see the diff viewer scroll to the link I clicked on (step #3), then scroll up/down as necessary (step #4). Instead, step #3 doesn't scroll anywhere, and step #4 scrolls up with every keypress. This makes the diff viewer pretty much unusable. What operating system are you using? What browser? Mac OS X 10.6.7, Chrome 12.0.742.91. Please provide any additional information below. Since I just updated to Chrome 12 yesterday and never saw this behavior before, I suspect this might be a Chrome bug and not a reviewboard bug, but your team will be better than I am at finding why this happens and reporting to Chrome/chromium/webkit, and this affects reviewboard users, so I'm filing it here first. Using Firefox 4.0.1 on the same host I see no such problems. I haven't had the chance to try this on other hosts with Chrome 12 installed. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2132 in reviewboard: Add a "Contact Admin" link
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2132 by cwro...@comcast.net: Add a "Contact Admin" link http://code.google.com/p/reviewboard/issues/detail?id=2132 *NOTE: If you have a patch, please submit it to http://reviews.reviewboard.org/ What version are you running? 1.0 What's the URL of the page this enhancement relates to, if any? At least main page - perhaps all pages Describe the enhancement and the motivation for it. Would like to see a "Contact Admin" link so that users could contact their RB admin about local issues, such as discarding reviews for ex-employees. In a large company, it is not always known who the admin is for the user to address email to that person. What operating system are you using? What browser? Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
