Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #9 on issue 1235 by carl.van...@gmail.com: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 Ok, so I rediscovered that adding the #NoteID / #Parent Id to the git-diff patch allows reviewboard to get this needed info. Also found a reviewboard mercurial extension that does the same. I'll be making my own simple extension that just does the patch generation. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2252 in reviewboard: changes between r2 and 2 doesn't make sense
Updates: Status: NeedInfo Owner: chip...@gmail.com Comment #1 on issue 2252 by chip...@gmail.com: changes between r2 and 2 doesn't make sense http://code.google.com/p/reviewboard/issues/detail?id=2252 These are revisions of diffs on a review request, rather than revisions within the repository. This selector allows reviewers to see what changed between versions of a diff that you've uploaded. For example, if you put up a large change, then make some additional changes to it based on reviews, and update your diff, reviewers will be able to see just those changes you've made instead of having to re-read a large diff. The UI for the diff revisions selector will undergo a rewrite at some point, as its interaction is not great and is a hold-over from the very early days of Review Board. If you're on r2, you shouldn't actually be able to click r2. The style on it should indicate that it's selected as one end of the revision range. Is that not happening? Is it actually clickable? Does that clear things up? (Love the Humble Indie Bundle, btw.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2252 in reviewboard: changes between r2 and 2 doesn't make sense
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2252 by o...@humblebundle.com: changes between r2 and 2 doesn't make sense http://code.google.com/p/reviewboard/issues/detail?id=2252 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.5.5 What's the URL of the page containing the problem? Any review request with more than one diff revision What steps will reproduce the problem? View the main page for the given review What is the expected output? What do you see instead? I would expect to see: Diff revision 2 (Latest) Jump to revision: [1] [2] Changes between r2 and: [trunk] [1] This is what I see: Diff revision 2 (Latest) Jump to revision: [1] [2] Changes between r2 and: [1] [2] If I'm viewing revision 2, then I would expect to be able to see changes between trunk and r2 or changes between r1 and r2. Why is there a button for changes between r2 and r2? That doesn't make sense. What operating system are you using? What browser? Mac OS X 10.6.8, Chrome Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2251 in reviewboard: Login to SCM Server Failed
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2251 by unalm...@gmail.com: Login to SCM Server Failed http://code.google.com/p/reviewboard/issues/detail?id=2251 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.5.1 What's the URL of the page containing the problem? http://gpreview9300.houston.lgc.com/r/new/ What steps will reproduce the problem? 1.go to New Review Request 2.Enter repository, Base Directory, diff 3. click create new request to see the error What is the expected output? What do you see instead? Nees to provide a view to enter ther new request parameters Instead see ther error Login to the SCM server failed What operating system are you using? What browser? Windows 7 Please provide any additional information below. I am able to see the diff in the review requests sent to me by other. This error started occurring this morning. I was successfully using this tool for more than a month. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #8 on issue 1235 by carl.van...@gmail.com: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 The review I am trying has both rename and modifications so I don't think its the same issue. I see that thread mentions using 'hg export -g', which I wasn't doing. Note: the export in that thread appears to be for a single commit. We typically do reviews on a branch that is going to merge, having multiple commits. Thus I tried for example: 'hg export -g tip:50324 > merge-review.patch' Reviewboard won't even allow that resultant patch-file to be uploaded saying file of first change in the patch can't be found. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #7 on issue 1235 by shul...@gmail.com: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 there is still an issue with pure file rename in mercurial http://code.google.com/p/reviewboard/issues/detail?id=2184 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #6 on issue 1235 by carl.van...@gmail.com: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 Can you elaborate? Uploading a git-style patch generated by 'hg diff -g' causes exceptions when trying to view the diff. Uploading a standard diff doesn't get renames picked up. I'm running reviewboard "1.6 RC2" -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1066 in reviewboard: Show file status in diff (added, modified, deleted, renamed)
Comment #11 on issue 1066 by carl.van...@gmail.com: Show file status in diff (added, modified, deleted, renamed) http://code.google.com/p/reviewboard/issues/detail?id=1066 Mercurial also has rename tracking, and can provide git style diffs. This is one of our biggest wishlist items for Reviewbord-Mercurial support, the ability to show only that a file has been renamed, and the actual changes in that file. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
