Issue 2304 in reviewboard: [Page not found] after upgrade to 1.6.1

2011-09-23 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2304 by eddiehor...@gmail.com: [Page not found] after upgrade to  
1.6.1

http://code.google.com/p/reviewboard/issues/detail?id=2304

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
1.6.1

What's the URL of the page containing the problem?
http://mysite/p4reviewboard/

What steps will reproduce the problem?
1. install ReviewBoard 1.6.1
2. service apache2 restart
3. Browse http://mysite/p4reviewboard/, the page shows incorrect rb-site  
upgrade command: [rb-site upgrade  
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.1.dev-py2.7.egg/reviewboard/data]
4. I ran [rb-site upgrade  
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.1.dev-py2.7.egg/reviewboard/data]  
and then found this command maybe not correct, so I ran again upgrade  
command as previous upgrade: [rb-site upgrade /var/www/p4reviewboard]


What is the expected output? What do you see instead?
The problem is after I upgrade to 1.6.1, my review board always return 404  
Page not found to any of links to http://mysite/p4reviewboard/.

The error message:

Using the URLconf defined in djblets.util.rooturl, Django tried these URL  
patterns, in this order:


^ ^admin/
^ ^media/(?Ppath.*)$
^ ^account/
^ ^reports/
^ ^s/(?Plocal_site_name[A-Za-z0-9\-_.]+)/
^ ^$ [name='root']
^ ^api/
^ ^r/
^ ^dashboard/$ [name='dashboard']
^ ^users/$ [name='all-users']
^ ^users/(?Pusername[A-Za-z0-9@_\-\.]+)/$ [name='user']
^ ^users/(?Pusername[A-Za-z0-9@_\-\.]+)/infobox/$  
[name='user-infobox']

^ ^groups/$ [name='all-groups']
^ ^groups/(?Pname[A-Za-z0-9_-]+)/$ [name='group']
^ ^groups/(?Pname[A-Za-z0-9_-]+)/members/$ [name='group_members']
^ ^account/logout/$ [name='logout']

The current URL, p4reviewboard/, didn't match any of these.



What operating system are you using? What browser?
Ubuntu 11.4, Firefox, chrome

Please provide any additional information below.
I used to upgrade from 1.5 to 1.6 and everything was fine, but this time  
after upgrade to 1.6.1, my server is totally broken. Even I remove entire  
reviewboard folder (/var/www/p4reviewboard) and database and use rb-site  
install to install a new reviewboard, the problem still exist. I also  
rollback to 1.6 and the problem is still the same. It seems django somehow  
don't remember the location of mysite's installation path  
(/var/www/p4reviewboard) so the hint of rb-site upgrade [path] is not  
correct. I also checked my apache2 site-enabled configuration, it's correct  
as another workable server.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2304 in reviewboard: [Page not found] after upgrade to 1.6.1

2011-09-23 Thread reviewboard

Updates:
Owner: chip...@gmail.com
Labels: -Priority-Medium Priority-High Component-Deployment

Comment #1 on issue 2304 by chip...@gmail.com: [Page not found] after  
upgrade to 1.6.1

http://code.google.com/p/reviewboard/issues/detail?id=2304

Nothing significant changed between RB 1.6.0 and 1.6.1, so I wouldn't  
expect there to be a problem there. However, there was a Django 1.3.1  
security release, and perhaps something happened to break you.


I'm working to reproduce this here, and will update if I discover anything.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2304 in reviewboard: [Page not found] after upgrade to 1.6.1

2011-09-23 Thread reviewboard

Updates:
Status: NeedInfo

Comment #2 on issue 2304 by chip...@gmail.com: [Page not found] after  
upgrade to 1.6.1

http://code.google.com/p/reviewboard/issues/detail?id=2304

Try changing your Apache config so that ScriptAlias goes from:

WSGIScriptAlias /p4reviewboard/ /var/www/./reviewboard.wsgi

to:

 
WSGIScriptAlias /p4reviewboard /var/www/./reviewboard.wsgi/p4reviewboard


Let me know if that fixes it.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2155 in reviewboard: post-review fails to upload diff if non-ascii characters are used in diff

2011-09-23 Thread reviewboard


Comment #5 on issue 2155 by chip...@gmail.com: post-review fails to upload  
diff if non-ascii characters are used in diff

http://code.google.com/p/reviewboard/issues/detail?id=2155

Issue 2300 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2300 in reviewboard: RBTools 0.3.3 not work with python2.7

2011-09-23 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 2155

Comment #2 on issue 2300 by chip...@gmail.com: RBTools 0.3.3 not work with  
python2.7

http://code.google.com/p/reviewboard/issues/detail?id=2300

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2155 in reviewboard: post-review fails to upload diff if non-ascii characters are used in diff

2011-09-23 Thread reviewboard

Updates:
Status: Fixed
Owner: chip...@gmail.com
Labels: Milestone-RBTools-Release1.0 Component-RBTools

Comment #6 on issue 2155 by chip...@gmail.com: post-review fails to upload  
diff if non-ascii characters are used in diff

http://code.google.com/p/reviewboard/issues/detail?id=2155

Fixed on release-0.3.x (0fff56d)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2304 in reviewboard: [Page not found] after upgrade to 1.6.1

2011-09-23 Thread reviewboard


Comment #3 on issue 2304 by eddiehor...@gmail.com: [Page not found] after  
upgrade to 1.6.1

http://code.google.com/p/reviewboard/issues/detail?id=2304

Thanks your prompt response.
I'm using mod_python, and later now I found a workaround by set the site at  
host root direction (in conf, change to Location/).
Then I tried to install a new rb site using wsgi and followed your change,  
but same problem is still there.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2304 in reviewboard: [Page not found] after upgrade to 1.6.1

2011-09-23 Thread reviewboard


Comment #4 on issue 2304 by chip...@gmail.com: [Page not found] after  
upgrade to 1.6.1

http://code.google.com/p/reviewboard/issues/detail?id=2304

It's possible they changed something that broke mod_python in Django 1.3.1.  
For the heck of it, try downgrading Django to 1.3.0 and see if it fixes it.


Should be able to remove your existing Django 1.3.1 directory in Python's  
site-packages directory, and then install using:


sudo easy_install Django==1.3.0

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2304 in reviewboard: [Page not found] after upgrade to 1.6.1

2011-09-23 Thread reviewboard


Comment #5 on issue 2304 by eddiehor...@gmail.com: [Page not found] after  
upgrade to 1.6.1

http://code.google.com/p/reviewboard/issues/detail?id=2304

I removed Django 1.3.1 and installed 1.3, but still don't fix.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2177 in reviewboard: git branch is not used

2011-09-23 Thread reviewboard

Updates:
Status: Fixed

Comment #9 on issue 2177 by trowb...@gmail.com: git branch is not used
http://code.google.com/p/reviewboard/issues/detail?id=2177

Fixed in master (feeddca). Thanks!

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1227 in reviewboard: Data lost when resizing comment box in IE8

2011-09-23 Thread reviewboard

Updates:
Status: Fixed

Comment #2 on issue 1227 by trowb...@gmail.com: Data lost when resizing  
comment box in IE8

http://code.google.com/p/reviewboard/issues/detail?id=1227

I think this is fixed now.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2290 in reviewboard: Adding Group for review

2011-09-23 Thread reviewboard

Updates:
Status: NotABug

Comment #3 on issue 2290 by trowb...@gmail.com: Adding Group  for  review
http://code.google.com/p/reviewboard/issues/detail?id=2290

It is optional.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 489 in reviewboard: [ ] DON'T SHIP IT button

2011-09-23 Thread reviewboard


Comment #29 on issue 489 by mike.d.c...@gmail.com: [ ] DON'T SHIP IT button
http://code.google.com/p/reviewboard/issues/detail?id=489

How about instead of Ship It, Don't Ship It, we use +1 / 0 / -1?

Examples:

I've just finished reviewing some code, and I feel it's not exactly ready  
for the prime time.  I put in my final comments regarding the review  
request, and then give the review request a -1.  Back in the Dashboard  
(or while viewing the review request), I can see that the current revision  
for this review request has a field in the table showing: 0 / -1 meaning  
that there are no +1's, and a single -1.


Another reviewer has a different opinion, however, and after their review,  
they give a +1.  So now, in the Dashboard I see that the latest revision  
for this review request displays a score of +1 / -1.


A third reviewer comes in, and agrees with me, so now we see:

+1 / -2.

The reviewee modifies their review request.  A new revision is uploaded, so  
the score is now reset at 0 / 0.


Note that a reviewer can also mark a review with 0, in the event that  
they have


I know that there was some concern that this would turn into a vote.  I'm  
pretty sure the Ship It is already a vote though.  There's just no way to  
vote the other way.


Thoughts?

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1909 in reviewboard: Information passed from post-review to RB does not show up in draft

2011-09-23 Thread reviewboard

Updates:
Status: UserError

Comment #1 on issue 1909 by trowb...@gmail.com: Information passed from  
post-review to RB does not show up in draft

http://code.google.com/p/reviewboard/issues/detail?id=1909

The only way this can happen is if you're not logged in on the web UI...

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1722 in reviewboard: UTF-16 file from Perforce not displayed

2011-09-23 Thread reviewboard

Updates:
Status: New

Comment #5 on issue 1722 by trowb...@gmail.com: UTF-16 file from Perforce  
not displayed

http://code.google.com/p/reviewboard/issues/detail?id=1722

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.