Issue 2493 in reviewboard: LDAP authentication fails if anonymous search is not allowed by the LDAP server

2012-02-21 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2493 by o...@lindenlab.com: LDAP authentication fails if  
anonymous search is not allowed by the LDAP server

http://code.google.com/p/reviewboard/issues/detail?id=2493

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?

  1.6.3

What's the URL of the page containing the problem?

  https://code-review.lindenlab.com/account/login/

What steps will reproduce the problem?
1. Set up LDAP service to prohibit anonymous searches (require bind before  
the search)
2. Configure ReviewBoard to use LDAP user authentication, but leave  
the Anonymous User Mask and Anonymous User Password fields empty.

3. Attempt to log in using a valid username and password

What is the expected output? What do you see instead?

The login attempt should succeed; ReviewBoard should be able to bind using  
the offered credentials, and then do the search for the required user  
information.


Instead, the login attempt fails because ReviewBoard attempts to search for  
the uid without binding first.





--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1896 in reviewboard: Omitting the git repo path throws 500 error

2012-02-21 Thread reviewboard


Comment #12 on issue 1896 by vinaychi...@gmail.com: Omitting the git repo  
path throws 500 error

http://code.google.com/p/reviewboard/issues/detail?id=1896

We have set the git repo config as follows:

Method 1
-
Path: u...@mydomain.com:test/test1.git
Mirror Path: u...@mydomain.com:test/test1.git
Raw file URL mask: u...@mydomain.com:test/test1.git

Method 2
-
Path: u...@mydomain.com:test/test1
Mirror Path: u...@mydomain.com:test/test1
Raw file URL mask: u...@mydomain.com:test/test1


The repos got added successfully but when I post for review it throws the  
following error


Error creating review request: The repository path specified is not in the  
list of known repositories (code 206)


What might be the issue?/ Are we missing something?

Thanks.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion

2012-02-21 Thread reviewboard


Comment #7 on issue 1113 by jhuffa...@gmail.com: post-review tool cannot  
handle revisions with deleted files in Subversion

http://code.google.com/p/reviewboard/issues/detail?id=1113

I ran into this problem recently.  I understand that you have an  
established workflow but this is a nasty bug that cost more than a few of  
us time.  I don't know your code base, but was successfully (easily) able  
to port the files from above (0.2 to 0.3.4).


I'm going to attach my diff from 0.3.4, if you really need me to apply it  
to reviews.reviewboard.org I can, but it seems like you should be able to  
do it more quickly.  I really hope this gets incorporated into future  
versions as it is quite annoying.



Attachments:
postreview.py.diff  3.1 KB

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2494 in reviewboard: manually uploaded git diff-tree --cc produce 'diff file is empty'

2012-02-21 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2494 by elliot.w...@gmail.com: manually uploaded git diff-tree  
--cc produce 'diff file is empty'

http://code.google.com/p/reviewboard/issues/detail?id=2494

What version are you running?
bleeding edge, c848031b769cf84b8f9fe42430210459735fed11

What's the URL of the page containing the problem?
rbtools post-review

What steps will reproduce the problem?
1. generate a diff of a merge commit with --cc. {you can just do git show  
COMMIT --format=format:''  out.diff}

2. post-review it

What is the expected output?
the diff to be posted to reviewboard

What do you see instead?
git@source:~/repositories/repo.git$ post-review \
  --publish \
  --debug \
  --username=git \
  --password=git \
  --diff-filename=/tmp/diff_eaca7ff \
  --server=https://site.com/reviewboard; \
  --branch=master \
  --description=Merge branch 'feature' into master\nConflicts:\nsrc/file \
  --summary=eaca7ff (JAVA) Merge branch 'point/5.0.26' into develop \
  | tee -a post-review.log

Error uploading diff

The generated diff file was empty. This usually means no files were
modified in this change.

Try running with --output-diff and --debug for more information.


RBTools 0.4 alpha 0 (dev)
Home = /opt/git
HTTP GETting api/
HTTP GETting https://site.com/reviewboard/api/info/
Using the new web API
Attempting to create review request on /opt/git/repositories/repo.git  
for None
HTTP POSTing to https://site.com/reviewboard/api/review-requests/:  
{'repository': '/opt/git/repositories/repo.git'}

Review request created
Attempting to set field 'summary' to 'eaca7ff (JAVA) Merge  
branch 'point/5.0.26' into develop'
HTTP PUTting to  
https://site.com/reviewboard/api/review-requests/6953/draft/:  
{'summary': eaca7ff (JAVA) Merge branch 'point/5.0.26' into develop}

Attempting to set field 'branch' to 'master' for review request '6953'
HTTP PUTting to  
https://site.com/reviewboard/api/review-requests/6953/draft/:  
{'branch': 'master'}
Attempting to set field 'description' to 'Merge branch 'feature' into  
master\nConflicts:\nsrc/file'
HTTP PUTting to  
https://site.com/reviewboard/api/review-requests/6953/draft/:  
{'description': Merge branch 'feature' into  
master\nConflicts:\nsrc/file}

Uploading diff, size: 5873
HTTP POSTing to  
https://site.com/reviewboard/api/review-requests/6953/diffs/: {}

Got API Error 105 (HTTP code 400): One or more fields had errors
Error data: {u'fields': {u'path': [u'The diff file is empty']},  
u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors',  
u'code': 105}}

Your review request still exists, but the diff is not attached.

What operating system are you using? What browser?
centos/firefox

more info:
scrubbed a few things. note that the diff size is 5873 bytes, and that this  
works when the diff is any git diff aside from diff --cc.



--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2490 in reviewboard: After installation in Windows Server 2003, reviewboard can not run!!!

2012-02-21 Thread reviewboard


Comment #8 on issue 2490 by wojciech...@gmail.com: After installation in  
Windows Server 2003, reviewboard can not run!!!

http://code.google.com/p/reviewboard/issues/detail?id=2490

As the error message suggests (C:\MinGW\bin\gcc.exe) you're still somehow  
using MinGW version of GCC. The only thing I might suggest is  
double-checking that there're no typos in you Path. Also, make sure you  
really have GCC in your perl\bin. It might be that GCC gets there with one  
of the additional packages (I use Perl from time to time so I probably have  
a few of them) rather than the base installation.


I must stress that what I did was a clumsy (but quick for me) workaround  
rather than a real solution. If you really want to follow in my footsteps  
you might try running the perl package manager ('ppm' command that starts a  
small gui app) and look for mingw package (a barebones one: gcc+dmake and  
not much more) as it seems that Perl relies on the legacy GCC 3. I'm not  
sure but it *might* work. Google says 'ppm install MinGW' from the command  
line should do the job but I would run ppm gui app to make sure that there  
aren't more than one version of this package.


An alternative (and maybe better) solution could be to fix distutils Python  
module that unnecessarily adds this compiler switch. If you do a full text  
search for 'mno-cygwin' in the Python install directory you might even find  
a script that adds it but I haven't tried patching it.


Another option, MinGW itself has some legacy packages available but using  
them is slightly more involved because you need to be carefull not to mix  
and match the new and old ones e.g.  
http://mingw-users.1079350.n2.nabble.com/How-do-I-install-mingw-gcc-3-4-5-td5604746.html.



--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2490 in reviewboard: After installation in Windows Server 2003, reviewboard can not run!!!

2012-02-21 Thread reviewboard


Comment #9 on issue 2490 by bruce...@gmail.com: After installation in  
Windows Server 2003, reviewboard can not run!!!

http://code.google.com/p/reviewboard/issues/detail?id=2490

Thanks!!  I successfully build PyCrypto and re-install it.

BUT, the problem has still not resolved.


mod_wsgi (pid=3584): Exception occurred processing WSGI  
script 'E:/ReviewBoard/code/htdocs/reviewboard.wsgi'.
[Wed Feb 22 09:36:12 2012] [error] [client 127.0.0.1] Traceback (most  
recent call last):
[Wed Feb 22 09:36:12 2012] [error] [client 127.0.0.1]
File C:\\Python27\\lib\\site-packages\\django-1.3.1-py2.7.egg\\django\\core\\handlers\\wsgi.py,  
line 250, in __call__
[Wed Feb 22 09:36:12 2012] [error] [client 127.0.0.1]  
self.load_middleware()
[Wed Feb 22 09:36:12 2012] [error] [client 127.0.0.1]
File C:\\Python27\\lib\\site-packages\\django-1.3.1-py2.7.egg\\django\\core\\handlers\\base.py,  
line 47, in load_middleware
[Wed Feb 22 09:36:12 2012] [error] [client 127.0.0.1] raise  
exceptions.ImproperlyConfigured('Error importing middleware %s: %s' %  
(mw_module, e))
[Wed Feb 22 09:36:12 2012] [error] [client 127.0.0.1] ImproperlyConfigured:  
Error importing middleware reviewboard.admin.middleware: DLL load failed:  
\xd5\xd2\xb2\xbb\xb5\xbd\xd6\xb8\xb6\xa8\xb5\xc4\xc4\xa3\xbf\xe9\xa1\xa3



--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.