Re: Issue 607 in reviewboard: post-review option to insert the review url into the changelist description

2012-06-08 Thread reviewboard


Comment #7 on issue 607 by xingfen...@yahoo.cn: post-review option to  
insert the review url into the changelist description

http://code.google.com/p/reviewboard/issues/detail?id=607

a  
href=http://www.replicaoakleysunglasses4u.com/oakley-sunglasses-kids-c-129.html;Oakley  
Sunglasses Kids/a
a  
href=http://www.replicaoakleysunglasses4u.com/oakley-sunglasses-holbrook-c-128.html;Oakley  
Sunglasses Holbrook/a
a  
href=http://www.replicaoakleysunglasses4u.com/oakley-sunglasses-golf-c-127.html;Oakley  
Sunglasses Golf/a
a  
href=http://www.replicaoakleysunglasses4u.com/oakley-sunglasses-frogskins-c-126.html;Oakley  
Sunglasses Frogskins/a
a  
href=http://www.replicaoakleysunglasses4u.com/oakley-sunglasses-cycling-c-113.html;Oakley  
Sunglasses Cycling/a
a  
href=http://www.replicaoakleysunglasses4u.com/oakley-sunglasses-active-c-112.html;Oakley  
Sunglasses Active/a
a href=http://www.replicaoakleysunglasses4u.com/;fake oakley  
sunglasses/a


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2631 in reviewboard: IE8: javascript error when hitting enter on the people/groups fields

2012-06-08 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2631 by vour...@gmail.com: IE8: javascript error when hitting  
enter on the people/groups fields

http://code.google.com/p/reviewboard/issues/detail?id=2631

What version are you running?
1.6.7.1

What's the URL of the page containing the problem?
/r/#/

What steps will reproduce the problem?
1. Start typing leading symbols of any name in people/group field
2. Press enter

What is the expected output? What do you see instead?
Expected: selected group/username (first in the list) is saved in  
corresponding field. Or error popup about non-existent user.

Actual: empty page and javascript error:
Can't move focus to the control because it is invisible, not
enabled, or of a type that does not accept the focus.
And there are some object required javascript errors.

What operating system are you using? What browser?
Windows 7 x64, IE8
Google-chrome, Firefox, IE9 on Windows and Linux do not fail, but show the  
error message - User does not exist.


Please provide any additional information below.
Looks like, similar issue has been fixed:
http://code.google.com/p/reviewboard/issues/detail?id=352
Bit it is reproduced in the latest version.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2632 in reviewboard: Cannot upload a diff created via svn

2012-06-08 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2632 by dmitry...@gmail.com: Cannot upload a diff created via svn
http://code.google.com/p/reviewboard/issues/detail?id=2632

What version are you running?
1.6.7.1

What steps will reproduce the problem?
1. I created a diff from svn (diff contains info about one file that was  
created, something like that:


Index: modules/compositionmng/server/utils/AuditLogUtils.java
===
--- modules/compositionmng/server/utils/AuditLogUtils.java  (revision )
+++ modules/compositionmng/server/utils/AuditLogUtils.java  (revision )
@@ -0,0 +1,7@@
+package com.server.utils;
+
+import org.apache.log4j.Logger;
+
+public class AuditLogUtils {
+private static Logger log = Logger.getLogger(AuditLogUtils.class);
+}

2. Then I tried to upload the diff and got an error:

2012-06-08 16:55:48,066 - ERROR - Internal Server Error:  
/reviews/api/review-requests/5/diffs/

Traceback (most recent call last):
   
File /usr/lib/python2.6/site-packages/Django-1.3.1-py2.6.egg/django/core/handlers/base.py,  
line 178, in get_response

response = middleware_method(request, response)
   
File /usr/lib/python2.6/site-packages/Django-1.3.1-py2.6.egg/django/middleware/http.py,  
line 15, in process_response

response['Content-Length'] = str(len(response.content))
   
File /usr/lib/python2.6/site-packages/Djblets-0.6.18-py2.6.egg/djblets/webapi/core.py,  
line 281, in _get_content

content = adapter.encode(self.api_data, request=self.request)
   
File /usr/lib/python2.6/site-packages/Djblets-0.6.18-py2.6.egg/djblets/webapi/core.py,  
line 88, in encode

return super(JSONEncoderAdapter, self).encode(o)
  File /usr/lib64/python2.6/site-packages/simplejson/encoder.py, line  
200, in encode

chunks = self.iterencode(o, _one_shot=True)
  File /usr/lib64/python2.6/site-packages/simplejson/encoder.py, line  
260, in iterencode

return _iterencode(o, 0)
   
File /usr/lib/python2.6/site-packages/Djblets-0.6.18-py2.6.egg/djblets/webapi/core.py,  
line 99, in default

raise TypeError(%r is not JSON serializable % (o,))
TypeError: Revision: HEAD is not JSON serializable

The error appears only when I upload diff that contains info about adding  
files, otherwise it works properly.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 342 in reviewboard: Allow incremental expansion of collapsed code blocks

2012-06-08 Thread reviewboard


Comment #14 on issue 342 by eshara...@gmail.com: Allow incremental  
expansion of collapsed code blocks

http://code.google.com/p/reviewboard/issues/detail?id=342

I agree an incremental expansion option would be useful, as would an option  
to re-collapse to the original context setting


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.