Re: Issue 2636 in reviewboard: Text selection in editable fields is broken
Comment #1 on issue 2636 by vlov...@gmail.com: Text selection in editable fields is broken http://code.google.com/p/reviewboard/issues/detail?id=2636 Ideal behaviour would be that if I'm selecting text it never turns editable. Similarly, if I have text selected & click on the field it doesn't turn editable but instead just loses the selection. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2636 in reviewboard: Text selection in editable fields is broken
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2636 by vlov...@gmail.com: Text selection in editable fields is broken http://code.google.com/p/reviewboard/issues/detail?id=2636 What version are you running? 1.6.4.1 What's the URL of the page containing the problem? r/2337/ What steps will reproduce the problem? 1. Go into a review 2. Select text in summary What is the expected output? What do you see instead? Expected: Text should maintain selection, not turn editable Actual: Text field turns editable. In summary, the entire text is selected, in description the selection is lost. What operating system are you using? What browser? Chrome 20.0.1132.27 beta, Firefox 12 on Ubuntu 12.04 Please provide any additional information below. Sometimes I can select text in the description/testing done text areas without it turning editable (& thus losing the selection). -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2635 in reviewboard: review-requests API filtering by ship-it=0 returns ship-it'ed review requests too.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2635 by tomas.br...@gmail.com: review-requests API filtering by ship-it=0 returns ship-it'ed review requests too. http://code.google.com/p/reviewboard/issues/detail?id=2635 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.6.4.1 What's the URL of the page containing the problem? /api/review/requests?ship-it=0 What steps will reproduce the problem? 1. Create some review requests, mark some of them as ship-it'ed. 2. Send a GET request to /api/review-requests?ship-it=0 3. The response includes review requests that have been ship-it'ed. What is the expected output? What do you see instead? I'd expect to see review requests that have not been accepted only. But the response includes review requests that have been ship-it'ed. What operating system are you using? What browser? I'm using the REST API from python and curl. Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2559 in reviewboard: Replying inlne to a review comment should be in direct response to the comment
Comment #1 on issue 2559 by liam.mer...@gmail.com: Replying inlne to a review comment should be in direct response to the comment http://code.google.com/p/reviewboard/issues/detail?id=2559 Our group has started to adopt reviewboard. Initially we adopted reviewboard with great gusto as it has some excellent features but having gone through a review of project with a diff with ~4000K lines of changes we've noticed some downsides (some of which I'm hoping are because we're just doing things wrong). In the case of this RFE, it's difficult to validate that the suggested changes are made if a new review is created for inline responses to the original comments. Instead the inline comment should be appended to the original review so that at the end you can go back and look at your review and see that all things have been addressed. [ This is on v1.5.1 (which is admittedly a bit behind - the rest of our org had already setup and are using reviewboard) and a mercurial-based gate ] -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2632 in reviewboard: Cannot upload a diff created via svn
Comment #7 on issue 2632 by dmitry...@gmail.com: Cannot upload a diff
created via svn
http://code.google.com/p/reviewboard/issues/detail?id=2632
I tried to use "svn diff" and got the same error
2012-06-14 10:00:32,866 - DEBUG - DiffParser.parse: Beginning parse of
diff, size = 94423
2012-06-14 10:00:32,879 - DEBUG - DiffParser.parse: Finished parsing diff.
2012-06-14 10:00:48,392 - ERROR - Internal Server Error:
/reviews/api/review-requests/5/diffs/
Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/Django-1.3.1-py2.6.egg/django/core/handlers/base.py",
line 178, in get_response
response = middleware_method(request, response)
File "/usr/lib/python2.6/site-packages/Django-1.3.1-py2.6.egg/django/middleware/http.py",
line 15, in process_response
response['Content-Length'] = str(len(response.content))
File "/usr/lib/python2.6/site-packages/Djblets-0.6.18-py2.6.egg/djblets/webapi/core.py",
line 281, in _get_content
content = adapter.encode(self.api_data, request=self.request)
File "/usr/lib/python2.6/site-packages/Djblets-0.6.18-py2.6.egg/djblets/webapi/core.py",
line 88, in encode
return super(JSONEncoderAdapter, self).encode(o)
File "/usr/lib64/python2.6/site-packages/simplejson/encoder.py", line
200, in encode
chunks = self.iterencode(o, _one_shot=True)
File "/usr/lib64/python2.6/site-packages/simplejson/encoder.py", line
260, in iterencode
return _iterencode(o, 0)
File "/usr/lib/python2.6/site-packages/Djblets-0.6.18-py2.6.egg/djblets/webapi/core.py",
line 99, in default
raise TypeError("%r is not JSON serializable" % (o,))
TypeError: is not JSON serializable
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
