Re: Issue 489 in reviewboard: [ ] DON'T SHIP IT button
Comment #33 on issue 489 by narf1...@gmail.com: [ ] DON'T SHIP IT button http://code.google.com/p/reviewboard/issues/detail?id=489 All the discussion above highlights a very nice enhancement, but I just thought to put down what I've been doing as a possible work around. In order for code being valid for shipping it needs x no of Ship It!'s and no open issues. For example: Dev A comes along and says Ship It!, but then Dev B finds a problem and opens and issue. Because there are still issues open, the Ship It! is not valid and simply comments on the fact that Dev A found it ok to go. This prevents code from being shipped despite someone having clicked Ship It!. A delete 'Ship It!' would still be nice for accidental clicks, and it would be cool to see the no of open issues on the dashboard. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2686 in reviewboard: 1.6.10 breaks svn+ssh for Subversion
Comment #22 on issue 2686 by cea...@gmail.com: 1.6.10 breaks svn+ssh for
Subversion
http://code.google.com/p/reviewboard/issues/detail?id=2686
I did the following:
$ git clone -b release-0.6.x https://github.com/djblets/djblets.git
$ cd djblets/
$ sudo ./setup.py install
$ sudo service memcached restart
$ sudo service apache2 restart
Unfortunately, I got the same error through the ReviewBoard UI. I ran the
same rbssh command you had me run before as the www-data user and got the
following output:
/usr/local/lib/python2.6/dist-packages/pycrypto-2.3-py2.6-linux-x86_64.egg/Crypto/Util/randpool.py:40:
RandomPool_DeprecationWarning:
This application uses RandomPool, which is
BROKEN in older releases. See http://www.pycrypto.org/randpool-broken
RandomPool_DeprecationWarning)
Traceback (most recent call last):
File /usr/local/bin/rbssh, line 9, in module
load_entry_point('ReviewBoard==1.6.10', 'console_scripts', 'rbssh')()
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 299, in
load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 2229, in
load_entry_point
return ep.load()
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 1948, in
load
entry = __import__(self.module_name, globals(),globals(), ['__name__'])
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.10-py2.6.egg/reviewboard/cmdline/rbssh.py,
line 42, in module
from reviewboard.scmtools import sshutils
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.10-py2.6.egg/reviewboard/scmtools/sshutils.py,
line 8, in module
from reviewboard.scmtools.errors import AuthenticationError, \
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.10-py2.6.egg/reviewboard/scmtools/errors.py,
line 4, in module
from djblets.util.templatetags.djblets_utils import humanize_list
File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.21-py2.6.egg/djblets/util/templatetags/djblets_utils.py,
line 31, in module
from django.contrib.auth.models import AnonymousUser, User
File /usr/local/lib/python2.6/dist-packages/Django-1.3.1-py2.6.egg/django/contrib/auth/models.py,
line 7, in module
from django.db import models
File /usr/local/lib/python2.6/dist-packages/Django-1.3.1-py2.6.egg/django/db/__init__.py,
line 14, in module
if not settings.DATABASES:
File /usr/local/lib/python2.6/dist-packages/Django-1.3.1-py2.6.egg/django/utils/functional.py,
line 276, in __getattr__
self._setup()
File /usr/local/lib/python2.6/dist-packages/Django-1.3.1-py2.6.egg/django/conf/__init__.py,
line 40, in _setup
raise ImportError(Settings cannot be imported, because environment
variable %s is undefined. % ENVIRONMENT_VARIABLE)
ImportError: Settings cannot be imported, because environment variable
DJANGO_SETTINGS_MODULE is undefined.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2686 in reviewboard: 1.6.10 breaks svn+ssh for Subversion
Comment #23 on issue 2686 by chip...@gmail.com: 1.6.10 breaks svn+ssh for Subversion http://code.google.com/p/reviewboard/issues/detail?id=2686 Upgrade to 1.6.11 and see if this is fixed for you. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2689 in reviewboard: Error logging in to ReviewBoard if not already logged in
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2689 by duane1...@gmail.com: Error logging in to ReviewBoard if not already logged in http://code.google.com/p/reviewboard/issues/detail?id=2689 Just recently upgraded to Review Board 1.6.11. When logging in on a browser without an existing cookie, I get a 500 Internal Server Error in response. However, on my machine that was previously logged in, I can use Review Board just fine. What version are you running? 1.6.11 What's the URL of the page containing the problem? Main URL (/reviews/ on my server) What steps will reproduce the problem? 1. Clear cookies on browser 2. Go to http://xxx.xxx.com/reviews/ (where I have the review board app mapped in my Apache server) 3. Observe Something broke! (Error 500) What is the expected output? What do you see instead? I expect to see the Review Board login page, which was previously visible using version 1.6.3 before doing the upgrade to 1.6.11. What operating system are you using? What browser? Tested in both Firefox (PC) and Chrome (Mac). Server is using CentOS Linux Release 5.7. Please provide any additional information below. This is the information from reviewboard.log: 2012-07-31 15:43:17,400 - ERROR - Exception thrown for user AnonymousUser at http://xxx.xxx.com/reviews/ 'tuple' object has no attribute 'scheme' Traceback (most recent call last): File /usr/lib/python2.4/site-packages/Django-1.3.2-py2.4.egg/django/core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/lib/python2.4/site-packages/Django-1.3.2-py2.4.egg/django/views/generic/simple.py, line 57, in redirect_to return klass(url % kwargs) File /usr/lib/python2.4/site-packages/Django-1.3.2-py2.4.egg/django/http/__init__.py, line 645, in __init__ if parsed.scheme and parsed.scheme not in self.allowed_schemes: AttributeError: 'tuple' object has no attribute 'scheme' 2012-07-31 15:43:17,401 - ERROR - Internal Server Error: /reviews/ Traceback (most recent call last): File /usr/lib/python2.4/site-packages/Django-1.3.2-py2.4.egg/django/core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/lib/python2.4/site-packages/Django-1.3.2-py2.4.egg/django/views/generic/simple.py, line 57, in redirect_to return klass(url % kwargs) File /usr/lib/python2.4/site-packages/Django-1.3.2-py2.4.egg/django/http/__init__.py, line 645, in __init__ if parsed.scheme and parsed.scheme not in self.allowed_schemes: AttributeError: 'tuple' object has no attribute 'scheme' -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2689 in reviewboard: Error logging in to ReviewBoard if not already logged in
Updates: Status: Confirmed Comment #1 on issue 2689 by chip...@gmail.com: Error logging in to ReviewBoard if not already logged in http://code.google.com/p/reviewboard/issues/detail?id=2689 This looks to be the new code path in the Django security release. Why we're hitting it, I don't know... I suspect they didn't test in Python 2.4. I would say for now, manually downgrade to Django 1.3.1. Unfortunately. You can do this with: $ sudo easy_install Django==1.3.1 And delete the Django-1.3.2-py2.4.egg directory referenced. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2689 in reviewboard: Error logging in to ReviewBoard if not already logged in
Comment #2 on issue 2689 by chip...@gmail.com: Error logging in to ReviewBoard if not already logged in http://code.google.com/p/reviewboard/issues/detail?id=2689 Filed a bug on the Django project: https://code.djangoproject.com/ticket/18692 For what it's worth, Review Board 1.7 won't be supporting Python 2.4, so it might not be a bad idea to think about upgrading Python. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2689 in reviewboard: Error logging in to ReviewBoard if not already logged in
Comment #3 on issue 2689 by duane1...@gmail.com: Error logging in to ReviewBoard if not already logged in http://code.google.com/p/reviewboard/issues/detail?id=2689 Thanks for the quick reply! Downgrading to Django 1.3.1 does work for now, but I think I will try to upgrade to Python. Should there be any issue upgrading to Python 2.7 or should I stick with Python 2.5? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2689 in reviewboard: Error logging in to ReviewBoard if not already logged in
Comment #4 on issue 2689 by chip...@gmail.com: Error logging in to ReviewBoard if not already logged in http://code.google.com/p/reviewboard/issues/detail?id=2689 2.7 is a good, safe bet. Note that all your existing packages are part of your 2.4 setup, so you'll basically need to reinstall them all. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
