Issue 2898 in reviewboard: ssh+svn access no more possible in version 1.7.5

2013-02-11 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2898 by andreasf...@gmail.com: ssh+svn access no more possible in  
version 1.7.5

http://code.google.com/p/reviewboard/issues/detail?id=2898

*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!

What version are you running?
1.7.5


What's the URL of the page containing the problem?
n.a.

What steps will reproduce the problem?
1.Running version 1.6.1
2.Subversion repository configured with ssh access. Generated key via webgui
3. Upgrade to version 1.7.5

What is the expected output? What do you see instead?
Access to the repository should be possible like before. Instead no more  
access to the repository is possible (no diffs can be shown any more)


What operating system are you using? What browser?
Ubuntu 12.04, Chrome

Please provide any additional information below.




--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Issue 2899 in reviewboard: Documentation does not mention the requirement to upload a full diff each time

2013-02-11 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2899 by ultraran...@gmail.com: Documentation does not mention the  
requirement to upload a full diff each time

http://code.google.com/p/reviewboard/issues/detail?id=2899

We run ReviewBoard 1.6.3.

When submitting a diff manually (without using the post-review tool), users  
don't understand they need to submit complete diffs every time. Instead  
they may wrongly submit several partial diffs as they make changes, meaning  
reviewers cannot see a complete end-to-end diff, and ReviewBoard does not  
work as intended.


This causes confusion and affects the reputation of ReviewBoard itself.  
People will stop using it if they can't get it to work correctly.


There is a stop-gap solution that could make things easier for users  
immediately: The ReviewBoard documentation must explain how it's necessary  
to submit a full diff each time and not a partial diff. This explanation  
could go on the Creating Review Requests page:  
http://www.reviewboard.org/docs/manual/1.7/users/review-requests/creating/


If the correct documentation is in place, local administrators and  
advocates of ReviewBoard could direct other users to it, ensuring its  
correct usage.


See also discussion at  
https://groups.google.com/forum/?fromgroups=#!starred/reviewboard/RosZjgO7FBo



--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Issue 1995 in reviewboard: Bug detection pattern should ignore a leading '#'

2013-02-11 Thread reviewboard


Comment #4 on issue 1995 by much...@gmail.com: Bug detection pattern should  
ignore a leading '#'

http://code.google.com/p/reviewboard/issues/detail?id=1995

I'll give this a shot. --Felix

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Issue 2900 in reviewboard: add ability to reply to comments from diff viewer

2013-02-11 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 2900 by matthew@kitware.com: add ability to reply to comments  
from diff viewer

http://code.google.com/p/reviewboard/issues/detail?id=2900

What version are you running?
1.7.5

What's the URL of the page this enhancement relates to, if any?
any diff view with comments

Describe the enhancement and the motivation for it.
It would be helpful if it were possible to reply to comments directly from  
the diff viewer, without having to go back to the reviews page (which loses  
the diff context).


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Issue 2559 in reviewboard: Replying inlne to a review comment should be in direct response to the comment

2013-02-11 Thread reviewboard


Comment #3 on issue 2559 by trowb...@gmail.com: Replying inlne to a review  
comment should be in direct response to the comment

http://code.google.com/p/reviewboard/issues/detail?id=2559

Issue 2900 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Issue 2900 in reviewboard: add ability to reply to comments from diff viewer

2013-02-11 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 2559

Comment #1 on issue 2900 by trowb...@gmail.com: add ability to reply to  
comments from diff viewer

http://code.google.com/p/reviewboard/issues/detail?id=2900

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Issue 2901 in reviewboard: RB tries to display diff from version 0 to 1

2013-02-11 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2901 by matthias...@famsik.de: RB tries to display diff from  
version 0 to 1

http://code.google.com/p/reviewboard/issues/detail?id=2901

*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!

What version are you running?
RB 1.7.2 (yes I know it's outdated but we haven't updated yet and I didn't  
see items in the release notes that looked related to this issue.)


The problem occurs when we create a review request without a diff but  
attache the diff later.


You can see this here http://rb.freedroid.org/r/1878/ in the second change  
of the RR.


RB offers to Show changes between the current diff and the previous diff  
(I assume code says current diff -1 but since the diff was attached  
afterwards an is the first diff, the previous diff is diff 0.
RB now tries to show the changes between diff0 and diff1 which fails  
obviously.

http://rb.freedroid.org/r/1878/diff/0-1/

It's only a minor issue but probably also easy to fix.

Regards, Matthias

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Issue 2884 in reviewboard: links with ampersand () are truncated

2013-02-11 Thread reviewboard


Comment #3 on issue 2884 by denis.ba...@gmail.com: links with ampersand ()  
are truncated

http://code.google.com/p/reviewboard/issues/detail?id=2884

I see this now on RB 1.6.13.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Issue 2884 in reviewboard: links with ampersand () are truncated

2013-02-11 Thread reviewboard


Comment #4 on issue 2884 by denis.ba...@gmail.com: links with ampersand ()  
are truncated

http://code.google.com/p/reviewboard/issues/detail?id=2884

I've made some investigation.

My code post WebSVN URL like this:
https://server/wsvn/project/?op=revisionrev=125peg=125

On Review page there are HTML code like this:
pre class=body_top  
reviewtexthttps://server/wsvn/project/?op=revisionamp;rev=125amp;peg=125


And on page I see:
https://server/wsvn/project/?op=revisionrev=125;
and everything up to last  is a link.

I think it is JavaScript formatting problem.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.