Issue 2935 in reviewboard: Diff currently unavailable.

2013-03-21 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2935 by 00036...@zte.com.cn: Diff currently unavailable.
http://code.google.com/p/reviewboard/issues/detail?id=2935

*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!

What version are you running?
1.7.6

What's the URL of the page containing the problem?
when I click view diff,error is :
Diff currently unavailable.
Error: 'Popen' object has no attribute 'kill'
Details
Traceback (most recent call last):
   
File c:\python25\lib\site-packages\ReviewBoard-1.7.6-py2.5.egg\reviewboard\diffviewer\views.py,  
line 383, in view_diff_fragment

file = get_requested_diff_file()
   
File c:\python25\lib\site-packages\ReviewBoard-1.7.6-py2.5.egg\reviewboard\diffviewer\views.py,  
line 309, in get_requested_diff_file

populate_diff_chunks(files, highlighting)
   
File c:\python25\lib\site-packages\ReviewBoard-1.7.6-py2.5.egg\reviewboard\diffviewer\diffutils.py,  
line 1197, in populate_diff_chunks

large_data=True)
   
File c:\python25\lib\site-packages\Djblets-0.7.11-py2.5.egg\djblets\util\misc.py,  
line 156, in cache_memoize

data = lookup_callable()
   
File c:\python25\lib\site-packages\ReviewBoard-1.7.6-py2.5.egg\reviewboard\diffviewer\diffutils.py,  
line 1196, in lambda

enable_syntax_highlighting)),
   
File c:\python25\lib\site-packages\ReviewBoard-1.7.6-py2.5.egg\reviewboard\diffviewer\diffutils.py,  
line 599, in get_chunks

new = get_patched_file(old, filediff)
   
File c:\python25\lib\site-packages\ReviewBoard-1.7.6-py2.5.egg\reviewboard\diffviewer\diffutils.py,  
line 392, in get_patched_file

return patch(diff, buffer, filediff.dest_file)
   
File c:\python25\lib\site-packages\ReviewBoard-1.7.6-py2.5.egg\reviewboard\diffviewer\diffutils.py,  
line 235, in patch

failure = p.wait()
  File C:\Python25\lib\contextlib.py, line 33, in __exit__
self.gen.throw(type, value, traceback)
   
File c:\python25\lib\site-packages\Djblets-0.7.11-py2.5.egg\djblets\util\contextmanagers.py,  
line 66, in controlled_subprocess

process.kill()
AttributeError: 'Popen' object has no attribute 'kill'

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What operating system are you using? What browser?


Please provide any additional information below.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Issue 2936 in reviewboard: Something broke! (Error 500) at http://rb.domain.pl/r/119/

2013-03-21 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2936 by mikola...@gmail.com: Something broke! (Error 500) at  
http://rb.domain.pl/r/119/

http://code.google.com/p/reviewboard/issues/detail?id=2936

*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!

What version are you running?
1.7.6

What's the URL of the page containing the problem?
http://rb.pl/r/*/ - all review requests

What steps will reproduce the problem?
1. Try to visit review request page
2. Wait for a long time and then error appears

What is the expected output? What do you see instead?
expected: review request page
current: Something broke! (Error 500)

It appears something broke when you tried to go to here. This is either a  
bug in Review Board or a server configuration error. Please report this to  
your administrator.


What operating system are you using? What browser?
client: Arch Linux, firefox, qupzilla, opera
server: Debian Lenny

Please provide any additional information below.
It looks like error with mercurial in ReviewBoard
apache error.log:

[Thu Mar 21 12:45:33 2013] [error] error accessing repository at True
[Thu Mar 21 12:45:33 2013] [error] error accessing repository at True
[Thu Mar 21 12:45:35 2013] [error] error accessing repository at True
[Thu Mar 21 12:45:35 2013] [error] error accessing repository at True
[Thu Mar 21 11:45:42 2013] [error]  
/usr/local/lib/python2.6/dist-packages/django/views/generic/list_detail.py:10:  
DeprecationWarning: Function-based generic views have been deprecated; use  
class-based views instead.

[Thu Mar 21 11:45:42 2013] [error]   DeprecationWarning
[Thu Mar 21 11:45:42 2013] [error]  
/usr/local/lib/python2.6/dist-packages/django/conf/__init__.py:75:  
DeprecationWarning: The ADMIN_MEDIA_PREFIX setting has been removed; use  
STATIC_URL instead.
[Thu Mar 21 11:45:42 2013] [error]   use STATIC_URL instead.,  
DeprecationWarning)
[Thu Mar 21 11:45:43 2013] [error] ERROR:root:Exception thrown for user xxx  
at http://rb.pl/r/121/

[Thu Mar 21 11:45:43 2013] [error]
[Thu Mar 21 11:45:43 2013] [error] 'NoneType' object has no  
attribute 'strip'

[Thu Mar 21 11:45:43 2013] [error] Traceback (most recent call last):
[Thu Mar 21 11:45:43 2013] [error]
File /usr/local/lib/python2.6/dist-packages/django/core/handlers/base.py,  
line 111, in get_response
[Thu Mar 21 11:45:43 2013] [error] response = callback(request,  
*callback_args, **callback_kwargs)
[Thu Mar 21 11:45:43 2013] [error]
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.7.6-py2.6.egg/reviewboard/accounts/decorators.py,  
line 20, in _check
[Thu Mar 21 11:45:43 2013] [error] return  
login_required(view_func)(*args, **kwargs)
[Thu Mar 21 11:45:43 2013] [error]
File /usr/local/lib/python2.6/dist-packages/Djblets-0.7.11-py2.6.egg/djblets/auth/util.py,  
line 47, in _checklogin
[Thu Mar 21 11:45:43 2013] [error] return view_func(request, *args,  
**kwargs)
[Thu Mar 21 11:45:43 2013] [error]
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.7.6-py2.6.egg/reviewboard/reviews/views.py,  
line 728, in review_detail

[Thu Mar 21 11:45:43 2013] [error] 'screenshots': screenshots,
[Thu Mar 21 11:45:43 2013] [error]
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.7.6-py2.6.egg/reviewboard/reviews/views.py,  
line 124, in _make_review_request_context
[Thu Mar 21 11:45:43 2013] [error] upload_diff_form =  
UploadDiffForm(review_request)
[Thu Mar 21 11:45:43 2013] [error]
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.7.6-py2.6.egg/reviewboard/reviews/forms.py,  
line 284, in __init__

[Thu Mar 21 11:45:43 2013] [error] data, *args, **kwargs)
[Thu Mar 21 11:45:43 2013] [error]
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.7.6-py2.6.egg/reviewboard/diffviewer/forms.py,  
line 51, in __init__
[Thu Mar 21 11:45:43 2013] [error] if  
self.repository.get_scmtool().get_diffs_use_absolute_paths():
[Thu Mar 21 11:45:43 2013] [error]
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.7.6-py2.6.egg/reviewboard/scmtools/models.py,  
line 136, in get_scmtool

[Thu Mar 21 11:45:43 2013] [error] return cls(self)
[Thu Mar 21 11:45:43 2013] [error]
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.7.6-py2.6.egg/reviewboard/scmtools/hg.py,  
line 31, in __init__
[Thu Mar 21 11:45:43 2013] [error] self.client =  
HgClient(repository.path, repository.local_site)
[Thu Mar 21 11:45:43 2013] [error]
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.7.6-py2.6.egg/reviewboard/scmtools/hg.py,  
line 212, in __init__

[Thu Mar 21 11:45:43 2013] [error] from mercurial import hg, ui
[Thu Mar 21 11:45:43 2013] [error]
File /usr/local/lib/python2.6/dist-packages/mercurial-2.4.2-py2.6-linux-x86_64.egg/mercurial/hg.py,  
line 12, in module

Re: Issue 2917 in reviewboard: Invalid diffs generated by post-review for local GIT to remote SVN

2013-03-21 Thread reviewboard


Comment #2 on issue 2917 by gernhard...@googlemail.com: Invalid diffs  
generated by post-review for local GIT to remote SVN

http://code.google.com/p/reviewboard/issues/detail?id=2917

Same problem here with RB 1.7.5 and RBTools 0.5. And the alternative rbt  
post just gives me:


CRITICAL:root:Error creating review request: The repository path specified  
is not in the list of known repositories (HTTP 400, API Error 206)



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Issue 2917 in reviewboard: Invalid diffs generated by post-review for local GIT to remote SVN

2013-03-21 Thread reviewboard


Comment #3 on issue 2917 by gernhard...@googlemail.com: Invalid diffs  
generated by post-review for local GIT to remote SVN

http://code.google.com/p/reviewboard/issues/detail?id=2917

Okay, apparently it's not exactly the same problem for me. I switched back  
to 0.4.3 and applied your patch/workaround but then got errors about files  
not being in the repository. After taking a look at the output  
of post-review --output-diff it became evident that git svn find-rev  
produced an error if its output didn't go to the terminal:


git svn find-rev master | tee
Unable to get Terminal Size. The TIOCGWINSZ ioctl didn't work. The COLUMNS  
and LINES environment variables didn't work. The resize program didn't  
work. at /usr/lib/perl5/Term/ReadKey.pm line 362.

12477

12477 is the correct SVN revision so after changing the regex in your patch  
to '([0-9]+)$' I can upload reviews again.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Issue 2937 in reviewboard: I can not approve the RB https://rb.corp.linkedin.com/r/146692/diff/#

2013-03-21 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2937 by core.reg...@gmail.com: I can not approve the RB  
https://rb.corp.linkedin.com/r/146692/diff/#

http://code.google.com/p/reviewboard/issues/detail?id=2937

*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!

What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What operating system are you using? What browser?


Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Issue 2937 in reviewboard: I can not approve the RB https://rb.corp.linkedin.com/r/146692/diff/#

2013-03-21 Thread reviewboard

Updates:
Status: SetupIssue

Comment #1 on issue 2937 by trowb...@gmail.com: I can not approve the RB  
https://rb.corp.linkedin.com/r/146692/diff/#

http://code.google.com/p/reviewboard/issues/detail?id=2937

You'll need to talk to your server administrator. This bug tracker is about  
the upstream open-source code, not any particular server.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Issue 2918 in reviewboard: Group reviews across multiple repositories

2013-03-21 Thread reviewboard


Comment #1 on issue 2918 by todd.hei...@gmail.com: Group reviews across  
multiple repositories

http://code.google.com/p/reviewboard/issues/detail?id=2918

I ran into this as well, just now.  While I realize the multiple repository  
problem may be a code smell, it is legacy.


I second the request for reviews across multiple repositories.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Issue 2938 in reviewboard: Long timezone values in Account Preferences cause an unexpected error

2013-03-21 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2938 by pablo.ro...@gmail.com: Long timezone values in Account  
Preferences cause an unexpected error

http://code.google.com/p/reviewboard/issues/detail?id=2938

What version are you running?
1.7.6

What's the URL of the page containing the problem?
Any place where a timezone is set, such as:
/account/preferences/

What steps will reproduce the problem?
1. Access the account preferences page
2. Attempt to set the timezone to one of the longer names, such as:  
America/Argentina/Buenos_Aires


What is the expected output? What do you see instead?
Timezone should be set accordingly. Instead, an error (500) occurs.

What operating system are you using? What browser?
Windows 2008, backend database on MySQL 5.5.29

The error seems to be caused by the length of the accounts_profile.timezone  
field, which is only varchar(20), so America/Argentina/Buenos_Aires  
exceeds the 20 characters.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.