Re: Issue 1874 in reviewboard: post-review does not properly parse diffs between commits in a branch on a git-svn repository
Updates: Status: Fixed Comment #8 on issue 1874 by trowb...@gmail.com: post-review does not properly parse diffs between commits in a branch on a git-svn repository http://code.google.com/p/reviewboard/issues/detail?id=1874 Fixed in rbtools master (dc0b739). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2322 in reviewboard: Unable to post reviews with post-review (0.3.4): can not log in into Reviewboard (1.6.1)
Updates: Status: SetupIssue Comment #23 on issue 2322 by trowb...@gmail.com: Unable to post reviews with post-review (0.3.4): can not log in into Reviewboard (1.6.1) http://code.google.com/p/reviewboard/issues/detail?id=2322 Digging through the mailing list, this seems to be when combining ldap + fastcgi. Since there's really nothing we can do about the fastcgi interface, I'm going to change the docs to more heavily recommend mod_wsgi and cite this issue specifically. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2632 in reviewboard: Cannot upload a diff created via svn
Updates: Status: Fixed Comment #9 on issue 2632 by trowb...@gmail.com: Cannot upload a diff created via svn http://code.google.com/p/reviewboard/issues/detail?id=2632 Something about your svn binary is pretty weird (We've only seen "(revision )" from IntelliJ IDEA before). That said, I think we can work around it. I've pushed a fix for this to master (95cf9c1). It will ship in 1.8.0. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2661 in reviewboard: Hitting enter in a text field causes the page to scroll down
Updates: Status: UnableToReproduce Comment #5 on issue 2661 by trowb...@gmail.com: Hitting enter in a text field causes the page to scroll down http://code.google.com/p/reviewboard/issues/detail?id=2661 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2829 in reviewboard: Diff generation hangs when trying to "Edit Review"
Updates: Status: Fixed Comment #6 on issue 2829 by trowb...@gmail.com: Diff generation hangs when trying to "Edit Review" http://code.google.com/p/reviewboard/issues/detail?id=2829 This was fixed in djblets (1b79a0c1). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3052 in reviewboard: security vulnerability: python injection
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3052 by yuzi...@gmail.com: security vulnerability: python
injection
http://code.google.com/p/reviewboard/issues/detail?id=3052
*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!
What version are you running?
1.7.11
What steps will reproduce the problem?
import rbtools.api.client
r = rbtools.api.client.RBClient('http://my-reviewboard',
username='my_username', password='my_password')
r.get_root().get_user(username='quit()')
What is the expected output?
{u'stat': u'fail', u'err': {u'msg': u'Object does not exist', u'code': 100}}
'{"stat": "fail", "err": {"msg": "Object does not exist", "code": 100}}'
Traceback (most recent call last):
File "", line 1, in
File "/Library/Python/2.7/site-packages/rbtools/api/resource.py", line
441, in
self._get_template_request(url, **kwargs)))
File "/Library/Python/2.7/site-packages/rbtools/api/decorators.py", line
24, in request_method
*args, **kwargs)
File "/Library/Python/2.7/site-packages/rbtools/api/transport/sync.py",
line 54, in execute_request_method
return self._execute_request(request)
File "/Library/Python/2.7/site-packages/rbtools/api/transport/sync.py",
line 63, in _execute_request
rsp = self.server.make_request(request)
File "/Library/Python/2.7/site-packages/rbtools/api/request.py", line
414, in make_request
self.process_error(e.code, e.read())
File "/Library/Python/2.7/site-packages/rbtools/api/request.py", line
387, in process_error
rsp['err']['msg'])
rbtools.api.errors.APIError: Object does not exist (HTTP 404, API Error 100)
What do you see instead?
'\n\n\n\n http-equiv="content-type" content="text/html; charset=utf-8">\n
Page not found at /api/users/quit()/\n content="NONE,NOARCHIVE">\n \nhtml * {
padding:0; margin:0; }\nbody * { padding:10px 20px; }\nbody * * {
padding:0; }\nbody { font:small sans-serif; background:#eee; }\n
body>div { border-bottom:1px solid #ddd; }\nh1 { font-weight:normal;
margin-bottom:.4em; }\nh1 span { font-size:60%; color:#666;
font-weight:normal; }\ntable { border:none; border-collapse: collapse;
width:100%; }\ntd, th { vertical-align:top; padding:2px 3px; }\nth
{ width:12em; text-align:right; color:#666; padding-right:.5em; }\n
#info { background:#f6f6f6; }\n#info ol { margin: 0.5em 4em; }\n
#info ol li { font-family: monospace; }\n#summary { background: #ffc;
}\n#explanation { background:#eee; border-bottom: 0px none; }\n
\n\n\n \nPage not found
(404)\n\n \n
Request Method:\nGET\n \n
\nRequest URL:\n
http://purpleslam-reviewboard.apple.com/api/users/quit()/\n
\n\n \n \n\n \n
Using the URLconf defined in djblets.util.rooturl,\n
Django tried these URL patterns, in this order:\n \n
\n\n \n\n
^\n\n\n
^admin/extensions/\n\n\n
\n\n \n\n
^\n\n\n^admin/\n
\n\n \n\n \n
\n^\n\n\n
^static\\/(?P.*)$\n\n\n
\n\n \n\n
^\n\n\n
^media\\/(?P.*)$\n\n\n
\n\n \n\n
^\n\n\n
^js-tests/$\n\n\n \n
\n \n\n^\n
\n\n^account/\n\n
\n \n\n \n\n
^\n\n\n
^s/(?P[A-Za-z0-9\\-_.]+)/\n
\n\n \n\n \n
\n^\n\n\n
^$\n[name=\'root\']\n\n \n
\n \n\n^\n
\n\n^api/\n\n
\n^$\n[name=\'root-resource\']\n
\n \n\n \n\n
^\n\n\n^api/\n
\n\n^default-re
Re: Issue 3052 in reviewboard: security vulnerability: python injection
Updates:
Status: NeedInfo
Comment #1 on issue 3052 by chip...@gmail.com: security vulnerability:
python injection
http://code.google.com/p/reviewboard/issues/detail?id=3052
Thanks for reporting this.
I'm not able to reproduce it. I set up an environment with 1.7.11 and tried
the repro case you provided. I haven't been able to cause this.
Looking at your log output, the 404 result you provided shows a result from
Django. The Django 404 happens because the URLs registered don't allow
parens, so we never get to a point where we reach any API handler
for "quit()" that can throw an API version of a 404, instead throwing only
a standard Django 404.
So all that looks correct. Well, "correct." We should probably have some
generic thing on /api/* that throws a 404 if nothing else matches.
Now, you end up with an Operation Timed Out. That's very strange. What
happens when connecting from a web browser?
Also, what version of RBTools are you using?
Does that query for get_review_requests work before doing the
get_user('quit()') ?
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3052 in reviewboard: Useless 404 payload for unhandled URLs
Updates: Summary: Useless 404 payload for unhandled URLs Labels: Component-API Comment #2 on issue 3052 by chip...@gmail.com: Useless 404 payload for unhandled URLs http://code.google.com/p/reviewboard/issues/detail?id=3052 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
