Re: Issue 3067 in reviewboard: Parent diffs with mercurial are still broken
Comment #10 on issue 3067 by patrick.horn: Parent diffs with mercurial are still broken http://code.google.com/p/reviewboard/issues/detail?id=3067 I'm using RB 1.7.12 and I had a slightly different problem with a simpler solution (when using hg-style diffs). The old code allowed the 'origChangesetId' from any file in the parent diff to become the source_rev for every file in the child diff; however it only worked if the parent diff had any files in common with the child. My attached patch fixes this. While the code in 1.7.12 was not 100% correct, this effectively solved the issue. If you try with 1.7.12 and the attached patch, the problem should be solved. I also had no issues when removing files and re-adding them back--this should be handled by the "f.origInfo != PRE_CREATION" check. Perhaps it is a bug with git-style diffs. I have yet to test in RB 1.7.13, but looking at the commit log, it looks like the code changed significantly between 1.7.12 and 1.7.13 with https://reviews.reviewboard.org/r/4121/ (45faed44) -- From what I can tell, the code now will only work in the case that you specify a parent diff with a global "# Parent" comment because it now only checks the global origChangesetId, so I think this change just made the issue more complicated. The good news is that with commits 253ff68 and 5acf49a it is now possible to specify the parent commit ID via the API, so the API parameter might be a nice solution to this problem in versions after 1.7.13. I will try to do some tests on 1.7.13 or a later version. I also have only tested with hg-style diffs, not git-style diffs so those might be different. Attachments: fix-parent-diff-1.7.12.patch 1011 bytes -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #17 on issue 2916 by javawiz...@opengroove.org: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 1.7.9 also has this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3106 in reviewboard: Sending out a huge diff for review failed
Updates: Status: Invalid Comment #1 on issue 3106 by trowb...@gmail.com: Sending out a huge diff for review failed http://code.google.com/p/reviewboard/issues/detail?id=3106 First of all, we can't accept bug reports that don't include answers to all of our questions. Second, there is a limit on the size of a diff file, but that limit is well above what is possible for humans to review. If your diff includes a bunch of auto-generated stuff, I suggest stripping that out before asking your colleagues to look at it. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3106 in reviewboard: Sending out a huge diff for review failed
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3106 by nithin...@gmail.com: Sending out a huge diff for review failed http://code.google.com/p/reviewboard/issues/detail?id=3106 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be rejected. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? What's the URL of the page containing the problem? What steps will reproduce the problem? 1. 2. 3. What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3067 in reviewboard: Parent diffs with mercurial are still broken
Comment #9 on issue 3067 by scherere...@gmail.com: Parent diffs with mercurial are still broken http://code.google.com/p/reviewboard/issues/detail?id=3067 Possible related issue, but it may be a different bug. I attempted to use the -o -g workaround and have encountered another edge case that fails: r4 [draft] : add file A (unrelated in content, but sharing the same name) r3 [draft] : miscelaneous r2 [draft] : remove file A r1 [public] : file A present hg postreview r4 -o -g -i 'foo' File A will show 'diff unavailable' My original workaround (diff -r 0:r3) still worked in this scenario. I have not tested to see if r3 is necessary to the test. Since the -o -g workaround seemed to work because it was using git diffs (and thus likely a different code path), this case should probably be tested with a git repository as well to ensure that it doesn't exist there. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3067 in reviewboard: Parent diffs with mercurial are still broken
Comment #8 on issue 3067 by scherere...@gmail.com: Parent diffs with mercurial are still broken http://code.google.com/p/reviewboard/issues/detail?id=3067 Possible related issue, but it may be a different bug. I attempted to use the -o -g workaround and have encountered another edge case that fails: r4 [draft] : add file A (unrelated in content, but sharing the same name) r3 [draft] : miscelaneous r2 [draft] : remove file A r1 [draft] : file A present hg postreview r4 -o -g -i 'foo' File A will show 'diff unavailable' My original workaround (diff -r 0:r3) still worked in this scenario. I have not tested to see if r3 is necessary to the test. Since the -o -g workaround seemed to work because it was using git diffs (and thus likely a different code path), this case should probably be tested with a git repository as well to ensure that it doesn't exist there. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3105 in reviewboard: Can't post diffs containing non-ascii characters in file name
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3105 by leonid...@gmail.com: Can't post diffs containing non-ascii characters in file name http://code.google.com/p/reviewboard/issues/detail?id=3105 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be rejected. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? Review Board 1.7.14 What's the URL of the page containing the problem? http://192.168.238.129/r/new/ What steps will reproduce the problem? 1. Add file with russian name to repository 2. Create patch with TortoiseSVN 3. Try to add patch to review What is the expected output? What do you see instead? I expect new review but I get this message instead: 'ascii' codec can't decode byte 0xca in position 0: ordinal not in range(128) What operating system are you using? What browser? Review Board: Debian 6 Workstation: Windows 7 + Google Chrome (Version 30.0.1599.69 m) Please provide any additional information below. If I use english titles I get correct workflow (even if there is any russian word). So if I use russian titles I get error. It does not matter if I rename diff file. It's OK if russian words in the body of file. Attachments: Картинка 22.png.patch 551 bytes pic22.png.patch 551 bytes new.txt.patch 546 bytes screenshot.png 44.8 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
