Re: Issue 3440 in reviewboard: AssertionError displaying changes from diff rev 1 to 2
Updates: Status: PendingReview Owner: chip...@gmail.com Labels: -Priority-Medium Priority-Critical Milestone-Release2.0.x Component-DiffViewer Comment #2 on issue 3440 by chip...@gmail.com: AssertionError displaying changes from diff rev 1 to 2 http://code.google.com/p/reviewboard/issues/detail?id=3440 Up for review at https://reviews.reviewboard.org/r/6030/ -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3444 in reviewboard: Autocomplete is too aggressive
Updates: Status: Confirmed Labels: EasyFix Component-WebUI Project-ReviewBoard Comment #1 on issue 3444 by chip...@gmail.com: Autocomplete is too aggressive http://code.google.com/p/reviewboard/issues/detail?id=3444 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 413 in reviewboard: Make Dashboard columns resizable.
Updates: Labels: -Djblets Project-Djblets Comment #5 on issue 413 by chip...@gmail.com: Make Dashboard columns resizable. http://code.google.com/p/reviewboard/issues/detail?id=413 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
22 issues changed in reviewboard
Updates: Labels: Project-RBTools Comment by chip...@gmail.com: (No comment was entered for this change.) Affected issues: issue 421: Enhancement request: nag owners about stale review requests http://code.google.com/p/reviewboard/issues/detail?id=421 issue 607: post-review option to insert the review url into the changelist description http://code.google.com/p/reviewboard/issues/detail?id=607 issue 1026: RFE: Add ability to ignore files in a patch http://code.google.com/p/reviewboard/issues/detail?id=1026 issue 1551: post-review: need an option to not save the cookie http://code.google.com/p/reviewboard/issues/detail?id=1551 issue 1556: Add the ability to pass SVN username and password on post-review command line http://code.google.com/p/reviewboard/issues/detail?id=1556 issue 1771: Prevent users from creating reviews for P4 changelists they don't own http://code.google.com/p/reviewboard/issues/detail?id=1771 issue 2071: A review should inform about any binary files that may have been changed (CVS) http://code.google.com/p/reviewboard/issues/detail?id=2071 issue 2392: rbtools should provide a warning when svn files are out of date http://code.google.com/p/reviewboard/issues/detail?id=2392 issue 2398: post-review should determine the SCM Client based on repository type http://code.google.com/p/reviewboard/issues/detail?id=2398 issue 2533: post-review prefers /home/login/.git over /home/login/svn/.svn http://code.google.com/p/reviewboard/issues/detail?id=2533 issue 2733: Avoid review creation if diff upload fails http://code.google.com/p/reviewboard/issues/detail?id=2733 issue 2835: post-review fails if extraneous git-svn remote http://code.google.com/p/reviewboard/issues/detail?id=2835 issue 3164: rbt patch --commit should support wrapping commit message lines http://code.google.com/p/reviewboard/issues/detail?id=3164 issue 3172: Review Board diff is not the same as perforce diff after files are moved and resolved http://code.google.com/p/reviewboard/issues/detail?id=3172 issue 3174: compare clearcase label is not supported http://code.google.com/p/reviewboard/issues/detail?id=3174 issue 3176: post-review requests to a server with thousand of repo is very slow http://code.google.com/p/reviewboard/issues/detail?id=3176 issue 3179: add support for UCM clearcase activity http://code.google.com/p/reviewboard/issues/detail?id=3179 issue 3194: Automatically determine subversion branch http://code.google.com/p/reviewboard/issues/detail?id=3194 issue 3195: Enable rbt post --guess-summary for subversion http://code.google.com/p/reviewboard/issues/detail?id=3195 issue 3289: Support for pre-post hooks http://code.google.com/p/reviewboard/issues/detail?id=3289 issue 3389: 'rbt patch' should error out more gracefully if the patch doesn't apply cleanly. http://code.google.com/p/reviewboard/issues/detail?id=3389 issue 3421: RB Tools cannot create a review request for a changeset that belongs to a discarded review request http://code.google.com/p/reviewboard/issues/detail?id=3421 -- You received this message because you are listed in the owner or CC fields of these issues, or because you starred them. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3445 in reviewboard: ReviewRequest.get_last_activity() always returns the ReviewRequest itself
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3445 by marc2...@gmail.com: ReviewRequest.get_last_activity()
always returns the ReviewRequest itself
http://code.google.com/p/reviewboard/issues/detail?id=3445
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.
What version are you running?
Review Board 2.1 alpha 0 (dev)
What's the URL of the page containing the problem?
My local page.
What steps will reproduce the problem?
1. Add a review to a review request
2. Compare timestamps between the latest review and the last_updated field
on the review request
What is the expected output? What do you see instead?
ReviewRequest.get_last_activity() always returns the ReviewRequest itself
instead of any of the reviews. This is because the last_updated field on a
ReviewRequest gets set to a time after the latest review, so there is never
a review that is newer than the ReviewRequest itself.
What operating system are you using? What browser?
Ubuntu and Chrome
Please provide any additional information below.
I'm trying to write an extension that will display the last user to update
a review request. However, ReviewRequest.get_last_activity() keeps
returning the ReviewRequest itself, so it always displays the submitter's
name.
I made an update as a different user than the one I submitted with and got
this:
$ python reviewboard/manage.py shell
...
from reviewboard.reviews.models.review_request import ReviewRequest as
RR
RR.objects.all()
[ReviewRequest: Test1]
rr = RR.objects.all()[0]
r = rr.reviews.filter(public=True).latest()
r
Review: Review of 'Test1'
r.timestamp
datetime.datetime(2014, 6, 26, 19, 46, 45, 65830, tzinfo=UTC)
rr.last_updated
datetime.datetime(2014, 6, 26, 19, 46, 45, 153334, tzinfo=UTC)
Here is the code I was playing with:
extension.py:
class LastUpdatedByColumn(Column):
def render_data(self, stateful_column, review_request):
timestamp, updated_object = review_request.get_last_activity()
if hasattr(updated_object, 'user'):
return updated_object.user.username
elif hasattr(updated_object, 'submitter'):
return updated_object.submitter.username
return '??? %s' % updated_object.__class__.__name__
class LastUpdatedBy(Extension):
metadata = {
'Name': 'LastUpdatedBy',
'Summary': 'A column that displays who the last user was to update
a review request.',
}
def initialize(self):
DashboardColumnsHook(self, [
LastUpdatedByColumn(id='lastUpdatedBy',
label='Last Updated',
detailed_label='Last Updated By'),
shrink=True),
])
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Issue 3446 in reviewboard: ReviewRequestFieldsHook and email notfications
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3446 by ke...@keithmoyer.com: ReviewRequestFieldsHook and email notfications http://code.google.com/p/reviewboard/issues/detail?id=3446 What version are you running? 2.0.2 What's the URL of the page this enhancement relates to, if any? email notifications Describe the enhancement and the motivation for it. ReviewBoard 2.0 added extensibility for adding custom fields to a review request. We've embraced that and included a couple of important-to-us fields. It would fantastic if our field hook could also indicate to be included in the various review request notification emails, alongside the description, testing, diffs, bugs, etc. What operating system are you using? What browser? Windows 7, Firefox 29 Please provide any additional information below. The rendered value would be preferred over the text value of the field. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
