Re: Issue 3607 in reviewboard: 4-tab indentation reduced to 3-tabs in diff viewer

2014-10-07 Thread reviewboard

Updates:
Status: ThirdParty

Comment #1 on issue 3607 by trowb...@gmail.com: 4-tab indentation reduced  
to 3-tabs in diff viewer

https://code.google.com/p/reviewboard/issues/detail?id=3607

This looks like a chrome bug. The markup is correct, and as you noted, it  
only seems to reproduce on chrome+osx.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3608 in reviewboard: Some comments do not appear on the review while is posted.

2014-10-07 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3608 by sivakuma...@gmail.com: Some comments do not appear on the  
review while is posted.

https://code.google.com/p/reviewboard/issues/detail?id=3608

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What operating system are you using? What browser?


Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3608 in reviewboard: Some comments do not appear on the review while is posted.

2014-10-07 Thread reviewboard

Updates:
Status: Invalid

Comment #1 on issue 3608 by trowb...@gmail.com: Some comments do not appear  
on the review while is posted.

https://code.google.com/p/reviewboard/issues/detail?id=3608

We need you to fill out the form or we can't do anything.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3604 in reviewboard: error at install time

2014-10-07 Thread reviewboard


Comment #2 on issue 3604 by makowski...@gmail.com: error at install time
https://code.google.com/p/reviewboard/issues/detail?id=3604

I know, and I have all the dependencies


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3602 in reviewboard: Master bug: Plain text is rendered incorrectly when escaping for Markdown.

2014-10-07 Thread reviewboard


Comment #2 on issue 3602 by jamesd...@gmail.com: Master bug: Plain text is  
rendered incorrectly when escaping for Markdown.

https://code.google.com/p/reviewboard/issues/detail?id=3602

Steps to reproduce:
1. Create a review request.
2. Enter the following description:


1. Lorem ipsum:
   Blah blah blah
2. Lorem ipsum:
   Blah blah blah


Result:
The description gets transformed into:
1. Lorem ipsum:
Blah blah blah
2. Lorem ipsum:
Blah blah blah

This doesn't seem to happen with bulleted list items with *.

(This is with Review Board 2.0.6, but I also reproduced it on  
demo.reviewboard.org which is currently running 2.1 alpha 0.)



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3599 in reviewboard: certain search string causes "Error 500"

2014-10-07 Thread reviewboard


Comment #1 on issue 3599 by dccar...@gmail.com: certain search string  
causes "Error 500"

https://code.google.com/p/reviewboard/issues/detail?id=3599

In order to allow our deployment to begin, I protected the code in  
question.  It will return "Unknown (%s)" % user, if 'user' is a string  
instead of an object with the "get_full_name()" method.


Now, I get the expected matches, and also a few of these (just the last  
line that gives the time and user):


NaN years, NaN months ago by Unknown ()

Apparently, I have a few bogus requests in my database.  I'll see if I can  
find and remove them.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3609 in reviewboard: Error displaying diff, wrapping index char traceback

2014-10-07 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3609 by csmay...@gmail.com: Error displaying diff, wrapping index  
char traceback

https://code.google.com/p/reviewboard/issues/detail?id=3609

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?
2.0.8

What's the URL of the page containing the problem?
http://.cisco.com/r/10256/diff/#

What steps will reproduce the problem?
1. Haven't figured out the exact parameters in which certain file diffs  
aren't displayed. It is happening fairly often though.

2. In one case, there was a large diff that had a piece:
+goto error;
+}
 /*

which would work fine, but when changed, removing a trailing space, to:

+goto error;
+}
+/*

it would blow up.


What is the expected output? What do you see instead?
Expect to see the diff of a file.
Instead, see
 There was an error displaying this diff.
string index out of range

Traceback (most recent call last):
   
File "/local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.8-py2.7.egg/reviewboard/diffviewer/views.py",  
line 236, in get

renderer = self.create_renderer(context, *args, **kwargs)
   
File "/local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.8-py2.7.egg/reviewboard/reviews/views.py",  
line 1088, in create_renderer

*args, **kwargs)
   
File "/local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.8-py2.7.egg/reviewboard/diffviewer/views.py",  
line 328, in create_renderer

self.diff_file = self._get_requested_diff_file()
   
File "/local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.8-py2.7.egg/reviewboard/diffviewer/views.py",  
line 369, in _get_requested_diff_file

request=self.request)
   
File "/local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.8-py2.7.egg/reviewboard/diffviewer/diffutils.py",  
line 383, in populate_diff_chunks

chunks = generator.get_chunks()
   
File "/local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.8-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",  
line 153, in get_chunks

large_data=True)
   
File "/local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/Djblets-0.8.11-py2.7.egg/djblets/cache/backend.py",  
line 111, in cache_memoize

data = lookup_callable()
   
File "/local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.8-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",  
line 152, in 

lambda: list(self._get_chunks_uncached()),
   
File "/local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.8-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",  
line 266, in _get_chunks_uncached

a[i1:i2], b[j1:j2], old_lines, new_lines)
   
File "/local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.8-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",  
line 377, in _diff_line

old_markup, new_markup, *indentation_change)
   
File "/local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.8-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",  
line 425, in _highlight_indentation

self._serialize_unindentation)
   
File "/local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.8-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",  
line 441, in _wrap_indentation_chars

while markup[start_pos] == '<':
IndexError: string index out of range

What operating system are you using? What browser?
Windows 7, Firefox 32.0.3, IE 10

Please provide any additional information below.

Maybe 1 in a couple hundred files are getting tracebacks instead of  
displaying their diffs after upgrading from 1.7.26 to 2.0.6 (and later to  
2.0.8). Tracebacks would indicate an issue in the chunk_generator code.  
Diffs seem to be fine internally, just bombing when trying to display, as  
per logs.


There is supposedly one user on another team who is using IE (version ???)  
and can see the diff just fine. Not working on my IE, Firefox, or anyone  
else I can find's system. Strange to me that the browser w

Re: Issue 3599 in reviewboard: certain search string causes "Error 500"

2014-10-07 Thread reviewboard


Comment #2 on issue 3599 by dccar...@gmail.com: certain search string  
causes "Error 500"

https://code.google.com/p/reviewboard/issues/detail?id=3599

In order to allow our deployment to begin, I protected the code in  
question.  It will return "Unknown (%s)" % user, if 'user' is a string  
instead of an object with the "get_full_name()" method.


Now, I get the expected matches, and also a few of these (just the last  
line that gives the time and user):


NaN years, NaN months ago by Unknown ()

Apparently, I have a few corrupted requests in my database.  How might I go  
about finding them?  When I look at "Review Requests" under  
admin->Database->Reviews->ReviewRequests, I see only requests with real  
users and real dates.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3604 in reviewboard: error at install time

2014-10-07 Thread reviewboard


Comment #3 on issue 3604 by trowb...@gmail.com: error at install time
https://code.google.com/p/reviewboard/issues/detail?id=3604

The 'collectstatic' management command actually seems to be part of the  
django package. What version of django do you have installed?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3385 in reviewboard: Error 500 while trying to login when two url point to the same site

2014-10-07 Thread reviewboard


Comment #5 on issue 3385 by wdaog...@gmail.com: Error 500 while trying to  
login when two url point to the same site

https://code.google.com/p/reviewboard/issues/detail?id=3385

There's no problem since i changed mysql database default character  
encoding into utf-8.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3585 in reviewboard: Post a comment containing Chinese charaters to a diff in reviewboard will faill !

2014-10-07 Thread reviewboard


Comment #3 on issue 3585 by wdaog...@gmail.com: Post a comment containing  
Chinese charaters to a diff in reviewboard  will faill !

https://code.google.com/p/reviewboard/issues/detail?id=3585

There's no problem since i changed mysql database default character  
encoding into utf-8.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3610 in reviewboard: rbt post --summary="不能用中文" in windows7 ,It cannot send any Chinese characters .

2014-10-07 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3610 by wdaog...@gmail.com: rbt post --summary="不能用中文"  in  
windows7 ,It cannot send any Chinese characters .

https://code.google.com/p/reviewboard/issues/detail?id=3610

When i use rbt post --summary="不能用中文" in windows7/dos, there will be  
some wrong characters in the summary . i use fiddle to intercept the  
sending request , I discovered the sending request containging invalid  
characters.



os: window 7 (Language:Chinese)
dos: Microsoft Windows 6.1.7601
RBTools: 0.6.2
python:Python 2.7.3


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3604 in reviewboard: error at install time

2014-10-07 Thread reviewboard


Comment #4 on issue 3604 by makowski...@gmail.com: error at install time
https://code.google.com/p/reviewboard/issues/detail?id=3604

yes it is, and I have it. The build is made with Django 1.7, but I saw that  
Arch have or had the same issue, or can it be an issue with missing  
lesscss ?
Strange because Fedora don't add this dependency in their package  
(http://pkgs.fedoraproject.org/cgit/python-djblets.git/tree/python-djblets.spec)



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.