Issue 3731 in reviewboard: Make it possible to selectively activate and deactivate ExtensionHooks

2015-01-20 Thread reviewboard

Status: Accepted
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 3731 by mike.d.c...@gmail.com: Make it possible to selectively  
activate and deactivate ExtensionHooks

https://code.google.com/p/reviewboard/issues/detail?id=3731

*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this enhancement request!


What version are you running?

2.0.12


What's the URL of the page this enhancement relates to, if any?

N/A

Describe the enhancement and the motivation for it.

We have a rather complicated extension, and there are bits of it that we'll  
be able to turn on and off in the configuration page for the extension.  
It'd be nice if we could make it simple to take a series of ExtensionHooks  
and disable them, and then re-enable them when later. Right now, I believe  
if an ExtensionHook has had shutdown called on it before an extension shuts  
down, the hook will not be removed from the Extension's hook set. If the  
Extension shuts down, it will attempt to shutdown an already shutdown  
ExtensionHook, and I believe that will cause an assertion failure (shutdown  
asserts that self.initialized is True).


There's also not a great way to turn the ExtensionHook back on once  
shutdown.



What operating system are you using? What browser?

OS X 10.9, Firefox 38


Please provide any additional information below.



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3730 in reviewboard: "summary" field not present in Review Request API

2015-01-20 Thread reviewboard

Updates:
Status: NotABug

Comment #1 on issue 3730 by trowb...@gmail.com: "summary" field not present  
in Review Request API

https://code.google.com/p/reviewboard/issues/detail?id=3730

This is the expected behavior. Any "field" which is itself a resource is  
presented as a link. You can include it inline by using ?expand=submitter


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3730 in reviewboard: "summary" field not present in Review Request API

2015-01-20 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3730 by mrcote: "summary" field not present in Review Request API
https://code.google.com/p/reviewboard/issues/detail?id=3730

What version are you running?

2.0.12

What's the URL of the page containing the problem?

/api/review-requests/*/

What steps will reproduce the problem?

Load the review-requests API for any review request.

What is the expected output? What do you see instead?

The documentation  
(https://www.reviewboard.org/docs/manual/2.0/webapi/2.0/resources/review-request/#webapi2.0-review-request-resource)  
indicates that there should be a "submitter" field, but it is missing in  
the JSON output.  There is a links.submitter field, however.


What operating system are you using? What browser?

OS X, curl 7.37.1.

Please provide any additional information below.

Not sure if the problem is in the docs or the API, but note that the  
example at the bottom of the doc  
(https://www.reviewboard.org/docs/manual/2.0/webapi/2.0/resources/review-request/#examples)  
is also missing the submitter field.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3729 in reviewboard: Cannot run rbt post in RBTools 0.7.0

2015-01-20 Thread reviewboard


Comment #1 on issue 3729 by bruce.c...@gmail.com: Cannot run rbt post in  
RBTools 0.7.0

https://code.google.com/p/reviewboard/issues/detail?id=3729

I'm seeing this as well: I'm running Windows 8.1 Update.
If I rename the svn binary, then it tries to run "hg root" and fails  
instead.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3729 in reviewboard: Cannot run rbt post in RBTools 0.7.0

2015-01-20 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3729 by tanists...@gmail.com: Cannot run rbt post in RBTools 0.7.0
https://code.google.com/p/reviewboard/issues/detail?id=3729

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?
RBTools 0.7

What's the URL of the page containing the problem?
rbt post

What steps will reproduce the problem?
(I think you have to set some unicode strings to the environment variables  
to reproduce this problem)

1. rbt post

What is the expected output? What do you see instead?
CRITICAL: environment can only contain strings

What operating system are you using? What browser?
Windows 7 SP1

Please provide any additional information below.
As the attachments.


Attachments:
env1.png  55.2 KB
rbtools.png  40.7 KB
env2.png  15.1 KB
env.txt  3.1 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.