Re: Issue 3732 in reviewboard: rbt post is generating diff against origin/master when on a local feature branch
Comment #2 on issue 3732 by ondr...@salsitasoft.com: rbt post is generating diff against origin/master when on a local feature branch https://code.google.com/p/reviewboard/issues/detail?id=3732 So there is no way to just take arbitrary commit and upload it to Review Board? I mean, just type `rbt post HASH` and that's it, without having to review the whole parent diff? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3717 in reviewboard: Get e-mail notifications for my own activity - still getting emails with my ShipIt
Comment #2 on issue 3717 by imcmy...@gmail.com: Get e-mail notifications for my own activity - still getting emails with my ShipIt https://code.google.com/p/reviewboard/issues/detail?id=3717 Currently working with this. Mingyi -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3734 in reviewboard: review reply diff_comment URI template eclipses review diff_comment URI template in RBClient
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3734 by mrcote: review reply diff_comment URI template eclipses review diff_comment URI template in RBClient https://code.google.com/p/reviewboard/issues/detail?id=3734 What version are you running? 2.0.12 What's the URL of the page containing the problem? It's a problem with the RBClient package when calling root.get_diff_comments(). What steps will reproduce the problem? 1. Create a review request. 2. Create a review on that review request and open an issue. 3. Use RBClient to try to get the diff_comment for that review in order to get the issue_open_count via root.get_diff_comments(). What is the expected output? What do you see instead? I should only have to provide review_request_id and review_id in order to get to the diff_comment. Instead, I get ValueError: Template was not provided a value for 'reply_id' smacleod says this is because there are diff_comment resources for both reviews and review replies, and that there is only a URI template created for the latter. So there is no direct way to get to the review's diff_comment; instead, I have to get the review and then call get_diff_comments() on the review resource. What operating system are you using? What browser? OS X, Python 2.7.9. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3730 in reviewboard: summary field not present in Review Request API
Comment #2 on issue 3730 by mrcote: summary field not present in Review Request API https://code.google.com/p/reviewboard/issues/detail?id=3730 Hm okay. This is very not clear in the API documentation in the way it is currently presented. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3735 in reviewboard: review reply diff_comment URI template eclipses review diff_comment URI template in RBClient
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3735 by mrcote: review reply diff_comment URI template eclipses review diff_comment URI template in RBClient https://code.google.com/p/reviewboard/issues/detail?id=3735 What version are you running? 2.0.12 What's the URL of the page containing the problem? It's a problem with the RBClient package when calling root.get_diff_comments(). What steps will reproduce the problem? 1. Create a review request. 2. Create a review on that review request and open an issue. 3. Use RBClient to try to get the diff_comment for that review in order to get the issue_open_count via root.get_diff_comments(). What is the expected output? What do you see instead? I should only have to provide review_request_id and review_id in order to get to the diff_comment. Instead, I get ValueError: Template was not provided a value for 'reply_id' smacleod says this is because there are diff_comment resources for both reviews and review replies, and that there is only a URI template created for the latter. So there is no direct way to get to the review's diff_comment; instead, I have to get the review and then call get_diff_comments() on the review resource. What operating system are you using? What browser? OS X, Python 2.7.9. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3737 in reviewboard: Code refactoring for def.less on review-request-action color
Updates: Labels: -Type-Enhancement Type-Task EasyFix Component-WebUI Comment #1 on issue 3737 by trowb...@gmail.com: Code refactoring for def.less on review-request-action color https://code.google.com/p/reviewboard/issues/detail?id=3737 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3711 in reviewboard: checkbox label wraps onto its own line
Comment #2 on issue 3711 by jess...@gmail.com: checkbox label wraps onto its own line https://code.google.com/p/reviewboard/issues/detail?id=3711 I will work on this one. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3734 in reviewboard: review reply diff_comment URI template eclipses review diff_comment URI template in RBClient
Comment #1 on issue 3734 by trowb...@gmail.com: review reply diff_comment URI template eclipses review diff_comment URI template in RBClient https://code.google.com/p/reviewboard/issues/detail?id=3734 Issue 3735 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3733 in reviewboard: Diff Size column should use a non-breaking space.
Updates: Status: Fixed Comment #3 on issue 3733 by trowb...@gmail.com: Diff Size column should use a non-breaking space. https://code.google.com/p/reviewboard/issues/detail?id=3733 Fixed in release-2.0.x (dd58acd). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3737 in reviewboard: Code refactoring for def.less on review-request-action color
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3737 by jtsen...@gmail.com: Code refactoring for def.less on review-request-action color https://code.google.com/p/reviewboard/issues/detail?id=3737 What version are you running? 2.0.13 alpha What's the URL of the page this enhancement relates to, if any? all Describe the enhancement and the motivation for it. Several duplicated references of same css definition that makes the code confusing and without obvious code clarifying benefit What operating system are you using? What browser? Mac OSX - Chrome, Firefox Please provide any additional information below. Code in reference - def.less @review-request-actions-bg: @review-request-action-primary-bg; @review-request-actions-border-color: darken(@review-request-action-primary-bg, 40%); @review-request-action-bg: #E5D7A8; @review-request-action-border-color: @review-request-actions-border-color; @review-request-action-active-bg: darken(@review-request-action-bg, 20%); @review-request-action-hover-bg: darken(@review-request-action-bg, 12%); @review-request-action-primary-bg: @review-request-action-bg; @review-request-action-primary-active-bg: @review-request-action-active-bg; @review-request-action-primary-hover-bg: @review-request-action-hover-bg; @review-request-action-menu-border-color: @review-request-actions-border-color; @review-request-action-menu-bg: @review-request-action-active-bg; @review-request-action-menu-item-hover-bg: @review-request-action-hover-bg; -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3737 in reviewboard: Code refactoring for def.less on review-request-action color
Comment #2 on issue 3737 by justw...@gmail.com: Code refactoring for def.less on review-request-action color https://code.google.com/p/reviewboard/issues/detail?id=3737 I'll look at this. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3733 in reviewboard: Diff Size column should use a non-breaking space.
Comment #2 on issue 3733 by yyou...@gmail.com: Diff Size column should use a non-breaking space. https://code.google.com/p/reviewboard/issues/detail?id=3733 I am fixing it. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
