Re: Issue 3776 in reviewboard: Problems with excluding files for diff/post with SVN

2015-03-03 Thread reviewboard

Updates:
Status: Started
Owner: bar...@beanbaginc.com
Labels: Milestone-RBTools-Release0.7.x SCM-Subversion

Comment #1 on issue 3776 by bar...@beanbaginc.com: Problems with excluding  
files for diff/post with SVN

https://code.google.com/p/reviewboard/issues/detail?id=3776

Hi Griffin, I've started working on this as  
https://reviews.reviewboard.org/r/7000.


I'm trying to reproduce your first issue, but cannot seem to get SVN to  
checkout a subdirectory of my repository. Running the command:


svn co file:///repos/my_repo/trunk/ trunk_checkout

Results in the following error:

svn: E17: URL 'file:///repos/my_repo/trunk' doesn't exist

If you could point out how to reproduce your setup, that would be very  
helpful.


Regards,
Barret

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3790 in reviewboard: RB not able to open local git repo on Windows

2015-03-03 Thread reviewboard

Updates:
Status: Fixed

Comment #1 on issue 3790 by trowb...@gmail.com: RB not able to open local  
git repo on Windows

https://code.google.com/p/reviewboard/issues/detail?id=3790

Fixed in release-2.0.x (9e2da0c). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3789 in reviewboard: UnicodeDecodeError: 'ascii' codec can't decode byte 0xe4 in position 92: ordinal not in range(128) sending an email on Windows

2015-03-03 Thread reviewboard

Updates:
Status: Fixed

Comment #1 on issue 3789 by  
trowb...@gmail.com: UnicodeDecodeError: 'ascii' codec can't decode byte  
0xe4 in position 92: ordinal not in range(128) sending an email on Windows

https://code.google.com/p/reviewboard/issues/detail?id=3789

Fixed in release-2.0.x (41e81a7). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3792 in reviewboard: Outlook message (.msg extension) upload fails in 2.0.13

2015-03-03 Thread reviewboard

Updates:
Status: Started
Owner: trowb...@gmail.com
Labels: Project-ReviewBoard Component-Attachments

Comment #6 on issue 3792 by trowb...@gmail.com: Outlook message (.msg  
extension) upload fails in 2.0.13

https://code.google.com/p/reviewboard/issues/detail?id=3792

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3203 in reviewboard: rbt doesn't authenticate some requests

2015-03-03 Thread reviewboard


Comment #2 on issue 3203 by ethan54: rbt doesn't authenticate some requests
https://code.google.com/p/reviewboard/issues/detail?id=3203

I ran into the same issue with the latest version of rbt (0.7.2).

See the attached status -d log. As the user says above,  
PresetHTTPAuthHandler only sends the Basic authentication on the first  
request. By forcing it to attach the authentication to every request, I was  
able to get things to work. It's unclear if this breaks other server  
configurations.


Attachments:
rbtdebug.txt  3.2 KB
rbt-3203.patch  721 bytes

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3796 in reviewboard: Internal Error deleting review due to character encoding.

2015-03-03 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3796 by msu...@aurea.com: Internal Error deleting review due to  
character encoding.

https://code.google.com/p/reviewboard/issues/detail?id=3796

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?
2.0.13 with bug fix: #3784

What's the URL of the page containing the problem?
http://review.XX/r/991/

What steps will reproduce the problem?
1. When viewing the review.
2. Select close / delete permanently
3. Nothing happens.
4. Check logs, there is an error.

What is the expected output? What do you see instead?
Review would be deleted.

What operating system are you using? What browser?
Amazon Linux, Google Chrome.

Please provide any additional information below.
Here is the stack trace from the logs:

2015-03-04 04:51:55,802 - ERROR -  - Exception thrown for user  at  
http://review.XX/api/review-requests/991/?api_format=jsonforce-text-type=htmlinclude-text-types=raw


'ascii' codec can't decode byte 0xc3 in position 22: ordinal not in  
range(128)

Traceback (most recent call last):
   
File /usr/lib/python2.6/site-packages/Django-1.6.9-py2.6.egg/django/core/handlers/base.py,  
line 112, in get_response

response = wrapped_callback(request, *callback_args, **callback_kwargs)
   
File /usr/lib/python2.6/site-packages/Django-1.6.9-py2.6.egg/django/views/decorators/cache.py,  
line 52, in _wrapped_view_func

response = view_func(request, *args, **kwargs)
   
File /usr/lib/python2.6/site-packages/Django-1.6.9-py2.6.egg/django/views/decorators/vary.py,  
line 19, in inner_func

response = func(*args, **kwargs)
   
File /usr/lib/python2.6/site-packages/Djblets-0.8.15-py2.6.egg/djblets/webapi/resources.py,  
line 497, in __call__

request, method, view, api_format=api_format, *args, **kwargs)
   
File /usr/lib/python2.6/site-packages/Djblets-0.8.15-py2.6.egg/djblets/webapi/resources.py,  
line 568, in call_method_view

return view(request, *args, **kwargs)
   
File /usr/lib/python2.6/site-packages/Djblets-0.8.15-py2.6.egg/djblets/util/decorators.py,  
line 78, in _call

f = augmented_func(*args, **kwargs)
   
File /usr/lib/python2.6/site-packages/Djblets-0.8.15-py2.6.egg/djblets/webapi/decorators.py,  
line 117, in _call

return view_func(*args, **kwargs)
   
File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.13-py2.6.egg/reviewboard/webapi/decorators.py,  
line 31, in _check

return webapi_login_required(view_func)(*args, **kwargs)
   
File /usr/lib/python2.6/site-packages/Djblets-0.8.15-py2.6.egg/djblets/webapi/decorators.py,  
line 117, in _call

return view_func(*args, **kwargs)
   
File /usr/lib/python2.6/site-packages/Djblets-0.8.15-py2.6.egg/djblets/webapi/decorators.py,  
line 138, in _checklogin

return view_func(*args, **kwargs)
   
File /usr/lib/python2.6/site-packages/Djblets-0.8.15-py2.6.egg/djblets/webapi/decorators.py,  
line 117, in _call

return view_func(*args, **kwargs)
   
File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.13-py2.6.egg/reviewboard/webapi/decorators.py,  
line 110, in _check

return view_func(*args, **kwargs)
   
File /usr/lib/python2.6/site-packages/Djblets-0.8.15-py2.6.egg/djblets/util/decorators.py,  
line 78, in _call

f = augmented_func(*args, **kwargs)
   
File /usr/lib/python2.6/site-packages/Djblets-0.8.15-py2.6.egg/djblets/webapi/decorators.py,  
line 117, in _call

return view_func(*args, **kwargs)
   
File /usr/lib/python2.6/site-packages/Djblets-0.8.15-py2.6.egg/djblets/webapi/resources.py,  
line 789, in get

etag = self.get_etag(request, obj)
   
File /usr/lib/python2.6/site-packages/Djblets-0.8.15-py2.6.egg/djblets/webapi/resources.py,  
line 1264, in get_etag

encode_etag=False)
   
File /usr/lib/python2.6/site-packages/Djblets-0.8.15-py2.6.egg/djblets/webapi/resources.py,  
line 1302, in generate_etag

values.append(six.text_type(getattr(obj, field)))
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 22:  
ordinal not in range(128)





Attachments:
2015-03-03_23-53-22.png  67.3 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 

Issue 3795 in reviewboard: Redirected back to page 1 of diff when clicking a file link in a multi-page diff

2015-03-03 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3795 by griffin@gmail.com: Redirected back to page 1 of diff  
when clicking a file link in a multi-page diff

https://code.google.com/p/reviewboard/issues/detail?id=3795

What version are you running?
2.0.13 or 2.5 alpha 0 (dev)

What's the URL of the page containing the problem?
Any review request where the diff has been split across multiple pages.
For example: https://reviews.reviewboard.org/r/6925/diff/1/?page=2

What steps will reproduce the problem?
1. Navigate to https://reviews.reviewboard.org/r/6925/
2. Click View Diff
3. Click 2 at the bottom of the File Index to advance to page 2 of the  
review request.
4. Click the link for any file in the File Index.  For instance  
reviewboard/diffviewer/testdata/new_src/README which is near the middle of  
the list.  Hovering over this link shows  
https://reviews.reviewboard.org/r/6925/diff/1/?page=2#29 as the target
5. We advance momentarily to the README file as expected and then  
are redirected back page 1 of the review request.


What is the expected output? What do you see instead?
Expect to advance to the selected file and stay there.  Always seem to be  
redirected back to the first page.  Since this is a dynamic issue I don't  
know how to capture it via a screen shot, but I can attempt to capture a  
video if that would be informative.


What operating system are you using? What browser?
Windows
Firefox 36.0

Please provide any additional information below.
This may be a Firefox specific issue as I can not replicate it in IE.  The  
review request that I used as an example has a bunch of deleted files, but  
I don't think that has anything to do with this.  I have been able to  
repeat this on multiple review requests on multiple different RB severs.   
The only commonality is that I'm always using Firefox.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3674 in reviewboard: rbt post crashes for Subversion post-commit with revision range and empty file

2015-03-03 Thread reviewboard

Updates:
Status: Fixed
Owner: bar...@beanbaginc.com

Comment #2 on issue 3674 by bar...@beanbaginc.com: rbt post crashes for  
Subversion post-commit with revision range and empty file

https://code.google.com/p/reviewboard/issues/detail?id=3674

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3794 in reviewboard: Rendering issue when viewing All Review Requests with Diff Size column enabled

2015-03-03 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3794 by griffin@gmail.com: Rendering issue when viewing All  
Review Requests with Diff Size column enabled

https://code.google.com/p/reviewboard/issues/detail?id=3794

What version are you running?
2.0.13 or 2.5 alpha 0 (dev)

What's the URL of the page containing the problem?
https://reviews.reviewboard.org/r/?columns=review_id%2Cstar%2Cship_it%2Csummary%2Csubmitter%2Ctime_added%2Clast_updated_since%2Crepository%2Cdiff_sizegridonly=1datagrid-id=datagrid-0page=5

What steps will reproduce the problem?
1. Navigate to https://reviews.reviewboard.org/r/
2. Click 3 at bottom of page to advance to page 3 (this step is not  
critical, and just illustrates that advancing pages nominally works).

3. Edit columns to add Diff Size column
4. Click 5 at bottom of page to advance to page 5

What is the expected output? What do you see instead?
Page is rendered incorrectly, see attached screenshot.

What operating system are you using? What browser?
Windows
Firefox 36.0
IE 11.0.9600.17633

Please provide any additional information below.
I'm not sure this has anything to do specifically with Diff Size.  I can  
repeat this with a variety of other columns as well.



Attachments:
Capture.PNG  71.8 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3776 in reviewboard: Problems with excluding files for diff/post with SVN

2015-03-03 Thread reviewboard


Comment #2 on issue 3776 by griffin@gmail.com: Problems with excluding  
files for diff/post with SVN

https://code.google.com/p/reviewboard/issues/detail?id=3776

Barret,

Here is a simple bash script that should illustrate what you need:

###
#!/bin/bash
set -x

svnadmin create /tmp/testrepo
mkdir foo
cd foo
mkdir trunk branches tags
echo test  trunk/a.txt
svn import . file:///tmp/testrepo -m initial commit
cd ..
svn co file:///tmp/testrepo/trunk foo_trunk_wc
cd foo_trunk_wc
echo stuff  a.txt
rbt diff --server 127.0.0.1:8080 -X a.txt
cd ..
svn co file:///tmp/testrepo foo_root_wc
cd foo_root_wc
echo stuff  trunk/a.txt
rbt diff --server 127.0.0.1:8080 -X trunk/a.txt
cd trunk
rbt diff --server 127.0.0.1:8080 -X a.txt
##


This will create a repo with trunk, branches, and tags directories in the  
root.  Then it will checkout trunk and perform an `rbt diff` with  
exclusion.  For completeness it also checks out the root and performs the  
diff again, and then a third time in the trunk subdirectory from the root  
checkout.  With respect to the first issue, the initial`rbt diff` execution  
is where the exclusion fails while the other instances work correctly.


Incidentally, when I test this against rev 5 of review request 7000  
everything works as expected.  I'll be adding feedback there soon.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.