Issue 3955 in reviewboard: circular dependency between reviews makes review request un-updatable (500 errors)

2015-09-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3955 by christop...@delphix.com: circular dependency between  
reviews makes review request un-updatable (500 errors)

https://code.google.com/p/reviewboard/issues/detail?id=3955

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?

2.0.19

What's the URL of the page containing the problem?

https://reviews.csiden.org/r/236/

What steps will reproduce the problem?
1. Create a new review request.
2. In the 'Depends On' field input the id of the review request itself  
(e.g. in the above link request 236 'depends on' request 236.

3. Publish the review (this works fine).
4. Try to update the description of the review after publishing, or upload  
a new diff and try to publish the new diff by pressing 'Publish Changes',  
neither works.


NOTE: The issue seems to occur with any circular dependency between review  
requests, e.g. if 237 'depends on' 238 and 238 'depends on' 237, the same  
issue occurs when publishing updates to both 237 and 238.


What is the expected output? What do you see instead?

I expect the review to be published, instead the page hangs until I  
navigate to a different page or reload, looking at the webservice requests  
via chrome developer tools I see that I got back a 500 internal error:


Request  
URL:https://reviews.csiden.org/api/review-requests/236/draft/?api_format=json=html=raw=depends_on%2Ctarget_people%2Ctarget_groups

Request Method:GET
Status Code:500 INTERNAL SERVER ERROR

But the web page does not indicate that an error occured. If I try to  
discard the draft I also get an error.


Also no log message is printed to the logs about the 500 error.

What operating system are you using? What browser?

Chrome on linux, linux server.

Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3956 in reviewboard: review requests with file attachments get 500 errors after upgrade to 2.0.19

2015-09-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3956 by christop...@delphix.com: review requests with file  
attachments get 500 errors after upgrade to 2.0.19

https://code.google.com/p/reviewboard/issues/detail?id=3956

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?

2.0.19 recently upgraded from 2.0.16

What's the URL of the page containing the problem?

http:///r/12359/

What steps will reproduce the problem?
1. Try to load the review request.

What is the expected output? What do you see instead?

Instead of loading the page displays a 500 error. The error log shows:

2015-09-03 02:03:51,984 - ERROR -  - Exception thrown for user chris at  
http:///r/12359/


 is not JSON serializable
Traceback (most recent call last):
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/core/handlers/base.py",  
line 112, in get_response

response = wrapped_callback(request, *callback_args, **callback_kwargs)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/accounts/decorators.py",  
line 23, in _check

return view_func(*args, **kwargs)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/site/decorators.py",  
line 35, in _check

return view_func(request, local_site=local_site, *args, **kwargs)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/reviews/views.py",  
line 721, in review_detail

RequestContext(request, context_data))
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/shortcuts/__init__.py",  
line 29, in render_to_response
return HttpResponse(loader.render_to_string(*args, **kwargs),  
**httpresponse_kwargs)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/loader.py",  
line 164, in render_to_string

return t.render(Context(dictionary))
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 140, in render

return self._render(context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 134, in _render

return self.nodelist.render(context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 840, in render

bit = self.render_node(node, context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 854, in render_node

return node.render(context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/loader_tags.py",  
line 123, in render

return compiled_parent._render(context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 134, in _render

return self.nodelist.render(context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 840, in render

bit = self.render_node(node, context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 854, in render_node

return node.render(context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/loader_tags.py",  
line 123, in render

return compiled_parent._render(context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 134, in _render

return self.nodelist.render(context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 840, in render

bit = self.render_node(node, context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 854, in render_node

return node.render(context)
   
File 

Re: Issue 3956 in reviewboard: review requests with file attachments get 500 errors after upgrade to 2.0.19

2015-09-02 Thread reviewboard


Comment #1 on issue 3956 by christop...@delphix.com: review requests with  
file attachments get 500 errors after upgrade to 2.0.19

https://code.google.com/p/reviewboard/issues/detail?id=3956

I forgot to mention that I am unable to reproduce the issue after the  
upgrade (i.e. creating a new review request after the upgrade with a file  
attachment does not have the same problem).


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.