Re: Review Board Ticket #4450: ReviewRequest.last_review_activity_timestamp should be exposed in the API

2016-08-16 Thread Christian Hammond
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4450/
--

New update by samsun387
For Beanbag, Inc. > Review Board > Ticket #4450


Reply:

We don't really have a mechanism for queries like that today. We'd have to 
consider how that would work, but I don't think I can make any promises there. 
I mean, we could perhaps add a `?last-updated-or-review-activity-from=`, but 
that's sort of a slippery slope.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4451: Deleting all files in a review request should remove the "Files" section

2016-08-16 Thread Barret Rennie
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4451/
--

New update by brennie
For Beanbag, Inc. > Review Board > Ticket #4451


Milestones:
+ Release-2.5.x


Tags:
+ Component:Reviews

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Review Board Ticket #4451: Deleting all files in a review request should remove the "Files" section

2016-08-16 Thread Barret Rennie
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4451/
--

New ticket #4451 by brennie
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * empty_files.png
   



--
Deleting all files in a review request should remove the "Files" section
==

# What version are you running?
2.5.x+

# What's the URL of the page containing the problem?
r/XXX

# What steps will reproduce the problem?
1. Create a new review request draft on either
2. If there are no new files on the review request, upload one
3. Remove all files from the review request


# What is the expected output? What do you see instead?
The "Files" section should not be visible, but it is.

# What operating system are you using? What browser?
Any

# Please provide any additional information below.
See attached screenshot.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4451: Deleting all files in a review request should remove the "Files" section

2016-08-16 Thread Barret Rennie
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4451/
--

New update by brennie
For Beanbag, Inc. > Review Board > Ticket #4451


Tags:
+ EasyFix

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4450: ReviewRequest.last_review_activity_timestamp should be exposed in the API

2016-08-16 Thread Kevin Yu
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4450/
--

New update by samsun387
For Beanbag, Inc. > Review Board > Ticket #4450


Reply:

Thanks for the quick response. Yes I also tried to use the 
last_review_timestamp(the column name in db in reviewrequest table) but found 
out it's not available through API. It would be great if you can expose that.

With last_review_timestamp being exposed through API, is there a way to 
call the API so that it returns the review requests with either 
last_updated_from or last_review_timestamp within 24 hours, whichever is later? 
Otherwise I will make two api calls to get two lists of review request and 
combine them.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.